GNU bug report logs - #61308
28.2; icomplete --- Error in post-command-hook: wrong-type-argument

Previous Next

Full log

View this message in rfc822 format

From: Fernando de Morais <fernandodemorais.jf <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: 61308 <at> debbugs.gnu.org
Subject: bug#61308: 28.2; icomplete --- Error in post-command-hook: wrong-type-argument
Date: Wed, 08 Feb 2023 19:09:09 -0300

Hello Juri,

Juri Linkov <juri <at> linkov.net> writes:

> Interesting bug report.  I guess we need to double-check
> if we are still in the right buffer after help-window-select
> selects another window and thus confuses icomplete-mode:
>
> diff --git a/lisp/icomplete.el b/lisp/icomplete.el
> index 014f38b2024..97457832e2c 100644
> --- a/lisp/icomplete.el
> +++ b/lisp/icomplete.el
> @@ -686,6 +686,8 @@ icomplete-exhibit
>  Should be run via minibuffer `post-command-hook'.
>  See `icomplete-mode' and `minibuffer-setup-hook'."
>    (when (and icomplete-mode
> +             ;; Check if still in the right buffer (bug#61308)
> +             (or (window-minibuffer-p) completion-in-region--data)
>               (icomplete-simple-completing-p)) ;Shouldn't be necessary.
>      (let ((saved-point (point)))
>        (save-excursion

This solved the problem, thank you!  🤝

I hope this path gets merged upstream.

-- 
Regards,
Fernando de Morais.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.