GNU bug report logs - #61302
29.0.60; rust-ts-mode does not show function-invocation on field-properties

Previous Next

Full log

View this message in rfc822 format

From: Randy Taylor <dev <at> rjt.dev>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: eliz <at> gnu.org, 61302 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: bug#61302: 29.0.60; rust-ts-mode does not show function-invocation on field-properties
Date: Tue, 14 Feb 2023 12:39:32 +0000

[Message part 1 (text/plain, inline)]

On Tuesday, February 14th, 2023 at 06:42, Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> wrote:
>Haven given the latest patch a try on a less macro-ridden codebase I have to say it looks a lot better. In general I would say for this other code-base it looks favourable to rust-mode.
>
>If there's one thing which still seems to be done better in rust-mode (not nitpicking the variable highlighting), it would be fully namespaces function calls within classes.
>
>Consider the following code:
>
>extern crate claxon;
>let result = claxon::FlacReader::open(path);
>>While rust-ts-mode correctly identifies that open() is a function-call, rust-mode correctly identified FlacReader as a class.

Thanks for testing. I've attached a patch fixing this.

I had deleted a query I thought was now covered :). I look forward to the day we have highlight tests!

[Message part 2 (text/html, inline)]

[0001-Fix-rust-ts-mode-type-and-module-highlighting-Bug-61.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.