Subject: bug#61283: 29.0.60; pcomplete-completions-at-point loses text properties, breaking pcomplete-from-help annotations

From: Eli Zaretskii <[email-masked]>
Date: Thu, 18 May 2023 08:39:54 +0300

> Date: Thu, 18 May 2023 04:01:46 +0200
> Cc: Augusto Stoffel <[email-masked]>, Eli Zaretskii <[email-masked]>,
>  [email-masked], [email-masked]
> From: Daniel Mendler <[email-masked]>
> 
> Yes, this occurred to me too. I assume relying on the original string
> should work since quoting should not change the string. Options like
> "--color=" are not affected by quoting.
> 
> But this means that the following simple patch to `completion--twq-all'
> also fixes the issue. It ensures that the original string is preserved
> in the common case where string quoting was ineffective. This approach
> may be better than refactoring pcomplete.el. The patch may even be safe
> enough for emacs-29.

Why do you think it will be safe for emacs-29?

And why do we have to fix this in Emacs 29.1?  This only affects
Eshell, AFAIU, is that true?