From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 04 01:44:02 2023 Received: (at submit) by debbugs.gnu.org; 4 Feb 2023 06:44:02 +0000 Received: from localhost ([127.0.0.1]:40500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOCHJ-0000Fr-H0 for submit@debbugs.gnu.org; Sat, 04 Feb 2023 01:44:02 -0500 Received: from lists.gnu.org ([209.51.188.17]:59144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOCHI-0000Fk-1q for submit@debbugs.gnu.org; Sat, 04 Feb 2023 01:44:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOCHH-0001cR-JP for guix-patches@gnu.org; Sat, 04 Feb 2023 01:43:59 -0500 Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pOCHF-0008Ad-Sy for guix-patches@gnu.org; Sat, 04 Feb 2023 01:43:59 -0500 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4P82zm3X1Jz9sZr for ; Sat, 4 Feb 2023 07:43:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=reilysiegel.com; s=MBO0001; t=1675493028; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=S7Mw8FpIcvjAprreWijAdKtyngzOH7wDe0gaxjJuOFo=; b=0K9uO0tKkTHxFLcYq0EOgbPhlx3KRqRJ113sOmkzjL3iIf2jbYF7pFQT/sqqaSWt1jWlAt yCk7M6f2NvaWnQbEKAFbab+/K26+F7wnG3wkJocEt0D+IrGKQiQsQ7h+gEZhn4oOOBYSU1 o3ImaevrtteY+Rio1KhNFttKwhgvypuBpY2qaedTD3Q02TpejZ38FpKrGDYXsszN6ilA/q Nj5vFoj/KHGGC5/GxxHejf9tvTyRoncR1pt72s6FeAYfCExgPLLsdvriNOipkjoGaU0ATA 74X5VFEFI3L+OyQ7Q7lAUb5qe51I5YZv/kn0js4XyHURQLub43QkkZgWJ0vAhg== From: Reily Siegel To: guix-patches@gnu.org Subject: [PATCH 0/1] Add lint checker for unused module imports. Date: Sat, 4 Feb 2023 01:42:28 -0500 Message-ID: <87lelegcbm.fsf@reilysiegel.com> MIME-Version: 1.0 Content-Type: text/plain X-Rspamd-Queue-Id: 4P82zm3X1Jz9sZr Received-SPF: pass client-ip=2001:67c:2050:0:465::102; envelope-from=mail@reilysiegel.com; helo=mout-p-102.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Julien Lepiller writes (guix-devel): > Many modules seem to use a lot of imports that are actually useless, > for instance (gnu packages heads) imports 20 package modules, but > only uses 4 of them. > > Removing these module imports would help a lot with reducing the number > of loops. If anyone wants to volunteer a lint checker for that, > raise hands :D This is a quick and dirty implementation of such a lint checker. It compares the symbols used in a module to those provided by its dependencies. If there is a dependency for which none of the symbols overlap, a warning is reported. A potential downside of this approach is that the lint checker cannot distinguish between lexically scoped variables and variables which actually reference another module. This has two effects: - The implementation is slower, because lexically bound variables must also be checked - The implementation may fail to report an unused import if a lexical binding with the same name as one of the module's exports is used However, this does vastly simplify the implementation. Reily Siegel (1): lint: Add unused-modules linter. guix/lint.scm | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 63 insertions(+), 1 deletion(-) From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 04 02:37:52 2023 Received: (at control) by debbugs.gnu.org; 4 Feb 2023 07:37:52 +0000 Received: from localhost ([127.0.0.1]:40538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOD7Q-0003zH-Cb for submit@debbugs.gnu.org; Sat, 04 Feb 2023 02:37:52 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:41975) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOD7M-0003z2-3M for control@debbugs.gnu.org; Sat, 04 Feb 2023 02:37:51 -0500 Received: by mail-ed1-f65.google.com with SMTP id v10so7075789edi.8 for ; Fri, 03 Feb 2023 23:37:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:date:to:from :subject:message-id:from:to:cc:subject:date:message-id:reply-to; bh=zx1iTwnZA2uAgux3j0QqQavyGpKJ94mpCL/rgDYNgDw=; b=RILIhNsmL63WltX6nLz31Gh2i54Vfn60xAr/60TRSaYGMm6WoOi4OdGeP8yCuGBZ3Y 3GCWSbaGMOzXLZ9EGJUg7zDBbBxNzYBdV4AQsePN1u7ruumMRUt/CS6sHgIpOlbV1cie HZJOlevCK0M9fZpaf+h6QLwGy3/71CAZwCfr29/bbs3jR8F3tZMjQ8K+At5qBL+caKpS NiOiou0Y4MQ22nOF5uvmU9HIFenelZrlRR0J7bLJcrotQkPE14kjPaFw/8DTeIe4Llz3 y1qbvzGu+PKZwcgfQ+XaHMshG1cga7ENDLkna5jlUSQORh/5rS99yjyO/MIt/CEGeIAb S9KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:date:to:from :subject:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=zx1iTwnZA2uAgux3j0QqQavyGpKJ94mpCL/rgDYNgDw=; b=fMYZkhwpDAWpa4YVDLXOONFjbd6OaM5uoENfnSvDvSead9aUa3i0AMb/TeJ9cxfRtN spI9WFINhIGACbQtoUwuhTxHgHPR7/D4XDJZNkFVk4CAgYT36xYBTT+0bWLKgMieJfcU zF/JXIGl7kYwpSAQtZG7AMvICEAZyKkVFQZOdzZpAhsa/Cq8UK8XZddOMx3LJlHs7hjE b994pNho1LQz+HoczXFyExLTSFz7/cT3N8NTvNgvszVY139HRfjKavZNmWCxpMxfBz1T KDJnXa8+VSbVUM4tauhfVM1/HKttde52g5HP4KGh9S6VuJ2mAzTe1Oc/phy89oAw+779 KFOQ== X-Gm-Message-State: AO0yUKXt25epVQs3rKlUG7h/l1sXTGQGw5VHeHvrrMC5EKznpd94ilGj wk0L3l7JeWyDs8DxLjMcJZlZOr/r+j8= X-Google-Smtp-Source: AK7set/DtDf1h80skuq81Y8ioGbNUXrwcftPerLaHZz/Lexn47VenC2M3O0JpZt+dY/emZTPuSGrrA== X-Received: by 2002:a50:9fef:0:b0:45c:835b:ac64 with SMTP id c102-20020a509fef000000b0045c835bac64mr14244806edf.31.1675496262223; Fri, 03 Feb 2023 23:37:42 -0800 (PST) Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at. [85.127.52.93]) by smtp.gmail.com with ESMTPSA id b11-20020aa7c6cb000000b004a986403dc1sm1674039eds.1.2023.02.03.23.37.41 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 23:37:41 -0800 (PST) Message-ID: <322002423076ce48f8fbd0c74e59cdda565178c9.camel@gmail.com> Subject: From: Liliana Marie Prikler To: control@debbugs.gnu.org Date: Sat, 04 Feb 2023 08:37:40 +0100 Content-Type: text/plain Content-Transfer-Encoding: 7bit User-Agent: Evolution 3.46.0 MIME-Version: 1.0 X-Spam-Score: 3.3 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 61265 61266 thanks Content analysis details: (3.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liliana.prikler[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 1.3 RCVD_IN_VALIDITY_RPBL RBL: Relay in Validity RPBL, https://senderscore.org/blocklistlookup/ [209.85.208.65 listed in bl.score.senderscore.com] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.65 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.65 listed in list.dnswl.org] 2.0 BLANK_SUBJECT Subject is present but empty X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.3 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 61265 61266 thanks Content analysis details: (2.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.208.65 listed in wl.mailspike.net] 1.3 RCVD_IN_VALIDITY_RPBL RBL: Relay in Validity RPBL, https://senderscore.org/blocklistlookup/ [209.85.208.65 listed in bl.score.senderscore.com] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.208.65 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (liliana.prikler[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager merge 61265 61266 thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 05 08:08:10 2023 Received: (at control) by debbugs.gnu.org; 5 Feb 2023 13:08:10 +0000 Received: from localhost ([127.0.0.1]:44346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOekc-00057H-4m for submit@debbugs.gnu.org; Sun, 05 Feb 2023 08:08:10 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:36711) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOeka-000574-T8 for control@debbugs.gnu.org; Sun, 05 Feb 2023 08:08:09 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id D3CEE581DF4; Sun, 5 Feb 2023 08:08:03 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 05 Feb 2023 08:08:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:to:to; s=mesmtp; t= 1675602483; x=1675609683; bh=DQDpOMqTxCQ3czKVgFFUCxk69i1YpSCkauD 7n50Sd/0=; b=RFiLKdMR+buEUsP9RF2CzHlV0N5lhgT9xY3eAmXJ42l3VY+ZoNZ 17EOiXnO5AvrKkGqa3VqyoF3TI0PaCxhLkfIPCgppiuduiKIGThbNHqNqtmi01EN w3fCgnfg533RPhLN9kbFN7EV90dAYogMyId3fWOh290l6Wni2ej9K9Qc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; t=1675602483; x=1675609683; bh=D QDpOMqTxCQ3czKVgFFUCxk69i1YpSCkauD7n50Sd/0=; b=XmCCKsXiiasHa6zgd NZ6Vzyxo05LmQruFrS/GvxTw5vEsoJEQw4atBH2706oN3l6y/n8LFICYDJpM6MgV qQNsY9AKd5hrR9koteq0ARX/wdqNDcp/gEmjAvwfhXwN1ScsuPv2rEg5B14T/dJT qVfav4QARMm39kMLHwkrFda9aam7NZiclqIiShbSljI0oQqvbDOoI8C3CTWYalrX 6Qa5BJLPG9FzJY9OGE6ksONUyRkf7hZUSFrb8Y/HIq7RbKa0S5216mDOnfXgQVVp PHq/iC+E3voASxYwiMw2uchwwmxMzw3k8uZvBHL1sYl3Xx8pGEdHdCXv2uL9OvWK RgP6Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeggedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucfgmhhpthihuchsuhgsjhgvtghtucdluddtmdenuc fjughrpeffhffvkfggtggusehttdertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhl rghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpe fhjeeigfefvedvfeetheegledtkeevuddtgedtudeiteehteegvdefffduffefffenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrg hmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Sun, 5 Feb 2023 08:08:03 -0500 (EST) Date: Sun, 5 Feb 2023 14:08:01 +0100 From: Leo Famulari To: control@debbugs.gnu.org Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: merge 61265 61266 Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [66.111.4.230 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) merge 61265 61266 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 05 08:09:25 2023 Received: (at 61265) by debbugs.gnu.org; 5 Feb 2023 13:09:25 +0000 Received: from localhost ([127.0.0.1]:44352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOelp-00059b-HN for submit@debbugs.gnu.org; Sun, 05 Feb 2023 08:09:25 -0500 Received: from new4-smtp.messagingengine.com ([66.111.4.230]:54857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOelo-00059Q-0e for 61265@debbugs.gnu.org; Sun, 05 Feb 2023 08:09:24 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailnew.nyi.internal (Postfix) with ESMTP id D3B46581DF4; Sun, 5 Feb 2023 08:09:18 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sun, 05 Feb 2023 08:09:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=mesmtp; t=1675602558; x=1675609758; bh=e/kapI4+94J5c7VqgDAqxv/3KKNvxdp+cXmfixprPBs=; b=hCnFzgahkkjE FVpYJP+jaicAw+MnOVSkz98RImrzaUbiWtg3bPPkNJQXAf6clj9SRjN55gZMtpZC awDdvuYDcCdjjg4sV6KWm8Ndw5GKqnW30XVw2eM41pQouRIdRznl+Zr5hAg5smTW kW3qB1uvRoSn0SFMETxonFwyZ0NUDWY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675602558; x=1675609758; bh=e/kapI4+94J5c7VqgDAqxv/3KKNv xdp+cXmfixprPBs=; b=Zdq9eRWe2Mb/A4xxRH6178Mb3cBRTtdNZxulnQ2kVuZO XwvHvaAgOc+dhyjbSXBERGRzc5kTqzXZWEC0V1HlyB7zFE5cdaZtKOr0nEyM1SEq F0iSuCxkRUDe1zLFJc4Ih3VLbJmTGLpaQWUHCaeX2j+LkqKFj7Ki8KJY1JKAbh15 i0uqvoZRG+83G6AOiOzwqPp1EAF9DdcK6hn7Sa+YEVYSaYPorF/y6Cj6fOfdze7z or32Io6FRBmE6nPltNyewocuA6Bd5LCpj7KibV0QOSkI7XHdf+U2vyVaQ74dRRbT E2K5bhTp1LxRE+/TawCZk7Ji8uV5X3UwXs14CmS6Lw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeggedggeekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvvefukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeetheeuvdeivdelueeukefhtdeihe dtgefhvddvlefhudejudeiheelfeevteeuhfenucffohhmrghinhepghhnuhdrohhrghen ucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghose hfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 Feb 2023 08:09:18 -0500 (EST) Date: Sun, 5 Feb 2023 14:09:16 +0100 From: Leo Famulari To: Reily Siegel Subject: Re: [bug#61265] [PATCH 0/1] Add lint checker for unused module imports. Message-ID: References: <87lelegcbm.fsf@reilysiegel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lelegcbm.fsf@reilysiegel.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61265 Cc: 61265@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Feb 04, 2023 at 01:42:28AM -0500, Reily Siegel wrote: > > Julien Lepiller writes (guix-devel): > > > Many modules seem to use a lot of imports that are actually useless, > > for instance (gnu packages heads) imports 20 package modules, but > > only uses 4 of them. > > > > Removing these module imports would help a lot with reducing the number > > of loops. If anyone wants to volunteer a lint checker for that, > > raise hands :D > > This is a quick and dirty implementation of such a lint checker. It > compares the symbols used in a module to those provided by its > dependencies. If there is a dependency for which none of the symbols > overlap, a warning is reported. A potential downside of this approach is > that the lint checker cannot distinguish between lexically scoped > variables and variables which actually reference another module. This > has two effects: Nice! Off-topic, if you are sending a patch series, be sure to follow the instructions in the manual section Sending a Patch Series: https://guix.gnu.org/manual/devel/en/html_node/Sending-a-Patch-Series.html Otherwise, the ticketing system creates a new ticket for each patch, like here. Don't worry, I've merged the ticket. From unknown Tue Aug 19 23:13:04 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Mar 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator