GNU bug report logs - #61263
[PATCH] gnu: dbacl: Fix failing check phase.

Previous Next

Package: guix-patches;

Reported by: danny <at> spesh.com

Date: Sat, 4 Feb 2023 05:10:02 UTC

Severity: normal

Tags: patch

Merged with 61270

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: 61263 <at> debbugs.gnu.org, danny <at> spesh.com
Cc: Danny O'Brien <danny <at> spesh.com>
Subject: [bug#61263] [PATCH] gnu: dbacl: Fix failing check phase.
Date: Sat, 04 Feb 2023 10:07:38 +0000

Hi Danny,

Low-quality review incoming.

I've merged the two duplicate-looking bugs 61263 & 61270.  What happened?

When adding new patch files, you need also add them to gnu/local.mk's sorted dist_patch_DATA list.  Thanks for submitting it upstream!

Reviewing the rest in K-9 is difficult because of the sweeping indentation changes.  Could you submit a v2 without them?

I suspect I'm disagreeing with 'guix style' and not with you, but the 'source' , '#t', and comment changes are steps back IMO (that poor "/"!).

As a rule, there's no requirement to blanket reformat existing code in Guix.  'guix style' isn't there yet.

Removing the obsolete '#t's entirely is welcome though—in a separate commit.

Thanks!

T G-R

Sent on the go.  Excuse or enjoy my brevity.
This bug report was last modified 2 years and 123 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.