GNU bug report logs - #61263
[PATCH] gnu: dbacl: Fix failing check phase.

Previous Next

Full log

View this message in rfc822 format

From: "Danny O'Brien" <danny <at> spesh.com>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 61263 <at> debbugs.gnu.org
Subject: [bug#61263] [PATCH] gnu: dbacl: Fix failing check phase.
Date: Sat, 4 Feb 2023 23:53:29 -0500

[Message part 1 (text/plain, inline)]

On Sat, Feb 04, 2023 at 2:07 AM, Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:

> Hi Danny,
>
> Low-quality review incoming.
>
> I've merged the two duplicate-looking bugs 61263 & 61270. What happened?
>


I think I didn't spot that the earlier submission went through.


> When adding new patch files, you need also add them to gnu/local.mk's
> sorted dist_patch_DATA list. Thanks for submitting it upstream!
>

Ah, will do!



Reviewing the rest in K-9 is difficult because of the sweeping indentation
> changes. Could you submit a v2 without them?
>
> I suspect I'm disagreeing with 'guix style' and not with you, but the
> 'source' , '#t', and comment changes are steps back IMO (that poor "/"!).
>
> As a rule, there's no requirement to blanket reformat existing code in
> Guix. 'guix style' isn't there yet.
>
> Removing the obsolete '#t's entirely is welcome though—in a separate
> commit.
>
> Thanks!
>
> T G-R
>
> Sent on the go. Excuse or enjoy my brevity.
>


Yep, that was all due to `guix style` — the instructions say to run it, but
that may be different if it's just tweaking an existing hand-crafted
package description. I'll re-submit.

Thanks for your suggestions!

d.

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.