GNU bug report logs - #61255
[PATCH 0/5] Add support for the RPM format to "guix pack"

Previous Next

Full log

Message #32 received at 61255 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 61255 <at> debbugs.gnu.org
Subject: Re: bug#61255: [PATCH 0/5] Add support for the RPM format to "guix
 pack"
Date: Sun, 12 Feb 2023 19:20:04 +0100

Hi,

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> * tests/pack.scm: Fix indentation.

[...]

>         (check   (gexp->derivation
> -                 "check-tarball"
> -                 (with-imported-modules '((guix build utils))

[...]

> +                    "check-tarball"
> +                  (with-imported-modules '((guix build utils))

I’m not convinced by the indentation rule for ‘gexp->derivation’ added
in 82daab42811a2e3c7684ebdf12af75ff0fa67b99: there’s no reason to treat
‘gexp->derivation’ differently from other procedures.

What about removing that rule from ‘.dir-locals.el’ and keeping
‘tests/pack.scm’ unchanged?

(Also not sure about the ‘computed-file’ rule.  For all these things,
we’ll want to keep Emacs and (guix read-print) in sync, too.)

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.