GNU bug report logs - #61255
[PATCH 0/5] Add support for the RPM format to "guix pack"

Previous Next

Full log

Message #23 received at 61255 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: Josselin Poiret <dev <at> jpoiret.xyz>, Tobias Geerinckx-Rice <me <at> tobias.gr>,
 Simon Tournier <zimon.toutoune <at> gmail.com>, Mathieu Othacehe <othacehe <at> gnu.org>,
 Christopher Baines <mail <at> cbaines.net>, Ricardo Wurmus <rekado <at> elephly.net>,
 61255 <at> debbugs.gnu.org
Subject: Re: [PATCH 2/5] gexp: computed-file: Honor %guile-for-build.
Date: Sat, 04 Feb 2023 02:11:23 +0100

Hello!

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> * guix/gexp.scm (computed-file): Set the default value of the #:guile argument
> to that of the %guile-for-build parameter.

[...]

>  (define* (computed-file name gexp
> -                        #:key guile (local-build? #t) (options '()))
> +                        #:key (guile (%guile-for-build))
> +                        (local-build? #t) (options '()))

I think that would lead ‘computed-file’ to pick (%guile-for-build) at
the wrong time (time of call instead of time of lowering).

Commit ab25eb7caaf5571cc9f8d6397a1eae127d7e29d1 made it #f such that
‘gexp->derivation’ gets to resolve it at the “right” time.

Does that make sense?  But perhaps this approach isn’t suitable in the
use case you’re looking at?

HTH,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.