GNU bug report logs - #6125
[PATCH] Fix indent of --help and --version

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Zhang Sen <zh.jesse <at> gmail.com>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] Fix indent of --help and --version
Date: Thu, 06 May 2010 16:00:47 +0800

Hi,

From the several commands I tried, HELP_OPTION_DESCRIPTION and
VERSION_OPTION_DESCRIPTION don't align well with others in the Usage.

$ cat --help
  -u                       (ignored)
  -v, --show-nonprinting   use ^ and M- notation, except for LFD and TAB
      --help     display this help and exit
      --version  output version information and exit

Here is a trivial patch to make the printing of --help/--version be
consistent with other options from Usage.

$ cat --help
  -u                       (ignored)
  -v, --show-nonprinting   use ^ and M- notation, except for LFD and TAB
  --help     display this help and exit
  --version  output version information and exit

Of course the second column is still broken, but I think that's beyond
this simple patch.

Regards,
- jesse

From ba3faa1e0661a6c335a1e7ff525325665a949b79 Mon Sep 17 00:00:00 2001
From: Zhang Sen <zh.jesse <at> gmail.com>
Date: Thu, 6 May 2010 15:07:18 +0800
Subject: [PATCH] Fix indent of --help and --version

Keep consistent with other options, which are printed with two-spaces indent
---
 src/system.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/system.h b/src/system.h
index 859b663..811fde9 100644
--- a/src/system.h
+++ b/src/system.h
@@ -387,9 +387,9 @@ enum
 "for details about the options it supports.\n")
 
 #define HELP_OPTION_DESCRIPTION \
-  _("      --help     display this help and exit\n")
+  _("  --help     display this help and exit\n")
 #define VERSION_OPTION_DESCRIPTION \
-  _("      --version  output version information and exit\n")
+  _("  --version  output version information and exit\n")
 
 #include "closein.h"
 #include "closeout.h"
-- 
1.7.0.6

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.