GNU bug report logs - #61238
[PATCH] Fix go-ts-mode type switch and select case blocks indentation

Previous Next

Full log

Message #20 received at 61238 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Davide Masserut <dm <at> mssdvd.com>
Cc: 61238 <at> debbugs.gnu.org, eliz <at> gnu.org
Subject: Re: bug#61238: [PATCH] Fix go-ts-mode type switch and select case
 blocks indentation
Date: Sat, 04 Feb 2023 19:29:50 +0100

Davide Masserut <dm <at> mssdvd.com> writes:

> Theodor Thornhill <theo <at> thornhill.no> writes:
>
>> Hey there, Davide, and thanks for the clear bug-report!
>>
>> This looks good to me, but before I install, Maybe you can also 
>> add a
>> test for this, similar to the ones in c-ts-mode-tests.el?
>>
>> Also, just checking - is fsf assignment needed for this change? 
>> Maybe
>> you've done it already, if so, forgive my ignorance :-)
>>
>> Theo

Thanks! I've commited and pushed this to the emacs-29 branch.  I made a
small tweak to the commit message and fixed this:

(ert-deftest go-ts-mode-test-indentation ()
  (skip-unless (treesit-ready-p 'c))
  (ert-test-erts-file (ert-resource-file "indent.erts")))

Thanks again,

Theo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.