GNU bug report logs - #61223
29.0.60; treesit--install-language-grammar-build-recipe refers github

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yuan Fu <casouri <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#61223: closed (29.0.60; treesit--install-language-grammar-build-recipe
 refers github)
Date: Fri, 03 Feb 2023 02:41:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Thu, 2 Feb 2023 18:40:21 -0800
with message-id <5D8CFA02-954D-4402-BB1E-84493F0B7299 <at> gmail.com>
and subject line Re: bug#61223: 29.0.60; treesit--install-language-grammar-build-recipe refers github
has caused the debbugs.gnu.org bug report #61223,
regarding 29.0.60; treesit--install-language-grammar-build-recipe refers github
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
61223: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61223
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Bug Report Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 29.0.60; treesit--install-language-grammar-build-recipe refers github
Date: Wed, 1 Feb 2023 22:17:56 -0800

X-Debbugs-CC: eliz <at> gnu.org, dgutov <at> yandex.ru
--text follows this line--
I noticed that treesit-install-language-grammar now automatically builds
the repository url from github:

(let ((repo-default (format "https://github.com/tree-sitter/tree-sitter-%s" lang)))
         (read-string
          "Enter the URL of the Git repository of the language grammar: "
          (and (treesit--check-repo-url repo-default) repo-default)))


AFAICT GNU don’t want to promote/refer to github, that’s why I didn’t
include “official” grammar repositories in
treesit-language-source-alist. Was there a discussion that I missed?

This is a nice feature, but I’d hate having to remove it later, after
users have noticed it and started using/depending on it, due to some GNU
policy.

Yuan

[Message part 3 (message/rfc822, inline)]

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 61223-done <at> debbugs.gnu.org, 61223 <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#61223: 29.0.60;
 treesit--install-language-grammar-build-recipe refers github
Date: Thu, 2 Feb 2023 18:40:21 -0800

> Hello Yuan, 
> 
> I think this is the result of installing the proposed patch from bug#61051, which Eli approved and Dmitry installed.  I had my doubts on the github reference but didn’t ask back then. 
> 
> Best, 
> 
> 
> RY

> On Feb 2, 2023, at 1:03 AM, Eli Zaretskii <eliz <at> gnu.org> wrote:
> 
> I don't see a problem here: it's just the default we offer when a
> grammar is available from the Tree-sitter site.  It's a far cry from
> having a database full of GitHub URLs that we'd need to maintain and
> keep up to date.

That’s very good news :-) Closing.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.