GNU bug report logs - #61205
'function' in 3rd element of treesit-font-lock-feature-list

Previous Next

Full log

Message #41 received at 61205 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 61205 <at> debbugs.gnu.org, casouri <at> gmail.com, theo <at> thornhill.no,
 jostein <at> secure.kjonigsen.net, dev <at> rjt.dev
Subject: Re: bug#61205: 'function' in 3rd element of
 treesit-font-lock-feature-list
Date: Fri, 03 Feb 2023 08:45:15 +0200

> Cc: 61205 <at> debbugs.gnu.org, Theodor Thornhill <theo <at> thornhill.no>,
>  Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>,
>  randy taylor <dev <at> rjt.dev>
> Date: Fri, 3 Feb 2023 04:51:04 +0200
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> 
> >> On a related note: 'property' is in level 3 in c-ts-mode.
> >>
> >> Should it to go level 4?
> > 
> > I believe property is level 3. Quoting the (emacs) manual:
> > 
> > Level 1
> >       This level usually fontifies only comments and function names in
> >       function definitions.
> > Level 2
> >       This level adds fontification of keywords, strings, and data types.
> > Level 3
> >       This is the default level; it adds fontification of assignments,
> >       numbers, properties, etc.
> > Level 4
> >       This level adds everything else that can be fontified: operators,
> >       delimiters, brackets, other punctuation, function names in function
> >       calls, variables, etc.
> 
> The manual could be updated.
> 
> Here's where we seem to have agreed that is should be level 4: 
> https://lists.gnu.org/archive/html/emacs-devel/2022-12/msg01221.html

Whatever you decide, please keep the doc string of
treesit-font-lock-level and the manual in sync.  I already needed to
fix those more than once because the code "disagreed" with the
documentation.  The pretest is too close for us to be able to sustain
such inaccuracies and resolve them in time.

So please present the patches to this effect for review and comments
before installing them.  TIA.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.