GNU bug report logs - #61205
'function' in 3rd element of treesit-font-lock-feature-list

Previous Next

Package: emacs;

Reported by: Dmitry Gutov <dgutov <at> yandex.ru>

Date: Wed, 1 Feb 2023 02:09:02 UTC

Severity: normal

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


Message #35 received at 61205 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 61205 <at> debbugs.gnu.org, Theodor Thornhill <theo <at> thornhill.no>,
 Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>,
 randy taylor <dev <at> rjt.dev>
Subject: Re: bug#61205: 'function' in 3rd element of
 treesit-font-lock-feature-list
Date: Thu, 2 Feb 2023 18:38:37 -0800

> On Feb 2, 2023, at 12:25 PM, Dmitry Gutov <dgutov <at> yandex.ru> wrote:
> 
> On 01/02/2023 07:18, Yuan Fu wrote:
>>> On Jan 31, 2023, at 6:08 PM, Dmitry Gutov<dgutov <at> yandex.ru>  wrote:
>>> 
>>> X-Debbugs-Cc: Yuan Fu<casouri <at> gmail.com>, Randy Taylor<dev <at> rjt.dev>
>>> 
>>> Some new built-in modes has 'function' feature highlighting thus enabled by default.
>>> 
>>> rust-ts-mode, go-ts-mode, cmake-mode
>>> 
>>> Should we move it to 4 for consistency with the rest?
>>> 
>>> Previously, we talked about that and concluded that function calls are usually everywhere and are easy to notice without additional highlighting.
>> Right, I think they should be level 4.
> 
> On a related note: 'property' is in level 3 in c-ts-mode.
> 
> Should it to go level 4?

I believe property is level 3. Quoting the (emacs) manual:

Level 1
     This level usually fontifies only comments and function names in
     function definitions.
Level 2
     This level adds fontification of keywords, strings, and data types.
Level 3
     This is the default level; it adds fontification of assignments,
     numbers, properties, etc.
Level 4
     This level adds everything else that can be fontified: operators,
     delimiters, brackets, other punctuation, function names in function
     calls, variables, etc.

Yuan



This bug report was last modified 2 years and 107 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.