From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: casouri@gmail.com, dev@rjt.dev, bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Feb 2023 02:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61205@debbugs.gnu.org Cc: yuan fu , randy taylor X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: yuan fu , randy taylor Received: via spool by submit@debbugs.gnu.org id=B.167521732628355 (code B ref -1); Wed, 01 Feb 2023 02:09:02 +0000 Received: (at submit) by debbugs.gnu.org; 1 Feb 2023 02:08:46 +0000 Received: from localhost ([127.0.0.1]:55439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pN2YI-0007NH-EO for submit@debbugs.gnu.org; Tue, 31 Jan 2023 21:08:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:37120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pN2YF-0007N6-NZ for submit@debbugs.gnu.org; Tue, 31 Jan 2023 21:08:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pN2YF-0001sC-HW for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 21:08:43 -0500 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pN2YD-0002f5-KW for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 21:08:43 -0500 Received: by mail-ed1-x52b.google.com with SMTP id fi26so16233649edb.7 for ; Tue, 31 Jan 2023 18:08:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=dX43fHdpZJ7kxlOzMCPpuK+I7QzybYOi95AU+ehewaI=; b=n2uFIvxvCVYRAZp9nBVc3Zw+OF3cevOc0tAWGnf3MLQJUi2SOUlt23x4FCTLDdg0BX Z5wr+PG3avH9rugNRNxYPejoZhlIKBVCW20PCYki0W+qB9LWRgI7Py5XTmsQsqAXo7Oe Ulvcgf8eg+tfQK57iliho3Zt9hCoBq3VeMEhKpp0JizjTavXiTNPUi7k4QMpFwj2OCrd aPECnoxhMr+SQlgrdE5KIvX1tZr1DRVtFULU1CE18bcc4fR2bZT+g1610FVUYHBCLizg /nZrcq/1TfBs4mqWrVyWrc57p6467iKvw3PINRuJFBP8LHIVkvUpd6sqnJQrbf2q3fAB Eg2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dX43fHdpZJ7kxlOzMCPpuK+I7QzybYOi95AU+ehewaI=; b=Jn9FLOrjtIJBYCQZ/ZAdxpkLILGfYnaQh7Lro490diayXGUOPmpGzT2smEVqVKr6WH RLHnkTh4itNfnhIWiMgSfzkPcS2SP6M1f7yCvs4lPOL5ybpyJgwIJEIMID0Go2ErvwU8 MnWVxDBiJeKxJERqwtvvhZk79F9bImcRP2kQKv/eV9LBvLSIvxMTTkk4tiOc/ge5SLoP tVNBe5Mv9d8oElZuYLIju59+ptnQHQN83xdfDTyhZdMLvyIdInl6p2uLssSQgrS0Wtvt Nd0lyd5JTdVFiAulUQhnq2/iq1JOEjBzaeZgoISNXwPhjzYmjXckdkCKIw9yl3EJUjFM D/yA== X-Gm-Message-State: AO0yUKVqGrN9TZsaM1QmgplqX5sdjyss/nXBKS/MImIeNAJYF80G1xIa adjdRh49FCEXycFGP2hcFY3EanyJbP0= X-Google-Smtp-Source: AK7set+VNpXmcHoTuX0BIRbvtneS/IeZGkYxT/b4r4BVae6ov6oCbovjhHIJkn/yxhZNj8WsQ+KKzw== X-Received: by 2002:a05:6402:370e:b0:48f:68b1:db4e with SMTP id ek14-20020a056402370e00b0048f68b1db4emr205833edb.27.1675217320014; Tue, 31 Jan 2023 18:08:40 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id jo17-20020a170906f6d100b008785b914883sm9255971ejb.116.2023.01.31.18.08.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 18:08:39 -0800 (PST) Message-ID: Date: Wed, 1 Feb 2023 04:08:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US From: Dmitry Gutov Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=raaahh@gmail.com; helo=mail-ed1-x52b.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) X-Debbugs-Cc: Yuan Fu , Randy Taylor Some new built-in modes has 'function' feature highlighting thus enabled by default. rust-ts-mode, go-ts-mode, cmake-mode Should we move it to 4 for consistency with the rest? Previously, we talked about that and concluded that function calls are usually everywhere and are easy to notice without additional highlighting. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Feb 2023 05:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61205@debbugs.gnu.org, randy taylor Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167522915316263 (code B ref 61205); Wed, 01 Feb 2023 05:26:01 +0000 Received: (at 61205) by debbugs.gnu.org; 1 Feb 2023 05:25:53 +0000 Received: from localhost ([127.0.0.1]:56157 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pN5d2-0004EE-AB for submit@debbugs.gnu.org; Wed, 01 Feb 2023 00:25:53 -0500 Received: from mail-il1-f176.google.com ([209.85.166.176]:37417) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pN5cv-0004Dt-MH for 61205@debbugs.gnu.org; Wed, 01 Feb 2023 00:25:51 -0500 Received: by mail-il1-f176.google.com with SMTP id u7so5951266ilg.4 for <61205@debbugs.gnu.org>; Tue, 31 Jan 2023 21:25:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=QOxOG6ZSYZ2PSJ7QnZebxdJ8Em+0AAcbN143jAe4hZw=; b=SsCTAB6U7zmHdr5NkMo5UdR/d8AiqOkBMInszl5EGhDDpkgd7VaGXoHjeyNLIUbm2M 6pZN+w424id48by2nhUM3+vQDLVJyQnxLa+LxJQiFwIOjyhaxvYYmjx6V+/WTh3voQED NtWjEt2ikEIS9wcJIvm5A3sUPhpOC4ZWXIb6JM57e5Z0Fd5dKsyMBIRjI1Is2eK1c85z qni6vxCBMXYPmebE58dEaK1D++Xk/ki3Hv90cZquOwgIuOCPGXM2DceTmd/549pj79Pd /VwEzayN/5GNQcQqmIK6enlX0REHEaDTWkvh0da/cPeagsTv6O7Nk1mWbdvZNJizK1l2 tQQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QOxOG6ZSYZ2PSJ7QnZebxdJ8Em+0AAcbN143jAe4hZw=; b=0H9RT+jmNnhvE2seutfU1kIyjJBup22QMR57GUcoY2wTQdaFgOp8DBUXaklRYi3iwL fdB9/xVxp46B0XvH1oiftK/tjYCTTOYEUX4H2lV+EBbf8cpuxhnQ1+MxoefbkAWYxTAW NNuhFjk5Q+QKsalb6aZ+Js08wqWKlE4BTV2Of9dBchw7HSciYJkTjVPsp/PXjkphUpYF p/PWhOFQYCOdjAlXr032TOv6gPNwd+eeSNf5kpMgZl/csCbviI0ZO6BoiEPBl+t6eWhn +hJ/xUzLEd4U1iVOKPCpeaYgYcmfGhgD9leal/VyeRcnR6lyynaQTTehurTPZ0Myebkh 59Vw== X-Gm-Message-State: AO0yUKVvncdhgHhEwF7Y2XJNEv5Y3BZ8tkKNqBauTxADhQhAoMrlmaT6 NPY7RbPBOZlkG9lTgz1s3EkesfFRobc= X-Google-Smtp-Source: AK7set/F53w3pFyNK+zTiQJXy4hF7YncG7DoyJBT5XEW39m76c5ozWVm2Ncs6HTBPVYtFPoAu3IrSw== X-Received: by 2002:a17:902:d482:b0:194:997d:7735 with SMTP id c2-20020a170902d48200b00194997d7735mr812747plg.48.1675228728126; Tue, 31 Jan 2023 21:18:48 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id o5-20020a170902bcc500b001946a3f4d9csm2502025pls.38.2023.01.31.21.18.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 31 Jan 2023 21:18:47 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) From: Yuan Fu In-Reply-To: Date: Tue, 31 Jan 2023 21:18:36 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: References: X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jan 31, 2023, at 6:08 PM, Dmitry Gutov wrote: >=20 > X-Debbugs-Cc: Yuan Fu , Randy Taylor >=20 > Some new built-in modes has 'function' feature highlighting thus = enabled by default. >=20 > rust-ts-mode, go-ts-mode, cmake-mode >=20 > Should we move it to 4 for consistency with the rest? >=20 > Previously, we talked about that and concluded that function calls are = usually everywhere and are easy to notice without additional = highlighting. Right, I think they should be level 4. Yuan= From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 02:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61205@debbugs.gnu.org, yuan fu Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167530528510112 (code B ref 61205); Thu, 02 Feb 2023 02:35:02 +0000 Received: (at 61205) by debbugs.gnu.org; 2 Feb 2023 02:34:45 +0000 Received: from localhost ([127.0.0.1]:60264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNPQz-0002d2-2j for submit@debbugs.gnu.org; Wed, 01 Feb 2023 21:34:45 -0500 Received: from mail-4018.proton.ch ([185.70.40.18]:36231) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNPQv-0002ck-OZ for 61205@debbugs.gnu.org; Wed, 01 Feb 2023 21:34:44 -0500 Date: Thu, 02 Feb 2023 02:34:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1675305274; x=1675564474; bh=ub496X9x+qFXCUaf/8Oi5UMF1NPjudwcef02a0u8t0s=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=SPr7EuibaRtQiEf2mBWSD3Y26acPo4id9Ap1kw6DUJ1uW8vMhOE6qHDRUUdxz+J/7 Z2IkwYnMLZWftLxt352OLgtv+cmENLGDQAf7NYdaAzvshVmem6RWvK2gOGR8v7GzZw jOd/nk4bRhZ1F2z3zgDWsnrRE44tSpJKuO9FK2PAJwmKt/kAZzNpJxk7XLY89TpMW9 ubbL0fhI5k60DrQK9xBtyESZ0sFQ75hQhNF5O0QdEAmDkMNTMw8mls2lQIfTC/NqPx 9iiEtSphOfuyYNwJpBk2gtFc7mP3JoovjEcdeN+KlXhgZ7VNFwqWfq6/ILRr88CQPO 5dSD/cHVuJVxA== From: Randy Taylor Message-ID: In-Reply-To: References: Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Tuesday, January 31st, 2023 at 21:08, Dmitry Gutov wr= ote: > X-Debbugs-Cc: Yuan Fu casouri@gmail.com, Randy Taylor dev@rjt.dev >=20 >=20 > Some new built-in modes has 'function' feature highlighting thus enabled > by default. >=20 > rust-ts-mode, go-ts-mode, cmake-mode >=20 > Should we move it to 4 for consistency with the rest? >=20 > Previously, we talked about that and concluded that function calls are > usually everywhere and are easy to notice without additional highlighting= . If that's what folks decided on then we should keep everything consistent. Personally, I find it odd that out of the box default highlighting wouldn't= highlight function calls. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 02:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: 61205@debbugs.gnu.org, randy taylor Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167530529610139 (code B ref 61205); Thu, 02 Feb 2023 02:35:02 +0000 Received: (at 61205) by debbugs.gnu.org; 2 Feb 2023 02:34:56 +0000 Received: from localhost ([127.0.0.1]:60267 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNPR9-0002dS-EK for submit@debbugs.gnu.org; Wed, 01 Feb 2023 21:34:55 -0500 Received: from mail-ej1-f47.google.com ([209.85.218.47]:42567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNPR7-0002dE-GS for 61205@debbugs.gnu.org; Wed, 01 Feb 2023 21:34:54 -0500 Received: by mail-ej1-f47.google.com with SMTP id bk15so2064803ejb.9 for <61205@debbugs.gnu.org>; Wed, 01 Feb 2023 18:34:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=cUXOGMR8YJUySkyJ0IBiNjzmESUB4BbiUnuVAMiydwU=; b=BicsTkrLNPsOizW9UCJGuRDa5B6xCM6+TdQ31Twasr6Evak53gLgyIGqshp5qbWhsA 7jE3LxLCyN6WDU6JoUOz+W6I/8aPenys6/PJ3ZnYzZHRRzubznSeTcmUlsxiex6F5rW4 z19Ki9MQRfxgQJPajNuOX5g+0A4fEqznSPZW0EJ2M9OqY5+6l0AXK0QA4CoGdZaVIZ9E oYNcsB6tuAfViIEcqID9J0dvC21Ws8y/2Vv1qwL37/GQl2XJneWLjKcaQqx5wPelGpOE XJPCvfbKVy3BBMFnBvS5LMwSJeErOj+HRMnr+VaHCW0yVBQ/cmXIwDLt+4fDLxZLiGdw NnEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cUXOGMR8YJUySkyJ0IBiNjzmESUB4BbiUnuVAMiydwU=; b=7jtv34AA6xwlkCOyElOQ3XpUtly356JF5u2tL90IrLv8/7qHnj/TYNmy9HzysZxGSB hVs0Rmqo1WLj1diuLFtnQ60vBkfgwazTIVuLQq/2PJmpPOZyxKzi/N/u54blI7PqHGYE EUJXpeEtWFWx9/wUBPzox19AjAJ8LeTGSI2kXqL/uJGT8ij+xRXAjwUAS0Er6WPAhDqu wPziIFl3bG4bsY6sdiaEwn2KdOP1xMoF5zbgkjAEiezLWUOy5Ligs6qxo7ZFYXmRt4ev YyPc/RAJ7XF4Yq7o8ULhY5c+NpxzFpSnVyMlC3Lp9gU53bJkflntMrG11Pv0AFdLe9zb 5IjQ== X-Gm-Message-State: AO0yUKUvvwxc8Z90WzMXe6cMIhH8G6yo5wNfcISlczffsMSltDipCoto T2BPPVtYlvLLxD9tAxW0kQY= X-Google-Smtp-Source: AK7set/5urNft+5dzreB+u5Yqx1FRJI3CiOvBawlvzFI3tw9ZQ8QlGQl2EnYPgGIyYLKiZkf5nlEpA== X-Received: by 2002:a17:906:b013:b0:884:930:b017 with SMTP id v19-20020a170906b01300b008840930b017mr5125391ejy.60.1675305286550; Wed, 01 Feb 2023 18:34:46 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id z2-20020a170906714200b00888161349desm5938698ejj.182.2023.02.01.18.34.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 18:34:45 -0800 (PST) Content-Type: multipart/mixed; boundary="------------NyQBXpH05RVgSCt1bEceqRC0" Message-ID: <775e21ae-6513-8dca-a669-bedae86bf02d@yandex.ru> Date: Thu, 2 Feb 2023 04:34:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: From: Dmitry Gutov In-Reply-To: X-Spam-Score: -0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) This is a multi-part message in MIME format. --------------NyQBXpH05RVgSCt1bEceqRC0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01/02/2023 07:18, Yuan Fu wrote: > > >> On Jan 31, 2023, at 6:08 PM, Dmitry Gutov wrote: >> >> X-Debbugs-Cc: Yuan Fu , Randy Taylor >> >> Some new built-in modes has 'function' feature highlighting thus enabled by default. >> >> rust-ts-mode, go-ts-mode, cmake-mode >> >> Should we move it to 4 for consistency with the rest? >> >> Previously, we talked about that and concluded that function calls are usually everywhere and are easy to notice without additional highlighting. > > Right, I think they should be level 4. OK, I tried simply changing that, and it turned out none of these modes have a 'definition' feature, so highlightings get stripped from all definitions as well. And in a couple of cases function calls got highlighted either as a type, or as a property. I fixed the latter by deleting one selector, and the latter didn't touch per se. But since the same modes had 'variable' and 'property' features in the 3rd level as well, I moved them to the 4th (that resolved the incorrect highlighting as property mentioned above, but it's probably need to be improved later, in case someone will want to enable 'property' but not 'function' highlighting). And I added the 'definition' features and moved some highlighting rules there. And added some. So the patch looks a bit more complex than expected, see attached. cmake-ts-mode, in the end, I ended up keeping as-is. The 'variable' selector is more functional there than everywhere else (the grammar uses those nodes for template expansion), and if 'function' is removed, the buffer looks almost devoid of highlighting. Also none of these modes have highlighting for function parameters or assignments. That can be improved later. --------------NyQBXpH05RVgSCt1bEceqRC0 Content-Type: text/x-patch; charset=UTF-8; name="ts-modes-refine-features.diff" Content-Disposition: attachment; filename="ts-modes-refine-features.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwgYi9saXNwL3Byb2dt b2Rlcy9nby10cy1tb2RlLmVsCmluZGV4IDVmM2UxZWEzZTY4Li4zNTM2YTZjYjBjZCAxMDA2 NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbAorKysgYi9saXNwL3Byb2dt b2Rlcy9nby10cy1tb2RlLmVsCkBAIC0xMTksMTcgKzExOSwyNyBAQCBnby10cy1tb2RlLS1m b250LWxvY2stc2V0dGluZ3MKICAgIDpmZWF0dXJlICdkZWxpbWl0ZXIKICAgICcoKFsiLCIg Ii4iICI7IiAiOiJdKSBAZm9udC1sb2NrLWRlbGltaXRlci1mYWNlKQogCisgICA6bGFuZ3Vh Z2UgJ2dvCisgICA6ZmVhdHVyZSAnZGVmaW5pdGlvbgorICAgJygoZnVuY3Rpb25fZGVjbGFy YXRpb24KKyAgICAgIG5hbWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5h bWUtZmFjZSkKKyAgICAgKG1ldGhvZF9kZWNsYXJhdGlvbgorICAgICAgbmFtZTogKGZpZWxk X2lkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKQorICAgICAobWV0 aG9kX3NwZWMKKyAgICAgIG5hbWU6IChmaWVsZF9pZGVudGlmaWVyKSBAZm9udC1sb2NrLWZ1 bmN0aW9uLW5hbWUtZmFjZSkpCisKKyAgIDpsYW5ndWFnZSAnZ28KKyAgIDpmZWF0dXJlICdk ZWZpbml0aW9uCisgICAnKChmaWVsZF9kZWNsYXJhdGlvbgorICAgICAgbmFtZTogKGZpZWxk X2lkZW50aWZpZXIpIEBmb250LWxvY2stcHJvcGVydHktZmFjZSkpCisKICAgIDpsYW5ndWFn ZSAnZ28KICAgIDpmZWF0dXJlICdmdW5jdGlvbgogICAgJygoY2FsbF9leHByZXNzaW9uCiAg ICAgICBmdW5jdGlvbjogKGlkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1m YWNlKQogICAgICAoY2FsbF9leHByZXNzaW9uCiAgICAgICBmdW5jdGlvbjogKHNlbGVjdG9y X2V4cHJlc3Npb24KLSAgICAgICAgICAgICAgICAgZmllbGQ6IChmaWVsZF9pZGVudGlmaWVy KSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZSkpCi0gICAgIChmdW5jdGlvbl9kZWNs YXJhdGlvbgotICAgICAgbmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24t bmFtZS1mYWNlKQotICAgICAobWV0aG9kX2RlY2xhcmF0aW9uCi0gICAgICBuYW1lOiAoZmll bGRfaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpKQorICAgICAg ICAgICAgICAgICBmaWVsZDogKGZpZWxkX2lkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rp b24tbmFtZS1mYWNlKSkpCiAKICAgIDpsYW5ndWFnZSAnZ28KICAgIDpmZWF0dXJlICdrZXl3 b3JkCkBAIC0yMTgsMTAgKzIyOCwxMCBAQCBnby10cy1tb2RlCiAgICAgKHNldHEtbG9jYWwg dHJlZXNpdC1mb250LWxvY2stc2V0dGluZ3MgZ28tdHMtbW9kZS0tZm9udC1sb2NrLXNldHRp bmdzKQogICAgIChzZXRxLWxvY2FsIHRyZWVzaXQtZm9udC1sb2NrLWZlYXR1cmUtbGlzdAog ICAgICAgICAgICAgICAgICcoKCBjb21tZW50KQotICAgICAgICAgICAgICAgICAgKCBrZXl3 b3JkIHN0cmluZyB0eXBlKQotICAgICAgICAgICAgICAgICAgKCBjb25zdGFudCBlc2NhcGUt c2VxdWVuY2UgZnVuY3Rpb24gbGFiZWwgbnVtYmVyCi0gICAgICAgICAgICAgICAgICAgIHBy b3BlcnR5IHZhcmlhYmxlKQotICAgICAgICAgICAgICAgICAgKCBicmFja2V0IGRlbGltaXRl ciBlcnJvciBvcGVyYXRvcikpKQorICAgICAgICAgICAgICAgICAgKCBrZXl3b3JkIHN0cmlu ZyB0eXBlIGRlZmluaXRpb24pCisgICAgICAgICAgICAgICAgICAoIGNvbnN0YW50IGVzY2Fw ZS1zZXF1ZW5jZSBsYWJlbCBudW1iZXIpCisgICAgICAgICAgICAgICAgICAoIGJyYWNrZXQg ZGVsaW1pdGVyIGVycm9yIG9wZXJhdG9yIGZ1bmN0aW9uIHZhcmlhYmxlCisgICAgICAgICAg ICAgICAgICAgIHByb3BlcnR5KSkpCiAKICAgICAodHJlZXNpdC1tYWpvci1tb2RlLXNldHVw KSkpCiAKZGlmZiAtLWdpdCBhL2xpc3AvcHJvZ21vZGVzL3J1c3QtdHMtbW9kZS5lbCBiL2xp c3AvcHJvZ21vZGVzL3J1c3QtdHMtbW9kZS5lbAppbmRleCBlMzE3NzkzZDIxMS4uMjBlZTJl NDIwZDMgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL3J1c3QtdHMtbW9kZS5lbAorKysg Yi9saXNwL3Byb2dtb2Rlcy9ydXN0LXRzLW1vZGUuZWwKQEAgLTE1NSw2ICsxNTUsMTYgQEAg cnVzdC10cy1tb2RlLS1mb250LWxvY2stc2V0dGluZ3MKICAgIDpmZWF0dXJlICdkZWxpbWl0 ZXIKICAgICcoKFsiLCIgIi4iICI7IiAiOiIgIjo6Il0pIEBmb250LWxvY2stZGVsaW1pdGVy LWZhY2UpCiAKKyAgIDpsYW5ndWFnZSAncnVzdAorICAgOmZlYXR1cmUgJ2RlZmluaXRpb24K KyAgICcoKGZ1bmN0aW9uX2l0ZW0gbmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stZnVu Y3Rpb24tbmFtZS1mYWNlKQorICAgICAobWFjcm9fZGVmaW5pdGlvbiAibWFjcm9fcnVsZXMh IiBAZm9udC1sb2NrLWNvbnN0YW50LWZhY2UpCisgICAgIChtYWNyb19kZWZpbml0aW9uIChp ZGVudGlmaWVyKSBAZm9udC1sb2NrLXByZXByb2Nlc3Nvci1mYWNlKSkKKworICAgOmxhbmd1 YWdlICdydXN0CisgICA6ZmVhdHVyZSAnZGVmaW5pdGlvbgorICAgJygoZmllbGRfZGVjbGFy YXRpb24gbmFtZTogKGZpZWxkX2lkZW50aWZpZXIpIEBmb250LWxvY2stcHJvcGVydHktZmFj ZSkpCisKICAgIDpsYW5ndWFnZSAncnVzdAogICAgOmZlYXR1cmUgJ2Z1bmN0aW9uCiAgICAn KChjYWxsX2V4cHJlc3Npb24KQEAgLTE2NCwxNSArMTc0LDEyIEBAIHJ1c3QtdHMtbW9kZS0t Zm9udC1sb2NrLXNldHRpbmdzCiAgICAgICAgIGZpZWxkOiAoZmllbGRfaWRlbnRpZmllcikg QGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCiAgICAgICAgKHNjb3BlZF9pZGVudGlm aWVyCiAgICAgICAgIG5hbWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5h bWUtZmFjZSldKQotICAgICAoZnVuY3Rpb25faXRlbSAoaWRlbnRpZmllcikgQGZvbnQtbG9j ay1mdW5jdGlvbi1uYW1lLWZhY2UpCiAgICAgIChnZW5lcmljX2Z1bmN0aW9uCiAgICAgICBm dW5jdGlvbjogWyhpZGVudGlmaWVyKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZQog ICAgICAgICAgICAgICAgICAoZmllbGRfZXhwcmVzc2lvbgogICAgICAgICAgICAgICAgICAg ZmllbGQ6IChmaWVsZF9pZGVudGlmaWVyKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFj ZSkKICAgICAgICAgICAgICAgICAgKHNjb3BlZF9pZGVudGlmaWVyCiAgICAgICAgICAgICAg ICAgICBuYW1lOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2Up XSkKLSAgICAgKG1hY3JvX2RlZmluaXRpb24gIm1hY3JvX3J1bGVzISIgQGZvbnQtbG9jay1j b25zdGFudC1mYWNlKQotICAgICAobWFjcm9fZGVmaW5pdGlvbiAoaWRlbnRpZmllcikgQGZv bnQtbG9jay1wcmVwcm9jZXNzb3ItZmFjZSkKICAgICAgKG1hY3JvX2ludm9jYXRpb24gbWFj cm86IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXByZXByb2Nlc3Nvci1mYWNlKSkKIAogICAg Omxhbmd1YWdlICdydXN0CkBAIC0yMDgsNyArMjE1LDYgQEAgcnVzdC10cy1tb2RlLS1mb250 LWxvY2stc2V0dGluZ3MKICAgICAgKG1vZF9pdGVtIG5hbWU6IChpZGVudGlmaWVyKSBAZm9u dC1sb2NrLWNvbnN0YW50LWZhY2UpCiAgICAgIChwcmltaXRpdmVfdHlwZSkgQGZvbnQtbG9j ay10eXBlLWZhY2UKICAgICAgKHR5cGVfaWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZh Y2UKLSAgICAgKHNjb3BlZF9pZGVudGlmaWVyIG5hbWU6IChpZGVudGlmaWVyKSBAZm9udC1s b2NrLXR5cGUtZmFjZSkKICAgICAgKHNjb3BlZF9pZGVudGlmaWVyIHBhdGg6IChpZGVudGlm aWVyKSBAZm9udC1sb2NrLWNvbnN0YW50LWZhY2UpCiAgICAgIChzY29wZWRfaWRlbnRpZmll cgogICAgICAgKHNjb3BlZF9pZGVudGlmaWVyCkBAIC0zMTgsMTAgKzMyNCwxMCBAQCBydXN0 LXRzLW1vZGUKICAgICAoc2V0cS1sb2NhbCB0cmVlc2l0LWZvbnQtbG9jay1zZXR0aW5ncyBy dXN0LXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncykKICAgICAoc2V0cS1sb2NhbCB0cmVl c2l0LWZvbnQtbG9jay1mZWF0dXJlLWxpc3QKICAgICAgICAgICAgICAgICAnKCggY29tbWVu dCkKLSAgICAgICAgICAgICAgICAgICgga2V5d29yZCBzdHJpbmcpCisgICAgICAgICAgICAg ICAgICAoIGtleXdvcmQgc3RyaW5nIGRlZmluaXRpb24pCiAgICAgICAgICAgICAgICAgICAo IGF0dHJpYnV0ZSBidWlsdGluIGNvbnN0YW50IGVzY2FwZS1zZXF1ZW5jZQotICAgICAgICAg ICAgICAgICAgICBmdW5jdGlvbiBudW1iZXIgcHJvcGVydHkgdHlwZSB2YXJpYWJsZSkKLSAg ICAgICAgICAgICAgICAgICggYnJhY2tldCBkZWxpbWl0ZXIgZXJyb3Igb3BlcmF0b3IpKSkK KyAgICAgICAgICAgICAgICAgICAgbnVtYmVyIHR5cGUpCisgICAgICAgICAgICAgICAgICAo IGJyYWNrZXQgZGVsaW1pdGVyIGVycm9yIG9wZXJhdG9yIGZ1bmN0aW9uIHByb3BlcnR5IHZh cmlhYmxlKSkpCiAKICAgICA7OyBJbWVudS4KICAgICAoc2V0cS1sb2NhbCB0cmVlc2l0LXNp bXBsZS1pbWVudS1zZXR0aW5ncwo= --------------NyQBXpH05RVgSCt1bEceqRC0-- From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 02:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Randy Taylor Cc: 61205@debbugs.gnu.org, yuan fu Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167530588011125 (code B ref 61205); Thu, 02 Feb 2023 02:45:02 +0000 Received: (at 61205) by debbugs.gnu.org; 2 Feb 2023 02:44:40 +0000 Received: from localhost ([127.0.0.1]:60272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNPaZ-0002tN-RE for submit@debbugs.gnu.org; Wed, 01 Feb 2023 21:44:40 -0500 Received: from mail-ej1-f50.google.com ([209.85.218.50]:36581) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNPaX-0002tA-CY for 61205@debbugs.gnu.org; Wed, 01 Feb 2023 21:44:38 -0500 Received: by mail-ej1-f50.google.com with SMTP id lu11so2192514ejb.3 for <61205@debbugs.gnu.org>; Wed, 01 Feb 2023 18:44:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=eWATD5LB3OHLCXYfvO9bSw4ys7X1GqnZEd0uSFIOtm4=; b=QWWNPSsAUyJMlcgfpGEFjl8VWDr9hmeaoiOSF3cjzgi37HB2lJyOmsLost5lGR2wG6 9RXS+kNHO8bzpp8fPxiZEAOeQYfAisy288xedgfulQU6T7pgUnHDmy8K6o9QpFsuk5oW LCn32giFqA73GMtNBTlu/l2cWQx9Pjt21tZhOMpnUbnOoxbJIGCI4yT7Xb2aQdxjy9EN MMrm7/QR4Bts7jvohTjfJe6TsneKWatQO7+lC3fParGKrUpGQUcFvO42BavIy0h8g0uD 7XXJVEBLP3v5VU/FFS/f7+f7B5wmrxXfSHCGlNbx0QjukdbhY+OuBhPTN6EtSCrlSHiC Mu5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eWATD5LB3OHLCXYfvO9bSw4ys7X1GqnZEd0uSFIOtm4=; b=yQGWpTaYgxQy67hCz+33MNwY4rszJDQTl+akgVTs4raV9LC9Vc4kmWxJ3f+b5joNmu ud36abi4x1duBlZYr1wR+hh+9BCN3pByPMJoP8Llxq3z5R1DQHprQXyIggs7thnSWIr2 3Eepy5cvFShJ/LgjhVohB4ZJnyaSL76NAAawnRYFfbIfNcAxwaUrJllhpBC7bMcbfIdx b2pHVkV+scE8n3xFyIx67+UdC8h4/BmAmqcDgFN1PAXR0EzrWM/80vJ9siv7L1hrapLN NTASgrRbgunSHSB3qQ6NFi0vzgHKJDGqbOES9vLBVfeqd5570FZ01sHnOpDwqRTFh3fF x0vQ== X-Gm-Message-State: AO0yUKVO95Ij+a9xVm6HXq9gniHW0K83pvTa7GLrTfCcJP5Ljy9uxFP/ G/aADfQyZG3zqWvR3xQ2EwA= X-Google-Smtp-Source: AK7set8bIeAVZ0JpC+HDJLxAWW2MBclVSYpcuULmjIR8gFbQGqpK573BQixz2YjJ1E58NX25WPudOQ== X-Received: by 2002:a17:906:254b:b0:879:4f94:41eb with SMTP id j11-20020a170906254b00b008794f9441ebmr4354810ejb.72.1675305870274; Wed, 01 Feb 2023 18:44:30 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id w5-20020a170906384500b00878003adeeesm10687258ejc.23.2023.02.01.18.44.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 18:44:29 -0800 (PST) Message-ID: <62bd269c-85bc-7689-cad1-d705ea9350cc@yandex.ru> Date: Thu, 2 Feb 2023 04:44:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 02/02/2023 04:34, Randy Taylor wrote: > On Tuesday, January 31st, 2023 at 21:08, Dmitry Gutov wrote: >> X-Debbugs-Cc: Yuan Fucasouri@gmail.com, Randy Taylordev@rjt.dev >> >> >> Some new built-in modes has 'function' feature highlighting thus enabled >> by default. >> >> rust-ts-mode, go-ts-mode, cmake-mode >> >> Should we move it to 4 for consistency with the rest? >> >> Previously, we talked about that and concluded that function calls are >> usually everywhere and are easy to notice without additional highlighting. > If that's what folks decided on then we should keep everything consistent. > > Personally, I find it odd that out of the box default highlighting wouldn't highlight function calls. I think that's more useful in some languages, and less in others. I guess we settled on this particular convention to be more consistent with existing major modes in Emacs. But I can see how it can be appealing, especially in languages with more complex syntax such as Rust. Same for 'property'. The one feature that I'm fairly certain is currently useless is 'variable', because we don't have any variable scope tracking (yet), and the grammars don't do it for us. So too many tokens get highlighted with font-lock-variable-name-face. Try the current rust-ts-mode, for example: almost everything ends up with that face. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 03:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61205@debbugs.gnu.org, Yuan Fu Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167530790114838 (code B ref 61205); Thu, 02 Feb 2023 03:19:01 +0000 Received: (at 61205) by debbugs.gnu.org; 2 Feb 2023 03:18:21 +0000 Received: from localhost ([127.0.0.1]:60279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNQ7B-0003rF-18 for submit@debbugs.gnu.org; Wed, 01 Feb 2023 22:18:21 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]:31085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNQ78-0003qw-00 for 61205@debbugs.gnu.org; Wed, 01 Feb 2023 22:18:19 -0500 Date: Thu, 02 Feb 2023 03:18:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1675307891; x=1675567091; bh=NI0cihw/WiwLbg0yV2FGxSbPMNdXEZ2bsdtGJuCt+2o=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=nGQvr1Qfji2Nyf2BvkE9cjUqwhKj6JCDVabtj2KYvBxy9E/nJhIMDzWos8fRvGT7r awt4INBr6NTZDf+YckrrvzEdWzBSKGSr5WatiVnmfE1IaRsH7ZAjH9byABqik+3BBw lG8HvTrx2vLTslQytkvd0oJiKqBrwGGqfAC3UOImI89KOY17GT/hlYWd4+2fNfqBqQ D0YnjeEzeVczkyOY6kpCA/jkRZYKA500frfb14qzS4Cwl0z572i/b8LS2UzEEeSUUj BwhzA51edKULOuTVLkVTHckwL4vSvLqZAvRgmlmPM58DqoDUGw9J5HqpuHH/ySgDLK h+9kQvk5U6MgA== From: Randy Taylor Message-ID: In-Reply-To: <775e21ae-6513-8dca-a669-bedae86bf02d@yandex.ru> References: <775e21ae-6513-8dca-a669-bedae86bf02d@yandex.ru> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wednesday, February 1st, 2023 at 21:34, Dmitry Gutov = wrote: > On 01/02/2023 07:18, Yuan Fu wrote: >=20 > > > On Jan 31, 2023, at 6:08 PM, Dmitry Gutov dgutov@yandex.ru wrote: > > >=20 > > > X-Debbugs-Cc: Yuan Fu casouri@gmail.com, Randy Taylor dev@rjt.dev > > >=20 > > > Some new built-in modes has 'function' feature highlighting thus enab= led by default. > > >=20 > > > rust-ts-mode, go-ts-mode, cmake-mode > > >=20 > > > Should we move it to 4 for consistency with the rest? > > >=20 > > > Previously, we talked about that and concluded that function calls ar= e usually everywhere and are easy to notice without additional highlighting= . > >=20 > > Right, I think they should be level 4. >=20 >=20 > OK, I tried simply changing that, and it turned out none of these modes > have a 'definition' feature, so highlightings get stripped from all > definitions as well. >=20 > And in a couple of cases function calls got highlighted either as a > type, or as a property. I fixed the latter by deleting one selector, and > the latter didn't touch per se. >=20 > But since the same modes had 'variable' and 'property' features in the > 3rd level as well, I moved them to the 4th (that resolved the incorrect > highlighting as property mentioned above, but it's probably need to be > improved later, in case someone will want to enable 'property' but not > 'function' highlighting). >=20 > And I added the 'definition' features and moved some highlighting rules > there. And added some. >=20 > So the patch looks a bit more complex than expected, see attached. >=20 > cmake-ts-mode, in the end, I ended up keeping as-is. The 'variable' > selector is more functional there than everywhere else (the grammar uses > those nodes for template expansion), and if 'function' is removed, the > buffer looks almost devoid of highlighting. >=20 > Also none of these modes have highlighting for function parameters or > assignments. That can be improved later. I just took a quick look (will have more time tomorrow hopefully), but: Why are there 2 separate definition features for both go and rust? There should just be one each. > - (scoped_identifier name: (identifier) @font-lock-type-face) Why was this removed? I think this will lead to some imports not being high= lighted at the very least. And please keep treesit-font-lock-feature-list alphabetized :). From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 03:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61205@debbugs.gnu.org, yuan fu Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167530858315955 (code B ref 61205); Thu, 02 Feb 2023 03:30:02 +0000 Received: (at 61205) by debbugs.gnu.org; 2 Feb 2023 03:29:43 +0000 Received: from localhost ([127.0.0.1]:60292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNQIB-00049H-4w for submit@debbugs.gnu.org; Wed, 01 Feb 2023 22:29:43 -0500 Received: from mail-4323.proton.ch ([185.70.43.23]:52899) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNQI6-000490-CF for 61205@debbugs.gnu.org; Wed, 01 Feb 2023 22:29:41 -0500 Date: Thu, 02 Feb 2023 03:29:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail2; t=1675308572; x=1675567772; bh=TVoUBmSuGkp4/LJbmcR7zmqO2wjGatThsobZdLYWT8g=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=PG5jRDe2OnWa1fLqSGLxFyfqD19c1cAve2GrsJygdglnCZNqlma3+wOLQFaxXA0Cy y2IGImiCgrtBJLJwt8I7rwdjNBXjIdbjYX6DJnmd+YJBCNSqaAdidWE6BByGtnpmPj Qz2ZfeNUEVyxQ+/p5tnVY4C+64JqW3UOP+XIeY/GMaH0vaW39z7D5EDw7LbXNl7iPJ AK9ylGI55BoOy96ebsb2Q1aD53REeU0AOhXGSZS8dJT6ilsPQ/9YAmedHx0rPGM1Eo kSGNlFuU+4/AZOM+KBqt5Qwyqii2DH/HOnwTj81+WnuPLDzjzrMB9lEAZt1UZUx9CX PXPrxN/tMtg8A== From: Randy Taylor Message-ID: In-Reply-To: <62bd269c-85bc-7689-cad1-d705ea9350cc@yandex.ru> References: <62bd269c-85bc-7689-cad1-d705ea9350cc@yandex.ru> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Wednesday, February 1st, 2023 at 21:44, Dmitry Gutov = wrote: > On 02/02/2023 04:34, Randy Taylor wrote: >=20 > > On Tuesday, January 31st, 2023 at 21:08, Dmitry Gutovdgutov@yandex.ru w= rote: > >=20 > > > X-Debbugs-Cc: Yuan Fucasouri@gmail.com, Randy Taylordev@rjt.dev > > >=20 > > > Some new built-in modes has 'function' feature highlighting thus enab= led > > > by default. > > >=20 > > > rust-ts-mode, go-ts-mode, cmake-mode > > >=20 > > > Should we move it to 4 for consistency with the rest? > > >=20 > > > Previously, we talked about that and concluded that function calls ar= e > > > usually everywhere and are easy to notice without additional highligh= ting. > > > If that's what folks decided on then we should keep everything consis= tent. > >=20 > > Personally, I find it odd that out of the box default highlighting woul= dn't highlight function calls. >=20 >=20 > I think that's more useful in some languages, and less in others. Sure, and people will have different opinions on it too. But I still think = out of the box we should be highlighting most things like other editors do.= It's easy enough to take out what you don't like. >=20 > I guess we settled on this particular convention to be more consistent > with existing major modes in Emacs. But I can see how it can be > appealing, especially in languages with more complex syntax such as Rust. >=20 > Same for 'property'. >=20 > The one feature that I'm fairly certain is currently useless is > 'variable', because we don't have any variable scope tracking (yet), and > the grammars don't do it for us. So too many tokens get highlighted with > font-lock-variable-name-face. Try the current rust-ts-mode, for example: > almost everything ends up with that face. If anything that isn't a variable is getting highlighted, then that's a bug= . Anything it's catching that isn't a variable can probably be dealt with s= imilar to how token_tree is dealt with. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 11:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Randy Taylor Cc: 61205@debbugs.gnu.org, Yuan Fu Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.16753357936702 (code B ref 61205); Thu, 02 Feb 2023 11:04:01 +0000 Received: (at 61205) by debbugs.gnu.org; 2 Feb 2023 11:03:13 +0000 Received: from localhost ([127.0.0.1]:60914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNXN2-0001k1-RP for submit@debbugs.gnu.org; Thu, 02 Feb 2023 06:03:13 -0500 Received: from mail-ej1-f47.google.com ([209.85.218.47]:37757) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNXMz-0001jj-QG for 61205@debbugs.gnu.org; Thu, 02 Feb 2023 06:03:11 -0500 Received: by mail-ej1-f47.google.com with SMTP id ud5so4871035ejc.4 for <61205@debbugs.gnu.org>; Thu, 02 Feb 2023 03:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=bMRFxhFRaSR6ZvFXMQnbfCJiV+gThI/Ffa/PakL47u8=; b=jpcCPvaqGsgv9+s8k8Oebvy4y4RXVX+1VmHtwZovcc4r+tKu5N3cYqrIItGA/dlldW 3brojmaN+OtLZ7Q//0AQXjdQG/SA2cbZIqtKgJF0lEN6J820bnZCF9U37PM99RnK7hKF bqIr2W1B2GjpSArM/L4ddXZ2jw5XB54ykZSzKwHCGxCCFExLz98VHMRHfZvHkdc5xTpV J5ElGOPpwi4PRb2kAPrNkReHSRpXvbR/Y1Pltq969SQG1HtDz98qpEv7ayPbh34Q/mzf 8WnhbTOOU9OE3TTTo1J+WYJ454mC9pqMKCkAyhIicoRxJiDm9xkwMd05V3tCU8v6Ptsq kKig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bMRFxhFRaSR6ZvFXMQnbfCJiV+gThI/Ffa/PakL47u8=; b=fIkyC+H8EJGjCVwWiD2nwilmEul3Ht6Ia7imrtLRxJWCG6ZazB/J1u0uN0mdKxHoGa vIwrK02lzXIYo5TDH+Ef6AZGQoiTSpKRZkQX16XPnjHG+J59HYyWXGKaTF4CooCqdDL6 n5wTWpBavemiiFkz/faeeqcFDkSLtUSWzagwwH+Zos7wsMpfeiouytlJXdwPLIAqILqc X4I3Dn3EqbZHTj0OkMqmHQUJBt++bENQ74JJWM5dg9JJeJtQrvBo3O1WeBEimRiAZcaR plxpu0r1dFzwIP7+cBIMasHVQC6M/9sdkjWuSjom0C91gFQ21KuXMDp0sZL3Hmen7pja RHbQ== X-Gm-Message-State: AO0yUKU+R3PDr7V5ke7q/vdm9uNF4fu+NIqlSSfXCTbnXTY4j316x2ru b7K5x6DOdsvPXg5IBGlhR24= X-Google-Smtp-Source: AK7set/nR1cxshhgm1ZS9t9DqCKYIaGHEJBF9smJmyyt5MZU0tBmUdQnlVZiZSPqDNX+X5H8VJM1LA== X-Received: by 2002:a17:907:a501:b0:877:612e:516e with SMTP id vr1-20020a170907a50100b00877612e516emr1486302ejc.61.1675335783670; Thu, 02 Feb 2023 03:03:03 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id ab13-20020a170907340d00b0088e9bbae7ecsm1415253ejc.165.2023.02.02.03.03.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 03:03:03 -0800 (PST) Message-ID: Date: Thu, 2 Feb 2023 13:03:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <775e21ae-6513-8dca-a669-bedae86bf02d@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 02/02/2023 05:18, Randy Taylor wrote: > On Wednesday, February 1st, 2023 at 21:34, Dmitry Gutov wrote: >> On 01/02/2023 07:18, Yuan Fu wrote: >> >>>> On Jan 31, 2023, at 6:08 PM, Dmitry Gutov dgutov@yandex.ru wrote: >>>> >>>> X-Debbugs-Cc: Yuan Fu casouri@gmail.com, Randy Taylor dev@rjt.dev >>>> >>>> Some new built-in modes has 'function' feature highlighting thus enabled by default. >>>> >>>> rust-ts-mode, go-ts-mode, cmake-mode >>>> >>>> Should we move it to 4 for consistency with the rest? >>>> >>>> Previously, we talked about that and concluded that function calls are usually everywhere and are easy to notice without additional highlighting. >>> >>> Right, I think they should be level 4. >> >> >> OK, I tried simply changing that, and it turned out none of these modes >> have a 'definition' feature, so highlightings get stripped from all >> definitions as well. >> >> And in a couple of cases function calls got highlighted either as a >> type, or as a property. I fixed the latter by deleting one selector, and >> the latter didn't touch per se. >> >> But since the same modes had 'variable' and 'property' features in the >> 3rd level as well, I moved them to the 4th (that resolved the incorrect >> highlighting as property mentioned above, but it's probably need to be >> improved later, in case someone will want to enable 'property' but not >> 'function' highlighting). >> >> And I added the 'definition' features and moved some highlighting rules >> there. And added some. >> >> So the patch looks a bit more complex than expected, see attached. >> >> cmake-ts-mode, in the end, I ended up keeping as-is. The 'variable' >> selector is more functional there than everywhere else (the grammar uses >> those nodes for template expansion), and if 'function' is removed, the >> buffer looks almost devoid of highlighting. >> >> Also none of these modes have highlighting for function parameters or >> assignments. That can be improved later. > > I just took a quick look (will have more time tomorrow hopefully), but: > > Why are there 2 separate definition features for both go and rust? > There should just be one each. It was an arbitrary choice on my part: the queries highlight different things (with different faces), so I put them separately. I don't mind if we combine them. >> - (scoped_identifier name: (identifier) @font-lock-type-face) > > Why was this removed? I think this will lead to some imports not being highlighted at the very least. It led to code like 'test1' in test::test1(); being highlighted with the font-lock-property-face. I didn't have a lot of time to spend on this, so just removed the rule. Some imports indeed are missing highlighting as a result. Perhaps the queries need to be scoped to 'use_declaration' nodes? > And please keep treesit-font-lock-feature-list alphabetized :). Sure. And in case you wanted to propose the next revision of this patch, I certainly wouldn't mind ;-) From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 11:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Randy Taylor Cc: 61205@debbugs.gnu.org, yuan fu Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.16753363037523 (code B ref 61205); Thu, 02 Feb 2023 11:12:01 +0000 Received: (at 61205) by debbugs.gnu.org; 2 Feb 2023 11:11:43 +0000 Received: from localhost ([127.0.0.1]:60918 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNXVH-0001xG-2h for submit@debbugs.gnu.org; Thu, 02 Feb 2023 06:11:43 -0500 Received: from mail-wm1-f44.google.com ([209.85.128.44]:43890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNXVC-0001wu-N5 for 61205@debbugs.gnu.org; Thu, 02 Feb 2023 06:11:42 -0500 Received: by mail-wm1-f44.google.com with SMTP id d4-20020a05600c3ac400b003db1de2aef0so1090118wms.2 for <61205@debbugs.gnu.org>; Thu, 02 Feb 2023 03:11:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=9JrLTMjtd3+WYhtLYRzT2NrEEPol4uL24Tv1LYczK3o=; b=BMwajRHuDKOAHY6/zUI5f+0a5Crghi1Q0menFTaAOZGuULBIhned9P1SR6h7Ypp4P4 fpbuEXjB5tsdobKXVZzfhk/k3L7gP2wFsOjDVpFfAsXYxekEbfUGevcUQ+vfQHczr9aQ OyNKqi7mO2oAuD184RVSRAdSNFkNgEnvduX66ywsF9sjLdw6wpvsZme0Ab+3KCudTtNT SHIiAM11ejYvmuO1rLwPKDsVenQzmY5sVsUMArP4B9cXlVcu80A5zS3WtXTbn49CTo3u EtCov8lnsGfZiDhu24WXav/6+p495ALGTUrmFDbtv4YAIJv8HpohLxH92D6dItcIPF8A 8a8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9JrLTMjtd3+WYhtLYRzT2NrEEPol4uL24Tv1LYczK3o=; b=VGiQAzIhcaS0vlrr/yiA/3/lIXvx7QnlmvVAPsXyK1fUflonnjAL8j4YbhW2aTP+0f hKPXYmljibdW0feNO+qJJWA9gCriyXf/1DpaOQzQZBi03RngOYTR9J6QL6v02jovbhdL fYtMU4szsP5EjOnWRsB/Wt0UTg1W6uT9ORaBRpEVmJyfkfnk0HRtHo6/4my958By6KwW gAR2MzlGlW0jat/U5JGti0Tx0hCaMApef2Wacrp3gwEdRsrdYmqHL775ahdGfXus3ziW 6NYYq/1qJcKZoFwfd/mzlVPzzNPBhszjnDIPeByNVRtj90EKJamkIwYGLoOCCTTlUipK 8E/A== X-Gm-Message-State: AO0yUKUIbNJHQRZY3QNy0oqikVOgjUR+X+Tv6a7DzoCmq4+8i6u9ixUh SoNEV91RTq9+CavBk7dKIzA= X-Google-Smtp-Source: AK7set/ED5gNGdZT9eBDjei74QjOhBmnJDw7/azHJF5BCLv7mHKNev5wj4X7nZpL3El/Wp+Pv+fTVQ== X-Received: by 2002:a05:600c:19d1:b0:3dc:3f1b:6757 with SMTP id u17-20020a05600c19d100b003dc3f1b6757mr5510316wmq.15.1675336292718; Thu, 02 Feb 2023 03:11:32 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id y10-20020a05600c364a00b003daf7721bb3sm4297685wmq.12.2023.02.02.03.11.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 03:11:32 -0800 (PST) Message-ID: <064e85bd-704e-8def-577f-b30fed449e21@yandex.ru> Date: Thu, 2 Feb 2023 13:11:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <62bd269c-85bc-7689-cad1-d705ea9350cc@yandex.ru> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 02/02/2023 05:29, Randy Taylor wrote: > On Wednesday, February 1st, 2023 at 21:44, Dmitry Gutov wrote: >> On 02/02/2023 04:34, Randy Taylor wrote: >> >>> On Tuesday, January 31st, 2023 at 21:08, Dmitry Gutovdgutov@yandex.ru wrote: >>> >>>> X-Debbugs-Cc: Yuan Fucasouri@gmail.com, Randy Taylordev@rjt.dev >>>> >>>> Some new built-in modes has 'function' feature highlighting thus enabled >>>> by default. >>>> >>>> rust-ts-mode, go-ts-mode, cmake-mode >>>> >>>> Should we move it to 4 for consistency with the rest? >>>> >>>> Previously, we talked about that and concluded that function calls are >>>> usually everywhere and are easy to notice without additional highlighting. >>>> If that's what folks decided on then we should keep everything consistent. >>> >>> Personally, I find it odd that out of the box default highlighting wouldn't highlight function calls. >> >> >> I think that's more useful in some languages, and less in others. > > Sure, and people will have different opinions on it too. But I still think out of the box we should be highlighting most things like other editors do. Perhaps we should have an extra level between 3 (highlight sparingly like other Emacs modes do) and 4 (highlight everything including stuff that doesn't always look great). > It's easy enough to take out what you don't like. Note that in this case "taking out" some things uncovered that the highlighting really isn't great in a different configuration. >> I guess we settled on this particular convention to be more consistent >> with existing major modes in Emacs. But I can see how it can be >> appealing, especially in languages with more complex syntax such as Rust. >> >> Same for 'property'. >> >> The one feature that I'm fairly certain is currently useless is >> 'variable', because we don't have any variable scope tracking (yet), and >> the grammars don't do it for us. So too many tokens get highlighted with >> font-lock-variable-name-face. Try the current rust-ts-mode, for example: >> almost everything ends up with that face. > > If anything that isn't a variable is getting highlighted, then that's a bug. Anything it's catching that isn't a variable can probably be dealt with similar to how token_tree is dealt with. With a list of exceptions? I hadn't thought about that. But it sounds like it might be a fair amount of work. Depends on the specific grammar, of course. Note that you'd also need to add such rules for every "feature" that might be disabled by the user, for its identifier tokens not to start being highlighted as a variable (if the user kept 'variable' in the features list). That's the current design we're working off. And tree-sitter has a recommended mechanism for highlighting locals. We just haven't implemented it yet. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 20:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: 61205@debbugs.gnu.org, Theodor Thornhill , randy taylor Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.16753695577484 (code B ref 61205); Thu, 02 Feb 2023 20:26:02 +0000 Received: (at 61205) by debbugs.gnu.org; 2 Feb 2023 20:25:57 +0000 Received: from localhost ([127.0.0.1]:35908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNg9c-0001wd-Vf for submit@debbugs.gnu.org; Thu, 02 Feb 2023 15:25:57 -0500 Received: from mail-ej1-f43.google.com ([209.85.218.43]:35683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNg9b-0001wQ-Li for 61205@debbugs.gnu.org; Thu, 02 Feb 2023 15:25:56 -0500 Received: by mail-ej1-f43.google.com with SMTP id qw12so9489862ejc.2 for <61205@debbugs.gnu.org>; Thu, 02 Feb 2023 12:25:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=4tz/Yf28vCm93+FhUzrRnIdjJADSyVLKnM/+e9kspLU=; b=OsideKQKbmaTJbW/LjXk8+58WuVyzvDnZDdcuFl8HGCcbYaRatiPxAf0q9q6wNRl9g niRyvKlFGuBnWRB2LE0Pn105pTOkagTz68KqnmRAJP6p6AOT66077DIo4mAY/MaOydgE CCjqzmvpN5A6k5JVvkLQ8AWrwbjQuAPq0+QRDJPz6IfimPhOpGq1sVfqDF7rGP6V6rZD tXkIHobRrcTFLV2LcIYs4/03Y5LdIoZPco4IabLULmrnEaZo6fQMMdMZA2txZD3znrOW BAH5uYc1SJDuDXrZ0qcoT5NPVKPfX7no43dtIMeqUu+HqB82Q1P4G5z5ttD3TguAemHt 0ggw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4tz/Yf28vCm93+FhUzrRnIdjJADSyVLKnM/+e9kspLU=; b=VkjK4r1fV6xZG6yJTx7vOmYPWE2x5FqhItL1690mxDoDswNphIcF/dbEgVPOBdONxx bfwDVaLsXv0o4AHmsd7YHjEALJ0rxB/8vZJsR7xpcCI9RddR0jAJiqRhCOtw1ZsF8COQ aZ1CrZ5RyByNDwU00A0JfH7jPjw0KMpMJkhkanGVvTefj/kLeWp1T9likWIMV6Cl6pJk 5W+r+8JBEdJAQFrcYw7I6ICoTN4Xa/pLyvE0llJEnatCnTbzKhE0Vpe1igiWb9cpECqh ME/+xqBjFkr1EigkdzyrTxYy60Ipr4jhs6/14ZZ+MfjmrZArPVv3vggf4iPaBgOWHYcp ZnLw== X-Gm-Message-State: AO0yUKXeKBQHohuDdwziLC4RYhMKP49yhRRYf0GAu8tD0LrRvvv9mw1j rgbvIHgGwJfiHtHTXtnBPis= X-Google-Smtp-Source: AK7set9vpEp/w00ykLKSRw4reb/G5soPFCFi6IdwMp8bo2mJYNJiVY4mh1y4UW+JkRRdnSGD45D42Q== X-Received: by 2002:a17:906:26cc:b0:878:605e:dbe7 with SMTP id u12-20020a17090626cc00b00878605edbe7mr6489154ejc.3.1675369549754; Thu, 02 Feb 2023 12:25:49 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id 17-20020a170906201100b007ae32daf4b9sm263962ejo.106.2023.02.02.12.25.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 12:25:49 -0800 (PST) Message-ID: Date: Thu, 2 Feb 2023 22:25:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 01/02/2023 07:18, Yuan Fu wrote: > >> On Jan 31, 2023, at 6:08 PM, Dmitry Gutov wrote: >> >> X-Debbugs-Cc: Yuan Fu, Randy Taylor >> >> Some new built-in modes has 'function' feature highlighting thus enabled by default. >> >> rust-ts-mode, go-ts-mode, cmake-mode >> >> Should we move it to 4 for consistency with the rest? >> >> Previously, we talked about that and concluded that function calls are usually everywhere and are easy to notice without additional highlighting. > Right, I think they should be level 4. On a related note: 'property' is in level 3 in c-ts-mode. Should it to go level 4? Also in typescript-ts-mode. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 02:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61205@debbugs.gnu.org, Theodor Thornhill , Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , randy taylor Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167539193822928 (code B ref 61205); Fri, 03 Feb 2023 02:39:02 +0000 Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 02:38:58 +0000 Received: from localhost ([127.0.0.1]:36212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNlyb-0005xk-SV for submit@debbugs.gnu.org; Thu, 02 Feb 2023 21:38:58 -0500 Received: from mail-pl1-f175.google.com ([209.85.214.175]:35444) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNlyZ-0005xT-FW for 61205@debbugs.gnu.org; Thu, 02 Feb 2023 21:38:56 -0500 Received: by mail-pl1-f175.google.com with SMTP id r8so3938625pls.2 for <61205@debbugs.gnu.org>; Thu, 02 Feb 2023 18:38:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6qdrBmxQ2mphRyqdR+xI+LbjZbo0AFKRCga76Zaociw=; b=lSQT/XBnQWSJP5lm0WBVbXOfj/vN7KGkAdkPIvbp7TI5eQrIBlDGV/+D8TVQIOcJBF 0LEEOrYo4HCUFfUaww+1+YyMnX+hFfzBjKoG/vWDuimM1m/qEtjJefZHthx2nJtW6n2Y Zsfot+nEYlqEt9cJOB6Df4mwQyNmMAGE82S0zWD3RstJ4+eXUMXe5MsqzQj6I5lPcfgO cy/o7i1zloHGpMIDKRCJiZZUwwR/R15rFvfI3pNRu/DSsmqdYMk1/0miTtPicQXgC0OZ 70dHwJpa4FYJ3wLN5OQ9J4gTx49EvgU4mPm2bg6ikRiO8Mj6mKSAVCktFGQXD63rBDfT 2h4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6qdrBmxQ2mphRyqdR+xI+LbjZbo0AFKRCga76Zaociw=; b=peS+okBjJAy/1kXsMOWAxoq5+bXtvwRFRMtYxKqTFY4XR4htRNstORXFJWTO7vYXmm IX2ZM6hDH6culL3ginYj65hTAxWRrcJMPcLw71Wy9rQCcEUoZG6oRECIFI1RAlHAbRQ9 UvlmqlN4ZfKujCJOAZooAeCqEaXKaoKtoQkA1UvAXY3XsKwf2+jZcdw9Ep3jny7qAS9A QYzhduZp10Y+B2udW1K89iSWOV4AivINT97EHC2GQNkmvUAWUM1MdiOMBNG/6pOh0EUz ostGjlhAXDTslk/gUrFRFi7kXQpD15Byq4N+555qOJWPuTuAwyCPaZndRI6mEWaL9Dcg xJhg== X-Gm-Message-State: AO0yUKVDjjNruSUCUW5FP7p7dgFoK8hvC8ocPGpdjEevZHyncc74agzH qHcMQ9pBspyYSvLfmnfI/9o= X-Google-Smtp-Source: AK7set9Ua2B8w5Z8LDmE3bpE7lNwHp6jZfZvvC9zaAjMq/KxG4umq6ToNVGPIIUIFxwiOJMm3LUixQ== X-Received: by 2002:a05:6a20:bc96:b0:be:39b0:42e0 with SMTP id fx22-20020a056a20bc9600b000be39b042e0mr7960718pzb.19.1675391929480; Thu, 02 Feb 2023 18:38:49 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id 5-20020a170902e9c500b0018bde2250fcsm359598plk.203.2023.02.02.18.38.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 02 Feb 2023 18:38:49 -0800 (PST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) From: Yuan Fu In-Reply-To: Date: Thu, 2 Feb 2023 18:38:37 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <645D27C7-0376-45F9-A5C9-CD84F9467ED4@gmail.com> References: X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Feb 2, 2023, at 12:25 PM, Dmitry Gutov wrote: >=20 > On 01/02/2023 07:18, Yuan Fu wrote: >>> On Jan 31, 2023, at 6:08 PM, Dmitry Gutov wrote: >>>=20 >>> X-Debbugs-Cc: Yuan Fu, Randy Taylor >>>=20 >>> Some new built-in modes has 'function' feature highlighting thus = enabled by default. >>>=20 >>> rust-ts-mode, go-ts-mode, cmake-mode >>>=20 >>> Should we move it to 4 for consistency with the rest? >>>=20 >>> Previously, we talked about that and concluded that function calls = are usually everywhere and are easy to notice without additional = highlighting. >> Right, I think they should be level 4. >=20 > On a related note: 'property' is in level 3 in c-ts-mode. >=20 > Should it to go level 4? I believe property is level 3. Quoting the (emacs) manual: Level 1 This level usually fontifies only comments and function names in function definitions. Level 2 This level adds fontification of keywords, strings, and data types. Level 3 This is the default level; it adds fontification of assignments, numbers, properties, etc. Level 4 This level adds everything else that can be fontified: operators, delimiters, brackets, other punctuation, function names in function calls, variables, etc. Yuan= From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 02:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: 61205@debbugs.gnu.org, Theodor Thornhill , Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , randy taylor Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167539267624419 (code B ref 61205); Fri, 03 Feb 2023 02:52:01 +0000 Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 02:51:16 +0000 Received: from localhost ([127.0.0.1]:36231 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNmAW-0006Ln-6N for submit@debbugs.gnu.org; Thu, 02 Feb 2023 21:51:16 -0500 Received: from mail-ej1-f43.google.com ([209.85.218.43]:41930) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNmAS-0006LV-J0 for 61205@debbugs.gnu.org; Thu, 02 Feb 2023 21:51:14 -0500 Received: by mail-ej1-f43.google.com with SMTP id m2so11689594ejb.8 for <61205@debbugs.gnu.org>; Thu, 02 Feb 2023 18:51:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=pHJ/IGDn++00Fll+wqbuNCH7fuHA8UHd2Yu7UA2u0uQ=; b=LYzflvXCVEjUcacSLbe/YDZ0xODxqFn4g/q5eC5rbPHJWYxITs13ii8EoFD6fk/t8x tZaKrk6XxSn8XxApbG8r5GJSSJK8jA6S5ZR24wGyFAE1yCKhxVzzk3E0vtuqADB0q0vM dDdfAzVt2bz0QIy+T16fiXHaOtSO9tk5RBW/sxtyeQu1qNLdlf2cnkV9orWsqlpO4wy0 7m2tn6p4rSAfJvIgLW0LhBAVwJOYZrSsH2eXyf3la5+cFTcfFr8/x9D+PW4/TvQIvBfx JiuTCP2GYlhcJuuDDAkE+q7/cvny0HxNSPIWUTCxJy8F5gsGO0XNQR+H+uKg1NCapBGW EjWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pHJ/IGDn++00Fll+wqbuNCH7fuHA8UHd2Yu7UA2u0uQ=; b=OMoWAfJznJVFH3XREV5X/w/jXN/iu49D9uw89ta7O58LEHx8sMml8lOq00xoLSODf7 C+YJUFO7Mgdgkalx6HT19nz/5IY6udoPP6qQYMkorToZkeNIWLWIh3oIemBOj96QzThy w5CzBwTzLtC6FyZaK5cRPn67NNzzL3lRCobBzi7yZRWrcUcMQs0zdHR+p4o1+ly017iZ 5q7h1PM8HOAv+7VkyD1vmyGOyxVYVZML5boEME2p0Am17UgURzKJg8NI+3vViDPdGy2E uB4y6gJlNhSiwgOVPm5M+BOTf+98ztmnBBnKy6oUkUC49sii5cE9E6pjGfs3Z89mBIUJ Npag== X-Gm-Message-State: AO0yUKWx7y4xlh/KVasuMJOYYlOM2om00ZzR7iT/ryn7Lr5xjHmZJzxt ybqXogQXdbu4MtQY1J557M0= X-Google-Smtp-Source: AK7set/NQ5jBd87D9vMa3jyIiNBNznHat/bM8yegy3wsoadmlMk+7tZ96YkDohXvfVNm+msl325PUg== X-Received: by 2002:a17:906:b7d7:b0:88d:fe1:1aca with SMTP id fy23-20020a170906b7d700b0088d0fe11acamr9172747ejb.34.1675392666620; Thu, 02 Feb 2023 18:51:06 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id cd11-20020a170906b34b00b008720c458bd4sm682785ejb.3.2023.02.02.18.51.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Feb 2023 18:51:05 -0800 (PST) Message-ID: <250a9090-8415-9fda-1622-cc9073328fb9@yandex.ru> Date: Fri, 3 Feb 2023 04:51:04 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <645D27C7-0376-45F9-A5C9-CD84F9467ED4@gmail.com> From: Dmitry Gutov In-Reply-To: <645D27C7-0376-45F9-A5C9-CD84F9467ED4@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 03/02/2023 04:38, Yuan Fu wrote: > > >> On Feb 2, 2023, at 12:25 PM, Dmitry Gutov wrote: >> >> On 01/02/2023 07:18, Yuan Fu wrote: >>>> On Jan 31, 2023, at 6:08 PM, Dmitry Gutov wrote: >>>> >>>> X-Debbugs-Cc: Yuan Fu, Randy Taylor >>>> >>>> Some new built-in modes has 'function' feature highlighting thus enabled by default. >>>> >>>> rust-ts-mode, go-ts-mode, cmake-mode >>>> >>>> Should we move it to 4 for consistency with the rest? >>>> >>>> Previously, we talked about that and concluded that function calls are usually everywhere and are easy to notice without additional highlighting. >>> Right, I think they should be level 4. >> >> On a related note: 'property' is in level 3 in c-ts-mode. >> >> Should it to go level 4? > > I believe property is level 3. Quoting the (emacs) manual: > > Level 1 > This level usually fontifies only comments and function names in > function definitions. > Level 2 > This level adds fontification of keywords, strings, and data types. > Level 3 > This is the default level; it adds fontification of assignments, > numbers, properties, etc. > Level 4 > This level adds everything else that can be fontified: operators, > delimiters, brackets, other punctuation, function names in function > calls, variables, etc. The manual could be updated. Here's where we seem to have agreed that is should be level 4: https://lists.gnu.org/archive/html/emacs-devel/2022-12/msg01221.html Even that discussion aside, property accesses and function calls seem to be similar enough as syntactic elements (in terms of position, usage, and frequency), so they should probably be on the same level. Don't you think? From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 06:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, jostein@secure.kjonigsen.net, dev@rjt.dev Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167540672518284 (code B ref 61205); Fri, 03 Feb 2023 06:46:02 +0000 Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 06:45:25 +0000 Received: from localhost ([127.0.0.1]:36361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNpp7-0004kp-3g for submit@debbugs.gnu.org; Fri, 03 Feb 2023 01:45:25 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNpp4-0004ka-N2 for 61205@debbugs.gnu.org; Fri, 03 Feb 2023 01:45:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNpoz-0000YC-4T; Fri, 03 Feb 2023 01:45:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=fpRplM6LSHJq3cm6IwGgNhR5WO+qFpmj7ilFFQ2kD2g=; b=Elyx1L5pMP43M9oUOjZ+ V93kqNVnpsH3Qgg+7ApyL47FieUF49CNqDEMHh4nKaJC+exY8j99mlYDvAhTm+UuoVGoZAbUzW4RV Mq2NrfUCUe/GzwcxBdUInZmZKGhHBJ9REahnEB6a67qZ6xpPVO5E8ORNfkVs6rg3FCWNYsCRPlO/o uixZ2oXKTwtFFGuTgtio1T/yZkH2HAzKC05fV6N3Cql2wMTGAjsUExYBfKhnhsYcUT3ilB1sMVALv 28dbqavaC2XqZA5bj/pkzeT1bLEGs34us0bcMrW3JeKHFCgCvt5Cwa+Z3blr17WKkkSR9DBZC6MC+ wDYekOqzKh7dPg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNpov-000660-6y; Fri, 03 Feb 2023 01:45:16 -0500 Date: Fri, 03 Feb 2023 08:45:15 +0200 Message-Id: <838rhfw8lg.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <250a9090-8415-9fda-1622-cc9073328fb9@yandex.ru> (message from Dmitry Gutov on Fri, 3 Feb 2023 04:51:04 +0200) References: <645D27C7-0376-45F9-A5C9-CD84F9467ED4@gmail.com> <250a9090-8415-9fda-1622-cc9073328fb9@yandex.ru> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 61205@debbugs.gnu.org, Theodor Thornhill , > Jostein Kjønigsen , > randy taylor > Date: Fri, 3 Feb 2023 04:51:04 +0200 > From: Dmitry Gutov > > >> On a related note: 'property' is in level 3 in c-ts-mode. > >> > >> Should it to go level 4? > > > > I believe property is level 3. Quoting the (emacs) manual: > > > > Level 1 > > This level usually fontifies only comments and function names in > > function definitions. > > Level 2 > > This level adds fontification of keywords, strings, and data types. > > Level 3 > > This is the default level; it adds fontification of assignments, > > numbers, properties, etc. > > Level 4 > > This level adds everything else that can be fontified: operators, > > delimiters, brackets, other punctuation, function names in function > > calls, variables, etc. > > The manual could be updated. > > Here's where we seem to have agreed that is should be level 4: > https://lists.gnu.org/archive/html/emacs-devel/2022-12/msg01221.html Whatever you decide, please keep the doc string of treesit-font-lock-level and the manual in sync. I already needed to fix those more than once because the code "disagreed" with the documentation. The pretest is too close for us to be able to sustain such inaccuracies and resolve them in time. So please present the patches to this effect for review and comments before installing them. TIA. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 06:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167540680618429 (code B ref 61205); Fri, 03 Feb 2023 06:47:01 +0000 Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 06:46:46 +0000 Received: from localhost ([127.0.0.1]:36366 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNpqP-0004nB-Lp for submit@debbugs.gnu.org; Fri, 03 Feb 2023 01:46:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNpqO-0004my-Ms for 61205@debbugs.gnu.org; Fri, 03 Feb 2023 01:46:45 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNpqJ-0000sa-DQ; Fri, 03 Feb 2023 01:46:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=fRzSFEWn3IJ+P8oWIPSzxQFUxUA5qW/gM2gt791A7Bg=; b=Zg7swbK9NQ+Q Gn7huhJ2O+svios2kie3U88Lx1AYz1Zo1QX4wjYTtddfKncuk+9V0NtuEY73uTHPPRLBCQf3iCi9S FQu4AmC1iJoHAF44qxKA6eQn/SnoUw2B8AQmBa+d3ghiW5zKaNg8KcdjkWkfhlMnSPmZW00QHHhZZ yeaNO8ldk+85Db2MZKRNgiSQNMtf1052mdsvvCIk9hTG709seMGIbIwhVaOxdLqfg8qlxt3JItTHX X06jKazGpegjx+B0hIIN3Z6lhTz8LVzI1bpWT9OzBnmXD8XmhEE1T4EIQUWPswMKXSwv7Up+v2zq3 YS+bxCXHyAE+ZOBHHxMBow==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNpqI-0006N0-ET; Fri, 03 Feb 2023 01:46:38 -0500 Date: Fri, 03 Feb 2023 08:46:42 +0200 Message-Id: <837cwzw8j1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Dmitry Gutov on Thu, 2 Feb 2023 22:25:47 +0200) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 61205@debbugs.gnu.org, Theodor Thornhill , > randy taylor > Date: Thu, 2 Feb 2023 22:25:47 +0200 > From: Dmitry Gutov > > On a related note: 'property' is in level 3 in c-ts-mode. > > Should it to go level 4? > > Also in typescript-ts-mode. What is 'property' in those modes? In c-ts-mode, is 'property' the name of a struct or enum member, as in foo.bar? Or is it something else? From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 11:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.16754245821195 (code B ref 61205); Fri, 03 Feb 2023 11:44:01 +0000 Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 11:43:02 +0000 Received: from localhost ([127.0.0.1]:36616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNuT7-0000JD-S3 for submit@debbugs.gnu.org; Fri, 03 Feb 2023 06:43:02 -0500 Received: from mail-ed1-f51.google.com ([209.85.208.51]:41858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNuT6-0000Ik-8U for 61205@debbugs.gnu.org; Fri, 03 Feb 2023 06:43:01 -0500 Received: by mail-ed1-f51.google.com with SMTP id v10so4883650edi.8 for <61205@debbugs.gnu.org>; Fri, 03 Feb 2023 03:43:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=+xtexzu3ME3IRlFtotAIvLuNh7kDRhrtG9ku2MHYW7Y=; b=hVLnwBecGmh7cA6U5lZPbPIcsC0UpmTJXZTOmIVSHk6m1eh6PVOwWaOE2Re4DGDYIq uqVYjGH+H2eWCOr+J0hU4WsgD//+wpNqtj9AxofqwVeESCY2ZLXOoOqDTBgzkVMwefSm rhDSTbgcBwFqIlREtdwOsLJuqyyl4Q9vz+wjbrsL0GHuL84p9a96BL06hY1plTx+v3FM 6FiHn4BqK26Pf12AYK6KJHIOG9U+jIPWtupwDv/Sa3BE2VX61ueWIs9A92yn2EpqG/P9 Z1QSfzXEY9rxPWpjdStHvUqPI9uItL5Df0JZPxU/MCslzya7lzQ0UoAXm39BQ1JCmoxN J0Fw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+xtexzu3ME3IRlFtotAIvLuNh7kDRhrtG9ku2MHYW7Y=; b=FFo+lS4FyFpWvfnO9cEGO0q/fjNIpnkw+Rg4rFvL3vIetjvfqT2/bRcsrD3hsZunso fUvuaVfksl4V5JqsTq0o1CpVmbi2MUIqh0S+oUkrAsqVgCJxdsX3MFq4ozw1MsbDhn39 owJDCzI0GoSc9/LYgt2SbYBXQ64TMMQ78z/Z5SL/YDznFEkN3LIB9IALlsx1AvUgfJZD Lv6OHyUZbuifYBeE5rRaDIQPgK8HmEiXGLqtnaKwvI14fjKsLd2+4czMrHOw62yk0WkS P0lD/FakYk7Ekv3SWWygTQ98rsLQqT1F4Xv1s37zE02bKCNvjJ4PXtQJniE+OhfXIscq rrjg== X-Gm-Message-State: AO0yUKVgKHmClKjn6WbksTtan06pFfexLAYQWz91LX3LJ1w6Sd5db4fO QHrkcOqn3Yav4sNEARrlYuU= X-Google-Smtp-Source: AK7set9sqvHHX0FFNr6DL0ZBnBD1108crWL80C9bYx8lSawf+bVq/ctnGF9RdTV14X2B/RGXOLMtrA== X-Received: by 2002:a05:6402:22a9:b0:4a2:4ed3:c14c with SMTP id cx9-20020a05640222a900b004a24ed3c14cmr8206663edb.39.1675424574254; Fri, 03 Feb 2023 03:42:54 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v21-20020a509555000000b004a9cb25d1eesm346960eda.87.2023.02.03.03.42.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 03:42:53 -0800 (PST) Message-ID: <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> Date: Fri, 3 Feb 2023 13:42:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <837cwzw8j1.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <837cwzw8j1.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 03/02/2023 08:46, Eli Zaretskii wrote: >> Cc:61205@debbugs.gnu.org, Theodor Thornhill, >> randy taylor >> Date: Thu, 2 Feb 2023 22:25:47 +0200 >> From: Dmitry Gutov >> >> On a related note: 'property' is in level 3 in c-ts-mode. >> >> Should it to go level 4? >> >> Also in typescript-ts-mode. > What is 'property' in those modes? In c-ts-mode, is 'property' the > name of a struct or enum member, as in foo.bar? Or is it something > else? It's the 'bar' in 'foo.bar', yes. Specifically in the cases where it's being looked up, rather than defined (in a type definition). Examples: it2.lnum_pixel_width = it.lnum_pixel_width; || (it.bidi_p && it.bidi_it.scan_dir == -1 'lnum_pixel_width', 'bidi_p', 'bidi_it' and 'scan_dir' are highlighted with font-lock-property-face. You can see it for yourself by trying c-ts-mode in any of our files. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 12:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.16754267865012 (code B ref 61205); Fri, 03 Feb 2023 12:20:03 +0000 Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 12:19:46 +0000 Received: from localhost ([127.0.0.1]:36667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNv2f-0001Im-OF for submit@debbugs.gnu.org; Fri, 03 Feb 2023 07:19:46 -0500 Received: from eggs.gnu.org ([209.51.188.92]:44620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNv2d-0001IZ-13 for 61205@debbugs.gnu.org; Fri, 03 Feb 2023 07:19:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNv2X-0005rL-Dp; Fri, 03 Feb 2023 07:19:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=i99ALY4ZM8SbeZqdHxHRIWOBrCrqJTSyhG77CB0/kCs=; b=YNXl9/ooVkbe CFbH+uTcrgOTfz3ttdd1hlk9ew6Fw7DfG4H7QW2kmONoCbiUgd1NWWVCUcjt7uFleVyl6c5vLP6Zw Hc4hu+ccNbIG6/FdKt98KvFBGsTpCenJJfZu+5EIMMj0J/CXv5G54gImDoswUGKNjSMeFpgI7tZ37 9YUOS79J/GgCmBa+QCVc1xjRSAOkwzqiaeaXNnVZBxdnNU0vaPjN9HqbvTUJiVpwgOyrXLIwS5Cq8 XjCH01Q+k8yFrAva5F2jfu5rzIfrzi1s0lmD7CeN8SH6Vdahy3FKNtIii14XXU6NHQP9SfPGbwdYp utBKgjpWv/9CxhgbfUWfKQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNv2W-0001Wx-Di; Fri, 03 Feb 2023 07:19:36 -0500 Date: Fri, 03 Feb 2023 14:19:40 +0200 Message-Id: <83k00zuejn.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> (message from Dmitry Gutov on Fri, 3 Feb 2023 13:42:51 +0200) References: <837cwzw8j1.fsf@gnu.org> <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 3 Feb 2023 13:42:51 +0200 > Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev > From: Dmitry Gutov > > On 03/02/2023 08:46, Eli Zaretskii wrote: > >> Cc:61205@debbugs.gnu.org, Theodor Thornhill, > >> randy taylor > >> Date: Thu, 2 Feb 2023 22:25:47 +0200 > >> From: Dmitry Gutov > >> > >> On a related note: 'property' is in level 3 in c-ts-mode. > >> > >> Should it to go level 4? > >> > >> Also in typescript-ts-mode. > > What is 'property' in those modes? In c-ts-mode, is 'property' the > > name of a struct or enum member, as in foo.bar? Or is it something > > else? > > It's the 'bar' in 'foo.bar', yes. Specifically in the cases where it's > being looked up, rather than defined (in a type definition). Examples: > > it2.lnum_pixel_width = it.lnum_pixel_width; > > || (it.bidi_p && it.bidi_it.scan_dir == -1 > > 'lnum_pixel_width', 'bidi_p', 'bidi_it' and 'scan_dir' are highlighted > with font-lock-property-face. You can see it for yourself by trying > c-ts-mode in any of our files. Then as far as I'm concerned, this can go to level 4, but it must be done consistently across all the *-ts modes. So if some mode wants 'property' to be highlighted, and wants it badly, we should IMO keep it in C as well. In any case, please make this consistent across all the relevant modes, and don't forget adjusting the documentation of treesit-font-lock-level accordingly as needed. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 15:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167543731510947 (code B ref 61205); Fri, 03 Feb 2023 15:16:01 +0000 Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 15:15:15 +0000 Received: from localhost ([127.0.0.1]:39763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNxmV-0002qU-AO for submit@debbugs.gnu.org; Fri, 03 Feb 2023 10:15:15 -0500 Received: from mail-ej1-f47.google.com ([209.85.218.47]:46923) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNxmT-0002qB-Ox for 61205@debbugs.gnu.org; Fri, 03 Feb 2023 10:15:14 -0500 Received: by mail-ej1-f47.google.com with SMTP id p26so16098787ejx.13 for <61205@debbugs.gnu.org>; Fri, 03 Feb 2023 07:15:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=oJmccHivm2qnGzf++SSBBjCJ5NrlEQA9gQzZs5PAC4c=; b=dPNh6WtnGzbOQl2lyYZCu77tFs6c7wj4wM0k6vSyY8SIj8mMqnWStUyE2Kkpi/Iqfo 76Ej8SB4wlpCL6dIRAvlh8hbOL5FtJwESKhZ4zWjMCneTBWuJ5mKNnRLbK20hpu1FhXO Y/IQh6x3FCgMNACsOZxHKJhBmYOsCtpl+NfMSQih3RmceCIU6y76kNIZ6HrkQvYlrvgY eXXBsWj6s94C/jTQCT0pkmFNQF6FP9rUBtd+KTSlgKGQe1o2f3mjBm57TwB+JmQbkrSz SWUZnNKmBejaeTmWUOpgf4K+fUseYDQWi8ppjhf0L7pH0RLlGFKVqY+3wcHVx8agkpEE drfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=oJmccHivm2qnGzf++SSBBjCJ5NrlEQA9gQzZs5PAC4c=; b=APzeyBy+thaT5AqoofE4/X4GkZAnAzkwRVeX33SE3G9JcbMzjpmLPFRUppl5lHIFbk Eeophf9Oo7WpQhIgaHoZqR6G/hmrUd9Wp+eop4hg8JYKGuNSTzoCCyY7nq6ThQR0XIib qbUiEsQzhxghVlANfLg5f93Ys9U0ayccOIwjyQ/H2CcD/PZb2ILSgRM87+kOrI7K/jzz VfX1dCjvli5R6F7dK1rGdgQCwvEMbmyyV+Du/DtCH9jLzq7jTnLb+kPezB0fcmF9bcm7 fCv2KB8TM65wXqSkDY9iqrnSyM4yjrmDRFOtQNDhsu3CX87tcfoKQw+bdqe8LjB8uEpI UdLQ== X-Gm-Message-State: AO0yUKV4N8mvisL1Eeh/YgDoj9kbNZKXbeHdd4hAEABCKrXrfMQfVJw2 01tTu7xsfGfdS2rUO1InZdo= X-Google-Smtp-Source: AK7set/3DIz/W7zaPN6ULw6qlFY17iMJxvSE3n0xrDaEn0ZvBx16QIAkyw5Qlw62kbnPddr7VMOatQ== X-Received: by 2002:a17:906:99cd:b0:88f:79e7:830d with SMTP id s13-20020a17090699cd00b0088f79e7830dmr5738134ejn.67.1675437307743; Fri, 03 Feb 2023 07:15:07 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id a27-20020a170906275b00b0086edf177209sm1514006ejd.78.2023.02.03.07.15.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 07:15:07 -0800 (PST) Message-ID: Date: Fri, 3 Feb 2023 17:15:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <837cwzw8j1.fsf@gnu.org> <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> <83k00zuejn.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83k00zuejn.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 03/02/2023 14:19, Eli Zaretskii wrote: >> Date: Fri, 3 Feb 2023 13:42:51 +0200 >> Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev >> From: Dmitry Gutov >> >> On 03/02/2023 08:46, Eli Zaretskii wrote: >>>> Cc:61205@debbugs.gnu.org, Theodor Thornhill, >>>> randy taylor >>>> Date: Thu, 2 Feb 2023 22:25:47 +0200 >>>> From: Dmitry Gutov >>>> >>>> On a related note: 'property' is in level 3 in c-ts-mode. >>>> >>>> Should it to go level 4? >>>> >>>> Also in typescript-ts-mode. >>> What is 'property' in those modes? In c-ts-mode, is 'property' the >>> name of a struct or enum member, as in foo.bar? Or is it something >>> else? >> >> It's the 'bar' in 'foo.bar', yes. Specifically in the cases where it's >> being looked up, rather than defined (in a type definition). Examples: >> >> it2.lnum_pixel_width = it.lnum_pixel_width; >> >> || (it.bidi_p && it.bidi_it.scan_dir == -1 >> >> 'lnum_pixel_width', 'bidi_p', 'bidi_it' and 'scan_dir' are highlighted >> with font-lock-property-face. You can see it for yourself by trying >> c-ts-mode in any of our files. > > Then as far as I'm concerned, this can go to level 4, but it must be > done consistently across all the *-ts modes. So if some mode wants > 'property' to be highlighted, and wants it badly, we should IMO keep > it in C as well. Consistency is what I'm after here. c-ts-mode, as well as go-ts-mode, rust-ts-mode and typescript-ts-mode, all previously mentioned in this report, currently put it at 3. The rest put it as 4, or don't use it at all. Maybe we'll move them to level 3 for the next release; I think to do that, we will have to define separate faces first (for function calls and maybe variable references, as soon as we manage to find them in a smart way), so that the users will be able to make sure definitions are distinct from usages. > In any case, please make this consistent across all the relevant > modes, and don't forget adjusting the documentation of > treesit-font-lock-level accordingly as needed. Okay. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 15:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167543968214874 (code B ref 61205); Fri, 03 Feb 2023 15:55:02 +0000 Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 15:54:42 +0000 Received: from localhost ([127.0.0.1]:39836 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNyOf-0003rq-Ll for submit@debbugs.gnu.org; Fri, 03 Feb 2023 10:54:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:34562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNyOb-0003rY-1n for 61205@debbugs.gnu.org; Fri, 03 Feb 2023 10:54:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNyOU-0005zH-Bx; Fri, 03 Feb 2023 10:54:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=IcINz+yi31uqLvVBjhKG2Rs5odRAopflOUhV6khe46o=; b=As2Da+AH3735 U+tdVMYw+HGop0wWlJufZEKz3ka69Q6zPXUG4DXSlh3ZkZQg9t3z702dtr4/MHtWMHKeORW3eO7ed AV84nylww3D1EN2qH2KyfnTyjd+d7r4EJ+woKurCPFg1vatNQcThNR1GicjFZTqe3wf9T5W9pUU9z Fbisr6wLj4RSMgRZ5aOfGH05HqVU0/AyavAEOubVsvdifVtpI7HksQwfAX6Ksvp0bgdEevUG7OBru idHVRsSPMmcoWr9t5Aj4xHK8m66ju2fbpHBHdT55fCJgUKB7RixkVbpscC5g70rZAGsmR4oQdrXrO pG15eyV8iH5FiRrm0gzG3g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNyOT-00087h-Jw; Fri, 03 Feb 2023 10:54:29 -0500 Date: Fri, 03 Feb 2023 17:54:34 +0200 Message-Id: <83fsbmvj5x.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Dmitry Gutov on Fri, 3 Feb 2023 17:15:05 +0200) References: <837cwzw8j1.fsf@gnu.org> <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> <83k00zuejn.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 3 Feb 2023 17:15:05 +0200 > Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev > From: Dmitry Gutov > > > Then as far as I'm concerned, this can go to level 4, but it must be > > done consistently across all the *-ts modes. So if some mode wants > > 'property' to be highlighted, and wants it badly, we should IMO keep > > it in C as well. > > Consistency is what I'm after here. > > c-ts-mode, as well as go-ts-mode, rust-ts-mode and typescript-ts-mode, > all previously mentioned in this report, currently put it at 3. > > The rest put it as 4, or don't use it at all. The question is: how important is this for go-ts-mode, rust-ts-mode, and typescript-ts-mode? I don't know the answer. If the importance is not high, then this should be moved to level 4. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 17:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167544426022032 (code B ref 61205); Fri, 03 Feb 2023 17:11:02 +0000 Received: (at 61205) by debbugs.gnu.org; 3 Feb 2023 17:11:00 +0000 Received: from localhost ([127.0.0.1]:39870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNzaV-0005jI-R9 for submit@debbugs.gnu.org; Fri, 03 Feb 2023 12:11:00 -0500 Received: from mail-ed1-f54.google.com ([209.85.208.54]:40613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNzaR-0005j1-Da for 61205@debbugs.gnu.org; Fri, 03 Feb 2023 12:10:58 -0500 Received: by mail-ed1-f54.google.com with SMTP id fi26so5820545edb.7 for <61205@debbugs.gnu.org>; Fri, 03 Feb 2023 09:10:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=wwhYNH3eGG3n9dAcXSBZVg92TJO1no2czWs+iedJhS4=; b=R//PfOGj2HyWTeMj5eyc+wkJZedQbUAKb6I+r6NSWoLF9pdlOwMMwYRW6qq1lC+sfr uzrJbCczEdllCafAwfYhsIBHqms0xD/xedKxygu/wtTdshP/uQb4+82OEQqM3zlLvaZE em+NHwf7yvvA9e544TecH3FsXoF9zXmRf1Aj/UrMP7PQKek+tbFoIYmvUbASpMkKtf24 hdqjPOrpgmBvisxgqmmH8xIN9FnFxBU4tkQHF6NLLyeYOk10iS9n5RqWOyN0G+LcAT5F 3fzLAFjVrEtyu15aHERCzJEWREQoQe9npj0pSrQ3IuUJce4ggMNsONwsZgQVWFEDISaI FToQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wwhYNH3eGG3n9dAcXSBZVg92TJO1no2czWs+iedJhS4=; b=oTPvLNMvFS7o9DQVeeudSa0yzKjMQtMuhswZkFDKyEbpGYUg1fFSr8YF5OeMrH84+o N7lo22YW4aNQh0UZExB9t/IaoICBx69+HFvlq5lPDCyO0GekvCAmY8WLQ+ZxBohTaAYa hoLn5SxUhqAzaouNFhhm6QYldjJdvsqMcCmfiR0pV2OblUbLmBGgYWKXiaX8GDWdQZ7Q 4W67+XtSEhAUzKq5qxciAWWToACCWynG07iricxt8HfRt72hIIO8U7XB6AeOGmKqYnOR 722h9XTaXxz1W2pigDZ0H7OrbbzvrIVPXsVF4suvCmFVOEKQGt1tLhX1Ba1l9H2FSHx3 qAIg== X-Gm-Message-State: AO0yUKUpG4j0j02Jvrm+UcjVB9oRAE/u28c6uS0VkdUj1m9FcSbcojCX wKRlDoDE78IbxpTFYSr402U= X-Google-Smtp-Source: AK7set9BdPRMnzme55gJekyYlzkZUaYvXUmPkjMgF3xvGa0omKrlu00oj3SIEhlnKHx+LFJZRlbIYw== X-Received: by 2002:a05:6402:3603:b0:4a0:e237:2cef with SMTP id el3-20020a056402360300b004a0e2372cefmr11675884edb.4.1675444249510; Fri, 03 Feb 2023 09:10:49 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m10-20020a056402430a00b0048eb0886b00sm1407137edc.42.2023.02.03.09.10.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 09:10:48 -0800 (PST) Message-ID: <3f14adfd-8aef-9352-4c9a-fff71f4223fb@yandex.ru> Date: Fri, 3 Feb 2023 19:10:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <837cwzw8j1.fsf@gnu.org> <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> <83k00zuejn.fsf@gnu.org> <83fsbmvj5x.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83fsbmvj5x.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 03/02/2023 17:54, Eli Zaretskii wrote: >> Date: Fri, 3 Feb 2023 17:15:05 +0200 >> Cc:61205@debbugs.gnu.org,casouri@gmail.com,theo@thornhill.no,dev@rjt.dev >> From: Dmitry Gutov >> >>> Then as far as I'm concerned, this can go to level 4, but it must be >>> done consistently across all the *-ts modes. So if some mode wants >>> 'property' to be highlighted, and wants it badly, we should IMO keep >>> it in C as well. >> Consistency is what I'm after here. >> >> c-ts-mode, as well as go-ts-mode, rust-ts-mode and typescript-ts-mode, >> all previously mentioned in this report, currently put it at 3. >> >> The rest put it as 4, or don't use it at all. > The question is: how important is this for go-ts-mode, rust-ts-mode, > and typescript-ts-mode? I don't know the answer. If the importance > is not high, then this should be moved to level 4. Right. They don't seem to be particularly more important there than in other modes. Or than 'function', for example. From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2023 03:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167548178827886 (code B ref 61205); Sat, 04 Feb 2023 03:37:01 +0000 Received: (at 61205) by debbugs.gnu.org; 4 Feb 2023 03:36:28 +0000 Received: from localhost ([127.0.0.1]:40313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pO9Ln-0007Fg-R0 for submit@debbugs.gnu.org; Fri, 03 Feb 2023 22:36:28 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:55932) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pO9Lk-0007FS-4b for 61205@debbugs.gnu.org; Fri, 03 Feb 2023 22:36:26 -0500 Received: by mail-wm1-f53.google.com with SMTP id q8so5183989wmo.5 for <61205@debbugs.gnu.org>; Fri, 03 Feb 2023 19:36:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=Yew125UAfXXYx3Glahv/ead2o8K7Q8eeLBo9Zj9jY1w=; b=e3THGTL2KmtymkOHM1dcEWbw6rHPC8rGIlGanV/1CX1qY5/Bguo9XaqbVrmQCDlb4n FjLw03gsSNtTN/ALsUiuMw3cNUqlO3sJeMXT2Tvy0ZD0W85z2jeim83oViuW6HKHR++x a8dlEmA3wUkpvA5JRdN1RF11nqfbSP56xBFF4Zqxt8oY1Pkm8TOa5FKXZpt63Rqu+qjX rUNbp1JdKD7XSKgU49G4U9ISc+EXTlhiovWQnRn+Jjl3+sV4qCYNulBcm+r1SwUcqElu /ZyYzXm2pMzc/GMRADY8rtHuj18MSFU+77oor4KJJvzAhJyE1z0x4bXU1mBJZt9JyLsr ckfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:cc:to:from:content-language:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Yew125UAfXXYx3Glahv/ead2o8K7Q8eeLBo9Zj9jY1w=; b=TJJERBGQ9CRRAcVPZLDl8Tkxqz+b4MSNXjKTbcGaG6JUCEJHsF/W2sWBA2JALIUMBQ 7CUWEMDkSt7YqbM3FPqGpkqakoKxTHvqmLLX3eERg52T9JtjbFsCRpeYCVt/FL80zX8C WNFHU6fYwtsC9iW8mh4Bj7E7xw7TRNpN4AehRkQPc4vj52VKRW/PCE+lEcMxjDhAD+WP vvq2hRdEvl2VYd54HTdOyjmo3w8r5DigVkjNECZ+J1/Ik25ULDIYGpsYIVQxBTn1vL1o uw0whZ6Kft/DrvWlOryLRyWpa0EiKHDijCULix3ng+EydlnB0ocMgtOcREHO0z1IAK0O dSYg== X-Gm-Message-State: AO0yUKW3awQGWZyxzstokTFKu5slGnCHJc6fObjtUyr7RmZaIIKwSUJL llfmiwArC4Hd2ph3dEEqm+w= X-Google-Smtp-Source: AK7set/FZvhn6sIq4pUu/+7HYkNmUKD6+48DZd6AwqB7dy6J3tt2uiq0RB/64eYQtUs1oLyUz5NviQ== X-Received: by 2002:a05:600c:3d90:b0:3df:eedf:f378 with SMTP id bi16-20020a05600c3d9000b003dfeedff378mr1880112wmb.24.1675481778038; Fri, 03 Feb 2023 19:36:18 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id g42-20020a05600c4caa00b003de664d4c14sm4210481wmp.36.2023.02.03.19.36.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Feb 2023 19:36:17 -0800 (PST) Content-Type: multipart/mixed; boundary="------------wApBWYgGtkm01kzn09e6pqK4" Message-ID: <2a710b11-4e3c-3103-19ee-cf313526ad63@yandex.ru> Date: Sat, 4 Feb 2023 05:36:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US From: Dmitry Gutov References: <837cwzw8j1.fsf@gnu.org> <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> <83k00zuejn.fsf@gnu.org> <83fsbmvj5x.fsf@gnu.org> <3f14adfd-8aef-9352-4c9a-fff71f4223fb@yandex.ru> In-Reply-To: <3f14adfd-8aef-9352-4c9a-fff71f4223fb@yandex.ru> X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) This is a multi-part message in MIME format. --------------wApBWYgGtkm01kzn09e6pqK4 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 03/02/2023 19:10, Dmitry Gutov wrote: > On 03/02/2023 17:54, Eli Zaretskii wrote: >>> Date: Fri, 3 Feb 2023 17:15:05 +0200 >>> Cc:61205@debbugs.gnu.org,casouri@gmail.com,theo@thornhill.no,dev@rjt.dev >>> From: Dmitry Gutov >>> >>>> Then as far as I'm concerned, this can go to level 4, but it must be >>>> done consistently across all the *-ts modes.  So if some mode wants >>>> 'property' to be highlighted, and wants it badly, we should IMO keep >>>> it in C as well. >>> Consistency is what I'm after here. >>> >>> c-ts-mode, as well as go-ts-mode, rust-ts-mode and typescript-ts-mode, >>> all previously mentioned in this report, currently put it at 3. >>> >>> The rest put it as 4, or don't use it at all. >> The question is: how important is this for go-ts-mode, rust-ts-mode, >> and typescript-ts-mode?  I don't know the answer.  If the importance >> is not high, then this should be moved to level 4. > > Right. They don't seem to be particularly more important there than in > other modes. Or than 'function', for example. Here's the updated patch in the meantime. Not sure what to do with 'type' highlighting in rust-ts-mode yet. Additional scoping seems like will require a bunch of repetitions. Perhaps a :pred instruction to filter out children of a call_expression might work better. --------------wApBWYgGtkm01kzn09e6pqK4 Content-Type: text/x-patch; charset=UTF-8; name="ts-modes-refine-features.diff" Content-Disposition: attachment; filename="ts-modes-refine-features.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9kaXNwbGF5LnRleGkgYi9kb2MvZW1hY3MvZGlzcGxh eS50ZXhpCmluZGV4IDk3NzMyYjY1ZTMyLi5hODZjMTJhMGRiNyAxMDA2NDQKLS0tIGEvZG9j L2VtYWNzL2Rpc3BsYXkudGV4aQorKysgYi9kb2MvZW1hY3MvZGlzcGxheS50ZXhpCkBAIC0x MTU5LDExICsxMTU5LDExIEBAIFBhcnNlci1iYXNlZCBGb250IExvY2sKIFRoaXMgbGV2ZWwg YWRkcyBmb250aWZpY2F0aW9uIG9mIGtleXdvcmRzLCBzdHJpbmdzLCBhbmQgZGF0YSB0eXBl cy4KIEBpdGVtIExldmVsIDMKIFRoaXMgaXMgdGhlIGRlZmF1bHQgbGV2ZWw7IGl0IGFkZHMg Zm9udGlmaWNhdGlvbiBvZiBhc3NpZ25tZW50cywKLW51bWJlcnMsIHByb3BlcnRpZXMsIGV0 Yy4KK251bWJlcnMsIGV0Yy4KIEBpdGVtIExldmVsIDQKIFRoaXMgbGV2ZWwgYWRkcyBldmVy eXRoaW5nIGVsc2UgdGhhdCBjYW4gYmUgZm9udGlmaWVkOiBvcGVyYXRvcnMsCiBkZWxpbWl0 ZXJzLCBicmFja2V0cywgb3RoZXIgcHVuY3R1YXRpb24sIGZ1bmN0aW9uIG5hbWVzIGluIGZ1 bmN0aW9uCi1jYWxscywgdmFyaWFibGVzLCBldGMuCitjYWxscywgcHJvcGVydHkgbG9vayB1 cHMsIHZhcmlhYmxlcywgZXRjLgogQGVuZCB0YWJsZQogCiBAdmluZGV4IHRyZWVzaXQtZm9u dC1sb2NrLWZlYXR1cmUtbGlzdApkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvYy10cy1t b2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvYy10cy1tb2RlLmVsCmluZGV4IDM5MGY2N2E4ZThj Li4yMDZiMmU5OGZiMyAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvYy10cy1tb2RlLmVs CisrKyBiL2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5lbApAQCAtNzc0LDggKzc3NCw4IEBA IGMtdHMtYmFzZS1tb2RlCiAgIChzZXRxLWxvY2FsIHRyZWVzaXQtZm9udC1sb2NrLWZlYXR1 cmUtbGlzdAogICAgICAgICAgICAgICAnKCggY29tbWVudCBkZWZpbml0aW9uKQogICAgICAg ICAgICAgICAgICgga2V5d29yZCBwcmVwcm9jZXNzb3Igc3RyaW5nIHR5cGUpCi0gICAgICAg ICAgICAgICAgKCBhc3NpZ25tZW50IGNvbnN0YW50IGVzY2FwZS1zZXF1ZW5jZSBsYWJlbCBs aXRlcmFsIHByb3BlcnR5ICkKLSAgICAgICAgICAgICAgICAoIGJyYWNrZXQgZGVsaW1pdGVy IGVycm9yIGZ1bmN0aW9uIG9wZXJhdG9yIHZhcmlhYmxlKSkpKQorICAgICAgICAgICAgICAg ICggYXNzaWdubWVudCBjb25zdGFudCBlc2NhcGUtc2VxdWVuY2UgbGFiZWwgbGl0ZXJhbCkK KyAgICAgICAgICAgICAgICAoIGJyYWNrZXQgZGVsaW1pdGVyIGVycm9yIGZ1bmN0aW9uIG9w ZXJhdG9yIHByb3BlcnR5IHZhcmlhYmxlKSkpKQogCiA7OzsjIyNhdXRvbG9hZAogKGRlZmlu ZS1kZXJpdmVkLW1vZGUgYy10cy1tb2RlIGMtdHMtYmFzZS1tb2RlICJDIgpkaWZmIC0tZ2l0 IGEvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dvLXRz LW1vZGUuZWwKaW5kZXggNWYzZTFlYTNlNjguLmE0YjY0ODA4Y2EyIDEwMDY0NAotLS0gYS9s aXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2dvLXRz LW1vZGUuZWwKQEAgLTExOSwxNyArMTE5LDI3IEBAIGdvLXRzLW1vZGUtLWZvbnQtbG9jay1z ZXR0aW5ncwogICAgOmZlYXR1cmUgJ2RlbGltaXRlcgogICAgJygoWyIsIiAiLiIgIjsiICI6 Il0pIEBmb250LWxvY2stZGVsaW1pdGVyLWZhY2UpCiAKKyAgIDpsYW5ndWFnZSAnZ28KKyAg IDpmZWF0dXJlICdkZWZpbml0aW9uCisgICAnKChmdW5jdGlvbl9kZWNsYXJhdGlvbgorICAg ICAgbmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKQor ICAgICAobWV0aG9kX2RlY2xhcmF0aW9uCisgICAgICBuYW1lOiAoZmllbGRfaWRlbnRpZmll cikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCisgICAgIChtZXRob2Rfc3BlYwor ICAgICAgbmFtZTogKGZpZWxkX2lkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFt ZS1mYWNlKSkKKworICAgOmxhbmd1YWdlICdnbworICAgOmZlYXR1cmUgJ2RlZmluaXRpb24K KyAgICcoKGZpZWxkX2RlY2xhcmF0aW9uCisgICAgICBuYW1lOiAoZmllbGRfaWRlbnRpZmll cikgQGZvbnQtbG9jay1wcm9wZXJ0eS1mYWNlKSkKKwogICAgOmxhbmd1YWdlICdnbwogICAg OmZlYXR1cmUgJ2Z1bmN0aW9uCiAgICAnKChjYWxsX2V4cHJlc3Npb24KICAgICAgIGZ1bmN0 aW9uOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCiAgICAg IChjYWxsX2V4cHJlc3Npb24KICAgICAgIGZ1bmN0aW9uOiAoc2VsZWN0b3JfZXhwcmVzc2lv bgotICAgICAgICAgICAgICAgICBmaWVsZDogKGZpZWxkX2lkZW50aWZpZXIpIEBmb250LWxv Y2stZnVuY3Rpb24tbmFtZS1mYWNlKSkKLSAgICAgKGZ1bmN0aW9uX2RlY2xhcmF0aW9uCi0g ICAgICBuYW1lOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2Up Ci0gICAgIChtZXRob2RfZGVjbGFyYXRpb24KLSAgICAgIG5hbWU6IChmaWVsZF9pZGVudGlm aWVyKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZSkpCisgICAgICAgICAgICAgICAg IGZpZWxkOiAoZmllbGRfaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZh Y2UpKSkKIAogICAgOmxhbmd1YWdlICdnbwogICAgOmZlYXR1cmUgJ2tleXdvcmQKQEAgLTIx NywxMSArMjI3LDEwIEBAIGdvLXRzLW1vZGUKICAgICA7OyBGb250LWxvY2suCiAgICAgKHNl dHEtbG9jYWwgdHJlZXNpdC1mb250LWxvY2stc2V0dGluZ3MgZ28tdHMtbW9kZS0tZm9udC1s b2NrLXNldHRpbmdzKQogICAgIChzZXRxLWxvY2FsIHRyZWVzaXQtZm9udC1sb2NrLWZlYXR1 cmUtbGlzdAotICAgICAgICAgICAgICAgICcoKCBjb21tZW50KQorICAgICAgICAgICAgICAg ICcoKCBjb21tZW50IGRlZmluaXRpb24pCiAgICAgICAgICAgICAgICAgICAoIGtleXdvcmQg c3RyaW5nIHR5cGUpCi0gICAgICAgICAgICAgICAgICAoIGNvbnN0YW50IGVzY2FwZS1zZXF1 ZW5jZSBmdW5jdGlvbiBsYWJlbCBudW1iZXIKLSAgICAgICAgICAgICAgICAgICAgcHJvcGVy dHkgdmFyaWFibGUpCi0gICAgICAgICAgICAgICAgICAoIGJyYWNrZXQgZGVsaW1pdGVyIGVy cm9yIG9wZXJhdG9yKSkpCisgICAgICAgICAgICAgICAgICAoIGNvbnN0YW50IGVzY2FwZS1z ZXF1ZW5jZSBsYWJlbCBudW1iZXIpCisgICAgICAgICAgICAgICAgICAoIGJyYWNrZXQgZGVs aW1pdGVyIGVycm9yIGZ1bmN0aW9uIG9wZXJhdG9yIHByb3BlcnR5IHZhcmlhYmxlKSkpCiAK ICAgICAodHJlZXNpdC1tYWpvci1tb2RlLXNldHVwKSkpCiAKZGlmZiAtLWdpdCBhL2xpc3Av cHJvZ21vZGVzL3J1c3QtdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL3J1c3QtdHMtbW9k ZS5lbAppbmRleCBlMzE3NzkzZDIxMS4uNjYyYzI4NjcxNmIgMTAwNjQ0Ci0tLSBhL2xpc3Av cHJvZ21vZGVzL3J1c3QtdHMtbW9kZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9ydXN0LXRz LW1vZGUuZWwKQEAgLTE1NSw2ICsxNTUsMTYgQEAgcnVzdC10cy1tb2RlLS1mb250LWxvY2st c2V0dGluZ3MKICAgIDpmZWF0dXJlICdkZWxpbWl0ZXIKICAgICcoKFsiLCIgIi4iICI7IiAi OiIgIjo6Il0pIEBmb250LWxvY2stZGVsaW1pdGVyLWZhY2UpCiAKKyAgIDpsYW5ndWFnZSAn cnVzdAorICAgOmZlYXR1cmUgJ2RlZmluaXRpb24KKyAgICcoKGZ1bmN0aW9uX2l0ZW0gbmFt ZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKQorICAgICAo bWFjcm9fZGVmaW5pdGlvbiAibWFjcm9fcnVsZXMhIiBAZm9udC1sb2NrLWNvbnN0YW50LWZh Y2UpCisgICAgIChtYWNyb19kZWZpbml0aW9uIChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXBy ZXByb2Nlc3Nvci1mYWNlKSkKKworICAgOmxhbmd1YWdlICdydXN0CisgICA6ZmVhdHVyZSAn ZGVmaW5pdGlvbgorICAgJygoZmllbGRfZGVjbGFyYXRpb24gbmFtZTogKGZpZWxkX2lkZW50 aWZpZXIpIEBmb250LWxvY2stcHJvcGVydHktZmFjZSkpCisKICAgIDpsYW5ndWFnZSAncnVz dAogICAgOmZlYXR1cmUgJ2Z1bmN0aW9uCiAgICAnKChjYWxsX2V4cHJlc3Npb24KQEAgLTE2 NCwxNSArMTc0LDEyIEBAIHJ1c3QtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAgICAg ICAgIGZpZWxkOiAoZmllbGRfaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1l LWZhY2UpCiAgICAgICAgKHNjb3BlZF9pZGVudGlmaWVyCiAgICAgICAgIG5hbWU6IChpZGVu dGlmaWVyKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZSldKQotICAgICAoZnVuY3Rp b25faXRlbSAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCiAg ICAgIChnZW5lcmljX2Z1bmN0aW9uCiAgICAgICBmdW5jdGlvbjogWyhpZGVudGlmaWVyKSBA Zm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZQogICAgICAgICAgICAgICAgICAoZmllbGRf ZXhwcmVzc2lvbgogICAgICAgICAgICAgICAgICAgZmllbGQ6IChmaWVsZF9pZGVudGlmaWVy KSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZSkKICAgICAgICAgICAgICAgICAgKHNj b3BlZF9pZGVudGlmaWVyCiAgICAgICAgICAgICAgICAgICBuYW1lOiAoaWRlbnRpZmllcikg QGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpXSkKLSAgICAgKG1hY3JvX2RlZmluaXRp b24gIm1hY3JvX3J1bGVzISIgQGZvbnQtbG9jay1jb25zdGFudC1mYWNlKQotICAgICAobWFj cm9fZGVmaW5pdGlvbiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcmVwcm9jZXNzb3ItZmFj ZSkKICAgICAgKG1hY3JvX2ludm9jYXRpb24gbWFjcm86IChpZGVudGlmaWVyKSBAZm9udC1s b2NrLXByZXByb2Nlc3Nvci1mYWNlKSkKIAogICAgOmxhbmd1YWdlICdydXN0CkBAIC0yMDgs NyArMjE1LDYgQEAgcnVzdC10cy1tb2RlLS1mb250LWxvY2stc2V0dGluZ3MKICAgICAgKG1v ZF9pdGVtIG5hbWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWNvbnN0YW50LWZhY2UpCiAg ICAgIChwcmltaXRpdmVfdHlwZSkgQGZvbnQtbG9jay10eXBlLWZhY2UKICAgICAgKHR5cGVf aWRlbnRpZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UKLSAgICAgKHNjb3BlZF9pZGVudGlm aWVyIG5hbWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZSkKICAgICAgKHNj b3BlZF9pZGVudGlmaWVyIHBhdGg6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLWNvbnN0YW50 LWZhY2UpCiAgICAgIChzY29wZWRfaWRlbnRpZmllcgogICAgICAgKHNjb3BlZF9pZGVudGlm aWVyCkBAIC0zMTcsMTEgKzMyMywxMSBAQCBydXN0LXRzLW1vZGUKICAgICA7OyBGb250LWxv Y2suCiAgICAgKHNldHEtbG9jYWwgdHJlZXNpdC1mb250LWxvY2stc2V0dGluZ3MgcnVzdC10 cy1tb2RlLS1mb250LWxvY2stc2V0dGluZ3MpCiAgICAgKHNldHEtbG9jYWwgdHJlZXNpdC1m b250LWxvY2stZmVhdHVyZS1saXN0Ci0gICAgICAgICAgICAgICAgJygoIGNvbW1lbnQpCisg ICAgICAgICAgICAgICAgJygoIGNvbW1lbnQgZGVmaW5pdGlvbikKICAgICAgICAgICAgICAg ICAgICgga2V5d29yZCBzdHJpbmcpCiAgICAgICAgICAgICAgICAgICAoIGF0dHJpYnV0ZSBi dWlsdGluIGNvbnN0YW50IGVzY2FwZS1zZXF1ZW5jZQotICAgICAgICAgICAgICAgICAgICBm dW5jdGlvbiBudW1iZXIgcHJvcGVydHkgdHlwZSB2YXJpYWJsZSkKLSAgICAgICAgICAgICAg ICAgICggYnJhY2tldCBkZWxpbWl0ZXIgZXJyb3Igb3BlcmF0b3IpKSkKKyAgICAgICAgICAg ICAgICAgICAgbnVtYmVyIHR5cGUpCisgICAgICAgICAgICAgICAgICAoIGJyYWNrZXQgZGVs aW1pdGVyIGVycm9yIGZ1bmN0aW9uIG9wZXJhdG9yIHByb3BlcnR5IHZhcmlhYmxlKSkpCiAK ICAgICA7OyBJbWVudS4KICAgICAoc2V0cS1sb2NhbCB0cmVlc2l0LXNpbXBsZS1pbWVudS1z ZXR0aW5ncwpkaWZmIC0tZ2l0IGEvdGVzdC9tYW51YWwvZXRhZ3MvcnMtc3JjL3Rlc3QucnMg Yi90ZXN0L21hbnVhbC9ldGFncy9ycy1zcmMvdGVzdC5ycwppbmRleCAwODFkMGQ3ZDRkZi4u MDZjZGUwZTc5ZTIgMTAwNjQ0Ci0tLSBhL3Rlc3QvbWFudWFsL2V0YWdzL3JzLXNyYy90ZXN0 LnJzCisrKyBiL3Rlc3QvbWFudWFsL2V0YWdzL3JzLXNyYy90ZXN0LnJzCkBAIC0xLDUgKzEs MTAgQEAKIG1vZCB0ZXN0OwogCit1c2Ugc3RkOjpjb2xsZWN0aW9uczo6aGFzaF9tYXA6Ontz ZWxmLCBIYXNoTWFwfTsKKwordXNlIHN0ZDo6cGF0aDo6e3NlbGYsIFBhdGgsIFBhdGhCdWZ9 OyAgLy8gZ29vZDogc3RkIGlzIGEgY3JhdGUgbmFtZQordXNlIGNyYXRlOjpmb286OmJhejo6 Zm9vYmF6OyAgICAvLyBnb29kOiBmb28gaXMgYXQgdGhlIHJvb3Qgb2YgdGhlIGNyYXRlCisK IGVudW0gSXBBZGRyS2luZCB7CiAgICAgVjQsCiAgICAgVjYsCkBAIC0xMiwzICsxNyw2OSBA QCBmbiB0ZXN0MSgpIHsKIGZuIG1haW4oKSB7CiAgICB0ZXN0Ojp0ZXN0MSgpOwogfQorCitm biBlYXRfYm94X2kzMihib3hlZF9pMzI6IEJveDxpMzI+KSB7CisgICAgcHJpbnRsbiEoIkRl c3Ryb3lpbmcgYm94IHRoYXQgY29udGFpbnMge30iLCBib3hlZF9pMzIpOworfQorCisvLyBU aGlzIGZ1bmN0aW9uIGJvcnJvd3MgYW4gaTMyCitmbiBib3Jyb3dfaTMyKGJvcnJvd2VkX2kz MjogJmkzMikgeworICAgIHByaW50bG4hKCJUaGlzIGludCBpczoge30iLCBib3Jyb3dlZF9p MzIpOworfQorCitzdHJ1Y3QgVmFsIHsKKyAgICB2YWw6IGY2NCwKK30KKworc3RydWN0IEdl blZhbDxUPiB7CisgICAgZ2VuX3ZhbDogVCwKK30KKworLy8gaW1wbCBvZiBWYWwKK2ltcGwg VmFsIHsKKyAgICBmbiB2YWx1ZSgmc2VsZikgLT4gJmY2NCB7CisgICAgICAgICZzZWxmLnZh bAorICAgIH0KK30KKworLy8gaW1wbCBvZiBHZW5WYWwgZm9yIGEgZ2VuZXJpYyB0eXBlIGBU YAoraW1wbDxUPiBHZW5WYWw8VD4geworICAgIGZuIHZhbHVlKCZzZWxmKSAtPiAmVCB7Cisg ICAgICAgICZzZWxmLmdlbl92YWwKKyAgICB9Cit9CisKK2ZuIG1haW4oKSB7CisgICAgbGV0 IHggPSBWYWwgeyB2YWw6IDMuMCB9OworICAgIGxldCB5ID0gR2VuVmFsIHsgZ2VuX3ZhbDog M2kzMiB9OworCisgICAgcHJpbnRsbiEoInt9LCB7fSIsIHgudmFsdWUoKSwgeS52YWx1ZSgp KTsKK30KKworZm4gbWFpbigpIHsKKyAgICAvLyBDcmVhdGUgYSBib3hlZCBpMzIsIGFuZCBh IHN0YWNrZWQgaTMyCisgICAgbGV0IGJveGVkX2kzMiA9IEJveDo6bmV3KDVfaTMyKTsKKyAg ICBsZXQgc3RhY2tlZF9pMzIgPSA2X2kzMjsKKworICAgIC8vIEJvcnJvdyB0aGUgY29udGVu dHMgb2YgdGhlIGJveC4gT3duZXJzaGlwIGlzIG5vdCB0YWtlbiwKKyAgICAvLyBzbyB0aGUg Y29udGVudHMgY2FuIGJlIGJvcnJvd2VkIGFnYWluLgorICAgIGJvcnJvd19pMzIoJmJveGVk X2kzMik7CisgICAgYm9ycm93X2kzMigmc3RhY2tlZF9pMzIpOworCisgICAgeworICAgICAg ICAvLyBUYWtlIGEgcmVmZXJlbmNlIHRvIHRoZSBkYXRhIGNvbnRhaW5lZCBpbnNpZGUgdGhl IGJveAorICAgICAgICBsZXQgX3JlZl90b19pMzI6ICZpMzIgPSAmYm94ZWRfaTMyOworCisg ICAgICAgIC8vIEVycm9yIQorICAgICAgICAvLyBDYW4ndCBkZXN0cm95IGBib3hlZF9pMzJg IHdoaWxlIHRoZSBpbm5lciB2YWx1ZSBpcyBib3Jyb3dlZCBsYXRlciBpbiBzY29wZS4KKyAg ICAgICAgZWF0X2JveF9pMzIoYm94ZWRfaTMyKTsKKyAgICAgICAgLy8gRklYTUUgXiBDb21t ZW50IG91dCB0aGlzIGxpbmUKKworICAgICAgICAvLyBBdHRlbXB0IHRvIGJvcnJvdyBgX3Jl Zl90b19pMzJgIGFmdGVyIGlubmVyIHZhbHVlIGlzIGRlc3Ryb3llZAorICAgICAgICBib3Jy b3dfaTMyKF9yZWZfdG9faTMyKTsKKyAgICAgICAgLy8gYF9yZWZfdG9faTMyYCBnb2VzIG91 dCBvZiBzY29wZSBhbmQgaXMgbm8gbG9uZ2VyIGJvcnJvd2VkLgorICAgIH0KKworICAgIC8v IGBib3hlZF9pMzJgIGNhbiBub3cgZ2l2ZSB1cCBvd25lcnNoaXAgdG8gYGVhdF9ib3hgIGFu ZCBiZSBkZXN0cm95ZWQKKyAgICBlYXRfYm94X2kzMihib3hlZF9pMzIpOworfQo= --------------wApBWYgGtkm01kzn09e6pqK4-- From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2023 06:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167549364111252 (code B ref 61205); Sat, 04 Feb 2023 06:54:02 +0000 Received: (at 61205) by debbugs.gnu.org; 4 Feb 2023 06:54:01 +0000 Received: from localhost ([127.0.0.1]:40511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOCQz-0002vQ-DW for submit@debbugs.gnu.org; Sat, 04 Feb 2023 01:54:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOCQx-0002vA-Dl for 61205@debbugs.gnu.org; Sat, 04 Feb 2023 01:54:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOCQr-0001PH-8u; Sat, 04 Feb 2023 01:53:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=V0tclIAfZ2kelgHhDAEbbBcIvHK5gfgn72ByFlO52tc=; b=kGbe29w3NlrL Sq+NyNWfiGI+tJKdVOqOtnTGbWbS7N5VMe5RM0nQsesqV1xn71Z5rGyqNzYBiBmy9R4xEUu8FeAgi r1hI1H/OONh5snUtAW7d6iHwTWAsFS1ytqMQRrc+nGrbJK6GwD9npnxJAnidGfrorCbUe6Z0spFxd bSVJKMvqNjHHFD2MKxj5+s5pxOJLS2FDWnGFHBjNX55ravqJDfiF6NnOH7n79zQstEfzUVxHKfBX5 e44gPHGPf9YP4k3VHjTx3XFkNgqzjhpyNYT8U9DGyAfdFi+tpAz9zTevbeBbVW7f2ycoOnR5Rv48s IeqP9t+RX7wMQl5inQD6Xw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOCQq-0004mX-Dy; Sat, 04 Feb 2023 01:53:52 -0500 Date: Sat, 04 Feb 2023 08:53:59 +0200 Message-Id: <838rhdvs3c.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <2a710b11-4e3c-3103-19ee-cf313526ad63@yandex.ru> (message from Dmitry Gutov on Sat, 4 Feb 2023 05:36:15 +0200) References: <837cwzw8j1.fsf@gnu.org> <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> <83k00zuejn.fsf@gnu.org> <83fsbmvj5x.fsf@gnu.org> <3f14adfd-8aef-9352-4c9a-fff71f4223fb@yandex.ru> <2a710b11-4e3c-3103-19ee-cf313526ad63@yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 4 Feb 2023 05:36:15 +0200 > From: Dmitry Gutov > Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev > > Here's the updated patch in the meantime. Thanks, but please also update the doc string of treesit-font-lock-level. > Not sure what to do with 'type' highlighting in rust-ts-mode yet. What is the problem with that? From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2023 23:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.16755542936380 (code B ref 61205); Sat, 04 Feb 2023 23:45:01 +0000 Received: (at 61205) by debbugs.gnu.org; 4 Feb 2023 23:44:53 +0000 Received: from localhost ([127.0.0.1]:43618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOSDE-0001ep-J2 for submit@debbugs.gnu.org; Sat, 04 Feb 2023 18:44:53 -0500 Received: from mail-ej1-f49.google.com ([209.85.218.49]:33513) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOSDB-0001eZ-2I for 61205@debbugs.gnu.org; Sat, 04 Feb 2023 18:44:51 -0500 Received: by mail-ej1-f49.google.com with SMTP id ml19so25058498ejb.0 for <61205@debbugs.gnu.org>; Sat, 04 Feb 2023 15:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=GNdA7ynzDxj6eDouEu0OiI8rfEkmvSENRaVIRn4IrOs=; b=XXURqmTJXDEMO/kwP5YCmOiexOrV7K1isyVcnNM2DdwYdkM2PwCHa/4L2ZKFy2HUmM RuewYL+5mS1iLNxtnkJCAzDiYQOW67qaB3dpMukl+Szc6GsRqZ9cnWOcTREOrspkcMsb IkW71Y/JpqXK+cIa0AkPXP01NCEyGmlCuqxcvYfh3bq5t4LHMZGOXrVC+Ze7V53nw21O l+K9z48/wYEygLFeqPBfZBonb5c3KcC90UKv43lMt+f0NHn9sXTMQDHg8wbvbgXj4lhd 9D4cByPhcIiOGVXIPYwYuamVDR2iTRiRMQTJgZ62VrJSUp6aZyzg91EN+qZeZzj/Pi// u09g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=GNdA7ynzDxj6eDouEu0OiI8rfEkmvSENRaVIRn4IrOs=; b=OJCmk9VE4q0RKbld81zF5PEsr7yN75gVF08kNkZhbRZ3CVEHVwXkTlQiQmamJzkjxg LjOcDbk8v94Mshp2/ehFH9aJwJx3kOlrIRNaOKxkbiZ4QfYY1VwMLgygVVTdZrzOg7/j 2/0twtqnYkreJiFmFPoo/UBtBBYvj1V5RTjaeQBHUQvsmW9XEPcLs5vzbjQaT+mCp/wf JB252BzHPOeLeQC1yjK6vPEDYwZoj/SOoZRtTOdbkrejXpZCCxMx7/ImTVs1PWJDOcAz TuXEaV05Lz2c+FFZcv5/L32MZmxLLLkOBi0J8w6/j6dzLWsGuHYITtj1cm/bD8dqQLSJ nOTA== X-Gm-Message-State: AO0yUKXexvQWPWe/eNp0edAkkL7X+nuO2uMYBvCHRT64L7rjfjVu3U9z 8dPmhPz+RZbHc9UHF1Lfz2A= X-Google-Smtp-Source: AK7set+OLPQffItJO1h0bU9KpfgaVZdS6Hf6IVEJ2CvH7OjHBQBAErZO4KQ3MKd0lcA1MNRgXvJP4Q== X-Received: by 2002:a17:907:2bc2:b0:866:6b08:946b with SMTP id gv2-20020a1709072bc200b008666b08946bmr15536838ejc.39.1675554283160; Sat, 04 Feb 2023 15:44:43 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id u21-20020a170906125500b0089b6fd89429sm277825eja.10.2023.02.04.15.44.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 04 Feb 2023 15:44:42 -0800 (PST) Content-Type: multipart/mixed; boundary="------------3b0vRbBm5YdkSF5PIKdP8p0Z" Message-ID: Date: Sun, 5 Feb 2023 01:44:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US References: <837cwzw8j1.fsf@gnu.org> <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> <83k00zuejn.fsf@gnu.org> <83fsbmvj5x.fsf@gnu.org> <3f14adfd-8aef-9352-4c9a-fff71f4223fb@yandex.ru> <2a710b11-4e3c-3103-19ee-cf313526ad63@yandex.ru> <838rhdvs3c.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <838rhdvs3c.fsf@gnu.org> X-Spam-Score: 0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) This is a multi-part message in MIME format. --------------3b0vRbBm5YdkSF5PIKdP8p0Z Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 04/02/2023 08:53, Eli Zaretskii wrote: >> Date: Sat, 4 Feb 2023 05:36:15 +0200 >> From: Dmitry Gutov >> Cc:61205@debbugs.gnu.org,casouri@gmail.com,theo@thornhill.no,dev@rjt.dev >> >> Here's the updated patch in the meantime. > Thanks, but please also update the doc string of > treesit-font-lock-level. Done. >> Not sure what to do with 'type' highlighting in rust-ts-mode yet. > What is the problem with that? The nodes structure of a 'use' instruction has a lot of nesting, and at least a couple of variations, which would lead to a combinatoric increase in the number of queries. Taking another look at the declarations, though, I wasn't sure I could understand the specific logic for choosing between font-lock-type-face and font-lock-constant-face. It seemed heavily inspired by https://github.com/tree-sitter/tree-sitter-rust/blob/master/queries/highlights.scm, though. So what I did is reverted to those rules (in that area): the path segments that start with an uppercase char get highlighted with font-lock-type-face. The rest don't get highlighted at all. That's how Rust code looks at Github, so a fair number of developers must be okay with it. (Github also highlights function calls, though.) I'm also adding function parameter highlighting to rust and go modes. See the attached patch. I suggest we install it in emacs-29, but then people are free to tweak the rules further. --------------3b0vRbBm5YdkSF5PIKdP8p0Z Content-Type: text/x-patch; charset=UTF-8; name="ts-modes-refine-features.diff" Content-Disposition: attachment; filename="ts-modes-refine-features.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2RvYy9lbWFjcy9kaXNwbGF5LnRleGkgYi9kb2MvZW1hY3MvZGlzcGxh eS50ZXhpCmluZGV4IDk3NzMyYjY1ZTMyLi5hODZjMTJhMGRiNyAxMDA2NDQKLS0tIGEvZG9j L2VtYWNzL2Rpc3BsYXkudGV4aQorKysgYi9kb2MvZW1hY3MvZGlzcGxheS50ZXhpCkBAIC0x MTU5LDExICsxMTU5LDExIEBAIFBhcnNlci1iYXNlZCBGb250IExvY2sKIFRoaXMgbGV2ZWwg YWRkcyBmb250aWZpY2F0aW9uIG9mIGtleXdvcmRzLCBzdHJpbmdzLCBhbmQgZGF0YSB0eXBl cy4KIEBpdGVtIExldmVsIDMKIFRoaXMgaXMgdGhlIGRlZmF1bHQgbGV2ZWw7IGl0IGFkZHMg Zm9udGlmaWNhdGlvbiBvZiBhc3NpZ25tZW50cywKLW51bWJlcnMsIHByb3BlcnRpZXMsIGV0 Yy4KK251bWJlcnMsIGV0Yy4KIEBpdGVtIExldmVsIDQKIFRoaXMgbGV2ZWwgYWRkcyBldmVy eXRoaW5nIGVsc2UgdGhhdCBjYW4gYmUgZm9udGlmaWVkOiBvcGVyYXRvcnMsCiBkZWxpbWl0 ZXJzLCBicmFja2V0cywgb3RoZXIgcHVuY3R1YXRpb24sIGZ1bmN0aW9uIG5hbWVzIGluIGZ1 bmN0aW9uCi1jYWxscywgdmFyaWFibGVzLCBldGMuCitjYWxscywgcHJvcGVydHkgbG9vayB1 cHMsIHZhcmlhYmxlcywgZXRjLgogQGVuZCB0YWJsZQogCiBAdmluZGV4IHRyZWVzaXQtZm9u dC1sb2NrLWZlYXR1cmUtbGlzdApkaWZmIC0tZ2l0IGEvbGlzcC9wcm9nbW9kZXMvYy10cy1t b2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvYy10cy1tb2RlLmVsCmluZGV4IDJhMTY0YWYyNmVh Li43MzAwMDc0ZTVjNiAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvYy10cy1tb2RlLmVs CisrKyBiL2xpc3AvcHJvZ21vZGVzL2MtdHMtbW9kZS5lbApAQCAtNzc0LDggKzc3NCw4IEBA IGMtdHMtYmFzZS1tb2RlCiAgIChzZXRxLWxvY2FsIHRyZWVzaXQtZm9udC1sb2NrLWZlYXR1 cmUtbGlzdAogICAgICAgICAgICAgICAnKCggY29tbWVudCBkZWZpbml0aW9uKQogICAgICAg ICAgICAgICAgICgga2V5d29yZCBwcmVwcm9jZXNzb3Igc3RyaW5nIHR5cGUpCi0gICAgICAg ICAgICAgICAgKCBhc3NpZ25tZW50IGNvbnN0YW50IGVzY2FwZS1zZXF1ZW5jZSBsYWJlbCBs aXRlcmFsIHByb3BlcnR5ICkKLSAgICAgICAgICAgICAgICAoIGJyYWNrZXQgZGVsaW1pdGVy IGVycm9yIGZ1bmN0aW9uIG9wZXJhdG9yIHZhcmlhYmxlKSkpKQorICAgICAgICAgICAgICAg ICggYXNzaWdubWVudCBjb25zdGFudCBlc2NhcGUtc2VxdWVuY2UgbGFiZWwgbGl0ZXJhbCkK KyAgICAgICAgICAgICAgICAoIGJyYWNrZXQgZGVsaW1pdGVyIGVycm9yIGZ1bmN0aW9uIG9w ZXJhdG9yIHByb3BlcnR5IHZhcmlhYmxlKSkpKQogCiA7OzsjIyNhdXRvbG9hZAogKGRlZmlu ZS1kZXJpdmVkLW1vZGUgYy10cy1tb2RlIGMtdHMtYmFzZS1tb2RlICJDIgpkaWZmIC0tZ2l0 IGEvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2dvLXRz LW1vZGUuZWwKaW5kZXggOTVkY2Y2NTNmYzYuLjRiMTRlNTUyODFlIDEwMDY0NAotLS0gYS9s aXNwL3Byb2dtb2Rlcy9nby10cy1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2dvLXRz LW1vZGUuZWwKQEAgLTEyMywxNyArMTIzLDI2IEBAIGdvLXRzLW1vZGUtLWZvbnQtbG9jay1z ZXR0aW5ncwogICAgOmZlYXR1cmUgJ2RlbGltaXRlcgogICAgJygoWyIsIiAiLiIgIjsiICI6 Il0pIEBmb250LWxvY2stZGVsaW1pdGVyLWZhY2UpCiAKKyAgIDpsYW5ndWFnZSAnZ28KKyAg IDpmZWF0dXJlICdkZWZpbml0aW9uCisgICAnKChmdW5jdGlvbl9kZWNsYXJhdGlvbgorICAg ICAgbmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKQor ICAgICAobWV0aG9kX2RlY2xhcmF0aW9uCisgICAgICBuYW1lOiAoZmllbGRfaWRlbnRpZmll cikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCisgICAgIChtZXRob2Rfc3BlYwor ICAgICAgbmFtZTogKGZpZWxkX2lkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFt ZS1mYWNlKQorICAgICAoZmllbGRfZGVjbGFyYXRpb24KKyAgICAgIG5hbWU6IChmaWVsZF9p ZGVudGlmaWVyKSBAZm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCisgICAgIChwYXJhbWV0ZXJf ZGVjbGFyYXRpb24KKyAgICAgIG5hbWU6IChpZGVudGlmaWVyKSBAZm9udC1sb2NrLXZhcmlh YmxlLW5hbWUtZmFjZSkpCisKICAgIDpsYW5ndWFnZSAnZ28KICAgIDpmZWF0dXJlICdmdW5j dGlvbgogICAgJygoY2FsbF9leHByZXNzaW9uCiAgICAgICBmdW5jdGlvbjogKGlkZW50aWZp ZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKQogICAgICAoY2FsbF9leHByZXNz aW9uCiAgICAgICBmdW5jdGlvbjogKHNlbGVjdG9yX2V4cHJlc3Npb24KLSAgICAgICAgICAg ICAgICAgZmllbGQ6IChmaWVsZF9pZGVudGlmaWVyKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5h bWUtZmFjZSkpCi0gICAgIChmdW5jdGlvbl9kZWNsYXJhdGlvbgotICAgICAgbmFtZTogKGlk ZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKQotICAgICAobWV0aG9k X2RlY2xhcmF0aW9uCi0gICAgICBuYW1lOiAoZmllbGRfaWRlbnRpZmllcikgQGZvbnQtbG9j ay1mdW5jdGlvbi1uYW1lLWZhY2UpKQorICAgICAgICAgICAgICAgICBmaWVsZDogKGZpZWxk X2lkZW50aWZpZXIpIEBmb250LWxvY2stZnVuY3Rpb24tbmFtZS1mYWNlKSkpCiAKICAgIDps YW5ndWFnZSAnZ28KICAgIDpmZWF0dXJlICdrZXl3b3JkCkBAIC0yMjEsMTEgKzIzMCwxMCBA QCBnby10cy1tb2RlCiAgICAgOzsgRm9udC1sb2NrLgogICAgIChzZXRxLWxvY2FsIHRyZWVz aXQtZm9udC1sb2NrLXNldHRpbmdzIGdvLXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncykK ICAgICAoc2V0cS1sb2NhbCB0cmVlc2l0LWZvbnQtbG9jay1mZWF0dXJlLWxpc3QKLSAgICAg ICAgICAgICAgICAnKCggY29tbWVudCkKKyAgICAgICAgICAgICAgICAnKCggY29tbWVudCBk ZWZpbml0aW9uKQogICAgICAgICAgICAgICAgICAgKCBrZXl3b3JkIHN0cmluZyB0eXBlKQot ICAgICAgICAgICAgICAgICAgKCBjb25zdGFudCBlc2NhcGUtc2VxdWVuY2UgZnVuY3Rpb24g bGFiZWwgbnVtYmVyCi0gICAgICAgICAgICAgICAgICAgIHByb3BlcnR5IHZhcmlhYmxlKQot ICAgICAgICAgICAgICAgICAgKCBicmFja2V0IGRlbGltaXRlciBlcnJvciBvcGVyYXRvcikp KQorICAgICAgICAgICAgICAgICAgKCBjb25zdGFudCBlc2NhcGUtc2VxdWVuY2UgbGFiZWwg bnVtYmVyKQorICAgICAgICAgICAgICAgICAgKCBicmFja2V0IGRlbGltaXRlciBlcnJvciBm dW5jdGlvbiBvcGVyYXRvciBwcm9wZXJ0eSB2YXJpYWJsZSkpKQogCiAgICAgKHRyZWVzaXQt bWFqb3ItbW9kZS1zZXR1cCkpKQogCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9ydXN0 LXRzLW1vZGUuZWwgYi9saXNwL3Byb2dtb2Rlcy9ydXN0LXRzLW1vZGUuZWwKaW5kZXggZTMx Nzc5M2QyMTEuLjU3MjJkMDM3YmJhIDEwMDY0NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9ydXN0 LXRzLW1vZGUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvcnVzdC10cy1tb2RlLmVsCkBAIC0x NTUsNiArMTU1LDE2IEBAIHJ1c3QtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAgICA6 ZmVhdHVyZSAnZGVsaW1pdGVyCiAgICAnKChbIiwiICIuIiAiOyIgIjoiICI6OiJdKSBAZm9u dC1sb2NrLWRlbGltaXRlci1mYWNlKQogCisgICA6bGFuZ3VhZ2UgJ3J1c3QKKyAgIDpmZWF0 dXJlICdkZWZpbml0aW9uCisgICAnKChmdW5jdGlvbl9pdGVtIG5hbWU6IChpZGVudGlmaWVy KSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZSkKKyAgICAgKG1hY3JvX2RlZmluaXRp b24gIm1hY3JvX3J1bGVzISIgQGZvbnQtbG9jay1jb25zdGFudC1mYWNlKQorICAgICAobWFj cm9fZGVmaW5pdGlvbiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcmVwcm9jZXNzb3ItZmFj ZSkKKyAgICAgKGZpZWxkX2RlY2xhcmF0aW9uIG5hbWU6IChmaWVsZF9pZGVudGlmaWVyKSBA Zm9udC1sb2NrLXByb3BlcnR5LWZhY2UpCisgICAgIChwYXJhbWV0ZXIgcGF0dGVybjogKGlk ZW50aWZpZXIpIEBmb250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKQorICAgICAocGFyYW1l dGVyCisgICAgICBwYXR0ZXJuOiAocmVmZXJlbmNlX3BhdHRlcm4gKGlkZW50aWZpZXIpIEBm b250LWxvY2stdmFyaWFibGUtbmFtZS1mYWNlKSkpCisKICAgIDpsYW5ndWFnZSAncnVzdAog ICAgOmZlYXR1cmUgJ2Z1bmN0aW9uCiAgICAnKChjYWxsX2V4cHJlc3Npb24KQEAgLTE2NCwx NSArMTc0LDEyIEBAIHJ1c3QtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzCiAgICAgICAg IGZpZWxkOiAoZmllbGRfaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZh Y2UpCiAgICAgICAgKHNjb3BlZF9pZGVudGlmaWVyCiAgICAgICAgIG5hbWU6IChpZGVudGlm aWVyKSBAZm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZSldKQotICAgICAoZnVuY3Rpb25f aXRlbSAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpCiAgICAg IChnZW5lcmljX2Z1bmN0aW9uCiAgICAgICBmdW5jdGlvbjogWyhpZGVudGlmaWVyKSBAZm9u dC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZQogICAgICAgICAgICAgICAgICAoZmllbGRfZXhw cmVzc2lvbgogICAgICAgICAgICAgICAgICAgZmllbGQ6IChmaWVsZF9pZGVudGlmaWVyKSBA Zm9udC1sb2NrLWZ1bmN0aW9uLW5hbWUtZmFjZSkKICAgICAgICAgICAgICAgICAgKHNjb3Bl ZF9pZGVudGlmaWVyCiAgICAgICAgICAgICAgICAgICBuYW1lOiAoaWRlbnRpZmllcikgQGZv bnQtbG9jay1mdW5jdGlvbi1uYW1lLWZhY2UpXSkKLSAgICAgKG1hY3JvX2RlZmluaXRpb24g Im1hY3JvX3J1bGVzISIgQGZvbnQtbG9jay1jb25zdGFudC1mYWNlKQotICAgICAobWFjcm9f ZGVmaW5pdGlvbiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1wcmVwcm9jZXNzb3ItZmFjZSkK ICAgICAgKG1hY3JvX2ludm9jYXRpb24gbWFjcm86IChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LXByZXByb2Nlc3Nvci1mYWNlKSkKIAogICAgOmxhbmd1YWdlICdydXN0CkBAIC0yMDgsMjAg KzIxNSwyMCBAQCBydXN0LXRzLW1vZGUtLWZvbnQtbG9jay1zZXR0aW5ncwogICAgICAobW9k X2l0ZW0gbmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stY29uc3RhbnQtZmFjZSkKICAg ICAgKHByaW1pdGl2ZV90eXBlKSBAZm9udC1sb2NrLXR5cGUtZmFjZQogICAgICAodHlwZV9p ZGVudGlmaWVyKSBAZm9udC1sb2NrLXR5cGUtZmFjZQotICAgICAoc2NvcGVkX2lkZW50aWZp ZXIgbmFtZTogKGlkZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1mYWNlKQotICAgICAoc2Nv cGVkX2lkZW50aWZpZXIgcGF0aDogKGlkZW50aWZpZXIpIEBmb250LWxvY2stY29uc3RhbnQt ZmFjZSkKLSAgICAgKHNjb3BlZF9pZGVudGlmaWVyCi0gICAgICAoc2NvcGVkX2lkZW50aWZp ZXIKLSAgICAgICBwYXRoOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1jb25zdGFudC1mYWNl KSkKKyAgICAgKChzY29wZWRfaWRlbnRpZmllciBuYW1lOiAoaWRlbnRpZmllcikgQGZvbnQt bG9jay10eXBlLWZhY2UpCisgICAgICAoOm1hdGNoICJeW0EtWl0iIEBmb250LWxvY2stdHlw ZS1mYWNlKSkKKyAgICAgKChzY29wZWRfaWRlbnRpZmllciBwYXRoOiAoaWRlbnRpZmllcikg QGZvbnQtbG9jay10eXBlLWZhY2UpCisgICAgICAoOm1hdGNoICJeW0EtWl0iIEBmb250LWxv Y2stdHlwZS1mYWNlKSkKKyAgICAgKChzY29wZWRfaWRlbnRpZmllcgorICAgICAgICAoc2Nv cGVkX2lkZW50aWZpZXIKKyAgICAgICAgIHBhdGg6IChpZGVudGlmaWVyKSBAZm9udC1sb2Nr LXR5cGUtZmFjZSkpCisgICAgICAoOm1hdGNoICJeW0EtWl0iIEBmb250LWxvY2stdHlwZS1m YWNlKSkKICAgICAgKChzY29wZWRfaWRlbnRpZmllcgogICAgICAgIHBhdGg6IFsoaWRlbnRp ZmllcikgQGZvbnQtbG9jay10eXBlLWZhY2UKICAgICAgICAgICAgICAgKHNjb3BlZF9pZGVu dGlmaWVyCiAgICAgICAgICAgICAgICBuYW1lOiAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10 eXBlLWZhY2UpXSkKICAgICAgICg6bWF0Y2ggIl5bQS1aXSIgQGZvbnQtbG9jay10eXBlLWZh Y2UpKQogICAgICAoc2NvcGVkX3R5cGVfaWRlbnRpZmllciBwYXRoOiAoaWRlbnRpZmllcikg QGZvbnQtbG9jay1jb25zdGFudC1mYWNlKQotICAgICAoc2NvcGVkX3VzZV9saXN0Ci0gICAg ICBwYXRoOiBbKGlkZW50aWZpZXIpIEBmb250LWxvY2stY29uc3RhbnQtZmFjZQotICAgICAg ICAgICAgIChzY29wZWRfaWRlbnRpZmllciAoaWRlbnRpZmllcikgQGZvbnQtbG9jay1jb25z dGFudC1mYWNlKV0pCiAgICAgICh0eXBlX2lkZW50aWZpZXIpIEBmb250LWxvY2stdHlwZS1m YWNlCiAgICAgICh1c2VfYXNfY2xhdXNlIGFsaWFzOiAoaWRlbnRpZmllcikgQGZvbnQtbG9j ay10eXBlLWZhY2UpCiAgICAgICh1c2VfbGlzdCAoaWRlbnRpZmllcikgQGZvbnQtbG9jay10 eXBlLWZhY2UpKQpAQCAtMzE3LDExICszMjQsMTEgQEAgcnVzdC10cy1tb2RlCiAgICAgOzsg Rm9udC1sb2NrLgogICAgIChzZXRxLWxvY2FsIHRyZWVzaXQtZm9udC1sb2NrLXNldHRpbmdz IHJ1c3QtdHMtbW9kZS0tZm9udC1sb2NrLXNldHRpbmdzKQogICAgIChzZXRxLWxvY2FsIHRy ZWVzaXQtZm9udC1sb2NrLWZlYXR1cmUtbGlzdAotICAgICAgICAgICAgICAgICcoKCBjb21t ZW50KQorICAgICAgICAgICAgICAgICcoKCBjb21tZW50IGRlZmluaXRpb24pCiAgICAgICAg ICAgICAgICAgICAoIGtleXdvcmQgc3RyaW5nKQogICAgICAgICAgICAgICAgICAgKCBhdHRy aWJ1dGUgYnVpbHRpbiBjb25zdGFudCBlc2NhcGUtc2VxdWVuY2UKLSAgICAgICAgICAgICAg ICAgICAgZnVuY3Rpb24gbnVtYmVyIHByb3BlcnR5IHR5cGUgdmFyaWFibGUpCi0gICAgICAg ICAgICAgICAgICAoIGJyYWNrZXQgZGVsaW1pdGVyIGVycm9yIG9wZXJhdG9yKSkpCisgICAg ICAgICAgICAgICAgICAgIG51bWJlciB0eXBlKQorICAgICAgICAgICAgICAgICAgKCBicmFj a2V0IGRlbGltaXRlciBlcnJvciBmdW5jdGlvbiBvcGVyYXRvciBwcm9wZXJ0eSB2YXJpYWJs ZSkpKQogCiAgICAgOzsgSW1lbnUuCiAgICAgKHNldHEtbG9jYWwgdHJlZXNpdC1zaW1wbGUt aW1lbnUtc2V0dGluZ3MKZGlmZiAtLWdpdCBhL2xpc3AvdHJlZXNpdC5lbCBiL2xpc3AvdHJl ZXNpdC5lbAppbmRleCA5OGY0NDZhMTQ1Ni4uMjU2MmUxMjg2YzcgMTAwNjQ0Ci0tLSBhL2xp c3AvdHJlZXNpdC5lbAorKysgYi9saXNwL3RyZWVzaXQuZWwKQEAgLTU4NSw5ICs1ODUsMTAg QEAgdHJlZXNpdC1mb250LWxvY2stbGV2ZWwKIExldmVsIDEgdXN1YWxseSBjb250YWlucyBv bmx5IGNvbW1lbnRzIGFuZCBkZWZpbml0aW9ucy4KIExldmVsIDIgdXN1YWxseSBhZGRzIGtl eXdvcmRzLCBzdHJpbmdzLCBkYXRhIHR5cGVzLCBldGMuCiBMZXZlbCAzIHVzdWFsbHkgcmVw cmVzZW50cyBmdWxsLWJsb3duIGZvbnRpZmljYXRpb25zLCBpbmNsdWRpbmcKLWFzc2lnbm1l bnRzLCBjb25zdGFudHMsIG51bWJlcnMgYW5kIGxpdGVyYWxzLCBwcm9wZXJ0aWVzLCBldGMu Cithc3NpZ25tZW50cywgY29uc3RhbnRzLCBudW1iZXJzIGFuZCBsaXRlcmFscywgZXRjLgog TGV2ZWwgNCBhZGRzIGV2ZXJ5dGhpbmcgZWxzZSB0aGF0IGNhbiBiZSBmb250aWZpZWQ6IGRl bGltaXRlcnMsCi1vcGVyYXRvcnMsIGJyYWNrZXRzLCBwdW5jdHVhdGlvbiwgYWxsIGZ1bmN0 aW9ucyBhbmQgdmFyaWFibGVzLCBldGMuCitvcGVyYXRvcnMsIGJyYWNrZXRzLCBwdW5jdHVh dGlvbiwgYWxsIGZ1bmN0aW9ucywgcHJvcGVydGllcywKK3ZhcmlhYmxlcywgZXRjLgogCiBJ biBhZGRpdGlvbiB0byB0aGUgZGVjb3JhdGlvbiBsZXZlbCwgaW5kaXZpZHVhbCBmZWF0dXJl cyBjYW4gYmUKIHR1cm5lZCBvbi9vZmYgYnkgY2FsbGluZyBgdHJlZXNpdC1mb250LWxvY2st cmVjb21wdXRlLWZlYXR1cmVzJy4K --------------3b0vRbBm5YdkSF5PIKdP8p0Z-- From unknown Sat Jun 21 03:21:42 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Feb 2023 06:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61205 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev Received: via spool by 61205-submit@debbugs.gnu.org id=B61205.167557714111390 (code B ref 61205); Sun, 05 Feb 2023 06:06:02 +0000 Received: (at 61205) by debbugs.gnu.org; 5 Feb 2023 06:05:41 +0000 Received: from localhost ([127.0.0.1]:43838 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOY9l-0002xc-Dt for submit@debbugs.gnu.org; Sun, 05 Feb 2023 01:05:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOY9j-0002xP-6d for 61205@debbugs.gnu.org; Sun, 05 Feb 2023 01:05:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOY9d-0002Gj-Lt; Sun, 05 Feb 2023 01:05:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9myTdCCtzyvAga7YowBucJP6Mr9P4bgortPgPWn/Pn8=; b=dEdIAZZiwMzn UpMRlN/PgIDKUHe2fAY4IggMvYbQqgWClprElXNKbIZbr3jI4s7ccLJhtyUEIL6XXtXp9tLnRzxXA 9axMZVWh5aL6jcuDRfM9h5VCfS/WQfNZ96qT1k6w2F2hpS47oy7by0icX4yFSzdLfL2bc9PhPgZcR I3I/0enUn7udBBPgwhoCksOSPgc/pgs1QZHAJZQEyRAyLwFBGusBOWO20iIchs06tmCwkUGRw6Q5I AUPsrGMtjYC/aFQoP6v807agieTJ5o/lSZG6tE7hOXndnWoHgMUw0wLmW2GF/36t7xXvR4U5fBXo/ eAMCsLOR2gUWAEJczgNhzA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOY9c-0007ZH-TL; Sun, 05 Feb 2023 01:05:33 -0500 Date: Sun, 05 Feb 2023 08:05:42 +0200 Message-Id: <83y1pcsl3d.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Dmitry Gutov on Sun, 5 Feb 2023 01:44:40 +0200) References: <837cwzw8j1.fsf@gnu.org> <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> <83k00zuejn.fsf@gnu.org> <83fsbmvj5x.fsf@gnu.org> <3f14adfd-8aef-9352-4c9a-fff71f4223fb@yandex.ru> <2a710b11-4e3c-3103-19ee-cf313526ad63@yandex.ru> <838rhdvs3c.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 5 Feb 2023 01:44:40 +0200 > Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev > From: Dmitry Gutov > > On 04/02/2023 08:53, Eli Zaretskii wrote: > >> Date: Sat, 4 Feb 2023 05:36:15 +0200 > >> From: Dmitry Gutov > >> Cc:61205@debbugs.gnu.org,casouri@gmail.com,theo@thornhill.no,dev@rjt.dev > >> > >> Here's the updated patch in the meantime. > > Thanks, but please also update the doc string of > > treesit-font-lock-level. > > Done. Thanks, LGTM. > >> Not sure what to do with 'type' highlighting in rust-ts-mode yet. > > What is the problem with that? > > The nodes structure of a 'use' instruction has a lot of nesting, and at > least a couple of variations, which would lead to a combinatoric > increase in the number of queries. If this proves to be a problem in practice, maybe we'll need some customization specific to Rust. > Taking another look at the declarations, though, I wasn't sure I could > understand the specific logic for choosing between font-lock-type-face > and font-lock-constant-face. > > It seemed heavily inspired by > https://github.com/tree-sitter/tree-sitter-rust/blob/master/queries/highlights.scm, > though. So what I did is reverted to those rules (in that area): the > path segments that start with an uppercase char get highlighted with > font-lock-type-face. The rest don't get highlighted at all. That's how > Rust code looks at Github, so a fair number of developers must be okay > with it. And this solves the potential combinatoric explosion? > See the attached patch. I suggest we install it in emacs-29, but then > people are free to tweak the rules further. Yes, please install. From unknown Sat Jun 21 03:21:42 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Dmitry Gutov Subject: bug#61205: closed (Re: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list) Message-ID: References: X-Gnu-PR-Message: they-closed 61205 X-Gnu-PR-Package: emacs Reply-To: 61205@debbugs.gnu.org Date: Sun, 05 Feb 2023 13:53:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1675605181-867-1" This is a multi-part message in MIME format... ------------=_1675605181-867-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61205: 'function' in 3rd element of treesit-font-lock-feature-list which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61205@debbugs.gnu.org. --=20 61205: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61205 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1675605181-867-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61205-done) by debbugs.gnu.org; 5 Feb 2023 13:52:20 +0000 Received: from localhost ([127.0.0.1]:44415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOfRM-0000D5-CN for submit@debbugs.gnu.org; Sun, 05 Feb 2023 08:52:20 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:42973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOfRK-0000Cp-4H for 61205-done@debbugs.gnu.org; Sun, 05 Feb 2023 08:52:18 -0500 Received: by mail-wm1-f51.google.com with SMTP id j29-20020a05600c1c1d00b003dc52fed235so6991499wms.1 for <61205-done@debbugs.gnu.org>; Sun, 05 Feb 2023 05:52:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=+Gobggtz3idA37cn6ugO7lw90hLQUDUSh20z3qArdQE=; b=PLLfqa1djeAt1tsHXKpWa06Q+Ern8fJtcYKe56hhL4ySaYyE6PGu48MdPJRDISUYWt WbhYcTJMN1Fdr7g923epfFXGBvJODDTS/b+X+5rOYBv6v5SsjH3DpRiEyP+uwSNfOxvT vQPT61Z1zga1s1389apHEityCRuccnj99xbpjXaPy06bebETpGcC86pjV3UnAFq5ETE2 pavroI7Lmfo9ZgFjgvj0RqV4SC3X3D6vOuZbKKO166hhJepx7TrNJECJdJWElMov0m5U 2hwaMJslBxLJwrCBH+M8DzePjNsgJ7SItYGuaMnPjoDZX8wkzjK/Siokk/4eokckoElD TJmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+Gobggtz3idA37cn6ugO7lw90hLQUDUSh20z3qArdQE=; b=Bx+IiA9p8DeuYb6spkuTgDqXYsaPUwtJub9V6NJqxa0p00sagAvxUicbIH9cg9Aa8X di/BpabUqVrDB3/OlNik43kKza9t6uSRptjHk7iAamaEDhTrCSbpKwfi5yENwt3QImoE s9q89TvXCndRKs2UNaXM8Ew1aEGH4DPa/1BvN/RYaJhf7ETkorM7sdoqtHMAUZcs/U3e HiO0JBRlfFUnhB/d9/LkJvqNusGWUj++a7ZstlkgEgYzOT1TeChXFXjNdJaaXtEx75Yf bfut1dIm435d3mJ7lGiwbddSQ+nfRL2ijsxqCgz24CL97CqinbwsVY9zuv5bHe0dbjWk ULoA== X-Gm-Message-State: AO0yUKVWBIK5TkfNvu1a3DL+VqSSXcZCLttAdAZ7WjPoTJYKZ+SwOe5P Z/rMmsmJZ9rMqidglDDlrXQ= X-Google-Smtp-Source: AK7set+EBbsJ+Fac4FjU+vBryXrO/suliFnaTEPhZFOqLCW4/zIEr7SNEPguVa9R8D5AaN1sEkjsFA== X-Received: by 2002:a05:600c:4395:b0:3df:9858:c02c with SMTP id e21-20020a05600c439500b003df9858c02cmr8925147wmn.1.1675605132287; Sun, 05 Feb 2023 05:52:12 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c17-20020a7bc851000000b003dc530186e1sm13327934wml.45.2023.02.05.05.52.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Feb 2023 05:52:11 -0800 (PST) Message-ID: Date: Sun, 5 Feb 2023 15:52:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#61205: 'function' in 3rd element of treesit-font-lock-feature-list Content-Language: en-US To: Eli Zaretskii References: <837cwzw8j1.fsf@gnu.org> <1b8044bd-6855-fdc7-697d-70322a8349c0@yandex.ru> <83k00zuejn.fsf@gnu.org> <83fsbmvj5x.fsf@gnu.org> <3f14adfd-8aef-9352-4c9a-fff71f4223fb@yandex.ru> <2a710b11-4e3c-3103-19ee-cf313526ad63@yandex.ru> <838rhdvs3c.fsf@gnu.org> <83y1pcsl3d.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83y1pcsl3d.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 61205-done Cc: dev@rjt.dev, casouri@gmail.com, 61205-done@debbugs.gnu.org, theo@thornhill.no X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 05/02/2023 08:05, Eli Zaretskii wrote: >> Date: Sun, 5 Feb 2023 01:44:40 +0200 >> Cc: 61205@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no, dev@rjt.dev >> From: Dmitry Gutov >> >> On 04/02/2023 08:53, Eli Zaretskii wrote: >>>> Date: Sat, 4 Feb 2023 05:36:15 +0200 >>>> From: Dmitry Gutov >>>> Cc:61205@debbugs.gnu.org,casouri@gmail.com,theo@thornhill.no,dev@rjt.dev >>>> >>>> Here's the updated patch in the meantime. >>> Thanks, but please also update the doc string of >>> treesit-font-lock-level. >> >> Done. > > Thanks, LGTM. > >>>> Not sure what to do with 'type' highlighting in rust-ts-mode yet. >>> What is the problem with that? >> >> The nodes structure of a 'use' instruction has a lot of nesting, and at >> least a couple of variations, which would lead to a combinatoric >> increase in the number of queries. > > If this proves to be a problem in practice, maybe we'll need some > customization specific to Rust. > >> Taking another look at the declarations, though, I wasn't sure I could >> understand the specific logic for choosing between font-lock-type-face >> and font-lock-constant-face. >> >> It seemed heavily inspired by >> https://github.com/tree-sitter/tree-sitter-rust/blob/master/queries/highlights.scm, >> though. So what I did is reverted to those rules (in that area): the >> path segments that start with an uppercase char get highlighted with >> font-lock-type-face. The rest don't get highlighted at all. That's how >> Rust code looks at Github, so a fair number of developers must be okay >> with it. > > And this solves the potential combinatoric explosion? Yes, simply because function names don't start with a capital letter by convention. So we don't highlight them as types. >> See the attached patch. I suggest we install it in emacs-29, but then >> people are free to tweak the rules further. > > Yes, please install. Thank you, done, and closing. ------------=_1675605181-867-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 1 Feb 2023 02:08:46 +0000 Received: from localhost ([127.0.0.1]:55439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pN2YI-0007NH-EO for submit@debbugs.gnu.org; Tue, 31 Jan 2023 21:08:46 -0500 Received: from lists.gnu.org ([209.51.188.17]:37120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pN2YF-0007N6-NZ for submit@debbugs.gnu.org; Tue, 31 Jan 2023 21:08:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pN2YF-0001sC-HW for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 21:08:43 -0500 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pN2YD-0002f5-KW for bug-gnu-emacs@gnu.org; Tue, 31 Jan 2023 21:08:43 -0500 Received: by mail-ed1-x52b.google.com with SMTP id fi26so16233649edb.7 for ; Tue, 31 Jan 2023 18:08:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=dX43fHdpZJ7kxlOzMCPpuK+I7QzybYOi95AU+ehewaI=; b=n2uFIvxvCVYRAZp9nBVc3Zw+OF3cevOc0tAWGnf3MLQJUi2SOUlt23x4FCTLDdg0BX Z5wr+PG3avH9rugNRNxYPejoZhlIKBVCW20PCYki0W+qB9LWRgI7Py5XTmsQsqAXo7Oe Ulvcgf8eg+tfQK57iliho3Zt9hCoBq3VeMEhKpp0JizjTavXiTNPUi7k4QMpFwj2OCrd aPECnoxhMr+SQlgrdE5KIvX1tZr1DRVtFULU1CE18bcc4fR2bZT+g1610FVUYHBCLizg /nZrcq/1TfBs4mqWrVyWrc57p6467iKvw3PINRuJFBP8LHIVkvUpd6sqnJQrbf2q3fAB Eg2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dX43fHdpZJ7kxlOzMCPpuK+I7QzybYOi95AU+ehewaI=; b=Jn9FLOrjtIJBYCQZ/ZAdxpkLILGfYnaQh7Lro490diayXGUOPmpGzT2smEVqVKr6WH RLHnkTh4itNfnhIWiMgSfzkPcS2SP6M1f7yCvs4lPOL5ybpyJgwIJEIMID0Go2ErvwU8 MnWVxDBiJeKxJERqwtvvhZk79F9bImcRP2kQKv/eV9LBvLSIvxMTTkk4tiOc/ge5SLoP tVNBe5Mv9d8oElZuYLIju59+ptnQHQN83xdfDTyhZdMLvyIdInl6p2uLssSQgrS0Wtvt Nd0lyd5JTdVFiAulUQhnq2/iq1JOEjBzaeZgoISNXwPhjzYmjXckdkCKIw9yl3EJUjFM D/yA== X-Gm-Message-State: AO0yUKVqGrN9TZsaM1QmgplqX5sdjyss/nXBKS/MImIeNAJYF80G1xIa adjdRh49FCEXycFGP2hcFY3EanyJbP0= X-Google-Smtp-Source: AK7set+VNpXmcHoTuX0BIRbvtneS/IeZGkYxT/b4r4BVae6ov6oCbovjhHIJkn/yxhZNj8WsQ+KKzw== X-Received: by 2002:a05:6402:370e:b0:48f:68b1:db4e with SMTP id ek14-20020a056402370e00b0048f68b1db4emr205833edb.27.1675217320014; Tue, 31 Jan 2023 18:08:40 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id jo17-20020a170906f6d100b008785b914883sm9255971ejb.116.2023.01.31.18.08.38 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Jan 2023 18:08:39 -0800 (PST) Message-ID: Date: Wed, 1 Feb 2023 04:08:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Dmitry Gutov Subject: 'function' in 3rd element of treesit-font-lock-feature-list Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=raaahh@gmail.com; helo=mail-ed1-x52b.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) X-Debbugs-Cc: Yuan Fu , Randy Taylor Some new built-in modes has 'function' feature highlighting thus enabled by default. rust-ts-mode, go-ts-mode, cmake-mode Should we move it to 4 for consistency with the rest? Previously, we talked about that and concluded that function calls are usually everywhere and are easy to notice without additional highlighting. ------------=_1675605181-867-1--