From unknown Sun Jun 22 22:46:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61201: Installation hint crashes when user names contain at sign Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Tue, 31 Jan 2023 17:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 61201@debbugs.gnu.org X-Debbugs-Original-To: bug-guix@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167518475821061 (code B ref -1); Tue, 31 Jan 2023 17:06:01 +0000 Received: (at submit) by debbugs.gnu.org; 31 Jan 2023 17:05:58 +0000 Received: from localhost ([127.0.0.1]:54857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMu50-0005Td-3J for submit@debbugs.gnu.org; Tue, 31 Jan 2023 12:05:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:38682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMu4v-0005TS-8A for submit@debbugs.gnu.org; Tue, 31 Jan 2023 12:05:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMu4r-0008IC-Na for bug-guix@gnu.org; Tue, 31 Jan 2023 12:05:50 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMu4p-0005QU-B1 for bug-guix@gnu.org; Tue, 31 Jan 2023 12:05:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=qBB0pTO81SJVFyNcZSfxDzB6qrV0tj1/W13UUSHeKXA=; b=GgPrtsAeQp+tHtf9KC123tzG1hDDWUUsV+12mBqoFtd5TuA296bO+0Nr 4ETHaaZzdLnim7ZKhiM+OWgPcV8S4cM3b5b/cLWO44Nw7+gcF85C58tSV 9GnbOA0/rJ2GaD1DIrFSH6XnnBAmpOmBCGoAjCVX1ymVAxzHl1YIwWndT c=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=ludovic.courtes@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.97,261,1669071600"; d="scan'208";a="46500912" Received: from unknown (HELO ribbon) ([193.50.110.131]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 18:05:42 +0100 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Duodi 12 =?UTF-8?Q?Pluvi=C3=B4se?= an 231 de la =?UTF-8?Q?R=C3=A9volution,?= jour du Brocoli X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 31 Jan 2023 18:05:40 +0100 Message-ID: <87edratz17.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=192.134.164.104; envelope-from=ludovic.courtes@inria.fr; helo=mail3-relais-sop.national.inria.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) A funny thing was reported earlier today on the Caf=C3=A9 Guix channel: --8<---------------cut here---------------start------------->8--- $ guix install hello [17:52] building profile with 5 packages... hint: Backtrace: 17 (primitive-load "/usr/local/bin/guix") In guix/ui.scm: 2279:7 16 (run-guix . ) 2242:10 15 (run-guix-command _ . ) In ice-9/boot-9.scm: 1752:10 14 (with-exception-handler _ _ #:unwind? _ # ) In guix/status.scm: 835:3 13 () 815:4 12 (call-with-status-report _ ) In guix/store.scm: 1300:8 11 (call-with-build-handler _ ) 1300:8 10 (call-with-build-handler # ?) In guix/build/syscalls.scm: 1440:3 9 () 1407:4 8 (call-with-file-lock/no-wait _ _ ) In guix/scripts/package.scm: 325:7 7 (build-and-use-profile _ "/var/guix/profiles/per-user/?" ?) In guix/ui.scm: 312:5 6 (display-hint _ ) 1451:24 5 (texi->plain-text ) In texinfo.scm: 1132:22 4 (parse ) 980:31 3 (loop # (fragment) _ _ ) 967:36 2 (loop # #f # ?) 92:2 1 (command-spec ) In ice-9/boot-9.scm: 1685:16 0 (raise-exception _ #:continuable? ) =20 ice-9/boot-9.scm:1685:16: In procedure raise-exception: Throw to key #E1E1E1">parser-error' with args(#f "Unknown command" univ)'. --8<---------------cut here---------------end--------------->8--- This is because the user name ends in =E2=80=9C@univ=E2=80=A6=E2=80=9D, whi= ch =E2=80=98display-hint=E2=80=99 interprets as Texinfo. Ludo=E2=80=99. From unknown Sun Jun 22 22:46:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61201: Installation hint crashes when user names contain at sign Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 24 Feb 2023 10:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 61201@debbugs.gnu.org Received: via spool by 61201-submit@debbugs.gnu.org id=B61201.167723451831112 (code B ref 61201); Fri, 24 Feb 2023 10:29:02 +0000 Received: (at 61201) by debbugs.gnu.org; 24 Feb 2023 10:28:38 +0000 Received: from localhost ([127.0.0.1]:36003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVVJe-00085i-5V for submit@debbugs.gnu.org; Fri, 24 Feb 2023 05:28:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVVJc-00085W-MG for 61201@debbugs.gnu.org; Fri, 24 Feb 2023 05:28:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVVJX-0000LH-EC for 61201@debbugs.gnu.org; Fri, 24 Feb 2023 05:28:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=z/A2nghfBijI+gcXaoBwUxys/iUu4hXExBgEUiSwsQI=; b=G950BNq1vYzLraAr0MMP S9VxI6ESJLjHye+7xVq9l6CQq4JyDa7EOWrEX7Q2x/B/vGdKJ99LGYRgeXvRMuojUQQiS9o7MB/8w UH51YE5dpgLXMZ99bl4MrugLDSOtTffejKMWdEq9wtW1/JgsKVVJt7HHWQnN8PHfOXuo1fJYy8qG7 r7Snd8Ix9+sPf2hIRr2G9ViVYtms5knZ4znIjvvpyHaPaZAGmG66BNPGFE2OfmsRkeKJpofgjZZyZ YXYI9fz1BMlKDPAySsGU5vtO9pzWpB3Rpaf1OxuS3DSl3SWMrduWEKPQ8sO5AJDpPMFwkNRcJnlSj F8D/ONKSfZfGlA==; Received: from [2001:660:6102:320:e120:2c8f:8909:cdfe] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVVJX-0007Ty-19 for 61201@debbugs.gnu.org; Fri, 24 Feb 2023 05:28:31 -0500 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87edratz17.fsf@inria.fr> Date: Fri, 24 Feb 2023 11:28:27 +0100 In-Reply-To: <87edratz17.fsf@inria.fr> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 31 Jan 2023 18:05:40 +0100") Message-ID: <87sfev2w8k.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > A funny thing was reported earlier today on the Caf=C3=A9 Guix channel: > > $ guix install hello [17:52] > building profile with 5 packages... > hint: Backtrace: [...] > In guix/ui.scm: > 312:5 6 (display-hint _ ) > 1451:24 5 (texi->plain-text ) > In texinfo.scm: > 1132:22 4 (parse ) > 980:31 3 (loop # (fragment) _ _ ) > 967:36 2 (loop # #f # ?) > 92:2 1 (command-spec ) > In ice-9/boot-9.scm: > 1685:16 0 (raise-exception _ #:continuable? ) >=20=20 > ice-9/boot-9.scm:1685:16: In procedure raise-exception: > Throw to key #E1E1E1">parser-error' with args(#f "Unknown command" univ)'. Here=E2=80=99s one way to reproduce the bug, showing a crash in =E2=80=98di= splay-hint=E2=80=99 due to an unescaped brace: --8<---------------cut here---------------start------------->8--- $ mkdir /tmp/x{ample $ touch /tmp/x{ample/guix.scm $ (cd '/tmp/x{ample' ; guix shell) guix shell: error: not loading '/tmp/x{ample/guix.scm' because not authoriz= ed to do so hint: Backtrace: 13 (primitive-load "/home/ludo/.config/guix/current/bin/guix") In guix/ui.scm: 2279:7 12 (run-guix . _) 2242:10 11 (run-guix-command _ . _) In ice-9/boot-9.scm: 1752:10 10 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _) In guix/scripts/shell.scm: 308:15 9 (_) In guix/ui.scm: 312:5 8 (display-hint _ _) 1451:24 7 (texi->plain-text _) In texinfo.scm: 1132:22 6 (parse _) 980:31 5 (loop # (*fragment*) _ _ _) 980:31 4 (loop # #f _ _ _) 911:31 3 (loop # #f # #f _) 746:27 2 (_ # #f (example smallexample verb= atim lisp smalllisp menu w %) # = =E2=80=A6) In sxml/ssax/input-parse.scm: 88:2 1 (next-token _ _ _ _) In ice-9/boot-9.scm: 1685:16 0 (raise-exception _ #:continuable? _) ice-9/boot-9.scm:1685:16: In procedure raise-exception: Throw to key `parser-error' with args `(# "EOF = while reading a token " "reading char data")'. --8<---------------cut here---------------end--------------->8--- Ludo=E2=80=99. From unknown Sun Jun 22 22:46:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61201: Installation hint crashes when user names contain at sign Resent-From: Csepp Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Fri, 24 Feb 2023 11:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61201 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 61201@debbugs.gnu.org X-Debbugs-Original-Cc: bug-guix@gnu.org, 61201@debbugs.gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167723766922333 (code B ref -1); Fri, 24 Feb 2023 11:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Feb 2023 11:21:09 +0000 Received: from localhost ([127.0.0.1]:36074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVW8S-0005o4-Kg for submit@debbugs.gnu.org; Fri, 24 Feb 2023 06:21:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:37284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pVW8Q-0005np-1l for submit@debbugs.gnu.org; Fri, 24 Feb 2023 06:21:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVW8P-0007BD-Hi for bug-guix@gnu.org; Fri, 24 Feb 2023 06:21:05 -0500 Received: from mx1.riseup.net ([198.252.153.129]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pVW8N-0000H8-Ff; Fri, 24 Feb 2023 06:21:05 -0500 Received: from fews2.riseup.net (fews2-pn.riseup.net [10.0.1.84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx1.riseup.net (Postfix) with ESMTPS id 4PNSBP0tkXzDqhC; Fri, 24 Feb 2023 11:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1677237661; bh=JqmNmdOQ9q5xm6077fAnkaCds2LmazVamJh3mC9pMxM=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=i/X8WHKNuNGRNFiVD34xS5I1wuWDISRKA1ysAnoHZv8nWk+XPlQF3A9Ppr/lszOgw gwlujGwRZufut/DBB7QLY1ilK9ziFT6hpVqnZx7xGnvwXHl982TM9B0YGZkQSH9J8z wtSTtM/8bYzqGvePSs1rXPgBSSjg01byKGVUuYV8= X-Riseup-User-ID: 28761947B21C0B8242D27141D73C0A26374C39310E3E7EE1E4BD54D866E6722C Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews2.riseup.net (Postfix) with ESMTPSA id 4PNSBN3DgLz1y7V; Fri, 24 Feb 2023 11:21:00 +0000 (UTC) References: <87edratz17.fsf@inria.fr> <87sfev2w8k.fsf@gnu.org> From: Csepp Date: Fri, 24 Feb 2023 12:18:36 +0100 In-reply-to: <87sfev2w8k.fsf@gnu.org> Message-ID: <87h6vbjomm.fsf@riseup.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=198.252.153.129; envelope-from=raingloom@riseup.net; helo=mx1.riseup.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Ludovic Court=C3=A8s writes: > Ludovic Court=C3=A8s skribis: > >> A funny thing was reported earlier today on the Caf=C3=A9 Guix channel: >> >> $ guix install hello [17:52] >> building profile with 5 packages... >> hint: Backtrace: > > [...] > >> In guix/ui.scm: >> 312:5 6 (display-hint _ ) >> 1451:24 5 (texi->plain-text ) >> In texinfo.scm: >> 1132:22 4 (parse ) >> 980:31 3 (loop # (fragment) _ _ ) >> 967:36 2 (loop # #f # ?) >> 92:2 1 (command-spec ) >> In ice-9/boot-9.scm: >> 1685:16 0 (raise-exception _ #:continuable? ) >>=20=20 >> ice-9/boot-9.scm:1685:16: In procedure raise-exception: >> Throw to key #E1E1E1">parser-error' with args(#f "Unknown command" univ)= '. > > Here=E2=80=99s one way to reproduce the bug, showing a crash in =E2=80=98= display-hint=E2=80=99 > due to an unescaped brace: > > $ mkdir /tmp/x{ample > $ touch /tmp/x{ample/guix.scm > $ (cd '/tmp/x{ample' ; guix shell) > guix shell: error: not loading '/tmp/x{ample/guix.scm' because not author= ized to do so > hint: Backtrace: > 13 (primitive-load "/home/ludo/.config/guix/current/bin/guix") > In guix/ui.scm: > 2279:7 12 (run-guix . _) > 2242:10 11 (run-guix-command _ . _) > In ice-9/boot-9.scm: > 1752:10 10 (with-exception-handler _ _ #:unwind? _ #:unwind-for-type _) > In guix/scripts/shell.scm: > 308:15 9 (_) > In guix/ui.scm: > 312:5 8 (display-hint _ _) > 1451:24 7 (texi->plain-text _) > In texinfo.scm: > 1132:22 6 (parse _) > 980:31 5 (loop # (*fragment*) _ _ _) > 980:31 4 (loop # #f _ _ _) > 911:31 3 (loop # #f # #f _) > 746:27 2 (_ # #f (example smallexample ve= rbatim lisp smalllisp menu w %) #= =E2=80=A6) > In sxml/ssax/input-parse.scm: > 88:2 1 (next-token _ _ _ _) > In ice-9/boot-9.scm: > 1685:16 0 (raise-exception _ #:continuable? _) > > ice-9/boot-9.scm:1685:16: In procedure raise-exception: > Throw to key `parser-error' with args `(# "EO= F while reading a token " "reading char data")'. > > Ludo=E2=80=99. Would it be heresy to recommend that plain strings and strings that contain texinfo markup be separate types to catch this sort of thing? In 2023 it's pretty embarrassing to have bugs that are basically SQL injections. From unknown Sun Jun 22 22:46:34 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Subject: bug#61201: closed (Re: bug#61749: [PATCH] ui: 'display-hint' quotes extra arguments for Texinfo.) Message-ID: References: <877cw2g1m3.fsf_-_@gnu.org> <87edratz17.fsf@inria.fr> X-Gnu-PR-Message: they-closed 61201 X-Gnu-PR-Package: guix Reply-To: 61201@debbugs.gnu.org Date: Mon, 27 Feb 2023 22:56:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1677538562-2702-1" This is a multi-part message in MIME format... ------------=_1677538562-2702-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61201: Installation hint crashes when user names contain at sign which was filed against the guix package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61201@debbugs.gnu.org. --=20 61201: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61201 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1677538562-2702-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61201-done) by debbugs.gnu.org; 27 Feb 2023 22:55:52 +0000 Received: from localhost ([127.0.0.1]:49165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWmPP-0000h4-Je for submit@debbugs.gnu.org; Mon, 27 Feb 2023 17:55:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pWmPM-0000gm-Ln; Mon, 27 Feb 2023 17:55:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWmPF-0007pK-Pr; Mon, 27 Feb 2023 17:55:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=z2aIy8s2H0GNytO5lOJd6XMzxZqnxU0GwzphAzCT0E8=; b=DACsZ7HEfhwbQZLnqONX 1ubUWY5ebqrToO5mzQc2g3HtoegVi25lF906/KIV7/qtQH4+f3490ZGzybeotFRGsW7M9gMR7LwWA 5Z1/YREgQ/PH95JdwbKp/Z7YEBVfgbSRI7bs+ESjyAn/4eyKeHHlpcztVo6R6/IbPw1GfCDVz9ACK Jz5YhfPjJCfG3w0I9eOMzc9LjQg3WW2q9vtC+trBDleC6+T57APGizXVg6UtNhpGn+F1JqrxGtZ4d u5CoxRZu9kYGRCZ15THrEEhxNPbT4kKKZY6FQWsPnFkZ11frYNDg50tjl2veIzPNhY+m8lSXTiGN5 KlpW69pec+TETQ==; Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pWmOx-0006Qq-NV; Mon, 27 Feb 2023 17:55:37 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: 61749-done@debbugs.gnu.org Subject: Re: bug#61749: [PATCH] ui: 'display-hint' quotes extra arguments for Texinfo. References: <87sfev2w8k.fsf@gnu.org> <20230224104004.19319-1-ludo@gnu.org> Date: Mon, 27 Feb 2023 23:55:16 +0100 In-Reply-To: <20230224104004.19319-1-ludo@gnu.org> ("Ludovic =?utf-8?Q?Cou?= =?utf-8?Q?rt=C3=A8s=22's?= message of "Fri, 24 Feb 2023 11:40:04 +0100") Message-ID: <877cw2g1m3.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61201-done Cc: 61201-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Ludovic Court=C3=A8s skribis: > Fixes . > > Previously, common practice was to splice arbitrary strings (user names, > file names, etc.) into Texinfo snippets passed to 'display-hint'. This > is unsafe in the general case because at signs and braces need to be > escaped to produced valid Texinfo. This commit addresses that. > > * guix/ui.scm (texinfo-quote): New procedure. > (display-hint): When ARGUMENTS is non-empty, pass it to 'texinfo-quote' > and call 'format'. > (report-unbound-variable-error, check-module-matches-file) > (display-collision-resolution-hint, run-guix-command): Remove explicit > 'format' call; pass 'format' arguments as extra arguments to 'display-hin= t'. > * gnu/services/monitoring.scm (zabbix-front-end-config): Likewise. > * guix/scripts.scm (warn-about-disk-space): Likewise. > * guix/scripts/build.scm (%standard-cross-build-options) > (%standard-native-build-options): Likewise. > * guix/scripts/describe.scm (display-checkout-info): Likewise. > * guix/scripts/environment.scm (suggest-command-name): Likewise. > * guix/scripts/home.scm (process-command): Likewise. > * guix/scripts/home/edit.scm (service-type-not-found): Likewise. > * guix/scripts/import.scm (guix-import): Likewise. > * guix/scripts/package.scm (display-search-path-hint): Likewise. > * guix/scripts/pull.scm (build-and-install): Likewise. > * guix/scripts/shell.scm (auto-detect-manifest): Likewise. > * guix/scripts/system.scm (check-file-system-availability): Likewise. > (guix-system): Likewise. > * guix/scripts/system/edit.scm (service-type-not-found): Likewise. > * guix/status.scm (print-build-event): Likewise. Pushed as 43c36c5c9f7a31649eb059fd16ed82bde20da3fc. Ludo=E2=80=99. ------------=_1677538562-2702-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 31 Jan 2023 17:05:58 +0000 Received: from localhost ([127.0.0.1]:54857 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMu50-0005Td-3J for submit@debbugs.gnu.org; Tue, 31 Jan 2023 12:05:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:38682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMu4v-0005TS-8A for submit@debbugs.gnu.org; Tue, 31 Jan 2023 12:05:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMu4r-0008IC-Na for bug-guix@gnu.org; Tue, 31 Jan 2023 12:05:50 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMu4p-0005QU-B1 for bug-guix@gnu.org; Tue, 31 Jan 2023 12:05:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=inria.fr; s=dc; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=qBB0pTO81SJVFyNcZSfxDzB6qrV0tj1/W13UUSHeKXA=; b=GgPrtsAeQp+tHtf9KC123tzG1hDDWUUsV+12mBqoFtd5TuA296bO+0Nr 4ETHaaZzdLnim7ZKhiM+OWgPcV8S4cM3b5b/cLWO44Nw7+gcF85C58tSV 9GnbOA0/rJ2GaD1DIrFSH6XnnBAmpOmBCGoAjCVX1ymVAxzHl1YIwWndT c=; Authentication-Results: mail3-relais-sop.national.inria.fr; dkim=none (message not signed) header.i=none; spf=SoftFail smtp.mailfrom=ludovic.courtes@inria.fr; dmarc=fail (p=none dis=none) d=inria.fr X-IronPort-AV: E=Sophos;i="5.97,261,1669071600"; d="scan'208";a="46500912" Received: from unknown (HELO ribbon) ([193.50.110.131]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 18:05:42 +0100 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: bug-guix@gnu.org Subject: Installation hint crashes when user names contain at sign X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Duodi 12 =?utf-8?Q?Pluvi=C3=B4se?= an 231 de la =?utf-8?Q?R=C3=A9volution=2C?= jour du Brocoli X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Tue, 31 Jan 2023 18:05:40 +0100 Message-ID: <87edratz17.fsf@inria.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=192.134.164.104; envelope-from=ludovic.courtes@inria.fr; helo=mail3-relais-sop.national.inria.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) A funny thing was reported earlier today on the Caf=C3=A9 Guix channel: --8<---------------cut here---------------start------------->8--- $ guix install hello [17:52] building profile with 5 packages... hint: Backtrace: 17 (primitive-load "/usr/local/bin/guix") In guix/ui.scm: 2279:7 16 (run-guix . ) 2242:10 15 (run-guix-command _ . ) In ice-9/boot-9.scm: 1752:10 14 (with-exception-handler _ _ #:unwind? _ # ) In guix/status.scm: 835:3 13 () 815:4 12 (call-with-status-report _ ) In guix/store.scm: 1300:8 11 (call-with-build-handler _ ) 1300:8 10 (call-with-build-handler # ?) In guix/build/syscalls.scm: 1440:3 9 () 1407:4 8 (call-with-file-lock/no-wait _ _ ) In guix/scripts/package.scm: 325:7 7 (build-and-use-profile _ "/var/guix/profiles/per-user/?" ?) In guix/ui.scm: 312:5 6 (display-hint _ ) 1451:24 5 (texi->plain-text ) In texinfo.scm: 1132:22 4 (parse ) 980:31 3 (loop # (fragment) _ _ ) 967:36 2 (loop # #f # ?) 92:2 1 (command-spec ) In ice-9/boot-9.scm: 1685:16 0 (raise-exception _ #:continuable? ) =20 ice-9/boot-9.scm:1685:16: In procedure raise-exception: Throw to key #E1E1E1">parser-error' with args(#f "Unknown command" univ)'. --8<---------------cut here---------------end--------------->8--- This is because the user name ends in =E2=80=9C@univ=E2=80=A6=E2=80=9D, whi= ch =E2=80=98display-hint=E2=80=99 interprets as Texinfo. Ludo=E2=80=99. ------------=_1677538562-2702-1--