From unknown Thu Jun 19 14:08:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61184 <61184@debbugs.gnu.org> To: bug#61184 <61184@debbugs.gnu.org> Subject: Status: 29.0.60; keymap-local-set and keymap-global-set became less strict Reply-To: bug#61184 <61184@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:08:26 +0000 retitle 61184 29.0.60; keymap-local-set and keymap-global-set became less s= trict reassign 61184 emacs submitter 61184 Daniel Mendler severity 61184 normal tag 61184 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 15:53:22 2023 Received: (at submit) by debbugs.gnu.org; 30 Jan 2023 20:53:22 +0000 Received: from localhost ([127.0.0.1]:50697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMb9W-0006Vd-GX for submit@debbugs.gnu.org; Mon, 30 Jan 2023 15:53:22 -0500 Received: from lists.gnu.org ([209.51.188.17]:37918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMb9U-0006VW-RE for submit@debbugs.gnu.org; Mon, 30 Jan 2023 15:53:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMb9U-0004uI-I3 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 15:53:20 -0500 Received: from server.qxqx.de ([2a01:4f8:121:346::180] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMb9R-00045A-D3 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 15:53:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:Subject:From:Cc:To :MIME-Version:Date:Message-ID:Sender:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=4R0shCKuGRAq7t3ljREqH9TY5zX6CUjDdkpHz01BM/c=; b=qZhzFo5VuMkCAh4EboeYM+7FhH g6fb49GvZeyywqU3mL4CiLAH/HZ6xJvnOjnCOdWkdazHnto5xycTcEdLVQJ4XEuINRqMEqHKHIXA6 2EcO8SLK6KMxwp41BeJYQrzRRb9pRHaiNxRI1qLcxVF3k1HOF9eEuJc/z2G3ssuO5w6k=; Message-ID: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> Date: Mon, 30 Jan 2023 21:52:54 +0100 MIME-Version: 1.0 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Daniel Mendler Subject: 29.0.60; keymap-local-set and keymap-global-set became less strict Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Lars Ingebrigtsen , Robert Pluim , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) In patch f67a9a12b7b0cdd6030cb080a6d6838255789a08, the commands keymap-local-set and keymap-global-set became less strict for non-interactive use, which is not the intended the design. The goal is that the API only accepts strings in a single format. The vector to string conversion should happen within the interactive form. There was an old commit by Stefan Monnier, where he relaxed the API, but Lars made it clear back then that it is better to only accept a single format for the keymap API, such that guidance for the user is better due to clear error messages. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 16:01:05 2023 Received: (at submit) by debbugs.gnu.org; 30 Jan 2023 21:01:05 +0000 Received: from localhost ([127.0.0.1]:50705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMbGz-0006kv-Dm for submit@debbugs.gnu.org; Mon, 30 Jan 2023 16:01:05 -0500 Received: from lists.gnu.org ([209.51.188.17]:51590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMbGw-0006kn-VG for submit@debbugs.gnu.org; Mon, 30 Jan 2023 16:01:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMbGu-0001zP-Nt for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:01:02 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMbGr-0005f5-UZ for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:01:00 -0500 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9A6724417B7; Mon, 30 Jan 2023 16:00:55 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 2248C4417B5; Mon, 30 Jan 2023 16:00:54 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1675112454; bh=/VRAgblkbTlNe4Jx0q+nv9/hUh4EkHzfo74N8j+GEPU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bRlvNDT2bw6y/Gh00gULtVKzTNKHmbqI8zSx1uRDVD5ToY0evefhzQeot2AxtPoGS ZUkoIOXLKth4W2C/H9fY9mC3SQXp3lZbwNhNAyrxX9EJpW5TiyPrlg7s+h7JD7E/iu LcSN5359jv7p/Pb/VlZP8A9FY9364jRccqbt2zvQUmFru92vS7cr6k5XiCzSF20xTJ uPTrg1tH6Z6JaaytJtdXOkhoTPoXUHNPmgR4TUAXVuY/hKlp6zkdj5dyS1ffTzymk7 wTC7xgB7BqzKkcYsSJq6xKPH1ADFKmIgB0/fykRxChpWwTkShkdomm60rrsJbrzr02 RaIRXVMfK2Wqw== Received: from pastel (unknown [45.72.238.67]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DF85C121319; Mon, 30 Jan 2023 16:00:53 -0500 (EST) From: Stefan Monnier To: Daniel Mendler Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict In-Reply-To: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> (Daniel Mendler's message of "Mon, 30 Jan 2023 21:52:54 +0100") Message-ID: References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> Date: Mon, 30 Jan 2023 16:00:51 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.109 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Lars Ingebrigtsen , bug-gnu-emacs@gnu.org, Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > In patch f67a9a12b7b0cdd6030cb080a6d6838255789a08, the commands > keymap-local-set and keymap-global-set became less strict for > non-interactive use, which is not the intended the design. The goal is > that the API only accepts strings in a single format. The vector to > string conversion should happen within the interactive form. I don't see any use for the vector->string conversion to happen in the interactive spec: I think the most important use cases for accepting vectors is when these come directly from Lisp, in which case having to convert them back to the KBD syntax (only to hope `key-parse` will correctly undo the damage) is just a waste and a hurdle. > There was an old commit by Stefan Monnier, where he relaxed the API, but > Lars made it clear back then that it is better to only accept a single > format for the keymap API, such that guidance for the user is better due > to clear error messages. Obviously, I disagree: the vector format is not going anywhere, so it makes a lot sense to accept it, even though I fully agree that guidance should never suggest the use of the vector format. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 16:06:09 2023 Received: (at submit) by debbugs.gnu.org; 30 Jan 2023 21:06:09 +0000 Received: from localhost ([127.0.0.1]:50719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMbLs-0006td-W9 for submit@debbugs.gnu.org; Mon, 30 Jan 2023 16:06:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:35700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMbLr-0006tV-57 for submit@debbugs.gnu.org; Mon, 30 Jan 2023 16:06:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMbLq-00077L-PS for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:06:06 -0500 Received: from server.qxqx.de ([2a01:4f8:121:346::180] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMbLp-0006Vu-7I for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:06:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=9xstT1JHUWzjxzVewiLLSG/eReW4H3urXRNi5XaSzq4=; b=DGyJiuVrCrOwmEyI2avRsupU6R TZSb4LFsRpi0S/Pu2ElITVAUQtRh7EhHpjF7jhu5rWL9B9JASbiIXpc8LGfsuLbxHm51eva66y98n /ltBm5s+JmJh3hvsnHdHRu8syRhBGA+UfFuUTWanU+2u7n6f4qKgYozuIytQjdJPACJ8=; Message-ID: <2b0f16c2-2890-b1a6-8d10-3569caefbc1d@daniel-mendler.de> Date: Mon, 30 Jan 2023 22:06:01 +0100 MIME-Version: 1.0 Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict Content-Language: en-US To: Stefan Monnier References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> From: Daniel Mendler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Lars Ingebrigtsen , bug-gnu-emacs@gnu.org, Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On 1/30/23 22:00, Stefan Monnier wrote: > I don't see any use for the vector->string conversion to happen in the > interactive spec: I think the most important use cases for accepting > vectors is when these come directly from Lisp, in which case having to > convert them back to the KBD syntax (only to hope `key-parse` will > correctly undo the damage) is just a waste and a hurdle. > Obviously, I disagree: the vector format is not going anywhere, so it > makes a lot sense to accept it, even though I fully agree that guidance > should never suggest the use of the vector format. Stefan, I know that you disagree, see the other thread. I am not the one to debate this with. Please discuss this with Lars, who introduced the API and intended it to be as strict as it was. Now the API gets relaxed through the backdoor because of the broken interactive use. This is why I am objecting. All I want is that the keymap.el API overall is consistent - currently it is not. The keymap-local/global-set made parts of the API accept vectors, key-parse accepts invalid strings and the rest seems to only accept strictly conforming key strings. I think what Lars had in mind with a strict string-only API for keymap.el, since this creates a consistent picture for keymap definitions. I agree that internally the vectors are not going away and that is okay, but this does not prohibit creating the more strict superficial string only API. Daniel From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 16:46:05 2023 Received: (at submit) by debbugs.gnu.org; 30 Jan 2023 21:46:05 +0000 Received: from localhost ([127.0.0.1]:50764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMbyW-0007xb-QF for submit@debbugs.gnu.org; Mon, 30 Jan 2023 16:46:05 -0500 Received: from lists.gnu.org ([209.51.188.17]:50824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMbyV-0007xM-Dr for submit@debbugs.gnu.org; Mon, 30 Jan 2023 16:46:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMbyU-0000Bq-JB for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:46:02 -0500 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMbyS-0004pW-Mr for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 16:46:02 -0500 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2B3E61000C4; Mon, 30 Jan 2023 16:45:59 -0500 (EST) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B681010002A; Mon, 30 Jan 2023 16:45:57 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1675115157; bh=3sGV830oMZ4kclnYrb38h6Te5aRYWHSFw0DoIZsLC/Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=koO1G1JO15d1EGVZjo3VGC1BabMhup8ACXDprUXc5FHWgvPHlmKd7D8o7Uawmzt1F ImDqAArWEYy01swije+rKGEMKzL/+yoHdT8AZd7gjtWfK750U6a/5E7AnDOmr/xsqX CrpzrI/On/6WUvs4qlUn/NTDJ2zULkF64EMCWHuNaFkkzzgaK1XxEmV9Ptw8jem7jx klWR2VXFYLdp5bc/MqQt4usoSLFq6j5sPNFWVhi4Atd53ca7g7641+mm0yPnHdE51s WSatgUZmaIpv9hHRwbAMfPfqvesBtg0ipQyNewINHujxTmCLXsopSp/EKrO3sbaPcq GdZH8k1L+walA== Received: from pastel (unknown [45.72.238.67]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 7E1A612096C; Mon, 30 Jan 2023 16:45:57 -0500 (EST) From: Stefan Monnier To: Daniel Mendler Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict In-Reply-To: <2b0f16c2-2890-b1a6-8d10-3569caefbc1d@daniel-mendler.de> (Daniel Mendler's message of "Mon, 30 Jan 2023 22:06:01 +0100") Message-ID: References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <2b0f16c2-2890-b1a6-8d10-3569caefbc1d@daniel-mendler.de> Date: Mon, 30 Jan 2023 16:45:56 -0500 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.327 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Lars Ingebrigtsen , bug-gnu-emacs@gnu.org, Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > I think what Lars had in mind with a strict string-only API for > keymap.el, since this creates a consistent picture for keymap > definitions. I agree that internally the vectors are not going away and > that is okay, but this does not prohibit creating the more strict > superficial string only API. It's still a PITA when you have a vector and you need to pass it to a function which happens to be usually receiving its data from end-users and hence passes its inputs through `key-parse`. Accepting vectors in `key-parse` doesn't prevent the construction of a consistent picture where end users only need to know about KBD-style strings. Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 17:03:16 2023 Received: (at submit) by debbugs.gnu.org; 30 Jan 2023 22:03:16 +0000 Received: from localhost ([127.0.0.1]:50799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMcFA-0008Vg-9C for submit@debbugs.gnu.org; Mon, 30 Jan 2023 17:03:16 -0500 Received: from lists.gnu.org ([209.51.188.17]:33146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMcF8-0008VY-Hm for submit@debbugs.gnu.org; Mon, 30 Jan 2023 17:03:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMcF6-0006dR-11 for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 17:03:14 -0500 Received: from server.qxqx.de ([2a01:4f8:121:346::180] helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMcF3-0008U0-KP for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 17:03:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=WOE5EE4g2UmPVXYfK+AdBbC0crbRdPRTVTWv4EJBBas=; b=otuCXsQGz1B2tq6PU597eSFdFC QHe8XbFbUJrHJ8WrCh43hve9lvmu41x+cVPewTDxywmkCgTLNBe3RzTyF+08JZLZZ51vULmuGHqJf 14bmfnxLmVbJIUnZpX++4jLJw1PJQTWlxjepel3YnUAEPPYWo3L5HTvia6pVQGgBRkl8=; Message-ID: <9fd41d2c-4d75-271b-d3a8-8ca8d5e6229a@daniel-mendler.de> Date: Mon, 30 Jan 2023 23:03:03 +0100 MIME-Version: 1.0 Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict To: Stefan Monnier References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <2b0f16c2-2890-b1a6-8d10-3569caefbc1d@daniel-mendler.de> Content-Language: en-US From: Daniel Mendler In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Lars Ingebrigtsen , bug-gnu-emacs@gnu.org, Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On 1/30/23 22:45, Stefan Monnier wrote: >> I think what Lars had in mind with a strict string-only API for >> keymap.el, since this creates a consistent picture for keymap >> definitions. I agree that internally the vectors are not going away and >> that is okay, but this does not prohibit creating the more strict >> superficial string only API. > > It's still a PITA when you have a vector and you need to pass it to > a function which happens to be usually receiving its data from end-users > and hence passes its inputs through `key-parse`. I tend to agree. Also I recently had to write a few times (keymap-set map " " #'long) where I would have preferred to write (keymap-set map [remap not] #'long). The same with `defvar-keymap' which also needs this long remap syntax. > Accepting vectors in `key-parse` doesn't prevent the construction of > a consistent picture where end users only need to know about > KBD-style strings. Yes, but I am no fan of "hiding the truth" in the documentation. It would not be bad to accept both the strict string syntax and vectors, and also document that. It would still be consistent, maybe even more so when considering the whole Emacs where many internal keymap and event functions operate on vectors. I hope it is not too late to fix the API for Emacs 29 such that it becomes consistent. When the API is officially released it is harder to change it. All functions should only accept the strict string syntax as defined by key-valid-p, including the key-parse function. As Stefan argues, the functions could also accept vectors, but then please - all of them. I would not mind that and may prefer it in some cases like the remapping or when you already have another vector anyway. On the other ahnd I also see the merits of the more restricted string only API, which would be simpler to explain and one would not have to hide the truth in the doc string. For internal uses with vectors there are still define-key and the other APIs. Daniel From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 22:42:44 2023 Received: (at submit) by debbugs.gnu.org; 31 Jan 2023 03:42:44 +0000 Received: from localhost ([127.0.0.1]:51089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMhXf-0000Tv-TS for submit@debbugs.gnu.org; Mon, 30 Jan 2023 22:42:44 -0500 Received: from lists.gnu.org ([209.51.188.17]:37850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMhXe-0000Tn-64 for submit@debbugs.gnu.org; Mon, 30 Jan 2023 22:42:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMhXd-0007rR-PG for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 22:42:41 -0500 Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMhXc-0004Wo-8r for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 22:42:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ph16VOGs2hNAl9p+MheyPTgTcPrMQsKSVOiBqCMXfWw=; b=levHoqD76TzlH/ZqwNHWpHAX4j yBqzCquapwhnLHSfpxyGHl1LpBvWwgWcCqmLQq1OHVEp0ICbvtw/xql8v3iWnaXe7fxJmlX5WcN3Q YhD9Jj6VwWywOxRahJPYoL78oILjNtX/q+a/iYJBIuxOOuQCd+s3VyZuSPhCjwFgGap0=; Received: from [84.212.220.105] (helo=downe) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pMhXR-0007P1-Fk; Tue, 31 Jan 2023 04:42:32 +0100 From: Lars Ingebrigtsen To: Daniel Mendler Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict In-Reply-To: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> (Daniel Mendler's message of "Mon, 30 Jan 2023 21:52:54 +0100") References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEX9+Mfa5tbWzqSa kHKHg3xHQDL////06BW9AAAAAWJLR0QGYWa4fQAAAAd0SU1FB+cBHwMkOsctaa4AAAG1SURBVDjL 7VJBrt0wCHRxcoDewAJ7bwHeP9nx/sl+3P8qJWkX/dK/QKUiJUoYwwyDQ/D48fNrhC/x45vc//hH AhAQv0nXkByAv1LpfiHJU3AkWOFG/ek3QDI4imAZuJ6OR0hdvYbmpdXPlQVvVCY6QNZ0QF7RzFIg jiOOXj7nsEp+Uut04A0s/nP1sqNdgF6hd94MRYhR2FlkQHs5R3uAhZhH8JO4XXp2VrLfAGD+APS2 rBM+chC3UOZ8bJyjZec7MXsr1v55YUHp0npe0nSUPxWw9we1GcsWLja3PpZEzF2UylKjUXqctmVH h4rQsVCFx0WctcdF4ZmjSQKl4Y7hbixTKgCyc5SFyY2aVfdoOnEEOhc6cLxjqlARhMmHq7wI0l0R IiXPG8YD1Vc03dC7FRiFNF1qUwbmlZttZCcHwdit9VTmO6NscHfSoHSvNvZdun7aEg01Xht8CgfS WZMZz4ro8kZOEon4FWCfIueujocL2QICUPNWYEk1APD5YsBmUMHvRXG5AjKqBKHqDhXDFS0vctt9 2b0KpJg2VF/x2yXZPbmLvjs+Tie94OVf0ffxzZ194hfmvmfNC5bJaAAAACV0RVh0ZGF0ZTpjcmVh dGUAMjAyMy0wMS0zMVQwMzozNjo1OCswMDowME3Nu3QAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjMt MDEtMzFUMDM6MzY6NTgrMDA6MDA8kAPIAAAAAElFTkSuQmCC X-Now-Playing: =?utf-8?Q?M=C3=A4rz's?= _Love Streams_: "The Rain Rains" Date: Tue, 31 Jan 2023 04:42:25 +0100 Message-ID: <875ycngyji.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Daniel Mendler writes: > There was an old commit by Stefan Monnier, where he relaxed the API, but > Lars made it clear back then that it is better to only accept a single > format for the keymap API, such that guidance for [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: bug-gnu-emacs@gnu.org, Robert Pluim , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Daniel Mendler writes: > There was an old commit by Stefan Monnier, where he relaxed the API, but > Lars made it clear back then that it is better to only accept a single > format for the keymap API, such that guidance for the user is better due > to clear error messages. Yes, that was kinda the point of the whole keymap-* thing. If there's one clear syntax, it makes many "but will this work, then?" problems users have go away -- there's a lot of trial and error involved currently. In addition, having one single syntax allows people to grep for bindings etc -- when exploring the source code, they can isearch for `C-c C-k' (or whatever) exactly and reliably find the command they're looking for that way (eventually). So keymap-local-set and keymap-global-set should be fixed to be strict again, otherwise there's not much point to the entire `keymap-*' exercise. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 05:23:46 2023 Received: (at 61184) by debbugs.gnu.org; 31 Jan 2023 10:23:46 +0000 Received: from localhost ([127.0.0.1]:51674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMnnl-0003ET-UR for submit@debbugs.gnu.org; Tue, 31 Jan 2023 05:23:46 -0500 Received: from mail-wr1-f41.google.com ([209.85.221.41]:37405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMnnk-0003EF-3h for 61184@debbugs.gnu.org; Tue, 31 Jan 2023 05:23:44 -0500 Received: by mail-wr1-f41.google.com with SMTP id q10so13729015wrm.4 for <61184@debbugs.gnu.org>; Tue, 31 Jan 2023 02:23:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=RLUqdUgKLThIlmMqWrefc7KgUA0zwDzHYjJxMmtszVc=; b=m4Bjv6THxQGYpK1/lVVoGs5fASHSZ6AQCdlfk5FNxpECyI+V/dEbriQWZ5lLV0lBnX BlOOWwdAmX3vLFKqmCTdIpM9efCQdm+NNfyixh7ilo6Wxuo5rnmlX3h/xQba4y+/2yKU sRZ1sG7EUR5MqDbsK+mTx7Z3P/0JZPZcGxgLA+Ta6cU9YKW0N68CNqM1kMNMGL1EuaNq Gj2yjTMHqQs9MTxPnSAEf/4XIo/H9DRTGSlltrd4W8f+otdBwjmcYz+fa0FbuukCFdYf ArgKb6D69qx5+yA/OwI0pBRUnPX4k/LQIyLB5cZ1wVbmqNSfqAFvAAE2AwyxT+5dBShW xPMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RLUqdUgKLThIlmMqWrefc7KgUA0zwDzHYjJxMmtszVc=; b=5cglVQSYqyFq59rk9kLaNTLAO3UbrTojx/HtzCtTfIJT7Y9cx4B+oT1GYrRFVyCPqC 8slNYf69A8haSQ+D3cuFhBZxdIG7tkcT+1RoKP5yY8QetS5/c4i+afhdcGMX/17cfoWq YtlFuPrEZod7ihVLUYkW7Tvhwtw4iwGUHs/a0kTn/L29o772SVcHvj+oEvd80lPJZ1iL Qzjj958nvGI9cz8HAo98cmhc/YukhLxQcsT3W16rTH35DvsVR8Fc/VZ72N01MH2aXQxB KbyQ8Bwzie4R8NUf0FEkC3gN+FYhB7GSEHI1SvFymox3hkt2WsbXE6ykRKXsUzvDO5w1 RlmQ== X-Gm-Message-State: AFqh2krH719BqHM6sfsJPiO/Ub+vTbp46XA6rRK0kCnRVg589Pv6o3xi Hs6qcIGeUQ/yn7lJkw8L2Uc= X-Google-Smtp-Source: AMrXdXuPkOgkHxVDiAgl10t4P/a0RzoNmVeBe8UZuEiu4pMZbnszyoGfHcbjvK6eR/9pL1kLzh0Ynw== X-Received: by 2002:adf:fb86:0:b0:2b6:7876:3cd4 with SMTP id a6-20020adffb86000000b002b678763cd4mr42891365wrr.16.1675160618101; Tue, 31 Jan 2023 02:23:38 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id r7-20020a5d52c7000000b002bdf5832843sm14223070wrv.66.2023.01.31.02.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 02:23:37 -0800 (PST) From: Robert Pluim To: Stephen Berman Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict In-Reply-To: <871qnbnhhy.fsf@rub.de> (Stephen Berman's message of "Tue, 31 Jan 2023 11:08:41 +0100") References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <875ycngyji.fsf@gnus.org> <87zg9zvzuc.fsf@gmail.com> <871qnbnhhy.fsf@rub.de> Date: Tue, 31 Jan 2023 11:23:36 +0100 Message-ID: <877cx3ovdj.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61184 Cc: Daniel Mendler , Lars Ingebrigtsen , 61184@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) (and redirecting back to bug#61184. EMORECOFFEE this morning) >>>>> On Tue, 31 Jan 2023 11:08:41 +0100, Stephen Berman said: >>=20 >> OK. How about this then (why are the `cursor-in-echo-area' shenaniga= ns >> necessary? I wonder if that=CA=BCs a bug, since without them we eith= er get >> the cursor not showing in the minibuffer for >> `read-key-sequence-vector', or we get an extra space displayed by >> `read-command') Stephen> TIL cursor-in-echo-area :-). This looks to me like a Stephen> good solution I looked at callint.c to figure out why `read-key-sequence' and (interactive "K") were different (why *are* they different?) Stephen> (though aesthetically I would add a space after the colon in t= he Stephen> read-key-sequence-vector prompt, even though the user input do= esn't Stephen> appear there). If you do that you get two spaces between the colon and the cursor. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 05:31:59 2023 Received: (at 61184) by debbugs.gnu.org; 31 Jan 2023 10:31:59 +0000 Received: from localhost ([127.0.0.1]:51685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMnvi-0003S5-UX for submit@debbugs.gnu.org; Tue, 31 Jan 2023 05:31:59 -0500 Received: from mout.gmx.net ([212.227.15.18]:55975) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMnvh-0003Rq-Ix for 61184@debbugs.gnu.org; Tue, 31 Jan 2023 05:31:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1675161091; bh=3rhVoU/2aInwribDo83ZEmDSsWT3L3wuBLbY4k3uDNo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Y4WR19hGo9fYFrKgwZpjCz2kD1/ld+J4B86VWCmhvsHepmGWT7M2G6lgjIr8etfA2 0WKJsMOLEtXrfVPo6LRk3krMGobD9DOYpoGN/k+M5dMRwgRvnH4o2zoIQcZY3SFMDJ TaJaRHptYkAdSFaII0sNXm+X2z0Kj9G1CWGQgOTfMhog5gKY+e7yEUTswL07fIbI4t locZoijiDDqfVxt4Mh6JOxC4uhe3CEfYy+djzXpbBJVOxl4XucXt5VDecqpj6k0v4J a2FYcAm6LKrOwhZslrssOYW07muZlpl9SNYkNUD2Lj1z0yWNNbe9Sq0FtYBlgS2pIB pRbl+p4bpyqrA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([89.246.36.69]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MNbkv-1ozMzY2Csd-00P5fE; Tue, 31 Jan 2023 11:31:31 +0100 From: Stephen Berman To: Robert Pluim Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict In-Reply-To: <877cx3ovdj.fsf@gmail.com> (Robert Pluim's message of "Tue, 31 Jan 2023 11:23:36 +0100") References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <875ycngyji.fsf@gnus.org> <87zg9zvzuc.fsf@gmail.com> <871qnbnhhy.fsf@rub.de> <877cx3ovdj.fsf@gmail.com> Date: Tue, 31 Jan 2023 11:31:29 +0100 Message-ID: <87wn53m1vi.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:P9Ow3CcvxB3fNyRAE9XhQ9pTr+0wGFBTyLX2CsDSzqLM/GmaL3B rkKEXVoDa20rFreuA8cUZ+KI2Fe0QyvUGhwq2J0QILORkIQrqh0tltG35abugSg0y224ySy Vy34foboCFOa5RobhfFO7VGLohNlkIsck/hV8N/yh+A666QRt8Og0CGYWB0jSd/SRoRZBaD n3XVVlTtS2n5xrCen5GgQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:nPQHPf9SLL8=;w/sZ3zTJzOHyah4g80sMuF1cwHd R6O9OYMyE8c7jnI8xcrxJKFWjlQE0Qiu9U1yNwyi/BSjXS+QstVqNM65Z5QcnJus4PHebDeMI wSMWeyWY4SKBB5LSVAzi6zb9ReVjFCgTwupWKk5Mxfz0Rd8HXolCbSRtGv/H6LY8SUhvnhx8h YawkXZgfh1ut2zni5YJUs0Hb5wMw1rklCKcQ0US4XZTUztvps3O5/QsPrteegiICMZ3Zor2ZX XDGN5XODmvjFVVEhzdm0EhluWdYoYddGjjdE+olNExocUF8mH2LkAgpdluAePt9EZf/g/GuE3 pcgRhZ75jICdti4LN4+5/akuQH0WDRd/b36KA0oaNbPla5mPPofygGUArMteheAlBJZ59At3O Ar/optnezViiDbEiEeVxRCgD7Fxu7IEp5BlI07oM4TV2NPfbPF5MjlTxEOAUMmYysjDwHIfoD FJXoiDr7n53RdOw8KF56wv3OXJkw1qgV4G8j9q9fLJazKC9gEf7SxqjUpWEy6f4QMwxO1hpYf bccLoYzS9r6QGJCJ7vCOKTwAq+xdUYARCaQHGqyuslK8KFLThUDnkJNfcCXLTzGmjcaLGY5DN ydLcZBU8qLKwlMP0IfoyxJsB/JiYd44tLP41/IWnVyTahMOa4g+GEc9bvMDVOFHzOt/K7ztGM kEtKBwzF2tp7AoMW5QwCr3sWnATzrzm8Ci4LvFIg9UwKPyW1Y5Rf8ZkmxCqHRRL/lLjDIMY5D /ID0tlBdJ6Uzd2Auq7PDfvR/czZRkz4r/kuuFFL1kXNDQ+Cey0IoOB3R9EltKx3bCNRR41k1X F9U0ib5rr5wLgrt29YwQoUiRmvHFHSN02dHSBIKShftXQEN5G9XN8+31V9BkpoeKtzxYTCZip yj3AAAlRDKYLksB+OGOjG2WWnhouUDhd1sWZdiLV1CoaTxxsBfK17idcpHEP8ee4GfskD39eo Z7gOUw7gHkAE+yi5KR3EBOBbY6M= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61184 Cc: Daniel Mendler , Lars Ingebrigtsen , 61184@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, 31 Jan 2023 11:23:36 +0100 Robert Pluim wrote: > (and redirecting back to bug#61184. EMORECOFFEE this morning) > >>>>>> On Tue, 31 Jan 2023 11:08:41 +0100, Stephen Berman > said: > > >>=20 > >> OK. How about this then (why are the `cursor-in-echo-area' shenani= gans > >> necessary? I wonder if that=CA=BCs a bug, since without them we ei= ther get > >> the cursor not showing in the minibuffer for > >> `read-key-sequence-vector', or we get an extra space displayed by > >> `read-command') > > Stephen> TIL cursor-in-echo-area :-). This looks to me like a > Stephen> good solution > > I looked at callint.c to figure out why `read-key-sequence' and > (interactive "K") were different Ah, ok. > (why *are* they different?) Good question. > Stephen> (though aesthetically I would add a space after the colon in= the > Stephen> read-key-sequence-vector prompt, even though the user input = doesn't > Stephen> appear there). > > If you do that you get two spaces between the colon and the cursor. Hm, I see just one space here with Emacs 29 and master (GNU/Linux)... Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 05:37:29 2023 Received: (at 61184) by debbugs.gnu.org; 31 Jan 2023 10:37:29 +0000 Received: from localhost ([127.0.0.1]:51697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMo13-0003aq-6G for submit@debbugs.gnu.org; Tue, 31 Jan 2023 05:37:29 -0500 Received: from mail-wm1-f52.google.com ([209.85.128.52]:51962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMo10-0003ac-W4 for 61184@debbugs.gnu.org; Tue, 31 Jan 2023 05:37:27 -0500 Received: by mail-wm1-f52.google.com with SMTP id o36so3958524wms.1 for <61184@debbugs.gnu.org>; Tue, 31 Jan 2023 02:37:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mlFQOf8m/+Lb+yXfx1z0mzYxG4qUMTNv3khHjyhP0Wc=; b=AsHWAYgfl6lx+IfvdN6u7FSuOKuwMdckg+bKq0N8N29diZ5AML4gDqd++x4lM96NaI xbgEJPndKGdqLFpFkpeJRAARRuNGzAvjr5a6qkuNd05MIICuFMKl8Z3nET7QD70Ljjwk OS0ZjmOMlebXh5RnQQeSxApFKvIamkFsXha/1hgAhYQ8EZGc2FoYPu4c0rHK5zmNQu20 gEPA4BmBrPR8gf+wBjiQrLlmT1amNuwJsAf/Iib31b0rLHUJWmBHAynH1DH5pDOd38ML 5d33a5KIBGbE7opxnfZmjYEXAE742YMfQxgBeqDDzuRBYDrtdE96DPS4rsu5qmGeLE/7 JZhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mlFQOf8m/+Lb+yXfx1z0mzYxG4qUMTNv3khHjyhP0Wc=; b=pHIHuO1cwRjaPKA/4xPECHEVh2qQbPxfFA2UKFYdg/i9M7AtbSLyBHwHbzE+11l09K oE61JXmvb+9NCWsG/VCg/DqdDXbSeFywiKucBm2xkljoDmNA+zlfkgI+mBvznn1mh0Fy QEsroLOs1BhY6hgEQkqFumomVeKqK++GxkxBRPV1XNz7Bcv8AvlRth3m5XRe7x7WOivS 9U4ohvDPt1v1wdqlLBcZK/awICjgMzyGqQ2AccC/7sSHSmJajZgHKM+/uq7CpuShEorn 1M028dqGq+P9sdU9S43vLyY6VqqbgfBQ49wp8bqYlzpqJApw+oE9vHXIoT6CMHdG14KC Pm3w== X-Gm-Message-State: AO0yUKXwhJv+t7DM9UXkJv5Xgz5rF3fMxDnocEsFaXFdAI859mzTEnrl 6/lmba21P0prM9K/EUDaU58= X-Google-Smtp-Source: AK7set8NDQZAcUnvOr095o6Zd0uR/Ho1urVMmVxePOotE+wK8JJeP2sgW8k/x5phL0N92tNvA+bUrA== X-Received: by 2002:a7b:c7ce:0:b0:3dc:42d2:aeee with SMTP id z14-20020a7bc7ce000000b003dc42d2aeeemr14254371wmk.25.1675161440846; Tue, 31 Jan 2023 02:37:20 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id t1-20020a05600c41c100b003dc47d458cdsm9993593wmh.15.2023.01.31.02.37.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 02:37:20 -0800 (PST) From: Robert Pluim To: Stephen Berman Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict In-Reply-To: <87wn53m1vi.fsf@rub.de> (Stephen Berman's message of "Tue, 31 Jan 2023 11:31:29 +0100") References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <875ycngyji.fsf@gnus.org> <87zg9zvzuc.fsf@gmail.com> <871qnbnhhy.fsf@rub.de> <877cx3ovdj.fsf@gmail.com> <87wn53m1vi.fsf@rub.de> Date: Tue, 31 Jan 2023 11:37:19 +0100 Message-ID: <87v8knng68.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61184 Cc: Daniel Mendler , Lars Ingebrigtsen , 61184@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Tue, 31 Jan 2023 11:31:29 +0100, Stephen Berman said: Stephen> On Tue, 31 Jan 2023 11:23:36 +0100 Robert Pluim wrote: >> (and redirecting back to bug#61184. EMORECOFFEE this morning) >>=20 >>>>>>> On Tue, 31 Jan 2023 11:08:41 +0100, Stephen Berman >> said: >>=20 >> >>=20 >> >> OK. How about this then (why are the `cursor-in-echo-area' shenan= igans >> >> necessary? I wonder if that=CA=BCs a bug, since without them we e= ither get >> >> the cursor not showing in the minibuffer for >> >> `read-key-sequence-vector', or we get an extra space displayed by >> >> `read-command') >>=20 Stephen> TIL cursor-in-echo-area :-). This looks to me like a Stephen> good solution >>=20 >> I looked at callint.c to figure out why `read-key-sequence' and >> (interactive "K") were different Stephen> Ah, ok. >> (why *are* they different?) Stephen> Good question. Stephen> (though aesthetically I would add a space after the colon in t= he Stephen> read-key-sequence-vector prompt, even though the user input do= esn't Stephen> appear there). >>=20 >> If you do that you get two spaces between the colon and the cursor. Stephen> Hm, I see just one space here with Emacs 29 and master (GNU/Li= nux)... including in a tty frame? I see one space in gui, two in tty. Redisplay expert to the white courtesy phone please. Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 05:44:38 2023 Received: (at 61184) by debbugs.gnu.org; 31 Jan 2023 10:44:38 +0000 Received: from localhost ([127.0.0.1]:51703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMo7y-0003lX-2C for submit@debbugs.gnu.org; Tue, 31 Jan 2023 05:44:38 -0500 Received: from mout.gmx.net ([212.227.17.21]:54467) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMo7w-0003lK-Mh for 61184@debbugs.gnu.org; Tue, 31 Jan 2023 05:44:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1675161850; bh=wmDs2X/xvjULyD10Hrc4NLT6aVnsID9jMmupcvhg1ss=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=QDP9vJw5hqUt0/+qdL0xyns73IQRgD74zBQC/L2b8BMZB+aOdu+mp9gYZt3jF76Mn aPj0v4/M+IAf8aDveqmpHWYx0b4UgQEIQ8UGk7cMpyJi0NM5+crDn4ZD5fgWFSXTVA ofeZ1f/w4NXRLvUqAztnyIzktHizPnPiInHi/WQhAPEWghso1Rkdh4L7lPNYH3RdOw JTVOrnPDA8vIvenDohsyTUoJ0gVL110ZPyVQr/rU24zMQ5QVd0iSe2NGB8kMXIGmuh 3QKSPoZuuEfV6+mJLGaNNR3rpK1sJ5s4U7NouWQBpQeh4IF1StrVnvzmZbox1n2JIO Ddp2wNg8KgYvQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([89.246.36.69]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MWRVb-1p87lp2nql-00Xq9D; Tue, 31 Jan 2023 11:44:10 +0100 From: Stephen Berman To: Robert Pluim Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict In-Reply-To: <87v8knng68.fsf@gmail.com> (Robert Pluim's message of "Tue, 31 Jan 2023 11:37:19 +0100") References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <875ycngyji.fsf@gnus.org> <87zg9zvzuc.fsf@gmail.com> <871qnbnhhy.fsf@rub.de> <877cx3ovdj.fsf@gmail.com> <87wn53m1vi.fsf@rub.de> <87v8knng68.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Tue, 31 Jan 2023 11:44:06 +0100 Message-ID: <87r0vbm1ah.fsf@rub.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:PNstfAK8szCEIjNNzCGURHfjwc8iAgIRtyyhDi7AsJIHKZurf66 961pWg2zcHBlZlUj2WRXOB4pJHo8heaCp5aKcwYX+ohzl8i1F+9WoZFO+5OQeyeY3qJ7jj0 MFIGSpdZMxNqW389ZTNy1y+xW1biLlEeqpWRmXsciEg4z5yNXs2VuDEB2OyGDrABvvBSfsp p7Y+f7T0GzPVdUqgLf3Vg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:XY2PWYJ1u98=;aqK9gmOz+AIyYjZvrPab4ccD7h7 3Hl2grZ7oEPv08kooYg7uJjBcNpJfIod3vw8t3GsA1JEnU2LzRtZEJG5jALFgBZOp+thHndEn 1OW83gj9nDSrP7+Qs/3IVxAIcavExOkjwE4UlUyB+psRhPaAD8J1YB+clP2LPr66v8bwA+l2m 0hCeFxx5L/H5P2o2YC7zOPqb/Ro10ET9pdK4CcQBMkaJdwxica5PiVw1QVvet5KBQvBv2mqIw G/jBo1j3WY9MQllt6oakR9nbiG3nt+/U92YQ9/l4BboSn0bGXMPpWZWtwxxR/cJZ+WOKKp5jN UdHiYqtsldZ/UShUfkiD38IsTJls7Ma09TGlAUsmYPLeGFTqlQhH2sxwGbgwjWSIacM7uBw0U 4CDajSi1rqvqKTEl6JJK+MOSUOaGicKz+JsAFz4x11E44VsNvsSSAOQTp4iVIvfZ7RnRVb6HR 6PVoy3zVyRN6b6hWHl+o7elJyrE2S/L6wllpZNEDnyOdFAvy23xgs6K47ZbxlKmjFHjtlKsLw inI25ww8kptbUymytFa1OdOcbeH7AWZjDN8U8abE/ClMgpw6C7JX9aIv5eWkNY6hevsYhnmmx A+msqPiWj1S7WULxA54Ga369o5RU+qEWnmrtdF0aH1mfI2m6h1RN03sHByqRkaSM2RddlhkWr igHmT/8xQZRY+4jyCseHhOq6ytWuM/O/Kl7hRX1Fpu4s1blW5Mqn+EkV55cyMf2Skvu6eQtt3 BLY+r0Hi7H7+M/P68uPjHp/Uk1Uu+C6jVgDaRwdOvMuy7EhZjHAnPuSok8yunN5EsyDDnB0gI 9QRnAjsYItxx2OtWd+0rmiX3SDLGHRXf2Ikgz8QxwxqmMSUUfMLi+FqxFlRFzwjM22SETdICn JXIOCejid099ZSpyAyI9cfJ4QKKUJN4JtCYO4ufHNnqvr2HF/Q+vWSWhi1xdK+SRvFC/oicVJ h+xSMA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61184 Cc: Daniel Mendler , Lars Ingebrigtsen , 61184@debbugs.gnu.org, Eli Zaretskii , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Tue, 31 Jan 2023 11:37:19 +0100 Robert Pluim wrote: >>>>>> On Tue, 31 Jan 2023 11:31:29 +0100, Stephen Berman > said: > > Stephen> On Tue, 31 Jan 2023 11:23:36 +0100 Robert Pluim > Stephen> wrote: > >> (and redirecting back to bug#61184. EMORECOFFEE this morning) > >>=20 > >>>>>>> On Tue, 31 Jan 2023 11:08:41 +0100, Stephen Berman > >> said: > >>=20 > >> >>=20 > >> >> OK. How about this then (why are the `cursor-in-echo-area' shen= anigans > >> >> necessary? I wonder if that=CA=BCs a bug, since without them we= either get > >> >> the cursor not showing in the minibuffer for > >> >> `read-key-sequence-vector', or we get an extra space displayed = by > >> >> `read-command') > >>=20 > Stephen> TIL cursor-in-echo-area :-). This looks to me like a > Stephen> good solution > >>=20 > >> I looked at callint.c to figure out why `read-key-sequence' and > >> (interactive "K") were different > > Stephen> Ah, ok. > > >> (why *are* they different?) > > Stephen> Good question. > > Stephen> (though aesthetically I would add a space after the colon in= the > Stephen> read-key-sequence-vector prompt, even though the user input = doesn't > Stephen> appear there). > >>=20 > >> If you do that you get two spaces between the colon and the cursor. > > Stephen> Hm, I see just one space here with Emacs 29 and master (GNU/= Linux)... > > including in a tty frame? I see one space in gui, two in > tty. Redisplay expert to the white courtesy phone please. Ah, yes. I'd only tested with -Q, not with -Q -nw. I also see two in the latter. Yet more questions... Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 07:10:41 2023 Received: (at 61184) by debbugs.gnu.org; 31 Jan 2023 12:10:41 +0000 Received: from localhost ([127.0.0.1]:51785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMpTF-0000OT-9G for submit@debbugs.gnu.org; Tue, 31 Jan 2023 07:10:41 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMpTD-0000OG-Gn for 61184@debbugs.gnu.org; Tue, 31 Jan 2023 07:10:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMpT6-0007ss-K7; Tue, 31 Jan 2023 07:10:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=tciobpBPC9JdiixMZP6bQUxjjWbSqAbJi6hZrmNv7Bg=; b=G3JlGe7Y4Hjm 0hmP+pNCpYJkcGIP/u3EQ9oG9cphLaSNCqEQG52R3vPIu4wQ/wqeLH4rP/+Lc0QQjjJn6AJwPUTsC rsrSM3cgOQ25uPvkZ56dIOLJJSZ1wiKbnul6NCtaR6v3XZrxmZPcWAoBw9emQR8d/WtgZk9+5q6gr 9Qb+OKmE8DvsOrSui/Mm7g8jUDuESVGKn9tiDPrdEjtMNqfhAxP7030QjriEMIhdl8fHK7dfwWv4S HkDVgZiI6LFkmkQtrybWMv/wUm9HWaFHEOm1tSK3ayJYha+ziJW2+gzBwXwRHzEfK0R+EjWvak5Li MGV6L/1tj70yWmawJSSxVw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMpT5-0007B6-SM; Tue, 31 Jan 2023 07:10:32 -0500 Date: Tue, 31 Jan 2023 14:10:28 +0200 Message-Id: <83o7qe3nwr.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> (message from Daniel Mendler on Mon, 30 Jan 2023 21:52:54 +0100) Subject: Re: bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61184 Cc: larsi@gnus.org, 61184@debbugs.gnu.org, rpluim@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Lars Ingebrigtsen , Robert Pluim , > Stefan Monnier > Date: Mon, 30 Jan 2023 21:52:54 +0100 > From: Daniel Mendler > > In patch f67a9a12b7b0cdd6030cb080a6d6838255789a08, the commands > keymap-local-set and keymap-global-set became less strict for > non-interactive use, which is not the intended the design. Please tell more about that, because I don't yet see how that commit made the non-interactive (and only non-interactive) invocations check the argument less strictly. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 08:47:40 2023 Received: (at 61184) by debbugs.gnu.org; 31 Jan 2023 13:47:40 +0000 Received: from localhost ([127.0.0.1]:51867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMqz6-0007as-32 for submit@debbugs.gnu.org; Tue, 31 Jan 2023 08:47:40 -0500 Received: from server.qxqx.de ([178.63.65.180]:43631 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMqz2-0007aZ-Fx for 61184@debbugs.gnu.org; Tue, 31 Jan 2023 08:47:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=E7IO4uXFmwce5IiSw9igEi2OYrlXIdoMEIj2X8Tc66k=; b=vShckToR7aL6pYZRu5FG7gcZxq Xh+WYil8+iUz3SUUPFhJtk9SQBXqQqQxdKOIO5udBwao6A7DwbPjmFxPNRn9xjaF/0xlAVjRMDdJp gxdjck8fPtM/CLA+Pq4b++iDy+9A+oiIa+C1oE0mwIJ4/4eyHSoC2J7mChBqcpjIEVnA=; Message-ID: <01e408b9-96fd-d747-3e2f-dc301c2ae4b5@daniel-mendler.de> Date: Tue, 31 Jan 2023 13:49:11 +0100 MIME-Version: 1.0 Subject: Re: bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict To: Eli Zaretskii References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <83o7qe3nwr.fsf@gnu.org> Content-Language: en-US From: Daniel Mendler In-Reply-To: <83o7qe3nwr.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61184 Cc: larsi@gnus.org, 61184@debbugs.gnu.org, rpluim@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 1/31/23 13:10, Eli Zaretskii wrote: >> Cc: Lars Ingebrigtsen , Robert Pluim , >> Stefan Monnier >> Date: Mon, 30 Jan 2023 21:52:54 +0100 >> From: Daniel Mendler >> >> In patch f67a9a12b7b0cdd6030cb080a6d6838255789a08, the commands >> keymap-local-set and keymap-global-set became less strict for >> non-interactive use, which is not the intended the design. > > Please tell more about that, because I don't yet see how that commit > made the non-interactive (and only non-interactive) invocations check > the argument less strictly. The function became less strict since it also accepts vector arguments now. The intended design by Lars was to only accept strings, and only strings which are valid according to `key-valid-p'. Daniel From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 09:16:44 2023 Received: (at 61184) by debbugs.gnu.org; 31 Jan 2023 14:16:44 +0000 Received: from localhost ([127.0.0.1]:51905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMrRD-0008N0-Ty for submit@debbugs.gnu.org; Tue, 31 Jan 2023 09:16:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMrRC-0008Mm-MS for 61184@debbugs.gnu.org; Tue, 31 Jan 2023 09:16:42 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMrR6-0006cS-KI; Tue, 31 Jan 2023 09:16:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=G90XIBiEi4/Sk8H0dlScAPEug5nYDphvCcGcEnDsW0w=; b=EormQa0vRt4z uJeQSW2dSoAyy9p6EXcDcVJeLbb++9aaKm4aRlnTSYHsX4sA/pzDfr9LWWpI7llaQBJkgRtrHlmMl CPoa6QnKhLxubNb3D0scPzMEpVMf9GhJQdV4yezxCy7fh765h+Te+6xQ6a8Zjn+WqQ41eztAYHgjo JMGTbkR7BIcHOs6AD+hXILjgT+wkNPbWpxDz7njSpDPc+7PQBrY6oVZO3H/F6CW24iFK/H6Z3XBF8 YcSIcyBICDHJ0PrgMRUfzM+x4e0yDMB4hbx8FlmT+MGBogVUfnzM67Mb2hOfjmVREytyN1/1D3/ZZ mQ3DBgkyiv3ul8twtAqJJg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMrR5-00023U-V1; Tue, 31 Jan 2023 09:16:36 -0500 Date: Tue, 31 Jan 2023 16:16:32 +0200 Message-Id: <834js63i2n.fsf@gnu.org> From: Eli Zaretskii To: Daniel Mendler In-Reply-To: <01e408b9-96fd-d747-3e2f-dc301c2ae4b5@daniel-mendler.de> (message from Daniel Mendler on Tue, 31 Jan 2023 13:49:11 +0100) Subject: Re: bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <83o7qe3nwr.fsf@gnu.org> <01e408b9-96fd-d747-3e2f-dc301c2ae4b5@daniel-mendler.de> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61184 Cc: larsi@gnus.org, 61184@debbugs.gnu.org, rpluim@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 31 Jan 2023 13:49:11 +0100 > Cc: 61184@debbugs.gnu.org, larsi@gnus.org, rpluim@gmail.com, > monnier@iro.umontreal.ca > From: Daniel Mendler > > The function became less strict since it also accepts vector arguments > now. Because after the change it calls key-description? Or due to something else? If the call to key-description is the problem, we could make it only in the interactive case, I think? Would that fix the problem? From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 09:53:14 2023 Received: (at 61184) by debbugs.gnu.org; 31 Jan 2023 14:53:14 +0000 Received: from localhost ([127.0.0.1]:52027 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMs0Y-00010e-6B for submit@debbugs.gnu.org; Tue, 31 Jan 2023 09:53:14 -0500 Received: from server.qxqx.de ([178.63.65.180]:60919 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMs0V-00010N-9x for 61184@debbugs.gnu.org; Tue, 31 Jan 2023 09:53:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GqX5G7OdQ8pxob09bg/LicGNAupYrGdOHGJZ3QQ4BR4=; b=O7t2g8E7+dk1HP5n/Qcxn86rxi Q/WIlLz651ujjdJQwHFrmArUOInZxxGp1Bpw54/r5dL/r4B1/N5vejpoKoyOFnaoZzZSOuADTNYxt 4gJyeto9moksYRouqYz2XsyUQGni6pskBxY12/hyOBnzaLo+s1SQco5UTTH4LSEIANtc=; Message-ID: <43a2db50-baf4-1fe3-58aa-f375da329c01@daniel-mendler.de> Date: Tue, 31 Jan 2023 15:53:01 +0100 MIME-Version: 1.0 Subject: Re: bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict To: Eli Zaretskii References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <83o7qe3nwr.fsf@gnu.org> <01e408b9-96fd-d747-3e2f-dc301c2ae4b5@daniel-mendler.de> <834js63i2n.fsf@gnu.org> Content-Language: en-US From: Daniel Mendler In-Reply-To: <834js63i2n.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61184 Cc: larsi@gnus.org, 61184@debbugs.gnu.org, rpluim@gmail.com, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 1/31/23 15:16, Eli Zaretskii wrote: >> Date: Tue, 31 Jan 2023 13:49:11 +0100 >> Cc: 61184@debbugs.gnu.org, larsi@gnus.org, rpluim@gmail.com, >> monnier@iro.umontreal.ca >> From: Daniel Mendler >> >> The function became less strict since it also accepts vector arguments >> now. > > Because after the change it calls key-description? Or due to > something else? Yes, because of the conversion by key-description. > If the call to key-description is the problem, we could make it only > in the interactive case, I think? Would that fix the problem? Yes, that would work as I already suggested in my original mail. Daniel From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 31 11:06:26 2023 Received: (at 61184) by debbugs.gnu.org; 31 Jan 2023 16:06:26 +0000 Received: from localhost ([127.0.0.1]:54800 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMt9O-0003p2-7q for submit@debbugs.gnu.org; Tue, 31 Jan 2023 11:06:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMt9K-0003oi-Iq for 61184@debbugs.gnu.org; Tue, 31 Jan 2023 11:06:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMt9D-0002Ht-Si; Tue, 31 Jan 2023 11:06:15 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=w5PjZ50nem/cEWbKxf1PumbJ0gwTD5iOObkHtNV111s=; b=bxg98NYZnR7s 6xFb0YDol2khgrIAusTIvRhkDhwVHl2wCKKnQDCDunhYP/kvLEv4Mp+Ne+lasd/0oMK3W4Wb5u654 DrkJeOnEyWfpcyXyD4vsnJFHzp6Iy8EQomi/bRaZSTHPE8XZxUyHh2buD9AJsdktfW8QyEBAdMhDC Vb6WLZ0i8KHHqO9fGBuYY2bK6+4TBPorFF7b4KVIIKhhd2eKQKo4WLNrBXdjgzex0iKn6RmqcUZVE TG3SAWRxTY2Zgbdo1IAkhuqzOj7lT2+E6bdafAinWS5tXys0JgDFQPSkgD2ns2MpOOChS096FbwXL 2RkxgkY+CJnGqHLWL2/lJQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMt9D-0008PG-0P; Tue, 31 Jan 2023 11:06:15 -0500 Date: Tue, 31 Jan 2023 18:06:11 +0200 Message-Id: <83zg9y1yfg.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87v8knng68.fsf@gmail.com> (message from Robert Pluim on Tue, 31 Jan 2023 11:37:19 +0100) Subject: Re: 29.0.60; keymap-local-set and keymap-global-set became less strict References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <875ycngyji.fsf@gnus.org> <87zg9zvzuc.fsf@gmail.com> <871qnbnhhy.fsf@rub.de> <877cx3ovdj.fsf@gmail.com> <87wn53m1vi.fsf@rub.de> <87v8knng68.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61184 Cc: mail@daniel-mendler.de, larsi@gnus.org, stephen.berman@gmx.net, monnier@iro.umontreal.ca, 61184@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: Lars Ingebrigtsen , Daniel Mendler > , 61184@debbugs.gnu.org, Stefan Monnier > , Eli Zaretskii > Date: Tue, 31 Jan 2023 11:37:19 +0100 > > >>>>> On Tue, 31 Jan 2023 11:31:29 +0100, Stephen Berman said: > > >> (why *are* they different?) > > Stephen> Good question. > > Stephen> (though aesthetically I would add a space after the colon in the > Stephen> read-key-sequence-vector prompt, even though the user input doesn't > Stephen> appear there). > >> > >> If you do that you get two spaces between the colon and the cursor. > > Stephen> Hm, I see just one space here with Emacs 29 and master (GNU/Linux)... > > including in a tty frame? I see one space in gui, two in > tty. Redisplay expert to the white courtesy phone please. You called? That's a bug: two separate code paths that did equivalent jobs -- almost. Walking glyphs is a tricksy business... Should be fixed now. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 04:19:56 2023 Received: (at 61184) by debbugs.gnu.org; 3 Feb 2023 09:19:56 +0000 Received: from localhost ([127.0.0.1]:36515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNsEd-0002kC-Rb for submit@debbugs.gnu.org; Fri, 03 Feb 2023 04:19:56 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:45682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNsEa-0002jt-G2; Fri, 03 Feb 2023 04:19:53 -0500 Received: by mail-wm1-f53.google.com with SMTP id m16-20020a05600c3b1000b003dc4050c94aso3340046wms.4; Fri, 03 Feb 2023 01:19:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=/vDcRo/u/rfqxmcTrh4F912VLI0bJe90L+oT5zaLlX4=; b=kOyCe40DcZQmagcu8Lh2ZdP1n6Jm1uOWdFEgCThvQNX09+JL7AFzIpmc3G7OmkDwN9 D02jloCiz1Xpp10IZgorElCIqGSM7JlehSyAZgvglB55/DP/KUcpQkiwQSmpGy6u/ad6 V6zCYG01PPru6hYDzwpOf3I2ux/N4SWHf2qBlQv0wdwj2wxrXus1dUzhg/0kqFLDod+t f4bxmyjoGy71gM8BWn3xmN7F5W5y0RACwxD6MJcgXgZuEiTs9lliDrY7SsALsKDfjw4W /duMv2lAgCD9NTlmI3e/7eZVXsYIofd+8G4rkN25L0CKyFFMAnstbqx+coh2+5SqxKjA A3Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/vDcRo/u/rfqxmcTrh4F912VLI0bJe90L+oT5zaLlX4=; b=7+CVgy2KQYzca9VWcaU/lRBOWPRQJOOnvunRE5xvQ5Zoxdscs90kPSXOmRoy+BUww2 jX1sB+68lJAnLfTpibFjZlKTTtOOWq8YJHcqCI2vr9Sc2h4pUqajf3eJH55i3AfRrJKR mdVXb/KNQ7ntNVqitc0AaHb4OsE4q0ypbiWFqmpRGImiAdbnVygJEn5isql3IgftseEJ 2geekrIGQvmI4X2sUhWJ7a5mf4gkakg16kljlu8VbTDpIB2pvbMILro53hfIPpfyPKsp AyJFG929Sa5D1PFW9iGOABJSn386rV1mZg5bUrF2AXWafqJASpvVHoEtXnk3gUTHtvSx i8jA== X-Gm-Message-State: AO0yUKVC3WGgmyEV97v5+H/ipCxjpKvkKOCRxNAarN8oxNUwD8r4fitm PmhBJwx0/6WZR/+xqN5qqsRMeE9AJmE= X-Google-Smtp-Source: AK7set+2eWyU6+d+YStf4mdeeiLtU34jVvpLUKZDWC4klVJmPrRTI7ka7SR8rIwakoleu/DkS1TqqQ== X-Received: by 2002:a05:600c:354d:b0:3df:eda1:43b9 with SMTP id i13-20020a05600c354d00b003dfeda143b9mr290723wmq.4.1675415985389; Fri, 03 Feb 2023 01:19:45 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id o37-20020a05600c512500b003c6bbe910fdsm8097984wms.9.2023.02.03.01.19.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 01:19:44 -0800 (PST) From: Robert Pluim To: Daniel Mendler Subject: Re: bug#61184: 29.0.60; keymap-local-set and keymap-global-set became less strict In-Reply-To: <43a2db50-baf4-1fe3-58aa-f375da329c01@daniel-mendler.de> (Daniel Mendler's message of "Tue, 31 Jan 2023 15:53:01 +0100") References: <5876987d-2479-f512-5767-218c8c16a909@daniel-mendler.de> <83o7qe3nwr.fsf@gnu.org> <01e408b9-96fd-d747-3e2f-dc301c2ae4b5@daniel-mendler.de> <834js63i2n.fsf@gnu.org> <43a2db50-baf4-1fe3-58aa-f375da329c01@daniel-mendler.de> Date: Fri, 03 Feb 2023 10:19:44 +0100 Message-ID: <87tu03m7gv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61184 Cc: Eli Zaretskii , 61184@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 61184 fixed close 61184 29.1 quit >>>>> On Tue, 31 Jan 2023 15:53:01 +0100, Daniel Mendler said: Daniel> On 1/31/23 15:16, Eli Zaretskii wrote: >>> Date: Tue, 31 Jan 2023 13:49:11 +0100 >>> Cc: 61184@debbugs.gnu.org, larsi@gnus.org, rpluim@gmail.com, >>> monnier@iro.umontreal.ca >>> From: Daniel Mendler >>> >>> The function became less strict since it also accepts vector arguments >>> now. >> >> Because after the change it calls key-description? Or due to >> something else? Daniel> Yes, because of the conversion by key-description. >> If the call to key-description is the problem, we could make it only >> in the interactive case, I think? Would that fix the problem? Daniel> Yes, that would work as I already suggested in my original mail. Daniel> Daniel The re-fix for 61149 fixes this Robert -- From unknown Thu Jun 19 14:08:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 Mar 2023 12:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator