GNU bug report logs - #6117
24.0.50; dired-marked-face same as dired-flagged-face

Previous Next

Package: emacs;

Reported by: jidanni <at> jidanni.org

Date: Wed, 5 May 2010 22:11:01 UTC

Severity: minor

Tags: fixed

Found in version 24.0.50

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 6117 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: jidanni <at> jidanni.org
Cc: 6117 <at> debbugs.gnu.org
Subject: Re: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face
Date: Thu, 06 May 2010 09:17:35 -0400

> Please don't use the same colors for both "*" and "D" marked files,
> seen here:

> (defface dired-marked
>   '((t (:inherit font-lock-warning-face)))
>   "Face used for marked files."
>   :group 'dired-faces
>   :version "22.1")
> (defvar dired-marked-face 'dired-marked
>   "Face name used for marked files.")

> (defface dired-flagged
>   '((t (:inherit font-lock-warning-face)))
>   "Face used for flagged files."
>   :group 'dired-faces
>   :version "22.1")
> (defvar dired-flagged-face 'dired-flagged
>   "Face name used for flagged files.")

Agreed.  And while there, please fix the docstrings so they say more
clearly what's different about "flagged vs marked".


        Stefan
This bug report was last modified 13 years and 330 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.