GNU bug report logs - #6117
24.0.50; dired-marked-face same as dired-flagged-face

Previous Next

Full log

Message #56 received at 6117 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 6117 <at> debbugs.gnu.org, 'Lars Magne Ingebrigtsen' <larsi <at> gnus.org>,
	Drew Adams <drew.adams <at> oracle.com>, jidanni <at> jidanni.org
Subject: Re: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face
Date: Thu, 18 Aug 2011 14:46:25 +0300

> Looks fine to me, but test the 16-color versions of those faces in an
> xterm first, to see if those color values give the right results.

Done.

I tested the 16-color versions in an xterm, and they look fine
on light and dark backgrounds.

I'm also going to install changes in packages related to dired
that use faces for marked/flagged for deletion:

=== modified file 'lisp/ibuffer.el'
--- lisp/ibuffer.el	2011-08-15 10:21:47 +0000
+++ lisp/ibuffer.el	2011-08-18 11:20:35 +0000
@@ -356,12 +356,12 @@ (defcustom ibuffer-load-hook nil
   :type 'hook
   :group 'ibuffer)
 
-(defcustom ibuffer-marked-face 'font-lock-warning-face
+(defcustom ibuffer-marked-face 'warning
   "Face used for displaying marked buffers."
   :type 'face
   :group 'ibuffer)
 
-(defcustom ibuffer-deletion-face 'font-lock-type-face
+(defcustom ibuffer-deletion-face 'error
   "Face used for displaying buffers marked for deletion."
   :type 'face
   :group 'ibuffer)

=== modified file 'lisp/proced.el'
--- lisp/proced.el	2011-07-20 09:53:51 +0000
+++ lisp/proced.el	2011-08-18 11:29:33 +0000
@@ -395,7 +395,7 @@ (defface proced-mark
   :group 'proced-faces)
 
 (defface proced-marked
-  '((t (:inherit font-lock-warning-face)))
+  '((t (:inherit error)))
   "Face used for marked processes."
   :group 'proced-faces)
 
=== modified file 'lisp/battery.el'
--- lisp/battery.el	2011-06-27 08:04:55 +0000
+++ lisp/battery.el	2011-08-18 11:12:33 +0000
@@ -199,7 +199,7 @@ (defun battery-update ()
 		      'face
 		      (and (<= (car (read-from-string (cdr (assq ?p data))))
 				   battery-load-critical)
-			   'font-lock-warning-face)
+			   'error)
 		      'help-echo "Battery status information")))
   (force-mode-line-update))
 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.