GNU bug report logs - #6117
24.0.50; dired-marked-face same as dired-flagged-face

Previous Next

Package: emacs;

Reported by: jidanni <at> jidanni.org

Date: Wed, 5 May 2010 22:11:01 UTC

Severity: minor

Tags: fixed

Found in version 24.0.50

Done: Chong Yidong <cyd <at> stupidchicken.com>

Bug is archived. No further changes may be made.

Full log


Message #29 received at 6117 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 6117 <at> debbugs.gnu.org, Chong Yidong <cyd <at> stupidchicken.com>,
	jidanni <at> jidanni.org
Subject: Re: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face
Date: Sat, 16 Jul 2011 21:53:39 +0200
Lars Magne Ingebrigtsen <larsi <at> gnus.org> writes:

>>> Please don't use the same colors for both "*" and "D" marked files,
>>> seen here:
>>
>>> (defface dired-marked
>>>   '((t (:inherit font-lock-warning-face)))

[...]

>>> (defface dired-flagged
>>>   '((t (:inherit font-lock-warning-face)))

[...]

> I've fixed the doc string, but what colours should be used, then?

"Drew Adams" <drew.adams <at> oracle.com> writes:

>> I've fixed the doc string, but what colours should be used, then?
>
> FWIW (not much), I use these colors:
>
> '((((background dark))
>    (:foreground "Blue" :background "#7575D4D41D1D")) ; ~ olive green
>   (t (:foreground "Yellow" :background "Blueviolet"))

There's apparently a rampage going on where all faces are supposed to
inherit from the `font-lock-*' faces, so I think this would be frowned
upon.

Does anybody have a suggestion taken from the `font-lock-*' corpus?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/




This bug report was last modified 13 years and 331 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.