GNU bug report logs - #6117
24.0.50; dired-marked-face same as dired-flagged-face

Previous Next

Full log

Message #23 received at 6117 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 6117 <at> debbugs.gnu.org, jidanni <at> jidanni.org
Subject: Re: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face
Date: Wed, 13 Jul 2011 23:28:33 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> Please don't use the same colors for both "*" and "D" marked files,
>> seen here:
>
>> (defface dired-marked
>>   '((t (:inherit font-lock-warning-face)))
>>   "Face used for marked files."
>>   :group 'dired-faces
>>   :version "22.1")
>> (defvar dired-marked-face 'dired-marked
>>   "Face name used for marked files.")
>
>> (defface dired-flagged
>>   '((t (:inherit font-lock-warning-face)))
>>   "Face used for flagged files."
>>   :group 'dired-faces
>>   :version "22.1")
>> (defvar dired-flagged-face 'dired-flagged
>>   "Face name used for flagged files.")
>
> Agreed.  And while there, please fix the docstrings so they say more
> clearly what's different about "flagged vs marked".

I've fixed the doc string, but what colours should be used, then?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.