From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: jidanni@jidanni.org Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 May 2010 22:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 6117@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.12730974573718 (code B ref -1); Wed, 05 May 2010 22:11:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 May 2010 22:10:57 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9mnw-0000xv-Cu for submit@debbugs.gnu.org; Wed, 05 May 2010 18:10:56 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9mnu-0000xq-BE for submit@debbugs.gnu.org; Wed, 05 May 2010 18:10:54 -0400 Received: from lists.gnu.org ([199.232.76.165]:35012) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O9mnq-0007LE-2p for submit@debbugs.gnu.org; Wed, 05 May 2010 18:10:50 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9mnp-0002Xf-8x for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 18:10:49 -0400 Received: from [140.186.70.92] (port=58773 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9mnm-0002Vh-VG for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 18:10:47 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9mnl-0004j4-Sf for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 18:10:46 -0400 Received: from caiajhbdcahe.dreamhost.com ([208.97.132.74]:42114 helo=homiemail-a14.g.dreamhost.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9mnl-0004ip-ON for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 18:10:45 -0400 Received: from jidanni.org (218-163-2-146.dynamic.hinet.net [218.163.2.146]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by homiemail-a14.g.dreamhost.com (Postfix) with ESMTPSA id 98D2E8C078 for ; Wed, 5 May 2010 15:10:43 -0700 (PDT) From: jidanni@jidanni.org Date: Thu, 06 May 2010 04:31:15 +0800 Message-ID: <87ljbyt7jg.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.3 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.3 (-----) Please don't use the same colors for both "*" and "D" marked files, seen here: (defface dired-marked '((t (:inherit font-lock-warning-face))) "Face used for marked files." :group 'dired-faces :version "22.1") (defvar dired-marked-face 'dired-marked "Face name used for marked files.") (defface dired-flagged '((t (:inherit font-lock-warning-face))) "Face used for flagged files." :group 'dired-faces :version "22.1") (defvar dired-flagged-face 'dired-flagged "Face name used for flagged files.") From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2010 13:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: jidanni@jidanni.org Cc: 6117@debbugs.gnu.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.12731518629392 (code B ref 6117); Thu, 06 May 2010 13:18:02 +0000 Received: (at 6117) by debbugs.gnu.org; 6 May 2010 13:17:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OA0xR-0002RR-Rf for submit@debbugs.gnu.org; Thu, 06 May 2010 09:17:41 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OA0xQ-0002RM-ON for 6117@debbugs.gnu.org; Thu, 06 May 2010 09:17:40 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AocGAGde4kvO+IB1/2dsb2JhbACROYwucr00hRMEjDA X-IronPort-AV: E=Sophos;i="4.52,341,1270440000"; d="scan'208";a="63568370" Received: from 206-248-128-117.dsl.teksavvy.com (HELO alfajor.home) ([206.248.128.117]) by ironport2-out.pppoe.ca with ESMTP; 06 May 2010 09:17:35 -0400 Received: by alfajor.home (Postfix, from userid 20848) id 8299BAF455; Thu, 6 May 2010 09:17:35 -0400 (EDT) From: Stefan Monnier Message-ID: References: <87ljbyt7jg.fsf@jidanni.org> Date: Thu, 06 May 2010 09:17:35 -0400 In-Reply-To: <87ljbyt7jg.fsf@jidanni.org> (jidanni@jidanni.org's message of "Thu, 06 May 2010 04:31:15 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.1 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > Please don't use the same colors for both "*" and "D" marked files, > seen here: > (defface dired-marked > '((t (:inherit font-lock-warning-face))) > "Face used for marked files." > :group 'dired-faces > :version "22.1") > (defvar dired-marked-face 'dired-marked > "Face name used for marked files.") > (defface dired-flagged > '((t (:inherit font-lock-warning-face))) > "Face used for flagged files." > :group 'dired-faces > :version "22.1") > (defvar dired-flagged-face 'dired-flagged > "Face name used for flagged files.") Agreed. And while there, please fix the docstrings so they say more clearly what's different about "flagged vs marked". Stefan From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2010 15:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Stefan Monnier'" , Cc: 6117@debbugs.gnu.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.127315930717490 (code B ref 6117); Thu, 06 May 2010 15:22:02 +0000 Received: (at 6117) by debbugs.gnu.org; 6 May 2010 15:21:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OA2tW-0004Y3-R1 for submit@debbugs.gnu.org; Thu, 06 May 2010 11:21:47 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OA2tU-0004Xx-C9 for 6117@debbugs.gnu.org; Thu, 06 May 2010 11:21:44 -0400 Received: from rcsinet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o46FLYFI030537 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 6 May 2010 15:21:36 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by rcsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o46FLVkU008510; Thu, 6 May 2010 15:21:33 GMT Received: from abhmt020.oracle.com by acsmt354.oracle.com with ESMTP id 219852541273159246; Thu, 06 May 2010 08:20:46 -0700 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 06 May 2010 08:20:45 -0700 From: "Drew Adams" References: <87ljbyt7jg.fsf@jidanni.org> Date: Thu, 6 May 2010 08:20:46 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcrtLp4V1soscusnSSKwkD3QlP+yTAAAETig X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Auth-Type: Internal IP X-Source-IP: rcsinet15.oracle.com [148.87.113.117] X-CT-RefId: str=0001.0A090208.4BE2DE81.00A4:SCFMA4539811,ss=1,fgs=0 X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) > Agreed. And while there, please fix the docstrings so they say more > clearly what's different about "flagged vs marked". Yes, thanks. Some Emacs doc and source-code comments refer to deletion flags as "marks" (which they are), so it helps to always specifically say "flagged for deletion" instead of just "flagged". Then any ambiguity will arise only wrt the terms "marked" or (more likely) "mark", and that needs to be taken care of contextually. For example, Dired lets you use `* c' to change "marks", and in that context the `D' flag is considered a mark. Always associating "flag" with "deletion" will go a long way to making things clear. From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2010 21:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: jidanni@jidanni.org Cc: 6117@debbugs.gnu.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.127317958227427 (code B ref 6117); Thu, 06 May 2010 21:00:03 +0000 Received: (at 6117) by debbugs.gnu.org; 6 May 2010 20:59:42 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OA8AY-00078K-ER for submit@debbugs.gnu.org; Thu, 06 May 2010 16:59:42 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3] helo=mx1.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OA8AX-00078F-72 for 6117@debbugs.gnu.org; Thu, 06 May 2010 16:59:41 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.33.106.cable.starman.ee [82.131.33.106]) by mx1.starman.ee (Postfix) with ESMTP id 788943F41B5; Thu, 6 May 2010 23:59:34 +0300 (EEST) From: Juri Linkov Organization: JURTA References: <87ljbyt7jg.fsf@jidanni.org> Date: Thu, 06 May 2010 23:57:10 +0300 In-Reply-To: <87ljbyt7jg.fsf@jidanni.org> (jidanni@jidanni.org's message of "Thu, 06 May 2010 04:31:15 +0800") Message-ID: <87bpcskasf.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.5 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > Please don't use the same colors for both "*" and "D" marked files, seen here: I use the key `D' to delete files marked with "*", so to me there is no difference between "*" and "D" marked files. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2010 02:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Juri Linkov'" , Cc: 6117@debbugs.gnu.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.12732002076456 (code B ref 6117); Fri, 07 May 2010 02:44:02 +0000 Received: (at 6117) by debbugs.gnu.org; 7 May 2010 02:43:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OADXD-0001g5-Iy for submit@debbugs.gnu.org; Thu, 06 May 2010 22:43:27 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OADXB-0001g0-Ch for 6117@debbugs.gnu.org; Thu, 06 May 2010 22:43:25 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o472hJKN026243 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 7 May 2010 02:43:21 GMT Received: from acsmt353.oracle.com (acsmt353.oracle.com [141.146.40.153]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o46LrcLg016067; Fri, 7 May 2010 02:43:18 GMT Received: from abhmt007.oracle.com by acsmt355.oracle.com with ESMTP id 244842791273200193; Thu, 06 May 2010 19:43:13 -0700 Received: from dradamslap1 (/141.144.168.217) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 06 May 2010 19:43:13 -0700 From: "Drew Adams" References: <87ljbyt7jg.fsf@jidanni.org> <87bpcskasf.fsf@mail.jurta.org> Date: Thu, 6 May 2010 19:43:10 -0700 Message-ID: <4E9293AAC84E40FE9331FD9DE354AB06@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87bpcskasf.fsf@mail.jurta.org> Thread-Index: AcrtYs1GkO5G6GIfTLygNjA73xXfqQAK7Nrw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5579 X-Auth-Type: Internal IP X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-CT-RefId: str=0001.0A090203.4BE37E49.00B5:SCFMA922111,ss=1,fgs=0 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.1 (----) > > Please don't use the same colors for both "*" and "D" > > marked files, seen here: > > I use the key `D' to delete files marked with "*", so to me there is > no difference between "*" and "D" marked files. I too use it. And I use `x' to delete flagged files. So what? It's not about how you or I delete files. It's about the different behavior between * and D. There is definitely a difference, even for you, between * and D marks. Commands such as B, C, and M have no effect on D marks (flags), but they do affect * marks. * and D have different behavior and they should definitely have different faces with different default colors. From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 May 2010 18:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Drew Adams" Cc: 6117@debbugs.gnu.org, jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.12732569274658 (code B ref 6117); Fri, 07 May 2010 18:29:01 +0000 Received: (at 6117) by debbugs.gnu.org; 7 May 2010 18:28:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OASI1-0001D4-Uv for submit@debbugs.gnu.org; Fri, 07 May 2010 14:28:47 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3] helo=mx1.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OASHz-0001Cz-Ub for 6117@debbugs.gnu.org; Fri, 07 May 2010 14:28:44 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (62.65.209.247.cable.starman.ee [62.65.209.247]) by mx1.starman.ee (Postfix) with ESMTP id A73CB3F41D0; Fri, 7 May 2010 21:28:39 +0300 (EEST) From: Juri Linkov Organization: JURTA References: <87ljbyt7jg.fsf@jidanni.org> <87bpcskasf.fsf@mail.jurta.org> <4E9293AAC84E40FE9331FD9DE354AB06@us.oracle.com> Date: Fri, 07 May 2010 21:16:12 +0300 In-Reply-To: <4E9293AAC84E40FE9331FD9DE354AB06@us.oracle.com> (Drew Adams's message of "Thu, 6 May 2010 19:43:10 -0700") Message-ID: <87vdazakrb.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.9 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.9 (---) > There is definitely a difference, even for you, between * and D marks. > Commands such as B, C, and M have no effect on D marks (flags), but they > do affect * marks. I meant that the difference between marking and flagging is artificial. There are just different keys to do the same: `D' for marked "*" files, and `x' for flagged "D" files. > * and D have different behavior and they should definitely have > different faces with different default colors. I don't oppose different default faces. I only had a doubt if users would like that. However, when decided to use different faces, I suggest to use the following default faces: * for `dired-flagged' leave the current face unchanged, inherited from `font-lock-warning-face' just like `compilation-error'; * for `dired-marked' use the same face definition as for `compilation-warning'. This face is closer to the current `font-lock-warning-face'. -- Juri Linkov http://www.jurta.org/emacs/ From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2011 22:01:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 6117@debbugs.gnu.org, jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.13105944227333 (code B ref 6117); Wed, 13 Jul 2011 22:01:04 +0000 Received: (at 6117) by debbugs.gnu.org; 13 Jul 2011 22:00:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7Te-0001u0-B6 for submit@debbugs.gnu.org; Wed, 13 Jul 2011 18:00:22 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7TP-0001l6-Ij for 6117@debbugs.gnu.org; Wed, 13 Jul 2011 18:00:10 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Qh7TA-0005pw-1n; Wed, 13 Jul 2011 23:59:48 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: (Stefan Monnier's message of "Thu, 06 May 2010 09:17:35 -0400") Date: Wed, 13 Jul 2011 23:28:33 +0200 Message-ID: References: <87ljbyt7jg.fsf@jidanni.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Tom Tom Club's _Close To The Bone_ X-Hashcash: 1:23:110713:jidanni@jidanni.org::9aut93aRXGDyy1jt:00000000000000000000000000000000000000000076Aq X-Hashcash: 1:23:110713:monnier@iro.umontreal.ca::hNJjguVAnIZdG6m2:00000000000000000000000000000000000004CEF X-Hashcash: 1:23:110713:6117@debbugs.gnu.org::owUsnGD0wN4QvoPY:000000000000000000000000000000000000000018l0c MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Qh7TA-0005pw-1n X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311199188.40464@gs+Jez6zy5Xedau1Fngvxw X-Spam-Status: No X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Stefan Monnier writes: >> Please don't use the same colors for both "*" and "D" marked files, >> seen here: > >> (defface dired-marked >> '((t (:inherit font-lock-warning-face))) >> "Face used for marked files." >> :group 'dired-faces >> :version "22.1") >> (defvar dired-marked-face 'dired-marked >> "Face name used for marked files.") > >> (defface dired-flagged >> '((t (:inherit font-lock-warning-face))) >> "Face used for flagged files." >> :group 'dired-faces >> :version "22.1") >> (defvar dired-flagged-face 'dired-flagged >> "Face name used for flagged files.") > > Agreed. And while there, please fix the docstrings so they say more > clearly what's different about "flagged vs marked". I've fixed the doc string, but what colours should be used, then? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Jul 2011 22:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "'Lars Magne Ingebrigtsen'" , "'Stefan Monnier'" Cc: 6117@debbugs.gnu.org, jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.131059609816085 (code B ref 6117); Wed, 13 Jul 2011 22:29:02 +0000 Received: (at 6117) by debbugs.gnu.org; 13 Jul 2011 22:28:18 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7uj-0004BO-Br for submit@debbugs.gnu.org; Wed, 13 Jul 2011 18:28:17 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qh7uh-0004B8-3r for 6117@debbugs.gnu.org; Wed, 13 Jul 2011 18:28:15 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p6DMS6xl027490 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 13 Jul 2011 22:28:08 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p6DMS6j8003350 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Jul 2011 22:28:06 GMT Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p6DMS0ox028458; Wed, 13 Jul 2011 17:28:01 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 13 Jul 2011 15:28:00 -0700 From: "Drew Adams" References: <87ljbyt7jg.fsf@jidanni.org> Date: Wed, 13 Jul 2011 15:28:02 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcxBqS+NoFPh6vRiRbWytyFTB+GuUAAAnOdw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4E1E1BF9.0004:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.3 (----) > I've fixed the doc string, but what colours should be used, then? FWIW (not much), I use these colors: '((((background dark)) (:foreground "Blue" :background "#7575D4D41D1D")) ; ~ olive green (t (:foreground "Yellow" :background "Blueviolet")) "*Face used for marks (except D) in dired buffers." '((t (:foreground "Yellow" :background "Red"))) "*Face used for deletion flags (D) in dired buffers." Whatever you decide on, I suggest something quite visible for `D'. From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 16 Jul 2011 19:54:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 6117@debbugs.gnu.org, Chong Yidong , jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.131084604024320 (code B ref 6117); Sat, 16 Jul 2011 19:54:03 +0000 Received: (at 6117) by debbugs.gnu.org; 16 Jul 2011 19:54:00 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QiAw3-0006KD-Ov for submit@debbugs.gnu.org; Sat, 16 Jul 2011 15:53:59 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QiAw1-0006Jz-Go for 6117@debbugs.gnu.org; Sat, 16 Jul 2011 15:53:58 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=quimbies.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QiAvo-0004Ek-GY; Sat, 16 Jul 2011 21:53:44 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: (Lars Magne Ingebrigtsen's message of "Wed, 13 Jul 2011 23:28:33 +0200") Date: Sat, 16 Jul 2011 21:53:39 +0200 Message-ID: References: <87ljbyt7jg.fsf@jidanni.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Laurie Freelove's _Heaven On Earth_: "Dear Prudence (Live)" X-Hashcash: 1:23:110716:6117@debbugs.gnu.org::Lnfl0ImIsY+WJLCa:000000000000000000000000000000000000000001Lgs X-Hashcash: 1:23:110716:monnier@iro.umontreal.ca::dSGmUYt/fMjpGnaF:00000000000000000000000000000000000003krM X-Hashcash: 1:23:110716:jidanni@jidanni.org::DGbmx7rtamid6XUB:000000000000000000000000000000000000000000RPfq MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QiAvo-0004Ek-GY X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1311450824.79563@L3/Z+2taOqzfKNZm1CtaeA X-Spam-Status: No X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Lars Magne Ingebrigtsen writes: >>> Please don't use the same colors for both "*" and "D" marked files, >>> seen here: >> >>> (defface dired-marked >>> '((t (:inherit font-lock-warning-face))) [...] >>> (defface dired-flagged >>> '((t (:inherit font-lock-warning-face))) [...] > I've fixed the doc string, but what colours should be used, then? "Drew Adams" writes: >> I've fixed the doc string, but what colours should be used, then? > > FWIW (not much), I use these colors: > > '((((background dark)) > (:foreground "Blue" :background "#7575D4D41D1D")) ; ~ olive green > (t (:foreground "Yellow" :background "Blueviolet")) There's apparently a rampage going on where all faces are supposed to inherit from the `font-lock-*' faces, so I think this would be frowned upon. Does anybody have a suggestion taken from the `font-lock-*' corpus? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 02 15:06:41 2011 Received: (at control) by debbugs.gnu.org; 2 Aug 2011 19:06:41 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoKIb-0000Pv-2a for submit@debbugs.gnu.org; Tue, 02 Aug 2011 15:06:41 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoKIZ-0000Pn-VU for control@debbugs.gnu.org; Tue, 02 Aug 2011 15:06:40 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QoKI0-0007Jq-25 for control@debbugs.gnu.org; Tue, 02 Aug 2011 21:06:04 +0200 Date: Tue, 02 Aug 2011 21:05:41 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #6117 X-MailScanner-ID: 1QoKI0-0007Jq-25 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1312916764.15507@KHFyMLX0fa++UcVvu/m5OA X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 6117 fixed close 6117 24.1 From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: Lars Magne Ingebrigtsen Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Aug 2011 19:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Stefan Monnier Cc: 6117@debbugs.gnu.org, Chong Yidong , jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.13123120991825 (code B ref 6117); Tue, 02 Aug 2011 19:09:01 +0000 Received: (at 6117) by debbugs.gnu.org; 2 Aug 2011 19:08:19 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoKKA-0000TK-NR for submit@debbugs.gnu.org; Tue, 02 Aug 2011 15:08:18 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QoKK7-0000T6-FY for 6117@debbugs.gnu.org; Tue, 02 Aug 2011 15:08:16 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1QoKJT-0007Ly-QZ; Tue, 02 Aug 2011 21:07:35 +0200 From: Lars Magne Ingebrigtsen In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sat, 16 Jul 2011 21:53:39 +0200") Date: Tue, 02 Aug 2011 21:05:38 +0200 Message-ID: References: <87ljbyt7jg.fsf@jidanni.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Throwing Muses's _Dizzy_: "Santa Claus" MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1QoKJT-0007Ly-QZ X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1312916856.35701@8C7hTfEdZ1PDWMzlEkdjlA X-Spam-Status: No X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Lars Magne Ingebrigtsen writes: > There's apparently a rampage going on where all faces are supposed to > inherit from the `font-lock-*' faces, so I think this would be frowned > upon. > > Does anybody have a suggestion taken from the `font-lock-*' corpus? I picket a font-lock face at random. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Aug 2011 09:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Lars Magne Ingebrigtsen Cc: 6117@debbugs.gnu.org, Chong Yidong , Stefan Monnier , jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.131296973222582 (code B ref 6117); Wed, 10 Aug 2011 09:49:02 +0000 Received: (at 6117) by debbugs.gnu.org; 10 Aug 2011 09:48:52 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qr5P9-0005sA-9B for submit@debbugs.gnu.org; Wed, 10 Aug 2011 05:48:52 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qr5P7-0005s3-ED for 6117@debbugs.gnu.org; Wed, 10 Aug 2011 05:48:49 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 2F47B6E8050; Wed, 10 Aug 2011 02:47:36 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id AAF8C451C37D; Wed, 10 Aug 2011 02:47:34 -0700 (PDT) From: Juri Linkov Organization: JURTA References: <87ljbyt7jg.fsf@jidanni.org> Date: Wed, 10 Aug 2011 12:45:03 +0300 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Tue, 02 Aug 2011 21:05:38 +0200") Message-ID: <871uwt38q1.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) >> There's apparently a rampage going on where all faces are supposed to >> inherit from the `font-lock-*' faces, so I think this would be frowned >> upon. >> >> Does anybody have a suggestion taken from the `font-lock-*' corpus? > > I picket a font-lock face at random. This is a dangerous change. It increases the likelihood of deleting the wrong files, because its default color is not distinctive and visible enough to help preventing the wrong operation. Moreover, depending on `font-lock-variable-name-face' with the hope that users never customize `font-lock-*' faces is a wrong assumption. After selecting a new color for variable names, the user later will discover an unpleasant effect that it have on other completely unrelated faces. For instance, I customized `font-lock-variable-name-face' to "Blue1", and now I have the same colors for Dired directories and files flagged for deletion! If it's absolutely necessary to distinguish between marked and flagged files, then they should use colors closer to traditional, e.g.: * for `dired-flagged' leave the old red face unchanged, just like `compilation-error'; * for `dired-marked' use the same face definition as for `compilation-warning'. Its orange color is very close to `dired-flagged' but still distinctive. From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Aug 2011 13:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: "'Juri Linkov'" , "'Lars Magne Ingebrigtsen'" Cc: 6117@debbugs.gnu.org, 'Chong Yidong' , jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.131298403716026 (code B ref 6117); Wed, 10 Aug 2011 13:48:02 +0000 Received: (at 6117) by debbugs.gnu.org; 10 Aug 2011 13:47:17 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qr97t-0004AR-01 for submit@debbugs.gnu.org; Wed, 10 Aug 2011 09:47:17 -0400 Received: from acsinet15.oracle.com ([141.146.126.227]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qr97p-0004AD-Pz for 6117@debbugs.gnu.org; Wed, 10 Aug 2011 09:47:15 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p7ADjuAB004961 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 10 Aug 2011 13:45:58 GMT Received: from acsmt357.oracle.com (acsmt357.oracle.com [141.146.40.157]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p7ADjsY6009654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 10 Aug 2011 13:45:55 GMT Received: from abhmt109.oracle.com (abhmt109.oracle.com [141.146.116.61]) by acsmt357.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p7ADjn9G013709; Wed, 10 Aug 2011 08:45:49 -0500 Received: from dradamslap1 (/10.159.55.111) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 10 Aug 2011 06:45:49 -0700 From: "Drew Adams" References: <87ljbyt7jg.fsf@jidanni.org> <871uwt38q1.fsf@mail.jurta.org> Date: Wed, 10 Aug 2011 06:45:46 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <871uwt38q1.fsf@mail.jurta.org> Thread-Index: AcxXQpn/yKTvGClaR7KdbsPAS/9ZJQAHfEQQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090201.4E428B97.0011:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) > >> Does anybody have a suggestion taken from the `font-lock-*' corpus? > > > > I picket a font-lock face at random. > > This is a dangerous change. It increases the likelihood of > deleting the wrong files, because its default color is not > distinctive and visible enough to help preventing the wrong > operation. Yes. Misguided. > Moreover, depending on `font-lock-variable-name-face' with the hope > that users never customize `font-lock-*' faces is a wrong assumption. > After selecting a new color for variable names, the user later > will discover an unpleasant effect that it have on other > completely unrelated faces. Yes. Misguided. > For instance, I customized `font-lock-variable-name-face' to "Blue1", > and now I have the same colors for Dired directories and files flagged > for deletion! It is simply a bad idea to inherit from a font-lock face here. And even in general, but that's another story. But you came close to it above, where you noted that "the user later will discover an unpleasant effect that it have on other completely unrelated faces". That "unpleasant effect" has nothing in particular to do with the case at hand, but is a general problem with inheriting faces willy nilly. But for the case at hand, at least, it should be clear to all that this is a bad idea. > If it's absolutely necessary to distinguish between marked and flagged > files, then they should use colors closer to traditional, e.g.: > > * for `dired-flagged' leave the old red face unchanged, > just like `compilation-error'; > > * for `dired-marked' use the same face definition as for > `compilation-warning'. Its orange color is very close > to `dired-flagged' but still distinctive. That would be OK. Same colors, but not via inheritance (else you get the same problem you indicated above). What's important is that: a. Both faces be easily noticeable. b. They be easily distinguished from each other. c. The deletion flag be most noticeable. A "warning" color such as red is good for this, as it signals potential danger. FWIW, I use these: Skyblue background for marked. Red foreground for flagged. Yellow-on-red for the `D' itself. Yellow-on-blueviolet for the `*' itself. From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2011 19:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: "Drew Adams" Cc: 6117@debbugs.gnu.org, 'Lars Magne Ingebrigtsen' , 'Chong Yidong' , jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.131360994820343 (code B ref 6117); Wed, 17 Aug 2011 19:40:02 +0000 Received: (at 6117) by debbugs.gnu.org; 17 Aug 2011 19:39:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QtlxD-0005I3-Gu for submit@debbugs.gnu.org; Wed, 17 Aug 2011 15:39:07 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QtlxA-0005Ht-RX for 6117@debbugs.gnu.org; Wed, 17 Aug 2011 15:39:06 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 0D2B66E807E; Wed, 17 Aug 2011 12:37:09 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 6B910451C137; Wed, 17 Aug 2011 12:37:07 -0700 (PDT) From: Juri Linkov Organization: JURTA References: <87ljbyt7jg.fsf@jidanni.org> <871uwt38q1.fsf@mail.jurta.org> Date: Wed, 17 Aug 2011 22:35:45 +0300 In-Reply-To: (Drew Adams's message of "Wed, 10 Aug 2011 06:45:46 -0700") Message-ID: <87ippvhm3g.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > It is simply a bad idea to inherit from a font-lock face here. Yes, basically the inheritance is a convenient tool to allow the user to modify a set of faces by editing one parent face, but only if these faces are semantically related. Font-lock faces semantically correspond to the entities existing in programming languages like comments, strings, keywords, function-names, variable-names, constants. So to create a reasonable face hierarchy, we should introduce faces with a universal color code like traffic lights where the red color denotes a dangerous activity or errors, the yellow/amber color denotes a caution, and the green color denotes a successful activity. In the patch below, I've removed the regression and restored traditional pre-24 colors in compilation and dired, and also changed `dired-flagged' to inherit from the `error' face, and `dired-marked' from `warning'. There are more places that need these new faces to indicate error/warning/success, e.g. battery.el and other packages unrelated to font-lock that currently abuse font-lock faces. They could be modified later. === modified file 'lisp/dired.el' --- lisp/dired.el 2011-08-10 08:40:46 +0000 +++ lisp/dired.el 2011-08-17 19:31:50 +0000 @@ -342,7 +342,7 @@ (defvar dired-mark-face 'dired-mark "Face name used for dired marks.") (defface dired-marked - '((t (:inherit font-lock-warning-face))) + '((t (:inherit warning))) "Face used for marked files." :group 'dired-faces :version "22.1") @@ -350,7 +350,7 @@ (defvar dired-marked-face 'dired-marked "Face name used for marked files.") (defface dired-flagged - '((t (:inherit font-lock-variable-name-face))) + '((t (:inherit error))) "Face used for files flagged for deletion." :group 'dired-faces :version "22.1") === modified file 'lisp/progmodes/compile.el' --- lisp/progmodes/compile.el 2011-07-25 08:23:29 +0000 +++ lisp/progmodes/compile.el 2011-08-17 19:32:45 +0000 @@ -647,19 +647,19 @@ (defvar compilation-environment nil (defvar compile-history nil) (defface compilation-error - '((t :inherit font-lock-warning-face)) + '((t :inherit error)) "Face used to highlight compiler errors." :group 'compilation :version "22.1") (defface compilation-warning - '((t :inherit font-lock-variable-name-face)) + '((t :inherit warning)) "Face used to highlight compiler warnings." :group 'compilation :version "22.1") (defface compilation-info - '((t :inherit font-lock-type-face)) + '((t :inherit success)) "Face used to highlight compiler information." :group 'compilation :version "22.1") === modified file 'lisp/faces.el' --- lisp/faces.el 2011-08-10 18:17:21 +0000 +++ lisp/faces.el 2011-08-17 19:31:45 +0000 @@ -2427,6 +2427,39 @@ (defface glyphless-char It is used for characters of no fonts too." :version "24.1" :group 'basic-faces) + +(defface error + '((((class color) (min-colors 88) (background light)) (:foreground "Red1" :weight bold)) + (((class color) (min-colors 88) (background dark)) (:foreground "Pink" :weight bold)) + (((class color) (min-colors 16) (background light)) (:foreground "Red1" :weight bold)) + (((class color) (min-colors 16) (background dark)) (:foreground "Pink" :weight bold)) + (((class color) (min-colors 8)) (:foreground "red")) + (t (:inverse-video t :weight bold))) + "Face used to highlight errors." + :version "24.1" + :group 'basic-faces) + +(defface warning + '((((class color) (min-colors 16)) (:foreground "Orange" :weight bold)) + (((class color)) (:foreground "cyan" :weight bold)) + (t (:weight bold))) + "Face used to highlight warnings." + :version "24.1" + :group 'basic-faces) + +(defface success + '((((class color) (min-colors 16) (background light)) + (:foreground "Green3" :weight bold)) + (((class color) (min-colors 88) (background dark)) + (:foreground "Green1" :weight bold)) + (((class color) (min-colors 16) (background dark)) + (:foreground "Green" :weight bold)) + (((class color)) (:foreground "green" :weight bold)) + (t (:weight bold))) + "Face used to indicate success." + :version "24.1" + :group 'basic-faces) + ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ;;; Manipulating font names. === modified file 'lisp/font-lock.el' --- lisp/font-lock.el 2011-07-14 13:50:25 +0000 +++ lisp/font-lock.el 2011-08-17 19:32:27 +0000 @@ -1959,12 +1959,7 @@ (defface font-lock-constant-face :group 'font-lock-faces) (defface font-lock-warning-face - '((((class color) (min-colors 88) (background light)) (:foreground "Red1" :weight bold)) - (((class color) (min-colors 88) (background dark)) (:foreground "Pink" :weight bold)) - (((class color) (min-colors 16) (background light)) (:foreground "Red1" :weight bold)) - (((class color) (min-colors 16) (background dark)) (:foreground "Pink" :weight bold)) - (((class color) (min-colors 8)) (:foreground "red")) - (t (:inverse-video t :weight bold))) + '((t :inherit error)) "Font Lock mode face used to highlight warnings." :group 'font-lock-faces) From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face In-Reply-To: <87ljbyt7jg.fsf@jidanni.org> Resent-From: jidanni@jidanni.org Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2011 20:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: juri@jurta.org Cc: 6117@debbugs.gnu.org, larsi@gnus.org, cyd@stupidchicken.com, drew.adams@oracle.com Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.131361146822656 (code B ref 6117); Wed, 17 Aug 2011 20:05:02 +0000 Received: (at 6117) by debbugs.gnu.org; 17 Aug 2011 20:04:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QtmLi-0005tM-Un for submit@debbugs.gnu.org; Wed, 17 Aug 2011 16:04:27 -0400 Received: from caiajhbdcbhh.dreamhost.com ([208.97.132.177] helo=homiemail-a4.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QtmLf-0005tC-HL for 6117@debbugs.gnu.org; Wed, 17 Aug 2011 16:04:25 -0400 Received: from homiemail-a4.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a4.g.dreamhost.com (Postfix) with ESMTP id 8204B51C063; Wed, 17 Aug 2011 13:02:27 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; c=nofws; d=jidanni.org; h=from:to:cc:subject :references:date:message-id:mime-version:content-type: content-transfer-encoding; q=dns; s=jidanni.org; b=EnHdMRO8+uAym 2eGW28cZZ25BCJpzrB1BHgK/Ymlm2NJgpI9f9oe4q9dL+iXJIRnqIXykshtTEU+O 2riJMewwURSWLpMLswsYfHHFSB0uODWt22jjfai+tk7n1As/2NugXa1Kr/Kus6AX zO2yZNjIvzqOdDkxWI3+be9d4K/JbM= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jidanni.org; h=from:to:cc :subject:references:date:message-id:mime-version:content-type: content-transfer-encoding; s=jidanni.org; bh=nkb2nr0EoyU++lx3+2E orN9akTQ=; b=l6Rd5qIdG9xaa7We/VAIny8bsOPlRRaZNqBTzOmcyCcDrJjh90a aJ+db1yWvXjCa0RNRAWEk9sCnE5dmebzJ/X22v6XgqPi9olcJC5o2xnY1M9fITcG tkYmgCWJ/XaFtIH1fgthYo+AfsIMKQ1b6BU4+p7mBaZpJDTDP7Y4bLxI= Received: from jidanni.org (218-163-0-19.dynamic.hinet.net [218.163.0.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: jidanni@jidanni.org) by homiemail-a4.g.dreamhost.com (Postfix) with ESMTPSA id E9DBC51C05F; Wed, 17 Aug 2011 13:02:26 -0700 (PDT) From: jidanni@jidanni.org References: <87ippvhm3g.fsf@mail.jurta.org> Date: Thu, 18 Aug 2011 04:02:19 +0800 Message-ID: <87k4abg62c.fsf@jidanni.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.4 (---) And pink, for files one needs their parents permissions to read, or be ov= er 18 =E2=98=BB From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 Aug 2011 21:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Juri Linkov Cc: 6117@debbugs.gnu.org, 'Lars Magne Ingebrigtsen' , Drew Adams , jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.131361710731088 (code B ref 6117); Wed, 17 Aug 2011 21:39:02 +0000 Received: (at 6117) by debbugs.gnu.org; 17 Aug 2011 21:38:27 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qtnoh-00085M-LQ for submit@debbugs.gnu.org; Wed, 17 Aug 2011 17:38:27 -0400 Received: from vm-emlprdomr-03.its.yale.edu ([130.132.50.144]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qtnof-00084y-Ad for 6117@debbugs.gnu.org; Wed, 17 Aug 2011 17:38:26 -0400 Received: from furball (dhcp-128-36-225-145.central.yale.edu [128.36.225.145]) (authenticated bits=0) by vm-emlprdomr-03.its.yale.edu (8.14.4/8.14.4) with ESMTP id p7HLaALd006596 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Wed, 17 Aug 2011 17:36:11 -0400 From: Chong Yidong References: <87ljbyt7jg.fsf@jidanni.org> <871uwt38q1.fsf@mail.jurta.org> <87ippvhm3g.fsf@mail.jurta.org> Date: Wed, 17 Aug 2011 17:36:10 -0400 In-Reply-To: <87ippvhm3g.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 17 Aug 2011 22:35:45 +0300") Message-ID: <87y5yrwwj9.fsf@stupidchicken.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.144 X-Spam-Score: -2.7 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) Juri Linkov writes: > In the patch below, I've removed the regression and restored > traditional pre-24 colors in compilation and dired, and also changed > `dired-flagged' to inherit from the `error' face, and `dired-marked' > from `warning'. > > There are more places that need these new faces to indicate > error/warning/success, e.g. battery.el and other packages unrelated to > font-lock that currently abuse font-lock faces. They could be > modified later. Looks fine to me, but test the 16-color versions of those faces in an xterm first, to see if those color values give the right results. From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Aug 2011 11:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Chong Yidong Cc: 6117@debbugs.gnu.org, 'Lars Magne Ingebrigtsen' , Drew Adams , jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.131366845324054 (code B ref 6117); Thu, 18 Aug 2011 11:55:02 +0000 Received: (at 6117) by debbugs.gnu.org; 18 Aug 2011 11:54:13 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qu1Aq-0006Ft-GC for submit@debbugs.gnu.org; Thu, 18 Aug 2011 07:54:13 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Qu1An-0006Fk-PY for 6117@debbugs.gnu.org; Thu, 18 Aug 2011 07:54:11 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 16E2C6E8053; Thu, 18 Aug 2011 04:52:10 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 7B9FA451C3C3; Thu, 18 Aug 2011 04:52:08 -0700 (PDT) From: Juri Linkov Organization: JURTA References: <87ljbyt7jg.fsf@jidanni.org> <871uwt38q1.fsf@mail.jurta.org> <87ippvhm3g.fsf@mail.jurta.org> <87y5yrwwj9.fsf@stupidchicken.com> Date: Thu, 18 Aug 2011 14:46:25 +0300 In-Reply-To: <87y5yrwwj9.fsf@stupidchicken.com> (Chong Yidong's message of "Wed, 17 Aug 2011 17:36:10 -0400") Message-ID: <87vctv54dq.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > Looks fine to me, but test the 16-color versions of those faces in an > xterm first, to see if those color values give the right results. Done. I tested the 16-color versions in an xterm, and they look fine on light and dark backgrounds. I'm also going to install changes in packages related to dired that use faces for marked/flagged for deletion: === modified file 'lisp/ibuffer.el' --- lisp/ibuffer.el 2011-08-15 10:21:47 +0000 +++ lisp/ibuffer.el 2011-08-18 11:20:35 +0000 @@ -356,12 +356,12 @@ (defcustom ibuffer-load-hook nil :type 'hook :group 'ibuffer) -(defcustom ibuffer-marked-face 'font-lock-warning-face +(defcustom ibuffer-marked-face 'warning "Face used for displaying marked buffers." :type 'face :group 'ibuffer) -(defcustom ibuffer-deletion-face 'font-lock-type-face +(defcustom ibuffer-deletion-face 'error "Face used for displaying buffers marked for deletion." :type 'face :group 'ibuffer) === modified file 'lisp/proced.el' --- lisp/proced.el 2011-07-20 09:53:51 +0000 +++ lisp/proced.el 2011-08-18 11:29:33 +0000 @@ -395,7 +395,7 @@ (defface proced-mark :group 'proced-faces) (defface proced-marked - '((t (:inherit font-lock-warning-face))) + '((t (:inherit error))) "Face used for marked processes." :group 'proced-faces) === modified file 'lisp/battery.el' --- lisp/battery.el 2011-06-27 08:04:55 +0000 +++ lisp/battery.el 2011-08-18 11:12:33 +0000 @@ -199,7 +199,7 @@ (defun battery-update () 'face (and (<= (car (read-from-string (cdr (assq ?p data)))) battery-load-critical) - 'font-lock-warning-face) + 'error) 'help-echo "Battery status information"))) (force-mode-line-update)) From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 22 12:06:51 2011 Received: (at control) by debbugs.gnu.org; 22 Aug 2011 16:06:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QvX1V-00039t-VN for submit@debbugs.gnu.org; Mon, 22 Aug 2011 12:06:50 -0400 Received: from vm-emlprdomr-05.its.yale.edu ([130.132.50.146]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QvX1T-00039m-Nj for control@debbugs.gnu.org; Mon, 22 Aug 2011 12:06:48 -0400 Received: from furball (dhcp-128-36-225-149.central.yale.edu [128.36.225.149]) (authenticated bits=0) by vm-emlprdomr-05.its.yale.edu (8.14.4/8.14.4) with ESMTP id p7MG4Osp002496 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Mon, 22 Aug 2011 12:04:24 -0400 From: Chong Yidong To: control@debbugs.gnu.org Subject: close 6117 Date: Mon, 22 Aug 2011 12:04:24 -0400 Message-ID: <87mxf1totz.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.71 on 130.132.50.146 X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) close 6117 thanks From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Aug 2011 18:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: Chong Yidong Cc: 6117@debbugs.gnu.org, jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.131420961828871 (code B ref 6117); Wed, 24 Aug 2011 18:14:01 +0000 Received: (at 6117) by debbugs.gnu.org; 24 Aug 2011 18:13:38 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QwHxJ-0007Vb-Sf for submit@debbugs.gnu.org; Wed, 24 Aug 2011 14:13:38 -0400 Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QwHxI-0007VU-Au for 6117@debbugs.gnu.org; Wed, 24 Aug 2011 14:13:37 -0400 Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 127206E80C0; Wed, 24 Aug 2011 11:11:01 -0700 (PDT) Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 0C5F1451C28D; Wed, 24 Aug 2011 11:10:59 -0700 (PDT) From: Juri Linkov Organization: JURTA References: <87ljbyt7jg.fsf@jidanni.org> <871uwt38q1.fsf@mail.jurta.org> <87ippvhm3g.fsf@mail.jurta.org> <87y5yrwwj9.fsf@stupidchicken.com> <87vctv54dq.fsf@mail.jurta.org> Date: Wed, 24 Aug 2011 21:09:42 +0300 In-Reply-To: <87vctv54dq.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 18 Aug 2011 14:46:25 +0300") Message-ID: <878vqiel5l.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) > I'm also going to install changes in packages related to dired > that use faces for marked/flagged for deletion: Installed. I also think it makes sense to create a new face `line-number' and inherit from it in `compilation-line-number'. Another place that could use this face is Occur to highlight line numbers in the *Occur* buffer. From unknown Thu Aug 14 21:56:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#6117: 24.0.50; dired-marked-face same as dired-flagged-face Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Aug 2011 18:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6117 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed To: "'Juri Linkov'" , "'Chong Yidong'" Cc: 6117@debbugs.gnu.org, jidanni@jidanni.org Received: via spool by 6117-submit@debbugs.gnu.org id=B6117.131420993131993 (code B ref 6117); Wed, 24 Aug 2011 18:19:02 +0000 Received: (at 6117) by debbugs.gnu.org; 24 Aug 2011 18:18:51 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QwI2N-0008Jy-0a for submit@debbugs.gnu.org; Wed, 24 Aug 2011 14:18:51 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QwI2J-0008Jp-AE for 6117@debbugs.gnu.org; Wed, 24 Aug 2011 14:18:48 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p7OIG8o1017782 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 24 Aug 2011 18:16:10 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p7OIG603020871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 24 Aug 2011 18:16:07 GMT Received: from abhmt111.oracle.com (abhmt111.oracle.com [141.146.116.63]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p7OIG1AI005375; Wed, 24 Aug 2011 13:16:01 -0500 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 24 Aug 2011 11:16:00 -0700 From: "Drew Adams" References: <87ljbyt7jg.fsf@jidanni.org> <871uwt38q1.fsf@mail.jurta.org><87ippvhm3g.fsf@mail.jurta.org> <87y5yrwwj9.fsf@stupidchicken.com><87vctv54dq.fsf@mail.jurta.org> <878vqiel5l.fsf@mail.jurta.org> Date: Wed, 24 Aug 2011 11:16:01 -0700 Message-ID: <7A83795C8D444DDAA30552FD96B97931@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <878vqiel5l.fsf@mail.jurta.org> Thread-Index: AcxiiUccliYMxcNoRpSVssv21JUu3wAAHvtA X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6109 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.4E553FEB.0078:SCFMA922111,ss=1,re=-4.000,fgs=0 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.2 (----) > I also think it makes sense to create a new face `line-number' > and inherit from it in `compilation-line-number'. Another place > that could use this face is Occur to highlight line numbers > in the *Occur* buffer. FWIW, grep and compilation output also refer to line numbers. These are not the numbers of the lines in those buffers, but they are line numbers.