GNU bug report logs - #61165
30.0.50; Avoid nreverse in row_to_value

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Helmut Eller <eller.helmut <at> gmail.com>
Subject: bug#61165: closed (Re: bug#61165: 30.0.50; Avoid nreverse in
 row_to_value)
Date: Thu, 02 Feb 2023 19:50:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#61165: 30.0.50; Avoid nreverse in row_to_value

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 61165 <at> debbugs.gnu.org.

-- 
61165: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61165
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Helmut Eller <eller.helmut <at> gmail.com>
Cc: 61165-done <at> debbugs.gnu.org
Subject: Re: bug#61165: 30.0.50; Avoid nreverse in row_to_value
Date: Thu, 02 Feb 2023 21:49:35 +0200

> From: Helmut Eller <eller.helmut <at> gmail.com>
> Date: Mon, 30 Jan 2023 08:30:14 +0100
> 
> The function row_to_value in the file src/sqlite.c can avoid the call to
> Fnreverse by traversing the row in reverse order.  Only a minor
> improvement but the change is simple.

Thanks, installed on the emacs-29 branch

[Message part 3 (message/rfc822, inline)]

From: Helmut Eller <eller.helmut <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Avoid nreverse in row_to_value
Date: Mon, 30 Jan 2023 08:30:14 +0100

[Message part 4 (text/plain, inline)]

The function row_to_value in the file src/sqlite.c can avoid the call to
Fnreverse by traversing the row in reverse order.  Only a minor
improvement but the change is simple.

[sqlite.patch (text/x-diff, inline)]

diff --git a/src/sqlite.c b/src/sqlite.c
index c96841e63f9..6e89ef04287 100644
--- a/src/sqlite.c
+++ b/src/sqlite.c
@@ -399,7 +399,7 @@ row_to_value (sqlite3_stmt *stmt)
   int len = sqlite3_column_count (stmt);
   Lisp_Object values = Qnil;
 
-  for (int i = 0; i < len; ++i)
+  for (int i = len - 1; 0 <= i; i--)
     {
       Lisp_Object v = Qnil;
 
@@ -434,7 +434,7 @@ row_to_value (sqlite3_stmt *stmt)
       values = Fcons (v, values);
     }
 
-  return Fnreverse (values);
+  return values;
 }
 
 static Lisp_Object

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.