From unknown Mon Aug 18 11:11:57 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61165 <61165@debbugs.gnu.org> To: bug#61165 <61165@debbugs.gnu.org> Subject: Status: 30.0.50; Avoid nreverse in row_to_value Reply-To: bug#61165 <61165@debbugs.gnu.org> Date: Mon, 18 Aug 2025 18:11:57 +0000 retitle 61165 30.0.50; Avoid nreverse in row_to_value reassign 61165 emacs submitter 61165 Helmut Eller severity 61165 normal tag 61165 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 02:30:23 2023 Received: (at submit) by debbugs.gnu.org; 30 Jan 2023 07:30:23 +0000 Received: from localhost ([127.0.0.1]:46205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMOcR-0001rL-0X for submit@debbugs.gnu.org; Mon, 30 Jan 2023 02:30:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:48842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMOcP-0001rD-4H for submit@debbugs.gnu.org; Mon, 30 Jan 2023 02:30:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMOcO-00059F-SI for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 02:30:20 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pMOcN-0004AV-6Y for bug-gnu-emacs@gnu.org; Mon, 30 Jan 2023 02:30:20 -0500 Received: by mail-wm1-x32b.google.com with SMTP id m5-20020a05600c4f4500b003db03b2559eso7431306wmq.5 for ; Sun, 29 Jan 2023 23:30:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=VzXlwKTaquFucfgiKOIgyNYvhUPrFinx1peVgsXvNVg=; b=LcaMK+FyquFnTm8bMe5CGYbDQFj7iRFrsv9TbZp5bGo/fFmKiAavCXHysDUaWFYT56 yxoXEXKPJxxIxInLEbP3hl/ztJUxA8Tgz3p4hd3XgyqEvh8duG5NITQ1L65ZvBupccHI KIOOTf95hT0oYAfBHKkgUz5oa3iZmXVpKvObuxD2kGQS22SxWXyi77XLldOvncx9oVQq WYuNesYmg6uLgx8a8Xr/lzP1rMT6xQWCoIs9g+Y/+Hd5QzaDNBHnShA9lFWdeJ2fYyDj gxhXZscmm52+8jyV5+JaOEGU8nB8arNpPs7CdWdHFt08j3l0jK1dSRU3OLfEEifQNhaC yZ0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VzXlwKTaquFucfgiKOIgyNYvhUPrFinx1peVgsXvNVg=; b=tRQu8J6qfRNU/OsfVVHm0AktmpNq36MgWghW8UGKhtHNZlu9QRcfAaiqgQU6lda4pp XMXWOPQjSAVEFChjgygUCKMAGkavLSnskANXpcmSKDZdyjtgleRIp6P91yBvsQevoD5s E7DbFt8nXwTstABZcWPJNwwTGDIPrbcwkQXPABG/Fsf8qUcMe972SmL0TfUaZjBGYI/f M12K3Lml7x3xHQRkuXbWwFD0x9O8Smvy8qKxKNwRXIn5vM2NMlRfNL1ayKQqY1jqK2Ir Gl080nL1kj8jttlEH4A2Zh12UqbvFLZTe82mePVT5kN9IOjNw68uxSK8lqpyyKF1NkPQ Ri6g== X-Gm-Message-State: AO0yUKWXNrPJwYRxjBFNjmvX7/h6Q+4zL+O5IdpR0mC3u5bvvv4ip957 eueR8cKcmgBJ6KrnFWoXAuCw7kO/M6A= X-Google-Smtp-Source: AK7set/ZWH8rShu2Kxb8COHzR3LlPd8zWoTz4hIchhwkTL+ROtaBBJ0eEDghon6vaFrp3w0PdbItLQ== X-Received: by 2002:a05:600c:3512:b0:3dc:2c7c:6616 with SMTP id h18-20020a05600c351200b003dc2c7c6616mr14283824wmq.21.1675063817392; Sun, 29 Jan 2023 23:30:17 -0800 (PST) Received: from caladan ([185.127.214.178]) by smtp.gmail.com with ESMTPSA id p12-20020a05600c418c00b003d9780466b0sm11750179wmh.31.2023.01.29.23.30.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 23:30:16 -0800 (PST) From: Helmut Eller To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Avoid nreverse in row_to_value Date: Mon, 30 Jan 2023 08:30:14 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=eller.helmut@gmail.com; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain The function row_to_value in the file src/sqlite.c can avoid the call to Fnreverse by traversing the row in reverse order. Only a minor improvement but the change is simple. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=sqlite.patch diff --git a/src/sqlite.c b/src/sqlite.c index c96841e63f9..6e89ef04287 100644 --- a/src/sqlite.c +++ b/src/sqlite.c @@ -399,7 +399,7 @@ row_to_value (sqlite3_stmt *stmt) int len = sqlite3_column_count (stmt); Lisp_Object values = Qnil; - for (int i = 0; i < len; ++i) + for (int i = len - 1; 0 <= i; i--) { Lisp_Object v = Qnil; @@ -434,7 +434,7 @@ row_to_value (sqlite3_stmt *stmt) values = Fcons (v, values); } - return Fnreverse (values); + return values; } static Lisp_Object --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 02:41:48 2023 Received: (at control) by debbugs.gnu.org; 30 Jan 2023 07:41:48 +0000 Received: from localhost ([127.0.0.1]:46224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMOnU-0002A8-JD for submit@debbugs.gnu.org; Mon, 30 Jan 2023 02:41:48 -0500 Received: from mail-oi1-f169.google.com ([209.85.167.169]:40493) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMOnT-00029t-9y for control@debbugs.gnu.org; Mon, 30 Jan 2023 02:41:47 -0500 Received: by mail-oi1-f169.google.com with SMTP id s66so9332928oib.7 for ; Sun, 29 Jan 2023 23:41:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=kZD2TEez1f7y7Tj5dBxXrpKmsHGGAm1EaIi6Ahgdz74=; b=MndCFd+rgcfqKTG4v8ZtE/MVG3iTl0irQb4hAnR2yDALyk1GGHq1s+99BCMhKMmTMy PXQYXzRZOkmusnNPw4Cv7W//JlSdgG2jKCBfnJKUckSsjt+HKBE6PKMrhXSP4+/DCQgd 4zMS4xkvXnZZhfC930TrfBjtZV+2ld9eyKvw3VRp6b868nWlUbuwV8l50Uu2nuzfcPn9 iAFY74g55vO6mR9rk0KeYXRlhINR+p7eBNFkDd/VHrK7xMTJ5OJPe89wKD0uzU82BCqT psgDMDexfOKmhQLve1sYqYX/k0il0wfwGxWa0K48mmlcwDYjzK/jxTfbWucdnNAn5TEM chNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=kZD2TEez1f7y7Tj5dBxXrpKmsHGGAm1EaIi6Ahgdz74=; b=2tw9U8q5snb0QT0758246PtAxILyaPhkqzdRHoWk+9JB/CpnUY7w/pAiutmfcPUzi6 PIZfmYBrel1t6bUySUyRHJzRoVbQ3RwtEA3xtWvZzNAWWtd6i4mwYEMLgs5AXfU8UDly nYTPDZFJnSVZqDQ0/bcNPwLA3LWGq+9G8mXWZUMJX/e59yFFTAbQfXwN9LmH/J+pdIH9 Zpd/tY7Bxr9a+yeHbfR7KcSdp4dvAFi1hnmZMpLik/jt7gcMYF0+9zCcJOG8U++Wj2E2 FeQzvdNDi3CMdRgwKKEcxB08+EpogfG7UzCRJzvaXKiFVhXd/+nzJgAH8p1Vlhpa0dp5 sDhA== X-Gm-Message-State: AFqh2kr7N6rEufQcsozLWo9n6JIHFJeCgIhHrG01AKOPcmJUppLCb9ad 7C6ne81DCAvy3VXUY0bihgkteGg0y5RtJin0mWHDLIt+ X-Google-Smtp-Source: AMrXdXvUHOHF6/90RDcuSKSx8QXu43JwqDE/C2Q8t6kh6V8wYHHfD2slACnfjWXHyzFiGrrzsiSQCQ9NkL9yz/b+ohY= X-Received: by 2002:aca:3c08:0:b0:360:ceaa:7e4e with SMTP id j8-20020aca3c08000000b00360ceaa7e4emr2316001oia.199.1675064501505; Sun, 29 Jan 2023 23:41:41 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 30 Jan 2023 08:41:41 +0100 From: Stefan Kangas X-Hashcash: 1:20:230130:control@debbugs.gnu.org::du2mTk0D+3EUGmLo:1CDl MIME-Version: 1.0 Date: Mon, 30 Jan 2023 08:41:41 +0100 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: tags 61165 + patch thanks Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [209.85.167.169 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [209.85.167.169 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 2.0 BLANK_SUBJECT Subject is present but empty 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) tags 61165 + patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 02 14:49:42 2023 Received: (at 61165-done) by debbugs.gnu.org; 2 Feb 2023 19:49:42 +0000 Received: from localhost ([127.0.0.1]:35850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNfaY-00076Y-5J for submit@debbugs.gnu.org; Thu, 02 Feb 2023 14:49:42 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNfaW-00076M-Gz for 61165-done@debbugs.gnu.org; Thu, 02 Feb 2023 14:49:40 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNfaQ-00073I-9z; Thu, 02 Feb 2023 14:49:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=h16QeTbEHj18oT5xzJEZbdp55wxclJ+4sFjjsYTRZF0=; b=ndSREClIeezg ev0rPi+wRAc8mzg/8aYIG7E3Qnw5hLDJugrUsYAd82hLAc0kwHxO7o7E0KAbVS9famzyyzuiYtCW9 /S8i+VgaDJ3koPxJVkI/wpXiIN7qjNOPeu6f3t0upsVWx836+ab0P0I7e2SVNzfRwUl++EP54m0KJ 7Nfz05/LrbJmOBh8gOfzyV12CD4u3sIZ03Zpc1Wi1lAvqRohIZVMWi+dWJBH3TkpfvYAByDbGlKKI WzwLXF0IHOteSPzp/CuF0TSbX56wXJH1p0IJy2IhTOF1BmgOArdjnYqPGtoU2wLfUnmn68ewI1AZv FKbcHOMPqy5P046sOOo7mw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNfaP-00034Y-Gi; Thu, 02 Feb 2023 14:49:33 -0500 Date: Thu, 02 Feb 2023 21:49:35 +0200 Message-Id: <83cz6rx2y8.fsf@gnu.org> From: Eli Zaretskii To: Helmut Eller In-Reply-To: (message from Helmut Eller on Mon, 30 Jan 2023 08:30:14 +0100) Subject: Re: bug#61165: 30.0.50; Avoid nreverse in row_to_value References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61165-done Cc: 61165-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Helmut Eller > Date: Mon, 30 Jan 2023 08:30:14 +0100 > > The function row_to_value in the file src/sqlite.c can avoid the call to > Fnreverse by traversing the row in reverse order. Only a minor > improvement but the change is simple. Thanks, installed on the emacs-29 branch From unknown Mon Aug 18 11:11:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 Mar 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator