GNU bug report logs - #61163
[PATCH] gnu: emacs-pretty-speedbar: New package.

Previous Next

Full log

Message #8 received at 61163 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Martin Marshall <law <at> martinmarshall.com>
Cc: 61163 <at> debbugs.gnu.org
Subject: Re: [bug#61163] [PATCH] gnu: emacs-pretty-speedbar: New package.
Date: Tue, 31 Jan 2023 15:05:14 +0100

Hello,

Martin Marshall <law <at> martinmarshall.com> writes:

> * gnu/packages/emacs-xyz.scm (emacs-pretty-speedbar): New package.

Thank you. Some comments follow.

> +(define-public emacs-pretty-speedbar
> +  (let ((commit "56dc9f114fcc55843e182cde1fc9d7a14c261c6a")
> +        (revision "0"))
> +    (package
> +      (name "emacs-pretty-speedbar")
> +      (version "0.2")

This should be (git-version "0.2" revision commit) since you're not
using the exact commit where the version bump happened.

> +      (source (origin
> +                (uri (git-reference
> +                      (url "https://github.com/kcyarn/pretty-speedbar")
> +                      (commit commit)))
> +                (method git-fetch)
> +                (file-name (git-file-name name version))
> +                (sha256
> +                 (base32
> +                  "1hz67jhvg9n9d07lil6zqciqhh512k0fv54dl605p7vi704ma2ir"))))
> +      (build-system emacs-build-system)
> +      (propagated-inputs (list font-awesome))

It seems the project requires Font Awesome 6, but Guix only provides
version 4. Is it an issue?

It may be worth considering updating font-awesome in Guix first, but
I don't know what its freedom status is nowadays (as a data point,
Parabola provides it, tho).

> +      (description
> +       "Generate and implement appealing SVG icons for the Emacs
> Speedbar.  

This is not a complete sentence.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.