Subject: Re: [bug#61163] [PATCH] gnu: emacs-pretty-speedbar: New package.

From: Martin Marshall <[email-masked]>
Date: Tue, 31 Jan 2023 13:16:25 -0500

> An updated patch is attached.

I believe something happened to the attachment in my reply,
either in transit or before sending.  (I'm new to sending
attachments with Gnus.)

Hopefully this time will work better.

-- 
Martin Marshall
[email-masked]

On Tue, Jan 31, 2023 at 12:54 PM Martin Marshall <[email-masked]>
wrote:

> Nicolas Goaziou <[email-masked]> writes:
>
> >> +      (propagated-inputs (list font-awesome))
> >
> > It seems the project requires Font Awesome 6, but Guix only provides
> > version 4. Is it an issue?
>
> I don't think so.  While the default value of the `pretty-speedbar-font'
> user-setting is "Font Awesome 6 Free Solid", the setting is
> customizable, and any icon font may be used with the package.
>
> Even with the default value of `pretty-speedbar-font' unchanged, my
> system automatically uses the Font Awesome 4 fonts provided by Guix's
> font-awesome package.
>
> > It may be worth considering updating font-awesome in Guix first, but
> > I don't know what its freedom status is nowadays (as a data point,
> > Parabola provides it, tho).
>
> There is a comment to its package definition stating this:
>
>    ;; XXX The build scripts of version 5 are not freely licensed and
>    ;; so we have to stick with version 4 for now:
>    ;; <https://bugs.gnu.org/32916>
>
> The linked discussion from 2018 concluded with all participants agreeing
> that distribution of version 5 or higher would violate the Gnu FSDG.
>
> I reviewed the Font Awesome GitHub Issues, and it seems they remain
> unwilling to change the licensing terms for the build scripts, the matter
> having been raised as late as March 2022.
>
> There is a fork of Font Awesome whose stated goals are "to continue
> building the amazing resource in a fully free, libre and open-source
> fashion" (https://github.com/ForkAwesome/Fork-Awesome).  I haven't
> used it though.
>
> >> +      (description
> >> +       "Generate and implement appealing SVG icons for the Emacs
> >> Speedbar.
> >
> > This is not a complete sentence.
> >
> > Could you send an updated patch?
>
> Thank you for this and the other feedback provided.
>
> I've rewritten the description along with the other suggested changes.
>
> An updated patch is attached.
>
> Warm regards,
>
> --
> Martin Marshall
> [email-masked]
>
From ba6c868b90504b5337ef14be8ee410a3ddad5890 Mon Sep 17 00:00:00 2001
Message-Id: <[email-masked]>
From: Martin Marshall <[email-masked]>
Date: Tue, 31 Jan 2023 11:38:47 -0500
Subject: [PATCH] gnu: Add emacs-pretty-speedbar.

* gnu/packages/emacs-xyz.scm (emacs-pretty-speedbar): Add variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ba2916a463..3c8c201145 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -6975,6 +6975,32 @@ (define-public emacs-sqlite3-api
 SQLite C interface, but should satisfy most user's needs.")
     (license license:gpl3+)))
 
+(define-public emacs-pretty-speedbar
+  (let ((commit "56dc9f114fcc55843e182cde1fc9d7a14c261c6a")
+        (revision "0"))
+    (package
+      (name "emacs-pretty-speedbar")
+      (version (git-version "0.2" revision commit))
+      (source (origin
+                (uri (git-reference
+                      (url "https://github.com/kcyarn/pretty-speedbar")
+                      (commit commit)))
+                (method git-fetch)
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1hz67jhvg9n9d07lil6zqciqhh512k0fv54dl605p7vi704ma2ir"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list font-awesome))
+      (home-page "https://github.com/kcyarn/pretty-speedbar")
+      (synopsis "SVG icons for the Emacs Speedbar")
+      (description
+       "This package generates and implements appealing SVG icons for the
+Emacs Speedbar.  By default, it generates icons from the Font Awesome fontset.
+However, alternative fontsets may also be used, and the color of the icons may
+be customized.")
+      (license license:gpl3+))))
+
 (define-public emacs-sr-speedbar
   (let ((commit "77a83fb50f763a465c021eca7343243f465b4a47")
         (revision "0"))
-- 
2.39.1