GNU bug report logs - #61157
gnu: Add uwufetch.

Previous Next

Full log

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: "J. Sims via Guix-patches" via <guix-patches <at> gnu.org>
Cc: "J. Sims" <jtsims <at> protonmail.com>, 61157 <at> debbugs.gnu.org
Subject: Re: [bug#61157] gnu: Add uwufetch.
Date: Tue, 31 Jan 2023 15:19:45 +0100

Hello,

"J. Sims via Guix-patches" via <guix-patches <at> gnu.org> writes:

> This is a fun little fetch utility and I thought it might enjoy
> inclusion in Guix.

Thank you. Some comments follow.

> +    (build-system gnu-build-system)
> +    (arguments
> +     (list #:tests? #f ;no tests

Please add a newline character after "list".

> +           #:make-flags #~(list (string-append "DESTDIR="
> +                                               #$output)
> +                                (string-append "ETC_DIR="
> +                                               #$output "/etc")
> +                                (string-append "CC="
> +                                               #$(cc-for-target)))

Please also add a newline character after "flags". Every flag should fit
into a single line.

> +           #:phases (with-imported-modules '((guix build utils))

I don'tthink you need to import modules.

> +                                           #~(modify-phases %standard-phases
> +                                               (delete 'configure)
> +                                               (add-before 'build 'path-source-paths
> +                                                 (lambda _
> +                                                   (substitute* "uwufetch.c"
> +                                                     (("(/usr(/local)?)(.*;)"
> +                                                       all _ _ rest)
> +                                                      (string-append #$output
> +                                                                     rest)))))))))

You can move this below "#:phases" to drastically improve indentation.

> +    (native-inputs (list git))

Are you sure git is required as a native input? If it is, then this
should be `git-minimal' instead.


> +    (synopsis "Cutesie *fetch utility")

I think we should provide better than this synopsis. Maybe, according
to upstream's About,

  Meme system info tool based on Nyan/UwU trend 

> +    (description
> +     "UwUFetch is a system information tool in the lineage of @code{neofetch},
> +@code{pfetch}, @{hyfetch}, and the like. It prints ASCII art of your system's

I suggest to use Neofetch instead of @code{neofetch}, Pfetch instead of
@code{pfetch} and HyFetch instead of (mind the typo!) @code{hyfetch}.

> +logo as well as a summary of system information. UwUFetch's unique contribution
> +is the uwu-ification of various words used in the description. For example, Guix
> +become gUwUix.")

Sentences should be separated with two spaces.

> +    (license license:gpl3)))

License is actually GPL3+.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.