From unknown Sun Jun 22 17:15:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61151: 30.0.50; sqlite-more-p is confusing Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 14:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61151 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61151@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167500397124314 (code B ref -1); Sun, 29 Jan 2023 14:53:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Jan 2023 14:52:51 +0000 Received: from localhost ([127.0.0.1]:42549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM935-0006K6-0P for submit@debbugs.gnu.org; Sun, 29 Jan 2023 09:52:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:34128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM933-0006Jy-Cz for submit@debbugs.gnu.org; Sun, 29 Jan 2023 09:52:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM932-0000ln-9E for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 09:52:48 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pM92z-0007yA-78 for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 09:52:47 -0500 Received: by mail-wr1-x436.google.com with SMTP id t18so8940680wro.1 for ; Sun, 29 Jan 2023 06:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=upVzx6C++11nEdVDZ3vQWL5w+QqzpM7eZKXReJE0INU=; b=oZxh4f9tzPe2tqxQLCjRoyJdiR3Uz77P2zlrILo6CuyjVoPQtYSaA0cxnVLJJZwJ5T So6EB6tVv0JKKWfeMAFnV6wXX+YFybxOKN8/QvtOZkd7dS4jsggirBMaFOqWEF5lcISX 2kx2/OONnlHhOLQhfO2UP9mb9XgDfK9IakZ0KnH2FtXeshVafrQr/u301LpMlRjzrbAS EHRlWNPiQp37K1+tAsXyHH5UCHDHx7rHN31UqErE2uUeaP6PwupBOm7rB1xyoyxX/rzR LJ5FzNvddNzWsFvJdUiyNcsTlduPffTPZYP9qX/M2JI2ws3QdV/mdOAL4cG2HVJwKQSM hRtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=upVzx6C++11nEdVDZ3vQWL5w+QqzpM7eZKXReJE0INU=; b=PkVgSPLn/CqjAtS3UknU4Euyu1/vPu3FPl+TGsxzLOaoWbiy9151vcao9fEMzAfUPi Sv82umoqQSCL8/jFCqeOc29MkE4qewemHNIWYHe80U3AKzLFxFtKCyJRgU7nhLEzTVcJ uybl3Gi34LtBnyIKZlUNWRQpdA7/Q+HqKeVCXT8JuDvtdwa07kUep15wgPmK65onHh2c oh39j8kEHap9LGkaZD+Wz1oJc/hH7eiOqdMHQ5knqnpJP3lppeprgYW8xoSfO7nzbwE2 FNillmLcYtioBrBCU+8tW6T9f1q/yJayViwPfVzb1yho+ljLM8CFzHPyNEBY2y0g6RjX Ljzw== X-Gm-Message-State: AO0yUKWzdZVNjhe2sQJrDBO0jRRoZlCnQ7n7akEw3AKQ5/AYpL/oz4hW Vx7G/3PRC5rEyY31KRMnkzMEG3uH3HI= X-Google-Smtp-Source: AK7set9Ef9q6wlFgvdk36B58T7tWEK9a+eOI2yuGR7YX2OEy80ZFcIFionS7ohJn/3KAIPtC8F3ciQ== X-Received: by 2002:a5d:5908:0:b0:2bf:bccd:45bc with SMTP id v8-20020a5d5908000000b002bfbccd45bcmr14747217wrd.64.1675003963639; Sun, 29 Jan 2023 06:52:43 -0800 (PST) Received: from caladan ([185.127.214.178]) by smtp.gmail.com with ESMTPSA id a18-20020a5d5092000000b002bdd8f12effsm9230783wrt.30.2023.01.29.06.52.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 06:52:42 -0800 (PST) From: Helmut Eller Date: Sun, 29 Jan 2023 15:52:34 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=eller.helmut@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This code (let* ((db (sqlite-open)) (stmt (sqlite-select db "values ('a',0), ('b',1)" nil 'set)) (rows '())) (while (sqlite-more-p stmt) (push (sqlite-next stmt) rows)) rows) returns: (nil ("b" 1) ("a" 0)) I would expect: (("b" 1) ("a" 0)) I think it would be more natural, if sqlite-more-p would return false before sqlite-next returns nil the first time. Helmut In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.35, cairo version 1.16.0) of 2023-01-29 built on caladan Repository revision: 254c75fc2935e7edef079166d90b231278115a2f Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --with-xpm=ifavailable --with-jpeg=ifavailable --with-gif=ifavailable --with-tiff=ifavailable' Configured features: CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 GTK3 ZLIB From unknown Sun Jun 22 17:15:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61151: 30.0.50; sqlite-more-p is confusing Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 15:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61151 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Helmut Eller Cc: 61151@debbugs.gnu.org Received: via spool by 61151-submit@debbugs.gnu.org id=B61151.167500596130058 (code B ref 61151); Sun, 29 Jan 2023 15:26:02 +0000 Received: (at 61151) by debbugs.gnu.org; 29 Jan 2023 15:26:01 +0000 Received: from localhost ([127.0.0.1]:45217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM9ZB-0007of-2I for submit@debbugs.gnu.org; Sun, 29 Jan 2023 10:26:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:50034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM9Z9-0007oT-LU for 61151@debbugs.gnu.org; Sun, 29 Jan 2023 10:26:00 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM9Z4-0004B3-CZ; Sun, 29 Jan 2023 10:25:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=VssOzYlBv1lkz61VRp7k9K+tesxv5JHJfPunEUzfARM=; b=KSISouPrhBQ8 VYUzz3kXCBtk8ES0SQrR4k++IazTMqp3f8eLVyT3xmIH7Ft5To6iDHErY1HPVgDDTV2hWFWu1GTFC 8P+sK7cpa24wGqZLUSSIM5SRYfhWLWPzKRizi339px4iy0+UYXTN5/PB2rBJNX1XKyU8ElZ7CApZR 4vt3krlszq4II7234jOvhY0IglKzmDnjIuOjzzUkZH+K5EmCX4+AqnbZvbbLU9GmlMmRh2VqvoR5H 6Q1lHxfP2jIHYZnO8DIPANr6SW4cSAgbckf1HSF4iyMHBhRQh1SaKAFyKlLouRHnMbnNP557dmusY 47BHnldWzvuSXMzw8XE3sw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM9Z3-0000gJ-PZ; Sun, 29 Jan 2023 10:25:54 -0500 Date: Sun, 29 Jan 2023 17:25:44 +0200 Message-Id: <83mt61747b.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Helmut Eller on Sun, 29 Jan 2023 15:52:34 +0100) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Helmut Eller > Date: Sun, 29 Jan 2023 15:52:34 +0100 > > This code > > (let* ((db (sqlite-open)) > (stmt (sqlite-select db "values ('a',0), ('b',1)" nil 'set)) > (rows '())) > (while (sqlite-more-p stmt) > (push (sqlite-next stmt) rows)) > rows) > > returns: (nil ("b" 1) ("a" 0)) > > I would expect: (("b" 1) ("a" 0)) > > I think it would be more natural, if sqlite-more-p would return false > before sqlite-next returns nil the first time. I'm not sure I understand why you need sqlite-more-p here. sqlite-next returns nil when it hits the end, so it should be enough. If we document this fact in the doc string of sqlite-next, would that be good enough to satisfy your use cases? From unknown Sun Jun 22 17:15:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61151: 30.0.50; sqlite-more-p is confusing Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 16:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61151 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 61151@debbugs.gnu.org Received: via spool by 61151-submit@debbugs.gnu.org id=B61151.16750083171859 (code B ref 61151); Sun, 29 Jan 2023 16:06:02 +0000 Received: (at 61151) by debbugs.gnu.org; 29 Jan 2023 16:05:17 +0000 Received: from localhost ([127.0.0.1]:45254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMABA-0000Tv-VU for submit@debbugs.gnu.org; Sun, 29 Jan 2023 11:05:17 -0500 Received: from mail-wm1-f50.google.com ([209.85.128.50]:55808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMAB9-0000Tg-S8 for 61151@debbugs.gnu.org; Sun, 29 Jan 2023 11:05:16 -0500 Received: by mail-wm1-f50.google.com with SMTP id q8so6498740wmo.5 for <61151@debbugs.gnu.org>; Sun, 29 Jan 2023 08:05:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=EXFospkwvq4e2E8xJUlHbbGxKlW68dPMffQ2nkeag4g=; b=Uk9Vv1c0WK1kjUoHIoD3ktl4PR60H2+/TAiRREv2tWPXRg+CE+/l0Qivw51n+Lk5OL C6iI0rcfXxAOmV1wZysXY848N4DvGVLNo+NchyDjlZXDx5DYYeXeKnBSDg84Jr52C8fH FKen1BgTcOKy7bYaoFTuAis55LrhZ5gCm2N00btnvbnLJkpv54MGMhkhxQvtC5Jw0TRc fj0iQPpH8nxc5n7vDLmcV84tf7r+6eo+k84LYGyKwPaiy2lXVHT8C0BwTfiDLnxgoDel MKig4UYFrYkN+j3UBeDlTk/ycN9bMNr9SA+cBRkOhhQJLUNZ5Ur76nS2ZH2X7ePUBIkQ 2+QQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EXFospkwvq4e2E8xJUlHbbGxKlW68dPMffQ2nkeag4g=; b=hksCBw+L20bOKGOcEiXCoowYFsHDizQdBk1nmW+dNa6YyJU3WY9fonfgussmRJ9xg4 8lZjQd9EnSeWLft8X83UoTm7Ksy2sYxmPs3orYeUf/u3Ycl6GsctTJbyJGgpw4il+zvK fZlQGf50vX7MAHBsDfKc4IbN6lcqaPbLTxK02c8vqpnCPvFMmAxr2cCg8GJNyVLPoVbg eEhBSLGK/7TZSdX1F8zip/jGJWFLYnFTI5H02Ys44q5SyyCrX0Ce87KdvLjbHHlKvEdJ r4tonf+YKTKkgvhjgzvr9nbkRH4KC1gevrcynhA13X+nW9asbzNUqhKd/fMSRLT1sdA8 uo/g== X-Gm-Message-State: AFqh2koxq4G+bkVexnwKmJSGYGyBJe1xzINjUrM7YY4cFq38TYAcqjRa qJkvi4Mh/hUK/icu+L86KEtOLtJZVBM= X-Google-Smtp-Source: AMrXdXsyj7HikIWKxA1TTzZIMYG7CYzI/a8EijGX/2Q+ujSzjR+MIlYC6d6RIQPlZunlpWxO9Xh20A== X-Received: by 2002:a05:600c:3d16:b0:3d3:3deb:d916 with SMTP id bh22-20020a05600c3d1600b003d33debd916mr46836512wmb.4.1675008308977; Sun, 29 Jan 2023 08:05:08 -0800 (PST) Received: from caladan ([185.127.214.178]) by smtp.gmail.com with ESMTPSA id t1-20020a05600c41c100b003dc47d458cdsm4884337wmh.15.2023.01.29.08.05.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 08:05:08 -0800 (PST) From: Helmut Eller In-Reply-To: <83mt61747b.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Jan 2023 17:25:44 +0200") References: <83mt61747b.fsf@gnu.org> Date: Sun, 29 Jan 2023 17:05:07 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jan 29 2023, Eli Zaretskii wrote: > I'm not sure I understand why you need sqlite-more-p here. > sqlite-next returns nil when it hits the end, so it should be enough. > If we document this fact in the doc string of sqlite-next, would that > be good enough to satisfy your use cases? Yes, I guess it would be possible to get rid of sqlite-more-p. However, sqlite-next seems to return nil once, but then it starts over. E.g this (let* ((db (sqlite-open)) (stmt (sqlite-select db "values ('a',0), ('b',1)" nil 'set)) (rows '())) (list (sqlite-next stmt) (sqlite-next stmt) (sqlite-next stmt) (sqlite-next stmt))) returns: (("a" 0) ("b" 1) nil ("a" 0)) This "wrap around" behavior is strange. In summary, I think that sqlite-next should signal and error instead of returning nil. And sqlite-more-p should be used to detect the end of the stream. (Theoretically, sqlite-next could then also return zero length rows, though that's probably not needed in practice.) Helmut From unknown Sun Jun 22 17:15:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61151: 30.0.50; sqlite-more-p is confusing Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 16:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61151 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Helmut Eller Cc: 61151@debbugs.gnu.org Received: via spool by 61151-submit@debbugs.gnu.org id=B61151.167501092715324 (code B ref 61151); Sun, 29 Jan 2023 16:49:01 +0000 Received: (at 61151) by debbugs.gnu.org; 29 Jan 2023 16:48:47 +0000 Received: from localhost ([127.0.0.1]:45330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMArH-0003z5-4s for submit@debbugs.gnu.org; Sun, 29 Jan 2023 11:48:47 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMArG-0003yu-6A for 61151@debbugs.gnu.org; Sun, 29 Jan 2023 11:48:46 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMArA-0008SE-Po; Sun, 29 Jan 2023 11:48:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=qq29b8nl6HEQ6uDRf8GHOvHbOuhwUwmXvZcfgzmf0nU=; b=kdgF5nGQwfDg iM4RcOWA0E7uv+ZYHERl5TtaDHEb8F+sBedgb1rQ8Z9Il/GxniJFQlo52+pjgRBo8R5aGNwb+gSCl zGHbNXranDtXpvd41XaQRSQp0jxIJW4P61esaLid7tqng/jCxWiXaPamV+T1injxziCuw2CApFtTW ND8H50UEYV/zqEUvVcTkLDsLuwuj1stsshuhosH0Oc0SPZh9fBUgAsxY+ZbLisS6nUzuVFMj6BhKg TkUn9/UqsQu/Z+auka5JFPZLf33c/l56hx2ir+buD973/bjS6/EuGvK1KZ6ZlO/cBGXAoI0rlvPsi u79Y1TTHyZtIKruiVfb7Bw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMArA-0007YQ-9o; Sun, 29 Jan 2023 11:48:40 -0500 Date: Sun, 29 Jan 2023 18:48:31 +0200 Message-Id: <83edrd70dc.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Helmut Eller on Sun, 29 Jan 2023 17:05:07 +0100) References: <83mt61747b.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Helmut Eller > Cc: 61151@debbugs.gnu.org > Date: Sun, 29 Jan 2023 17:05:07 +0100 > > On Sun, Jan 29 2023, Eli Zaretskii wrote: > > > I'm not sure I understand why you need sqlite-more-p here. > > sqlite-next returns nil when it hits the end, so it should be enough. > > If we document this fact in the doc string of sqlite-next, would that > > be good enough to satisfy your use cases? > > Yes, I guess it would be possible to get rid of sqlite-more-p. > > However, sqlite-next seems to return nil once, but then it starts over. This should be easy to fix. > In summary, I think that sqlite-next should signal and error instead of > returning nil. I think we can only signal an error if sqlite-next is called again after it returned nil, otherwise it is not justified. But I'm not an expert on databases, so maybe I'm missing something. > And sqlite-more-p should be used to detect the end of > the stream. I don't think it's possible without trying to read. From unknown Sun Jun 22 17:15:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61151: 30.0.50; sqlite-more-p is confusing Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 18:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61151 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 61151@debbugs.gnu.org Received: via spool by 61151-submit@debbugs.gnu.org id=B61151.167501644024976 (code B ref 61151); Sun, 29 Jan 2023 18:21:02 +0000 Received: (at 61151) by debbugs.gnu.org; 29 Jan 2023 18:20:40 +0000 Received: from localhost ([127.0.0.1]:45361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMCIC-0006Um-Dv for submit@debbugs.gnu.org; Sun, 29 Jan 2023 13:20:40 -0500 Received: from mail-wm1-f43.google.com ([209.85.128.43]:46723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMCIA-0006UW-BF for 61151@debbugs.gnu.org; Sun, 29 Jan 2023 13:20:38 -0500 Received: by mail-wm1-f43.google.com with SMTP id m5-20020a05600c4f4500b003db03b2559eso6744003wmq.5 for <61151@debbugs.gnu.org>; Sun, 29 Jan 2023 10:20:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=/1OmrTXNLEqPvEEnWfQyZBE0Emv9EmDWPRnClii/3cU=; b=Ku6zpZz48hDU4Ob3yysc19yLxNZLhOggDpMTB/rrGoiHswWOeObJr/smogmWVD96bd oniEg5ddW1pX4tP8ImAqbTPqqKOiQo+FKBDjum7tbqJHt8U2jqcs43vfYrsXUcTcGBcv Io4PRGUOCkEC8mCBunmbyk1+xNfjfmB3+n7dK/UmEKocwXkOTlqCoEMycKIH5ThrPD8I QuidqsY7y/aelJaZyCYD5qTDvIja4gMHyT2JokDFe6PEG1Saz7CI9n/qJMnNvb82mqMi /W8OeSDN1XYBX9bWGxuo0Bn2SnUsIxNLsZCVaTph1DQnnMaXpvy34GcaMj+X0SrYxXts 761w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/1OmrTXNLEqPvEEnWfQyZBE0Emv9EmDWPRnClii/3cU=; b=d3DwFc0MutVRiygYB1I/GN93uZymGs3RZ+L2YP4Ym+Z4peFH243xqAnxpoSM4B/0OB VyZn/MVQojT1w0xhJ5wu8laRER0ba43on+vG8bW0MTq7L3QzCmJVpNl1GXS6q1la2HIk fC65vx6rU7v/N8LWN3KnSgECXmUb4ofWZDiQrrGCGSs9UkDQ3ZtZWc/nR98ny9MT8eB8 207Dz5KGrC7QoUa2y7jvp1yDu/Ou9hMWaQ0e87YPWjht7LRQoUiV4JwScLaLS32bXJXJ mnfugAMvHFlxDJvVI6U/U6rP9qEaBld4nk6SdOMn5qLdT5zUHZib2zJEfrCUq3u74EqV YGWg== X-Gm-Message-State: AFqh2ko0cqOks4p8sNnc/f/cP9M4+ZdT3K2+jzkOTnwA/LK3F+r+phh7 0oOhzOKptXcXCl35GyjNW4b38M12/NI= X-Google-Smtp-Source: AMrXdXu7orPdVM7W2WI5S9eOJwJ45sB42SrmwGPEu9cmVvQJbJi1a2yzOSwPaEh/4N98VqKzm16oVA== X-Received: by 2002:a05:600c:3b1b:b0:3da:11d7:dba3 with SMTP id m27-20020a05600c3b1b00b003da11d7dba3mr45598773wms.5.1675016432328; Sun, 29 Jan 2023 10:20:32 -0800 (PST) Received: from caladan ([185.127.214.178]) by smtp.gmail.com with ESMTPSA id n23-20020a05600c3b9700b003dab77aa911sm16281668wms.23.2023.01.29.10.20.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 10:20:31 -0800 (PST) From: Helmut Eller In-Reply-To: <83edrd70dc.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Jan 2023 18:48:31 +0200") References: <83mt61747b.fsf@gnu.org> <83edrd70dc.fsf@gnu.org> Date: Sun, 29 Jan 2023 19:20:30 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jan 29 2023, Eli Zaretskii wrote: >> However, sqlite-next seems to return nil once, but then it starts over. > > This should be easy to fix. The documentation[1] also says: SQLITE_DONE means that the statement has finished executing successfully. sqlite3_step() should not be called again on this virtual machine without first calling sqlite3_reset() to reset the virtual machine back to its initial state. So this would seems like prudent fix. >> In summary, I think that sqlite-next should signal and error instead of >> returning nil. > > I think we can only signal an error if sqlite-next is called again > after it returned nil, otherwise it is not justified. But I'm not an > expert on databases, so maybe I'm missing something. > >> And sqlite-more-p should be used to detect the end of >> the stream. > > I don't think it's possible without trying to read. If we don't change the way the API works, then maybe the documentation should mention that the proper way to iterate over the results is a bit unusual. E.g.: (let* ((db (sqlite-open)) (stmt (sqlite-select db "values ('a',0), ('b',1)" nil 'set)) (rows '()) row) (while (progn (setq row (sqlite-next stmt)) (sqlite-more-p stmt)) (push row rows)) rows) And perhaps provide a function like sqlite-for-each that hides this peculiarity. Helmut [1] https://sqlite.org/c3ref/step.html From unknown Sun Jun 22 17:15:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61151: 30.0.50; sqlite-more-p is confusing Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 18:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61151 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Helmut Eller Cc: 61151@debbugs.gnu.org Received: via spool by 61151-submit@debbugs.gnu.org id=B61151.167501787527338 (code B ref 61151); Sun, 29 Jan 2023 18:45:01 +0000 Received: (at 61151) by debbugs.gnu.org; 29 Jan 2023 18:44:35 +0000 Received: from localhost ([127.0.0.1]:45381 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMCfK-00076s-Tl for submit@debbugs.gnu.org; Sun, 29 Jan 2023 13:44:35 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMCfJ-00076e-7x for 61151@debbugs.gnu.org; Sun, 29 Jan 2023 13:44:33 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMCfD-0000NL-Ma; Sun, 29 Jan 2023 13:44:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=gFJWWhOg2mw5tyajwa4HiyOa+9/ydvPwG3fQ+wihPAw=; b=kRKG+fiZNSMM lQHbhfj1NpF/FGfCswiLv2QrAf6KSvzuK4X7x9f4rDPNvhJDxhBJVCyrS/HxzcdobNCjDxiWnVMHo kb4X8nCyPoKhR670zV2plvfg2Ka1VwxP68L8UfBu0u3dTmr+LCe8O+tzkt1jjcqF1Y1g5UKb+8O4P MQay8bi5ribnEVrBEhZTfmQIzmtc2xiGr929BXN5Wm+BzzKrOqumuvyFMrgbRejAf1k2xfG+NtOLr EGuHVQOgf0wVkT+2ZU5PVcvF8TTqDd9cc+3gY/Ne6MKsKF8X50fpUOKpufN0eLY75bHurUVaEXDYU kGjCNKj9MJy5aVk5/c5Ukw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMCfC-0003kR-W6; Sun, 29 Jan 2023 13:44:27 -0500 Date: Sun, 29 Jan 2023 20:44:19 +0200 Message-Id: <834js96v0c.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Helmut Eller on Sun, 29 Jan 2023 19:20:30 +0100) References: <83mt61747b.fsf@gnu.org> <83edrd70dc.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Helmut Eller > Cc: 61151@debbugs.gnu.org > Date: Sun, 29 Jan 2023 19:20:30 +0100 > > On Sun, Jan 29 2023, Eli Zaretskii wrote: > > >> However, sqlite-next seems to return nil once, but then it starts over. > > > > This should be easy to fix. > > The documentation[1] also says: > > SQLITE_DONE means that the statement has finished executing > successfully. sqlite3_step() should not be called again on this > virtual machine without first calling sqlite3_reset() to reset the > virtual machine back to its initial state. > > So this would seems like prudent fix. What is "this"? Signaling an error after sqlite-next returns nil? Or something else? > If we don't change the way the API works, then maybe the documentation > should mention that the proper way to iterate over the results is a bit > unusual. E.g.: > > (let* ((db (sqlite-open)) > (stmt (sqlite-select db "values ('a',0), ('b',1)" nil 'set)) > (rows '()) > row) > (while (progn (setq row (sqlite-next stmt)) > (sqlite-more-p stmt)) > (push row rows)) > rows) > > And perhaps provide a function like sqlite-for-each that hides this > peculiarity. Let me think about this. From unknown Sun Jun 22 17:15:27 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61151: 30.0.50; sqlite-more-p is confusing Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 30 Jan 2023 06:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61151 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 61151@debbugs.gnu.org Received: via spool by 61151-submit@debbugs.gnu.org id=B61151.16750618383656 (code B ref 61151); Mon, 30 Jan 2023 06:58:02 +0000 Received: (at 61151) by debbugs.gnu.org; 30 Jan 2023 06:57:18 +0000 Received: from localhost ([127.0.0.1]:46165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMO6Q-0000wt-BB for submit@debbugs.gnu.org; Mon, 30 Jan 2023 01:57:18 -0500 Received: from mail-wr1-f54.google.com ([209.85.221.54]:35348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMO6O-0000wd-NG for 61151@debbugs.gnu.org; Mon, 30 Jan 2023 01:57:17 -0500 Received: by mail-wr1-f54.google.com with SMTP id y1so10064363wru.2 for <61151@debbugs.gnu.org>; Sun, 29 Jan 2023 22:57:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+zWbWQ/TAqINe62K5EXDO2RJiqYvwlg9pv/VsA76NaA=; b=NGA1R6XyqDPJcYhrmvAsj6wLjstI7WMSR1br4OeIfSv4AQjUxa0Js9QVjiTaq3hHkw rTQUDrnPxnIPr2SNTKpjYVJfkaI4nfQm4g5cUXCXL+wcA40BcKOvQOMoqZ8rX8mD1UWI eAVQgde45wDppaPxOAI7R2NC7eTxFPFCsqW6n4qAYkxi3ndSfi4Q6UMAmihcQTn3SRt+ y1cRUfnNCsUVt9mHehfrApK3Bgtb+vC8ndFfmgU4E682/lS9QMFsBIa0TTabpjaVOqhT jco8o4KGvF5c41+cwmGiFfkmMCZiIJGPgaV9NKRxzRhTe1bZrrB9wFMkNTbYA4b90veH /3KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+zWbWQ/TAqINe62K5EXDO2RJiqYvwlg9pv/VsA76NaA=; b=PevJa7FxzvqBqvHmV6Vy4Tz+2ERbPCAfTY1fiugTXijf+nYxR2TpPMq5a4pfK487GR 0M6GXsUREZv4SaDWQ0kbobpwkfiojdwXpl9LnRbZG7RMXHu8CKWf4quEgLGi80qQVqE5 iSqp4a3TJ0T6DlSjn7acBC3djwJ3705eVfmIT8L1OjlXaTo3ys+cXLi3K/NIH1cE8YXD Fd2wPKWhlAGnw9fqG3Hte0LrOs015IfG2t4V5FCXfHBp5DvR7ijghX7wKnZSXUxnFNFv LQxGC5T/ar2gIkphGRPcKyqOyzRe5BtzOsqCd54bZ8KmO0bhrFK6pMRwyInQp80KdXvo mRiQ== X-Gm-Message-State: AFqh2komtlkYuT+Xwh7/a2gGxXIQRX22O4ke3sJXLe2pvRnlif5Dl1XW ROXr91jpTcRhd6Zt9zBEIciI2du3KDU= X-Google-Smtp-Source: AMrXdXuN4BmSZMdFWKvkQB7Ag4gjb66LVp9nTwJXENmrscTYdY1J53FXD4vRVBzOHTR1uP+i06Bs6g== X-Received: by 2002:adf:e782:0:b0:2be:5ca0:a7f9 with SMTP id n2-20020adfe782000000b002be5ca0a7f9mr30556801wrm.33.1675061830640; Sun, 29 Jan 2023 22:57:10 -0800 (PST) Received: from caladan ([185.127.214.178]) by smtp.gmail.com with ESMTPSA id g11-20020a5d488b000000b002be5bdbe40csm12661803wrq.27.2023.01.29.22.57.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 22:57:10 -0800 (PST) From: Helmut Eller In-Reply-To: <834js96v0c.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Jan 2023 20:44:19 +0200") References: <83mt61747b.fsf@gnu.org> <83edrd70dc.fsf@gnu.org> <834js96v0c.fsf@gnu.org> Date: Mon, 30 Jan 2023 07:57:09 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, Jan 29 2023, Eli Zaretskii wrote: >> On Sun, Jan 29 2023, Eli Zaretskii wrote: >> >> >> However, sqlite-next seems to return nil once, but then it starts over. >> > >> > This should be easy to fix. >> >> The documentation[1] also says: >> >> SQLITE_DONE means that the statement has finished executing >> successfully. sqlite3_step() should not be called again on this >> virtual machine without first calling sqlite3_reset() to reset the >> virtual machine back to its initial state. >> >> So this would seems like prudent fix. > > What is "this"? Signaling an error after sqlite-next returns nil? Or > something else? I meant to not call sqlite3_step again after that it has returned SQLITE_DONE. Either by returning nil or signaling an error. Helmut From unknown Sun Jun 22 17:15:27 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Helmut Eller Subject: bug#61151: closed (Re: bug#61151: 30.0.50; sqlite-more-p is confusing) Message-ID: References: <83edr7x2z7.fsf@gnu.org> X-Gnu-PR-Message: they-closed 61151 X-Gnu-PR-Package: emacs Reply-To: 61151@debbugs.gnu.org Date: Thu, 02 Feb 2023 19:50:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1675367402-27350-1" This is a multi-part message in MIME format... ------------=_1675367402-27350-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61151: 30.0.50; sqlite-more-p is confusing which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61151@debbugs.gnu.org. --=20 61151: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61151 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1675367402-27350-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61151-done) by debbugs.gnu.org; 2 Feb 2023 19:49:07 +0000 Received: from localhost ([127.0.0.1]:35846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNfZy-00075k-PX for submit@debbugs.gnu.org; Thu, 02 Feb 2023 14:49:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNfZx-000755-16 for 61151-done@debbugs.gnu.org; Thu, 02 Feb 2023 14:49:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNfZr-0005r4-8L; Thu, 02 Feb 2023 14:48:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=8nwqYqqSLzA359QyPllODRU9Bvmr59jkx/3SlV/mU0Q=; b=rbivmJNr35lG Q8UDKQM+1G1/+2GFEPuFgaaBiWv/I/VHA1DQGBNCuDzmKMVT80f5x+pLDtX7U/jAK7FyylbbxUJr/ rZ7ykCh5O82dFcX/zL/qzy4xVYUmqozYMTIywzptoh/g7JkiR5NnKm77z/isI6begFNm9Z1Vk2TCk lg9xi1z9VdBLYGzN1PssENWp3uCwBAxxHe2aTqGrNfTjYeiN5nkzf+YGLAjUNl0z8XaKVn7XQ/6re rcrJREaG24jEnqxiscGH1fozrPZRq43HDNTIbifUa+1Jg9tUyLLgoTqC0be+k2YBAOiyrQ+YCXSAt 1wljSWzinEVNn86CxU0DSQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNfZq-00031t-0n; Thu, 02 Feb 2023 14:48:58 -0500 Date: Thu, 02 Feb 2023 21:49:00 +0200 Message-Id: <83edr7x2z7.fsf@gnu.org> From: Eli Zaretskii To: Helmut Eller In-Reply-To: (message from Helmut Eller on Mon, 30 Jan 2023 07:57:09 +0100) Subject: Re: bug#61151: 30.0.50; sqlite-more-p is confusing References: <83mt61747b.fsf@gnu.org> <83edrd70dc.fsf@gnu.org> <834js96v0c.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61151-done Cc: 61151-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Helmut Eller > Cc: 61151@debbugs.gnu.org > Date: Mon, 30 Jan 2023 07:57:09 +0100 > > On Sun, Jan 29 2023, Eli Zaretskii wrote: > > >> On Sun, Jan 29 2023, Eli Zaretskii wrote: > >> > >> >> However, sqlite-next seems to return nil once, but then it starts over. > >> > > >> > This should be easy to fix. > >> > >> The documentation[1] also says: > >> > >> SQLITE_DONE means that the statement has finished executing > >> successfully. sqlite3_step() should not be called again on this > >> virtual machine without first calling sqlite3_reset() to reset the > >> virtual machine back to its initial state. > >> > >> So this would seems like prudent fix. > > > > What is "this"? Signaling an error after sqlite-next returns nil? Or > > something else? > > I meant to not call sqlite3_step again after that it has returned > SQLITE_DONE. Either by returning nil or signaling an error. I went with the former. I also documented that it returns nil when the statement finishes execution. ------------=_1675367402-27350-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Jan 2023 14:52:51 +0000 Received: from localhost ([127.0.0.1]:42549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM935-0006K6-0P for submit@debbugs.gnu.org; Sun, 29 Jan 2023 09:52:51 -0500 Received: from lists.gnu.org ([209.51.188.17]:34128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM933-0006Jy-Cz for submit@debbugs.gnu.org; Sun, 29 Jan 2023 09:52:49 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM932-0000ln-9E for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 09:52:48 -0500 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pM92z-0007yA-78 for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 09:52:47 -0500 Received: by mail-wr1-x436.google.com with SMTP id t18so8940680wro.1 for ; Sun, 29 Jan 2023 06:52:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=upVzx6C++11nEdVDZ3vQWL5w+QqzpM7eZKXReJE0INU=; b=oZxh4f9tzPe2tqxQLCjRoyJdiR3Uz77P2zlrILo6CuyjVoPQtYSaA0cxnVLJJZwJ5T So6EB6tVv0JKKWfeMAFnV6wXX+YFybxOKN8/QvtOZkd7dS4jsggirBMaFOqWEF5lcISX 2kx2/OONnlHhOLQhfO2UP9mb9XgDfK9IakZ0KnH2FtXeshVafrQr/u301LpMlRjzrbAS EHRlWNPiQp37K1+tAsXyHH5UCHDHx7rHN31UqErE2uUeaP6PwupBOm7rB1xyoyxX/rzR LJ5FzNvddNzWsFvJdUiyNcsTlduPffTPZYP9qX/M2JI2ws3QdV/mdOAL4cG2HVJwKQSM hRtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=upVzx6C++11nEdVDZ3vQWL5w+QqzpM7eZKXReJE0INU=; b=PkVgSPLn/CqjAtS3UknU4Euyu1/vPu3FPl+TGsxzLOaoWbiy9151vcao9fEMzAfUPi Sv82umoqQSCL8/jFCqeOc29MkE4qewemHNIWYHe80U3AKzLFxFtKCyJRgU7nhLEzTVcJ uybl3Gi34LtBnyIKZlUNWRQpdA7/Q+HqKeVCXT8JuDvtdwa07kUep15wgPmK65onHh2c oh39j8kEHap9LGkaZD+Wz1oJc/hH7eiOqdMHQ5knqnpJP3lppeprgYW8xoSfO7nzbwE2 FNillmLcYtioBrBCU+8tW6T9f1q/yJayViwPfVzb1yho+ljLM8CFzHPyNEBY2y0g6RjX Ljzw== X-Gm-Message-State: AO0yUKWzdZVNjhe2sQJrDBO0jRRoZlCnQ7n7akEw3AKQ5/AYpL/oz4hW Vx7G/3PRC5rEyY31KRMnkzMEG3uH3HI= X-Google-Smtp-Source: AK7set9Ef9q6wlFgvdk36B58T7tWEK9a+eOI2yuGR7YX2OEy80ZFcIFionS7ohJn/3KAIPtC8F3ciQ== X-Received: by 2002:a5d:5908:0:b0:2bf:bccd:45bc with SMTP id v8-20020a5d5908000000b002bfbccd45bcmr14747217wrd.64.1675003963639; Sun, 29 Jan 2023 06:52:43 -0800 (PST) Received: from caladan ([185.127.214.178]) by smtp.gmail.com with ESMTPSA id a18-20020a5d5092000000b002bdd8f12effsm9230783wrt.30.2023.01.29.06.52.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 06:52:42 -0800 (PST) From: Helmut Eller To: bug-gnu-emacs@gnu.org Subject: 30.0.50; sqlite-more-p is confusing Date: Sun, 29 Jan 2023 15:52:34 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=eller.helmut@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This code (let* ((db (sqlite-open)) (stmt (sqlite-select db "values ('a',0), ('b',1)" nil 'set)) (rows '())) (while (sqlite-more-p stmt) (push (sqlite-next stmt) rows)) rows) returns: (nil ("b" 1) ("a" 0)) I would expect: (("b" 1) ("a" 0)) I think it would be more natural, if sqlite-more-p would return false before sqlite-next returns nil the first time. Helmut In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.35, cairo version 1.16.0) of 2023-01-29 built on caladan Repository revision: 254c75fc2935e7edef079166d90b231278115a2f Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: Debian GNU/Linux 11 (bullseye) Configured using: 'configure --with-xpm=ifavailable --with-jpeg=ifavailable --with-gif=ifavailable --with-tiff=ifavailable' Configured features: CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG LIBSELINUX LIBSYSTEMD LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 GTK3 ZLIB ------------=_1675367402-27350-1--