From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 08:44:57 2023 Received: (at submit) by debbugs.gnu.org; 29 Jan 2023 13:44:57 +0000 Received: from localhost ([127.0.0.1]:42455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM7zM-0004RY-Qx for submit@debbugs.gnu.org; Sun, 29 Jan 2023 08:44:57 -0500 Received: from lists.gnu.org ([209.51.188.17]:50632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM7zL-0004RQ-I6 for submit@debbugs.gnu.org; Sun, 29 Jan 2023 08:44:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM7zL-0001eu-03 for bug-gnu-emacs@gnu.org; Sun, 29 Jan 2023 08:44:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM7zK-00058q-NX; Sun, 29 Jan 2023 08:44:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:Subject:To:From:Date:in-reply-to: references; bh=u768lsA6f8ysi+rMH7siWq28+tCt0OISJwRfsHHJAkc=; b=lntdSzbznd2ZxG 3Sqip6MWeevU752mLQJ+LY1BL+QA5aR7n1i3bYlp++59rP/rfVLKk61Fy5ovX0fZZbdKhip/+milg B4n0lk6n5DMN5Tas3bxfu56OtkYTCPWFEengeYZlSDqnKF0k+gz/VTFHv/QgUPvjQ/x5Odw3rRfN1 FOjDVe5gPYpX2E9bH4s5ZuuT4g4uzJqXA1Asy1FVG11E7UTsjLJQADxIJIhLZpkyknZd+FI8bhr2h cxbu4Iek1yT+iWuI7u6YaOadhiUnPc6EvZaJdYzQ5zqg6bxLDgkFvYSakaWcPe0QaG4mmxVWSrKi8 zCITFkutK53oeKaiQbiQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pM7zK-0007FN-7L; Sun, 29 Jan 2023 08:44:54 -0500 Date: Sun, 29 Jan 2023 15:44:44 +0200 Message-Id: <83wn5578vn.fsf@gnu.org> From: Eli Zaretskii To: bug-gnu-emacs@gnu.org Subject: 29.0.60; keymap-local-set rejects key sequences MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) To reproduce: emacs -Q M-x keymap-local-set C-c . forward-line RET Observe the error message: [3 46] is not a valid key definition; see ‘key-valid-p’ (The error message comes from keymap--check.) To type the key sequence, I actually pressed Ctrl and typed 'c', then released Ctrl and typed '.'. Isn't that what one is supposed to use? So the above basically makes keymap-local-set useless, or am I missing something? The following does work: M-: (keymap-local-set "C-c ." 'forward-line) RET However, I could find no way of typing the string "C-c ." at the prompt of keymap-local-set. In GNU Emacs 29.0.60 (build 259, i686-pc-mingw32) of 2023-01-29 built on HOME-C4E4A596F7 Repository revision: b73539832d9c4e802925cb8f261a13473da383b3 Repository branch: emacs-29 Windowing system distributor 'Microsoft Corp.', version 5.1.2600 System Description: Microsoft Windows XP Service Pack 3 (v5.1.0.2600) Configured using: 'configure -C --prefix=/d/usr --with-wide-int --enable-checking=yes,glyphs 'CFLAGS=-O0 -gdwarf-4 -g3'' Configured features: ACL GIF GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBXML2 MODULES NOTIFY W32NOTIFY PDUMPER PNG RSVG SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XPM ZLIB Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads w32notify w32 lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 42883 10204) (symbols 48 6278 0) (strings 16 16568 2962) (string-bytes 1 399068) (vectors 16 9325) (vector-slots 8 146723 13332) (floats 8 24 24) (intervals 40 293 123) (buffers 888 11)) From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 09:35:32 2023 Received: (at 61149) by debbugs.gnu.org; 29 Jan 2023 14:35:32 +0000 Received: from localhost ([127.0.0.1]:42505 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM8mK-0005mA-7m for submit@debbugs.gnu.org; Sun, 29 Jan 2023 09:35:32 -0500 Received: from mout.gmx.net ([212.227.17.22]:59429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM8mH-0005lw-Pr for 61149@debbugs.gnu.org; Sun, 29 Jan 2023 09:35:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1675002923; bh=D2p/zEb/FSvJjJaQMgzjWWWnQ+SHok9Y+eABn7Fel+s=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=o6e2yzHdylKHaFJY3IZg3BWNxc1qEcpI9tQvLVXjB+xq/v6Rrd18B4H+jWvbltTFm 1qBwSMgZV3CDTRY8V/6M97ZRQwIc0u3fTJEH8WFqxzstfeQ3oBselGGAZvgstB2l2z U9Er/BU7I0eYlovMPDfsrGS5PmKfE7are+OV2iG8E0xdBOdSRO+34acsP4pxC90Q86 OurWlC4Tf+UHXNOmpxjpJCJZrsCzPOT+MvLOU63DFLfhLJ2ixJdpl3snbevJfnxKAZ 8XKBtwVEk+QeijVMYXLwCdce3s140zt4DIoc6+h90jyziHew9UlLy5/DcBEGjy71cE 9OVECjp72TZkw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([89.246.36.185]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MirjY-1ohJqp0Ujs-00eyBm; Sun, 29 Jan 2023 15:35:23 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#61149: 29.0.60; keymap-local-set rejects key sequences In-Reply-To: <83wn5578vn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 29 Jan 2023 15:44:44 +0200") References: <83wn5578vn.fsf@gnu.org> Date: Sun, 29 Jan 2023 15:35:22 +0100 Message-ID: <875ycpbe8l.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:QepVc5R/UV2zHpPNmco2ke1mahGbGFH6FW4MxLeNG0l0WImlT5A betIibg5noZ84hSQPumxrjbACLnYlOSUhtmStwgCTf+fPqZ8f7+NoOia85Ni5+0JYXuihWj EShn+19Jr1bTv3QlGpKm5OctOTVnJOz3jlSJRMBzR0IeH3vxG5RMfPgBhfbtp9tb5nJZA7s qqyzxI6+s0tUpmt6viutg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:0M061x6RbJY=;Jztb6dxdKZMzcGIDL/icJ25YOCn 5W1AKkRb5MLZatrwBzCNhHVCCoDXHnYuHB8+q72ZU8UCJhvipab5w/I4ocFJ76e0Oyj7u4DfL OVmUYs3dwO+zWIK0pPdmyy6TMfkkV0tZmY+R7NON//EyaOIhqkMdpXoo8t34s/VfnkzfaN18t tRJfLZyldYc3LVPlCAMb9j7JyeXYG1hLSaTiwYY+ehWESgMN4zvV9i///fh55pTvIs3/BqFxB ftIc/Oc76Sb5GlPmnLIbC6VB9cQ/540/QYZsk6BA/Y5/KtLMqHo0N6CavYj9+Fp+/S+m92dIq kWF9S3pVftXyV1aR1YNU20/xH3kV1pE+lwJAR+JQGOypv0RQNSy9glEPssNr1uTRKuMRkTucW wBm9UMrwL8OgeBwN8xDVvsJSrwDsR4lQLqeo20arwFr2LwMEiAxQ0IDyUGVqkkL66nqISfEcg UGQGRlYbTEm7ZUWkFj/E0fgS/JWorXLcy5LeYiRr43GM/baihfR81GIzrA6OP7qzHjqWda2f+ 08sGp6JEz4oQ2ezwNnxRc73USxa2QzgBM1kBsYKZnXHZ4YKtIeqZergOBehdf33dHuKOZWyCY QBl0jrZjrNAu4Qo24bnFhvTCoy3vxOKKkgIGcRs4ZJJDMAj5gpFywDGScM+ZXyJX9eF811yFF 3YPj0qoXx6xx+EuuiN75rCNwwYuKJr9GzNobWpKMJ60fYiRUvFk7Lj9naleer2U9bhcX8lU/x Rx5uWAyXNMbF/3hrLV//Yh2zbaCcZ5hThabQGou3NghI6/y9E2ZNHWGW1Y12D3csbuuSgqzxh +qDO72T7eJRV7I38XtJzloELCJnkA7gfO+ik5/OoNN6k5QfFm39ag+PjV9CGEQVnkqi5YNC4L VpxgZWyej39muYQXDY4RhJmTquru48jekliPWDrAUxe2lyGTeGhNJaYau7jzaqyizCqjEas+N Wuv5Ig== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61149 Cc: 61149@debbugs.gnu.org, Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun, 29 Jan 2023 15:44:44 +0200 Eli Zaretskii wrote: > To reproduce: > > emacs -Q > M-x keymap-local-set > C-c . > forward-line RET > > Observe the error message: > > [3 46] is not a valid key definition; see =E2=80=98key-valid-p=E2=80=99 > > (The error message comes from keymap--check.) > > To type the key sequence, I actually pressed Ctrl and typed 'c', then > released Ctrl and typed '.'. Isn't that what one is supposed to use? > > So the above basically makes keymap-local-set useless, or am I missing > something? The following does work: > > M-: (keymap-local-set "C-c ." 'forward-line) RET > > However, I could find no way of typing the string "C-c ." at the > prompt of keymap-local-set. This patch seems to DTRT: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: keymap-local-set patch diff --git a/lisp/keymap.el b/lisp/keymap.el index 791221f2459..9643dce5f9c 100644 --- a/lisp/keymap.el +++ b/lisp/keymap.el @@ -95,7 +95,8 @@ keymap-local-set cases is shared with all other buffers in the same major mode." (declare (compiler-macro (lambda (form) (keymap--compile-check key) form))) (interactive "KSet key locally: \nCSet key %s locally to command: ") - (let ((map (current-local-map))) + (let ((map (current-local-map)) + (key (key-description key))) (unless map (use-local-map (setq map (make-sparse-keymap)))) (keymap-set map key command))) --=-=-= Content-Type: text/plain Steve Berman --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 10:28:54 2023 Received: (at 61149) by debbugs.gnu.org; 29 Jan 2023 15:28:54 +0000 Received: from localhost ([127.0.0.1]:45223 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM9bx-0007t9-Nb for submit@debbugs.gnu.org; Sun, 29 Jan 2023 10:28:54 -0500 Received: from mout.gmx.net ([212.227.15.15]:47083) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM9bv-0007sv-40 for 61149@debbugs.gnu.org; Sun, 29 Jan 2023 10:28:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1675006125; bh=HvaVjXGK8Cca9gXvvWo/U80uDFwZxotvlC/iqRYjVsk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Hki6MFtpRZ3tX7WCCk52l/3zpGhDeWbXgjoyMLWd+vFQxo6DkOTqzqPwgupRgr2Tj 3/r7azsOgjubSQqyJKfOjjoJC2FpxYSQBUA/K9luWpcGkWJaSBL60PuY04nqud96ei usW5Tm1AtmV/ZvbrIhfj6cTzmOq9/XVI45o5X77t413/deDWbUFWGn0MIQn9UX8MiR RKtWahkG0cW5RehkHDcAhOGOiJQK0AhTW7ehmFM2A8DwDRvYRB5thpt1uN/5Mwluyb YvmV8scsGCpWc7kSSHTEXexMQw3Qn7vOEyY8Ze5+/iucSRRdPgXkbYklwLGD76MNhf 2uz8XoaQ2oszQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([89.246.36.185]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N0oFz-1oQ3HV3sfd-00wiKj; Sun, 29 Jan 2023 16:28:44 +0100 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#61149: 29.0.60; keymap-local-set rejects key sequences In-Reply-To: <875ycpbe8l.fsf@rub.de> (Stephen Berman's message of "Sun, 29 Jan 2023 15:35:22 +0100") References: <83wn5578vn.fsf@gnu.org> <875ycpbe8l.fsf@rub.de> Date: Sun, 29 Jan 2023 16:28:44 +0100 Message-ID: <871qndbbrn.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:5ADZd2wm2Pxk4aEYKyECIOLF9VlXGNiwfPJy2MkJxAmkjFVzCzX kajkOmfyeWp5YCV8YTv94kYC5L+3RUZhSMVsa0xQFPJjgkZK6gB0XooLzEGbRj69t+e6ON6 QXyV0VIVK6N/9+Pyw6a6/lNh+DixiOob4quA+fQwAaNLGfm2wF+d9sryKk8VKJZJ1qip0Ig D4WYwBqvU6JcSNAMV/a8Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Cj4nIXHTdaA=;ubBFzYlIVCc6xGNEfLq0L6mUfIf YWYbyGke47JE3bfLN3YkoqS1P4R586cXiqVM2cWfDxCF81ast6w1nk1qMbOsegeEwhVH2wFyp 6s5q65iRMwPR7+YuoDmTMd43huA4eS08yTlL7RZJoQhA/BBAGPC8HO951bDxNMnJoECR/JInH W9UnfIItjOfLR90ljUH1u3LOMet6PtbLAr6+MMDXoUaAsczcFQISwaOHiVzI3AsPH5vMD7O2+ RcpFycTUkBLbhM0sLWBcuXRFoBEURsvQoJOlYLVRU1W9KqNt7w7Ip16kcJMtyPiGBZfCqqYcA 6KCnMj6KJDIFrJPtjMlwEQ2euvqBig1UZv9CC+QLp0EcbQilgTT04G83PDsryZGxu+hSGWTJa +LpbJ6tUuYPX9hNwilGmYoP5ds4RDYe5md5aLZnued/6+LC3U5f9AvJuAuCckuIQNii25nPPu QizONptd2+3PEczxqk5rz9FXNNhGFNdJ2cBIA/CEz9s+WuUq48PpFP7Cxg7jfEISZOPkJZgsa V8LQNjDDZCeyv6cYSfxi+tNINA8zFm9EcQQgohd4w/LWz6hJV0yreyvQsM7JjcQ4VDYRZA/kT 9FsaN9p7fy0AMvr4y30dTTEP8WaCqsWtRNDjAsW40/6tEV+7qARyeB+DnPh/5YiLCF0jTZeIW DRokXcluKDuRw841MY8P7dLBYM+53Tjry/7qkECmkeJ9WXDUfU9mBFB0NWTR+oHgf2QIbMbiw IRmwiRhYnfh1ZKvTuhcRfbF0VjF1g5QiFEY2qKCt/TJQ44pmXaTa/Uy8mV3fTrZSj/HpaZ1eU Uo331utoTYxqxQNe4EX+9H4QC2IInGfaRnSU7HGQQJ2ysSHHqgnmvHDabHKSqMKWnIpUS+aHB LjvjfNImBjQioGP8M1yNe7u/wZPXjUZHXVTyybdxwSRfAg/eTwtE7OeLKjwD/Pi0IhyNxrk/C iUUcyT5deaoAb6cYnX2edDLUoFo= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61149 Cc: 61149@debbugs.gnu.org, Robert Pluim X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sun, 29 Jan 2023 15:35:22 +0100 Stephen Berman = wrote: > On Sun, 29 Jan 2023 15:44:44 +0200 Eli Zaretskii wrote: > >> To reproduce: >> >> emacs -Q >> M-x keymap-local-set >> C-c . >> forward-line RET >> >> Observe the error message: >> >> [3 46] is not a valid key definition; see =E2=80=98key-valid-p=E2=80=99 >> >> (The error message comes from keymap--check.) >> >> To type the key sequence, I actually pressed Ctrl and typed 'c', then >> released Ctrl and typed '.'. Isn't that what one is supposed to use? >> >> So the above basically makes keymap-local-set useless, or am I missing >> something? The following does work: >> >> M-: (keymap-local-set "C-c ." 'forward-line) RET >> >> However, I could find no way of typing the string "C-c ." at the >> prompt of keymap-local-set. > > This patch seems to DTRT: > > diff --git a/lisp/keymap.el b/lisp/keymap.el > index 791221f2459..9643dce5f9c 100644 > --- a/lisp/keymap.el > +++ b/lisp/keymap.el > @@ -95,7 +95,8 @@ keymap-local-set > cases is shared with all other buffers in the same major mode." > (declare (compiler-macro (lambda (form) (keymap--compile-check key) fo= rm))) > (interactive "KSet key locally: \nCSet key %s locally to command: ") > - (let ((map (current-local-map))) > + (let ((map (current-local-map)) > + (key (key-description key))) > (unless map > (use-local-map (setq map (make-sparse-keymap)))) > (keymap-set map key command))) ... but not in your non-interactive case; so maybe this instead: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: keymap-local-set patch Content-Transfer-Encoding: quoted-printable diff --git a/lisp/keymap.el b/lisp/keymap.el index 791221f2459..48ec91d03c8 100644 =2D-- a/lisp/keymap.el +++ b/lisp/keymap.el @@ -98,6 +98,8 @@ keymap-local-set (let ((map (current-local-map))) (unless map (use-local-map (setq map (make-sparse-keymap)))) + (unless (stringp key) + (setq key (key-description key))) (keymap-set map key command))) (defun keymap-global-unset (key &optional remove) --=-=-= Content-Type: text/plain Steve Berman --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 02:59:12 2023 Received: (at 61149) by debbugs.gnu.org; 30 Jan 2023 07:59:12 +0000 Received: from localhost ([127.0.0.1]:46229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMP4K-0004z6-6k for submit@debbugs.gnu.org; Mon, 30 Jan 2023 02:59:12 -0500 Received: from mail-wm1-f49.google.com ([209.85.128.49]:33567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMP4J-0004yt-5P for 61149@debbugs.gnu.org; Mon, 30 Jan 2023 02:59:11 -0500 Received: by mail-wm1-f49.google.com with SMTP id iv8-20020a05600c548800b003db04a0a46bso8311960wmb.0 for <61149@debbugs.gnu.org>; Sun, 29 Jan 2023 23:59:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=dvd1BHe0TKBKBfTM4qHjRxVcFwqkmsAfkmXdl/nI6GU=; b=SNGOck1BafSvWJ78L6zTbJrl3VJvJsBzbnQ/dsOZJwfyi1AkEpfXJ/7y3bDIvbVYFR U0T45QJ2j/Gow9CbJK9tQm9jS0VPuOwsVUIK/UUuXa0+/ssYqAfOxliSZe+nspO0kuUD pMsszOyB1iOmI87QjosPfhkydRjoGYVUbWREd6GLAqzdZJ/ij93ZlFh8gVyf1/ZZHTx9 sABTrWcGe1tNxPIBWSCRcUvK4iRUkFMovz56wTWahLg/ZrvSswUn29HMTe6pwsImdA2v oGX5Q0gTMDoW9NF4QymgiPYeLfSCHcBHCLL9UxjNC0lUEvcVWEESB1ZsbyflE5ZJP/iX S8cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dvd1BHe0TKBKBfTM4qHjRxVcFwqkmsAfkmXdl/nI6GU=; b=vvRKx0GUOePL6ZfzRZo25UBniLhNM9E/VxW9b6bFwvbzK7p3oZAzk7eKQtCfFsF8VJ wcLhStKtPhDsBbPBkVEOnyrnuRYaw8Sqmfg7U3z83+oGCh+OHf2j2S6vOjNOTytvMONv oBl2zmKoqTSef1+tHir3FP1CD5jyx/V8/YGoh5Rj4vzPyxvJXnNMHUKH5fDgDHvWptOO 0djDt8jpKDHJNU0Sv8OsmnQE29TXvmD355Lj2nOf1w4e3yhaxWx1xEbWPqHzsjUgANWJ 6DUJ5XpnNZ3t9JRbSjDHaMyKezPSacrk0dCXxfQy/b8IAvI71dytT7+y6oTz6aap0UyV zagQ== X-Gm-Message-State: AO0yUKUUAUbeS2UfOcxs+WmvqvXasdgJX5aZ0MQTFSBY7UtAKtw7QRNH qxFo1tnUx2C0yefeiGXBvQdD7prDQVQ= X-Google-Smtp-Source: AK7set+PxucODRJbH4AU5nM/wo/t1TiDjmCSEvXI1h+uKOsyoitNoy9phkwLn7Zh9c6Yxnq/GIOJpg== X-Received: by 2002:a1c:7702:0:b0:3dc:50b8:67dd with SMTP id t2-20020a1c7702000000b003dc50b867ddmr5821790wmi.16.1675065544754; Sun, 29 Jan 2023 23:59:04 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id y21-20020a05600c341500b003da28dfdedcsm6056060wmp.5.2023.01.29.23.59.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Jan 2023 23:59:04 -0800 (PST) From: Robert Pluim To: Stephen Berman Subject: Re: bug#61149: 29.0.60; keymap-local-set rejects key sequences In-Reply-To: <871qndbbrn.fsf@rub.de> (Stephen Berman's message of "Sun, 29 Jan 2023 16:28:44 +0100") References: <83wn5578vn.fsf@gnu.org> <875ycpbe8l.fsf@rub.de> <871qndbbrn.fsf@rub.de> Date: Mon, 30 Jan 2023 08:59:03 +0100 Message-ID: <87fsbszc54.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61149 Cc: Eli Zaretskii , 61149@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Sun, 29 Jan 2023 16:28:44 +0100, Stephen Berman said: Stephen> ... but not in your non-interactive case; so maybe this instead: Stephen> diff --git a/lisp/keymap.el b/lisp/keymap.el Stephen> index 791221f2459..48ec91d03c8 100644 Stephen> --- a/lisp/keymap.el Stephen> +++ b/lisp/keymap.el Stephen> @@ -98,6 +98,8 @@ keymap-local-set Stephen> (let ((map (current-local-map))) Stephen> (unless map Stephen> (use-local-map (setq map (make-sparse-keymap)))) Stephen> + (unless (stringp key) Stephen> + (setq key (key-description key))) Stephen> (keymap-set map key command))) `keymap-global-set' has the same type of issue. How about this instead: diff --git a/lisp/keymap.el b/lisp/keymap.el index 791221f2459..1a339598f0c 100644 --- a/lisp/keymap.el +++ b/lisp/keymap.el @@ -79,7 +79,7 @@ keymap-global-set (interactive (let* ((menu-prompting nil) (key (read-key-sequence "Set key globally: " nil t))) - (list key + (list (key-description key) (read-command (format "Set key %s to command: " (key-description key)))))) (keymap-set (current-global-map) key command)) @@ -94,7 +94,12 @@ keymap-local-set The binding goes in the current buffer's local map, which in most cases is shared with all other buffers in the same major mode." (declare (compiler-macro (lambda (form) (keymap--compile-check key) form))) - (interactive "KSet key locally: \nCSet key %s locally to command: ") + (interactive + (let* ((menu-prompting nil) + (key (read-key-sequence "Set key locally: " nil t))) + (list (key-description key) + (read-command (format "Set key %s to command: " + (key-description key)))))) (let ((map (current-local-map))) (unless map (use-local-map (setq map (make-sparse-keymap)))) Robert -- From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 03:47:00 2023 Received: (at 61149) by debbugs.gnu.org; 30 Jan 2023 08:47:00 +0000 Received: from localhost ([127.0.0.1]:46281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMPoZ-0006CS-Tb for submit@debbugs.gnu.org; Mon, 30 Jan 2023 03:47:00 -0500 Received: from mout.gmx.net ([212.227.15.19]:43171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMPoY-0006CC-8U for 61149@debbugs.gnu.org; Mon, 30 Jan 2023 03:46:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1675068409; bh=MPmLxjiXey7aZ3nNUVYg7OFds5AFZXqYClImjIN81f8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=r8TnRDijPH2j0bXC5Ve0kMadOC9li6jEYxPZIEssgL4Mh/Lyj0k/4EazSD0E0fKDK exOQ52d72PWe2gcHnlmWZQ80QaqgTK+7MmFfimQSQQh8NGFz0mlxiUU8KtNfso5zk8 OIQkR/jboYPfQJAeALmTiAPQ5kvWu5s5RXp9S8ER3fQOp8uinrKMtsyKUGX7Odq8Mh XU/P/Ixm86yKlG5qb2FbUroMJY/ufiFDT64v7oNOssN1Hs+blfH41B04nUx9Z9D9Ko lhvDoevIY/pv/7bnKLn8roCKNaGh4Tff24rk9ifV9xj2E/5k0Da1oKQfv4CEx6Ladt fbB693yksjHmA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from strobelfs ([89.246.36.163]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MTzf6-1pDANv36l0-00QxEo; Mon, 30 Jan 2023 09:46:49 +0100 From: Stephen Berman To: Robert Pluim Subject: Re: bug#61149: 29.0.60; keymap-local-set rejects key sequences In-Reply-To: <87fsbszc54.fsf@gmail.com> (Robert Pluim's message of "Mon, 30 Jan 2023 08:59:03 +0100") References: <83wn5578vn.fsf@gnu.org> <875ycpbe8l.fsf@rub.de> <871qndbbrn.fsf@rub.de> <87fsbszc54.fsf@gmail.com> Date: Mon, 30 Jan 2023 09:46:49 +0100 Message-ID: <87zga0jtom.fsf@rub.de> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:9j5flNL0xswTozUpfqhkjt8lv1CD0TyDM1AdopeH0G342um8x6a kaROCWD/LETEN9fEdu9m8vfEqAjfPX62KonkI1g2wCELi10rpV/dAxl9VqBHXvOFsLuR9ni g8Xdqzw1sXGbibGZJqZT8sfqm3Lusnn1Vm6S3lVAbBd/2OfzVLAcEw3Lq2SMDZhFTC3F9GK zNuuSet+vHdnpZEVFViWw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:UCEvpugyYAU=;rrBtZxBajabXpX9yzeikFazzx3S jWwzfS3voGhf2PjKsHGqsfYGTMp/G4kidBa70xqn6IBYphGRtrj9JW6THY9KiDy25vNJDVrbJ kkiStKw0lwhBZ19ykxXEKX/IYUA36uCB/VYMEN11SAz3ySAxxFWjyHQ/JhBiZ63eE2DaU7hwf NWF71QK14MwxVnEPPJOUdSklByvU/Oeznm9t27zWd0JJfggmGuCJ6rvoozSXwKxd7tRNQMrpx 53KweExwHyf1NYXyQDeADxOilp5DbTraVTKgJlcJlBwFg46TM/XH0q1dME73eXUH4d8ygTXHf kpdorG3fp4YboOu8Ll9QJlF/kqP+AFaG1uhOH31GPSyaN6u8bwkGaa8khHXwixDl9Qr5yzisX v3LuoXgupAfe8UXmoNownDebT6p3PBamAWqwRS5363Gb1/Bhhz1lM9zLfVrDpc6e13Y15mmD/ dCC3AvqJx/+jtOefAXNRwhPjAxVBoJhuIMmA7N6uxhikAb7+y2gsUoIPqzTqbh5aSyppAWWq9 Ps6z7I8qzZqqXOuYS0GlPb2g0qWsO+l73jWZr384Tj4Io0QyfI+PCE4BR/63jVH7BIqr9Rpc6 8gwuxTIT2ttUWl8ZfA6TNWDQT0dcd9s72bn5/TfuVe75GdCzkN9Gq6xnqXKvg9iwMbiIJzJlw uWPyF8DJUyjerfICNu4u6VajcmbnLzvVhK7K95RyrzqEZ4WVU4mIce/4aB3OcEt+z/zX4wgMB t0t8NMbtFyWcjdvdjeSt1YPz7VKjheMTZ82JawfZufNt32jsImDnMHfflKBnkHDNulSazGn4j 37zZpeFauzpYbEWi7m1t7FRxHExb/COm8JzFN1CDTNT/xFYVBa48m6K2AMliCFFq0JlwPvRYQ +JX+iFV1YG1VjVdJ4diax81DtP3ZZ16xzs6sUk0jt6zgWUvcYPhORTCLwoHyXEsqX4Ibcooyf NzMHcF27magx7Pc+pwjqba+UWJ4= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61149 Cc: Eli Zaretskii , 61149@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Mon, 30 Jan 2023 08:59:03 +0100 Robert Pluim wrote: >>>>>> On Sun, 29 Jan 2023 16:28:44 +0100, Stephen Berman > said: > > Stephen> ... but not in your non-interactive case; so maybe this instead: > > Stephen> diff --git a/lisp/keymap.el b/lisp/keymap.el > Stephen> index 791221f2459..48ec91d03c8 100644 > Stephen> --- a/lisp/keymap.el > Stephen> +++ b/lisp/keymap.el > Stephen> @@ -98,6 +98,8 @@ keymap-local-set > Stephen> (let ((map (current-local-map))) > Stephen> (unless map > Stephen> (use-local-map (setq map (make-sparse-keymap)))) > Stephen> + (unless (stringp key) > Stephen> + (setq key (key-description key))) > Stephen> (keymap-set map key command))) > > `keymap-global-set' has the same type of issue. Thanks, I failed to check that. > How about this > instead: > > diff --git a/lisp/keymap.el b/lisp/keymap.el > index 791221f2459..1a339598f0c 100644 > --- a/lisp/keymap.el > +++ b/lisp/keymap.el > @@ -79,7 +79,7 @@ keymap-global-set > (interactive > (let* ((menu-prompting nil) > (key (read-key-sequence "Set key globally: " nil t))) > - (list key > + (list (key-description key) > (read-command (format "Set key %s to command: " > (key-description key)))))) > (keymap-set (current-global-map) key command)) > @@ -94,7 +94,12 @@ keymap-local-set > The binding goes in the current buffer's local map, which in most > cases is shared with all other buffers in the same major mode." > (declare (compiler-macro (lambda (form) (keymap--compile-check key) form))) > - (interactive "KSet key locally: \nCSet key %s locally to command: ") > + (interactive > + (let* ((menu-prompting nil) > + (key (read-key-sequence "Set key locally: " nil t))) > + (list (key-description key) > + (read-command (format "Set key %s to command: " > + (key-description key)))))) > (let ((map (current-local-map))) > (unless map > (use-local-map (setq map (make-sparse-keymap)))) This also DTRT, but it also gives keymap-local-set the same UI as that of keymap-global-set, which is that at the first prompt the cursor jumps out of the minibuffer (due to read-key-sequence), and then jumps back at the second prompt. I find this quite jarring (and the first time I was quite surprised and thought I had either mistyped or there was a bug). I would prefer it if both commands had keymap-local-set's current UI. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 04:47:45 2023 Received: (at 61149) by debbugs.gnu.org; 30 Jan 2023 09:47:45 +0000 Received: from localhost ([127.0.0.1]:46411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMQlM-0007xO-KT for submit@debbugs.gnu.org; Mon, 30 Jan 2023 04:47:45 -0500 Received: from mail-wr1-f43.google.com ([209.85.221.43]:42872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMQlK-0007wc-Sc for 61149@debbugs.gnu.org; Mon, 30 Jan 2023 04:47:43 -0500 Received: by mail-wr1-f43.google.com with SMTP id d14so10430421wrr.9 for <61149@debbugs.gnu.org>; Mon, 30 Jan 2023 01:47:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=RSyLaKYBiPRtuq1iQoGcqKz5SlE94ThYKirYlMULvdQ=; b=OdTCGWRlzciU8ND0jg8DQmh/8sl/RdtLbA4EuiSDxiQL3DvJTC3Vp5riNe8fU0/ANU RyalHCLtNsa7J8PCV4IZvBGEYhCk28LDfO0UvrHjfJ0BWDaV7Z5LAtlvrG+54u1Wqs4g WsNw+Thv/+D353mYPWHGGu0yQhkVkS7pKXPT/zSCMu2ed0QSyRVyW0HSVX6jEZFV8yAE no59f0iqtkc8JJEUnipjtGy+8+TXoglxCYZYhAeGDwLmcFQPUirC2zWPcWWcNGvTkjon midoecTLstlNdnDYZRMkYDQ0UaSTrqHuCumcsn7DaBJPfOReX+Bx60LbXtwJMAmca7AZ 9tlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RSyLaKYBiPRtuq1iQoGcqKz5SlE94ThYKirYlMULvdQ=; b=aMPN8PVO3zF2E8T3GLnTEHQBCxc3DN3E2dFzddcFl2hfyHmERrsLRpfD53/7JbJcrT zYITcIj2w6gtuoS6Va0ehUoP+uJUbgHczQd7Gr4mroA5VAbPYISzgbWiwmL6hFXvzsIl DGGBagoJGeBlBq5+rWQezym6RMtQQUOkQ+Lz4J55YEHEN1/QRoH45/VyLALzVmfltZid HKADOD29TZIXY4JJZ37J0BKsYd12Zzyhi/2R55q/K1v3P2MbITTFUlOEF8UhygfNY1Di 2qtKj18hsaddtZJcPdwNzfZA1UcmszW+EB9gj6V2yxtBhqs23xmxrrpsRXFzojD4sdgJ lHzg== X-Gm-Message-State: AO0yUKXcgjZQ1V0Q/3SFWkHGmT73FmpLzelWVY9ZQMWVNUDOlm5ApkNi EwJzLT8gZ6XiRBPv6ZVBTXS7yQo83HI= X-Google-Smtp-Source: AK7set+vOzaQjwu/6bKM3v0C37gBYbicN8mAlgy7l8y/6G9qb/JEsAeBS+3J1to2TJPA8OrbYExfKQ== X-Received: by 2002:a5d:4bc2:0:b0:2bf:dab7:8fa0 with SMTP id l2-20020a5d4bc2000000b002bfdab78fa0mr6957041wrt.25.1675072056454; Mon, 30 Jan 2023 01:47:36 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id a17-20020adffb91000000b002bddac15b3dsm11146612wrr.33.2023.01.30.01.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 01:47:36 -0800 (PST) From: Robert Pluim To: Stephen Berman Subject: Re: bug#61149: 29.0.60; keymap-local-set rejects key sequences In-Reply-To: <87zga0jtom.fsf@rub.de> (Stephen Berman's message of "Mon, 30 Jan 2023 09:46:49 +0100") References: <83wn5578vn.fsf@gnu.org> <875ycpbe8l.fsf@rub.de> <871qndbbrn.fsf@rub.de> <87fsbszc54.fsf@gmail.com> <87zga0jtom.fsf@rub.de> Date: Mon, 30 Jan 2023 10:47:35 +0100 Message-ID: <87357sz748.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61149 Cc: Eli Zaretskii , 61149@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 30 Jan 2023 09:46:49 +0100, Stephen Berman said: Stephen> This also DTRT, but it also gives keymap-local-set the same UI= as that Stephen> of keymap-global-set, which is that at the first prompt the cu= rsor jumps Stephen> out of the minibuffer (due to read-key-sequence), and then jum= ps back at Stephen> the second prompt. I find this quite jarring (and the first t= ime I was Stephen> quite surprised and thought I had either mistyped or there was= a bug). Stephen> I would prefer it if both commands had keymap-local-set's curr= ent UI. Yes, that is quite annoying. So let=CA=BCs do it your way (with an incidental spacing fix :-) ) Eli, emacs-29, I think, if you=CA=BCre ok with the fix. diff --git a/lisp/keymap.el b/lisp/keymap.el index 791221f2459..caabedd5aec 100644 --- a/lisp/keymap.el +++ b/lisp/keymap.el @@ -76,12 +76,9 @@ keymap-global-set that local binding will continue to shadow any global binding that you make with this function." (declare (compiler-macro (lambda (form) (keymap--compile-check key) form= ))) - (interactive - (let* ((menu-prompting nil) - (key (read-key-sequence "Set key globally: " nil t))) - (list key - (read-command (format "Set key %s to command: " - (key-description key)))))) + (interactive "KSet key globally:\nCSet key %s globally to command: ") + (unless (stringp key) + (setq key (key-description key))) (keymap-set (current-global-map) key command)) =20 (defun keymap-local-set (key command) @@ -94,10 +91,12 @@ keymap-local-set The binding goes in the current buffer's local map, which in most cases is shared with all other buffers in the same major mode." (declare (compiler-macro (lambda (form) (keymap--compile-check key) form= ))) - (interactive "KSet key locally: \nCSet key %s locally to command: ") + (interactive "KSet key locally:\nCSet key %s locally to command: ") (let ((map (current-local-map))) (unless map (use-local-map (setq map (make-sparse-keymap)))) + (unless (stringp key) + (setq key (key-description key))) (keymap-set map key command))) =20 (defun keymap-global-unset (key &optional remove) From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 08:14:38 2023 Received: (at 61149) by debbugs.gnu.org; 30 Jan 2023 13:14:38 +0000 Received: from localhost ([127.0.0.1]:46661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMTza-0004FH-Dy for submit@debbugs.gnu.org; Mon, 30 Jan 2023 08:14:38 -0500 Received: from eggs.gnu.org ([209.51.188.92]:36798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMTzY-0004F2-ML for 61149@debbugs.gnu.org; Mon, 30 Jan 2023 08:14:37 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMTzT-0004JR-48; Mon, 30 Jan 2023 08:14:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=eTqPbDqhlvGM6e6/SweNGI35SY4yLifYsjQq7ZMdKls=; b=iOTz4G2lUcZrsDX1CUNn ZqrUWCTWIn53VoSzKs1HNWfJNf7g/uCUVE3JbN9VGOLgJ5GzkEmz8ouVSOoo+iZ+nKkGzFsbKzuvc FcLP9AGT95J7MNY8aY8mXZIiTTjPG/y7Wfb4CvfTF8Vv/tBpC5q3+HrG5oQOLiKMNQMxNllmf1xLx uIB2H+FXkhoTUulbJ7Y9sUqPe/V7LZOW2NcyCPpTzeLdIGFeRiwKG2Q6mqKmG11/3q1ytb/cz6+gH z2KQhmAvCQ7dukBWYxfZLNWEfjpY+zxgVuFe9krwE60YYZXsESUok5Ml+iBnIZSNZdjOz7SEW+Hxa IynGkYEzwGbx4g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pMTzS-0005cq-7J; Mon, 30 Jan 2023 08:14:30 -0500 Date: Mon, 30 Jan 2023 15:14:24 +0200 Message-Id: <835yco5fm7.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87357sz748.fsf@gmail.com> (message from Robert Pluim on Mon, 30 Jan 2023 10:47:35 +0100) Subject: Re: bug#61149: 29.0.60; keymap-local-set rejects key sequences References: <83wn5578vn.fsf@gnu.org> <875ycpbe8l.fsf@rub.de> <871qndbbrn.fsf@rub.de> <87fsbszc54.fsf@gmail.com> <87zga0jtom.fsf@rub.de> <87357sz748.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61149 Cc: 61149@debbugs.gnu.org, stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: Eli Zaretskii , 61149@debbugs.gnu.org > Date: Mon, 30 Jan 2023 10:47:35 +0100 > > Yes, that is quite annoying. So letʼs do it your way (with an > incidental spacing fix :-) ) > > Eli, emacs-29, I think, if youʼre ok with the fix. Definitely emacs-29, since these commands are new in Emacs 29, and we cannot possibly release broken commands. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 30 08:26:04 2023 Received: (at 61149) by debbugs.gnu.org; 30 Jan 2023 13:26:04 +0000 Received: from localhost ([127.0.0.1]:46690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMUAd-0006wc-Ka for submit@debbugs.gnu.org; Mon, 30 Jan 2023 08:26:04 -0500 Received: from mail-wm1-f41.google.com ([209.85.128.41]:40480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pMUAb-0006w1-CH; Mon, 30 Jan 2023 08:26:01 -0500 Received: by mail-wm1-f41.google.com with SMTP id j32-20020a05600c1c2000b003dc4fd6e61dso3160234wms.5; Mon, 30 Jan 2023 05:26:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=EX3VZGfeQluJMY2C4LlzttkRNvXJ/32TedaYP6A8imw=; b=Boe5vNmYjGPyJA5gWHu6MafWpYqdQe/If/sML5yyKp0bGWLlcWa+X3WWb1af0fNEH1 IUDhWqVZWxpfHKtnw0qsB/rmHsaTA/FMIqdRlueOngX3bwYpKIwfs+d3oKVTBEMZZtwb QevIlQ0L7nrFY8DBySZhhJoyGzh7EY0WKD3fUieGyyAXTM2qGTLHNtmtxfUNEA1fWwmn x0wICTm0bRf8mhHP6SZfhqqOvfpCj7fL+F4PbUJSMAY8SZulFkyUM3iDnhyTtplD+YY1 2/oGjM+bJHq/VZtXRnjX3I6V7mPpFil7ZY8FqTSDUTBlzde3RcMmGvHnRR+9Z1ByNAyd gbYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EX3VZGfeQluJMY2C4LlzttkRNvXJ/32TedaYP6A8imw=; b=U63upJNOqokTcmwjVJm3HTX44z7jQLY7p+L/KsNKOM7vmRSikMHhy1hB2aR/vD/diO j7aBqlSFq599TVn72pD+s9UQ4Wx4ZO1vcpHN+9DmEBhKTAK23kRVgObNUoSRokosZXZS CUg0Su/3QOezMMVZPaNhowvENVHnQjwYtW9XbJkONEbl78/vT8FI6tg1cK3Duv9w9KjS QM1huKEntUsBrywTz3V6VA/m24b8wvhCOXaBIhnQZ46Wer5hZA+xpu1Cg1xr9ZfhB2IM v5EVYfvHpSEbAJf9roj7lV+upek0wW+BxrJ2lSnReY6kWU345GjjOQQDasiWrIjBYZzb tc+Q== X-Gm-Message-State: AFqh2krob1kkyV8LhZ4+N70Lv6c0gezlg+xoxwq5QAhtunm9H4LEOMeE /tSZll5Kzngd3xc0jqu6EENGw8xjibo= X-Google-Smtp-Source: AMrXdXsoTUXl9bGGrla0gmaUveqqSZBdk84y39VJ5Mt+wfojkjObO9k9/VwyVMLfvXRkZ053CHOzdg== X-Received: by 2002:a05:600c:1d8a:b0:3db:f0a:cfa1 with SMTP id p10-20020a05600c1d8a00b003db0f0acfa1mr45636666wms.9.1675085155274; Mon, 30 Jan 2023 05:25:55 -0800 (PST) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id f21-20020a5d58f5000000b00236883f2f5csm11947924wrd.94.2023.01.30.05.25.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jan 2023 05:25:54 -0800 (PST) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#61149: 29.0.60; keymap-local-set rejects key sequences In-Reply-To: <835yco5fm7.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 30 Jan 2023 15:14:24 +0200") References: <83wn5578vn.fsf@gnu.org> <875ycpbe8l.fsf@rub.de> <871qndbbrn.fsf@rub.de> <87fsbszc54.fsf@gmail.com> <87zga0jtom.fsf@rub.de> <87357sz748.fsf@gmail.com> <835yco5fm7.fsf@gnu.org> Date: Mon, 30 Jan 2023 14:25:54 +0100 Message-ID: <87pmawxifx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61149 Cc: 61149@debbugs.gnu.org, stephen.berman@gmx.net X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 61149 fixed close 61149 29.1 quit >>>>> On Mon, 30 Jan 2023 15:14:24 +0200, Eli Zaretskii said: >> From: Robert Pluim >> Cc: Eli Zaretskii , 61149@debbugs.gnu.org >> Date: Mon, 30 Jan 2023 10:47:35 +0100 >>=20 >> Yes, that is quite annoying. So let=CA=BCs do it your way (with an >> incidental spacing fix :-) ) >>=20 >> Eli, emacs-29, I think, if you=CA=BCre ok with the fix. Eli> Definitely emacs-29, since these commands are new in Emacs 29, and= we Eli> cannot possibly release broken commands. Eli> Thanks. Closing, pushed as f67a9a12b7b Robert --=20 From unknown Mon Jun 23 07:52:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 28 Feb 2023 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator