GNU bug report logs - #61120
[PATCH core-updates 0/1] gnu: mesa: Fix sporadic test failures.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Simon South <simon <at> simonsouth.net>
Subject: bug#61120: closed (Re: bug#61120: [PATCH core-updates 0/1] gnu:
 mesa: Fix sporadic test failures.)
Date: Sat, 04 Mar 2023 16:33:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#61120: [PATCH core-updates 0/1] gnu: mesa: Fix sporadic test failures.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 61120 <at> debbugs.gnu.org.

-- 
61120: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61120
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon South <simon <at> simonsouth.net>
Cc: 61120-done <at> debbugs.gnu.org
Subject: Re: bug#61120: [PATCH core-updates 0/1] gnu: mesa: Fix sporadic
 test failures.
Date: Sat, 04 Mar 2023 17:32:20 +0100

Simon South <simon <at> simonsouth.net> skribis:

> * gnu/packages/patches/mesa-fix-sporadic-test-failures.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/gl.scm (mesa)[source]: Apply it.

Applied, thanks for the investigation!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Simon South <simon <at> simonsouth.net>
To: guix-patches <at> gnu.org
Subject: [PATCH core-updates 0/1] gnu: mesa: Fix sporadic test failures.
Date: Sat, 28 Jan 2023 08:30:38 -0500

On core-updates, I've found Mesa will sometimes fail its test suite with error
messages like

  ../mesa-22.2.4/src/gallium/drivers/r600/sfn/tests/sfn_instrfromstring_test.cpp:712: Failure
  Expected equality of these values:
    os.str()
      Which is: "WRITE_SCRATCH 20 R1.xyzw\xFF\xFF AL:4 ALO:16"
    init
      Which is: "WRITE_SCRATCH 20 R1.xyzw AL:4 ALO:16"

Turns out this is due to an uninitialized buffer in the test suite's code,
reported to upstream with issue 7021[0] and fixed with upstream commit
7749599d[1] in Mesa 22.3.0.

The patch to follow backports this commit to the version in core-updates,
22.2.4, and has eliminated these sporadic failures for me.

Tested on x86-64 and AArch64 and everything seems fine.

[0] https://gitlab.freedesktop.org/mesa/mesa/-/issues/7021

[1] https://gitlab.freedesktop.org/mesa/mesa/-/commit/7749599d737d205a88bbb6fa755ba095d9b581fa

--
Simon South
simon <at> simonsouth.net


Simon South (1):
  gnu: mesa: Fix sporadic test failures.

 gnu/local.mk                                  |  1 +
 gnu/packages/gl.scm                           |  4 ++-
 .../mesa-fix-sporadic-test-failures.patch     | 27 +++++++++++++++++++
 3 files changed, 31 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/patches/mesa-fix-sporadic-test-failures.patch


base-commit: 770d379d7b60590bfdcb749287cb6713dee093ce
prerequisite-patch-id: 418e6f2f834e0f77d4da64e48bf654d610fbfe80
prerequisite-patch-id: 7c9321685c0c33cb9d1438797d2cb2bb540276c4
-- 
2.39.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.