From unknown Mon Aug 18 11:31:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61120] [PATCH core-updates 0/1] gnu: mesa: Fix sporadic test failures. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 28 Jan 2023 13:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61120 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61120@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167491266028267 (code B ref -1); Sat, 28 Jan 2023 13:31:01 +0000 Received: (at submit) by debbugs.gnu.org; 28 Jan 2023 13:31:00 +0000 Received: from localhost ([127.0.0.1]:39890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLlIK-0007Lr-2i for submit@debbugs.gnu.org; Sat, 28 Jan 2023 08:31:00 -0500 Received: from lists.gnu.org ([209.51.188.17]:33418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLlIH-0007Lh-GV for submit@debbugs.gnu.org; Sat, 28 Jan 2023 08:30:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLlI8-0003ZQ-0p for guix-patches@gnu.org; Sat, 28 Jan 2023 08:30:49 -0500 Received: from mailout.easymail.ca ([64.68.200.34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLlI4-00029U-Gi for guix-patches@gnu.org; Sat, 28 Jan 2023 08:30:47 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 18DD36813B for ; Sat, 28 Jan 2023 13:30:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo07-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo07-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dl80mrZakMtm for ; Sat, 28 Jan 2023 13:30:40 +0000 (UTC) Received: from localhost.localdomain (23-233-96-72.cpe.pppoe.ca [23.233.96.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 9E059680FB for ; Sat, 28 Jan 2023 13:30:40 +0000 (UTC) From: Simon South Date: Sat, 28 Jan 2023 08:30:38 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On core-updates, I've found Mesa will sometimes fail its test suite with error messages like ../mesa-22.2.4/src/gallium/drivers/r600/sfn/tests/sfn_instrfromstring_test.cpp:712: Failure Expected equality of these values: os.str() Which is: "WRITE_SCRATCH 20 R1.xyzw\xFF\xFF AL:4 ALO:16" init Which is: "WRITE_SCRATCH 20 R1.xyzw AL:4 ALO:16" Turns out this is due to an uninitialized buffer in the test suite's code, reported to upstream with issue 7021[0] and fixed with upstream commit 7749599d[1] in Mesa 22.3.0. The patch to follow backports this commit to the version in core-updates, 22.2.4, and has eliminated these sporadic failures for me. Tested on x86-64 and AArch64 and everything seems fine. [0] https://gitlab.freedesktop.org/mesa/mesa/-/issues/7021 [1] https://gitlab.freedesktop.org/mesa/mesa/-/commit/7749599d737d205a88bbb6fa755ba095d9b581fa -- Simon South simon@simonsouth.net Simon South (1): gnu: mesa: Fix sporadic test failures. gnu/local.mk | 1 + gnu/packages/gl.scm | 4 ++- .../mesa-fix-sporadic-test-failures.patch | 27 +++++++++++++++++++ 3 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/mesa-fix-sporadic-test-failures.patch base-commit: 770d379d7b60590bfdcb749287cb6713dee093ce prerequisite-patch-id: 418e6f2f834e0f77d4da64e48bf654d610fbfe80 prerequisite-patch-id: 7c9321685c0c33cb9d1438797d2cb2bb540276c4 -- 2.39.1 From unknown Mon Aug 18 11:31:06 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#61120] [PATCH core-updates 1/1] gnu: mesa: Fix sporadic test failures. Resent-From: Simon South Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 28 Jan 2023 13:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61120 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 61120@debbugs.gnu.org Received: via spool by 61120-submit@debbugs.gnu.org id=B61120.167491276228456 (code B ref 61120); Sat, 28 Jan 2023 13:33:01 +0000 Received: (at 61120) by debbugs.gnu.org; 28 Jan 2023 13:32:42 +0000 Received: from localhost ([127.0.0.1]:39895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLlJx-0007Ou-Jg for submit@debbugs.gnu.org; Sat, 28 Jan 2023 08:32:41 -0500 Received: from mailout.easymail.ca ([64.68.200.34]:51604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLlJv-0007Oe-0D for 61120@debbugs.gnu.org; Sat, 28 Jan 2023 08:32:39 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 6A444E82E4 for <61120@debbugs.gnu.org>; Sat, 28 Jan 2023 13:32:33 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo08-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo08-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rohPm1zH1odz for <61120@debbugs.gnu.org>; Sat, 28 Jan 2023 13:32:33 +0000 (UTC) Received: from localhost.localdomain (23-233-96-72.cpe.pppoe.ca [23.233.96.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 0C12AE80C9 for <61120@debbugs.gnu.org>; Sat, 28 Jan 2023 13:32:33 +0000 (UTC) From: Simon South Date: Sat, 28 Jan 2023 08:32:31 -0500 Message-Id: <74cb66802a5a503d087378df6e2a8d423c6e69a4.1674910858.git.simon@simonsouth.net> X-Mailer: git-send-email 2.39.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/patches/mesa-fix-sporadic-test-failures.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/gl.scm (mesa)[source]: Apply it. --- gnu/local.mk | 1 + gnu/packages/gl.scm | 4 ++- .../mesa-fix-sporadic-test-failures.patch | 27 +++++++++++++++++++ 3 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/mesa-fix-sporadic-test-failures.patch diff --git a/gnu/local.mk b/gnu/local.mk index 3dbad5b439..306c72c44d 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -1505,6 +1505,7 @@ dist_patch_DATA = \ %D%/packages/patches/mercurial-hg-extension-path.patch \ %D%/packages/patches/mercurial-openssl-compat.patch \ %D%/packages/patches/mesa-opencl-all-targets.patch \ + %D%/packages/patches/mesa-fix-sporadic-test-failures.patch \ %D%/packages/patches/meson-allow-dirs-outside-of-prefix.patch \ %D%/packages/patches/mhash-keygen-test-segfault.patch \ %D%/packages/patches/mia-fix-boost-headers.patch \ diff --git a/gnu/packages/gl.scm b/gnu/packages/gl.scm index dd62fac13e..8a6d2ac57f 100644 --- a/gnu/packages/gl.scm +++ b/gnu/packages/gl.scm @@ -279,7 +279,9 @@ (define-public mesa version "/mesa-" version ".tar.xz"))) (sha256 (base32 - "1azpr68pdg63yq3igmzwsgn2ypg49m0mp3hfkq0lcyswr99npmv5")))) + "1azpr68pdg63yq3igmzwsgn2ypg49m0mp3hfkq0lcyswr99npmv5")) + (patches + (list (search-patch "mesa-fix-sporadic-test-failures.patch"))))) (build-system meson-build-system) (propagated-inputs ;; The following are in the Requires.private field of gl.pc. diff --git a/gnu/packages/patches/mesa-fix-sporadic-test-failures.patch b/gnu/packages/patches/mesa-fix-sporadic-test-failures.patch new file mode 100644 index 0000000000..50ac5530a2 --- /dev/null +++ b/gnu/packages/patches/mesa-fix-sporadic-test-failures.patch @@ -0,0 +1,27 @@ +commit 7749599d737d205a88bbb6fa755ba095d9b581fa +Author: Gert Wollny +Date: Mon Aug 15 17:15:43 2022 +0200 + + r600/sfn: Initialize out buffer when printing op + + 79ca456b4837b3bc21cf9ef3c03c505c4b4909f6 + r600/sfn: rewrite NIR backend + + Closes: #7021 + + Signed-off-by: Gert Wollny + Part-of: + +diff --git a/src/gallium/drivers/r600/sfn/sfn_instr_export.cpp b/src/gallium/drivers/r600/sfn/sfn_instr_export.cpp +index 3d40ea1796a..00826ed6457 100644 +--- a/src/gallium/drivers/r600/sfn/sfn_instr_export.cpp ++++ b/src/gallium/drivers/r600/sfn/sfn_instr_export.cpp +@@ -206,7 +206,7 @@ bool WriteScratchInstr::do_ready() const + + void WriteScratchInstr::do_print(std::ostream& os) const + { +- char buf[6]; ++ char buf[6] = {0}; + + os << "WRITE_SCRATCH "; + if (m_address) -- 2.39.1 From unknown Mon Aug 18 11:31:06 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Simon South Subject: bug#61120: closed (Re: bug#61120: [PATCH core-updates 0/1] gnu: mesa: Fix sporadic test failures.) Message-ID: References: <871qm4tr3f.fsf_-_@gnu.org> X-Gnu-PR-Message: they-closed 61120 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 61120@debbugs.gnu.org Date: Sat, 04 Mar 2023 16:33:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1677947581-20713-1" This is a multi-part message in MIME format... ------------=_1677947581-20713-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #61120: [PATCH core-updates 0/1] gnu: mesa: Fix sporadic test failures. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 61120@debbugs.gnu.org. --=20 61120: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D61120 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1677947581-20713-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 61120-done) by debbugs.gnu.org; 4 Mar 2023 16:32:30 +0000 Received: from localhost ([127.0.0.1]:37512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYUo9-0005NL-T1 for submit@debbugs.gnu.org; Sat, 04 Mar 2023 11:32:30 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48202) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYUo8-0005N5-3W for 61120-done@debbugs.gnu.org; Sat, 04 Mar 2023 11:32:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYUo2-0001Vn-Lk; Sat, 04 Mar 2023 11:32:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=1cbrcaEBVV8BXkXNhmOksSv1x229/txDvqj5z9gdMjI=; b=c4tSucaQkrF603LV37br ZPjXy6OrMerZIuMUHC9b8jKqTxC6daNiZhkfODpuIK1ZlbdtQv1RJPhleyx/krXPJwtucjF1QNzZ6 GuQzChASGdnsR0WpJzj2qkaPh3roRPoJ7IlYJfak5+0fsrdUZk35smFqTCLWYdlNzHlN4zjSO63dU ak9Zv/xFxuvAO82V8roB24wQM/Zvedz33K0yH6FesiOPQxvB2s7O7PAYNWLchzVD2e5e9IYWh3fFL p70Hx7ImKB4msFZKFr7gCZd0edm8mIcup3w6nqgWPjqAJFkDtTCvTwST3ewNc5y7aKW7ENN6WDwc1 T3S8wdBhBaotlQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYUo2-0006dU-8h; Sat, 04 Mar 2023 11:32:22 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simon South Subject: Re: bug#61120: [PATCH core-updates 0/1] gnu: mesa: Fix sporadic test failures. References: <74cb66802a5a503d087378df6e2a8d423c6e69a4.1674910858.git.simon@simonsouth.net> Date: Sat, 04 Mar 2023 17:32:20 +0100 In-Reply-To: <74cb66802a5a503d087378df6e2a8d423c6e69a4.1674910858.git.simon@simonsouth.net> (Simon South's message of "Sat, 28 Jan 2023 08:32:31 -0500") Message-ID: <871qm4tr3f.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61120-done Cc: 61120-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Simon South skribis: > * gnu/packages/patches/mesa-fix-sporadic-test-failures.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/gl.scm (mesa)[source]: Apply it. Applied, thanks for the investigation! Ludo=E2=80=99. ------------=_1677947581-20713-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 28 Jan 2023 13:31:00 +0000 Received: from localhost ([127.0.0.1]:39890 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLlIK-0007Lr-2i for submit@debbugs.gnu.org; Sat, 28 Jan 2023 08:31:00 -0500 Received: from lists.gnu.org ([209.51.188.17]:33418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLlIH-0007Lh-GV for submit@debbugs.gnu.org; Sat, 28 Jan 2023 08:30:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLlI8-0003ZQ-0p for guix-patches@gnu.org; Sat, 28 Jan 2023 08:30:49 -0500 Received: from mailout.easymail.ca ([64.68.200.34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLlI4-00029U-Gi for guix-patches@gnu.org; Sat, 28 Jan 2023 08:30:47 -0500 Received: from localhost (localhost [127.0.0.1]) by mailout.easymail.ca (Postfix) with ESMTP id 18DD36813B for ; Sat, 28 Jan 2023 13:30:41 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at emo07-pco.easydns.vpn Received: from mailout.easymail.ca ([127.0.0.1]) by localhost (emo07-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id dl80mrZakMtm for ; Sat, 28 Jan 2023 13:30:40 +0000 (UTC) Received: from localhost.localdomain (23-233-96-72.cpe.pppoe.ca [23.233.96.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailout.easymail.ca (Postfix) with ESMTPSA id 9E059680FB for ; Sat, 28 Jan 2023 13:30:40 +0000 (UTC) From: Simon South To: guix-patches@gnu.org Subject: [PATCH core-updates 0/1] gnu: mesa: Fix sporadic test failures. Date: Sat, 28 Jan 2023 08:30:38 -0500 Message-Id: X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.68.200.34; envelope-from=simon@simonsouth.net; helo=mailout.easymail.ca X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On core-updates, I've found Mesa will sometimes fail its test suite with error messages like ../mesa-22.2.4/src/gallium/drivers/r600/sfn/tests/sfn_instrfromstring_test.cpp:712: Failure Expected equality of these values: os.str() Which is: "WRITE_SCRATCH 20 R1.xyzw\xFF\xFF AL:4 ALO:16" init Which is: "WRITE_SCRATCH 20 R1.xyzw AL:4 ALO:16" Turns out this is due to an uninitialized buffer in the test suite's code, reported to upstream with issue 7021[0] and fixed with upstream commit 7749599d[1] in Mesa 22.3.0. The patch to follow backports this commit to the version in core-updates, 22.2.4, and has eliminated these sporadic failures for me. Tested on x86-64 and AArch64 and everything seems fine. [0] https://gitlab.freedesktop.org/mesa/mesa/-/issues/7021 [1] https://gitlab.freedesktop.org/mesa/mesa/-/commit/7749599d737d205a88bbb6fa755ba095d9b581fa -- Simon South simon@simonsouth.net Simon South (1): gnu: mesa: Fix sporadic test failures. gnu/local.mk | 1 + gnu/packages/gl.scm | 4 ++- .../mesa-fix-sporadic-test-failures.patch | 27 +++++++++++++++++++ 3 files changed, 31 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/mesa-fix-sporadic-test-failures.patch base-commit: 770d379d7b60590bfdcb749287cb6713dee093ce prerequisite-patch-id: 418e6f2f834e0f77d4da64e48bf654d610fbfe80 prerequisite-patch-id: 7c9321685c0c33cb9d1438797d2cb2bb540276c4 -- 2.39.1 ------------=_1677947581-20713-1--