Subject: bug#61119: closed (Re: bug#61119: [PATCH core-updates 0/1] gnu: p7zip: Fix build with GCC 11.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 04 Mar 2023 16:31:02 +0000

Your bug report

#61119: [PATCH core-updates 0/1] gnu: p7zip: Fix build with GCC 11.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
61119: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61119
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#61119: [PATCH core-updates 0/1] gnu: p7zip: Fix build with GCC 11.
From: Ludovic Courtès <[email-masked]>
To: Simon South <[email-masked]>
Cc: [email-masked]
Date: Sat, 04 Mar 2023 17:30:06 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Simon South <[email-masked]> skribis:

> * gnu/packages/patches/p7zip-fix-build-with-gcc-11.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Add it.
> * gnu/packages/compression.scm (p7zip)[source]: Apply it.

Applied, thanks!

Ludo’.

Subject: [PATCH core-updates 0/1] gnu: p7zip: Fix build with GCC 11.
From: Simon South <[email-masked]>
To: [email-masked]
Date: Sat, 28 Jan 2023 07:57:37 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

On core-updates, p7zip is failing to build with error messages like

  ../../../../CPP/7zip/Archive/Wim/WimHandler.cpp:308:11: error: use of an
  operand of type ‘bool’ in ‘operator++’ is forbidden in C++17
    308 |           numMethods++;
        |           ^~~~~~~~~~

This follows from the move to GCC 11 and its use by default of the GNU dialect
of the C++17 standard for interpreting C++ code.  (Note p7zip is essentially
abandoned and its code is aging.)

The patch to follow causes GCC to use the GNU dialect of the C++14 standard
instead, as GCC 10 did by default, reducing the error messages to warnings and
allowing the build to complete.

I've tested this on x86-64 and AArch64 and everything seems fine.

--
Simon South
[email-masked]

Simon South (1):
  gnu: p7zip: Fix build with GCC 11.

 gnu/local.mk                                  |  1 +
 gnu/packages/compression.scm                  |  1 +
 .../patches/p7zip-fix-build-with-gcc-11.patch | 49 +++++++++++++++++++
 3 files changed, 51 insertions(+)
 create mode 100644 gnu/packages/patches/p7zip-fix-build-with-gcc-11.patch

base-commit: 770d379d7b60590bfdcb749287cb6713dee093ce
prerequisite-patch-id: 418e6f2f834e0f77d4da64e48bf654d610fbfe80
-- 
2.39.1