GNU bug report logs - #61117
Update svtplay-dl to 4.18

Previous Next

Full log

Message #34 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jessica Tallon <tsyesika <at> tsyesika.se>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 61117 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#61117] Update svtplay-dl to 4.18
Date: Sun, 5 Mar 2023 11:39:10 +0100

[Message part 1 (text/plain, inline)]

Hello,

Sorry for the long delay on addressing this feedback.

Tobias Geerinckx-Rice <me <at> tobias.gr> writes:
> Jessica,
>
> Please avoid propagation whenever possible; it breaks all kinds of
> nice things.
>
> Propagating A from B means that Guix will effectively ‘install’ A
> alongside B when the user installs only B.  Or how classical package
> managers bluntly handle ‘dependencies’.  Not good!
>

Thanks for the tip, I've included a patch which does it this way.

>
>> it's needed while the program is running to merge two files, not
>> while building.
>
> So 4.17 did not need or use ffmpeg this way?
>
> Otherwise, put each unrelated changes into a separate commit: one to
> improve the ffmpeg situation, and one to update svtplay-dl. You can
> send multiple related commits as one patch series to one bug number,
> though.

4.17 did indeed need ffmpeg, I've included two patches one which
resolves the ffmpeg issue and the other which updates it to 4.18.

Thanks,
Jessica.

[0000-cover-letter.patch (text/x-patch, attachment)]

[0001-gnu-fix-svtplay-dl-wrapping-to-use-ffmpeg.patch (text/x-patch, attachment)]

[0002-gnu-svtplay-dl-update-to-4.18.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.