From unknown Thu Jun 19 14:24:11 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61117 <61117@debbugs.gnu.org> To: bug#61117 <61117@debbugs.gnu.org> Subject: Status: Update svtplay-dl to 4.18 Reply-To: bug#61117 <61117@debbugs.gnu.org> Date: Thu, 19 Jun 2025 21:24:11 +0000 retitle 61117 Update svtplay-dl to 4.18 reassign 61117 guix-patches submitter 61117 Jessica Tallon severity 61117 normal tag 61117 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 06:29:15 2023 Received: (at submit) by debbugs.gnu.org; 28 Jan 2023 11:29:16 +0000 Received: from localhost ([127.0.0.1]:39713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLjOV-0007zC-Ik for submit@debbugs.gnu.org; Sat, 28 Jan 2023 06:29:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:33374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLjOR-0007z2-AV for submit@debbugs.gnu.org; Sat, 28 Jan 2023 06:29:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLjOR-0002E0-3u for guix-patches@gnu.org; Sat, 28 Jan 2023 06:29:11 -0500 Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pLjOP-0006RL-7H for guix-patches@gnu.org; Sat, 28 Jan 2023 06:29:10 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4P3sf33vbbz9sWN for ; Sat, 28 Jan 2023 12:28:59 +0100 (CET) From: Jessica Tallon To: guix-patches@gnu.org Subject: Update svtplay-dl to 4.18 Date: Sat, 28 Jan 2023 12:29:03 +0100 Message-ID: <5646122.DvuYhMxLoT@localhost.localdomain> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="nextPart5904265.lOV4Wx5bFT" Content-Transfer-Encoding: 7Bit X-Rspamd-Queue-Id: 4P3sf33vbbz9sWN Received-SPF: pass client-ip=2001:67c:2050:0:465::101; envelope-from=tsyesika@tsyesika.se; helo=mout-p-101.mailbox.org X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --nextPart5904265.lOV4Wx5bFT Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hello, I've attached a patch to upgrade svtplay-dl from 4.17 to 4.18. I've also moved ffmpeg form inputs to propagated-inputs as it's needed while the program is running to merge two files, not while building. Thanks, Jessica. --nextPart5904265.lOV4Wx5bFT Content-Disposition: attachment; filename="0001-gnu-packages-video.scm-svtplay-dl-update-to-4.18.patch" Content-Transfer-Encoding: 7Bit Content-Type: text/x-patch; charset="unicode-2-0-utf-8"; name="0001-gnu-packages-video.scm-svtplay-dl-update-to-4.18.patch" >From f487a0b2b9433d3151782e187fa9b69e13b9e0c3 Mon Sep 17 00:00:00 2001 Message-Id: From: Jessica Tallon Date: Sat, 28 Jan 2023 11:50:32 +0100 Subject: [PATCH] * gnu/packages/video.scm (svtplay-dl) update to 4.18 --- gnu/packages/video.scm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 60d39c38dc..4f2012ef3c 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -5635,7 +5635,7 @@ (define-public video-contact-sheet (define-public svtplay-dl (package (name "svtplay-dl") - (version "4.17") + (version "4.18") (source (origin (method git-fetch) (uri (git-reference @@ -5644,10 +5644,11 @@ (define-public svtplay-dl (file-name (git-file-name name version)) (sha256 (base32 - "0yjxmvldskw4pji3lg69pbx05izvxahz9my7z5p31mkiz6v33dmx")))) + "1xb2n3bwjddr86mjynbfd8m2g98gzqbj5mmsfc735q9xp14l30pf")))) (build-system python-build-system) - (inputs (list ffmpeg python-pyaml python-requests python-pysocks + (inputs (list python-pyaml python-requests python-pysocks python-cryptography)) + (propagated-inputs (list ffmpeg)) (home-page "https://svtplay-dl.se/") (synopsis "Download or stream SVT Play's (and others) TV programmes") (description -- 2.39.1 --nextPart5904265.lOV4Wx5bFT-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 07:51:14 2023 Received: (at submit) by debbugs.gnu.org; 28 Jan 2023 12:51:14 +0000 Received: from localhost ([127.0.0.1]:39819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkfp-00041f-P8 for submit@debbugs.gnu.org; Sat, 28 Jan 2023 07:51:14 -0500 Received: from lists.gnu.org ([209.51.188.17]:53988) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkfm-00041V-62 for submit@debbugs.gnu.org; Sat, 28 Jan 2023 07:51:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLkfl-0002Vb-MZ for guix-patches@gnu.org; Sat, 28 Jan 2023 07:51:09 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLkfi-00042l-Fe for guix-patches@gnu.org; Sat, 28 Jan 2023 07:51:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=yUe+T3KQmoHl6 /pRJLZORC0iItP8MThm8yre3rrp4QA=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=EFIxRgUb7bOikbt9LWVKmK90Bx0UXPuA6aXJiU khzNqKFniVGu7HkDDoCmZrY0+oYVZ8Rhi5j5X/DLVLc9qOQbpv8W/Aobc6E9yg9ao7l9Eq 0ipv2ZIOWJUw2oY/4KuEp6H2SFgDXQO3icBvBHNSJm90vG1emXvMOUl/nF++g6RlFh9qDZ 4kbAj4WTXrtodDR4wraFrHhCsGbQPstNv1NCEMA0uKlW+giH8LOwSa8DMLpnzJHS99lHkr 3G2o43n4+gNE8SQQ6lyafu5iMCv5kK56AyBB0CdLpKnJYxM5wb/s8+YKX+pUbjPq8/CzRn f6qDIIyuLyNVat7cPFjeZWIQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 473c57e0 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 28 Jan 2023 12:51:02 +0000 (UTC) References: <5646122.DvuYhMxLoT@localhost.localdomain> From: Tobias Geerinckx-Rice To: Jessica Tallon Subject: Re: [bug#61117] Update svtplay-dl to 4.18 Date: Sat, 28 Jan 2023 13:33:44 +0100 In-reply-to: <5646122.DvuYhMxLoT@localhost.localdomain> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87357ult1k.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 61117@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Jessica, Jessica Tallon =E5=86=99=E9=81=93=EF=BC=9A > I've attached a patch to upgrade svtplay-dl from 4.17 to 4.18. Thanks! > I've also moved ffmpeg form inputs to propagated-inputs Please avoid propagation whenever possible; it breaks all kinds of=20 nice things. Propagating A from B means that Guix will effectively =E2=80=98install=E2= =80=99 A=20 alongside B when the user installs only B. Or how classical=20 package managers bluntly handle =E2=80=98dependencies=E2=80=99. Not good! Here's what I'd do instead [untested]: (arguments (list #:phases #~(modify-phases %standard-phases (add-after 'wrap 'wrap-harder (lambda* (#:key inputs outputs=20 #:allow-other-keys) (wrap-script (string-append (assoc-ref outputs=20 "out") "/bin/svtplay-dl") `("PATH" ":" prefix (,(dirname (search-input-file inputs "bin/ffmpeg")))))))))) (native-inputs (list guile-3.0)) ; for wrap-script > it's needed while the program is=20 > running to merge two files, not while building. So 4.17 did not need or use ffmpeg this way? Otherwise, put each unrelated changes into a separate commit: one=20 to improve the ffmpeg situation, and one to update svtplay-dl.=20 You can send multiple related commits as one patch series to one=20 bug number, though. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY9Uatw0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15XMoBALYlzpK/UWBrpMt7maGd+CLzb6LvgptO6VTTc4mw FvaIAQDFWKaUlXwtYyqLb9z6wI8kO0rpHlyG0bQd/6IcFyJbCQ== =HBip -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 07:57:49 2023 Received: (at submit) by debbugs.gnu.org; 28 Jan 2023 12:57:49 +0000 Received: from localhost ([127.0.0.1]:39834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkmD-0004BQ-AD for submit@debbugs.gnu.org; Sat, 28 Jan 2023 07:57:49 -0500 Received: from lists.gnu.org ([209.51.188.17]:35162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkm9-0004BA-Jp for submit@debbugs.gnu.org; Sat, 28 Jan 2023 07:57:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLkm9-0003TA-AQ for guix-patches@gnu.org; Sat, 28 Jan 2023 07:57:45 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLkm6-0004pp-K0 for guix-patches@gnu.org; Sat, 28 Jan 2023 07:57:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=kOtdAtikQ1wwO 5Dc9IsK10N6VOvkjO2K25A501ogH4w=; h=in-reply-to:date:subject:cc:from: references; d=tobias.gr; b=HSppW2e5rSBwqznU2EFyfFPFcUh1PGqqPrQeSxr9Os0 Q0+PcQkWE5D2CblWL+ORkte1vPyX2txKO8O4AZe/WmxAYWXOpoR8NTpCch6mnjKm5O6NE/ M8KZhveXiz9VdhTY2ISBlMpStMD2Oz2IMNH0Oun+tT48TROkKW99jIU55dg+X5A0Pvu+ho NKlbJuaIokde1jRlP5MTK+wKm8qU2s+nfWJ2pzA8qqtlz3qcS0yLgKOrCG6psvZ+s0Clnc aO1qWneMfc6DOCaiZxyIZbrioqkqnkdBehzSqBTmdynJPkTO6lpc8WAOu+xtFFxiSp6rhO RtBErE9CT/17+qjeJ8g== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 7127fb0d (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 28 Jan 2023 12:57:40 +0000 (UTC) References: <5646122.DvuYhMxLoT@localhost.localdomain> <87357ult1k.fsf@nckx> From: Tobias Geerinckx-Rice Subject: Re: [bug#61117] Update svtplay-dl to 4.18 Date: Sat, 28 Jan 2023 13:58:53 +0100 In-reply-to: <87357ult1k.fsf@nckx> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87y1pmke62.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MISSING_HEADERS=1.021, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: submit Cc: Jessica Tallon , 61117@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > (lambda* (#:key inputs outputs > #:allow-other-keys) ^ Dunno why mu4e added a hard newline here. There shouldn't be one. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY9UcRQ0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15m3sBAOWDh9aizraxtITqyN8do4EP5hyqetFE73k3Nig9 NepUAP4q8SmytfTkeku9nZD9sev59xMlQy/V4Pt6vrUUl1zFDQ== =sjYA -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 08:01:17 2023 Received: (at submit) by debbugs.gnu.org; 28 Jan 2023 13:01:17 +0000 Received: from localhost ([127.0.0.1]:39856 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkpZ-0006dy-F8 for submit@debbugs.gnu.org; Sat, 28 Jan 2023 08:01:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:60586) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkpV-0006dn-Mc for submit@debbugs.gnu.org; Sat, 28 Jan 2023 08:01:13 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLkpV-0004zi-GQ for guix-patches@gnu.org; Sat, 28 Jan 2023 08:01:13 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLkpU-0005ff-1I for guix-patches@gnu.org; Sat, 28 Jan 2023 08:01:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=6lsSkeThhmKtT 2A/eWeB66fIueOx6HqFYXT+pSUkS2M=; h=in-reply-to:date:subject:cc:from: references; d=tobias.gr; b=Saba9HkjUfPljMGHVIS6AYJusUh11Vv1ijiKEe+f+ag xYg2lIK0oew0laKgoYgLb8xqhi9FKs4MawGpQFlzpcFfoKhDHfkHKA7zs3XHUO+u/LALzC bzraY5zsLZSyPMhg0ErSLgp6w7CrGYmEK6w28auDi5k4726zsNTN4/DR+Dgj8sHcDHRABo 7SJXGyJC7RUUNngjLs3gtscYGq2sm7Y+NcSWIjENwdCe4kadc8eFiXW2oKUMf7G6c666F3 C1H8NdjPUj00Tb/C7bW59DlDJkTLBF41oyvKbXZnBuiYz5aEWqupahUlRlxsI4o4cK+/Ap gzqOq6g1rkrVK2q0wCQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 31f6256a (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 28 Jan 2023 13:01:09 +0000 (UTC) References: <5646122.DvuYhMxLoT@localhost.localdomain> <87357ult1k.fsf@nckx> From: Tobias Geerinckx-Rice Subject: Re: [bug#61117] Update svtplay-dl to 4.18 Date: Sat, 28 Jan 2023 14:02:39 +0100 In-reply-to: <87357ult1k.fsf@nckx> BIMI-Selector: v=BIMI1; s=default; Message-ID: <87tu0ake09.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@tobias.gr; helo=tobias.gr X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MISSING_HEADERS=1.021, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: submit Cc: Jessica Tallon , 61117@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Tobias Geerinckx-Rice via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A > (wrap-script (string-append (assoc-ref outputs > "out")=20 > ^ And here. All the others are good. Sorry for the mess. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY9UdFg0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW15WQwA/RdhfeclZThtWHuxVz6Aqucg6LJuNtenkN3Gj430 UTHCAP9A2Trmh3rUIdEb//bXsxqgBUX1keL7l/3IcQVrwMThAQ== =3FuZ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 09:27:04 2023 Received: (at control) by debbugs.gnu.org; 3 Feb 2023 14:27:04 +0000 Received: from localhost ([127.0.0.1]:36877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNx1s-0006zF-Dt for submit@debbugs.gnu.org; Fri, 03 Feb 2023 09:27:04 -0500 Received: from mira.cbaines.net ([212.71.252.8]:42122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNx1q-0006z0-1z for control@debbugs.gnu.org; Fri, 03 Feb 2023 09:27:02 -0500 Received: from localhost (unknown [85.28.89.231]) by mira.cbaines.net (Postfix) with ESMTPSA id 8B85627BBE9 for ; Fri, 3 Feb 2023 14:27:01 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id b11f68fb for ; Fri, 3 Feb 2023 14:27:00 +0000 (UTC) From: Christopher Baines To: control@debbugs.gnu.org Subject: tag 61117 moreinfo Date: Fri, 03 Feb 2023 14:27:00 +0000 Message-ID: <87a61u3juz.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 61117 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 05 05:11:23 2023 Received: (at submit) by debbugs.gnu.org; 5 Mar 2023 10:11:23 +0000 Received: from localhost ([127.0.0.1]:38532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYlKt-0001B7-A4 for submit@debbugs.gnu.org; Sun, 05 Mar 2023 05:11:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:39128) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYlKq-0001Ay-LZ for submit@debbugs.gnu.org; Sun, 05 Mar 2023 05:11:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYlKp-0004ct-13 for guix-patches@gnu.org; Sun, 05 Mar 2023 05:11:19 -0500 Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pYlKm-0008KX-O9 for guix-patches@gnu.org; Sun, 05 Mar 2023 05:11:18 -0500 Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4PTyCZ5yjKz9swN; Sun, 5 Mar 2023 11:11:06 +0100 (CET) References: <5646122.DvuYhMxLoT@localhost.localdomain> <87357ult1k.fsf@nckx> From: Jessica Tallon To: Tobias Geerinckx-Rice Subject: Re: [bug#61117] Update svtplay-dl to 4.18 Date: Sun, 05 Mar 2023 11:05:28 +0100 In-reply-to: <87357ult1k.fsf@nckx> Message-ID: <877cvv33vo.fsf@tsyesika.se> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2001:67c:2050:0:465::102; envelope-from=tsyesika@tsyesika.se; helo=mout-p-102.mailbox.org X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 61117@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, Sorry for the long delay on addressing this feedback. Tobias Geerinckx-Rice writes: > [[PGP Signed Part:Undecided]] > Jessica, > > Please avoid propagation whenever possible; it breaks all kinds of > nice things. > > Propagating A from B means that Guix will effectively =E2=80=98install=E2= =80=99 A > alongside B when the user installs only B. Or how classical package > managers bluntly handle =E2=80=98dependencies=E2=80=99. Not good! > Thanks for the tip, I've included a patch which does it this way. > >> it's needed while the program is running to merge two files, not >> while building. > > So 4.17 did not need or use ffmpeg this way? > > Otherwise, put each unrelated changes into a separate commit: one to > improve the ffmpeg situation, and one to update svtplay-dl. You can > send multiple related commits as one patch series to one bug number, > though. 4.17 did indeed need ffmpeg, I've included two patches one which resolves the ffmpeg issue and the other which updates it to 4.18. Thanks, Jessica. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0000-cover-letter.patch Content-Description: Cover letter >From 1b81f1786ba0cb038bf76ab74cbc90847d06206b Mon Sep 17 00:00:00 2001 Message-Id: From: Jessica Tallon Date: Sun, 5 Mar 2023 11:02:49 +0100 Subject: [PATCH 0/2] Upgrade svtplay-dl to 4.18 & fix wrapping with ffmpeg The first patch fixes svtplay-dl which needs ffmpeg to create a unified file with both sound and video combined. Before it didn't have access to ffmpeg so it would display an error and leave the two files uncombined. The second upgrades svtplay-dl to the latest version, 4.18. Jessica Tallon (2): gnu: fix svtplay-dl wrapping to use ffmpeg gnu: svtplay-dl update to 4.18 gnu/packages/video.scm | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) -- 2.39.1 --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-fix-svtplay-dl-wrapping-to-use-ffmpeg.patch Content-Transfer-Encoding: quoted-printable Content-Description: Patch to fix ffmpeg issue >From e9d073dbf37323d11bddae32a1c54d65864959be Mon Sep 17 00:00:00 2001 Message-Id: In-Reply-To: References: From: Jessica Tallon Date: Sun, 5 Mar 2023 10:43:58 +0100 Subject: [PATCH 1/2] gnu: fix svtplay-dl wrapping to use ffmpeg * gnu/packages/video.scm (svtplay-dl): Wrap program to give access to ffmpe= g. --- gnu/packages/video.scm | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 13299fdf06..721f7c4d4e 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -64,6 +64,7 @@ ;;; Copyright =C2=A9 2022 Chadwain Holness ;;; Copyright =C2=A9 2022 Andy Tai ;;; Copyright =C2=A9 2023 Ott Joon +;;; Copyright =C2=A9 2023 Jessica Tallon ;;; ;;; This file is part of GNU Guix. ;;; @@ -5690,8 +5691,19 @@ (define-public svtplay-dl (base32 "0yjxmvldskw4pji3lg69pbx05izvxahz9my7z5p31mkiz6v33dmx")))) (build-system python-build-system) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (add-after 'install 'wrap-executable + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (ffmpeg (assoc-ref inputs "ffmpeg"))) + (wrap-program (string-append out "/bin/svtplay-dl") + `("PATH" ":" prefix + ,(list (string-append ffmpeg "/bin")))))))))) (inputs (list ffmpeg python-pyaml python-requests python-pysocks - python-cryptography)) + python-cryptography bash-minimal)) (home-page "https://svtplay-dl.se/") (synopsis "Download or stream SVT Play's (and others) TV programmes") (description --=20 2.39.1 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-gnu-svtplay-dl-update-to-4.18.patch Content-Description: Patch to update svtplay-dl to 4.18 >From 1b81f1786ba0cb038bf76ab74cbc90847d06206b Mon Sep 17 00:00:00 2001 Message-Id: <1b81f1786ba0cb038bf76ab74cbc90847d06206b.1678010569.git.tsyesika@tsyesika.se> In-Reply-To: References: From: Jessica Tallon Date: Sun, 5 Mar 2023 10:56:54 +0100 Subject: [PATCH 2/2] gnu: svtplay-dl update to 4.18 * gnu/packages/video.scm (svtplay-dl) update to 4.18 --- gnu/packages/video.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 721f7c4d4e..fbebaaff28 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -5680,7 +5680,7 @@ (define-public video-contact-sheet (define-public svtplay-dl (package (name "svtplay-dl") - (version "4.17") + (version "4.18") (source (origin (method git-fetch) (uri (git-reference @@ -5689,7 +5689,7 @@ (define-public svtplay-dl (file-name (git-file-name name version)) (sha256 (base32 - "0yjxmvldskw4pji3lg69pbx05izvxahz9my7z5p31mkiz6v33dmx")))) + "1xb2n3bwjddr86mjynbfd8m2g98gzqbj5mmsfc735q9xp14l30pf")))) (build-system python-build-system) (arguments (list -- 2.39.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 05 05:39:25 2023 Received: (at submit) by debbugs.gnu.org; 5 Mar 2023 10:39:25 +0000 Received: from localhost ([127.0.0.1]:38557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYlm0-0001pw-Fj for submit@debbugs.gnu.org; Sun, 05 Mar 2023 05:39:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:34796) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYllx-0001pi-R7 for submit@debbugs.gnu.org; Sun, 05 Mar 2023 05:39:23 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYllx-0001yW-IA for guix-patches@gnu.org; Sun, 05 Mar 2023 05:39:21 -0500 Received: from mout-p-102.mailbox.org ([2001:67c:2050:0:465::102]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pYllv-0004Va-Ay for guix-patches@gnu.org; Sun, 05 Mar 2023 05:39:21 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4PTyr21BTdz9sdQ; Sun, 5 Mar 2023 11:39:14 +0100 (CET) Date: Sun, 5 Mar 2023 11:39:10 +0100 From: Jessica Tallon To: Tobias Geerinckx-Rice Subject: Re: [bug#61117] Update svtplay-dl to 4.18 Message-ID: <20230305112617.3babd216@tsyesika.se> In-Reply-To: <87357ult1k.fsf@nckx> References: <5646122.DvuYhMxLoT@localhost.localdomain> <87357ult1k.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/hKS+q8zEHoSCgTjYOovsjLs" Received-SPF: pass client-ip=2001:67c:2050:0:465::102; envelope-from=tsyesika@tsyesika.se; helo=mout-p-102.mailbox.org X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 61117@debbugs.gnu.org, guix-patches@gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) --MP_/hKS+q8zEHoSCgTjYOovsjLs Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Hello, Sorry for the long delay on addressing this feedback. Tobias Geerinckx-Rice writes: > Jessica, > > Please avoid propagation whenever possible; it breaks all kinds of > nice things. > > Propagating A from B means that Guix will effectively =E2=80=98install=E2= =80=99 A > alongside B when the user installs only B. Or how classical package > managers bluntly handle =E2=80=98dependencies=E2=80=99. Not good! > Thanks for the tip, I've included a patch which does it this way. > >> it's needed while the program is running to merge two files, not >> while building. > > So 4.17 did not need or use ffmpeg this way? > > Otherwise, put each unrelated changes into a separate commit: one to > improve the ffmpeg situation, and one to update svtplay-dl. You can > send multiple related commits as one patch series to one bug number, > though. 4.17 did indeed need ffmpeg, I've included two patches one which resolves the ffmpeg issue and the other which updates it to 4.18. Thanks, Jessica. --MP_/hKS+q8zEHoSCgTjYOovsjLs Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0000-cover-letter.patch >From 1b81f1786ba0cb038bf76ab74cbc90847d06206b Mon Sep 17 00:00:00 2001 Message-Id: From: Jessica Tallon Date: Sun, 5 Mar 2023 11:02:49 +0100 Subject: [PATCH 0/2] Upgrade svtplay-dl to 4.18 & fix wrapping with ffmpeg The first patch fixes svtplay-dl which needs ffmpeg to create a unified file with both sound and video combined. Before it didn't have access to ffmpeg so it would display an error and leave the two files uncombined. The second upgrades svtplay-dl to the latest version, 4.18. Jessica Tallon (2): gnu: fix svtplay-dl wrapping to use ffmpeg gnu: svtplay-dl update to 4.18 gnu/packages/video.scm | 18 +++++++++++++++--- 1 file changed, 15 insertions(+), 3 deletions(-) -- 2.39.1 --MP_/hKS+q8zEHoSCgTjYOovsjLs Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-gnu-fix-svtplay-dl-wrapping-to-use-ffmpeg.patch =46rom e9d073dbf37323d11bddae32a1c54d65864959be Mon Sep 17 00:00:00 2001 Message-Id: In-Reply-To: References: From: Jessica Tallon Date: Sun, 5 Mar 2023 10:43:58 +0100 Subject: [PATCH 1/2] gnu: fix svtplay-dl wrapping to use ffmpeg * gnu/packages/video.scm (svtplay-dl): Wrap program to give access to ffmpe= g. --- gnu/packages/video.scm | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 13299fdf06..721f7c4d4e 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -64,6 +64,7 @@ ;;; Copyright =C2=A9 2022 Chadwain Holness ;;; Copyright =C2=A9 2022 Andy Tai ;;; Copyright =C2=A9 2023 Ott Joon +;;; Copyright =C2=A9 2023 Jessica Tallon ;;; ;;; This file is part of GNU Guix. ;;; @@ -5690,8 +5691,19 @@ (define-public svtplay-dl (base32 "0yjxmvldskw4pji3lg69pbx05izvxahz9my7z5p31mkiz6v33dmx")))) (build-system python-build-system) + (arguments + (list + #:phases + #~(modify-phases %standard-phases + (add-after 'install 'wrap-executable + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((out (assoc-ref outputs "out")) + (ffmpeg (assoc-ref inputs "ffmpeg"))) + (wrap-program (string-append out "/bin/svtplay-dl") + `("PATH" ":" prefix + ,(list (string-append ffmpeg "/bin")))))))))) (inputs (list ffmpeg python-pyaml python-requests python-pysocks - python-cryptography)) + python-cryptography bash-minimal)) (home-page "https://svtplay-dl.se/") (synopsis "Download or stream SVT Play's (and others) TV programmes") (description --=20 2.39.1 --MP_/hKS+q8zEHoSCgTjYOovsjLs Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0002-gnu-svtplay-dl-update-to-4.18.patch >From 1b81f1786ba0cb038bf76ab74cbc90847d06206b Mon Sep 17 00:00:00 2001 Message-Id: <1b81f1786ba0cb038bf76ab74cbc90847d06206b.1678010569.git.tsyesika@tsyesika.se> In-Reply-To: References: From: Jessica Tallon Date: Sun, 5 Mar 2023 10:56:54 +0100 Subject: [PATCH 2/2] gnu: svtplay-dl update to 4.18 * gnu/packages/video.scm (svtplay-dl) update to 4.18 --- gnu/packages/video.scm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index 721f7c4d4e..fbebaaff28 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -5680,7 +5680,7 @@ (define-public video-contact-sheet (define-public svtplay-dl (package (name "svtplay-dl") - (version "4.17") + (version "4.18") (source (origin (method git-fetch) (uri (git-reference @@ -5689,7 +5689,7 @@ (define-public svtplay-dl (file-name (git-file-name name version)) (sha256 (base32 - "0yjxmvldskw4pji3lg69pbx05izvxahz9my7z5p31mkiz6v33dmx")))) + "1xb2n3bwjddr86mjynbfd8m2g98gzqbj5mmsfc735q9xp14l30pf")))) (build-system python-build-system) (arguments (list -- 2.39.1 --MP_/hKS+q8zEHoSCgTjYOovsjLs-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 05 15:13:45 2023 Received: (at submit) by debbugs.gnu.org; 5 Mar 2023 20:13:45 +0000 Received: from localhost ([127.0.0.1]:40697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYujp-0002lG-I1 for submit@debbugs.gnu.org; Sun, 05 Mar 2023 15:13:45 -0500 Received: from lists.gnu.org ([209.51.188.17]:46118) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYujo-0002l8-5g for submit@debbugs.gnu.org; Sun, 05 Mar 2023 15:13:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYujn-0004Fa-SN for guix-patches@gnu.org; Sun, 05 Mar 2023 15:13:43 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYujl-0000o5-SN for guix-patches@gnu.org; Sun, 05 Mar 2023 15:13:43 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id ACAFF3200912; Sun, 5 Mar 2023 15:13:39 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 05 Mar 2023 15:13:40 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=mesmtp; t=1678047219; x=1678133619; bh=n/TIkB9nAIU0KRvld8F+866uHwabh3Sx9niuPdB7PCI=; b= Y/yY9lZmhYI2qjZ1tPr6RaDFvKLio9+EVnhhDPGDjLW7VbV2IvZjTuBaN0Otj5Ii HG5XeQOFRHxmMcMddCQ9SVb0zuuHriYIZznbveAq/1IYPIm+ZwYGg4RopRXGjovF NUf2cY/gV1N0COJ9F+PASpUc5K730aWvdziedK4z8wk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1678047219; x=1678133619; bh=n/TIkB9nAIU0K Rvld8F+866uHwabh3Sx9niuPdB7PCI=; b=pu65vJgRFNck4rSqKPSk8WxfpgrCu UNxEakA1+a99VTE5xMZihDD5FjVov9USvNQYVgVO+DIYhfmcQU2EvRGwFwNIjnpv 3SG6QFo/AGhteSn1VNjl8arJWfoRG4vJfyqR1GIS5CLC4CDgDYuVHe9m5ukL2Sql bhJkcq8/QIMTJBnCYG6qAjNI6KTROg9Dmwk485dKhaRtp+aBtYz/irtAukOHq2jS ZVUpKSqpn6GsLZEWOssbxd5L+oidE0tXv4U9+oxoQ2DmOeznpth9TIwIxRfGSmnC TymdHyxG//gf52aBER3/aA+44x6lxFaCi86lpPsIO/3O9UCLXWl0MFiVw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtgedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeuhfeffffgueduleehvdej leeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 Mar 2023 15:13:38 -0500 (EST) Date: Sun, 5 Mar 2023 15:13:36 -0500 From: Leo Famulari To: Tobias Geerinckx-Rice via Guix-patches via Subject: Re: [bug#61117] Update svtplay-dl to 4.18 Message-ID: References: <5646122.DvuYhMxLoT@localhost.localdomain> <87357ult1k.fsf@nckx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87357ult1k.fsf@nckx> Received-SPF: pass client-ip=64.147.123.20; envelope-from=leo@famulari.name; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Jessica Tallon , 61117@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Thanks again for working on this package! On Sat, Jan 28, 2023 at 01:33:44PM +0100, Tobias Geerinckx-Rice via Guix-patches via wrote: > > I've also moved ffmpeg form inputs to propagated-inputs > > Please avoid propagation whenever possible; it breaks all kinds of nice > things. I'm here to express my weak preference for dynamically binding FFmpeg in use cases like this one. That means, I prefer if packages like svtplay-dl do not depend on FFmpeg at all, but rather expect the user to install FFmpeg alongside them. I prefer this because I use a custom FFmpeg professionally as a video engineer, and it's easier to use it with Guix packages if the dependency is resolved at run-time rather than at build-time. I'd expect that many people like me also use a variety of custom FFmpeg builds for different use cases. Like I said, it's a weak preference. And I probably wouldn't use svtplay-dl at work in the US, although I do use youtube-dl / yt-dlp. Let me know what you think. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 05 15:35:32 2023 Received: (at submit) by debbugs.gnu.org; 5 Mar 2023 20:35:32 +0000 Received: from localhost ([127.0.0.1]:40742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYv4t-0003N7-PL for submit@debbugs.gnu.org; Sun, 05 Mar 2023 15:35:32 -0500 Received: from lists.gnu.org ([209.51.188.17]:39942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYv4r-0003Ms-Si for submit@debbugs.gnu.org; Sun, 05 Mar 2023 15:35:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYv4r-00088h-IL for guix-patches@gnu.org; Sun, 05 Mar 2023 15:35:29 -0500 Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pYv4p-00048Y-QG for guix-patches@gnu.org; Sun, 05 Mar 2023 15:35:29 -0500 Received: from smtp2.mailbox.org (smtp2.mailbox.org [10.196.197.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4PVD3s50h5z9sSb; Sun, 5 Mar 2023 21:35:21 +0100 (CET) References: <5646122.DvuYhMxLoT@localhost.localdomain> <87357ult1k.fsf@nckx> From: Jessica Tallon To: Leo Famulari Subject: Re: [bug#61117] Update svtplay-dl to 4.18 Date: Sun, 05 Mar 2023 21:15:14 +0100 In-reply-to: Message-ID: <87sfej3pj1.fsf@tsyesika.se> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2001:67c:2050:0:465::101; envelope-from=tsyesika@tsyesika.se; helo=mout-p-101.mailbox.org X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 61117@debbugs.gnu.org, Tobias Geerinckx-Rice via Guix-patches via X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Leo Famulari writes: > Thanks again for working on this package! > > On Sat, Jan 28, 2023 at 01:33:44PM +0100, Tobias Geerinckx-Rice via Guix-patches via wrote: >> > I've also moved ffmpeg form inputs to propagated-inputs >> >> Please avoid propagation whenever possible; it breaks all kinds of nice >> things. > > I'm here to express my weak preference for dynamically binding FFmpeg in > use cases like this one. > > That means, I prefer if packages like svtplay-dl do not depend on FFmpeg > at all, but rather expect the user to install FFmpeg alongside them. > > I prefer this because I use a custom FFmpeg professionally as a video > engineer, and it's easier to use it with Guix packages if the dependency > is resolved at run-time rather than at build-time. > > I'd expect that many people like me also use a variety of custom FFmpeg > builds for different use cases. > > Like I said, it's a weak preference. And I probably wouldn't use > svtplay-dl at work in the US, although I do use youtube-dl / yt-dlp. Let > me know what you think. Hello, Thanks for sharing your experiance, especially as a professional video engineer :) I think I have a mild opinion for having it bring in ffmpeg, this is mostly for three reasons: - There isn't a good way to communicate to users that they might wish to pull in ffmpeg. - svtplay-dl will download both audio and video parts and then realise it doesn't have ffmpeg and will give up producing a warning. This leaves it up to the user to fix, while a merging both files is a simple job it often has me searching through a manual as I'm not well versed in ffmpeg or similar. - I like it when things work consistantly (if x version of svtplay-dl works a specific way on my machine, it should on another machine, not dependent on my profile) My preference is mild though, let me know what you think! Thanks, Jessica. From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 05 15:58:36 2023 Received: (at submit) by debbugs.gnu.org; 5 Mar 2023 20:58:36 +0000 Received: from localhost ([127.0.0.1]:40841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYvRE-00044V-AL for submit@debbugs.gnu.org; Sun, 05 Mar 2023 15:58:36 -0500 Received: from lists.gnu.org ([209.51.188.17]:59088) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYvRC-00044M-FX for submit@debbugs.gnu.org; Sun, 05 Mar 2023 15:58:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYvRC-00011m-63 for guix-patches@gnu.org; Sun, 05 Mar 2023 15:58:34 -0500 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYvRA-0008EH-Ce for guix-patches@gnu.org; Sun, 05 Mar 2023 15:58:33 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 29D703200996; Sun, 5 Mar 2023 15:58:30 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 05 Mar 2023 15:58:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=mesmtp; t=1678049909; x=1678136309; bh=+FchpFyV7V0n+ypjtnGUC4s95Xl9I6KNxcgcDFBqhvA=; b= Y9+krCeHqGTGpHWk82eDpg66GckZt+bhDXaOR8LghmyGKAwDRQA4PvrRSAPvTdzg EV8Iy0dD607uvb7CeL6urr7M2ivyi7ElT0+Ix8fOHy3g2HCds5W3XWoKlyG3Qp+p G2FYZ34uL3j1B1IiygyoI2IexfMYxQqvTu7QiytlRoQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1678049909; x=1678136309; bh=+FchpFyV7V0n+ ypjtnGUC4s95Xl9I6KNxcgcDFBqhvA=; b=NmO20MyFAz2bUU9hqcXloho/66fdu SlyQyOMQCRUILV+BsLKN71rD/GY1ahNDkz16fXrrPFU3H0KnkQuIkHLZETqKM3Qs M1HFcbWT8Xxay6dAbr35x6lvzKBG2LIDVUYQzn0NRsP+8+zftdCiZeoWuh4irGfW dyxrLr7IIGdGsiIuB0bR+dYadGXX1UZbJeKY4u0BdOGWOFf6eiuLaWQ5TfbRyKfo puz/SwMsuEcoUg4n7HkxGd2Gs2G4lbcLzSJzBAjD4j5oNZebekVbK6gE19BTurbd DzN7YEKDZLK8RMTEIIw3QyOv18Tkx87MXuHOMOKd+xl9/MwNS++vhS+uw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddtgedgudegfecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvgho ucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrg htthgvrhhnpeeiteduheefkeeufeelgeduhfejgfelheefleeuhfeffffgueduleehvdej leeiteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 Mar 2023 15:58:29 -0500 (EST) Date: Sun, 5 Mar 2023 15:58:27 -0500 From: Leo Famulari To: Jessica Tallon Subject: Re: [bug#61117] Update svtplay-dl to 4.18 Message-ID: References: <5646122.DvuYhMxLoT@localhost.localdomain> <87357ult1k.fsf@nckx> <87sfej3pj1.fsf@tsyesika.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87sfej3pj1.fsf@tsyesika.se> Received-SPF: pass client-ip=64.147.123.20; envelope-from=leo@famulari.name; helo=wout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: 61117@debbugs.gnu.org, Tobias Geerinckx-Rice via Guix-patches via X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) On Sun, Mar 05, 2023 at 09:15:14PM +0100, Jessica Tallon wrote: > I think I have a mild opinion for having it bring in ffmpeg, this is > mostly for three reasons: > > - There isn't a good way to communicate to users that they might wish to > pull in ffmpeg. > > - svtplay-dl will download both audio and video parts and then realise > it doesn't have ffmpeg and will give up producing a warning. This > leaves it up to the user to fix, while a merging both files is a > simple job it often has me searching through a manual as I'm not well > versed in ffmpeg or similar. > > - I like it when things work consistantly (if x version of svtplay-dl > works a specific way on my machine, it should on another machine, not > dependent on my profile) > > My preference is mild though, let me know what you think! I think you should go with your method!