From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jan 2023 20:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61104@debbugs.gnu.org Cc: Yuan Fu , Theodor Thornhill X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Reply-To: jostein@kjonigsen.net Received: via spool by submit@debbugs.gnu.org id=B.167485048522343 (code B ref -1); Fri, 27 Jan 2023 20:15:02 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jan 2023 20:14:45 +0000 Received: from localhost ([127.0.0.1]:38563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLV7T-0005oI-NM for submit@debbugs.gnu.org; Fri, 27 Jan 2023 15:14:44 -0500 Received: from lists.gnu.org ([209.51.188.17]:40392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLV7Q-0005o7-Fc for submit@debbugs.gnu.org; Fri, 27 Jan 2023 15:14:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLV7Q-0001kr-8z for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 15:14:40 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLV7M-0007mP-SA for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 15:14:39 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 38FDC5C00EB; Fri, 27 Jan 2023 15:14:34 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 27 Jan 2023 15:14:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:reply-to:sender :subject:subject:to:to; s=fm2; t=1674850474; x=1674936874; bh=FQ YdAFiDTCvqZOOyzcYbEbx2rY7+LdB0TWbZjPcgbNk=; b=mmF6UG3eqMFRkc4urE WLojJ0srcMyUk5G9IVnqGzXpePLNyN7M1BbZ2VSihHyQszi0WC+n8jOLb7d666pX zhcy/Be8SdWPd1KR1txOlnX5m7buUSfRNsFTayY8Ru9REiLmC0ktoxwH0p5JZQoJ C76Eg+BHw+8hIZDy8wzKClEPoU0AU3sRO1dGcLqitDVAwBqkisaDkU66j6wq1M9P Nb60tq8RZ3AKvT2mHRByHFC4+UifmE3aLQY30e+0WDqRnoAmMu6OiAITuRweDLgF iMN22wctgBfvzAPJ62yZbkpux+oF+lPXcS1zpZZ2JxcvJdgEYcbDJZoVkRgRBRUk 6Wgw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1674850474; x=1674936874; bh=FQYdAFiDTCvqZOOyzcYbEbx2rY7+LdB0TWb ZjPcgbNk=; b=XVQe/KQRQ8u+EfQefsSOMr8oDkrgAkrGF9kLhCUu1gVy3nDr1Fd qio33q1d4uJ665kJ352r5gnlYKB1ZVYOoJlqU2Uh/BL9UnAQfPaqa4zqET3G+Est dV5YumjxNgJZa6kV44QyLfmCD5dNev7VzuZLWeSykUMm+cgk8lnqD3ZoCo/Ew/r6 4N9ftRyfd6qqe3++32YWdV798IVBiM4QibK1GaSv8Y2xSqMHshwAmoG8s9hpszqY roLyaEQQrObej6Ea8hseYNcQPFUO7YYdOS0LWmMISJ+bb6o4kbTZmQT1jcDJApOJ 3K1qOJbYAhPQMSxFmZs4wsksVtJ0y/YAfOg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddviedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfvfevrhfhufesrgdtreertdefjeenucfhrhhomheplfhoshht vghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjohhnih hgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepveevlefgteevgfekveduieelvdff iedvfeelieekudeuffefgeefgfejkeejteeinecuffhomhgrihhnpehkjhhnihhgshgvnh drnhhonecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep jhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 27 Jan 2023 15:14:32 -0500 (EST) Content-Type: multipart/alternative; boundary="------------LV6ynPTaRhGE7TnrpiNzNYb1" Message-ID: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> Date: Fri, 27 Jan 2023 21:14:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-GB, nb-NO From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Received-SPF: pass client-ip=66.111.4.26; envelope-from=jostein@secure.kjonigsen.net; helo=out2-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) This is a multi-part message in MIME format. --------------LV6ynPTaRhGE7TnrpiNzNYb1 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit When compiling a TypeScript project using tsc (or other tooling) from Emacs, compilation errors and warnings are not highlighted by compilation-mode. Consider the following output: src/resources/document.ts:140:22 - error TS2362: The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type. 140       return `File-${new Date() * 1}${ext}`;                          ~~~~~~~~~~ This output should cause compilation-mode to highlight the error and provide code-navigation. I know we explicitly added support for this to typescript.el back in the days, but I'm not sure what the "right" thing to do is now that typescrip-ts-mode is a first class Emacs citizen. Should we add compilation-mode patterns directly to the major-mode, or should we provide patches to compile.el instead? Does anyone have any strong opinion or guidance here? -- Jostein In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, GTK+ Version  3.24.36, cairo version 1.17.6) of 2023-01-26 built on thinkpad-t14s Repository revision: f8c95d1a7681e861fc22d2a040cda0ddfe23eff4 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12201007 System Description: Arch Linux Configured using:  'configure --with-json --with-tree-sitter' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings:   value of $LANG: en_US.UTF-8   locale-coding-system: utf-8-unix Major mode: JSON Minor modes in effect:   global-git-commit-mode: t   magit-auto-revert-mode: t   electric-pair-mode: t   highlight-symbol-mode: t   flycheck-mode: t   editorconfig-mode: t   company-mode: t   which-function-mode: t   helm-mode: t   helm-minibuffer-history-mode: t   shell-dirtrack-mode: t   helm--remap-mouse-mode: t   async-bytecomp-package-mode: t   delete-selection-mode: t   global-auto-revert-mode: t   yas-global-mode: t   yas-minor-mode: t   global-nlinum-mode: t   nlinum-mode: t   ido-yes-or-no-mode: t   override-global-mode: t   server-mode: t   global-hl-line-mode: t   pixel-scroll-precision-mode: t   doom-modeline-mode: t   tooltip-mode: t   global-eldoc-mode: t   show-paren-mode: t   electric-indent-mode: t   mouse-wheel-mode: t   menu-bar-mode: t   file-name-shadow-mode: t   global-font-lock-mode: t   font-lock-mode: t   blink-cursor-mode: t   column-number-mode: t   line-number-mode: t   transient-mark-mode: t   auto-composition-mode: t   auto-encryption-mode: t   auto-compression-mode: t   hs-minor-mode: t Load-path shadows: /home/jostein/.emacs.d/elpa/transient-20230107.1528/transient hides /home/jostein/build/emacs/lisp/transient Features: (shadow sort mail-extr emacsbug help-fns radix-tree cl-print json-ts-mode dired-aux textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnutls network-stream url-http url-gw nsm url-cache url-auth goto-addr misearch multi-isearch flyspell ispell magit-extras magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log magit-diff smerge-mode diff git-commit log-edit message sendmail yank-media rfc822 mml mml-sec epa derived epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader pcvs-util magit-core magit-autorevert magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section crm helm-command helm-elisp helm-eval edebug helm-info vc-git diff-mode vc-dispatcher disp-table bug-reference winner ffap tramp-archive tramp-gvfs tramp-cache time-stamp zeroconf dbus face-remap executable markdown-mode color add-log elec-pair typescript-ts-mode js c-ts-common cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs treesit vc-svn ido-completing-read+ memoize minibuf-eldef elisp-slime-nav paredit highlight-symbol flycheck editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch company-oddmuse company-keywords company-etags etags fileloop generator company-gtags company-dabbrev-code company-dabbrev company-files company-clang company-capf company-cmake company-semantic company-template company-bbdb company eglot external-completion array jsonrpc ert ewoc debug backtrace flymake-proc flymake warnings which-func hideshow eww url-queue thingatpt shr pixel-fill kinsoku url-file svg xml dom puny mm-url gnus nnheader gnus-util mail-utils range mm-util mail-prsvr helm-imenu helm-mode helm-misc helm-files image-dired image-dired-tags image-dired-external image-dired-util xdg image-mode dired dired-loaddefs exif tramp tramp-loaddefs trampver tramp-integration cus-edit pp cus-load wid-edit files-x tramp-compat shell parse-time iso8601 ls-lisp helm-buffers helm-occur helm-tags helm-locate helm-grep helm-regexp helm-utils helm-help helm-types helm helm-global-bindings helm-easymenu helm-core async-bytecomp helm-source helm-multi-match helm-lib async pcase imenu ob-plantuml org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete org-list org-footnote org-faces org-entities time-date noutline outline icons ob-emacs-lisp ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs format-spec delsel autorevert filenotify yasnippet nlinum linum ido-yes-or-no advice ido edmacro kmacro use-package-bind-key bind-key easy-mmode xref project server hl-line pixel-scroll cua-base compile-eslint compile text-property-search comint ansi-osc ansi-color ring doom-modeline doom-modeline-segments doom-modeline-env doom-modeline-core all-the-icons all-the-icons-faces data-material data-weathericons data-octicons data-fileicons data-faicons data-alltheicons shrink-path rx f f-shortdoc s dash compat dracula-theme cl-extra help-mode use-package-ensure use-package-core finder-inf yasnippet-autoloads ido-yes-or-no-autoloads elisp-slime-nav-autoloads cmake-mode-autoloads flycheck-autoloads pkg-info-autoloads magit-autoloads all-the-icons-autoloads crontab-mode-autoloads powershell-autoloads doom-modeline-autoloads undo-tree-autoloads rust-mode-autoloads magit-section-autoloads paredit-autoloads dracula-theme-autoloads cargo-autoloads yaml-mode-autoloads helm-autoloads popup-autoloads queue-autoloads nlinum-autoloads bmx-mode-autoloads company-autoloads git-commit-autoloads multiple-cursors-autoloads dap-mode-autoloads lsp-treemacs-autoloads treemacs-autoloads cfrs-autoloads posframe-autoloads hydra-autoloads pfuture-autoloads ace-window-autoloads avy-autoloads bui-autoloads transient-autoloads ido-completing-read+-autoloads memoize-autoloads with-editor-autoloads compat-autoloads epl-autoloads lsp-docker-autoloads yaml-autoloads highlight-symbol-autoloads expand-region-autoloads lsp-mode-autoloads lv-autoloads markdown-mode-autoloads spinner-autoloads ht-autoloads shrink-path-autoloads f-autoloads dash-autoloads s-autoloads info editorconfig-autoloads helm-core-autoloads async-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 903185 104000)  (symbols 48 46499 0)  (strings 32 231885 9884)  (string-bytes 1 6411082)  (vectors 16 124883)  (vector-slots 8 2338056 282804)  (floats 8 984 1046)  (intervals 56 17029 3032)  (buffers 984 62)) -- Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no --------------LV6ynPTaRhGE7TnrpiNzNYb1 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

When compiling a TypeScript project using tsc (or other tooling) from Emacs,
compilation errors and warnings are not highlighted by compilation-mode.

Consider the following output:

src/resources/document.ts:140:22 - error TS2362: The left-hand side of an arithmetic operation must be of type 'any', 'number', 'bigint' or an enum type.

140       return `File-${new Date() * 1}${ext}`;
                         ~~~~~~~~~~

This output should cause compilation-mode to highlight the error and provide code-navigation.

I know we explicitly added support for this to typescript.el back in the days, but I'm not
sure what the "right" thing to do is now that typescrip-ts-mode is a first class Emacs citizen.

Should we add compilation-mode patterns directly to the major-mode, or should we provide
patches to compile.el instead?

Does anyone have any strong opinion or guidance here?

--
Jostein


In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, GTK+ Version
 3.24.36, cairo version 1.17.6) of 2023-01-26 built on thinkpad-t14s
Repository revision: f8c95d1a7681e861fc22d2a040cda0ddfe23eff4
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12201007
System Description: Arch Linux

Configured using:
 'configure --with-json --with-tree-sitter'

Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG
JSON LCMS2 LIBOTF LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY
PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS
TREE_SITTER WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: JSON

Minor modes in effect:
  global-git-commit-mode: t
  magit-auto-revert-mode: t
  electric-pair-mode: t
  highlight-symbol-mode: t
  flycheck-mode: t
  editorconfig-mode: t
  company-mode: t
  which-function-mode: t
  helm-mode: t
  helm-minibuffer-history-mode: t
  shell-dirtrack-mode: t
  helm--remap-mouse-mode: t
  async-bytecomp-package-mode: t
  delete-selection-mode: t
  global-auto-revert-mode: t
  yas-global-mode: t
  yas-minor-mode: t
  global-nlinum-mode: t
  nlinum-mode: t
  ido-yes-or-no-mode: t
  override-global-mode: t
  server-mode: t
  global-hl-line-mode: t
  pixel-scroll-precision-mode: t
  doom-modeline-mode: t
  tooltip-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  column-number-mode: t
  line-number-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  hs-minor-mode: t

Load-path shadows:
/home/jostein/.emacs.d/elpa/transient-20230107.1528/transient hides /home/jostein/build/emacs/lisp/transient

Features:
(shadow sort mail-extr emacsbug help-fns radix-tree cl-print
json-ts-mode dired-aux textsec uni-scripts idna-mapping ucs-normalize
uni-confusable textsec-check gnutls network-stream url-http url-gw nsm
url-cache url-auth goto-addr misearch multi-isearch flyspell ispell
magit-extras magit-submodule magit-obsolete magit-blame magit-stash
magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone
magit-remote magit-commit magit-sequence magit-notes magit-worktree
magit-tag magit-merge magit-branch magit-reset magit-files magit-refs
magit-status magit magit-repos magit-apply magit-wip magit-log
magit-diff smerge-mode diff git-commit log-edit message sendmail
yank-media rfc822 mml mml-sec epa derived epg rfc6068 epg-config
mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045
ietf-drums mailabbrev gmm-utils mailheader pcvs-util magit-core
magit-autorevert magit-margin magit-transient magit-process with-editor
magit-mode transient magit-git magit-base magit-section crm helm-command
helm-elisp helm-eval edebug helm-info vc-git diff-mode vc-dispatcher
disp-table bug-reference winner ffap tramp-archive tramp-gvfs
tramp-cache time-stamp zeroconf dbus face-remap executable markdown-mode
color add-log elec-pair typescript-ts-mode js c-ts-common cc-mode
cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars
cc-defs treesit vc-svn ido-completing-read+ memoize minibuf-eldef
elisp-slime-nav paredit highlight-symbol flycheck editorconfig
editorconfig-core editorconfig-core-handle editorconfig-fnmatch
company-oddmuse company-keywords company-etags etags fileloop generator
company-gtags company-dabbrev-code company-dabbrev company-files
company-clang company-capf company-cmake company-semantic
company-template company-bbdb company eglot external-completion array
jsonrpc ert ewoc debug backtrace flymake-proc flymake warnings
which-func hideshow eww url-queue thingatpt shr pixel-fill kinsoku
url-file svg xml dom puny mm-url gnus nnheader gnus-util mail-utils
range mm-util mail-prsvr helm-imenu helm-mode helm-misc helm-files
image-dired image-dired-tags image-dired-external image-dired-util xdg
image-mode dired dired-loaddefs exif tramp tramp-loaddefs trampver
tramp-integration cus-edit pp cus-load wid-edit files-x tramp-compat
shell parse-time iso8601 ls-lisp helm-buffers helm-occur helm-tags
helm-locate helm-grep helm-regexp helm-utils helm-help helm-types helm
helm-global-bindings helm-easymenu helm-core async-bytecomp helm-source
helm-multi-match helm-lib async pcase imenu ob-plantuml org ob ob-tangle
ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete
pcomplete org-list org-footnote org-faces org-entities time-date
noutline outline icons ob-emacs-lisp ob-core ob-eval org-cycle org-table
ol org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu
calendar cal-loaddefs org-version org-compat org-macs format-spec delsel
autorevert filenotify yasnippet nlinum linum ido-yes-or-no advice ido
edmacro kmacro use-package-bind-key bind-key easy-mmode xref project
server hl-line pixel-scroll cua-base compile-eslint compile
text-property-search comint ansi-osc ansi-color ring doom-modeline
doom-modeline-segments doom-modeline-env doom-modeline-core
all-the-icons all-the-icons-faces data-material data-weathericons
data-octicons data-fileicons data-faicons data-alltheicons shrink-path
rx f f-shortdoc s dash compat dracula-theme cl-extra help-mode
use-package-ensure use-package-core finder-inf yasnippet-autoloads
ido-yes-or-no-autoloads elisp-slime-nav-autoloads cmake-mode-autoloads
flycheck-autoloads pkg-info-autoloads magit-autoloads
all-the-icons-autoloads crontab-mode-autoloads powershell-autoloads
doom-modeline-autoloads undo-tree-autoloads rust-mode-autoloads
magit-section-autoloads paredit-autoloads dracula-theme-autoloads
cargo-autoloads yaml-mode-autoloads helm-autoloads popup-autoloads
queue-autoloads nlinum-autoloads bmx-mode-autoloads company-autoloads
git-commit-autoloads multiple-cursors-autoloads dap-mode-autoloads
lsp-treemacs-autoloads treemacs-autoloads cfrs-autoloads
posframe-autoloads hydra-autoloads pfuture-autoloads
ace-window-autoloads avy-autoloads bui-autoloads transient-autoloads
ido-completing-read+-autoloads memoize-autoloads with-editor-autoloads
compat-autoloads epl-autoloads lsp-docker-autoloads yaml-autoloads
highlight-symbol-autoloads expand-region-autoloads lsp-mode-autoloads
lv-autoloads markdown-mode-autoloads spinner-autoloads ht-autoloads
shrink-path-autoloads f-autoloads dash-autoloads s-autoloads info
editorconfig-autoloads helm-core-autoloads async-autoloads package
browse-url url url-proxy url-privacy url-expand url-methods url-history
url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers
url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache
json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs
cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify
ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode lisp-mode prog-mode register
page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads dbusbind inotify lcms2 dynamic-setting system-font-setting
font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty
make-network-process emacs)

Memory information:
((conses 16 903185 104000)
 (symbols 48 46499 0)
 (strings 32 231885 9884)
 (string-bytes 1 6411082)
 (vectors 16 124883)
 (vector-slots 8 2338056 282804)
 (floats 8 984 1046)
 (intervals 56 17029 3032)
 (buffers 984 62))

--
Vennlig hilsen
 Jostein Kjønigsen
jostein@kjonigsen.net 🍵 jostein@gmail.com
 https://jostein.kjønigsen.no
--------------LV6ynPTaRhGE7TnrpiNzNYb1-- From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jan 2023 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: jostein@kjonigsen.net Cc: casouri@gmail.com, 61104@debbugs.gnu.org, theo@thornhill.no Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167485142924044 (code B ref 61104); Fri, 27 Jan 2023 20:31:02 +0000 Received: (at 61104) by debbugs.gnu.org; 27 Jan 2023 20:30:29 +0000 Received: from localhost ([127.0.0.1]:38570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLVMj-0006Fk-8r for submit@debbugs.gnu.org; Fri, 27 Jan 2023 15:30:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58694) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLVMh-0006FX-0D for 61104@debbugs.gnu.org; Fri, 27 Jan 2023 15:30:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLVMb-00035D-47; Fri, 27 Jan 2023 15:30:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=bmE4ksOsePkfdgVVvLi3BlX7tmBEXw7SSLppZ/qXaoo=; b=X/PZdC1VXK56Ud7uEieI Ru+ZMJ8g6ZtXVmIuRMh9EDO0sXnMq9wUdZEyUdTxvQLJ2zTLYikTji0HUPcuV6KpFsKFQNDiJylj2 LhbTYg+LlsCQI7Yy7PUjSTor1hSC1V+e2oxLRom8LLdECAaa5YVN+SjU8k8mWTSg3bHAnEkzReiFk 8HRLHCds3KYuQar+8kGxUiPuJsjC9K3tQd7ooZ3Ui+VrGjz9nnlCj4XdOzi2tRnCpfBuQZuWCz74r 5O77L14EQPfA+lincDaLjISWTonOr/pn/s4UJHBr7R9v8S8k+BxOAYOg4DQMWAyQNhYdvbhtiYgjo kTsOrQXesegxzg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLVMX-0002M8-2i; Fri, 27 Jan 2023 15:30:17 -0500 Date: Fri, 27 Jan 2023 22:30:02 +0200 Message-Id: <83o7qjbu0l.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> (message from Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= on Fri, 27 Jan 2023 21:14:30 +0100) References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Yuan Fu , Theodor Thornhill > Date: Fri, 27 Jan 2023 21:14:30 +0100 > From: Jostein Kjønigsen > > When compiling a TypeScript project using tsc (or other tooling) from Emacs, > compilation errors and warnings are not highlighted by compilation-mode. > > Consider the following output: > > src/resources/document.ts:140:22 - error TS2362: The left-hand side of an arithmetic operation must be of > type 'any', 'number', 'bigint' or an enum type. > > 140 return `File-${new Date() * 1}${ext}`; > ~~~~~~~~~~ > > This output should cause compilation-mode to highlight the error and provide code-navigation. > > I know we explicitly added support for this to typescript.el back in the days, but I'm not > sure what the "right" thing to do is now that typescrip-ts-mode is a first class Emacs citizen. > > Should we add compilation-mode patterns directly to the major-mode, or should we provide > patches to compile.el instead? Why isn't this part of compilation-error-regexp-alist-alist? From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jan 2023 20:53:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , jostein@kjonigsen.net Cc: casouri@gmail.com, 61104@debbugs.gnu.org, theo@thornhill.no Reply-To: jostein@kjonigsen.net Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167485275426553 (code B ref 61104); Fri, 27 Jan 2023 20:53:03 +0000 Received: (at 61104) by debbugs.gnu.org; 27 Jan 2023 20:52:34 +0000 Received: from localhost ([127.0.0.1]:38633 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLVi6-0006uD-5Z for submit@debbugs.gnu.org; Fri, 27 Jan 2023 15:52:34 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:35307) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLVi3-0006tv-G6 for 61104@debbugs.gnu.org; Fri, 27 Jan 2023 15:52:32 -0500 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 65E305C00F2; Fri, 27 Jan 2023 15:52:26 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 27 Jan 2023 15:52:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm2; t=1674852746; x=1674939146; bh=Cr IfAOM7YIgRyJUKSg0R4KQkz6gTwjxke48BdjmY0P4=; b=M4TBTp1X6RhMV6YQ83 ThOUWNjvsMwPkoxv7JuA7V2lqNQedCdajOChblrcMzEs5a1/URro1FZZgaDshG7d f49a2KYzeEULjFvqbAw+c8vTuwv8FZqBf7IhYox7m+eBH0faXc6CRZJq2NfBLkiO 0jcQOG5apzO286vLYjGNaFyv3HzGBHBVPvoxGgFntj5eP5TSI7KYrwy7cKIY1qZf Vg3Vc2EPOihRS6doDyHMVc2PrgXMAKLXxv6vGYFSke7cToRmdKH1TyDr6avB914g HKtID0FD323nEqELcPn0ec2q08XXnzcEXBfRmrNqZD11d1ZsSmIxF1ZLuDCUUbnr Fazg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1674852746; x=1674939146; bh=CrIfAOM7YIgRyJUKSg0R4KQkz6gTwjxke48 BdjmY0P4=; b=QrQBHhFaT7VfwHbrQDbUwW/IG685AstyFTBNwo7PrNVXXoRMnHU TUp5Rnjdt4JG7sd9HA8tlo12PSu7PgYtw5N63bRkQ8uiIIoIKYFWN88IqpgewmER abji+r4ko0ltdSwOXE8Bo7oGUUo+jYDGlYvMLxKE+S07US7EknAGd4/fyTkLG2uq jqZydf38PSsEdC+F8zMe9Y9RrBP2Em+35Vh2m7dISGH/vCqwCiYZcZ3gA8nNO40z H/5lu074bmyrx9TGZz5v+NJTZDEnQUcHXzfRH1C3bGpxIS+w4xMZ4yU/LPDfkf0A pn75wOvSeQ+BhIAxUTXVjaX6w/loNTJ9VKA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddviedgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfghruffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefl ohhsthgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjh honhhighhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpefhgeevvefhfeeffedtvdfh vdeiieffheeiheegheegtddtkeevffelteetgedvjeenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgvihhnsehsvggtuhhrvgdrkhhj ohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 27 Jan 2023 15:52:25 -0500 (EST) Message-ID: Date: Fri, 27 Jan 2023 21:52:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-GB, nb-NO References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= In-Reply-To: <83o7qjbu0l.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.8 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 1/27/23 21:30, Eli Zaretskii wrote: > > Why isn't this part of compilation-error-regexp-alist-alist? That is obviously what I think we should do. We already have good and tested matcher expressions for this. I was just uncertain about what the conventional way of adding those expressions to Emacs: - adding it directly in the relevant major-mode's source-file, to improve code-locality? - adding it in compile.el, to improve ability to oversee all expressions, and be able to optimize those? I see csharp-mode.el has the expressions added directly there. Should I go about preparing patches doing the same for typescript-ts-mode too? -- Jostein From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2023 07:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: jostein@kjonigsen.net Cc: casouri@gmail.com, 61104@debbugs.gnu.org, theo@thornhill.no Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167489061627557 (code B ref 61104); Sat, 28 Jan 2023 07:24:01 +0000 Received: (at 61104) by debbugs.gnu.org; 28 Jan 2023 07:23:36 +0000 Received: from localhost ([127.0.0.1]:39424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLfYm-0007AP-Dj for submit@debbugs.gnu.org; Sat, 28 Jan 2023 02:23:36 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54232) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLfYh-0007A8-4t for 61104@debbugs.gnu.org; Sat, 28 Jan 2023 02:23:34 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLfYb-0000s4-4J; Sat, 28 Jan 2023 02:23:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=omsAFMicTH8xBPSK8ZhRG/2puwkSJcUo9h/IZCJkVeo=; b=IwVOPgBkx6ziihvflYH0 EX415qwzQdj8yaRZXigT8/RtD9OyD1Geb+/89sy2K8GXS1SyiRVXjXkLRyQyZuoUKZBAyp6xZckVF lZUfmKoDuyBI36y8nODzpo1Cxv4/eIO30K7IydlgQnRA93VduwR4OpHKEDxrasRb0FHVvoHGxlKlA S2GiUly0smFqzBdL80Dqrur86MF6TIJQ3eerPAoXE35z1WmURJnKSsE+tiIGSaeNx2KLfh1I9g1Ed NhYL0k+CyZbDOhPxgSzIbzr4U/gQU6GrtGztr/8IZDJWlnmCmq5kG+u4YfCuEsrxxE8X8fVoyYl19 s5mqOpLynjukVg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLfYY-0003s0-R1; Sat, 28 Jan 2023 02:23:24 -0500 Date: Sat, 28 Jan 2023 09:23:10 +0200 Message-Id: <83lelnazs1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= on Fri, 27 Jan 2023 21:52:24 +0100) References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 27 Jan 2023 21:52:24 +0100 > Cc: 61104@debbugs.gnu.org, casouri@gmail.com, theo@thornhill.no > From: Jostein Kjønigsen > > On 1/27/23 21:30, Eli Zaretskii wrote: > > > > Why isn't this part of compilation-error-regexp-alist-alist? > > That is obviously what I think we should do. > We already have good and tested matcher expressions for this. > > I was just uncertain about what the conventional way of adding those > expressions to Emacs: > > - adding it directly in the relevant major-mode's source-file, to > improve code-locality? I don't think doing this in the major-mode file will improve locality, because we have compilation-minor-mode, which should be able to do its thing even if the relevant major mode is not yet loaded. > - adding it in compile.el, to improve ability to oversee all > expressions, and be able to optimize those? > > I see csharp-mode.el has the expressions added directly there. Should I > go about preparing patches doing > the same for typescript-ts-mode too? I don't see why not. From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2023 14:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , jostein@kjonigsen.net Cc: casouri@gmail.com, 61104@debbugs.gnu.org, theo@thornhill.no Reply-To: jostein@kjonigsen.net Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.16749160951371 (code B ref 61104); Sat, 28 Jan 2023 14:29:02 +0000 Received: (at 61104) by debbugs.gnu.org; 28 Jan 2023 14:28:15 +0000 Received: from localhost ([127.0.0.1]:39950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLmBi-0000M3-GY for submit@debbugs.gnu.org; Sat, 28 Jan 2023 09:28:14 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:35603) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLmBg-0000Lr-Mf for 61104@debbugs.gnu.org; Sat, 28 Jan 2023 09:28:13 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A2C405C00EB; Sat, 28 Jan 2023 09:28:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sat, 28 Jan 2023 09:28:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm2; t= 1674916087; x=1675002487; bh=PTaNJmWTplLzDhnSQNe8ZOAgqzgNw9RRLCl v55DjC48=; b=Wzjt6cN8cpp2C+R0P0j749JrKRbDI8sjR7f+N1+OijFA9jyZPuQ +L7huMgVF3P9SHDIFd2OqniokzKTz/0BegErNRliBs8WozKjeyx+b9uxDk38/JpZ CXHAtyO9ERY557WdGQjcyW57MflP2uM1DXrbB/L7WJ3p4s/asRUZsA+ReHnsj6FJ vo3Cj3lMzPm5f3NxbzDZl0wMw9d8ypI4ojk0NjOPGVpsua3cWQekdzTHasNy7/cO kEVEoRKCG7Sa7DYlqVU8FcUKATwkSzyTzGxuuTtbRaR7PAQh0FU1nW6zrN+PFL58 iNLrk20eEwMQ2DGPlUm5hgBep6Ibj4mrpIg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1674916087; x=1675002487; bh=PTaNJmWTplLzD hnSQNe8ZOAgqzgNw9RRLClv55DjC48=; b=Q6n78PFaGim+ry8eR56FoXuqoDCGK fQ/Fa/b+TU5hgVw7PGDTruIJl6vwo/+5jYp1Bk2dMu9FJX0Cn1FVJxIdn9VKO9vd ojizitAJrAOtlRtUvuFdBQXvcznONkCAeyeQlH/4mi+mJU3oa9z9O2Q9/XYrHDVN L8WlkgqwFKg7CFxvVDuDRW7qotOoorTt41cOHB6Zql+1AR7iwdq9eStNumMZ0IVk k9fNDXNBrXrxO5b3BAfZqzQSc1x7Gl+URhvovEgJPs3IYkz4iRdyiQaAG/tv0eic +y8JqA0CrC/q8p+/Nuezaat+qHteruF63lz1WhcA/tXdOp01sWfKeW9Vg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedruddvkedgieefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurheptgfkffggfghruffvvehfhfgjsehmtderredtfeejnecuhfhrohhmpeflohhs thgvihhnucfmjhppnhhighhsvghnuceojhhoshhtvghinhesshgvtghurhgvrdhkjhhonh highhsvghnrdhnvghtqeenucggtffrrghtthgvrhhnpedvfeeffeefieegueegkefgkeev tdevfeevffeghfdukeeffeevhefgheevhfehteenucffohhmrghinhepvghlrdhishenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehjohhsthgv ihhnsehsvggtuhhrvgdrkhhjohhnihhgshgvnhdrnhgvth X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 28 Jan 2023 09:28:06 -0500 (EST) Content-Type: multipart/mixed; boundary="------------7CEHBLLEaGIwiM07dWpz0ndT" Message-ID: Date: Sat, 28 Jan 2023 15:28:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-GB, nb-NO References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> <83lelnazs1.fsf@gnu.org> From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= In-Reply-To: <83lelnazs1.fsf@gnu.org> X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) This is a multi-part message in MIME format. --------------7CEHBLLEaGIwiM07dWpz0ndT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/28/23 08:23, Eli Zaretskii wrote: > > I don't think doing this in the major-mode file will improve locality, > because we have compilation-minor-mode, which should be able to do its > thing even if the relevant major mode is not yet loaded. Fair enough! > >> - adding it in compile.el, to improve ability to oversee all >> expressions, and be able to optimize those? >> >> I see csharp-mode.el has the expressions added directly there. Should I >> go about preparing patches doing >> the same for typescript-ts-mode too? > I don't see why not. Ok. Attached is a patch which adds Typescript tsc-support to compile.el. Is this OK to install in emacs-29? I also see in retrospect that my comment about csharp-mode above may been somewhat ambiguous and easy to misunderstand (and seemingly you did). To be clear: csharp-mode includes the compilation-mode regexps in the major-mode, not in compile.el. Is this also something we should aim to fix for emacs-29, or should we leave that for master? -- Jostein --------------7CEHBLLEaGIwiM07dWpz0ndT Content-Type: text/x-patch; charset=UTF-8; name="0001-Add-support-for-Typescript-compilation-to-compilatio.patch" Content-Disposition: attachment; filename*0="0001-Add-support-for-Typescript-compilation-to-compilatio.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSBiNjBjMDY4NmZjOTI1MjkwZmYyMDFlZDc5Mzk5ZTQ4ZWJjNDdkNmQwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogU2F0LCAyOCBKYW4gMjAyMyAx NToyMzoxMSArMDEwMApTdWJqZWN0OiBbUEFUQ0hdIEFkZCBzdXBwb3J0IGZvciBUeXBlc2Ny aXB0IGNvbXBpbGF0aW9uIHRvIGNvbXBpbGF0aW9uLW1vZGUKCi0tLQogbGlzcC9wcm9nbW9k ZXMvY29tcGlsZS5lbCB8IDE4ICsrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQs IDE4IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9jb21waWxl LmVsIGIvbGlzcC9wcm9nbW9kZXMvY29tcGlsZS5lbAppbmRleCA1NzU4ZWFkZjk5Ni4uMWU1 N2QwYjdiYjIgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2NvbXBpbGUuZWwKKysrIGIv bGlzcC9wcm9nbW9kZXMvY29tcGlsZS5lbApAQCAtNjQ5LDYgKzY0OSwyNCBAQCBjb21waWxh dGlvbi1lcnJvci1yZWdleHAtYWxpc3QtYWxpc3QKICAgICA7OyB3ZSBkbyBub3Qga25vdyB3 aGF0IGxpbmVzIHdpbGwgZm9sbG93LgogICAgIChndWlsZS1maWxlICJeSW4gXFwoLitcXC4u K1xcKTpcbiIgMSBuaWwgbmlsIDApCiAgICAgKGd1aWxlLWxpbmUgIl4gKlxcKFswLTldK1xc KTogKlxcKFswLTldK1xcKSIgbmlsIDEgMikKKworICAgIDs7IFR5cGVzY3JpcHQgY29tcGls YXRpb24gcHJpb3IgdG8gdHNjIHZlcnNpb24gMi43LCAicGxhaW4iIGZvcm1hdDoKKyAgICA7 OyBncmVldGVyLnRzKDMwLDEyKTogZXJyb3IgVFMyMzM5OiBQcm9wZXJ0eSAnZm9vJyBkb2Vz IG5vdCBleGlzdC4KKyAgICAodHlwZXNjcmlwdC10c2MtcGxhaW4KKyAgICAgLChjb25jYXQK KyAgICAgICJeW1s6Ymxhbms6XV0qIgorICAgICAgIlxcKFteKFxyXG4pXStcXCkoXFwoWzAt OV0rXFwpLFxcKFswLTldK1xcKSk6W1s6Ymxhbms6XV0rIgorICAgICAgImVycm9yIFtbOmFs bnVtOl1dKzogW15cclxuXSskIikKKyAgICAgMSAyIDMgMikKKworICAgIDs7IFR5cGVzY3Jp cHQgY29tcGlsYXRpb24gYWZ0ZXIgdHNjIHZlcnNpb24gMi43LCAicHJldHR5IiBmb3JtYXQ6 CisgICAgOzsgc3JjL3Jlc291cmNlcy9kb2N1bWVudC50czoxNDA6MjIgLSBlcnJvciBUUzIz NjI6IHNvbWV0aGluZy4KKyAgICAodHlwZXNjcmlwdC10c2MtcHJldHR5CisgICAgICwoY29u Y2F0CisgICAgICAgIl5bWzpibGFuazpdXSoiCisgICAgICAgIlxcKFteKFxyXG4pXStcXCk6 XFwoWzAtOV0rXFwpOlxcKFswLTldK1xcKSAtIFtbOmJsYW5rOl1dKiIKKyAgICAgICAiZXJy b3IgW1s6YWxudW06XV0rOiBbXlxyXG5dKyQiKQorICAgICAxIDIgMyAyKQogICAgICkpCiAg ICJBbGlzdCBvZiB2YWx1ZXMgZm9yIGBjb21waWxhdGlvbi1lcnJvci1yZWdleHAtYWxpc3Qn LiIpCiAKLS0gCjIuMzkuMQoK --------------7CEHBLLEaGIwiM07dWpz0ndT-- From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Feb 2023 21:02:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: casouri@gmail.com, 61104@debbugs.gnu.org, theo@thornhill.no Reply-To: jostein@kjonigsen.net Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167537168611401 (code B ref 61104); Thu, 02 Feb 2023 21:02:05 +0000 Received: (at 61104) by debbugs.gnu.org; 2 Feb 2023 21:01:26 +0000 Received: from localhost ([127.0.0.1]:35958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNghy-0002xp-4m for submit@debbugs.gnu.org; Thu, 02 Feb 2023 16:01:26 -0500 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:39515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNghw-0002wT-Hp for 61104@debbugs.gnu.org; Thu, 02 Feb 2023 16:01:25 -0500 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id CDEC63200920; Thu, 2 Feb 2023 16:01:17 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 02 Feb 2023 16:01:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm2; t= 1675371677; x=1675458077; bh=vShrelAKnsqs4slRmPra1bkvvrbz8nfWj7r fy/7qnMc=; b=YpbYcGtzdDnVkwvHpz4cZO/CcskzmFAUh1w9A4JErrcUDrsmtnG j08E8t4M46E3gxPB/Z+USzfKv0HbMHLUGQVV+emFP1s3LsXnziTeFG1JPqFkT7NV 1gc4liyYlj/ShPNgKHIZ4eiUCwyByzfQLG/3M3O9aTSYK0lo7rnjJydhqZvkPsG+ ki3PL58yrNJluMyGgDd0YnNQVkNKOBegOCSw7urwqbeuVEn6R5YhQPJBir364Em0 jlQ72MyM9yolVHBQQ/RguyXe6T3e2TC0SacPFKT0arkti7hNvO8J3/nPpsGmN3Pp XgHTyB1uDzm/XEbCBCk/ghPB0jXS/TuXFEw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1675371677; x=1675458077; bh=vShrelAKnsqs4 slRmPra1bkvvrbz8nfWj7rfy/7qnMc=; b=mgpI4aH1WFyLo63BF5+aA/OgIBtQN hFUHLWdkiGeWZg5mZ7ogOpbEVaYeLmsTS/NPEZYh7sYo9asO9ks91/76nrWFeI6I zxomcavoVBzMAJDwbfBuPXGvz78VHup6nIYVkhaOTxTCYZQwipqZJCAnnh82cxGb Mer79JkYLa+eApMNnOWjNSQX0XBvpjaBQ6ZqpRMlNKhFVk3ezo+1lxv2lYXy2JfJ OeFbuGurYPbwKEYgxUYlON4hCthPfnELgQ0gn5xGOhKziW3rhsVqwBIL1UzpjQy7 Dy/cG0lI+QZTu26r13Je+geGiNgTaegMpyOZTsEsaNGv5dFC9B82xlaEQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefkedgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfrhfuhffvvehfjgesrgdtreertdefjeenucfhrhhomheplfho shhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepvdegkedvhfelveekgedtffdt lefhheffuddutddtgeehieejffekvdejhfeiteelnecuffhomhgrihhnpehkjhhnihhgsh gvnhdrnhhopdgvlhdrihhsnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehm rghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvg ht X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 2 Feb 2023 16:01:15 -0500 (EST) Content-Type: multipart/alternative; boundary="------------EynyYrui00wTXy0tCpVleqw6" Message-ID: Date: Thu, 2 Feb 2023 22:01:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-GB, nb-NO From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> <83lelnazs1.fsf@gnu.org> In-Reply-To: X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) This is a multi-part message in MIME format. --------------EynyYrui00wTXy0tCpVleqw6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Any news on this one? Will this be merged? :) Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no On 1/28/23 15:28, Jostein Kjønigsen wrote: > > On 1/28/23 08:23, Eli Zaretskii wrote: >> >> I don't think doing this in the major-mode file will improve locality, >> because we have compilation-minor-mode, which should be able to do its >> thing even if the relevant major mode is not yet loaded. > Fair enough! >> >>> - adding it in compile.el, to improve ability to oversee all >>> expressions, and be able to optimize those? >>> >>> I see csharp-mode.el has the expressions added directly there. Should I >>> go about preparing patches doing >>> the same for typescript-ts-mode too? >> I don't see why not. > > Ok. Attached is a patch which adds Typescript tsc-support to > compile.el. Is this OK to install in emacs-29? > > I also see in retrospect that my comment about csharp-mode above may > been somewhat ambiguous and easy to misunderstand (and seemingly you > did). > > To be clear: csharp-mode includes the compilation-mode regexps in the > major-mode, not in compile.el. Is this also something we should aim to > fix for emacs-29, or should we leave that for master? > > -- > Jostein --------------EynyYrui00wTXy0tCpVleqw6 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Any news on this one? Will this be merged? :)

Vennlig hilsen
Jostein Kjønigsen

jostein@kjonigsen.net 🍵 jostein@gmail.com
https://jostein.kjønigsen.no
On 1/28/23 15:28, Jostein Kjønigsen wrote:

On 1/28/23 08:23, Eli Zaretskii wrote:

I don't think doing this in the major-mode file will improve locality,
because we have compilation-minor-mode, which should be able to do its
thing even if the relevant major mode is not yet loaded.
Fair enough!

- adding it in compile.el, to improve ability to oversee all
expressions, and be able to optimize those?

I see csharp-mode.el has the expressions added directly there. Should I
go about preparing patches doing
the same for typescript-ts-mode too?
I don't see why not.

Ok. Attached is a patch which adds Typescript tsc-support to compile.el. Is this OK to install in emacs-29?

I also see in retrospect that my comment about csharp-mode above may been somewhat ambiguous and easy to misunderstand (and seemingly you did).

To be clear: csharp-mode includes the compilation-mode regexps in the major-mode, not in compile.el. Is this also something we should aim to fix for emacs-29, or should we leave that for master?

--
Jostein
--------------EynyYrui00wTXy0tCpVleqw6-- From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 05:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: jostein@kjonigsen.net, Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , Eli Zaretskii Cc: casouri@gmail.com, 61104@debbugs.gnu.org Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.16754022469023 (code B ref 61104); Fri, 03 Feb 2023 05:31:02 +0000 Received: (at 61104) by debbugs.gnu.org; 3 Feb 2023 05:30:46 +0000 Received: from localhost ([127.0.0.1]:36288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNoer-0002LT-Kh for submit@debbugs.gnu.org; Fri, 03 Feb 2023 00:30:46 -0500 Received: from out-168.mta0.migadu.com ([91.218.175.168]:13743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNoeo-0002LH-F2 for 61104@debbugs.gnu.org; Fri, 03 Feb 2023 00:30:43 -0500 Date: Fri, 03 Feb 2023 06:30:29 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1675402240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=49UQWEQMAT9fHaGZBVFPMYKFq2oYceIRpZbjbsLRC3o=; b=v7CURzuqf8Ln+2jAqrmsuRbHBwUvgVSydBipCMJlzM1VOOCmyemXT1h61PbapMeVSkeAm4 ZDeTvL2JGF0F6r1o+PISX6LAVNDgIWqt2idRScCC5rvFHN5Dla5uf68szMz0dL+E1P8rYP OYc+9D8g3cRoA6lSHFBRxVNdBNX6UCFewxWZM+2YS4eqrvdfEAPW833sSi2kyRQvHZOtQ7 gwg0OeErxfP//M8RqYXqxwbPe2PN+HY7zH0xIbIWkjOu74M2e/V9uDtk2//HMHsfKctr2f 6D1DSEp3TxI/6QwJXEEJ/VAX3zk7svOd+qQGykGMyuuTbRhQxaHQIghFG5kOlw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill In-Reply-To: References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> <83lelnazs1.fsf@gnu.org> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 2 February 2023 22:01:11 CET, "Jostein Kj=C3=B8nigsen" wrote: >Any news on this one? Will this be merged? :) > My guess is that it should go on master=2E I'll look at it today - sorry i= t took some time :) Theo >Vennlig hilsen >*Jostein Kj=C3=B8nigsen* > >jostein@kjonigsen=2Enet =F0=9F=8D=B5 jostein@gmail=2Ecom >https://jostein=2Ekj=C3=B8nigsen=2Eno >On 1/28/23 15:28, Jostein Kj=C3=B8nigsen wrote: >>=20 >> On 1/28/23 08:23, Eli Zaretskii wrote: >>>=20 >>> I don't think doing this in the major-mode file will improve locality, >>> because we have compilation-minor-mode, which should be able to do its >>> thing even if the relevant major mode is not yet loaded=2E >> Fair enough! >>>=20 >>>> - adding it in compile=2Eel, to improve ability to oversee all >>>> expressions, and be able to optimize those? >>>>=20 >>>> I see csharp-mode=2Eel has the expressions added directly there=2E Sh= ould I >>>> go about preparing patches doing >>>> the same for typescript-ts-mode too? >>> I don't see why not=2E >>=20 >> Ok=2E Attached is a patch which adds Typescript tsc-support to compile= =2Eel=2E Is this OK to install in emacs-29? >>=20 >> I also see in retrospect that my comment about csharp-mode above may be= en somewhat ambiguous and easy to misunderstand (and seemingly you did)=2E >>=20 >> To be clear: csharp-mode includes the compilation-mode regexps in the m= ajor-mode, not in compile=2Eel=2E Is this also something we should aim to f= ix for emacs-29, or should we leave that for master? >>=20 >> --=20 >> Jostein From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 07:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Theodor Thornhill Cc: jostein@secure.kjonigsen.net, casouri@gmail.com, 61104@debbugs.gnu.org, jostein@kjonigsen.net Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167540798720580 (code B ref 61104); Fri, 03 Feb 2023 07:07:02 +0000 Received: (at 61104) by debbugs.gnu.org; 3 Feb 2023 07:06:27 +0000 Received: from localhost ([127.0.0.1]:36373 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNq9S-0005Lr-LO for submit@debbugs.gnu.org; Fri, 03 Feb 2023 02:06:26 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNq9Q-0005Lb-Om for 61104@debbugs.gnu.org; Fri, 03 Feb 2023 02:06:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNq9K-0006an-UE; Fri, 03 Feb 2023 02:06:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=iO078LaPR7YMPKm1HZSm+eK2CtpVQbVs37ECsLhjfuI=; b=i9B0GeZyXw+e17YrCXz0 IYCyT2Do3fzCa/gYA/OFH444IwAvafh1GjRZxI9C+eHuCXnqALLWFC5RUfSJRESGELnvmQgUXyV71 CCRBTtlKm+6VKOBsfj/Pylpbvfv4jTw8xgC9yNgrUnqLXBZM/4Dko1aS4xDuGmvjGrYX0lNljT8gk o1m8aO8pdc27sCK7vdwUm4YDG2zR+dGXgd8vELC7VrSDNKkNNrACfceFsWXkTAn+N7JkFgUqagee0 pNQHojmTHE8fVY0h2IXQSIoBM8g/t/gxPc2iWEo/WFmqS6OxFTbdQ/Usfh4rxoNPnD2ey7Isy3pvV glsMyjTWsIoFqA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNq9K-0004Xs-Dl; Fri, 03 Feb 2023 02:06:18 -0500 Date: Fri, 03 Feb 2023 09:06:22 +0200 Message-Id: <831qn7w7m9.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Theodor Thornhill on Fri, 03 Feb 2023 06:30:29 +0100) References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> <83lelnazs1.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 03 Feb 2023 06:30:29 +0100 > From: Theodor Thornhill > CC: 61104@debbugs.gnu.org, casouri@gmail.com > > On 2 February 2023 22:01:11 CET, "Jostein Kjønigsen" wrote: > >Any news on this one? Will this be merged? :) > > > > My guess is that it should go on master. I'll look at it today - sorry it took some time :) I'm okay with installing this on emacs-29 if the patch looks good. Typescript mode is new in Emacs 29, so it's okay to make this change now. But please be sure that the relevant tests still pass, i.e. that this change doesn't break something else in compilation-mode. Thanks. From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Feb 2023 08:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: jostein@secure.kjonigsen.net, casouri@gmail.com, 61104@debbugs.gnu.org, jostein@kjonigsen.net Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167541125426308 (code B ref 61104); Fri, 03 Feb 2023 08:01:02 +0000 Received: (at 61104) by debbugs.gnu.org; 3 Feb 2023 08:00:54 +0000 Received: from localhost ([127.0.0.1]:36437 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNr0A-0006qF-BG for submit@debbugs.gnu.org; Fri, 03 Feb 2023 03:00:54 -0500 Received: from out-212.mta0.migadu.com ([91.218.175.212]:46811) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNr07-0006q5-V3 for 61104@debbugs.gnu.org; Fri, 03 Feb 2023 03:00:53 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1675411249; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hbwh2jx2/EoRvLwEsGlAltZyku/Jl29fcTU6Xb4Fhcw=; b=xU+mRnQ7AqkQCDlbNsTi6hvhu4LbDi7ZyS825X90oTySUyCBKiHqaGgBZE3cGTTrlHKU/a xLMS8joE5hdQCR27K3pFwddWsFzQ9OX+QkrMKGxUP0cq7aWDEjwzPE/1o81AN6Xp4nE/Cd s+GTl/xFaBBPyueS1mfRNtpnSexnmEs8m3hPMgRUxWoqEfqj43jkkNYZFypkOPS8ybyvF7 suyBEjF5TMyOa+e7GlB8iZ5Z93rjom7+wGX9MgS0z+PQDL+yOoD4gpe+9AW2fBvqmUdSf1 yYegSYweyvy/IFmw95wPY6zzo30qUeRgBRLlKd48d5Thzhofwt6E4tcQlD7wdQ== From: Theodor Thornhill In-Reply-To: <831qn7w7m9.fsf@gnu.org> References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> <83lelnazs1.fsf@gnu.org> <831qn7w7m9.fsf@gnu.org> Date: Fri, 03 Feb 2023 09:00:48 +0100 Message-ID: <87h6w3ch5b.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Fri, 03 Feb 2023 06:30:29 +0100 >> From: Theodor Thornhill >> CC: 61104@debbugs.gnu.org, casouri@gmail.com >>=20 >> On 2 February 2023 22:01:11 CET, "Jostein Kj=C3=B8nigsen" wrote: >> >Any news on this one? Will this be merged? :) >> > >>=20 >> My guess is that it should go on master. I'll look at it today - sorry i= t took some time :) > > I'm okay with installing this on emacs-29 if the patch looks good. > Typescript mode is new in Emacs 29, so it's okay to make this change > now. But please be sure that the relevant tests still pass, i.e. that > this change doesn't break something else in compilation-mode. > > Thanks. Ok, I'll do that then. I'll add this in addition in the next commit, if that's ok. Thanks, Jostein and Eli :) Theo diff --git a/test/lisp/progmodes/compile-tests.el b/test/lisp/progmodes/com= pile-tests.el index 53dc7f2a13..22721563df 100644 --- a/test/lisp/progmodes/compile-tests.el +++ b/test/lisp/progmodes/compile-tests.el @@ -382,9 +382,13 @@ compile-tests--test-regexps-data ;; sun-ada (sun-ada "/home3/xdhar/rcds_rc/main.a, line 361, char 6:syntax error: = \",\" inserted" 1 6 361 "/home3/xdhar/rcds_rc/main.a") + (typescript-tsc-plain "/home/foo/greeter.ts(30,12): error TS2339: Prop= erty 'foo' does not exist." + 1 12 30 "/home/foo/greeter.ts") + (typescript-tsc-pretty "src/resources/document.ts:140:22 - error TS236= 2: something." + 1 22 140 "src/resources/document.ts") ;; 4bsd (edg-1 "/usr/src/foo/foo.c(8): warning: w may be used before set" - 1 nil 8 "/usr/src/foo/foo.c") + 1 nil 8 "/usr/src/foo/foo.c") (edg-1 "/usr/src/foo/foo.c(9): error: w is used before set" 1 nil 9 "/usr/src/foo/foo.c") (4bsd "strcmp: variable # of args. llib-lc(359) :: /usr/src/foo/foo.= c(8)" @@ -495,7 +499,7 @@ compile-test-error-regexps (compilation-num-warnings-found 0) (compilation-num-infos-found 0)) (mapc #'compile--test-error-line compile-tests--test-regexps-data) - (should (eq compilation-num-errors-found 98)) + (should (eq compilation-num-errors-found 100)) (should (eq compilation-num-warnings-found 35)) (should (eq compilation-num-infos-found 28))))) =20 From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2023 08:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: jostein@kjonigsen.net, casouri@gmail.com, 61104@debbugs.gnu.org, jostein@secure.kjonigsen.net Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167549909629261 (code B ref 61104); Sat, 04 Feb 2023 08:25:01 +0000 Received: (at 61104) by debbugs.gnu.org; 4 Feb 2023 08:24:56 +0000 Received: from localhost ([127.0.0.1]:40616 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pODqx-0007bs-JP for submit@debbugs.gnu.org; Sat, 04 Feb 2023 03:24:55 -0500 Received: from out-27.mta1.migadu.com ([95.215.58.27]:58281) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pODqu-0007bj-It for 61104@debbugs.gnu.org; Sat, 04 Feb 2023 03:24:54 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1675499091; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dmUnAIwWxCRNRUk61ewYgsX2tVuV2Fq54dpIHru4di0=; b=kbvsT2AoedNECEyAttJbL49Q1N78fEBwN/KGV9t3XATLI9XsmukaSjcpVMUp6o58HejAWx CDAyKJjHH+2/wstvDM1IZUlY9xDMRQPt9p5nQ5CDGZ0aFH1xeCgEVVmnH1aAX22gCguobh MPqUWnkP3SeoknJCx+PcKOvh0h5GMOSJOqW49+T/oSZ7+wimGUg+s8FqZ4oJP6VxT1mwGw Fd8zAelFyysH4jR6BiH5H+n0fGCKcr6FZl6CIUAfvO3LdIp8+PToibTG8N9r4wVrBAs45o 1FcsoB3q5nzjaKYw2IP6+uqAlhq7kOkY86qvS9Z0JXq/ddvqYk48iz6kFNZx/A== From: Theodor Thornhill In-Reply-To: <87h6w3ch5b.fsf@thornhill.no> (Theodor Thornhill's message of "Fri, 03 Feb 2023 09:00:48 +0100") References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> <83o7qjbu0l.fsf@gnu.org> <83lelnazs1.fsf@gnu.org> <831qn7w7m9.fsf@gnu.org> <87h6w3ch5b.fsf@thornhill.no> Date: Sat, 04 Feb 2023 09:24:49 +0100 Message-ID: <87sfflhm7i.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > Eli Zaretskii writes: > >>> Date: Fri, 03 Feb 2023 06:30:29 +0100 >>> From: Theodor Thornhill >>> CC: 61104@debbugs.gnu.org, casouri@gmail.com >>>=20 >>> On 2 February 2023 22:01:11 CET, "Jostein Kj=C3=B8nigsen" wrote: >>> >Any news on this one? Will this be merged? :) >>> > >>>=20 >>> My guess is that it should go on master. I'll look at it today - sorry = it took some time :) >> >> I'm okay with installing this on emacs-29 if the patch looks good. >> Typescript mode is new in Emacs 29, so it's okay to make this change >> now. But please be sure that the relevant tests still pass, i.e. that >> this change doesn't break something else in compilation-mode. >> >> Thanks. > > Ok, I'll do that then. I'll add this in addition in the next commit, if > that's ok. > > Thanks, Jostein and Eli :) The changes are now installed on the emacs-29 branch, thanks! Closing this :) Theo From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 04 03:25:08 2023 Received: (at control) by debbugs.gnu.org; 4 Feb 2023 08:25:08 +0000 Received: from localhost ([127.0.0.1]:40622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pODr9-0007cs-Us for submit@debbugs.gnu.org; Sat, 04 Feb 2023 03:25:08 -0500 Received: from out-127.mta1.migadu.com ([95.215.58.127]:58499) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pODr8-0007ck-Ix for control@debbugs.gnu.org; Sat, 04 Feb 2023 03:25:07 -0500 Date: Sat, 04 Feb 2023 09:25:05 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1675499105; h=from:from:reply-to:subject:subject:date:date:to:to:cc; bh=caz3H+IrW33SUJEgWMI49P7AQESzNKUI+FS1f+ENP/c=; b=H6rGme9Bvx9htoGKwDY8ded5ZIMJLQ/A64ijVuMAMev79i5C4Elzbp3uTGeBprj1yy9cwe +CUMMvF1I5Fk2bC1DKTbMZiZEeS/Q3oPgWoeKtvKgfRfkKc6zBfeoX2qhrFHmkY/ChS+73 7QHc6zbtiYC8XYXSmFNZ0qGUE+Pli3AIzUyi/RrSH74HIGqJiyegThBm318ogh8BllG1xf 6QhX0vSYAZBYR6JHkjxbyCa88BFNAG8+bAC7bxdnVkFUgUTpk2OfptLhTbwnDkNbE5qpF1 pdw6DpOzb8FPmmpoxMmhD0df9PpnTrlyaWsDUiCwdTYC0fzQKhLo1Ra2qLONoQ== To: control@debbugs.gnu.org X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill Subject: control message for bug #61104 X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" Message-Id: X-Spam-Score: -1.0 (-) close 61104 29.1 quit From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support References: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> In-Reply-To: <316aee65-50c6-9dad-5b8d-08d90675c5a5@secure.kjonigsen.net> Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Feb 2023 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: jostein@kjonigsen.net Cc: casouri@gmail.com, 61104@debbugs.gnu.org, Theodor Thornhill , Eli Zaretskii Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167551196314022 (code B ref 61104); Sat, 04 Feb 2023 12:00:02 +0000 Received: (at 61104) by debbugs.gnu.org; 4 Feb 2023 11:59:23 +0000 Received: from localhost ([127.0.0.1]:40796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOHCU-0003e4-Nn for submit@debbugs.gnu.org; Sat, 04 Feb 2023 06:59:23 -0500 Received: from mail-ed1-f51.google.com ([209.85.208.51]:46927) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOHCQ-0003dn-NG for 61104@debbugs.gnu.org; Sat, 04 Feb 2023 06:59:21 -0500 Received: by mail-ed1-f51.google.com with SMTP id cw4so7384416edb.13 for <61104@debbugs.gnu.org>; Sat, 04 Feb 2023 03:59:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=jAd4w1izv7cs1QeudlDsvlWhSafop+GAACEr0Kt2uf0=; b=LYe8VvonoXrt+Zvqxo7TnP9aq1jiyIqKabDHkA2ZBDeqz4TA4LYOkNdeb+82uQAJnV SD5Z27oCCeoqZbuHyAY5XfTSpxRaXLmI/YtlMLETSEL0UUrUmKyu9DMsMowOlxY1qFrP 2Zx407ZIgN1pG8c1/Pih8BfGGJGF42a17P2tnzaIHNvh1eARxVkE8/iBehxFRHo+HNzw 7n8PCygqgX2J3nkfFZ1+T/e54uAl61kXw343G9kJESC/NgRp92E1VMdA17QVct3UTMel KaVbXT7mxFUpQyWVYx0ysQZ1COf6j4ZB/sBxCgFZCqpRj0vQLDI+7O8T9jY/P5Ukx/EQ eRTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jAd4w1izv7cs1QeudlDsvlWhSafop+GAACEr0Kt2uf0=; b=TooqZlI4LrtEtjRU2rj32EKFnhlXYIT+FQhipARx9o2jV4jOZUVJkYu1J1XpgkVNXH ioq8HLhyFO3yDcljwD9du1BpoJb48XIaWEaScO64nGMrl5TwfckN74zSIMf8KEmklOUU CFRaihbVrBpTzdbfXBHSBB7eX9UmHO4QwB+fn+rUUfr5A/ejxCh1Kz+q1J4+KFlmsSvZ uB8JDtNjdAY4bG0VoIiZOZjVynxJD66UjeSAl0rqhSJDATUQvuKUx7ForCEJR28I1eYA GsUcrV/Mv25+dJgu302FiKEkLRyzsj5JWrVwRhX0kduyUcQzv7Rmq7RN15bq6LS5D4ZZ ryPQ== X-Gm-Message-State: AO0yUKVXhscDUqbFD8ixG0f1GpBqn9Oqpju7Xtna5ZeY36Tx2iR3cA17 lpHHm9FzARsVGTd021LUu1Y= X-Google-Smtp-Source: AK7set+VlguTzOSD7JIUctcgzx4sV+hi/VmvpAs6E7GBcJ57xlDge8xSdSS2nrG69BDASUAx7/UMSA== X-Received: by 2002:a50:9f48:0:b0:4aa:a0f8:d98 with SMTP id b66-20020a509f48000000b004aaa0f80d98mr1216530edf.0.1675511952623; Sat, 04 Feb 2023 03:59:12 -0800 (PST) Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id v4-20020a056402348400b0049ef04ad502sm2399875edc.40.2023.02.04.03.59.11 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 Feb 2023 03:59:12 -0800 (PST) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Message-Id: <792EC2CE-006B-42F1-81C2-453E71C2173C@gmail.com> Date: Sat, 4 Feb 2023 12:59:10 +0100 X-Mailer: Apple Mail (2.3654.120.0.1.14) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Jostein, thank you for contributing a new compilation-mode pattern! We generally want these regexps to be as tight as possible while still = doing their job. This is partly because the large and ever-growing = number of rules tend to interfere with one another, and over-broad = patterns have shown to be a source of performance problems in the past. I hope you don't mind helping us finishing the job: First of all, both regexps match arbitrary amounts of horizontal = whitespace at the beginning of a line, but neither message example you = supplied contains any such leading whitespace. This means that either = the set of test cases needs to be extended, or we could safely remove = this leading whitespace matcher. If leading whitespace indeed can occur, then when and how, exactly? = Spaces or tabs, and how many? Please give us examples from actual = compiler output. Similarly the patterns match arbitrary whitespace before the word = "error". This seems equally questionable -- would a single space do? If = not, please provide actual output demonstrating it that could be added = to the test suite, and tell us how it varies (tabs vs spaces, amount of = whitespace, etc). The following is a minor point that we'll fix but I thought you may want = to know: The use of [[:blank:]] and [[:alnum:]] is very likely more expensive = than required since they accept Unicode whitespace and letters which = obviously never will occur where matched so if it's all the same to you = we'll reduce them to ASCII patterns. Similarly, the inclusion of \r in patterns seems to be a = misunderstanding: the tail part, "[^\r\n]+$", does not make sense -- = normally, carriage returns aren't seen in buffers because line = terminator translation convert everything to a single \n, and if a stray = CR did occur then that pattern would never match anyway (why?). From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Feb 2023 20:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , jostein@kjonigsen.net Cc: casouri@gmail.com, 61104@debbugs.gnu.org, Theodor Thornhill , Eli Zaretskii Reply-To: jostein@kjonigsen.net Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167562941129205 (code B ref 61104); Sun, 05 Feb 2023 20:37:02 +0000 Received: (at 61104) by debbugs.gnu.org; 5 Feb 2023 20:36:51 +0000 Received: from localhost ([127.0.0.1]:46564 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOlkm-0007ax-A6 for submit@debbugs.gnu.org; Sun, 05 Feb 2023 15:36:49 -0500 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:48755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOlki-0007ah-Ko for 61104@debbugs.gnu.org; Sun, 05 Feb 2023 15:36:46 -0500 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id BF059320083A; Sun, 5 Feb 2023 15:36:37 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Sun, 05 Feb 2023 15:36:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to; s=fm2; t= 1675629397; x=1675715797; bh=K6RTIcb3ButSFu6WDqxHBLaGZ/UPlFrsiQ8 ub0Pact8=; b=NLSw9slpDnxILd2UfJV+qcT5opVik1yWY1x6Z/3z97J9FrojNzd ciRZPr6/xgznAOcfLR1UbJkyzNCpLH3J9LOkNQduS4f2ynMJcjttGmDxx83TZmSU VvEsK2bvX6Uw3nvjzYbb7cryMXFG83AG3YCMKrRp30HEAfGbHDdXqV7ucnEdKWza c13wkXf0Tnnf2tQv4TnZRn+TVT5i8lq++tnjVBFO7raqQnQdz7WzFi+LInSvrQ5q WF/HTyYZBkAUlcR/0RtGqZOm8lZJNOnEyqSaFzWGm1SalwLMSwT1o2jUoWkszsLC OS5ECSAKoThXuxypZZQqQ0sy9Z0Feyft6ow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1675629397; x=1675715797; bh=K6RTIcb3ButSF u6WDqxHBLaGZ/UPlFrsiQ8ub0Pact8=; b=MsIbhjjRw1tRWeh7wyV3LZX2YbQMR JUsOgkZoerJQ4w6VqajUIIAgKaD+HQ55u4q7B/EoyM4P2fsccse+si5seiGCI/C8 LByyNI28fGZR9A75WM4KF/np5Dnsrha0JhUKRJ/HP4s1pHu21wtLDnCCz6MhW6aa B9M3sj07ziGP+sVgWYVfox1KmLms4+AbGTIgKRggOBHiKzljEaOD7dmcMfNyK7NR r0dZ0sQRimNjJXez663d5EQTuAEXyosgHe9Pj+7huXiMyiDB0J57y3/EZqlHu0KX X5mW7NSMftvTyXjm4U4QTAT3PPMnMh5BrSol7PuBYGNNiyRSa2c7GLI+g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudeggedgudefkecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpegtkfffgggfrhfuvfevfhfhjgesmhdtreertdefjeenucfhrhhomheplfho shhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnhepleeihefgveefffelkeelleff ffdtfeevleetheefgfdtgfdtfeeiveekgfevkedvnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhho nhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 5 Feb 2023 15:36:36 -0500 (EST) Content-Type: multipart/mixed; boundary="------------CnTLUCBzCryYhNBZrQEO4RVr" Message-ID: <12a97d26-90cc-4a25-61a5-5aff33915610@secure.kjonigsen.net> Date: Sun, 5 Feb 2023 21:36:34 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-GB, nb-NO References: <792EC2CE-006B-42F1-81C2-453E71C2173C@gmail.com> From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= In-Reply-To: <792EC2CE-006B-42F1-81C2-453E71C2173C@gmail.com> X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) This is a multi-part message in MIME format. --------------CnTLUCBzCryYhNBZrQEO4RVr Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hey there and thanks for the valuable feedback! I'll try to do my best to provide the info I can, so that we can create the tightest regexps for this, which still are functional on the level users would expect. On 2/4/23 12:59, Mattias Engdegård wrote: > First of all, both regexps match arbitrary amounts of horizontal whitespace at the beginning of a line, but neither message example you supplied contains any such leading whitespace. This means that either the set of test cases needs to be extended, or we could safely remove this leading whitespace matcher. I've gone looking, but I really can't find confirmation that this whitespace is required, at least not when building directly through the tsc TypeScript compiler. I can see in the old test-suite for the MELPA package these two variants were the only test-cases present as well. As such I think it's defiintely safe to remove this leading whitespace. > Similarly the patterns match arbitrary whitespace before the word "error". This seems equally questionable -- would a single space do? If not, please provide actual output demonstrating it that could be added to the test suite, and tell us how it varies (tabs vs spaces, amount of whitespace, etc). I can't see any real use-case for this either. Let's snip it. > The following is a minor point that we'll fix but I thought you may want to know: > > The use of [[:blank:]] and [[:alnum:]] is very likely more expensive than required since they accept Unicode whitespace and letters which obviously never will occur where matched so if it's all the same to you we'll reduce them to ASCII patterns. I've given this a try, and it seems to work fine. I'm OK with such a change. > Similarly, the inclusion of \r in patterns seems to be a misunderstanding: the tail part, "[^\r\n]+$", does not make sense -- normally, carriage returns aren't seen in buffers because line terminator translation convert everything to a single \n, and if a stray CR did occur then that pattern would never match anyway (why?). Fair enough. I've changed the code to only looks for \n instead. Attached is a patch which codifies all these changes, and from what I can tell, still does the job. You make take it as is, or you may further work on it, if you think that is still needed. -- Jostein --------------CnTLUCBzCryYhNBZrQEO4RVr Content-Type: text/x-patch; charset=UTF-8; name="0001-Optimize-compilation-mode-expressions-for-TypeScript.patch" Content-Disposition: attachment; filename*0="0001-Optimize-compilation-mode-expressions-for-TypeScript.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAxYzZhNzFjZDFkYjViNTg5ZmY5ZmM1ZjRmZTc2ZTkzNTdiN2JlZGJkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/Sm9zdGVpbj0yMEtqPUMzPUI4bmln c2VuPz0gPGpvc3RlaW5Aa2pvbmlnc2VuLm5ldD4KRGF0ZTogU3VuLCA1IEZlYiAyMDIzIDIx OjM0OjA4ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gT3B0aW1pemUgY29tcGlsYXRpb24tbW9k ZSBleHByZXNzaW9ucyBmb3IgVHlwZVNjcmlwdAoKLSBsaXNwL3Byb2dtb2Rlcy9jb21waWxl LmVsOiByZW1vdmUgdW5uZWVkZWQgYW5kIGV4cGVuc2l2ZSBjaGVja3MuCi0tLQogbGlzcC9w cm9nbW9kZXMvY29tcGlsZS5lbCB8IDEwICsrKystLS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA0 IGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9wcm9n bW9kZXMvY29tcGlsZS5lbCBiL2xpc3AvcHJvZ21vZGVzL2NvbXBpbGUuZWwKaW5kZXggMWU1 N2QwYjdiYi4uNzcwMGU1ZjdiMSAxMDA2NDQKLS0tIGEvbGlzcC9wcm9nbW9kZXMvY29tcGls ZS5lbAorKysgYi9saXNwL3Byb2dtb2Rlcy9jb21waWxlLmVsCkBAIC02NTQsMTggKzY1NCwx NiBAQCBjb21waWxhdGlvbi1lcnJvci1yZWdleHAtYWxpc3QtYWxpc3QKICAgICA7OyBncmVl dGVyLnRzKDMwLDEyKTogZXJyb3IgVFMyMzM5OiBQcm9wZXJ0eSAnZm9vJyBkb2VzIG5vdCBl eGlzdC4KICAgICAodHlwZXNjcmlwdC10c2MtcGxhaW4KICAgICAgLChjb25jYXQKLSAgICAg ICJeW1s6Ymxhbms6XV0qIgotICAgICAgIlxcKFteKFxyXG4pXStcXCkoXFwoWzAtOV0rXFwp LFxcKFswLTldK1xcKSk6W1s6Ymxhbms6XV0rIgotICAgICAgImVycm9yIFtbOmFsbnVtOl1d KzogW15cclxuXSskIikKKyAgICAgICJcXChbXihcclxuKV0rXFwpKFxcKFswLTldK1xcKSxc XChbMC05XStcXCkpOiAiCisgICAgICAiZXJyb3IgW0EtWjAtOV0rOiBbXlxuXSskIikKICAg ICAgMSAyIDMgMikKIAogICAgIDs7IFR5cGVzY3JpcHQgY29tcGlsYXRpb24gYWZ0ZXIgdHNj IHZlcnNpb24gMi43LCAicHJldHR5IiBmb3JtYXQ6CiAgICAgOzsgc3JjL3Jlc291cmNlcy9k b2N1bWVudC50czoxNDA6MjIgLSBlcnJvciBUUzIzNjI6IHNvbWV0aGluZy4KICAgICAodHlw ZXNjcmlwdC10c2MtcHJldHR5CiAgICAgICwoY29uY2F0Ci0gICAgICAgIl5bWzpibGFuazpd XSoiCi0gICAgICAgIlxcKFteKFxyXG4pXStcXCk6XFwoWzAtOV0rXFwpOlxcKFswLTldK1xc KSAtIFtbOmJsYW5rOl1dKiIKLSAgICAgICAiZXJyb3IgW1s6YWxudW06XV0rOiBbXlxyXG5d KyQiKQorICAgICAgICJcXChbXihcclxuKV0rXFwpOlxcKFswLTldK1xcKTpcXChbMC05XStc XCkgLSAiCisgICAgICAgImVycm9yIFtBLVowLTldKzogW15cbl0rJCIpCiAgICAgIDEgMiAz IDIpCiAgICAgKSkKICAgIkFsaXN0IG9mIHZhbHVlcyBmb3IgYGNvbXBpbGF0aW9uLWVycm9y LXJlZ2V4cC1hbGlzdCcuIikKLS0gCjIuMzkuMQoK --------------CnTLUCBzCryYhNBZrQEO4RVr-- From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 11:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: jostein@kjonigsen.net Cc: casouri@gmail.com, 61104@debbugs.gnu.org, Theodor Thornhill , Eli Zaretskii Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.16756823824738 (code B ref 61104); Mon, 06 Feb 2023 11:20:02 +0000 Received: (at 61104) by debbugs.gnu.org; 6 Feb 2023 11:19:42 +0000 Received: from localhost ([127.0.0.1]:47475 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOzXB-0001EM-Se for submit@debbugs.gnu.org; Mon, 06 Feb 2023 06:19:42 -0500 Received: from mail-ed1-f43.google.com ([209.85.208.43]:43712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOzXA-0001E4-FY for 61104@debbugs.gnu.org; Mon, 06 Feb 2023 06:19:40 -0500 Received: by mail-ed1-f43.google.com with SMTP id m8so11247761edd.10 for <61104@debbugs.gnu.org>; Mon, 06 Feb 2023 03:19:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=GcFkSSYyTyYIFBo2siaKo6mOuYIZ2mQvVtFu0NFbGiA=; b=PrWuka7rDAe1KV6WRgDpSR8SPv/R/s4HGv0LMD0bAq8zXlF+Frk1St8TE1T3l3YkPT BOdSZFYk6ZebYk8CL16bqQySLBfQH7IuUYTHNlkjm3hgLP+XCn3Uh1Wg+YzZYnDhnz3i svscZnljxo7wY2HjcU7IrwW0OLyO5dy0yN1rZd65cnXjbRtgxep3176hRPq2eeXoHPtW 5POzjI1RXdU7LtQTsJENbc1fnyd/a8rNyC64GdIrBodD2Lkvcnt+i0E4ko7YiK1eoD22 /gU/N6SzzG5jVv+YeQpSZQtbAjOz2KRywlH6h3urgJmwjbQAaurxETgZRSwnh6ZydQxp peWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GcFkSSYyTyYIFBo2siaKo6mOuYIZ2mQvVtFu0NFbGiA=; b=dwTzRqbsqQ2uoGT16NRpsNPrknm4yrpT77CMx4crp9zxeojX/dd752UnV80TAQCxD4 V8Dx/CNnOKVptjnR+7LTU2Oq7HbwuSdQWd7mm50bWvHNRKJxNezMYw4WKO0InA873Zvs 6/Cxq1cbpKiZvuB4ZO4WrXsirmswXCtZoVvgYa8139JWrUXV8Zru7BXmaB+ZCjlQ8zAX ULgt5DArEQ0HQCnuJPTtmsEDvIuojDignCP7ynsDDWVr6gk3TMTa4lshpxmAbZi6IqMG Dt73sWUa9JD3Ys7KInq05X8GbD16FlHIUmGpzHVH6ggNiVdBmfmx7pRGP1a5DKSYu09x oZmQ== X-Gm-Message-State: AO0yUKWKdAifN58//GcZVSeNjO78CwdWZ826pFSqGIOo5EOjL3jnzXGY 3KZHnYWisnYxxB7i/HiReQU= X-Google-Smtp-Source: AK7set+NYMMudWvcUCbfW99MWf36BcoK4UqFcYYIGwkm7/R/LqUu4loQMX//Uc+4njB5uVMlVrahXw== X-Received: by 2002:a50:aade:0:b0:4aa:b26f:1a0a with SMTP id r30-20020a50aade000000b004aab26f1a0amr4299695edc.27.1675682374392; Mon, 06 Feb 2023 03:19:34 -0800 (PST) Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id b15-20020a509f0f000000b004aaa3c872d0sm2946324edf.87.2023.02.06.03.19.33 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2023 03:19:34 -0800 (PST) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Message-Id: <2F86FB50-87F7-432D-B87A-1738056907AB@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_C3F4CE4C-5452-4678-94B8-8B2450BEA8B2" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Date: Mon, 6 Feb 2023 12:19:32 +0100 In-Reply-To: <12a97d26-90cc-4a25-61a5-5aff33915610@secure.kjonigsen.net> References: <792EC2CE-006B-42F1-81C2-453E71C2173C@gmail.com> <12a97d26-90cc-4a25-61a5-5aff33915610@secure.kjonigsen.net> X-Mailer: Apple Mail (2.3654.120.0.1.14) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_C3F4CE4C-5452-4678-94B8-8B2450BEA8B2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 5 feb. 2023 kl. 21.36 skrev Jostein Kj=C3=B8nigsen = : > Attached is a patch which codifies all these changes, and from what I = can tell, still does the job. You make take it as is, or you may further = work on it, if you think that is still needed. Thank you! I translated the regexps to rx (which I personally find more = maintainable and has plenty of precedence in this context) and tightened = them up further. They are now anchored at beginning-of-line again, and = file names cannot start with whitespace (for disambiguation and speed). I also removed the part that matches the actual message text since it = isn't needed, and it would highlight (with an underline in the standard = theme) the whole text which is a bit ungainly to read. If the message is = multi-line, which earlier examples in this discussions indicated might = be the case, then only the first would be highlighted this way which = wasn't ideal either. Patch attached, please tell me what you think. Does tsc distinguish between warnings, errors, and 'informational' = messages (such as locations of interest that are not errors in their own = right)? The examples you supplied all had the word "error" in a = prominent place. It would be possible to join the two tsc rules into a single one which = would be slightly faster, but having them separate could also be an = advantage since it would allow for them to be disabled individually in = case of clashes. --Apple-Mail=_C3F4CE4C-5452-4678-94B8-8B2450BEA8B2 Content-Disposition: attachment; filename=0001-Simplify-typescript-compilation-mode-patterns-bug-61.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Simplify-typescript-compilation-mode-patterns-bug-61.patch" Content-Transfer-Encoding: quoted-printable =46rom=20d6d336cfe588dd5d8a5bf647c5beb9e45b47ef3d=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Mon,=206=20Feb=202023=2011:45:33=20+0100=0A= Subject:=20[PATCH]=20Simplify=20typescript=20compilation-mode=20patterns=20= (bug#61104)=0AMIME-Version:=201.0=0AContent-Type:=20text/plain;=20= charset=3DUTF-8=0AContent-Transfer-Encoding:=208bit=0A=0A*=20= lisp/progmodes/compile.el=20(compilation-error-regexp-alist-alist):=0A= Tighten=20regexps=20and=20simplify.=20=20Translate=20to=20rx.=0A*=20= etc/compilation.txt:=20Add=20examples.=0A=0AIn=20collaboration=20with=20= Jostein=20Kj=C3=B8nigsen.=0A---=0A=20etc/compilation.txt=20=20=20=20=20=20= =20|=2014=20++++++++++++++=0A=20lisp/progmodes/compile.el=20|=2028=20= ++++++++++++++++++++--------=0A=202=20files=20changed,=2034=20= insertions(+),=208=20deletions(-)=0A=0Adiff=20--git=20= a/etc/compilation.txt=20b/etc/compilation.txt=0Aindex=20= 672cbebafff..5f6ecb09cc2=20100644=0A---=20a/etc/compilation.txt=0A+++=20= b/etc/compilation.txt=0A@@=20-639,6=20+639,20=20@@=20symbol:=20weblint=0A= =20index.html=20(13:1)=20Unknown=20element=20=0A=20=0A=20=0A+*=20= Typescript=20prior=20to=20tsc=20version=202.7,=20"plain"=20format=0A+=0A= +symbol:=20typescript-tsc-plain=0A+=0A+greeter.ts(30,12):=20error=20= TS2339:=20Property=20'foo'=20does=20not=20exist.=0A+=0A+=0A+*=20= Typescript=20after=20tsc=20version=202.7,=20"pretty"=20format=0A+=0A= +symbol:=20typescript-tsc-pretty=0A+=0A+src/resources/document.ts:140:22=20= -=20error=20TS2362:=20something.=0A+=0A+=0A=20*=20Directory=20tracking=0A= =20=0A=20Directories=20are=20matched=20via=20= 'compilation-directory-matcher'.=20=20Files=20which=20are=0Adiff=20--git=20= a/lisp/progmodes/compile.el=20b/lisp/progmodes/compile.el=0Aindex=20= 1e57d0b7bb2..ccf64fb670b=20100644=0A---=20a/lisp/progmodes/compile.el=0A= +++=20b/lisp/progmodes/compile.el=0A@@=20-653,19=20+653,31=20@@=20= compilation-error-regexp-alist-alist=0A=20=20=20=20=20;;=20Typescript=20= compilation=20prior=20to=20tsc=20version=202.7,=20"plain"=20format:=0A=20= =20=20=20=20;;=20greeter.ts(30,12):=20error=20TS2339:=20Property=20'foo'=20= does=20not=20exist.=0A=20=20=20=20=20(typescript-tsc-plain=0A-=20=20=20=20= =20,(concat=0A-=20=20=20=20=20=20"^[[:blank:]]*"=0A-=20=20=20=20=20=20= "\\([^(\r\n)]+\\)(\\([0-9]+\\),\\([0-9]+\\)):[[:blank:]]+"=0A-=20=20=20=20= =20=20"error=20[[:alnum:]]+:=20[^\r\n]+$")=0A+=20=20=20=20=20,(rx=20bol=0A= +=20=20=20=20=20=20=20=20=20=20(group=20(not=20(in=20"=20\t\n()"))=20=20=20= ;=201:=20file=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20(*=20= (not=20(in=20"\n()"))))=0A+=20=20=20=20=20=20=20=20=20=20"("=0A+=20=20=20= =20=20=20=20=20=20=20(group=20(+=20(in=20"0-9")))=20=20=20=20=20=20=20=20= ;=202:=20line=0A+=20=20=20=20=20=20=20=20=20=20","=0A+=20=20=20=20=20=20=20= =20=20=20(group=20(+=20(in=20"0-9")))=20=20=20=20=20=20=20=20;=203:=20= column=0A+=20=20=20=20=20=20=20=20=20=20"):=20error=20"=0A+=20=20=20=20=20= =20=20=20=20=20(+=20(in=20"0-9A-Z"))=20=20=20=20=20=20=20=20=20=20=20=20=20= ;=20error=20code=0A+=20=20=20=20=20=20=20=20=20=20":=20")=0A=20=20=20=20=20= =201=202=203=202)=0A=20=0A=20=20=20=20=20;;=20Typescript=20compilation=20= after=20tsc=20version=202.7,=20"pretty"=20format:=0A=20=20=20=20=20;;=20= src/resources/document.ts:140:22=20-=20error=20TS2362:=20something.=0A=20= =20=20=20=20(typescript-tsc-pretty=0A-=20=20=20=20=20,(concat=0A-=20=20=20= =20=20=20=20"^[[:blank:]]*"=0A-=20=20=20=20=20=20=20= "\\([^(\r\n)]+\\):\\([0-9]+\\):\\([0-9]+\\)=20-=20[[:blank:]]*"=0A-=20=20= =20=20=20=20=20"error=20[[:alnum:]]+:=20[^\r\n]+$")=0A+=20=20=20=20=20= ,(rx=20bol=0A+=20=20=20=20=20=20=20=20=20=20(group=20(not=20(in=20"=20= \t\n()"))=20=20=20;=201:=20file=0A+=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20(*=20(not=20(in=20"\n()"))))=0A+=20=20=20=20=20=20=20=20=20=20= ":"=0A+=20=20=20=20=20=20=20=20=20=20(group=20(+=20(in=20"0-9")))=20=20=20= =20=20=20=20=20;=202:=20line=0A+=20=20=20=20=20=20=20=20=20=20":"=0A+=20=20= =20=20=20=20=20=20=20=20(group=20(+=20(in=20"0-9")))=20=20=20=20=20=20=20= =20;=203:=20column=0A+=20=20=20=20=20=20=20=20=20=20"=20-=20error=20"=0A= +=20=20=20=20=20=20=20=20=20=20(+=20(in=20"0-9A-Z"))=20=20=20=20=20=20=20= =20=20=20=20=20=20;=20error=20code=0A+=20=20=20=20=20=20=20=20=20=20":=20= ")=0A=20=20=20=20=20=201=202=203=202)=0A=20=20=20=20=20))=0A=20=20=20= "Alist=20of=20values=20for=20`compilation-error-regexp-alist'.")=0A--=20=0A= 2.32.0=20(Apple=20Git-132)=0A=0A= --Apple-Mail=_C3F4CE4C-5452-4678-94B8-8B2450BEA8B2-- From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= , jostein@kjonigsen.net Cc: casouri@gmail.com, 61104@debbugs.gnu.org, Theodor Thornhill , Eli Zaretskii Reply-To: jostein@kjonigsen.net Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167570316424029 (code B ref 61104); Mon, 06 Feb 2023 17:07:02 +0000 Received: (at 61104) by debbugs.gnu.org; 6 Feb 2023 17:06:04 +0000 Received: from localhost ([127.0.0.1]:49762 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP4wO-0006FV-BP for submit@debbugs.gnu.org; Mon, 06 Feb 2023 12:06:04 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60109) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP4wL-0006Eu-Pk for 61104@debbugs.gnu.org; Mon, 06 Feb 2023 12:06:02 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B74E65C00CD; Mon, 6 Feb 2023 12:05:55 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 06 Feb 2023 12:05:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:reply-to:sender :subject:subject:to:to; s=fm2; t=1675703155; x=1675789555; bh=/3 /6C+pZUGu2sI7L4bvFpxFKSRXo8AWdQcHvMRX0BFI=; b=FtdQbPZjTdAwfPYQwt L0AbA4F7DPZQ6ZIwfPE06a55JjM2CRtQ7eN2k1D4ItB1IM16+h5wL1wFvODVMoI7 jHTfLCQXRUVehKlfUmJqJUnTU1rKyhEv6oISHtyvRoqERBw2k1L1Yjsr4tVZwo0R yNLcrVKVkQzMhCsLer29uF5H3NMJKLjXorXFBLbxqtbrfM76Gh4g5aC+EUgFNkFa 2udHvhr1xTtV1zimLl+LJvgJeDEha4bk1QG/1QszqnagFPAP0KeGOxO3Hg58sXDJ XK8xk8/8l3KHQwKGHMBGynh73nQBAmNUk3RueGhNQmOA+SAWI3FFdyuf6PO8MslP sRCQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1675703155; x=1675789555; bh=/3/6C+pZUGu2sI7L4bvFpxFKSRXo8AWdQcH vMRX0BFI=; b=iSYhYK6CGbaDWHAOcRfr2gW+IeFDeh97nTQBWKt2ASZ6Zko8vzQ iO0uGQlQNS95rn1pLkvyRu2R5whlxezN24eV03P5euULiG5mHOCfeQs6QiuvEAn4 p0CxdP6pLpCb7SWrvxduaBZj7XXTWgQhaVNJ6gHHJ1EUcQsYWI0ib5QZbd71hdev 0vMVJybTVPSVvVA38mRfeBLh1jbznUo3SyIbeFCRHPiIfDW+zyj9yKVEPXqUZshG 8Ii8sgaWGTybGwKMvdBGT72w7JpNIMDosMVA+Ztmu/0hSIh/0RImcd+hXNYLhLnb TcQFL3oFNlJAo2AAyo+o6wtUXVfY2h6c4ug== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegiedgleegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfrhfuvfevfhfhjggtgfesthekredttdefjeenucfhrhhomheplfho shhtvghinhcumfhjpphnihhgshgvnhcuoehjohhsthgvihhnsehsvggtuhhrvgdrkhhjoh hnihhgshgvnhdrnhgvtheqnecuggftrfgrthhtvghrnheptdeftdektdffueekvddvvdek ueevuddviedtffffgffggeeltdekhefgtdejkeevnecuvehluhhsthgvrhfuihiivgeptd enucfrrghrrghmpehmrghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhho nhhighhsvghnrdhnvght X-ME-Proxy: Feedback-ID: ib2f84088:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 6 Feb 2023 12:05:54 -0500 (EST) Message-ID: <7802fc0d-3abc-8905-411b-4ada721e8013@secure.kjonigsen.net> Date: Mon, 6 Feb 2023 18:05:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-GB, nb-NO References: <792EC2CE-006B-42F1-81C2-453E71C2173C@gmail.com> <12a97d26-90cc-4a25-61a5-5aff33915610@secure.kjonigsen.net> <2F86FB50-87F7-432D-B87A-1738056907AB@gmail.com> From: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= In-Reply-To: <2F86FB50-87F7-432D-B87A-1738056907AB@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) On 2/6/23 12:19, Mattias Engdegård wrote: > Thank you! I translated the regexps to rx (which I personally find > more maintainable and has plenty of precedence in this context) and > tightened them up further. They are now anchored at beginning-of-line > again, and file names cannot start with whitespace (for disambiguation > and speed). Thanks. These are all good changes. > I also removed the part that matches the actual message text since it isn't needed, and it would highlight (with an underline in the standard theme) the whole text which is a bit ungainly to read. If the message is multi-line, which earlier examples in this discussions indicated might be the case, then only the first would be highlighted this way which wasn't ideal either. Seconded. No issues with that either. > Does tsc distinguish between warnings, errors, and 'informational' messages (such as locations of interest that are not errors in their own right)? The examples you supplied all had the word "error" in a prominent place. I don't think so. There are code-analysis warnings which seems to be provided to your editor of choice through LSP. These can be made into a compilation-error with the appropriate config-flag, but I can't out of the blue find any "middle ground" where they are emitted compile-time as warnings. Someone please correct me if I'm wrong. > It would be possible to join the two tsc rules into a single one which would be slightly faster, but having them separate could also be an advantage since it would allow for them to be disabled individually in case of clashes. To me that sounds like an optimization going one step too far. It will result in a more complex expression, which is harder to work with/maintain, and might also be more computationally expensive due to back-tracking complexity. I personally think that having 2 self-documented expressions side by side works better, but I'm no authority on compilation-mode and performance :) > Patch attached, please tell me what you think. I've tested that patch myself, and from what I can tell, it still works just fine :) -- Jostein From unknown Sun Jun 22 07:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61104: 29.0.60; typescript-ts-mode does not provide compilation-mode support Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 17:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61104 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: jostein@kjonigsen.net Cc: casouri@gmail.com, 61104@debbugs.gnu.org, Theodor Thornhill , Eli Zaretskii Received: via spool by 61104-submit@debbugs.gnu.org id=B61104.167570489027435 (code B ref 61104); Mon, 06 Feb 2023 17:35:01 +0000 Received: (at 61104) by debbugs.gnu.org; 6 Feb 2023 17:34:50 +0000 Received: from localhost ([127.0.0.1]:49792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP5OE-00078R-9v for submit@debbugs.gnu.org; Mon, 06 Feb 2023 12:34:50 -0500 Received: from mail-ej1-f54.google.com ([209.85.218.54]:34601) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pP5OB-000786-T2 for 61104@debbugs.gnu.org; Mon, 06 Feb 2023 12:34:48 -0500 Received: by mail-ej1-f54.google.com with SMTP id e22so7036651ejb.1 for <61104@debbugs.gnu.org>; Mon, 06 Feb 2023 09:34:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=L16l9RzmD0ZDu8L5EXImaQcW5WNxxbSTH3J7/7e85PM=; b=kHoQm0csb+Vw7krLDccXeFrgGuawY2uN/B2FQHEbogLg0mEWtD/2Dtvgu24wuGn8yc GdEoRlC0jqJVUSSLlrqb0Waw2+6G3Yf0EzZSlyHnsvPksbL1Dt1DXhk8Q7O217Lpa6/z N777yDHD1NoPphZK5IvVTvXkvQDrKNJWKILR/TZeKEI11+SzIMkFWLklLjVB6powHK9a E9XCgYa3RbR7oppgpg63Me2i8EEgD1NtXd7dvUz8gfHURtveR2ZEQ23xOLcDR2IMFouy 5b0v6hF9oWHTGQ2JmVrysoSsZaY80ehWJ1o8tDWC9xCo+E3Tdr0AqZ0ZYomUkeggJDbb gEdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=L16l9RzmD0ZDu8L5EXImaQcW5WNxxbSTH3J7/7e85PM=; b=doWvBYTBmI7keZi7GMh2EI139mLvy1crJs+tEZMJsYiOBNQ8uIXe838Mj4BeHyfu+E RO3hH/ZeNbabMChceoc8ghAD45+zhiPw4Or/DmE3i7RD3N1iJEAPChk0nXHeBEWtN6E9 9VftA4cgxGrFHtZ+YqzA7/wVRhbpCdaDGbNCTVhhlATVuFW4FFJgoZ5yQnmUdqlezpEI F/MuSsBr4YI5iDQ2KY9QBJcW4JV3oJCqWRqZhOAIMH8G0Mu4xrZzuRPTAUsybATLKIWA rHhhb3gxD4ikcUF48e8WZ3hVny5DogQOjkzBFs5QOcnEGiOG1b/f3/Eh7HiWaE7TGE8A 5KLg== X-Gm-Message-State: AO0yUKVzu01oor6CuHz/qRR4lNKYl1DEQT4ZZO5tY6EZrjHPxUYgjznY kJvLKkzF2eG4vqBUarn9EJc= X-Google-Smtp-Source: AK7set+DFtItZLtago6v2j1HMp5soTDCiAUJghVknlf8yfELQkJGdKdY6m06J8So9VS/xI3fo9Q5TA== X-Received: by 2002:a17:906:2a55:b0:895:58be:957 with SMTP id k21-20020a1709062a5500b0089558be0957mr209537eje.2.1675704882014; Mon, 06 Feb 2023 09:34:42 -0800 (PST) Received: from smtpclient.apple (c188-150-171-209.bredband.tele2.se. [188.150.171.209]) by smtp.gmail.com with ESMTPSA id d20-20020a17090694d400b0088e682e3a4csm5667376ejy.185.2023.02.06.09.34.40 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2023 09:34:41 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <7802fc0d-3abc-8905-411b-4ada721e8013@secure.kjonigsen.net> Date: Mon, 6 Feb 2023 18:34:40 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <792EC2CE-006B-42F1-81C2-453E71C2173C@gmail.com> <12a97d26-90cc-4a25-61a5-5aff33915610@secure.kjonigsen.net> <2F86FB50-87F7-432D-B87A-1738056907AB@gmail.com> <7802fc0d-3abc-8905-411b-4ada721e8013@secure.kjonigsen.net> X-Mailer: Apple Mail (2.3654.120.0.1.14) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 6 feb. 2023 kl. 18.05 skrev Jostein Kj=C3=B8nigsen = : > I've tested that patch myself, and from what I can tell, it still = works just fine Excellent, now pushed to emacs-29. We're done!