From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 13:40:12 2023 Received: (at submit) by debbugs.gnu.org; 27 Jan 2023 18:40:12 +0000 Received: from localhost ([127.0.0.1]:38431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLTdz-0003BP-Ry for submit@debbugs.gnu.org; Fri, 27 Jan 2023 13:40:12 -0500 Received: from lists.gnu.org ([209.51.188.17]:54670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLTdw-0003BG-QA for submit@debbugs.gnu.org; Fri, 27 Jan 2023 13:40:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLTdu-0005Zb-HE for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 13:40:08 -0500 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLTds-0000p6-6k for bug-gnu-emacs@gnu.org; Fri, 27 Jan 2023 13:40:05 -0500 Received: by mail-wr1-x42b.google.com with SMTP id h12so5762598wrv.10 for ; Fri, 27 Jan 2023 10:40:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=UFw+RGUvXai28J6il+FPI18YPb5UhM1N/+i8/pmQduQ=; b=ObwAUeC9ovPnL3kLK9r68rj7cSIQUIek0mFSwPfNlEBU1JIfEVdzV/juru4IVt7WtH nY1I1f0El4nQk6RjF4jbwjdMnQvh2uYWIEUgg4J9J9Zent1C8eGTf0/AC6uCqq66d3r2 1zgr311Jop8Lku2YzhIJ0DkHZ1426UJh6NCjMwGwaJZ0PY6PdN0nk1vmpfSO4hqa9fI4 HUhxrZ7fixCRREXEMerAdbUx0NmRc3r4ofEzcHRZXc4hwGgtNle+6KC7NXjVqQc0bqXh MHkJvxvuACFPnkwOrMzNAZ9BkWF0UBZm79Qk7ZjDVeaiq5tNsJaPndlJA/CIDAdyu/Kd /EYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UFw+RGUvXai28J6il+FPI18YPb5UhM1N/+i8/pmQduQ=; b=DlSuR95o9jl3geSI7Pwatqpp7+3iMs7w609qEDSrEKk/6L+FuxcBM4tov3yPg3wIuG ZMzxYuRgEGH671X7orc/7P2VJ9Gr4aX+BZq0ZK4omuQ9i1aPNaPNE32RIiOb7T0fg9Rb JSpHeXrlgjKeMEmTx2vgBH5tpisqdBUJ5W4mh3wxn8rNJ3yF79PJfLwypiH0sr/vSade h+jMiojUb8PosEthp80bG4zF++mRLxSOtYhGwkkNTp4GabHAwhr4ZRIpC7smMaBjHsJc w9iggyh8kn5CppX9W/LuKbTNyU0ZwUa30tjUDiGtSuTRk8E90cEApSVJBYQ2E1RSgJza q/Zg== X-Gm-Message-State: AFqh2kr4mq0RGXIueWSi5/3Kt7y1jx/sE9k651pI2jr17KJX428/qOqQ gm+EF3fdZACQLQsrrgQGUP1oO71EdEU= X-Google-Smtp-Source: AMrXdXtn04v9d1eCVmBIzGiNIV6lqiEVbAl+JegpcpxJPMBO+Qs42zYU4sNqIih990QQ78Loe7IQmQ== X-Received: by 2002:a05:6000:1b85:b0:2be:f21:6af6 with SMTP id r5-20020a0560001b8500b002be0f216af6mr35033471wru.23.1674844801856; Fri, 27 Jan 2023 10:40:01 -0800 (PST) Received: from localhost ([137.195.26.27]) by smtp.gmail.com with ESMTPSA id t4-20020a05600001c400b002bdcce37d31sm5266581wrx.99.2023.01.27.10.40.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Jan 2023 10:40:01 -0800 (PST) From: Al Haji-Ali To: bug-gnu-emacs@gnu.org Subject: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once Date: Fri, 27 Jan 2023 18:29:06 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=abdo.haji.ali@gmail.com; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) The following code: --8<---------------cut here---------------start------------->8--- (let ((fn (lambda () (message "Buffer changed: %S" (current-buffer))))) (add-hook 'buffer-list-update-hook fn) (with-selected-window (minibuffer-window) (save-window-excursion nil) nil) (remove-hook 'buffer-list-update-hook fn) nil) --8<---------------cut here---------------end--------------->8--- Prints "Buffer changed: #" once, even though the selection should return to the currently selected buffer (which is different from the mini-buffer). I would expect either that the hook 'buffer-list-update-hook is not called at all, or that it is called twice (one time for every change of the selected buffer). Best regards, -- Al From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 02 05:23:18 2023 Received: (at 61102) by debbugs.gnu.org; 2 Feb 2023 10:23:18 +0000 Received: from localhost ([127.0.0.1]:60888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNWkQ-0000cB-Ch for submit@debbugs.gnu.org; Thu, 02 Feb 2023 05:23:18 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNWkN-0000bx-Hz for 61102@debbugs.gnu.org; Thu, 02 Feb 2023 05:23:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNWkH-00067N-GY; Thu, 02 Feb 2023 05:23:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PhAG4Pzwbx0o9RqAVLGtoVFNgNmDj79bwSbz9t/0BHM=; b=Ob8qSDSqdmRh 6gxOR1FegMm9LUZifIxYeGuCTqRaaDmyHIDPo4Au4Mcy9IobqhFGv0YPwXPNqmKkHg3HBuaai1QYU 7kCUyLtFoQMh4PykudEovKc7aekhZLTxQjaLtwJGrU1BhoYDd4Wrp+pn+LZPASNO2oSPyIVO9uNZd PtFSdqdFvgQlGF1egBhhhBzfixyvB/Yzi+Q+y/XsrugGp8XixkOq3B9y/s5J69m/u6YpCjtsHXk0Q 5z3eCIJsKTo3aYda4ab+W8uPwJGyqk16+o+rc/gJM8/JrnMDvaL2RUkn+lqNcXzF8yx4RPU3eKMma XOE/s/Ez3XPukWH4/MXWIA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNWk0-0008Nq-CE; Thu, 02 Feb 2023 05:23:00 -0500 Date: Thu, 02 Feb 2023 12:22:53 +0200 Message-Id: <83ilgkxt6q.fsf@gnu.org> From: Eli Zaretskii To: Al Haji-Ali , martin rudalics In-Reply-To: (message from Al Haji-Ali on Fri, 27 Jan 2023 18:29:06 +0000) Subject: Re: bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61102 Cc: 61102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Al Haji-Ali > Date: Fri, 27 Jan 2023 18:29:06 +0000 > > > The following code: > > --8<---------------cut here---------------start------------->8--- > > (let ((fn (lambda () (message "Buffer changed: %S" (current-buffer))))) > (add-hook 'buffer-list-update-hook fn) > (with-selected-window (minibuffer-window) > (save-window-excursion nil) nil) > (remove-hook 'buffer-list-update-hook fn) > nil) > > --8<---------------cut here---------------end--------------->8--- > > Prints "Buffer changed: #" once, even though the selection should return to the currently selected buffer (which is different from the mini-buffer). > > I would expect either that the hook 'buffer-list-update-hook is not called at all, or that it is called twice (one time for every change of the selected buffer). Martin, any comments on this? FWIW, I'm not sure this is a bug, but maybe I'm missing something. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 02 10:05:02 2023 Received: (at 61102) by debbugs.gnu.org; 2 Feb 2023 15:05:02 +0000 Received: from localhost ([127.0.0.1]:35507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNb94-0005TP-BT for submit@debbugs.gnu.org; Thu, 02 Feb 2023 10:05:02 -0500 Received: from mout.gmx.net ([212.227.17.20]:47453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNb92-0005Sw-9c for 61102@debbugs.gnu.org; Thu, 02 Feb 2023 10:05:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1675350293; bh=yZWhi1Tev3zlGxhLSVpVKdjOfVMeWAqEwop7w81ogYs=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=Fz3cZlWP1Y7pOiCPQnvuzVqYTNl++m2GGFoupWYtMbO1/yOnQoryysa+JwCLTO+Nn uXVQ5mOr7FRx72dsMor/Z7pCek3+DFF+Qdh1FIrfePUJ3YjeBvQ/+nxPVcqCabc+aV kOnlQohrYy1cD2/yFRJ6q7APPbVQke8BiGqvHbcLdxh2czU32jKwbzjfON9+OFG42j cM1l1GR82VB8jiJSB5doXJTbR6U4zXQewYzqnlyu3ti/lUT7FO15GkR4Zi/ue+9LLI GqiT7Devn/ek8fJEpHtUwVAyjs4pG9OoOZoUP1ogub7TIyX92/x+inIorl57mVVUCV e+poL7pBGaE/A== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.103] ([46.125.249.77]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MZTmY-1pAu7H2QwI-00WTft; Thu, 02 Feb 2023 16:04:53 +0100 Message-ID: <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> Date: Thu, 2 Feb 2023 16:04:52 +0100 MIME-Version: 1.0 Subject: Re: bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once Content-Language: en-US To: Eli Zaretskii , Al Haji-Ali References: <83ilgkxt6q.fsf@gnu.org> From: martin rudalics In-Reply-To: <83ilgkxt6q.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 X-Provags-ID: V03:K1:d+9t/4PzeINCGOrwCnZrbGpgxoc3adCbFDTCeYEsRAQgcivuBB3 bfWLVUzzqqZ6ztzpukD3yQQK/TKlDTH2W3pCcHo7VIVWhLdaq4QWFGqviTfa7BrDEbGvUje z0NTYUv5ECxvjPIJcVhA+AEfLTyakLyoZlRTRDA/j374KoF/mOMklzHgeKBnfT15C8P9x6E qMtYUxRbMBGgPrT73BiVg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:Lf8urwHpRIM=;kdvxHyysLjF6l9HNr1NNIYyi55N UDqiTmHxwKdGSAU0GeKzZEU7a8jBdvqTcyj+pscGPfHQnrP/2z56FiUPLXE65HIHDGGg82XL9 b/3Ca/Ai/8WamJdand3r3bN9NButPx6OxEpBeBqdnJX8WJUFylcvmPSkaiagYiI7E/+Kveem1 glCqPKlfmrIE7G8jv7AEPTGLmEK4+VeWZ0SGiFwpmqYXZu4KTY/oTt+ONAfI9SOyhkPkdh0WQ o4DbBC1BKaeZpNf5CSrLWcfsQxatkRbk6jspEUpMczhHQVwSl7TNNDZY3ctAxsec+nt+hjVAc Q1sfGxf1cHcD/nQvg+/iW4akxaMK0vHJOC38nJyCAW8nrxOuy/y0zWeebBTPh9FXYu2mnWxDn XOaC4n/YPc28c1D8Wqv7dBN5CO6gwVUv88NwYCgVaxHHyQLMAHi6IaCJYAOUO+YAwSnIG1WXJ jkcbyCMRYWDrqO/VaR52/AguvesfER+DA4BtXDzRnCpcp8ECStv2vLA4/6y2WyIuLxwciYB7j GWkeilbulsQNpNFJF3aYPULMg1fcgXZZoRSOAe0L60wSn//cUlNwDdQBBF7r08X22dF6WtOrN e75S86CgECiOyCkyNSyOONIDsHg/hK5smJ6rtX3HmRJ7fcEKzeyAFgsWDjgIS45RujA4gcOm6 TmyNwCtRTOCml+jiTd530i+5z5N7lgjSR/MlWsWDJLMRj326iMrepnWtmP9WCohzk/s79AOPn HP6Tv5irN0ZIOg45Bfs8XwJMAOtSmjwh+E5g5Lhikb+zQUO8W62pZtLtjTxqe3LQXRC+qCsHN TXRzbQXbAcXK7uv3pW56klY69SqULdq52okqhdpQkBGpeL5xpzzWgqyey5ndaw4s4qccrTNh8 aIPCjByoxvChu7gi2XTpPjiOsS6Qu+wvQ30ln0eZyr0zQXBBr013MMaJAYTDQxOuSfvd89VSk mJFeA+pZYSPGdDjj2L+prxS6yEw= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61102 Cc: 61102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) ID4+IFRoZSBmb2xsb3dpbmcgY29kZToNCiA+Pg0KID4+IC0tODwtLS0tLS0tLS0tLS0tLS1j dXQgaGVyZS0tLS0tLS0tLS0tLS0tLXN0YXJ0LS0tLS0tLS0tLS0tLT44LS0tDQogPj4NCiA+ PiAobGV0ICgoZm4gKGxhbWJkYSAoKSAobWVzc2FnZSAiQnVmZmVyIGNoYW5nZWQ6ICVTIiAo Y3VycmVudC1idWZmZXIpKSkpKQ0KID4+ICAgIChhZGQtaG9vayAnYnVmZmVyLWxpc3QtdXBk YXRlLWhvb2sgZm4pDQogPj4gICAgKHdpdGgtc2VsZWN0ZWQtd2luZG93IChtaW5pYnVmZmVy LXdpbmRvdykNCiA+PiAgICAgIChzYXZlLXdpbmRvdy1leGN1cnNpb24gbmlsKSBuaWwpDQog Pj4gICAgKHJlbW92ZS1ob29rICdidWZmZXItbGlzdC11cGRhdGUtaG9vayBmbikNCiA+PiAg ICBuaWwpDQogPj4NCiA+PiAtLTg8LS0tLS0tLS0tLS0tLS0tY3V0IGhlcmUtLS0tLS0tLS0t LS0tLS1lbmQtLS0tLS0tLS0tLS0tLS0+OC0tLQ0KID4+DQogPj4gUHJpbnRzICJCdWZmZXIg Y2hhbmdlZDogIzxidWZmZXIgICpNaW5pYnVmLTAqPiIgb25jZSwgZXZlbiB0aG91Z2ggdGhl IHNlbGVjdGlvbiBzaG91bGQgcmV0dXJuIHRvIHRoZSBjdXJyZW50bHkgc2VsZWN0ZWQgYnVm ZmVyICh3aGljaCBpcyBkaWZmZXJlbnQgZnJvbSB0aGUgbWluaS1idWZmZXIpLg0KID4+DQog Pj4gSSB3b3VsZCBleHBlY3QgZWl0aGVyIHRoYXQgdGhlIGhvb2sgJ2J1ZmZlci1saXN0LXVw ZGF0ZS1ob29rIGlzIG5vdCBjYWxsZWQgYXQgYWxsLCBvciB0aGF0IGl0IGlzIGNhbGxlZCB0 d2ljZSAob25lIHRpbWUgZm9yIGV2ZXJ5IGNoYW5nZSBvZiB0aGUgc2VsZWN0ZWQgYnVmZmVy KS4NCg0KImZvciBldmVyeSBjaGFuZ2Ugb2YgdGhlIHNlbGVjdGVkIGJ1ZmZlciIgaXMgYW1i aWd1b3VzLiAgSSBzdXBwb3NlIHRoZQ0KT1AgbWVhbnMgImZvciBldmVyeSBjaGFuZ2Ugb2Yg dGhlIHNlbGVjdGVkIHdpbmRvdyIgaGVyZS4NCg0KID4gTWFydGluLCBhbnkgY29tbWVudHMg b24gdGhpcz8gIEZXSVcsIEknbSBub3Qgc3VyZSB0aGlzIGlzIGEgYnVnLCBidXQNCiA+IG1h eWJlIEknbSBtaXNzaW5nIHNvbWV0aGluZy4NCg0KVGhlIGRvYy1zdHJpbmcgb2YgJ3dpdGgt c2VsZWN0ZWQtd2luZG93JyBzYXlzIHRoYXQ6DQoNCiAgICJJdCBkb2VzIG5vdCBhbHRlciB0 aGUgYnVmZmVyIGxpc3Qgb3JkZXJpbmcuIg0KDQphbmQgdGhlIEVsaXNwIG1hbnVhbCBpcyBt b3JlIGV4cGxpY2l0IGJ5IHNheWluZyB0aGF0DQoNCiAgICJUaGUgb3JkZXJpbmcgb2YgcmVj ZW50bHkgc2VsZWN0ZWQgd2luZG93cyBhbmQgdGhlIGJ1ZmZlciBsaXN0IHJlbWFpbg0KICAg IHVuY2hhbmdlZCB1bmxlc3MgeW91IGRlbGliZXJhdGVseSBjaGFuZ2UgdGhlbSB3aXRoaW4g Rk9STVM7IGZvcg0KICAgIGV4YW1wbGUsIGJ5IGNhbGxpbmcg4oCYc2VsZWN0LXdpbmRvd+KA mSB3aXRoIGFyZ3VtZW50IE5PUkVDT1JEIOKAmG5pbOKAmS4NCiAgICBIZW5jZSwgdGhpcyBt YWNybyBpcyB0aGUgcHJlZmVycmVkIHdheSB0byB0ZW1wb3JhcmlseSB3b3JrIHdpdGgNCiAg ICBXSU5ET1cgYXMgdGhlIHNlbGVjdGVkIHdpbmRvdyB3aXRob3V0IG5lZWRsZXNzbHkgcnVu bmluZw0KICAgIOKAmGJ1ZmZlci1saXN0LXVwZGF0ZS1ob29r4oCZLiINCg0KVGhlIG9uZSBt ZXNzYWdlIHRoZSBPUCBzZWVzIGNvbWVzIGZyb20gdGhpcyBjYWxsIGluDQonc2V0LXdpbmRv dy1jb25maWd1cmF0aW9uJw0KDQoJc2VsZWN0X3dpbmRvdyAoZGF0YS0+Y3VycmVudF93aW5k b3csIFFuaWwsIGZhbHNlKTsNCg0KJ3NldC13aW5kb3ctY29uZmlndXJhdGlvbicgaXRzZWxm IGlzIGNhbGxlZCBieSAnc2F2ZS13aW5kb3ctZXhjdXJzaW9uJy4NCg0KbWFydGluDQo= From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 02 12:06:05 2023 Received: (at 61102) by debbugs.gnu.org; 2 Feb 2023 17:06:05 +0000 Received: from localhost ([127.0.0.1]:35650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNd2D-0002f2-Fw for submit@debbugs.gnu.org; Thu, 02 Feb 2023 12:06:05 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNd2C-0002eZ-H7 for 61102@debbugs.gnu.org; Thu, 02 Feb 2023 12:06:04 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNd27-0004dD-30; Thu, 02 Feb 2023 12:05:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ufD+PfQHi/oIMT6W2bJpqaI7Y5KfDcIBaLS63K3ZGD4=; b=ryLdu09dvvzXQzobuqoJ 7uLbO175AY31oXUCNnUqpN9kBCAXriL3tkg5o2Oq5M5ONfn7JPSdPMH5BnnP3Fm8shRmKGEUJT6hn /plLAAhTkuq5gZhkvDbba7HhLNxr5zNSZajFGxi5pI88kjgww1su/e3mRnsteZiilUfN9usjR5Ozi LEYoDqMC4mj4iOPAhzdt6dTqY1XykNbB80gARaT54jiQxCrz4L6qUZJYAqJC0U48rFsBCt5F6qrIn GTTwDeXNl8ahLMg63WIVreK0LEKQ3/AId3C9uWhGQr9ySNKUBXzWP639rleXc5Lc5QCCKyK9G9Onz xQWt8z1dycYT7A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNd26-0007tn-Aa; Thu, 02 Feb 2023 12:05:58 -0500 Date: Thu, 02 Feb 2023 19:06:00 +0200 Message-Id: <83v8kkvvyf.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> (message from martin rudalics on Thu, 2 Feb 2023 16:04:52 +0100) Subject: Re: bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once References: <83ilgkxt6q.fsf@gnu.org> <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61102 Cc: abdo.haji.ali@gmail.com, 61102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 2 Feb 2023 16:04:52 +0100 > Cc: 61102@debbugs.gnu.org > From: martin rudalics > > > Martin, any comments on this? FWIW, I'm not sure this is a bug, but > > maybe I'm missing something. > > The doc-string of 'with-selected-window' says that: > > "It does not alter the buffer list ordering." > > and the Elisp manual is more explicit by saying that > > "The ordering of recently selected windows and the buffer list remain > unchanged unless you deliberately change them within FORMS; for > example, by calling ‘select-window’ with argument NORECORD ‘nil’. > Hence, this macro is the preferred way to temporarily work with > WINDOW as the selected window without needlessly running > ‘buffer-list-update-hook’." > > The one message the OP sees comes from this call in > 'set-window-configuration' > > select_window (data->current_window, Qnil, false); > > 'set-window-configuration' itself is called by 'save-window-excursion'. So do you agree with me that there's no bug here? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 02 12:20:09 2023 Received: (at 61102) by debbugs.gnu.org; 2 Feb 2023 17:20:09 +0000 Received: from localhost ([127.0.0.1]:35674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNdFp-00030i-Du for submit@debbugs.gnu.org; Thu, 02 Feb 2023 12:20:09 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:37597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNdFn-000308-K7 for 61102@debbugs.gnu.org; Thu, 02 Feb 2023 12:20:07 -0500 Received: by mail-wr1-f46.google.com with SMTP id q10so2365390wrm.4 for <61102@debbugs.gnu.org>; Thu, 02 Feb 2023 09:20:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=VkFNfUK7ZWaT0s/E3QXT1KDVZTnsXki1g679Jn0RKag=; b=C44D/3xepKfgqd/1EP3RkklI3ra80Va/zXXGqZmPUZLWDz0WGbituTitDNypUOJrQ3 yR/HVfSMZPAw9nD3L10kgW6xTjW948tO2yhO+8pGI+gVEq0eVvjQHHyzGUVXTmRNgiBQ hI8xQjzCKM2bC/IuAeZd2+k9qyWS1gE8dCFurJm2Bwml9m6XJTRijHp55u5dtL9ROCmz In1r9/dCXx7Ap/ecM1CMfnWE32S8GmkE9bx7/e9L/zWGS5zNXrYq2BO+Q4Dl8tc7+0OM wWkfl7ooUCQg6PRdCk3leehoqHOulROJvUJPVyvrrDPIPjkRTNnVHNIyfknuUhWlDmqi 17Og== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VkFNfUK7ZWaT0s/E3QXT1KDVZTnsXki1g679Jn0RKag=; b=SWNu+kHbcWd2ODRSI2ekNzao08Jm6dM8dTdqIpGf4hpel1jmGrw6P3LJ6lunbqLTwv fawqisHKxr0aQn4IZJcDdtmc5qvetK1JCGV4Bvu6M75MJF75F6nqSmRjuhOFPGBGLK63 SqlGnt4I0lFalpW0N2Mq3IcOzlgO0b1iIYoPOdC6ymc45NfmDMlvsoX7V0f1/7DVu2FO yamkh8PZqlWImhDZQdX6S70GdaDrk6nHPq4i5HHTQKwPfv20yqtYMQDQMoVUlVNC7mYY TPE0oIwvFnd9u5W2jAUj0rMMVZ1cSIdxurU0BIC3KIpKcPtOIJPamP1Wa9T3pcEX6m/W eIrQ== X-Gm-Message-State: AO0yUKWf3ONXa+huTV5n8KWOn/LzmFWwzAwnctCh77rLQiZ+NqsKd9Ez +5zEBFdttN03iPe5jXoD6SE= X-Google-Smtp-Source: AK7set++a7CuaXRtUh/SW31Ri/lNhilfaTYQxcr84X7iNfGtErUt/GBj6RotvdRQ6ZO5aYG9//2Piw== X-Received: by 2002:adf:e5c9:0:b0:2bf:ae42:9879 with SMTP id a9-20020adfe5c9000000b002bfae429879mr6083128wrn.32.1675358401362; Thu, 02 Feb 2023 09:20:01 -0800 (PST) Received: from localhost (sgyl-45-b2-v4wan-165314-cust948.vm6.cable.virginm.net. [92.236.87.181]) by smtp.gmail.com with ESMTPSA id l8-20020a05600c4f0800b003dec22de1b1sm447028wmq.10.2023.02.02.09.20.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 09:20:00 -0800 (PST) From: Al Haji-Ali To: martin rudalics , Eli Zaretskii Subject: Re: bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once In-Reply-To: <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> References: <83ilgkxt6q.fsf@gnu.org> <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> Date: Thu, 02 Feb 2023 17:08:55 +0000 Message-ID: <87mt5wxae0.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61102 Cc: 61102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 02/02/2023, martin rudalics wrote: > "The ordering of recently selected windows and the buffer list remain > unchanged unless you deliberately change them within FORMS; for > example, by calling =E2=80=98select-window=E2=80=99 with argument NOR= ECORD =E2=80=98nil=E2=80=99. > Hence, this macro is the preferred way to temporarily work with > WINDOW as the selected window without needlessly running > =E2=80=98buffer-list-update-hook=E2=80=99." I see that the behaviour is not a bug as per the documentation. But it does lead to strange behaviours in code or packages that rely on tra= cking the selected window since there is no way (that I see at least) to de= tect that the selected window did not change, or changed back at the end of= executing this code. Best regards, -- Al From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 02 13:16:48 2023 Received: (at 61102) by debbugs.gnu.org; 2 Feb 2023 18:16:48 +0000 Received: from localhost ([127.0.0.1]:35780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNe8d-0004Wx-Oj for submit@debbugs.gnu.org; Thu, 02 Feb 2023 13:16:47 -0500 Received: from mout.gmx.net ([212.227.17.21]:54819) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNe8a-0004Wi-TX for 61102@debbugs.gnu.org; Thu, 02 Feb 2023 13:16:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1675361796; bh=RI0LsiPyiQ9qUdsRXss3peYZIeM09BgyERiiTOjER1g=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=R3ALvqJW2tE6PYoVzt4+R2mrQtKWYIHPUqg1HTRiunKFNLWhhMbmRdO3aC1hjhsh7 T9yALoYyM+0lOfP3Kf0NetqZfs9qa898O+MhOBex4G4/Yd2JjRUmmied19ScIKF+Ro Vln9DzhpHaMN9A6Ly+7Vma0jXxp9SOVden6vMjsxbUKxV+WPVjHgUpoAWTzE9EKoWF 36yiFasm4UDRt5ZxNbxYOyZYCDfqnAyyVlJJMl+HwbQ4MOwXn5QLUoWboT98Qwb8dN mmawtqIJ7aLd8YPWOYKe0CByD2GWq64RT5odmDqDKHUqlJfsCVKBLjQ44z3vCq8JE2 UMGCV+dXaix2g== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.103] ([46.125.249.77]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MaJ3t-1pB9Iv0Pw5-00WHQo; Thu, 02 Feb 2023 19:16:36 +0100 Message-ID: <1cfc87e6-cd04-2242-0518-603d0c8c6fb1@gmx.at> Date: Thu, 2 Feb 2023 19:16:34 +0100 MIME-Version: 1.0 Subject: Re: bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once Content-Language: en-US To: Eli Zaretskii References: <83ilgkxt6q.fsf@gnu.org> <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> <83v8kkvvyf.fsf@gnu.org> From: martin rudalics In-Reply-To: <83v8kkvvyf.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:NTKNYGR+zYG/N7C3LJGhAkEzqqThWTVRphkEUzjfa87POOH0AiT vWrK/SGiJhrAZlcqnoCmEBZAgn2w7PtGXRM3FoLwm9ioXE18en5ngJ0t7k8fkx5mDnTt11R 4M6eAEmG8Kavj7y1oaVqz2kzn5HbcqE6fU9uxdamsbtCRAjWeYVD+Sge0oH99AHt64CYTpM OX7ap+m1npoPLhodtPIVw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:JRvFX1VQG/o=;GogPjkVx1O1fbbp9JeoVET7NoPg culkGB7tFAYT8Zv/zNNEM+nutKnRxLigqHhOLIJdhOEy5DxDvnyeTnuKATjtRKUBzcECaK8A1 b1sq+x8hvUaZ1onZhGghHBsKAO/27+9648SbfdQWz9QoCsi1EIl3kRwD7d+sJqIJAYxDHJ3wc smiKuo1SH2Zvdnc+aBO6DT7IBfqOBImhLrJXaVyNDhjlCOzbsigJ+Uh/nTsNZ9GS/DluYm9xr TaI+H+99uSmezgdp9G6E3bDVHQR5f9okKjNvJ/XnAcVx2GxVycF6r7qh9VvuFMEQaWRhwKW1B PQZeZksx5gWl8xdRUN9jp2dO4GicwHXII9xkKMIeny/l3UVKTcLETPBiheUux+Q2vAtQJ11Y5 GzTqLrfrO42iKeZyKEWmGk/6Pbwec2PouXGy77XCgtZbikMdC6pGgmVOigL5x+qk1+DinurEj 8citAuj+K5e9GTyzFIMxf8VMv5Hmg9G4SOWdmr3PKJctUAs/cjAsKBZ2V/slA/WdAYC0Yh7S9 WbXs8RDRsqfZEsbJJN+xTE6Nx3RVdEKouj8z7wVn0NIRTzkm75aXKiQlq28CwSB94UBwWscVa n60RQxwozx8VtpHptKQmgpYhHBcAPY3y8DWsEDIE7PVo46hIqBmjJGZmCj2eD//eZlko0n5aV IQt3KereMr7yaReromRaD1b+itFOgdI+K7oGnQW1HhZwgDi+bkYwrFPlB6JsxdEv5j/LhCHbZ lLTuhftHSeqQklP2yfsS1W4luXgI+0niBRgNiBK3cKKinO+/cgCfnVkokIQQ6mfNmHxtZoss6 J+Y8MOUl+0eeGFioduagKfxEZA77niQQuVYzuABhh+eGKAbUvubOSSl8boGuf9TntybUAXVA0 SZmZoAmJYJFRNRMtgImVxF/pshT+mN5OHcKE761MNg6Ol1AV4kLDkwjLABuind3Vl345YIPHT ptUmNHv6PANb/phDETGfFpswa3U= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61102 Cc: abdo.haji.ali@gmail.com, 61102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > So do you agree with me that there's no bug here? Yes. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 02 13:17:19 2023 Received: (at 61102) by debbugs.gnu.org; 2 Feb 2023 18:17:19 +0000 Received: from localhost ([127.0.0.1]:35784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNe99-0004YH-2n for submit@debbugs.gnu.org; Thu, 02 Feb 2023 13:17:19 -0500 Received: from mout.gmx.net ([212.227.17.21]:37723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNe97-0004Xy-Tm for 61102@debbugs.gnu.org; Thu, 02 Feb 2023 13:17:18 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1675361832; bh=Ot2570mHx7ratefNBY+u5CkWTSzeuE7wlvpS300J+0Q=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=Hk8/m2PM4VTsiFNWJNt6Uqsgj9PTFVTiGHQ8a1ZMRpNsokj7p2LqbidHeq8H+rjLd WRFz+kUrGiFlZtPaxE5qJLmUdfb0IbAP4fYkBUju+FLDIObnADrgDcWUiKTZnll/9r uhAs3JzKy9t+fo/VYmdWenfAYYxABc+YOITgRUSF3finm7Cjq9wmRaXracD/Aeamk5 ufOZ3Yzwc1s3bifKz9jZm8hBRJTYWFSFJFivkCccwRFJ8P1KamDBkNqu7neryOc94W qGm07cEBVn5iMDZfanaMCudvI6CoGWO6pg4ozBaeMMvZ+gVnoqb1S29aBFYTU/Igm/ 6aBercj4GgDLw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.103] ([46.125.249.77]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MBUqF-1pUTMW3Vz5-00Czvc; Thu, 02 Feb 2023 19:17:11 +0100 Message-ID: <11f81172-4649-655a-d1b1-c49cf57d315b@gmx.at> Date: Thu, 2 Feb 2023 19:17:10 +0100 MIME-Version: 1.0 Subject: Re: bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once Content-Language: en-US To: Al Haji-Ali , Eli Zaretskii References: <83ilgkxt6q.fsf@gnu.org> <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> <87mt5wxae0.fsf@gmail.com> From: martin rudalics In-Reply-To: <87mt5wxae0.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:nMWuuqC00GitZ53E+snD9Ly3CvXyGu81Z5FfXF1OpAeuh0epJPg MpQuBag7hXVgpS5ZYFbhRG6J/zklDcBtPEboddf62XBheCTgnk2ybLAZ6xc5Cb6wEPGLB9N 6PQu5LYG7NXgUW7xqlqG3+lkwMXqqN/16q4tt2TwhYxfpKaYqX5rXoSgvau9vCoMrpo0UrN RiQbJPUMaSJCUqAqEv4oQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:r2dheEYLtG8=;8j4zIfKgu8KW6MZ1sUK4/EtduMX 0iieiSQZX0q6r3D0TR7yVV7PJWOSH7zmjTayJeEJXBjYHXqgsBqwlObCaXFjmTmjnu6gwaz+2 9exBTG2gSG0mjwg97Vn15HQZuT/raB2vGTU6wGD48qAY06eutmyQ7oHnNRcXK0hR3CPIlLaF7 jH4i+lKkMipNfHYk9nXT9w0arKJIZYCKUKa7PPHTzd2U0N7FxdH/15bje2C0aP17tQccndtRf SVjOKGzpqarf7DsQRcRMwggKPAld5TlPt87AwELdXmFfxictuIxUVL/j4TDxvztWDu5+ml42+ xs7jUfgiOVFS+iWtqViC6BMX/+O+nvyOEr0e7gKoEaeiS4tgb/o96vo+1UuZpxgS6iFt8i4mK RqqtVP4mZNV1ngXur5fFWoJHrOYv+RCXW9XMi7k71ccCacbZn7byaX84GN2viEPGLY774PV4G 4LZ3XtRx+sew1zYJKwDBhppDlsgiK84HuPUCscws8Rv1AeoAI5gmO00lXRbxDjb0t1RhSPXU1 PhqqUMlDrCG+SpfmRr46E1vhWGHYmMehOJxv15kJj5dGaAA4SUZetNVZb3CFjIHrv8jcR/xFF sOFOyI5NYJjiS9hW4Mxd37wHerEL7PQ2wShdZWNyNZcE9mEZfL3sQ69WKheUIQ6Z5CAgeA6au 4PFv4x2CuISLZ3eWDO1lIBtQg4bNvLN9ecTervg14Ecjzj9c8XNL1fMsZxei6y1En5A1c6nOA BzMhw5pLrUSugrJ3JC+K9gJ8qLRwUQQz5tfIs4nYQFt5fG9zMTCJoWV3x2UeDKoJIgfG6qSVQ wNFMhjqE8bcVxUbmxuWzeChcbtOZxKuYp88/BVnT9nrqAdVZlbp4FN8RNBomUWDnESxwkZGVS HUWuYbbWbQYX6Bu54tOa0SYT0dG8p9nam8B1Dh92rChUbdlxRq8aw9adivXCzihGgvpATOvlJ euit8dQVw3hGYZZban5SKNTXics= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61102 Cc: 61102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I see that the behaviour is not a bug as per the documentation. > > But it does lead to strange behaviours in code or packages that rely > on tracking the selected window since there is no way (that I see at > least) to detect that the selected window did not change, or changed > back at the end of executing this code. You can save the selected window, call 'select-window', run your code, call 'select-window' with the previously selected window again. Or have a look at 'window-selection-change-functions'. If you told me what your code is supposed to do within 'with-selected-window', I might be able to give you further advice. As a rule, both 'save-window-excursion' and 'with-selected-window' should be avoided, if possible. martin From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 02 14:57:03 2023 Received: (at 61102-done) by debbugs.gnu.org; 2 Feb 2023 19:57:03 +0000 Received: from localhost ([127.0.0.1]:35860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNfhf-0007Hp-0E for submit@debbugs.gnu.org; Thu, 02 Feb 2023 14:57:03 -0500 Received: from eggs.gnu.org ([209.51.188.92]:57918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNfhc-0007HL-FE for 61102-done@debbugs.gnu.org; Thu, 02 Feb 2023 14:57:01 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNfhX-00013x-2u; Thu, 02 Feb 2023 14:56:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3kwwmvVRxPKWGy3Y4hfj+3KO45lt5NYQR/4wD8Lbzb4=; b=OqDH8HQp8/8n FE8WDnFB+iWZIjRENWi2ipqHbNPqbN7RjZfEWLBnbyAKFvn98kT5a9E1TvB/k6eZIP/koGLAomrYg 23oB73zHGtn1yg10RGpVYvE4iBcTIoVv8PNCmIag29m8wR+OF3Oeg0r60cruI6nrhPVgOW1m4tYHj xZKCfuIC65PfMWXQs7sMlKxr85dr9N3qawzc/OSEu1syvTmO7VFAB4EaYjtXgYTwtlE0k9Lv0oUGS b7CWhOkkNLxicpXaIkBCHLPaKzM3ip5B4d4YiXzguqX6PIx0R1vttE0clr8lPwu6pEdHGcSBLXOeH 5mjOByY0OuAeyGetr9KJKA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pNfhW-0005KZ-Hv; Thu, 02 Feb 2023 14:56:54 -0500 Date: Thu, 02 Feb 2023 21:56:56 +0200 Message-Id: <83bkmbx2lz.fsf@gnu.org> From: Eli Zaretskii To: martin rudalics In-Reply-To: <1cfc87e6-cd04-2242-0518-603d0c8c6fb1@gmx.at> (message from martin rudalics on Thu, 2 Feb 2023 19:16:34 +0100) Subject: Re: bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once References: <83ilgkxt6q.fsf@gnu.org> <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> <83v8kkvvyf.fsf@gnu.org> <1cfc87e6-cd04-2242-0518-603d0c8c6fb1@gmx.at> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61102-done Cc: abdo.haji.ali@gmail.com, 61102-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 2 Feb 2023 19:16:34 +0100 > Cc: abdo.haji.ali@gmail.com, 61102@debbugs.gnu.org > From: martin rudalics > > > So do you agree with me that there's no bug here? > > Yes. Thanks, I'm therefore closing this bug. (The issue can still be discussed even though the bug is closed.) From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 02 16:30:09 2023 Received: (at 61102) by debbugs.gnu.org; 2 Feb 2023 21:30:09 +0000 Received: from localhost ([127.0.0.1]:36026 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNh9l-0003ss-82 for submit@debbugs.gnu.org; Thu, 02 Feb 2023 16:30:09 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:43715) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNh9k-0003rK-7H for 61102@debbugs.gnu.org; Thu, 02 Feb 2023 16:30:08 -0500 Received: by mail-wr1-f46.google.com with SMTP id h12so2924586wrv.10 for <61102@debbugs.gnu.org>; Thu, 02 Feb 2023 13:30:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=wKXGCJtscai230ZWYGuxgJGb7VsKJiY7aQeUyEvUd4E=; b=lfV66yJ7iuvaACN6Q3j+n4nOktxFmgS44JSNkFCm1UEoI/HA58K4DUPR0+JEyLYUnX +AMYH5JFJIVSebmKks8C9MhP4/wGl3btV7icGR2ZepD6SAZAmPHmrVKOpPXAyj1GadLg tsNKQMxGQDXE9hkrnr9Pm0NdnUbV0UkyfqOHFvzZtqgDiMfldusqF+0LzxaFL3HCLdXv mnvh9epmvV0wiLAnKxzIux8i8TcCfQ86FQO5SD7ApPj4Lw4QiFbv3KjZEBFX0S7dPzmw ZN8JGG19g4r+gCxWIu+pz9yH1ZHfmxfDTv+qoEPaS+gpDUgGOm2QIDEtpo8hHXc+qQ2n fm8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wKXGCJtscai230ZWYGuxgJGb7VsKJiY7aQeUyEvUd4E=; b=RdPRHbJlDxoIcgd4lrCMRmOQkCYsnY7tqGErz/XacSKG1BZe+loDpDUwTICIH/ZJB7 VKBenqddxVVUfmKwBKViuNKiIRrbo4dLFzJpqyASMoC4NxOg21SDONylaVcUa56ORE1S /EG78UoxRqZGhu7Zf9CfHtK3fPi5/jvP/yf9bk8keQZTrZbiUDamXQnNy0FwQEOiP6/3 D6CU1yQa6WWyTmjUyAhwh/52vHsWjmCJZmX9vrVBKBMPhKE/7gfLad6b8rQEZvRX0pnw P0CWGn5LyIRrmaFGz5cJ1pbDWo9ph1UnAhuT4hTpda3/jtcuzBwkhMjMgXT1HnIZgKAh FfdA== X-Gm-Message-State: AO0yUKVFwKnBbHzkpergjK7RxsTYnpy1p2dyo2aYMytC7GfzeDPEvG7z h0dwhBHFL4lz+HOKwVAUesw= X-Google-Smtp-Source: AK7set9sk2v0OibAG929z/YS+XOgnfTVveICgLgyjPaouYelOSaODmaAh01VkHB+NKjucPLK5GJG6A== X-Received: by 2002:a05:6000:1542:b0:2bf:c319:c83f with SMTP id 2-20020a056000154200b002bfc319c83fmr9334623wry.21.1675373401959; Thu, 02 Feb 2023 13:30:01 -0800 (PST) Received: from localhost (sgyl-45-b2-v4wan-165314-cust948.vm6.cable.virginm.net. [92.236.87.181]) by smtp.gmail.com with ESMTPSA id c14-20020adffb4e000000b002be0b1e556esm398174wrs.59.2023.02.02.13.30.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Feb 2023 13:30:01 -0800 (PST) From: Al Haji-Ali To: martin rudalics , Eli Zaretskii Subject: Re: bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once In-Reply-To: <11f81172-4649-655a-d1b1-c49cf57d315b@gmx.at> References: <83ilgkxt6q.fsf@gnu.org> <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> <87mt5wxae0.fsf@gmail.com> <11f81172-4649-655a-d1b1-c49cf57d315b@gmx.at> Date: Thu, 02 Feb 2023 21:21:12 +0000 Message-ID: <87edr7yd9z.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61102 Cc: 61102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 02/02/2023, martin rudalics wrote: > You can save the selected window, call 'select-window', run your code, > call 'select-window' with the previously selected window again. Or have > a look at 'window-selection-change-functions'. If you told me what your > code is supposed to do within 'with-selected-window', I might be able to > give you further advice. As a rule, both 'save-window-excursion' and > 'with-selected-window' should be avoided, if possible. Thanks! I should have clarified that I am developing a package that keeps track of the currently active window and executes certain code when the selected window changes (similar to auto-dim-other-buffers, if you are aware of it). I can't control what the user of my package does, in terms of combining `save-window-excursion` with `with-selected-window` or otherwise, so I am looking for a solution that works regardless I guess my only option is have an idle timer that checks if the current selected window is different compared to the last time a `buffer-list-update-hook` was called. -- Al From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 03:33:41 2023 Received: (at 61102) by debbugs.gnu.org; 3 Feb 2023 08:33:41 +0000 Received: from localhost ([127.0.0.1]:36461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNrVs-0007dd-Vi for submit@debbugs.gnu.org; Fri, 03 Feb 2023 03:33:41 -0500 Received: from mout.gmx.net ([212.227.15.18]:36239) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNrVq-0007dM-2Y for 61102@debbugs.gnu.org; Fri, 03 Feb 2023 03:33:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1675413211; bh=2stZeC5DVs/C23WFNFFNW3ry5o53mUseahYo6qKh2Hs=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=QiSy0PGQNsr51d2cQYqeOlq/Tnu6qUWVNyDUcXxcjw+R8T4tMyLhF1x33xSM0bimz iHIvvBTyBf73FqGI9X/PlM4LCHhBCUQFKZDgOPXEUewVOyjQ1Y0bIYI3w0NPE4OPMt NCvimlPSj9H4ArJxDYD7xn1IKT3av+KvdL57LCTw8pfbi2cAuOPwEC0/yafDvowyjr eMNn3Fj4zbXT4P0WE0RFbdgVu4YjZO2fu5o7HDDXrKX5w1MBjdo+65r3XjHACXM0bE ikYrWFlPczp13U8ivqX4IA7sYgdk7jQGFpXfO85ggJv9fFifc9aeGEW7NMgLWwjSwm losCjaQH/ufsA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([212.95.5.171]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MPXhA-1p2MLR30MM-00MbSq; Fri, 03 Feb 2023 09:33:31 +0100 Message-ID: Date: Fri, 3 Feb 2023 09:33:27 +0100 MIME-Version: 1.0 Subject: Re: bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once Content-Language: en-US To: Al Haji-Ali , Eli Zaretskii References: <83ilgkxt6q.fsf@gnu.org> <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> <87mt5wxae0.fsf@gmail.com> <11f81172-4649-655a-d1b1-c49cf57d315b@gmx.at> <87edr7yd9z.fsf@gmail.com> From: martin rudalics In-Reply-To: <87edr7yd9z.fsf@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:9uXppunOSeC73bQu+Nj2Uq1U8toOdpL70eB4wqanuco+6BKkVrw vB12U+jbwF1qfArdEz4LeN+e4gqbRh+X48GhEThjcTBPYfEL1uNEBcPONyYqU/U0ogCLjiL B/lhWByO/wV8OG+A6atE6lywhr4NGCbKMy8d9D4L9blGyOn5REaSSpv5RXH+2V1Xz7lLhTm T0nPDX+j94n6jm1F3J1RQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:PsevbQ7JfWg=;V0eiYshEDdBkb6JK1O+Pr247/Ui 9iWy4vunt6tRXDumxjmI9/CSxNtbNq+5SL8rkwfJnN9F38O+k6tLfFcAF91imca9B9P/149gj NhIXYJh42I5Hbm3mmqdIeY0pr1VhUdWRUH7pMVASxD3uF051VnvvNpnme+5eOZWSaVCiSHQED lB+RerK0iGNmzETecdDNqfKB8P0TNkv19ZtTaFuaBjZL+1VAd4p30asUzJTMGdaDaPc58Ez43 uOUrM51Oe2/UP4xpYWgL+SQWWLdhO1tCNaFmo6U6NRK2sUE2U2dfN+JEcep9d8+8OCb3IyUBs Mq6PTRa5RpfVkUyEzuYk5u6Bl2pXsPsEF97RCvuNSu0Rqjh43WwH+c0RTU1BMzLD9O4WF5Zvr febKxfh5LH5W4q5EuwRL3W8xuYxMFHHR2Bh7DFCeedBczoUaj4IUKX4nXZGbE817PrB3qU+Os qznr7l+yezplONB2e93KYe2b2uKFSjeKVJKzY9Sr4leBaqt379ywut3Yu/PHYH6RogB8EbyWZ Fbt9Y7C5z/Hr2ulZUSLi1KvPAUVfRXAhs3Py4NJxNiytpH8k4/ERvjQcGRQnMjRsWmhLPJTY5 u+hbkPGO9xHkfy6OFaJFVnU+2heIBSXKNnvZiWbVyjNTR7KdF3wRtrK1QMsbB9bzoUpS8EV5K Mlxci/rLAu1GhRDbcPta/6c6XI9d/n4u5vFkdIsJ7qget+CnAw/DF1czoauYRw18J8o83lPp0 wAn0z61ye+GiAscuUmG04umnKtyZO+RwWTugUps/vjY/p8+eWUrWCZBpvSUoIMrHxTo3yV0tK b8Z7IpJd4EhGXHIRAiAmLDtdh9tAgurztbH8nUOUwqPioEUUdMRbF/w4Cpsdgw+oHbA1WawLA /xFdqwEhWno+zZeDZkrbhx2DEnNwyiUgyIV83gcCkmVerG+GpPoxRvxSaaqeqVGG9TIHw4IlI 7/Zupg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61102 Cc: 61102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Thanks! I should have clarified that I am developing a package that > keeps track of the currently active window and executes certain code > when the selected window changes (similar to auto-dim-other-buffers, > if you are aware of it). I can't control what the user of my package > does, in terms of combining `save-window-excursion` with > `with-selected-window` or otherwise, so I am looking for a solution > that works regardless 'window-selection-change-functions' (or 'window-state-change-hook') should handle that. If these don't work for you, please tell us why. > I guess my only option is have an idle timer that checks if the > current selected window is different compared to the last time a > `buffer-list-update-hook` was called. I rather suppose you want to check if it is different to that of the last time your package did something particular to it. martin From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 03 07:00:15 2023 Received: (at 61102) by debbugs.gnu.org; 3 Feb 2023 12:00:15 +0000 Received: from localhost ([127.0.0.1]:36640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNujm-0000qo-Ls for submit@debbugs.gnu.org; Fri, 03 Feb 2023 07:00:14 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:39808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pNujk-0000pU-HB for 61102@debbugs.gnu.org; Fri, 03 Feb 2023 07:00:12 -0500 Received: by mail-wm1-f51.google.com with SMTP id hn2-20020a05600ca38200b003dc5cb96d46so5828478wmb.4 for <61102@debbugs.gnu.org>; Fri, 03 Feb 2023 04:00:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=NFWeSoOwZvuGpMpfsKeRasJXMO5WDITUaBT2RCn2gYo=; b=Sod8QdfwDpCMAA3LsHjXZwgnosvufTeg2M4G0OYIJvtLLCNaDTkCl2GV//wd09Jko7 bZLU/Of8EFFct22fE7kF/z4GL6v56RUD3z4CuogpnfInbxdapXBXuI1FFlqLTPhSP02c /jdEdpWXTmZRRYYWg7eUjmkLjS5N34bcYUI5bbtC87+GA35JEpbLeWUA/brOJ1XR10lM 4DZDKYbQt/Cj81d9g0Fw3nd/WwMJ4E/bBMEqAAd8RSPMZ1ivbaFI4Qe9bcmhgpD/qJUV u9Ty4PW8wiZTytrTyJIJjEv08B/sJX6VNkvlO+b1MwtCA0/5ubWVTBCyYCH3q8qeGA46 ZRkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NFWeSoOwZvuGpMpfsKeRasJXMO5WDITUaBT2RCn2gYo=; b=E+5whJ7+jC1zNkLo1n84w8zvj25ZZjV17wO4LfNuhh2RKV+r8LZVLBKH0LFfF37Kh9 bpChrSK/+gqtJvMY438zH5HQiXTb4d9rRR1Vll3jzZSlj4JuapjAo0PqYF6QEbmoBghH T0glJ54QLY4ADVXYHUAAmPwcYkgcBDs2z/4xn2OYYAgbq2C2zlXNawDPIvp/xIyzslNX YQr9AwHKeczgYRUU3ADRP99Wyw8PRlmytC1agAaUuWFzflXE3MxpnxziAShYEuvp/TYW jCT1NHP1+xy7XsROC/ky3urVEUuHmvKsuMxbgxFRvZ2iVgOATZPhwbzp1NRYWYFDLUXb vKPw== X-Gm-Message-State: AO0yUKW9vaBmv4U10B8BhRFqlP7mh20Z9E9MmOwt3BRsyxvDYmYulDOl kJxgVQPZC/46wgOcLkv+E0s= X-Google-Smtp-Source: AK7set8VsR2X93gyswkAXN6gLfXJjghzF4HPgN6A6Z2RnuLWBrGdDTDb0sB5AtXficbdZItUZyWoKA== X-Received: by 2002:a1c:4c17:0:b0:3da:2a59:8a4f with SMTP id z23-20020a1c4c17000000b003da2a598a4fmr9537949wmf.38.1675425606480; Fri, 03 Feb 2023 04:00:06 -0800 (PST) Received: from localhost ([137.195.26.27]) by smtp.gmail.com with ESMTPSA id he7-20020a05600c540700b003df5be8987esm5764289wmb.20.2023.02.03.04.00.06 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 Feb 2023 04:00:06 -0800 (PST) From: Al Haji-Ali To: martin rudalics , Eli Zaretskii Subject: Re: bug#61102: 28.1; with-selected-window/save-window-excursion calls buffer-list-update-hook only once In-Reply-To: References: <83ilgkxt6q.fsf@gnu.org> <780090dc-1cc9-e8f6-893e-be12972b78e4@gmx.at> <87mt5wxae0.fsf@gmail.com> <11f81172-4649-655a-d1b1-c49cf57d315b@gmx.at> <87edr7yd9z.fsf@gmail.com> Date: Fri, 03 Feb 2023 11:49:14 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 61102 Cc: 61102@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 03/02/2023, martin rudalics wrote: > 'window-selection-change-functions' (or 'window-state-change-hook') > should handle that. If these don't work for you, please tell us why. Indeed! I was using the code of `auto-dim-other-buffers` as a guide, and I am not sure why `buffer-list-update-hook` is used there instead of `window-selection-change-functions`. Your suggestion makes sense and I will stick to it. Best regards, -- Al From unknown Tue Jun 17 22:28:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 Mar 2023 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator