GNU bug report logs - #61083
29.0.60; js-ts-mode does not correctly fontify imports with aliases [PATCH]

Previous Next

Package: emacs;

Reported by: jostein <at> kjonigsen.net

Date: Thu, 26 Jan 2023 19:38:02 UTC

Severity: normal

Tags: patch

Found in version 29.0.60

Fixed in version 29.1

Done: Theodor Thornhill <theo <at> thornhill.no>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 61083 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Jostein Kjønigsen <jostein <at> secure.kjonigsen.net>
Cc: Yuan Fu <casouri <at> gmail.com>, jostein <at> kjonigsen.net, 61083 <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#61083: 29.0.60; js-ts-mode does not correctly fontify
 imports with aliases [PATCH]
Date: Fri, 27 Jan 2023 13:47:50 +0100

Jostein Kjønigsen <jostein <at> secure.kjonigsen.net> writes:

> Currently js-ts-mode handles imports with aliases incorrectly. To be
> consistent with how we otherwise do things, we should only highlight
> the variable which is new and/or introduced.
>
> This bug is closely related to the following typrscrip-ts-mode bug:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=61081
>
> Attached is a patch which fontifies import-declarations somewhat more
> correctly.
>
> The following cases have been tested and all fontify properly:
>
> import gnu from "fsf";              // highlights gnu
> import { gnu2 } from "fsf2";        // highlights gnu2
> import { gnu as gnu3 } from "fsf3"; // highlights gnu3
> import * as gnu4 from "fsf4";       // highlights gnu4
>
> --


Thanks, Jostein! Installing them today :)

Theo
This bug report was last modified 2 years and 119 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.