GNU bug report logs - #61082
[PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143.

Previous Next

Full log

Message #14 received at 61082 <at> debbugs.gnu.org (full text, mbox):

From: conses <contact <at> conses.eu>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 61082 <at> debbugs.gnu.org
Subject: Re: bug#61082: [PATCH] gnu: emacs-pulseaudio-control: Update to
 34a61143.
Date: Sat, 28 Jan 2023 13:59:48 +0100

Nicolas Goaziou <mail <at> nicolasgoaziou.fr> writes:

> Hello,

Hi Nicolas,

>> -      (source
>> -       (origin
>> -         (method git-fetch)
>> -         (uri (git-reference
>> -               (url "https://github.com/flexibeast/pulseaudio-control")
>> -               (commit commit)))
>> -         (file-name (git-file-name name version))
>> -         (sha256
>> -          (base32
>> -           "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76"))))
>> +      (source (origin
>> +                (method git-fetch)
>> +                (uri (git-reference
>> +                      (url "https://git.sr.ht/~flexibeast/pulseaudio-control")
>> +                      (commit commit)))
>> +                (file-name (git-file-name name version))
>> +                (sha256
>> +                 (base32
>> +                  "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5"))))
>>        (build-system emacs-build-system)
>> -      (arguments
>> -       '(#:phases (modify-phases %standard-phases
>> -                    (add-after 'unpack 'patch-file-name
>> -                      (lambda* (#:key inputs #:allow-other-keys)
>> -                        (let ((pulseaudio (assoc-ref inputs "pulseaudio")))
>> -                          (chmod "pulseaudio-control.el" #o600)
>> -                          (emacs-substitute-variables "pulseaudio-control.el"
>> -                            ("pulseaudio-control-pactl-path"
>> -                             (string-append pulseaudio "/bin/pactl")))
>> -                          #t))))))
>
> Why did you remove this phase? AFAICT, pulseaudio-control-pactl-path
> still exists.
>
>

Because this might have been needed when the package didn't allow
the pactl executable path to be found dynamically, but as per
https://github.com/flexibeast/pulseaudio-control/commit/c8640fceb530ab7a1aa551d70f7ee222147d95cf
this is no longer needed.

-- 
Best regards,
conses

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.