From unknown Sat Aug 16 21:59:15 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61082 <61082@debbugs.gnu.org> To: bug#61082 <61082@debbugs.gnu.org> Subject: Status: [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143. Reply-To: bug#61082 <61082@debbugs.gnu.org> Date: Sun, 17 Aug 2025 04:59:15 +0000 retitle 61082 [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143. reassign 61082 guix-patches submitter 61082 conses severity 61082 normal tag 61082 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 26 14:07:53 2023 Received: (at submit) by debbugs.gnu.org; 26 Jan 2023 19:07:53 +0000 Received: from localhost ([127.0.0.1]:36219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pL7bE-0000Pr-GM for submit@debbugs.gnu.org; Thu, 26 Jan 2023 14:07:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:59404) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pL7bC-0000Pi-Kf for submit@debbugs.gnu.org; Thu, 26 Jan 2023 14:07:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pL7bC-00025Z-DP for guix-patches@gnu.org; Thu, 26 Jan 2023 14:07:50 -0500 Received: from relay10.mail.gandi.net ([217.70.178.230]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pL7bA-0002Ky-5E for guix-patches@gnu.org; Thu, 26 Jan 2023 14:07:50 -0500 Received: (Authenticated sender: contact@conses.eu) by mail.gandi.net (Postfix) with ESMTPSA id A6DF2240004 for ; Thu, 26 Jan 2023 19:07:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conses.eu; s=gm1; t=1674760061; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=M/LIZvJGM87X2I/m1pBhuer67rm2yczMrVb0PdvEdvw=; b=RzuhGV64Tc7Naj+VR6z7N7vlowSHWbG2D8+eyIu3FOX1FxsiHaLzRwHn4rVD0GATxOmjar hfPwg8lm4Cpc1lWwgvk6hTq4pxgRTMVUdhk+S6yvtkltxvpCrFeoUqQE812r0y46EhPf3y CBZbUDAHC4NI/pHAEiOmWn2ByOTBlcEn0wxRa96j42T6AFJ6b+f/U0j3VnUsFYPr9APe4d +3OVhUMnNq9n4EvPdhl9vzCnRd2d2tVnHL78Fpqhgo3fS5a59lOljzLJwo8/U+5B3Mu5cK 3ZR89gBvZxe1KHnX8u+NxMP7TaV0QrWjVUly7f20H4vBfwtJXF0Rl86SBhuPmQ== From: conses To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143. Date: Thu, 26 Jan 2023 20:07:25 +0100 Message-ID: <86h6wd6ro2.fsf@conses.eu> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.178.230; envelope-from=contact@conses.eu; helo=relay10.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to 34a61143. --- gnu/packages/emacs-xyz.scm | 35 ++++++++++++----------------------- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index dc378581f5..7b5888a1d1 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -21447,34 +21447,23 @@ (define-public emacs-md4rd (license license:gpl3+))) (define-public emacs-pulseaudio-control - (let ((commit "a931533140547510decdc368f39b2d2b97ca725f") - (revision "4")) + (let ((commit "34a6114357dbbc6b6720aa013e0f8a48f3739403") + (revision "5")) (package (name "emacs-pulseaudio-control") (version (git-version "0.0.1" revision commit)) - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/flexibeast/pulseaudio-control") - (commit commit))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76")))) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://git.sr.ht/~flexibeast/pulseaudio-control") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5")))) (build-system emacs-build-system) - (arguments - '(#:phases (modify-phases %standard-phases - (add-after 'unpack 'patch-file-name - (lambda* (#:key inputs #:allow-other-keys) - (let ((pulseaudio (assoc-ref inputs "pulseaudio"))) - (chmod "pulseaudio-control.el" #o600) - (emacs-substitute-variables "pulseaudio-control.el" - ("pulseaudio-control-pactl-path" - (string-append pulseaudio "/bin/pactl"))) - #t)))))) (inputs (list pulseaudio)) - (home-page "https://github.com/flexibeast/pulseaudio-control") + (home-page "https://git.sr.ht/~flexibeast/pulseaudio-control") (synopsis "Control @code{pulseaudio} from Emacs") (description "This package allows controlling @code{pulseaudio} from Emacs.") -- 2.38.1 -- Best regards, conses From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 03:52:36 2023 Received: (at 61082) by debbugs.gnu.org; 27 Jan 2023 08:52:36 +0000 Received: from localhost ([127.0.0.1]:36718 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLKTL-0007Y7-Sg for submit@debbugs.gnu.org; Fri, 27 Jan 2023 03:52:36 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:36681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLKTK-0007Xt-1Z for 61082@debbugs.gnu.org; Fri, 27 Jan 2023 03:52:34 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 4025AFF808; Fri, 27 Jan 2023 08:52:26 +0000 (UTC) From: Nicolas Goaziou To: conses Subject: Re: [bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143. References: <86h6wd6ro2.fsf@conses.eu> Date: Fri, 27 Jan 2023 09:52:20 +0100 In-Reply-To: <86h6wd6ro2.fsf@conses.eu> (conses's message of "Thu, 26 Jan 2023 20:07:25 +0100") Message-ID: <87lelol5q3.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61082 Cc: 61082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, conses writes: > * gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to > 34a61143. Thank you. The commit message is incomplete: you modified pointer to upstream, you need to write it here. > --- > gnu/packages/emacs-xyz.scm | 35 ++++++++++++----------------------- > 1 file changed, 12 insertions(+), 23 deletions(-) > > diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm > index dc378581f5..7b5888a1d1 100644 > --- a/gnu/packages/emacs-xyz.scm > +++ b/gnu/packages/emacs-xyz.scm > @@ -21447,34 +21447,23 @@ (define-public emacs-md4rd > (license license:gpl3+))) > > (define-public emacs-pulseaudio-control > - (let ((commit "a931533140547510decdc368f39b2d2b97ca725f") > - (revision "4")) > + (let ((commit "34a6114357dbbc6b6720aa013e0f8a48f3739403") > + (revision "5")) > (package > (name "emacs-pulseaudio-control") > (version (git-version "0.0.1" revision commit)) Base version seems to be "0.1", according to puleseaudio-control.el. In this case, you can restart revision to "1" (or "0"). > - (source > - (origin > - (method git-fetch) > - (uri (git-reference > - (url "https://github.com/flexibeast/pulseaudio-control") > - (commit commit))) > - (file-name (git-file-name name version)) > - (sha256 > - (base32 > - "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76")))) > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://git.sr.ht/~flexibeast/pulseaudio-control") > + (commit commit))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5")))) > (build-system emacs-build-system) > - (arguments > - '(#:phases (modify-phases %standard-phases > - (add-after 'unpack 'patch-file-name > - (lambda* (#:key inputs #:allow-other-keys) > - (let ((pulseaudio (assoc-ref inputs "pulseaudio"))) > - (chmod "pulseaudio-control.el" #o600) > - (emacs-substitute-variables "pulseaudio-control.el" > - ("pulseaudio-control-pactl-path" > - (string-append pulseaudio "/bin/pactl"))) > - #t)))))) Why did you remove this phase? AFAICT, pulseaudio-control-pactl-path still exists. > (inputs (list pulseaudio)) > - (home-page "https://github.com/flexibeast/pulseaudio-control") > + (home-page "https://git.sr.ht/~flexibeast/pulseaudio-control") This also need to be specified in the commit message. Could you send an updated patch? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 07:51:27 2023 Received: (at 61082) by debbugs.gnu.org; 28 Jan 2023 12:51:27 +0000 Received: from localhost ([127.0.0.1]:39822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkg3-00042A-5H for submit@debbugs.gnu.org; Sat, 28 Jan 2023 07:51:27 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:41469) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkg1-00041s-3w for 61082@debbugs.gnu.org; Sat, 28 Jan 2023 07:51:26 -0500 Received: (Authenticated sender: contact@conses.eu) by mail.gandi.net (Postfix) with ESMTPSA id 4789C1C0002 for <61082@debbugs.gnu.org>; Sat, 28 Jan 2023 12:51:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conses.eu; s=gm1; t=1674910278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=KScLW7ivPj+hG74+wH5VncHIAPAB+6R6ugFlY6UZOXY=; b=bQ1igPjKjiDjAKQ4W8DlUplj2+U0kXsZI9pHq7J0mxEnYp9OpqbDAuBw4gVaBaniZnHB5F mRHuUGF5rQumKVAxROgbWCG5rF7wSt5adEr7iEPUuC9zduaYKvmFyh5ZgYd/THVz6rwKam VLsLbOfbkhmyC6MhQsC6D5HB3US8T5XZLM4aG90QYgQ0klAT0xhSasBHd7RBD3nacV3KA/ F0CbCLCDifaS8WXt+FPQGyTx5OtkwRfxcRXoFH8Wws2HztjRRHYjGn0oqPmWZI2Qr97y+e AwvD+KDmFuu9eDImSU3xBjZGVCZu/Y2V/dOV2y9w11krkrh68Cgx6NGWpuVPVg== From: conses To: 61082@debbugs.gnu.org Subject: [PATCH v2] gnu: emacs-pulseaudio-control: Update to 34a61143. Date: Sat, 28 Jan 2023 13:51:14 +0100 Message-ID: <86o7qi6cvx.fsf@conses.eu> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61082 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to 34a61143. [home-page]: Change upstream URL to new sourcehut repository. --- gnu/packages/emacs-xyz.scm | 37 +++++++++++++------------------------ 1 file changed, 13 insertions(+), 24 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index dc378581f5..f4898e04e4 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -21447,34 +21447,23 @@ (define-public emacs-md4rd (license license:gpl3+))) (define-public emacs-pulseaudio-control - (let ((commit "a931533140547510decdc368f39b2d2b97ca725f") - (revision "4")) + (let ((commit "34a6114357dbbc6b6720aa013e0f8a48f3739403") + (revision "0")) (package (name "emacs-pulseaudio-control") - (version (git-version "0.0.1" revision commit)) - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/flexibeast/pulseaudio-control") - (commit commit))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76")))) + (version (git-version "0.1" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://git.sr.ht/~flexibeast/pulseaudio-control") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5")))) (build-system emacs-build-system) - (arguments - '(#:phases (modify-phases %standard-phases - (add-after 'unpack 'patch-file-name - (lambda* (#:key inputs #:allow-other-keys) - (let ((pulseaudio (assoc-ref inputs "pulseaudio"))) - (chmod "pulseaudio-control.el" #o600) - (emacs-substitute-variables "pulseaudio-control.el" - ("pulseaudio-control-pactl-path" - (string-append pulseaudio "/bin/pactl"))) - #t)))))) (inputs (list pulseaudio)) - (home-page "https://github.com/flexibeast/pulseaudio-control") + (home-page "https://git.sr.ht/~flexibeast/pulseaudio-control") (synopsis "Control @code{pulseaudio} from Emacs") (description "This package allows controlling @code{pulseaudio} from Emacs.") -- 2.38.1 -- Best regards, conses From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 07:59:58 2023 Received: (at 61082) by debbugs.gnu.org; 28 Jan 2023 12:59:58 +0000 Received: from localhost ([127.0.0.1]:39846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkoH-0004FG-O8 for submit@debbugs.gnu.org; Sat, 28 Jan 2023 07:59:58 -0500 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:49561) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLkoF-0004F3-R8 for 61082@debbugs.gnu.org; Sat, 28 Jan 2023 07:59:56 -0500 Received: (Authenticated sender: contact@conses.eu) by mail.gandi.net (Postfix) with ESMTPSA id 9AD361C000D; Sat, 28 Jan 2023 12:59:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conses.eu; s=gm1; t=1674910790; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CMRHgerPoZ4TeaqXa7k+IdguWrc98qzsbQCZCPGY2/w=; b=GMaw7HRu3NDDfDc/WkuC1Uw81gkeZzgl33W4W/C1rNOkSHp5ew656AQpEyt0j5BvKK9+zD L/njC6FbEF5O9/pEjsoxJiIIP10Rmtp1w04DFuiiE5vcmIdxit6viBkI+Xa8AGWVu+gKbl 9JrFdqS3hrFJTBOGBqNNwAOt/h+wxpsOhvtEwqMjQwUeZCJGLwXxP49ZyK5mPhrE6elhTr fc4iN8+1gy3WRuRbevg44w54bCPxJmowMUxHZ5y4mCyegvpn+XYJFErUyPg/bRZiJVLwXy KPJSAsimPyMklAcTBUfBuyh5whYqpuv5A/UvEmDqxgaOb2ZLaaHPUtqC6PYEuw== From: conses To: Nicolas Goaziou Subject: Re: bug#61082: [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143. In-Reply-To: <87lelol5q3.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Fri, 27 Jan 2023 09:52:20 +0100") References: <86h6wd6ro2.fsf@conses.eu> <87lelol5q3.fsf@nicolasgoaziou.fr> Date: Sat, 28 Jan 2023 13:59:48 +0100 Message-ID: <86h6wa6chn.fsf_-_@conses.eu> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61082 Cc: 61082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Nicolas Goaziou writes: > Hello, Hi Nicolas, >> - (source >> - (origin >> - (method git-fetch) >> - (uri (git-reference >> - (url "https://github.com/flexibeast/pulseaudio-control") >> - (commit commit))) >> - (file-name (git-file-name name version)) >> - (sha256 >> - (base32 >> - "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76")))) >> + (source (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://git.sr.ht/~flexibeast/pulseaudio-control") >> + (commit commit))) >> + (file-name (git-file-name name version)) >> + (sha256 >> + (base32 >> + "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5")))) >> (build-system emacs-build-system) >> - (arguments >> - '(#:phases (modify-phases %standard-phases >> - (add-after 'unpack 'patch-file-name >> - (lambda* (#:key inputs #:allow-other-keys) >> - (let ((pulseaudio (assoc-ref inputs "pulseaudio"))) >> - (chmod "pulseaudio-control.el" #o600) >> - (emacs-substitute-variables "pulseaudio-control.el" >> - ("pulseaudio-control-pactl-path" >> - (string-append pulseaudio "/bin/pactl"))) >> - #t)))))) > > Why did you remove this phase? AFAICT, pulseaudio-control-pactl-path > still exists. > > Because this might have been needed when the package didn't allow the pactl executable path to be found dynamically, but as per https://github.com/flexibeast/pulseaudio-control/commit/c8640fceb530ab7a1aa551d70f7ee222147d95cf this is no longer needed. -- Best regards, conses From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 11:30:28 2023 Received: (at 61082) by debbugs.gnu.org; 28 Jan 2023 16:30:28 +0000 Received: from localhost ([127.0.0.1]:41424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLo5z-00043X-Vu for submit@debbugs.gnu.org; Sat, 28 Jan 2023 11:30:28 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:36395) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLo5x-00043G-HE for 61082@debbugs.gnu.org; Sat, 28 Jan 2023 11:30:26 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 8B35BFF802; Sat, 28 Jan 2023 16:30:18 +0000 (UTC) From: Nicolas Goaziou To: conses Subject: Re: [bug#61082] [PATCH] gnu: emacs-pulseaudio-control: Update to 34a61143. References: <86h6wd6ro2.fsf@conses.eu> <87lelol5q3.fsf@nicolasgoaziou.fr> <86h6wa6chn.fsf_-_@conses.eu> Date: Sat, 28 Jan 2023 17:30:06 +0100 In-Reply-To: <86h6wa6chn.fsf_-_@conses.eu> (conses's message of "Sat, 28 Jan 2023 13:59:48 +0100") Message-ID: <874jsak4fl.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61082 Cc: 61082@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, conses writes: > Because this might have been needed when the package didn't allow > the pactl executable path to be found dynamically, but as per > https://github.com/flexibeast/pulseaudio-control/commit/c8640fceb530ab7a1aa551d70f7ee222147d95cf > this is no longer needed. I don't think (or (executable-find "pactl") "/usr/bin/pactl") is equivalent to (search-input-file inputs "/bin/pactl") Some Emacs packages remove those `executable-find' calls, e.g., emacs-nov-el, emacs-emacsql-sqlite3, emacs-telega, etc. It does make sense to keep this phase (but you can remove the initial chmod call and the final #T), unless I'm missing something. We want the Emacs package to always refer to its own Pulseaudio input, don't we? Regards, -- Nicolas Goaziou From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 28 14:06:10 2023 Received: (at 61082) by debbugs.gnu.org; 28 Jan 2023 19:06:10 +0000 Received: from localhost ([127.0.0.1]:41580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLqWg-0002Ca-FK for submit@debbugs.gnu.org; Sat, 28 Jan 2023 14:06:10 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:35755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLqWd-0002Bl-Jf for 61082@debbugs.gnu.org; Sat, 28 Jan 2023 14:06:09 -0500 Received: (Authenticated sender: contact@conses.eu) by mail.gandi.net (Postfix) with ESMTPSA id 1E0B7FF802 for <61082@debbugs.gnu.org>; Sat, 28 Jan 2023 19:06:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=conses.eu; s=gm1; t=1674932761; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=w4bLuatwxrT7NeuLQKApXqHTxiBlAd5yuOKPrM3c+WI=; b=Cc6waDbZytDZB1vYC3gTq50TxZCg1VrxN/Gw42JDAMYPW/HCFolBisnJjikL4Te/iRPllq DJrx0BZKmWZnaXnOhfZk8hPTLaIwepsepXOvxuyGt/eiNcG05SYSkR4adBg8VWBK1cDr+N xlQHIKz+eq3G//+PX7TvWYsGqG+Flm79awoaEfu5W9TgE077NLRdLG/J9EYvcOC39okEJr 9E65DuNite0T+wpS1Dri+i2bgcp7ufaba++EiGhpHKDxhjPihkpWKtICfdVtP1aNMO6h33 HAN776d0Z5az8z5qGn2vcpJxax0k6zTNpO8KRVtoUE5fpxMgOWfGBwc1wEjzGg== From: conses To: 61082@debbugs.gnu.org Subject: [PATCH v3] gnu: emacs-pulseaudio-control: Update to 34a61143. Date: Sat, 28 Jan 2023 20:05:59 +0100 Message-ID: <86wn5632eg.fsf@conses.eu> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61082 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) * gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to 34a61143. [home-page]: Change upstream URL to new sourcehut repository. [arguments]: Clean up patch-file-name phase. --- gnu/packages/emacs-xyz.scm | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index dc378581f5..bfad151e18 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -21447,34 +21447,31 @@ (define-public emacs-md4rd (license license:gpl3+))) (define-public emacs-pulseaudio-control - (let ((commit "a931533140547510decdc368f39b2d2b97ca725f") - (revision "4")) + (let ((commit "34a6114357dbbc6b6720aa013e0f8a48f3739403") + (revision "0")) (package (name "emacs-pulseaudio-control") - (version (git-version "0.0.1" revision commit)) - (source - (origin - (method git-fetch) - (uri (git-reference - (url "https://github.com/flexibeast/pulseaudio-control") - (commit commit))) - (file-name (git-file-name name version)) - (sha256 - (base32 - "1jvjn9jszjjapi167an49jxcvr88cvgjwykglhp4b8lwhbjfqw76")))) + (version (git-version "0.1" revision commit)) + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://git.sr.ht/~flexibeast/pulseaudio-control") + (commit commit))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "0wm312pqp0i5i6qh6g3nacnnvsrad58927cl2g42gxzrzlb3slv5")))) (build-system emacs-build-system) (arguments '(#:phases (modify-phases %standard-phases (add-after 'unpack 'patch-file-name (lambda* (#:key inputs #:allow-other-keys) (let ((pulseaudio (assoc-ref inputs "pulseaudio"))) - (chmod "pulseaudio-control.el" #o600) (emacs-substitute-variables "pulseaudio-control.el" ("pulseaudio-control-pactl-path" - (string-append pulseaudio "/bin/pactl"))) - #t)))))) + (string-append pulseaudio "/bin/pactl"))))))))) (inputs (list pulseaudio)) - (home-page "https://github.com/flexibeast/pulseaudio-control") + (home-page "https://git.sr.ht/~flexibeast/pulseaudio-control") (synopsis "Control @code{pulseaudio} from Emacs") (description "This package allows controlling @code{pulseaudio} from Emacs.") -- 2.38.1 -- Best regards, conses From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 29 09:45:42 2023 Received: (at 61082-done) by debbugs.gnu.org; 29 Jan 2023 14:45:42 +0000 Received: from localhost ([127.0.0.1]:42527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM8wA-00063u-Dk for submit@debbugs.gnu.org; Sun, 29 Jan 2023 09:45:42 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:51431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM8w8-00063f-8l for 61082-done@debbugs.gnu.org; Sun, 29 Jan 2023 09:45:40 -0500 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id A3B1E40005; Sun, 29 Jan 2023 14:45:33 +0000 (UTC) From: Nicolas Goaziou To: conses Subject: Re: [bug#61082] [PATCH v3] gnu: emacs-pulseaudio-control: Update to 34a61143. References: <86h6wd6ro2.fsf@conses.eu> <86wn5632eg.fsf@conses.eu> Date: Sun, 29 Jan 2023 15:45:26 +0100 In-Reply-To: <86wn5632eg.fsf@conses.eu> (conses's message of "Sat, 28 Jan 2023 20:05:59 +0100") Message-ID: <87r0vdiem1.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 61082-done Cc: 61082-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, conses writes: > * gnu/packages/emacs-xyz.scm (emacs-pulseaudio-control): Update to 34a61143. > [home-page]: Change upstream URL to new sourcehut repository. > [arguments]: Clean up patch-file-name phase. Neat. Thank you. I added a reference to source update in the commit message and applied your patch. Regards, -- Nicolas Goaziou From unknown Sat Aug 16 21:59:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 27 Feb 2023 12:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator