GNU bug report logs - #61074
[PATCH] gnu: Add emacs-poke.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 61074 in the body.
You can then email your comments to 61074 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH] gnu: Add emacs-poke.
Date: Thu, 26 Jan 2023 11:28:59 +0200

* gnu/packages/engineering.scm (emacs-poke): New variable.
(poke)[arguments]: Add configure-flag to install emacs files to
temporary directory.
---
 gnu/packages/engineering.scm | 22 +++++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/engineering.scm b/gnu/packages/engineering.scm
index ff997a140d..15dc70d5ad 100644
--- a/gnu/packages/engineering.scm
+++ b/gnu/packages/engineering.scm
@@ -2903,7 +2903,9 @@ (define-public poke
      ;; To enable the "hyperlink server", add the `--enable-hserver' flag.
      `(#:configure-flags
        '("--enable-mi"
-         "--disable-static")))
+         "--disable-static"
+         ;; The emacs files are provided in emacs-poke.
+         "--with-lispdir=/tmp/share/emacs")))
     (home-page "https://www.gnu.org/software/poke/#documentation")
     (synopsis "Editing of arbitrary binary data")
     (description "GNU poke is an interactive, extensible editor for binary data.
@@ -2912,6 +2914,24 @@ (define-public poke
 data structures and to operate on them.")
     (license license:gpl3+)))
 
+(define-public emacs-poke
+  (package
+    (inherit poke)
+    (name "emacs-poke")
+    (build-system emacs-build-system)
+    (arguments
+     (list
+       #:phases
+       #~(modify-phases %standard-phases
+           (add-before 'expand-load-path 'change-working-directory
+             (lambda _ (chdir "etc"))))))
+    (inputs '())
+    (native-inputs '())
+    (synopsis "GNU Poke major modes for Emacs")
+    (description
+     "This package provides two Emacs major modes for working with GNU Poke:
+@code{poke-ras-mode.el} and @code{poke-map-mode.el}.")))
+
 (define-public pcb2gcode
   ;; Take some additional commits after v2.4.0 to fix build against
   ;; geos 3.10.1.

base-commit: a84ceaa8b2e8e121957afea1d1d3fe7c8141cb8d
prerequisite-patch-id: c10af8ba74fbbf48837769e71262382ada47dc71
prerequisite-patch-id: e001083279dec68d9710fb42bedfd710ab0ae707
-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

Message #8 received at 61074 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 61074 <at> debbugs.gnu.org
Subject: Re: [bug#61074] [PATCH] gnu: Add emacs-poke.
Date: Fri, 27 Jan 2023 09:59:09 +0100

Hello,

Efraim Flashner <efraim <at> flashner.co.il> writes:

> * gnu/packages/engineering.scm (emacs-poke): New variable.
> (poke)[arguments]: Add configure-flag to install emacs files to
> temporary directory.

Thank you. I only have one nit.

> +    (description
> +     "This package provides two Emacs major modes for working with GNU Poke:
> +@code{poke-ras-mode.el} and @code{poke-map-mode.el}.")))

Here it is.

"poke-ras-mode.el" and "poke-map-mode.el" are not major modes, but
files. I suggest to obey to Emacs typography and use, respectively,
"Poke Ras mode" and "Poke Map mode".

I didn't try to build the package, but I assume you did already, and
qa.guix.gnu.org is not helpful at the moment.

Regards,
-- 
Nicolas Goaziou

Message #13 received at 61074-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 61074-done <at> debbugs.gnu.org
Subject: Re: [bug#61074] [PATCH] gnu: Add emacs-poke.
Date: Mon, 30 Jan 2023 10:41:46 +0200

[Message part 1 (text/plain, inline)]

Thanks. Patch pushed!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.