Subject: Re: [bug#61065] [PATCH v2] gnu: Add emacs-ein.

From: Nicolas Goaziou <[email-masked]>
Date: Fri, 27 Jan 2023 23:08:48 +0100

Hello,

Cayetano Santos via Guix-patches via <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-ein): New variable.

Thank you. I applied your patch with the following changes.

> +(define-public emacs-ein
> +  (package
> +    (name "emacs-ein")
> +    (version "20220911")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri
> +        (git-reference
> +         (url "https://github.com/millejoh/emacs-ipython-notebook")
> +         (commit "b2410dc96f61aa806a7934099d8f1e40c8f6ca18")))

I added

  (file-name (git-file-name name version))

> +       (sha256
> +        (base32
> +         "02392bxl0msda58cls0i79mzqjs73x39czx0mlb0sg2vxp84gy15"))))
> +    (build-system emacs-build-system)
> +    (arguments
> +     (list
> +      #:tests? #t
> +      #:test-command
> +      #~(list "emacs" "-Q" "--batch"
> +              "-L" "test"
> +              "--load" "test/testein-loader.el")
> +      #:phases
> +           #~(modify-phases %standard-phases
> +               (add-after 'unpack 'move-source-files
> +                 (lambda _
> +                   (let ((el-files (find-files "./lisp" ".*\\.el$")))
> +                     (for-each (lambda (f)
> +                                 (rename-file f (basename f)))
> +                               el-files)))))))
> +    (native-inputs
> +     (list emacs-f emacs-mocker))
> +    (propagated-inputs (list emacs-anaphora
> +                             emacs-dash
> +                             emacs-deferred
> +                             emacs-polymode
> +                             emacs-request
> +                             emacs-websocket
> +                             emacs-with-editor))

I added a newline character after "propagated-inputs".

> +    (home-page "https://github.com/millejoh/emacs-ipython-notebook")
> +    (synopsis "Jupyter client for all languages")
> +    (description
> +     "The Emacs IPython Notebook (EIN) package provides a Jupyter Notebook
> +client and integrated REPL (like SLIME) in Emacs.  EIN improves notebook
> +editing by allowing you to use Emacs.  It also expose IPython features such as
> +code evaluation, object inspection and code completion. These features can be

I added a missing space before "These features".

Regards,
-- 
Nicolas Goaziou