From unknown Thu Aug 14 18:32:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6106 <6106@debbugs.gnu.org> To: bug#6106 <6106@debbugs.gnu.org> Subject: Status: 24.0.50; info.el adds 'search-failed to debug-ignored-errors Reply-To: bug#6106 <6106@debbugs.gnu.org> Date: Fri, 15 Aug 2025 01:32:16 +0000 retitle 6106 24.0.50; info.el adds 'search-failed to debug-ignored-errors reassign 6106 emacs submitter 6106 Helmut Eller severity 6106 normal tag 6106 fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 05:56:22 2010 Received: (at submit) by debbugs.gnu.org; 5 May 2010 09:56:22 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9bL3-000109-Sp for submit@debbugs.gnu.org; Wed, 05 May 2010 05:56:22 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9bL1-000100-UB for submit@debbugs.gnu.org; Wed, 05 May 2010 05:56:20 -0400 Received: from lists.gnu.org ([199.232.76.165]:36556) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O9bKz-0000Jq-Au for submit@debbugs.gnu.org; Wed, 05 May 2010 05:56:17 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9bKy-0007E0-GL for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 05:56:16 -0400 Received: from [140.186.70.92] (port=57812 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9bKx-0007Cv-13 for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 05:56:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, FSL_HELO_NON_FQDN_1, HELO_NO_DOMAIN, RCVD_IN_BRBL_LASTEXT, RCVD_IN_RP_RNBL, T_TO_NO_BRKTS_FREEMAIL autolearn=no version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9bKw-0001xv-0x for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 05:56:14 -0400 Received: from dial-178183.pool.broadband44.net ([212.46.178.183]:39251 helo=ix) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9bKv-0001xC-AR for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 05:56:13 -0400 Received: from helmut by ix with local (Exim 4.69) (envelope-from ) id 1O9bKs-00013k-To for bug-gnu-emacs@gnu.org; Wed, 05 May 2010 11:56:10 +0200 From: Helmut Eller To: bug-gnu-emacs@gnu.org Subject: 24.0.50; info.el adds 'search-failed to debug-ignored-errors Date: Wed, 05 May 2010 11:56:10 +0200 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.8 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.8 (-----) Around line 4833 in info.el 'search-failed is added to debug-ignored-errors. That seems counterproductive to me. I would not expect at all that viewing an info file would change the way the debugger works. It would be less annoying if info mode would only modify the buffer-local binding of debug-ignored-errors. From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 14:23:21 2010 Received: (at 6106) by debbugs.gnu.org; 5 May 2010 18:23:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9jFh-00074p-2Y for submit@debbugs.gnu.org; Wed, 05 May 2010 14:23:21 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3] helo=mx1.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9jFe-00074k-JT for 6106@debbugs.gnu.org; Wed, 05 May 2010 14:23:19 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.29.84.cable.starman.ee [82.131.29.84]) by mx1.starman.ee (Postfix) with ESMTP id 2C4403F4127; Wed, 5 May 2010 21:23:07 +0300 (EEST) From: Juri Linkov To: Helmut Eller Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors Organization: JURTA References: Date: Wed, 05 May 2010 21:18:05 +0300 In-Reply-To: (Helmut Eller's message of "Wed, 05 May 2010 11:56:10 +0200") Message-ID: <87vdb2mcoi.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 6106 Cc: 6106@debbugs.gnu.org, lennart.borgman@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) > Around line 4833 in info.el 'search-failed is added to debug-ignored-errors. > > That seems counterproductive to me. I would not expect at all that > viewing an info file would change the way the debugger works. It would > be less annoying if info mode would only modify the buffer-local binding > of debug-ignored-errors. We are waiting when Lennart will post a newer version of the patch that introduces new functions `user-error' and `user-signal'. They will obsolete `debug-ignored-errors'. And info.el will call (user-signal 'search-failed ...) -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 01:57:11 2010 Received: (at 6106) by debbugs.gnu.org; 6 May 2010 05:57:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9u59-0006JL-I0 for submit@debbugs.gnu.org; Thu, 06 May 2010 01:57:11 -0400 Received: from dial-178183.pool.broadband44.net ([212.46.178.183] helo=ix) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9u58-0006JE-LY for 6106@debbugs.gnu.org; Thu, 06 May 2010 01:57:11 -0400 Received: from helmut by ix with local (Exim 4.69) (envelope-from ) id 1O9u53-0000t0-0y; Thu, 06 May 2010 07:57:05 +0200 From: Helmut Eller To: Juri Linkov Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors References: <87vdb2mcoi.fsf@mail.jurta.org> Date: Thu, 06 May 2010 07:57:04 +0200 In-Reply-To: <87vdb2mcoi.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 05 May 2010 21:18:05 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: 6106 Cc: 6106@debbugs.gnu.org, lennart.borgman@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.7 (---) * Juri Linkov [2010-05-05 20:18+0200] writes: >> Around line 4833 in info.el 'search-failed is added to debug-ignored-errors. >> >> That seems counterproductive to me. I would not expect at all that >> viewing an info file would change the way the debugger works. It would >> be less annoying if info mode would only modify the buffer-local binding >> of debug-ignored-errors. > > We are waiting when Lennart will post a newer version of the patch that > introduces new functions `user-error' and `user-signal'. They will > obsolete `debug-ignored-errors'. And info.el will call > (user-signal 'search-failed ...) OK. That sounds good. Helmut From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 09:08:04 2010 Received: (at 6106) by debbugs.gnu.org; 6 May 2010 13:08:04 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OA0o8-0002MV-0t for submit@debbugs.gnu.org; Thu, 06 May 2010 09:08:04 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OA0o5-0002M8-O2 for 6106@debbugs.gnu.org; Thu, 06 May 2010 09:08:02 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAA9c4kvO+IB1/2dsb2JhbACdZ3K9HoUTBIww X-IronPort-AV: E=Sophos;i="4.52,341,1270440000"; d="scan'208";a="63567355" Received: from 206-248-128-117.dsl.teksavvy.com (HELO alfajor.home) ([206.248.128.117]) by ironport2-out.pppoe.ca with ESMTP; 06 May 2010 09:07:56 -0400 Received: by alfajor.home (Postfix, from userid 20848) id 43E9EAF455; Thu, 6 May 2010 09:07:51 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors Message-ID: References: <87vdb2mcoi.fsf@mail.jurta.org> Date: Thu, 06 May 2010 09:07:51 -0400 In-Reply-To: <87vdb2mcoi.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 05 May 2010 21:18:05 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 6106 Cc: 6106@debbugs.gnu.org, Helmut Eller X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > We are waiting when Lennart will post a newer version of the patch that > introduces new functions `user-error' and `user-signal'. They will > obsolete `debug-ignored-errors'. And info.el will call > (user-signal 'search-failed ...) Hmm... that would mean that his patch goes quite a bit further than what I expected (I think he only provides `user-error' and not `user-signal'). Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 16:54:47 2010 Received: (at 6106) by debbugs.gnu.org; 6 May 2010 20:54:47 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OA85m-00075v-QO for submit@debbugs.gnu.org; Thu, 06 May 2010 16:54:47 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3] helo=mx1.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OA85k-00075k-3z for 6106@debbugs.gnu.org; Thu, 06 May 2010 16:54:44 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.33.106.cable.starman.ee [82.131.33.106]) by mx1.starman.ee (Postfix) with ESMTP id A0AFF3F41CD; Thu, 6 May 2010 23:54:36 +0300 (EEST) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors Organization: JURTA References: <87vdb2mcoi.fsf@mail.jurta.org> X-Debbugs-CC: lennart.borgman@gmail.com Date: Thu, 06 May 2010 23:49:41 +0300 In-Reply-To: (Stefan Monnier's message of "Thu, 06 May 2010 09:07:51 -0400") Message-ID: <87sk6516ay.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 6106 Cc: Helmut Eller , 6106@debbugs.gnu.org, lennart.borgman@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) [Cc:ed Lennart] Lennart, could you please tell at what stage your patch currently is and how it handles user-level signals? >> We are waiting when Lennart will post a newer version of the patch that >> introduces new functions `user-error' and `user-signal'. They will >> obsolete `debug-ignored-errors'. And info.el will call >> (user-signal 'search-failed ...) > > Hmm... that would mean that his patch goes quite a bit further than what > I expected (I think he only provides `user-error' and not > `user-signal'). -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 29 02:42:55 2012 Received: (at 6106) by debbugs.gnu.org; 29 Jul 2012 06:42:55 +0000 Received: from localhost ([127.0.0.1]:47549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SvNDK-0000wh-LU for submit@debbugs.gnu.org; Sun, 29 Jul 2012 02:42:54 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:54700 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SvNDG-0000wR-R6 for 6106@debbugs.gnu.org; Sun, 29 Jul 2012 02:42:52 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 8DC03451CB9A; Sat, 28 Jul 2012 23:35:43 -0700 (PDT) From: Juri Linkov To: Helmut Eller Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors Organization: JURTA References: Date: Sun, 29 Jul 2012 09:32:22 +0300 In-Reply-To: (Helmut Eller's message of "Wed, 05 May 2010 11:56:10 +0200") Message-ID: <87fw8bt721.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 6106 Cc: 6106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Around line 4833 in info.el 'search-failed is added to debug-ignored-errors. > > That seems counterproductive to me. I would not expect at all that > viewing an info file would change the way the debugger works. It would > be less annoying if info mode would only modify the buffer-local binding > of debug-ignored-errors. `search-failed' is added to `debug-ignored-errors' in info.el to not enter the debugger when a normal search stops with no results. But this error is raised by `xsignal1 (Qsearch_failed, string)' in `re-search-forward' (called from `Info-search'), so I see no way to replace it with a call to the new function `user-error' (or the same function with any other name). From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 23:57:14 2017 Received: (at 6106) by debbugs.gnu.org; 24 Mar 2017 03:57:14 +0000 Received: from localhost ([127.0.0.1]:41620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crGLi-0006U3-4P for submit@debbugs.gnu.org; Thu, 23 Mar 2017 23:57:14 -0400 Received: from mail-it0-f54.google.com ([209.85.214.54]:36593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crGLf-0006Ti-Co; Thu, 23 Mar 2017 23:57:11 -0400 Received: by mail-it0-f54.google.com with SMTP id w124so3183393itb.1; Thu, 23 Mar 2017 20:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=7WI5zXZnp9Ggmq0CAxxIbiM4ZF9N/x/eibPFshN6yBg=; b=m27XEanehEBlwwmE5XJnVAkb2wItzNXCPXTVsGG4d/+G+fdovtXny+BC3FTOAT0g29 E/VnrqNHl1qnQh86no46T4HHcO95RtHXdaxlez7zlSowL+mMriFBAabegzCI05Qpbzcw D7MrofiTTK5LnEaOZcwMpV332Pg8BI2ywzfEMvpYUpAxo6aDdn6+bFJM+Dui3wkdf4q+ rKEzYPIgsJrFLAkRs08OaDH4uEUgw/N74KzYv5DNGIfCUW8gcz8umhVoyR5Ag534cDTz HumBu+5qhgoSbzqovAmbtVs/skQD5Cvq7dRXC7sSPb4Cl9P8ER5bfR7tk/Rxe3f1/DDN qJ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=7WI5zXZnp9Ggmq0CAxxIbiM4ZF9N/x/eibPFshN6yBg=; b=YsWIi4ssl986o1VB8P4jvBaobQj10W6j44yov73FV50IuxAo2kvbG/bbSMM1Z5ZrfD uEhyTu5B5wdl99hQifRq5EFEDaX821L5LaVAc4xurm77ha7vXy7+dmPcsKNgvE+E2ZXk 3voJB7+6YpyPP2iS1utBaWCRXwUppZE/EVJ2hJTnQNkEqO57sJcE9q//7rg5Mjo0W3Kp nwlPqcDD2YLOyMdSar7CgOszv/zI7EQmvq4fvFW9N9lsFdbvPUbWrsBI7F5lUMxcSEIS DkUdxjYJkox8m72ihgxjnkVLcng37SQzWestjKSxILEdxmANJvm89WQarB6B1qDQqqmy CXew== X-Gm-Message-State: AFeK/H3JQIdTpgnQDAbGHQ/T7PGT0rtl+lbPNXSuKrBUOjpANrLFliLDEGQyo4uKTKOq6A== X-Received: by 10.36.43.194 with SMTP id h185mr1140758ita.121.1490327825784; Thu, 23 Mar 2017 20:57:05 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id p191sm435065itc.4.2017.03.23.20.57.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Mar 2017 20:57:05 -0700 (PDT) From: npostavs@users.sourceforge.net To: Juri Linkov Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors References: <87fw8bt721.fsf@mail.jurta.org> Date: Thu, 23 Mar 2017 23:58:28 -0400 In-Reply-To: <87fw8bt721.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 29 Jul 2012 09:32:22 +0300") Message-ID: <87vaqz2umz.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 6106 Cc: 6106@debbugs.gnu.org, Helmut Eller X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --=-=-= Content-Type: text/plain tags 6106 patch quit Juri Linkov writes: > `search-failed' is added to `debug-ignored-errors' in info.el > to not enter the debugger when a normal search stops with no results. > > But this error is raised by `xsignal1 (Qsearch_failed, string)' > in `re-search-forward' (called from `Info-search'), > so I see no way to replace it with a call to the new function > `user-error' (or the same function with any other name). Use the NOERROR parameter? --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Don-t-add-search-failed-to-ignored-errors-in-info.patch Content-Description: patch >From f0b7b943368e9856dda49c3bdb862c1940266189 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Thu, 23 Mar 2017 23:54:58 -0400 Subject: [PATCH v1] Don't add `search-failed' to ignored errors in info.el (Bug#6106) * lisp/info.el: Stop adding `search-failed' to `debug-ignored-errors'. (Info-select-node, Info-search): Replace (signal 'search-failed ...) with (user-error "Search failed: "...). --- lisp/info.el | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/lisp/info.el b/lisp/info.el index 8dc85f48a4..a06c868fb3 100644 --- a/lisp/info.el +++ b/lisp/info.el @@ -1672,7 +1672,7 @@ Info-select-node (forward-line 2) (if (looking-at "\^_") (forward-line 1) - (signal 'search-failed (list "\n\^_")))) + (user-error "Search failed: `\n\^_'"))) ;; Get nodename spelled as it is in the node. (re-search-forward "Node:[ \t]*") (setq Info-current-node @@ -1998,19 +1998,20 @@ Info-search Info-isearch-initial-node bound (and found (> found opoint-min) (< found opoint-max))) - (signal 'search-failed (list regexp "end of node"))) + (user-error "Search failed: `%s' (end of node)" regexp)) ;; If no subfiles, give error now. (unless (or found Info-current-subfile) (if isearch-mode - (signal 'search-failed (list regexp "end of manual")) + (user-error "Search failed: `%s' (end of manual)" regexp) (let ((search-spaces-regexp Info-search-whitespace-regexp)) - (if backward - (re-search-backward regexp) - (re-search-forward regexp))))) + (unless (if backward + (re-search-backward regexp nil t) + (re-search-forward regexp nil t)) + (user-error "Search failed: `%s'" regexp))))) (if (and bound (not found)) - (signal 'search-failed (list regexp))) + (user-error "Search failed: `%s'" regexp)) (unless (or found bound) (unwind-protect @@ -2054,9 +2055,8 @@ Info-search (setq list nil))) (if found (message "") - (signal 'search-failed (if isearch-mode - (list regexp "end of manual") - (list regexp))))) + (user-error "Search failed: `%s'%s" + regexp (if isearch-mode " (end of manual)" "")))) (if (not found) (progn (Info-read-subfile osubfile) (goto-char opoint) @@ -5237,9 +5237,6 @@ Info-speedbar-buttons (erase-buffer)) (Info-speedbar-hierarchy-buttons nil 0)) -;; FIXME: Really? Why here? -(add-to-list 'debug-ignored-errors 'search-failed) - ;;;; Desktop support (defun Info-desktop-buffer-misc-data (_desktop-dirname) -- 2.11.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 18:44:33 2017 Received: (at 6106) by debbugs.gnu.org; 26 Mar 2017 22:44:33 +0000 Received: from localhost ([127.0.0.1]:46403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csGtl-0002Hw-3U for submit@debbugs.gnu.org; Sun, 26 Mar 2017 18:44:33 -0400 Received: from sub3.mail.dreamhost.com ([69.163.253.7]:56077 helo=homiemail-a11.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1csGti-0002Hh-Ne for 6106@debbugs.gnu.org; Sun, 26 Mar 2017 18:44:31 -0400 Received: from homiemail-a11.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a11.g.dreamhost.com (Postfix) with ESMTP id 66EBF314C066; Sun, 26 Mar 2017 15:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=jurta.org; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version: content-type; s=jurta.org; bh=h10Ccev/kG7JH+yqco+fi+b6oXI=; b=ak g50gH3KrmmGBa7M/pmTaueyTmmB2KiTygobo05YZU+YKf1yzSWK0F1DCUbIzDNLe jis/oIe3uvvNrhWTwC4XoUmRiA++Awj4yFHRJTbf121oPAP59KLfNz1m7wYEhBp0 WftbapDWd4QueBYzQO60QPgdbl0LyX4ipCctV/Q6A= Received: from localhost.linkov.net (m213-102-69-42.cust.tele2.ee [213.102.69.42]) (Authenticated sender: jurta@jurta.org) by homiemail-a11.g.dreamhost.com (Postfix) with ESMTPA id 8F8AC314C062; Sun, 26 Mar 2017 15:44:28 -0700 (PDT) From: Juri Linkov To: npostavs@users.sourceforge.net Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors Organization: LINKOV.NET References: <87fw8bt721.fsf@mail.jurta.org> <87vaqz2umz.fsf@users.sourceforge.net> Date: Mon, 27 Mar 2017 01:35:14 +0300 In-Reply-To: <87vaqz2umz.fsf@users.sourceforge.net> (npostavs's message of "Thu, 23 Mar 2017 23:58:28 -0400") Message-ID: <87wpbb1y1p.fsf@localhost> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 6106 Cc: 6106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) >> `search-failed' is added to `debug-ignored-errors' in info.el >> to not enter the debugger when a normal search stops with no results. >> >> But this error is raised by `xsignal1 (Qsearch_failed, string)' >> in `re-search-forward' (called from `Info-search'), >> so I see no way to replace it with a call to the new function >> `user-error' (or the same function with any other name). > > Use the NOERROR parameter? Looks right, thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 27 20:23:25 2017 Received: (at 6106) by debbugs.gnu.org; 28 Mar 2017 00:23:25 +0000 Received: from localhost ([127.0.0.1]:48003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cseuy-00089g-RY for submit@debbugs.gnu.org; Mon, 27 Mar 2017 20:23:25 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:34945) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cseuw-00089L-Ba; Mon, 27 Mar 2017 20:23:22 -0400 Received: by mail-it0-f44.google.com with SMTP id y18so95179533itc.0; Mon, 27 Mar 2017 17:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=fGyq47z0Ba0xsGcCQp+5ax4uggR7NugRrAPeKobBxuc=; b=K1wHtDMWB5OB7APj2l+OkHu9cKSqmzIvAnJoOHVYdVdAps3sHMvltm+p3JA80cipfp t424H8RmzLxIhMsbKA7nvJQVry1jAPbx/opu37UlZXTx40qPy0USYhdK1tAUm2pE20ih L3yBAlo3LLIxV78WLLZLln7Kz47Oam5h0NpD8LeQVUPC2+GeyReLXl2vblUtUjei0WFf DySZki+P6Yeohw0Y+MtVfMt55a4bvpO1GXvIThx43SDSjClZ/qs3HLwe9pskIVI29yU1 jCSKoCk5gx3GIjgFSmG2KwTIdUkOu/LxV3wikFt/5ArsbdWk2EiP/V3dFf3dzSWq6r2X JPHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=fGyq47z0Ba0xsGcCQp+5ax4uggR7NugRrAPeKobBxuc=; b=Zn3KCUo6JyZHlzLi3/DgMjG98zpJihBLtDpr54BSkPzxM7nExVxQ2mFrCAxaBrqByz pbXGvj2ttlpO3d++XxPYV6UmpPELJt4gcKrZ0/ygg/I/Dm5OZXRe2tWm6tsnKOV3Z+Cf ZPBNLlpXgyzLKRE19pX7Z6If5ITPci/FUB36MqIUAg/9pOXb/ttqtLvMeum4IYYnogh3 9iYSBELv1L533xNVatzh04oekeSkmGTVOWgA/Z4sT3FapbDMhXzMiHfFWoZavXUSkI82 AvTeV9qcNqv2dmf/ugWnHv8jkviYXJ0SfratRSzKmoYlWA3XPr0ddn/bkqBBsYco/r6n tYow== X-Gm-Message-State: AFeK/H3gxAneb/OOC92Jngs7mc0iiBDoDfXZTIe0xZNokMODrIJJKYHwcO/+vGRsI3anRg== X-Received: by 10.36.1.208 with SMTP id 199mr12332883itk.20.1490660596465; Mon, 27 Mar 2017 17:23:16 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id h71sm1062418ioe.9.2017.03.27.17.23.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 27 Mar 2017 17:23:15 -0700 (PDT) From: npostavs@users.sourceforge.net To: Juri Linkov Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors References: <87fw8bt721.fsf@mail.jurta.org> <87vaqz2umz.fsf@users.sourceforge.net> <87wpbb1y1p.fsf@localhost> Date: Mon, 27 Mar 2017 20:24:37 -0400 In-Reply-To: <87wpbb1y1p.fsf@localhost> (Juri Linkov's message of "Mon, 27 Mar 2017 01:35:14 +0300") Message-ID: <87y3vq2qpm.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 6106 Cc: 6106@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 6106 fixed close 6106 26.1 quit Juri Linkov writes: >>> `search-failed' is added to `debug-ignored-errors' in info.el >>> to not enter the debugger when a normal search stops with no results. >>> >>> But this error is raised by `xsignal1 (Qsearch_failed, string)' >>> in `re-search-forward' (called from `Info-search'), >>> so I see no way to replace it with a call to the new function >>> `user-error' (or the same function with any other name). >> >> Use the NOERROR parameter? > > Looks right, thanks. Thanks for the review, push to master [1: a62437d4b9]. 1: 2017-03-27 20:18:20 -0400 a62437d4b933825a92ac3836836edbca3540fa1c Don't add `search-failed' to ignored errors in info.el (Bug#6106) From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 09:42:44 2017 Received: (at 6106) by debbugs.gnu.org; 1 Apr 2017 13:42:44 +0000 Received: from localhost ([127.0.0.1]:55185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuJIi-0007j3-2W for submit@debbugs.gnu.org; Sat, 01 Apr 2017 09:42:44 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:34924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuJIh-0007ir-2p for 6106@debbugs.gnu.org; Sat, 01 Apr 2017 09:42:43 -0400 Received: by mail-io0-f180.google.com with SMTP id z13so54263868iof.2 for <6106@debbugs.gnu.org>; Sat, 01 Apr 2017 06:42:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=RxtANvzUWHfknVf8hHaPL2ijlpLVfBH115GGZSH9vJk=; b=SOJ9oMQcbDtkR/PawGeXuvyY1V9iOtEaf6DdXQET3pmouA6TWdDJb5h/i66ivxPQcR HP96lQCJdhee8iYcoGc+NoBLHJ9gr5YlJ4xB63Re30qlKV/4eGJUN5klvvGSAsKLJbne BwPtxgn8vvvfPfXT6uZEdnNXMJ/v3PuozkeTlwcKwDNXwFtJEP4SAx7Z7tgdF9yemoP3 1Iei08Xt6Lsr5JUgaWZFcn0yNHIo0G3wTPRjUMnZ1KHsR4pAq4rTZTeYo02bRJht4QAp 8zNjX6o7P+leLlzkPC3zb6xoftImsgrPlqi0UqxJW484HoRNQpQIleIO4WzsFWITWyyn nEJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=RxtANvzUWHfknVf8hHaPL2ijlpLVfBH115GGZSH9vJk=; b=EzFyh5LJWaNzf1izYe/nXmR6W/je5Ab4/Xuj8RlMySks9Fc3W70S7rp8pRtjqYp6Cy 2esUe+T4yOw5WB9l1Gm3ptXr5yBcerYF0+H/hMO/ciR2pebmlFtxofvpTuT5l6v0JzeM S/lFy+tsWjGtUa+6HiRHJZ0rZhV9k/Kc+FL4qu3ldwTTnZOTXRzXJP5ZiiDSOXCvF4C4 a6II6uAISbW5KPjw6ttLKsx9BUgk/5Vx3SCbxiqeHfYqe06KyaPA17MMq0YNiMqTviSK dK3WwV71+QhESLeXAnMjlS6wI8yi4CrNqlZKnP8UAaLqp8GqtIfHTJD1avIojnTLbaeI K0dg== X-Gm-Message-State: AFeK/H19jPEwjZN3L4qPIvF5THb388lnnCqaYB6ryepS2gnAieSiQ8dFF8iVqFTqh5j9nw== X-Received: by 10.107.189.68 with SMTP id n65mr8588422iof.154.1491054157419; Sat, 01 Apr 2017 06:42:37 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id 78sm2948659ity.7.2017.04.01.06.42.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Apr 2017 06:42:36 -0700 (PDT) From: npostavs@users.sourceforge.net To: Juri Linkov Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors References: <87fw8bt721.fsf@mail.jurta.org> <87vaqz2umz.fsf@users.sourceforge.net> Date: Sat, 01 Apr 2017 09:43:59 -0400 In-Reply-To: <87vaqz2umz.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Thu, 23 Mar 2017 23:58:28 -0400") Message-ID: <87k2741bvk.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 6106 Cc: Mark Oteiza , 6106@debbugs.gnu.org, Helmut Eller X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain npostavs@users.sourceforge.net writes: > (Info-select-node, Info-search): Replace (signal 'search-failed ...) > with (user-error "Search failed: "...). Turns out this breaks isearch over multiple nodes, as noted by Mark Oteiza in [1]. I believe this is fixed by the patch below. [1]: http://lists.gnu.org/archive/html/emacs-devel/2017-03/msg00869.html --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v1-0001-Throw-a-search-failed-derived-error-in-Info-searc.patch Content-Description: patch >From 2cb893febdf06282c1183b3e4f4de8728bbe44b9 Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 1 Apr 2017 09:34:04 -0400 Subject: [PATCH v1] Throw a `search-failed' derived error in Info search The original fix for Bug#6106 switched from signalling `search-failed' to `user-error'. However, this breaks incremental searching over multiple nodes because the isearch code doesn't expect a `user-error'. * src/search.c (syms_of_search): New error, `user-search-failed', with `user-error' and `search-failed' as parents. * lisp/info.el (Info-search): Use it instead of `user-error' so that isearch will handle failed searches correctly. --- lisp/info.el | 12 ++++++------ src/search.c | 9 +++++++++ 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/lisp/info.el b/lisp/info.el index a6bab290a7..81e5d29f82 100644 --- a/lisp/info.el +++ b/lisp/info.el @@ -1998,20 +1998,20 @@ Info-search Info-isearch-initial-node bound (and found (> found opoint-min) (< found opoint-max))) - (user-error "Search failed: `%s' (end of node)" regexp)) + (signal 'user-search-failed (list regexp "(end of node)"))) ;; If no subfiles, give error now. (unless (or found Info-current-subfile) (if isearch-mode - (user-error "Search failed: `%s' (end of manual)" regexp) + (signal 'user-search-failed (list regexp "end of manual")) (let ((search-spaces-regexp Info-search-whitespace-regexp)) (unless (if backward (re-search-backward regexp nil t) (re-search-forward regexp nil t)) - (user-error "Search failed: `%s'" regexp))))) + (signal 'user-seach-failed (list regexp)))))) (if (and bound (not found)) - (user-error "Search failed: `%s'" regexp)) + (signal 'user-search-failed (list regexp))) (unless (or found bound) (unwind-protect @@ -2055,8 +2055,8 @@ Info-search (setq list nil))) (if found (message "") - (user-error "Search failed: `%s'%s" - regexp (if isearch-mode " (end of manual)" "")))) + (signal 'user-search-failed + `(,regexp ,@(if isearch-mode '("end of manual")))))) (if (not found) (progn (Info-read-subfile osubfile) (goto-char opoint) diff --git a/src/search.c b/src/search.c index 33cb02aa7a..48caea2f51 100644 --- a/src/search.c +++ b/src/search.c @@ -3389,6 +3389,10 @@ syms_of_search (void) /* Error condition used for failing searches. */ DEFSYM (Qsearch_failed, "search-failed"); + /* Error condition used for failing searches started by user, i.e., + where failure should not invoke the debugger. */ + DEFSYM (Quser_search_failed, "search-failed"); + /* Error condition signaled when regexp compile_pattern fails. */ DEFSYM (Qinvalid_regexp, "invalid-regexp"); @@ -3397,6 +3401,11 @@ syms_of_search (void) Fput (Qsearch_failed, Qerror_message, build_pure_c_string ("Search failed")); + Fput (Quser_search_failed, Qerror_conditions, + listn (CONSTYPE_PURE, 2, Qsearch_failed, Quser_error)); + Fput (Quser_search_failed, Qerror_message, + build_pure_c_string ("Search failed")); + Fput (Qinvalid_regexp, Qerror_conditions, listn (CONSTYPE_PURE, 2, Qinvalid_regexp, Qerror)); Fput (Qinvalid_regexp, Qerror_message, -- 2.11.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 10:13:49 2017 Received: (at 6106) by debbugs.gnu.org; 1 Apr 2017 14:13:49 +0000 Received: from localhost ([127.0.0.1]:55865 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuJml-0000B3-Ul for submit@debbugs.gnu.org; Sat, 01 Apr 2017 10:13:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40627) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuJmj-0000Ao-I0 for 6106@debbugs.gnu.org; Sat, 01 Apr 2017 10:13:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cuJmd-0008CB-Gc for 6106@debbugs.gnu.org; Sat, 01 Apr 2017 10:13:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47887) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cuJmW-00088f-Ci; Sat, 01 Apr 2017 10:13:32 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4966 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cuJmV-0000xi-07; Sat, 01 Apr 2017 10:13:32 -0400 Date: Sat, 01 Apr 2017 17:13:32 +0300 Message-Id: <83vaqo43n7.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87k2741bvk.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors References: <87fw8bt721.fsf@mail.jurta.org> <87vaqz2umz.fsf@users.sourceforge.net> <87k2741bvk.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 6106 Cc: juri@jurta.org, mvoteiza@udel.edu, 6106@debbugs.gnu.org, eller.helmut@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: npostavs@users.sourceforge.net > Date: Sat, 01 Apr 2017 09:43:59 -0400 > Cc: Mark Oteiza , 6106@debbugs.gnu.org, > Helmut Eller > > Turns out this breaks isearch over multiple nodes, as noted by Mark > Oteiza in [1]. I believe this is fixed by the patch below. > > [1]: http://lists.gnu.org/archive/html/emacs-devel/2017-03/msg00869.html Thanks. I think the symbol you are introducing and its plist should be documented in the ELisp manual and mentioned in NEWS. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 10:23:41 2017 Received: (at 6106) by debbugs.gnu.org; 1 Apr 2017 14:23:41 +0000 Received: from localhost ([127.0.0.1]:55870 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuJwK-0000Qw-Vm for submit@debbugs.gnu.org; Sat, 01 Apr 2017 10:23:41 -0400 Received: from mail-qk0-f169.google.com ([209.85.220.169]:33306) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuJwJ-0000Qh-2E for 6106@debbugs.gnu.org; Sat, 01 Apr 2017 10:23:39 -0400 Received: by mail-qk0-f169.google.com with SMTP id d201so57229696qkc.0 for <6106@debbugs.gnu.org>; Sat, 01 Apr 2017 07:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fve7bwfiRZyNlztiV6ffg1jzrNbp7/eIZKI+J4kPOlE=; b=JYqu0WdpBZCb8eNBQ4LRNDA7CW6gasK1fIrFJxOUd99xqhgST7b7bMD61+Hrwwjwig rcanMi+ghNwRuLZfftCUZGraxU+S+cu5e+f4jOUlf2ZiJ1nEoERZ8kz05JcVd7sIwYE4 Bhgj2WkDsyLjirL2KPaG0kxu0xhX4MywQBIOI/x2NrsOnBs9FPoMwjzXWhGZp5UPSIGZ BcKMqV8nL3K70/AqSUHOewsfhJbIeKwxGSuhzZ46KjAa7VlLZUPem5JLOLny8IEZuuR4 R5PSSCgWjwpsDCcCl95C9aYojIYlqGxPZjIG5LSm1hkwdmIdT5mHMpwrkdyAZe+bUafp 9ncg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fve7bwfiRZyNlztiV6ffg1jzrNbp7/eIZKI+J4kPOlE=; b=ehZ8gduXVzRNEGYU1mcNKiGa0QftclIc5c6lDpdTB77LC0RZDUZi9iE/NwARnijdl0 sR7wG/q0vM3wYqvQA1X8VLlnreh2fib8K8M4uLxmlXydGgvTzBPoGCVNh634pB/8cScT 38Ngr3yuEzHDhnwRxhq5buRyvDH/6lqXfm22ACYw/GSif5CcZpAFydj1kv2H7icb3gGq s0y2RHgW7CrWdWdTMiq7tE8DGPOxNy+UZJXinbGde7m5lntRRYQH5PZDl0MCZV9FnNYl XvUCtfz40XmZ4Pgzl4vR3JiAzvdA1dhVgL0H1NZ6qqiopM+BhpSqUr+dkZ6lpR+jYZJt 3kKw== X-Gm-Message-State: AFeK/H38+dINAb2wJGUYtCpLwshy+IWQuDxPoFeR1q4sCbT5XhKYe0FKBxC9MTpnHXgHh4sl X-Received: by 10.55.159.196 with SMTP id i187mr7349121qke.94.1491056613150; Sat, 01 Apr 2017 07:23:33 -0700 (PDT) Received: from holos.localdomain (pool-173-67-40-97.bltmmd.fios.verizon.net. [173.67.40.97]) by smtp.gmail.com with ESMTPSA id f205sm4816783qke.9.2017.04.01.07.23.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Apr 2017 07:23:32 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id 1166A66124; Sat, 1 Apr 2017 10:23:32 -0400 (EDT) Date: Sat, 1 Apr 2017 10:23:32 -0400 From: Mark Oteiza To: npostavs@users.sourceforge.net Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors Message-ID: <20170401142332.GA5792@holos.localdomain> References: <87fw8bt721.fsf@mail.jurta.org> <87vaqz2umz.fsf@users.sourceforge.net> <87k2741bvk.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k2741bvk.fsf@users.sourceforge.net> User-Agent: Mutt/1.8+21 (c875e6f4785d) (2017-02-23) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 6106 Cc: Juri Linkov , 6106@debbugs.gnu.org, Helmut Eller X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 01/04/17 at 09:43am, npostavs@users.sourceforge.net wrote: > npostavs@users.sourceforge.net writes: > > > (Info-select-node, Info-search): Replace (signal 'search-failed ...) > > with (user-error "Search failed: "...). > > Turns out this breaks isearch over multiple nodes, as noted by Mark > Oteiza in [1]. I believe this is fixed by the patch below. > > [1]: http://lists.gnu.org/archive/html/emacs-devel/2017-03/msg00869.html Thanks for addressing. I get the following with your patch: peculiar error: "cats", "(end of node)" From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 17:07:27 2017 Received: (at 6106) by debbugs.gnu.org; 1 Apr 2017 21:07:27 +0000 Received: from localhost ([127.0.0.1]:55992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuQF4-0001gb-OF for submit@debbugs.gnu.org; Sat, 01 Apr 2017 17:07:27 -0400 Received: from mail-io0-f175.google.com ([209.85.223.175]:34424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuQF3-0001gO-CC for 6106@debbugs.gnu.org; Sat, 01 Apr 2017 17:07:25 -0400 Received: by mail-io0-f175.google.com with SMTP id b140so57291671iof.1 for <6106@debbugs.gnu.org>; Sat, 01 Apr 2017 14:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=prL4jDUPOpDMZ1mPCaQXBjE1pGI00NMcOf9//fywfEM=; b=rGyBcM66OzMJMOnHT9va+mpl5jDdLLijU/4157ByVMRVUGVYbFLGTTURqwbn2thuiJ 8craai5GNzRqlI83feLsqUG1m3ZSBa+FgdTre87Rb9BaIxcH7k7t6FW/8DSdss6S0EVu ey0PcUDytoQVviUtvW5cocDOHpHzcR/J/OUMG3NMVK20RYcPP6fY309SCWfK1nw6WaFy 1gbxWjj7z1fCaJP+G3bBJ/mTyuKcHB9J3yfBODAQ2jLohlEQmps9Bnu5JMPtUyS3GnGQ x5fpd2GllwuZ9c6nQ2JlmhBcHEL8NQCSlsMjEaHimQp7zaJkD1cI8ano/0sceKKTAeqc cqpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=prL4jDUPOpDMZ1mPCaQXBjE1pGI00NMcOf9//fywfEM=; b=dUqGqb3/2Ub49Qhgjppsca6narEfobeDKtixC40/Q4Phrg/i9RnffuHHRtiyMFPP5L Kcn1UZnkFeo1cwqbv2Q+Ldcs1449qAdl+zhARdOss7ZDE/IUeUXKN158Svuav1uRZupd AyaZb4acnrD+XI4GwNIoAu1/say76aRNtpG1AHsjnYaCsKzZZe3f9X34AUsVEkjD9kA7 a44HuvXRn52/mg4b2KiQ3vHi9XTxQOo1yyzo6Y/WxD11Pbf3mNbKOkzLOXCuKpKhK3eG 9/HkNIuLJtL7qBpTV7FIazE2nZ5wtgd/P5wPYTCHMSI72GNfrHGkiXw5PMkI7sYZGmSX Gvkg== X-Gm-Message-State: AFeK/H1WrqruLJwAHBMn38o1Lhx/ROcEdxfWGzlQTvM2Mz7XAFQkC15iC6jhs3L0GeXgXw== X-Received: by 10.107.163.83 with SMTP id m80mr10551038ioe.74.1491080839814; Sat, 01 Apr 2017 14:07:19 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id f196sm5583597itc.2.2017.04.01.14.07.18 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Apr 2017 14:07:18 -0700 (PDT) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors References: <87fw8bt721.fsf@mail.jurta.org> <87vaqz2umz.fsf@users.sourceforge.net> <87k2741bvk.fsf@users.sourceforge.net> <83vaqo43n7.fsf@gnu.org> Date: Sat, 01 Apr 2017 17:08:42 -0400 In-Reply-To: <83vaqo43n7.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 01 Apr 2017 17:13:32 +0300") Message-ID: <87fuhr25ut.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 6106 Cc: juri@jurta.org, mvoteiza@udel.edu, 6106@debbugs.gnu.org, eller.helmut@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Eli Zaretskii writes: > > Thanks. I think the symbol you are introducing and its plist should > be documented in the ELisp manual and mentioned in NEWS. I added it to `(elisp) Standard Errors' after `user-error'. Or should it go next to `search-failed'? It says the list is "grouped by concept" though it seems to be alphabetical. Mark Oteiza writes: > On 01/04/17 at 09:43am, npostavs@users.sourceforge.net wrote: >> npostavs@users.sourceforge.net writes: >> >> > (Info-select-node, Info-search): Replace (signal 'search-failed ...) >> > with (user-error "Search failed: "...). >> >> Turns out this breaks isearch over multiple nodes, as noted by Mark >> Oteiza in [1]. I believe this is fixed by the patch below. >> >> [1]: http://lists.gnu.org/archive/html/emacs-devel/2017-03/msg00869.html > > Thanks for addressing. I get the following with your patch: > > peculiar error: "cats", "(end of node)" Sorry, I messed up. I did an initial implementation using `define-error' in lisp, and I didn't retest after moving that part to C. Here's a corrected patch. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=v2-0001-Throw-a-search-failed-derived-error-in-Info-searc.patch Content-Description: patch >From bc0b21552dd782190662fe1fcbf7cd8197a7822e Mon Sep 17 00:00:00 2001 From: Noam Postavsky Date: Sat, 1 Apr 2017 09:34:04 -0400 Subject: [PATCH v2] Throw a `search-failed' derived error in Info search The original fix for Bug#6106 switched from signalling `search-failed' to `user-error'. However, this breaks incremental searching over multiple nodes because the isearch code doesn't expect a `user-error'. * src/search.c (syms_of_search): New error, `user-search-failed', with `user-error' and `search-failed' as parents. * doc/lispref/errors.texi (Standard Errors): Document it. * etc/NEWS: Announce it. * lisp/info.el (Info-search): Use it instead of `user-error' so that isearch will handle failed searches correctly. --- doc/lispref/errors.texi | 6 ++++++ etc/NEWS | 4 ++++ lisp/info.el | 12 ++++++------ src/search.c | 10 ++++++++++ 4 files changed, 26 insertions(+), 6 deletions(-) diff --git a/doc/lispref/errors.texi b/doc/lispref/errors.texi index 2ec1a108ea..1f67819c34 100644 --- a/doc/lispref/errors.texi +++ b/doc/lispref/errors.texi @@ -186,6 +186,12 @@ Standard Errors @item user-error The message is the empty string. @xref{Signaling Errors}. +@item user-search-failed +This is like @samp{search-failed}, but doesn't trigger the debugger, +like @samp{user-error}. @xref{Signaling Errors}, and @xref{Searching +and Matching}. This is used for searching in Info files, @xref{Search +Text,,,info,Info}. + @item void-function The message is @samp{Symbol's function definition is void}. @xref{Function Cells}. diff --git a/etc/NEWS b/etc/NEWS index c09cc390bb..f4627ac3a6 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1067,6 +1067,10 @@ its window gets deleted by 'delete-other-windows'. *** New command 'window-swap-states' swaps the states of two live windows. ++++ +*** New error type 'user-search-failed' like 'search-failed' but +avoids debugger like 'user-error'. + * Changes in Emacs 26.1 on Non-Free Operating Systems diff --git a/lisp/info.el b/lisp/info.el index a06c868fb3..28534f13e6 100644 --- a/lisp/info.el +++ b/lisp/info.el @@ -1998,20 +1998,20 @@ Info-search Info-isearch-initial-node bound (and found (> found opoint-min) (< found opoint-max))) - (user-error "Search failed: `%s' (end of node)" regexp)) + (signal 'user-search-failed (list regexp "(end of node)"))) ;; If no subfiles, give error now. (unless (or found Info-current-subfile) (if isearch-mode - (user-error "Search failed: `%s' (end of manual)" regexp) + (signal 'user-search-failed (list regexp "end of manual")) (let ((search-spaces-regexp Info-search-whitespace-regexp)) (unless (if backward (re-search-backward regexp nil t) (re-search-forward regexp nil t)) - (user-error "Search failed: `%s'" regexp))))) + (signal 'user-seach-failed (list regexp)))))) (if (and bound (not found)) - (user-error "Search failed: `%s'" regexp)) + (signal 'user-search-failed (list regexp))) (unless (or found bound) (unwind-protect @@ -2055,8 +2055,8 @@ Info-search (setq list nil))) (if found (message "") - (user-error "Search failed: `%s'%s" - regexp (if isearch-mode " (end of manual)" "")))) + (signal 'user-search-failed + `(,regexp ,@(if isearch-mode '("end of manual")))))) (if (not found) (progn (Info-read-subfile osubfile) (goto-char opoint) diff --git a/src/search.c b/src/search.c index 33cb02aa7a..c0deb57213 100644 --- a/src/search.c +++ b/src/search.c @@ -3389,6 +3389,10 @@ syms_of_search (void) /* Error condition used for failing searches. */ DEFSYM (Qsearch_failed, "search-failed"); + /* Error condition used for failing searches started by user, i.e., + where failure should not invoke the debugger. */ + DEFSYM (Quser_search_failed, "user-search-failed"); + /* Error condition signaled when regexp compile_pattern fails. */ DEFSYM (Qinvalid_regexp, "invalid-regexp"); @@ -3397,6 +3401,12 @@ syms_of_search (void) Fput (Qsearch_failed, Qerror_message, build_pure_c_string ("Search failed")); + Fput (Quser_search_failed, Qerror_conditions, + listn (CONSTYPE_PURE, 4, + Quser_search_failed, Quser_error, Qsearch_failed, Qerror)); + Fput (Quser_search_failed, Qerror_message, + build_pure_c_string ("Search failed")); + Fput (Qinvalid_regexp, Qerror_conditions, listn (CONSTYPE_PURE, 2, Qinvalid_regexp, Qerror)); Fput (Qinvalid_regexp, Qerror_message, -- 2.11.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 22:33:48 2017 Received: (at 6106) by debbugs.gnu.org; 2 Apr 2017 02:33:48 +0000 Received: from localhost ([127.0.0.1]:56240 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuVKu-0003cI-43 for submit@debbugs.gnu.org; Sat, 01 Apr 2017 22:33:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cuVKq-0003c4-GP for 6106@debbugs.gnu.org; Sat, 01 Apr 2017 22:33:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cuVKk-0004pA-Dv for 6106@debbugs.gnu.org; Sat, 01 Apr 2017 22:33:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54098) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cuVKV-0004bN-3K; Sat, 01 Apr 2017 22:33:23 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3253 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1cuVKU-0008RH-82; Sat, 01 Apr 2017 22:33:22 -0400 Date: Sun, 02 Apr 2017 05:33:28 +0300 Message-Id: <83k2734jyf.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <87fuhr25ut.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors References: <87fw8bt721.fsf@mail.jurta.org> <87vaqz2umz.fsf@users.sourceforge.net> <87k2741bvk.fsf@users.sourceforge.net> <83vaqo43n7.fsf@gnu.org> <87fuhr25ut.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 6106 Cc: juri@jurta.org, mvoteiza@udel.edu, 6106@debbugs.gnu.org, eller.helmut@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: npostavs@users.sourceforge.net > Cc: 6106@debbugs.gnu.org, juri@jurta.org, mvoteiza@udel.edu, eller.helmut@gmail.com > Date: Sat, 01 Apr 2017 17:08:42 -0400 > > Eli Zaretskii writes: > > > > Thanks. I think the symbol you are introducing and its plist should > > be documented in the ELisp manual and mentioned in NEWS. > > I added it to `(elisp) Standard Errors' after `user-error'. Or should > it go next to `search-failed'? It says the list is "grouped by concept" > though it seems to be alphabetical. It's not exactly alphabetical, so after user-error is fine, IMO. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 10:49:41 2017 Received: (at 6106) by debbugs.gnu.org; 2 Apr 2017 14:49:41 +0000 Received: from localhost ([127.0.0.1]:57609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cugp3-0002FW-9C for submit@debbugs.gnu.org; Sun, 02 Apr 2017 10:49:41 -0400 Received: from mail-qk0-f173.google.com ([209.85.220.173]:34593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cugoz-0002FF-W3 for 6106@debbugs.gnu.org; Sun, 02 Apr 2017 10:49:39 -0400 Received: by mail-qk0-f173.google.com with SMTP id d10so97854481qke.1 for <6106@debbugs.gnu.org>; Sun, 02 Apr 2017 07:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=udel-edu.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TE5DMfd7RdI6tFkhYMsLug49bn8NP42nARGIV/RojPQ=; b=CJtnVNjp+5NxvusAj+fOOn7hj2xZF04P15ULT8rbEnJyt8PxiSeVZoCc1I34073hSF LhlwYGYniPNa6WyN/muNKSSJvtLFXZJVGTysfxOYRHx5PFwOPMJfkVf0rQNP1Dr5mUvt trE0Hp7AgYrVTMIkmzsfGTfqwz7FQbcywXm9qX1I8WHBFDBUBPAvUdLY2ZTxx7JSVhoy j+5lQvTrwh+K4aIIWDQNX6Tt5JMdJ8q8JlXtgiF9RXmMQRB8dbvRTK0TphHGfHucHTL9 RINVe/f+rWH51CnW4jdZHyuIeG/bz5W8hNW4fMPWMZlXVh+JO2tNsRv/s64D/7QHO7Ea VLxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TE5DMfd7RdI6tFkhYMsLug49bn8NP42nARGIV/RojPQ=; b=p+gzCZd9/VrLCib0HkKL+xmO1HnijDIzFc48PZEwfQ2NRPa+1e6h7spzvzpRTT2wyD iuAMDCwkRnYWvlREXystwj66vhyFjfrgBLqnqa4Iz7eo9GnJhniG0VIBIj8UZevGBRR0 HHacIzxfcru4fySupFS/OWeAu1PhtVkiLhXnLTxCAaVvKGlE6Xp/0990RFcm5H7ROGhD YKS4YKjD9dDKX7qU0WHAWYNyia3nQ7dZZLMshYLhKj66xBQB5DuhGZ2S+wJSbhiHQnTe DHPi95h/dLbc2Ai+hX7CKwfRCBXMlTYbWzA+0r2W1046pQZnwnXMX+6Y6vn+6sucE+Wb Atvw== X-Gm-Message-State: AFeK/H2srKNUwviR7/taTpKF8uKN2Y3O8RqjIorsn1Pl2Mn9Y5ZLIU4kACvyHs3Ia1uik7nL X-Received: by 10.55.203.142 with SMTP id u14mr642293qkl.169.1491144571960; Sun, 02 Apr 2017 07:49:31 -0700 (PDT) Received: from holos.localdomain (pool-173-67-40-97.bltmmd.fios.verizon.net. [173.67.40.97]) by smtp.gmail.com with ESMTPSA id z29sm7694100qtz.67.2017.04.02.07.49.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Apr 2017 07:49:31 -0700 (PDT) Received: by holos.localdomain (Postfix, from userid 1000) id 522D266124; Sun, 2 Apr 2017 10:49:30 -0400 (EDT) Date: Sun, 2 Apr 2017 10:49:30 -0400 From: Mark Oteiza To: npostavs@users.sourceforge.net Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors Message-ID: <20170402144930.GA11440@holos.localdomain> References: <87fw8bt721.fsf@mail.jurta.org> <87vaqz2umz.fsf@users.sourceforge.net> <87k2741bvk.fsf@users.sourceforge.net> <83vaqo43n7.fsf@gnu.org> <87fuhr25ut.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87fuhr25ut.fsf@users.sourceforge.net> User-Agent: Mutt/1.8+21 (c875e6f4785d) (2017-02-23) X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 6106 Cc: juri@jurta.org, Eli Zaretskii , 6106@debbugs.gnu.org, eller.helmut@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On 01/04/17 at 05:08pm, npostavs@users.sourceforge.net wrote: > Mark Oteiza writes: > > > On 01/04/17 at 09:43am, npostavs@users.sourceforge.net wrote: > >> npostavs@users.sourceforge.net writes: > >> > >> > (Info-select-node, Info-search): Replace (signal 'search-failed ...) > >> > with (user-error "Search failed: "...). > >> > >> Turns out this breaks isearch over multiple nodes, as noted by Mark > >> Oteiza in [1]. I believe this is fixed by the patch below. > >> > >> [1]: http://lists.gnu.org/archive/html/emacs-devel/2017-03/msg00869.html > > > > Thanks for addressing. I get the following with your patch: > > > > peculiar error: "cats", "(end of node)" > > Sorry, I messed up. I did an initial implementation using > `define-error' in lisp, and I didn't retest after moving that part to > C. Here's a corrected patch. Works for me--thank you for the fix. From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 03 19:50:43 2017 Received: (at 6106) by debbugs.gnu.org; 3 Apr 2017 23:50:43 +0000 Received: from localhost ([127.0.0.1]:59620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvBkA-0006Bv-OV for submit@debbugs.gnu.org; Mon, 03 Apr 2017 19:50:42 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:35810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cvBk8-0006Bi-Ng for 6106@debbugs.gnu.org; Mon, 03 Apr 2017 19:50:41 -0400 Received: by mail-io0-f179.google.com with SMTP id z13so86130919iof.2 for <6106@debbugs.gnu.org>; Mon, 03 Apr 2017 16:50:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=1Q8l7YvRl7K01dOl7IIuYV4A3mSvEm2CWthuoUtsQbQ=; b=uMDtCrXfzD7eYBpI05wL32UqJBrM26JceFNqiJfZGrEElZaC5U+tte7ptF95NWyaFo +lWqlgsIWEVWTnx5rXKvs63DgMD9gTLRrKz+hH/MC9eNpOs+06AFlDJEE2yHJSmbimQ5 STtSYlOOzvIRTvSugpbaap1PWEOtN5KZuqRZxL9q9UwFNmeExPD77572w+gj9QaeDrnC Hc2XhWwoRrBqoI9PkxdzteLU8/oGM3Qnrq8D4iq9ZvuI2I8Gzn479dkcbdEIyX0btmuO cGy9OxYaDGPc3xz1Y5G+q1+mU5p0F9OlwHZRayLf4aCbGnGsw8dYW1l82e3AEFZZlXll 68QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=1Q8l7YvRl7K01dOl7IIuYV4A3mSvEm2CWthuoUtsQbQ=; b=uVcSuSju7vfX6xClUPa6INO7vHtJeYwVZHlGZT/DR8Qma6Bsh9TsqeD+7FblpdQwI2 liP811trj4aCR9PPJl3sYSFid4F8G24AiV4HfITJmDCTdHGwYzar0R0MPaLtYYC3vgPA dnaG0SeqEHEqq9yWAZEOOGVOTKeISY6MzBAwDEBS/1vNJrkqAsXUuCTDBp562woeqxec EH4nqBrzVrkA+yGmFae8KzC2VOEzbKm9w1KdMqBVX9XSZKsao+xuJlyQP3WM5wz5MwSq kc2Ufv0qR1WYbnAp7udeWp+L/c+IgL/zmiYAAglMlk0cNxdqXWeaE7icnVCF0dxcNKhF 8a4w== X-Gm-Message-State: AFeK/H3zrzm3CNZ9myKy5VsSwK75HPfdVnEoRTrM5iBEws7A8Of4hOBUknvW5ZhbzbqqVg== X-Received: by 10.107.41.212 with SMTP id p203mr20356554iop.13.1491263435201; Mon, 03 Apr 2017 16:50:35 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id w75sm6470135itc.21.2017.04.03.16.50.34 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Apr 2017 16:50:34 -0700 (PDT) From: npostavs@users.sourceforge.net To: Mark Oteiza Subject: Re: bug#6106: 24.0.50; info.el adds 'search-failed to debug-ignored-errors References: <87fw8bt721.fsf@mail.jurta.org> <87vaqz2umz.fsf@users.sourceforge.net> <87k2741bvk.fsf@users.sourceforge.net> <83vaqo43n7.fsf@gnu.org> <87fuhr25ut.fsf@users.sourceforge.net> <20170402144930.GA11440@holos.localdomain> Date: Mon, 03 Apr 2017 19:51:57 -0400 In-Reply-To: <20170402144930.GA11440@holos.localdomain> (Mark Oteiza's message of "Sun, 2 Apr 2017 10:49:30 -0400") Message-ID: <87h925vyle.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 6106 Cc: juri@jurta.org, Eli Zaretskii , 6106@debbugs.gnu.org, eller.helmut@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Mark Oteiza writes: > > Works for me--thank you for the fix. Thanks for testing, pushed to master [2: 3887c54544]. 2: 2017-04-03 19:36:14 -0400 3887c54544bc2e5f8c2e7c12973887f9b2b88c40 Throw a `search-failed' derived error in Info search From unknown Thu Aug 14 18:32:16 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 02 May 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator