GNU bug report logs - #61051
treesit-install-language-grammar can provide the default repository URL

Previous Next

Package: emacs;

Reported by: Dmitry Gutov <dgutov <at> yandex.ru>

Date: Wed, 25 Jan 2023 03:24:01 UTC

Severity: normal

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


Message #8 received at 61051 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 61051 <at> debbugs.gnu.org
Subject: Re: bug#61051: treesit-install-language-grammar can provide the
 default repository URL
Date: Wed, 25 Jan 2023 14:29:30 +0200
> Date: Wed, 25 Jan 2023 05:23:37 +0200
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> 
> The format https://github.com/tree-sitter/tree-sitter-%s will work for a 
> lot of languages, and the user won't even have to search for the address.
> 
> The patch can look like this:
> 
> diff --git a/lisp/treesit.el b/lisp/treesit.el
> index 660039cc7cc..c1b98d085e8 100644
> --- a/lisp/treesit.el
> +++ b/lisp/treesit.el
> @@ -2708,7 +2708,8 @@ treesit--install-language-grammar-build-recipe
>         (list
>          lang
>          (read-string
> -        "Enter the URL of the Git repository of the language grammar: ")
> +        "Enter the URL of the Git repository of the language grammar: "
> +        (format "https://github.com/tree-sitter/tree-sitter-%s" lang))
>          (empty-string-to-nil
>           (read-string
>            "Enter the tag or branch (default: default branch): "))

Sounds good, but wouldn't we confuse users in those cases where the
Tree-sitter site doesn't have a grammar?  Would it be perhaps feasible
to probe first that a Git repository at the URL exists?




This bug report was last modified 2 years and 115 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.