From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 20:20:59 2023 Received: (at submit) by debbugs.gnu.org; 25 Jan 2023 01:20:59 +0000 Received: from localhost ([127.0.0.1]:57881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKUTD-00050u-3h for submit@debbugs.gnu.org; Tue, 24 Jan 2023 20:20:59 -0500 Received: from lists.gnu.org ([209.51.188.17]:58124) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKUT8-00050k-Ju for submit@debbugs.gnu.org; Tue, 24 Jan 2023 20:20:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKUT8-0007Wn-DU for bug-coreutils@gnu.org; Tue, 24 Jan 2023 20:20:54 -0500 Received: from dev.gentoo.org ([2001:470:ea4a:1:5054:ff:fec7:86e4] helo=smtp.gentoo.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1pKUT6-0003jO-Rw for bug-coreutils@gnu.org; Tue, 24 Jan 2023 20:20:54 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 5560E340F4D; Wed, 25 Jan 2023 01:20:42 +0000 (UTC) Date: Tue, 24 Jan 2023 20:20:40 -0500 From: Mike Frysinger To: bug-coreutils@gnu.org Subject: mv: add support for --one-file-system Message-ID: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="04lV2M0xOCWngyMn" Content-Disposition: inline Received-SPF: pass client-ip=2001:470:ea4a:1:5054:ff:fec7:86e4; envelope-from=vapier@gentoo.org; helo=smtp.gentoo.org X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --04lV2M0xOCWngyMn Content-Type: text/plain; charset=utf-8 Content-Disposition: inline mv will automatically use rename, but if that fails (e.g. with EXDEV), it falls back to copying files. i'd like to require that the mv be atomic when relocating a directory, and if it isn't, fallback to other logic. to that end, it'd be nice if mv supported --one-file-system and would return an error when hitting EXDEV rather than copying. -mike --04lV2M0xOCWngyMn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmPQg+gACgkQQWM7n+g3 9YHDCA//TZIs59DCSzpn07+ewdhy40JuRGoimKw0vwH+rxGQXY2Nonu05cr24Ji1 3dSnVwCSjOLQN83qTCIOZ0kpgqd8NfKhBGrO8W1EOIIlQ5BjlwhSRJEBNj8qUYm9 vqq6aYfaXqVav8oMb1k2S3mRd8i2v/ayzj3pV54fji06V2PLGTJ/54D7g/KczAki uMfAXLTyt/1XyPBfhmINeW2nUgXlnuRZ85GQ7PYY0XtnwIZINb4+CNOXklPT15+e 7nRFYzuoAEkBXpdJDtMtHBh5VlspnJT6KhYo4qVk8YN9yXupZ+0bfp6BkHxKST7r eZjMPGz+qiI/p5/FKu+/jwFXKVmAR++fmCP9CAhG7UeuyIO8d+5KhEcn2sP8qJsM dJthSA+vRpX3pzgDDJ/WntKNfkFSivGF0goQKPxjTGnbsoorO4aKiM3La/MOE0fe dweMiI2Cjjlp8ANGdY7kt3xyCaPspnx4eDpviPwFg3Xjf/vantwsE8IwNz1M1/bm MfMWvwLNOZE1MttCFD/JK1A9MFaTCwtI5Q+LELUldz3IorLiS+pILt218rGavyuY 2YOm7RbUJ+skbMNjhf4/SI5Wme9lBXHt27fgsnYzNMWupXiAPcKjrNSFefyYSlhr vLRGhUevaNCYZAJckoNo1WP+BfvUfdOiDxNNCdpOrpLBsMMKvlg= =lLSt -----END PGP SIGNATURE----- --04lV2M0xOCWngyMn-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 21:27:31 2023 Received: (at control) by debbugs.gnu.org; 25 Jan 2023 02:27:31 +0000 Received: from localhost ([127.0.0.1]:57939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKVVb-0000ft-0H for submit@debbugs.gnu.org; Tue, 24 Jan 2023 21:27:31 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:48988 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKVVZ-0000fZ-AO for control@debbugs.gnu.org; Tue, 24 Jan 2023 21:27:29 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 3ABB1340F39; Wed, 25 Jan 2023 02:27:22 +0000 (UTC) From: Mike Frysinger To: control@debbugs.gnu.org Subject: Control message User-Agent: GNU debbugs/0 Message-Id: <20230125022722.3ABB1340F39@smtp.gentoo.org> Date: Wed, 25 Jan 2023 02:27:22 +0000 (UTC) X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) severity 61050 wishlist thankyou From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 04:08:00 2023 Received: (at 61050) by debbugs.gnu.org; 25 Jan 2023 09:08:00 +0000 Received: from localhost ([127.0.0.1]:58257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKblA-0001cE-AE for submit@debbugs.gnu.org; Wed, 25 Jan 2023 04:08:00 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50008) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKbl8-0001bx-9e for 61050@debbugs.gnu.org; Wed, 25 Jan 2023 04:07:59 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 96522160045; Wed, 25 Jan 2023 01:07:50 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id aEJcLkLNeiZc; Wed, 25 Jan 2023 01:07:49 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 98F9F160054; Wed, 25 Jan 2023 01:07:49 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 98F9F160054 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1674637669; bh=JqKm+SWfdZ+AXLNFVKctTWQYkeWx+lKLoIIPPG0Cyuc=; h=Content-Type:Message-ID:Date:MIME-Version:To:From:Subject; b=L9tY/iTNFUBH3Zq6pqPkpwukwKXYm+Rw7UDUgyz28KBHOSdxVaLEBD0dH/yjQTYXP yMz4/uNzieRZyVlY3s4sJMF+ePT0ieYZK4alJx5UbWgSA4RYT1bWzF4xltdVzszIqs dwtasWT2GHKhQPRByBockJj1PeRS/f9mV5O0HdCY= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id yHgpgwzWdqdc; Wed, 25 Jan 2023 01:07:49 -0800 (PST) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 6F5C2160045; Wed, 25 Jan 2023 01:07:49 -0800 (PST) Content-Type: multipart/mixed; boundary="------------b4g36Yc9QUL9fddWbCTPa4Kj" Message-ID: <959daacf-01b9-c5a4-2b7f-694eada803d3@cs.ucla.edu> Date: Wed, 25 Jan 2023 01:07:48 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: Mike Frysinger References: Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: bug#61050: mv: add support for --one-file-system In-Reply-To: X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 61050 Cc: 61050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) This is a multi-part message in MIME format. --------------b4g36Yc9QUL9fddWbCTPa4Kj Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-01-24 17:20, Mike Frysinger wrote: > i'd like to require that the mv be > atomic when relocating a directory, and if it isn't, fallback to other > logic Calling the new option "--one-file-system" sounds a bit wrong, as --one-file-system is for programs like 'du' and 'cp' and causes them to not cross a file system boundary when recursing - something that 'mv' could also do (when it falls back on copying), but which is a different thing than what you're asking for. How about if we call the new option --no-copy instead? Something like the attached incomplete patch, say. (It needs more documentation and ideally a test case.) --------------b4g36Yc9QUL9fddWbCTPa4Kj Content-Type: text/x-patch; charset=UTF-8; name="no-copy.diff" Content-Disposition: attachment; filename="no-copy.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9jb3B5LmMgYi9zcmMvY29weS5jCmluZGV4IDk4ZjJiYTQ1YS4u OTk4MzQ0MzRmIDEwMDY0NAotLS0gYS9zcmMvY29weS5jCisrKyBiL3NyYy9jb3B5LmMKQEAg LTI2MTcsNyArMjYxNyw3IEBAIGNvcHlfaW50ZXJuYWwgKGNoYXIgY29uc3QgKnNyY19uYW1l LCBjaGFyIGNvbnN0ICpkc3RfbmFtZSwKICAgICAgICAgIHdoZXJlIHlvdSdkIHJlcGxhY2Ug JzE4JyB3aXRoIHRoZSBpbnRlZ2VyIGluIHBhcmVudGhlc2VzIHRoYXQKICAgICAgICAgIHdh cyBvdXRwdXQgZnJvbSB0aGUgcGVybCBvbmUtbGluZXIgYWJvdmUuCiAgICAgICAgICBJZiBu ZWNlc3NhcnksIG9mIGNvdXJzZSwgY2hhbmdlICcvdG1wJyB0byBzb21lIG90aGVyIGRpcmVj dG9yeS4gICovCi0gICAgICBpZiAocmVuYW1lX2Vycm5vICE9IEVYREVWKQorICAgICAgaWYg KHJlbmFtZV9lcnJubyAhPSBFWERFViB8fCB4LT5ub19jb3B5KQogICAgICAgICB7CiAgICAg ICAgICAgLyogVGhlcmUgYXJlIG1hbnkgd2F5cyB0aGlzIGNhbiBoYXBwZW4gZHVlIHRvIGEg cmFjZSBjb25kaXRpb24uCiAgICAgICAgICAgICAgV2hlbiBzb21ldGhpbmcgaGFwcGVucyBi ZXR3ZWVuIHRoZSBpbml0aWFsIGZvbGxvd19mc3RhdGF0IGFuZCB0aGUKZGlmZiAtLWdpdCBh L3NyYy9jb3B5LmggYi9zcmMvY29weS5oCmluZGV4IGQ3NzVkYjA0Ny4uMTVkY2ZhOGFmIDEw MDY0NAotLS0gYS9zcmMvY29weS5oCisrKyBiL3NyYy9jb3B5LmgKQEAgLTEzNCw5ICsxMzQs OSBAQCBzdHJ1Y3QgY3Bfb3B0aW9ucwogICAgICBDcmVhdGUgZGVzdGluYXRpb24gZGlyZWN0 b3JpZXMgYXMgdXN1YWwuICovCiAgIGJvb2wgaGFyZF9saW5rOwogCi0gIC8qIElmIHRydWUs IHJhdGhlciB0aGFuIGNvcHlpbmcsIGZpcnN0IGF0dGVtcHQgdG8gdXNlIHJlbmFtZS4KLSAg ICAgSWYgdGhhdCBmYWlscywgdGhlbiByZXNvcnQgdG8gY29weWluZy4gICovCi0gIGJvb2wg bW92ZV9tb2RlOworICAvKiBJZiBNT1ZFX01PREUsIGZpcnN0IGF0dGVtcHQgdG8gdXNlIHJl bmFtZS4KKyAgICAgSWYgdGhhdCBmYWlscyBhbmQgIU5PX0NPUFksIHJlc29ydCB0byBjb3B5 aW5nLiAgKi8KKyAgYm9vbCBtb3ZlX21vZGUsIG5vX2NvcHk7CiAKICAgLyogSWYgdHJ1ZSwg aW5zdGFsbCgxKSBpcyB0aGUgY2FsbGVyLiAgKi8KICAgYm9vbCBpbnN0YWxsX21vZGU7CmRp ZmYgLS1naXQgYS9zcmMvbXYuYyBiL3NyYy9tdi5jCmluZGV4IDcyYmJlOGU0Ni4uZjI3YTA3 YTFjIDEwMDY0NAotLS0gYS9zcmMvbXYuYworKysgYi9zcmMvbXYuYwpAQCAtNDgsNyArNDgs OCBAQAogICAgbm9uLWNoYXJhY3RlciBhcyBhIHBzZXVkbyBzaG9ydCBvcHRpb24sIHN0YXJ0 aW5nIHdpdGggQ0hBUl9NQVggKyAxLiAgKi8KIGVudW0KIHsKLSAgU1RSSVBfVFJBSUxJTkdf U0xBU0hFU19PUFRJT04gPSBDSEFSX01BWCArIDEKKyAgTk9fQ09QWV9PUFRJT04gPSBDSEFS X01BWCArIDEsCisgIFNUUklQX1RSQUlMSU5HX1NMQVNIRVNfT1BUSU9OCiB9OwogCiBzdGF0 aWMgc3RydWN0IG9wdGlvbiBjb25zdCBsb25nX29wdGlvbnNbXSA9CkBAIC01OCw2ICs1OSw3 IEBAIHN0YXRpYyBzdHJ1Y3Qgb3B0aW9uIGNvbnN0IGxvbmdfb3B0aW9uc1tdID0KICAgeyJm b3JjZSIsIG5vX2FyZ3VtZW50LCBOVUxMLCAnZid9LAogICB7ImludGVyYWN0aXZlIiwgbm9f YXJndW1lbnQsIE5VTEwsICdpJ30sCiAgIHsibm8tY2xvYmJlciIsIG5vX2FyZ3VtZW50LCBO VUxMLCAnbid9LAorICB7Im5vLWNvcHkiLCBub19hcmd1bWVudCwgTlVMTCwgTk9fQ09QWV9P UFRJT059LAogICB7Im5vLXRhcmdldC1kaXJlY3RvcnkiLCBub19hcmd1bWVudCwgTlVMTCwg J1QnfSwKICAgeyJzdHJpcC10cmFpbGluZy1zbGFzaGVzIiwgbm9fYXJndW1lbnQsIE5VTEws IFNUUklQX1RSQUlMSU5HX1NMQVNIRVNfT1BUSU9OfSwKICAgeyJzdWZmaXgiLCByZXF1aXJl ZF9hcmd1bWVudCwgTlVMTCwgJ1MnfSwKQEAgLTI2MCw2ICsyNjIsNyBAQCBSZW5hbWUgU09V UkNFIHRvIERFU1QsIG9yIG1vdmUgU09VUkNFKHMpIHRvIERJUkVDVE9SWS5cblwKIElmIHlv dSBzcGVjaWZ5IG1vcmUgdGhhbiBvbmUgb2YgLWksIC1mLCAtbiwgb25seSB0aGUgZmluYWwg b25lIHRha2VzIGVmZmVjdC5cblwKICIpLCBzdGRvdXQpOwogICAgICAgZnB1dHMgKF8oIlwK KyAgICAgIC0tbm8tY29weSAgICAgICAgICAgICAgICBkbyBub3QgY29weSBpZiByZW5hbWlu ZyBmYWlsc1xuXAogICAgICAgLS1zdHJpcC10cmFpbGluZy1zbGFzaGVzICByZW1vdmUgYW55 IHRyYWlsaW5nIHNsYXNoZXMgZnJvbSBlYWNoIFNPVVJDRVxuXAogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgYXJndW1lbnRcblwKICAgLVMsIC0tc3VmZml4PVNVRkZJWCAg ICAgICAgICBvdmVycmlkZSB0aGUgdXN1YWwgYmFja3VwIHN1ZmZpeFxuXApAQCAtMzMwLDYg KzMzMyw5IEBAIG1haW4gKGludCBhcmdjLCBjaGFyICoqYXJndikKICAgICAgICAgY2FzZSAn bic6CiAgICAgICAgICAgeC5pbnRlcmFjdGl2ZSA9IElfQUxXQVlTX05POwogICAgICAgICAg IGJyZWFrOworICAgICAgICBjYXNlIE5PX0NPUFlfT1BUSU9OOgorICAgICAgICAgIHgubm9f Y29weSA9IHRydWU7CisgICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2UgU1RSSVBfVFJB SUxJTkdfU0xBU0hFU19PUFRJT046CiAgICAgICAgICAgcmVtb3ZlX3RyYWlsaW5nX3NsYXNo ZXMgPSB0cnVlOwogICAgICAgICAgIGJyZWFrOwo= --------------b4g36Yc9QUL9fddWbCTPa4Kj-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 05:34:06 2023 Received: (at 61050) by debbugs.gnu.org; 25 Jan 2023 10:34:06 +0000 Received: from localhost ([127.0.0.1]:58431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKd6U-0006Pv-CA for submit@debbugs.gnu.org; Wed, 25 Jan 2023 05:34:06 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:52023) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKd6S-0006PP-6S for 61050@debbugs.gnu.org; Wed, 25 Jan 2023 05:34:04 -0500 Received: by mail-wm1-f45.google.com with SMTP id fl24so79772wmb.1 for <61050@debbugs.gnu.org>; Wed, 25 Jan 2023 02:34:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=MkZa5qQgs7jweqwT1dcQ0aD0Qi1oiiB6UZtZv+D1cV8=; b=mVMa5NzOJiKNjuOudqgnYE4lW/y5cNzLwd2I9deF85gJVmpiQqoMdcsRs2lErn9FZZ hImSZkIm8W82dVy2Vfk7GHdwj5ivZWZS2IZbuftoYvo2SUBNFEoLSjmC+4/V7y3xmb/9 ADyrGU9/5WcWO8lilm4lh7sribuF7OfcrnvlTW55u/0syYHrlK9G6bwz9/AlavUdzt4h CJADjraJDvfjzuGFiZF9XtGaDXAGbyac9to0NW3PvXm9zSsiFETxH0Hkae1U41ibszQw 24wyWxbp8YMsdlRxxebPlPNVYU8OD/U/rXLVYlnArCFHKNoHRfOFvCvyPQJi2pivKZWy XEBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MkZa5qQgs7jweqwT1dcQ0aD0Qi1oiiB6UZtZv+D1cV8=; b=i1w+MvXBCkoo3osrsE+LwKaKVg0bMsPRVYIm1LhDrxK77YanJmgca+I2DDnE8l0Ba0 W82MpRvUzGTVpDhHZs1LBPhkAG5LrMr/wurgSBEYT7KgOCbMfqJrLhqM/7URseA8R7tA 5ebdMPaPlnZs+6YYxYd36gsuZAqnM0og8Hw/rIdm7sdInnZL/rQ7gOBb+cKLraMAu1jg fTm4QihxsTi4Ml8vPQT2C1zV8CcUxhI2Y2Kq8ParUzeK5Gs6dGYtA/vU4xnBJYsTne82 aXGYzuLd74YqqDLVY8p4uVzJhdHaFzE6RcyxdWxW9sCH0VDWF0yR2PKLhLiFJ6PyuUPm ZcGA== X-Gm-Message-State: AFqh2koXKBeNEOtvygCJ7zrGvztZcZOMNL8m2f5qYyTDGo2wFd5wqnd9 6GN20wL5DpHnZoGQB1HHwfk= X-Google-Smtp-Source: AMrXdXt6NP1nwn1C0RpoFY/NBw1UYBxL2wNKU14GEejCqkMdACh43eEkwdzIwuVm0KWfoocXqvMkMw== X-Received: by 2002:a05:600c:31a3:b0:3d6:8570:1239 with SMTP id s35-20020a05600c31a300b003d685701239mr32534811wmp.16.1674642838050; Wed, 25 Jan 2023 02:33:58 -0800 (PST) Received: from [192.168.1.9] (95-44-90-175-dynamic.agg2.lod.rsl-rtd.eircom.net. [95.44.90.175]) by smtp.googlemail.com with ESMTPSA id p5-20020a05600c2e8500b003db15b1fb3csm1397501wmn.13.2023.01.25.02.33.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 02:33:57 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 10:33:56 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Subject: Re: bug#61050: mv: add support for --one-file-system Content-Language: en-US To: Paul Eggert , Mike Frysinger References: <959daacf-01b9-c5a4-2b7f-694eada803d3@cs.ucla.edu> From: =?UTF-8?Q?P=C3=A1draig_Brady?= In-Reply-To: <959daacf-01b9-c5a4-2b7f-694eada803d3@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 61050 Cc: 61050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 25/01/2023 09:07, Paul Eggert wrote: > On 2023-01-24 17:20, Mike Frysinger wrote: >> i'd like to require that the mv be >> atomic when relocating a directory, and if it isn't, fallback to other >> logic > > Calling the new option "--one-file-system" sounds a bit wrong, as > --one-file-system is for programs like 'du' and 'cp' and causes them to > not cross a file system boundary when recursing - something that 'mv' > could also do (when it falls back on copying), but which is a different > thing than what you're asking for. > > How about if we call the new option --no-copy instead? Something like > the attached incomplete patch, say. (It needs more documentation and > ideally a test case.) --no-copy is better more general naming. I can see the usefulness of this, so +1 from me. thanks, Pádraig From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 08:34:56 2023 Received: (at 61050) by debbugs.gnu.org; 25 Jan 2023 13:34:56 +0000 Received: from localhost ([127.0.0.1]:58630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKfvU-0008AH-1m for submit@debbugs.gnu.org; Wed, 25 Jan 2023 08:34:56 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:32776 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKfvR-0008A1-9R for 61050@debbugs.gnu.org; Wed, 25 Jan 2023 08:34:54 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id C3F7E340D4F; Wed, 25 Jan 2023 13:34:46 +0000 (UTC) Date: Wed, 25 Jan 2023 08:34:45 -0500 From: Mike Frysinger To: Paul Eggert Subject: Re: bug#61050: mv: add support for --one-file-system Message-ID: References: <959daacf-01b9-c5a4-2b7f-694eada803d3@cs.ucla.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <959daacf-01b9-c5a4-2b7f-694eada803d3@cs.ucla.edu> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 61050 Cc: 61050@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 25 Jan 2023 01:07, Paul Eggert wrote: > On 2023-01-24 17:20, Mike Frysinger wrote: > > i'd like to require that the mv be > > atomic when relocating a directory, and if it isn't, fallback to other > > logic > > Calling the new option "--one-file-system" sounds a bit wrong, as > --one-file-system is for programs like 'du' and 'cp' and causes them to > not cross a file system boundary when recursing - something that 'mv' > could also do (when it falls back on copying), but which is a different > thing than what you're asking for. > > How about if we call the new option --no-copy instead? Something like > the attached incomplete patch, say. (It needs more documentation and > ideally a test case.) either works for me, thanks should there be a `--copy` flag to be able to undo `--no-copy` ? > --- a/src/copy.c > +++ b/src/copy.c > @@ -2617,7 +2617,7 @@ copy_internal (char const *src_name, char const *dst_name, > where you'd replace '18' with the integer in parentheses that > was output from the perl one-liner above. > If necessary, of course, change '/tmp' to some other directory. */ > - if (rename_errno != EXDEV) > + if (rename_errno != EXDEV || x->no_copy) personally i always argue against using negative variable names. it's hard to reason about, and reads like awkward english which requires multiple scans to convince myself that it's correct. but i rarely work on the coreutils code, so feel free to ignore. -mike From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 14:13:42 2023 Received: (at 61050-done) by debbugs.gnu.org; 27 Jan 2023 19:13:42 +0000 Received: from localhost ([127.0.0.1]:38508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLUAP-0004AS-P7 for submit@debbugs.gnu.org; Fri, 27 Jan 2023 14:13:42 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43844) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLUAN-0004AE-CX for 61050-done@debbugs.gnu.org; Fri, 27 Jan 2023 14:13:40 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2DA9B16005C; Fri, 27 Jan 2023 11:13:33 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6RGJywzMB71i; Fri, 27 Jan 2023 11:13:31 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 75F2D160066; Fri, 27 Jan 2023 11:13:31 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu 75F2D160066 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1674846811; bh=XxLN1d6vzCYE5X0/1UkHQvvvP06LNIhPZ2XccfXpRrw=; h=Content-Type:Message-ID:Date:MIME-Version:To:From:Subject; b=OMNh9JWIpd17yad5OyPT7rRYMpjkc5U/jFKvTn03qmhYhW7/MfJ2YwlmXaTUJxzdd fk7AH+tHkD8vlsL5vvehSQ0cYQLMEd1+cGQTHhFwHOnD2iQmlTHfGj0ou9O0TudHE/ 9qbPbnDK7n6bnfwx6WxkdkjuyZN/f9u50UmtLj5E= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id M9whfy2Q8MOK; Fri, 27 Jan 2023 11:13:31 -0800 (PST) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 472A016005C; Fri, 27 Jan 2023 11:13:31 -0800 (PST) Content-Type: multipart/mixed; boundary="------------TcdYt6F3QcoZGa1dbcWVGzz5" Message-ID: <13ba87b0-ffce-7e57-6c1d-536cafe45754@cs.ucla.edu> Date: Fri, 27 Jan 2023 11:13:30 -0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 To: Mike Frysinger References: <959daacf-01b9-c5a4-2b7f-694eada803d3@cs.ucla.edu> Content-Language: en-US From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: bug#61050: mv: add support for --one-file-system In-Reply-To: X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 61050-done Cc: 61050-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) This is a multi-part message in MIME format. --------------TcdYt6F3QcoZGa1dbcWVGzz5 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-01-25 05:34, Mike Frysinger wrote: > should there be a `--copy` flag to be able to undo `--no-copy` ? We can add one if there's a need, but mv doesn't have a --clobber option to match its --no-clobber and I'm hoping --no-copy is similar. > personally i always argue against using negative variable names Yes, I considered calling it "rename_only" instead of "no_copy", but the pull of the --no-copy option's name was too strong. Besides, "rename_only" wasn't quite right either as "mv --no-copy" does more than just renaming (e.g., if the destination is not writeable). If we can come up with a better name now's a good time to switch. In the meantime I installed the attached coreutils patch. --------------TcdYt6F3QcoZGa1dbcWVGzz5 Content-Type: text/x-patch; charset=UTF-8; name="0001-mv-new-option-no-copy.patch" Content-Disposition: attachment; filename="0001-mv-new-option-no-copy.patch" Content-Transfer-Encoding: base64 RnJvbSAyMDAwNWNhNzMzZTExMWE2MTIxMmVlOGE2ODkwYTU0NTgzYzU1NTYyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBGcmksIDI3IEphbiAyMDIzIDEwOjU5OjEzIC0wODAwClN1YmplY3Q6IFtQQVRD SF0gbXY6IG5ldyBvcHRpb24gLS1uby1jb3B5CgpXaXNobGlzdCBpdGVtIGZyb20gTWlrZSBG cnlzaW5nZXIgKEJ1ZyM2MTA1MCkuCiogc3JjL2NvcHkuYyAoY29weV9pbnRlcm5hbCk6CkRv IG5vdCBmYWxsIGJhY2sgb24gY29weWluZyBpZiB4LT5ub19jb3B5LgoqIHNyYy9jb3B5Lmgg KHN0cnVjdCBjcF9vcHRpb25zKTogTmV3IG1lbWJlciBub19jb3B5LgoqIHNyYy9tdi5jIChO T19DT1BZX09QVElPTik6IE5ldyBjb25zdGFudC4KKGxvbmdfb3B0aW9ucywgdXNhZ2UsIG1h aW4pOiBTdXBwb3J0IC0tbm8tY29weS4KKiB0ZXN0cy9tdi9uby1jb3B5LnNoOiBOZXcgdGVz dC4KKiB0ZXN0cy9sb2NhbC5tayAoYWxsX3Rlc3RzKTogQWRkIGl0LgotLS0KIE5FV1MgICAg ICAgICAgICAgICAgfCAgMyArKysKIGRvYy9jb3JldXRpbHMudGV4aSAgfCAyNyArKysrKysr KysrKysrKystLS0tLS0tLS0tLS0KIHNyYy9jb3B5LmMgICAgICAgICAgfCAgMiArLQogc3Jj L2NvcHkuaCAgICAgICAgICB8ICA2ICsrKy0tLQogc3JjL212LmMgICAgICAgICAgICB8ICA4 ICsrKysrKystCiB0ZXN0cy9sb2NhbC5tayAgICAgIHwgIDEgKwogdGVzdHMvbXYvbm8tY29w eS5zaCB8IDMzICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogNyBmaWxlcyBj aGFuZ2VkLCA2MyBpbnNlcnRpb25zKCspLCAxNyBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2Rl IDEwMDc1NSB0ZXN0cy9tdi9uby1jb3B5LnNoCgpkaWZmIC0tZ2l0IGEvTkVXUyBiL05FV1MK aW5kZXggOTU5NDE3OWI0Li5kNzE0YjhmM2IgMTAwNjQ0Ci0tLSBhL05FV1MKKysrIGIvTkVX UwpAQCAtOTUsNiArOTUsOSBAQCBHTlUgY29yZXV0aWxzIE5FV1MgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAtKi0gb3V0bGluZSAtKi0KICAgbHMgbm93IHN1cHBvcnRz IHRoZSAtLXRpbWU9bW9kaWZpY2F0aW9uIG9wdGlvbiwgdG8gZXhwbGljaXRseQogICBzZWxl Y3QgdGhlIGRlZmF1bHQgbXRpbWUgdGltZXN0YW1wIGZvciBkaXNwbGF5IGFuZCBzb3J0aW5n LgogCisgIG12IG5vdyBzdXBwb3J0cyB0aGUgLS1uby1jb3B5IG9wdGlvbiwgd2hpY2ggY2F1 c2VzIGl0IHRvIGZhaWwgd2hlbgorICBhc2tlZCB0byBtb3ZlIGEgZmlsZSB0byBhIGRpZmZl cmVudCBmaWxlIHN5c3RlbS4KKwogICB3YyBub3cgYWNjZXB0cyB0aGUgLS10b3RhbD17YXV0 byxuZXZlcixhbHdheXMsb25seX0gb3B0aW9uCiAgIHRvIGdpdmUgZXhwbGljaXQgY29udHJv bCBvdmVyIHdoZW4gdGhlIHRvdGFsIGlzIG91dHB1dC4KIApkaWZmIC0tZ2l0IGEvZG9jL2Nv cmV1dGlscy50ZXhpIGIvZG9jL2NvcmV1dGlscy50ZXhpCmluZGV4IGY1ZTUzMWQ2NS4uYzc0 OTRiYTQ3IDEwMDY0NAotLS0gYS9kb2MvY29yZXV0aWxzLnRleGkKKysrIGIvZG9jL2NvcmV1 dGlscy50ZXhpCkBAIC0xMDAzOCwxOSArMTAwMzgsMTYgQEAgZmFpbGluZyB0aGF0IGlmIHRo ZSBsYXN0IGZpbGUgaXMgYSBkaXJlY3RvcnkgYW5kIHRoZQogZGlyZWN0b3J5LCB1c2luZyB0 aGUgQHZhcntzb3VyY2V9cycgbmFtZXMuCiBAZW5kIGl0ZW1pemUKIAotQGNvbW1hbmR7bXZ9 IGNhbiBtb3ZlIGFueSB0eXBlIG9mIGZpbGUgZnJvbSBvbmUgZmlsZSBzeXN0ZW0gdG8gYW5v dGhlci4KLVByaW9yIHRvIHZlcnNpb24gQGNvZGV7NC4wfSBvZiB0aGUgZmlsZXV0aWxzLAot QGNvbW1hbmR7bXZ9IGNvdWxkIG1vdmUgb25seSByZWd1bGFyIGZpbGVzIGJldHdlZW4gZmls ZSBzeXN0ZW1zLgotRm9yIGV4YW1wbGUsIG5vdyBAY29tbWFuZHttdn0gY2FuIG1vdmUgYW4g ZW50aXJlIGRpcmVjdG9yeSBoaWVyYXJjaHkKLWluY2x1ZGluZyBzcGVjaWFsIGRldmljZSBm aWxlcyBmcm9tIG9uZSBwYXJ0aXRpb24gdG8gYW5vdGhlci4gIEl0IGZpcnN0Ci11c2VzIHNv bWUgb2YgdGhlIHNhbWUgY29kZSB0aGF0J3MgdXNlZCBieSBAY29kZXtjcCAtYX0gdG8gY29w eSB0aGUKLXJlcXVlc3RlZCBkaXJlY3RvcmllcyBhbmQgZmlsZXMsIHRoZW4gKGFzc3VtaW5n IHRoZSBjb3B5IHN1Y2NlZWRlZCkKLWl0IHJlbW92ZXMgdGhlIG9yaWdpbmFscy4gIElmIHRo ZSBjb3B5IGZhaWxzLCB0aGVuIHRoZSBwYXJ0IHRoYXQgd2FzCi1jb3BpZWQgdG8gdGhlIGRl c3RpbmF0aW9uIHBhcnRpdGlvbiBpcyByZW1vdmVkLiAgSWYgeW91IHdlcmUgdG8gY29weQot dGhyZWUgZGlyZWN0b3JpZXMgZnJvbSBvbmUgcGFydGl0aW9uIHRvIGFub3RoZXIgYW5kIHRo ZSBjb3B5IG9mIHRoZSBmaXJzdAorVG8gbW92ZSBhIGZpbGUsIEBjb21tYW5ke212fSBvcmRp bmFyaWx5IHNpbXBseSByZW5hbWVzIGl0LgorSG93ZXZlciwgaWYgcmVuYW1pbmcgZG9lcyBu b3Qgd29yayBiZWNhdXNlIHRoZSBkZXN0aW5hdGlvbidzIGZpbGUKK3N5c3RlbSBkaWZmZXJz LCBAY29tbWFuZHttdn0gZmFsbHMgYmFjayBvbiBjb3B5aW5nIGFzIGlmIGJ5IEBjb2Rle2Nw IC1hfSwKK3RoZW4gKGFzc3VtaW5nIHRoZSBjb3B5IHN1Y2NlZWRlZCkgaXQgcmVtb3ZlcyB0 aGUgb3JpZ2luYWwuCitJZiB0aGUgY29weSBmYWlscywgdGhlbiBAY29tbWFuZHttdn0gcmVt b3ZlcyBhbnkgcGFydGlhbGx5IGNyZWF0ZWQKK2NvcHkgaW4gdGhlIGRlc3RpbmF0aW9uLiAg SWYgeW91IHdlcmUgdG8gY29weSB0aHJlZSBkaXJlY3RvcmllcyBmcm9tCitvbmUgZmlsZSBz eXN0ZW0gdG8gYW5vdGhlciBhbmQgdGhlIGNvcHkgb2YgdGhlIGZpcnN0CiBkaXJlY3Rvcnkg c3VjY2VlZGVkLCBidXQgdGhlIHNlY29uZCBkaWRuJ3QsIHRoZSBmaXJzdCB3b3VsZCBiZSBs ZWZ0IG9uCi10aGUgZGVzdGluYXRpb24gcGFydGl0aW9uIGFuZCB0aGUgc2Vjb25kIGFuZCB0 aGlyZCB3b3VsZCBiZSBsZWZ0IG9uIHRoZQotb3JpZ2luYWwgcGFydGl0aW9uLgordGhlIGRl c3RpbmF0aW9uIGZpbGUgc3lzdGVtIGFuZCB0aGUgc2Vjb25kIGFuZCB0aGlyZCB3b3VsZCBi ZSBsZWZ0IG9uIHRoZQorb3JpZ2luYWwgZmlsZSBzeXN0ZW0uCiAKIEBjaW5kZXggZXh0ZW5k ZWQgYXR0cmlidXRlcywgeGF0dHIKIEBjb21tYW5ke212fSBhbHdheXMgdHJpZXMgdG8gY29w eSBleHRlbmRlZCBhdHRyaWJ1dGVzICh4YXR0ciksIHdoaWNoIG1heQpAQCAtMTAxMTQsNiAr MTAxMTEsMTIgQEAgRG8gbm90IG92ZXJ3cml0ZSBhbiBleGlzdGluZyBmaWxlOyBzaWxlbnRs eSBkbyBub3RoaW5nIGluc3RlYWQuCiBAbXZPcHRzSWZuCiBUaGlzIG9wdGlvbiBpcyBtdXR1 YWxseSBleGNsdXNpdmUgd2l0aCBAb3B0aW9uey1ifSBvciBAb3B0aW9uey0tYmFja3VwfSBv cHRpb24uCiAKK0BpdGVtIC0tbm8tY29weQorQG9waW5kZXggLS1uby1jb3B5CitAY2luZGV4 IHJlbmFtaW5nIGZpbGVzIHdpdGhvdXQgY29weWluZyB0aGVtCitJZiBhIGZpbGUgY2Fubm90 IGJlIHJlbmFtZWQgYmVjYXVzZSB0aGUgZGVzdGluYXRpb24gZmlsZSBzeXN0ZW0gZGlmZmVy cywKK2ZhaWwgd2l0aCBhIGRpYWdub3N0aWMgaW5zdGVhZCBvZiBjb3B5aW5nIGFuZCB0aGVu IHJlbW92aW5nIHRoZSBmaWxlLgorCiBAaXRlbSAtdQogQGl0ZW14IC0tdXBkYXRlCiBAb3Bp bmRleCAtdQpkaWZmIC0tZ2l0IGEvc3JjL2NvcHkuYyBiL3NyYy9jb3B5LmMKaW5kZXggOThm MmJhNDVhLi45OTgzNDQzNGYgMTAwNjQ0Ci0tLSBhL3NyYy9jb3B5LmMKKysrIGIvc3JjL2Nv cHkuYwpAQCAtMjYxNyw3ICsyNjE3LDcgQEAgY29weV9pbnRlcm5hbCAoY2hhciBjb25zdCAq c3JjX25hbWUsIGNoYXIgY29uc3QgKmRzdF9uYW1lLAogICAgICAgICAgd2hlcmUgeW91J2Qg cmVwbGFjZSAnMTgnIHdpdGggdGhlIGludGVnZXIgaW4gcGFyZW50aGVzZXMgdGhhdAogICAg ICAgICAgd2FzIG91dHB1dCBmcm9tIHRoZSBwZXJsIG9uZS1saW5lciBhYm92ZS4KICAgICAg ICAgIElmIG5lY2Vzc2FyeSwgb2YgY291cnNlLCBjaGFuZ2UgJy90bXAnIHRvIHNvbWUgb3Ro ZXIgZGlyZWN0b3J5LiAgKi8KLSAgICAgIGlmIChyZW5hbWVfZXJybm8gIT0gRVhERVYpCisg ICAgICBpZiAocmVuYW1lX2Vycm5vICE9IEVYREVWIHx8IHgtPm5vX2NvcHkpCiAgICAgICAg IHsKICAgICAgICAgICAvKiBUaGVyZSBhcmUgbWFueSB3YXlzIHRoaXMgY2FuIGhhcHBlbiBk dWUgdG8gYSByYWNlIGNvbmRpdGlvbi4KICAgICAgICAgICAgICBXaGVuIHNvbWV0aGluZyBo YXBwZW5zIGJldHdlZW4gdGhlIGluaXRpYWwgZm9sbG93X2ZzdGF0YXQgYW5kIHRoZQpkaWZm IC0tZ2l0IGEvc3JjL2NvcHkuaCBiL3NyYy9jb3B5LmgKaW5kZXggZDc3NWRiMDQ3Li45ZDM4 ODQ0MDMgMTAwNjQ0Ci0tLSBhL3NyYy9jb3B5LmgKKysrIGIvc3JjL2NvcHkuaApAQCAtMTM0 LDkgKzEzNCw5IEBAIHN0cnVjdCBjcF9vcHRpb25zCiAgICAgIENyZWF0ZSBkZXN0aW5hdGlv biBkaXJlY3RvcmllcyBhcyB1c3VhbC4gKi8KICAgYm9vbCBoYXJkX2xpbms7CiAKLSAgLyog SWYgdHJ1ZSwgcmF0aGVyIHRoYW4gY29weWluZywgZmlyc3QgYXR0ZW1wdCB0byB1c2UgcmVu YW1lLgotICAgICBJZiB0aGF0IGZhaWxzLCB0aGVuIHJlc29ydCB0byBjb3B5aW5nLiAgKi8K LSAgYm9vbCBtb3ZlX21vZGU7CisgIC8qIElmIE1PVkVfTU9ERSwgZmlyc3QgdHJ5IHRvIHJl bmFtZS4KKyAgICAgSWYgdGhhdCBmYWlscyBhbmQgTk9fQ09QWSwgZmFpbCBpbnN0ZWFkIG9m IGNvcHlpbmcuICAqLworICBib29sIG1vdmVfbW9kZSwgbm9fY29weTsKIAogICAvKiBJZiB0 cnVlLCBpbnN0YWxsKDEpIGlzIHRoZSBjYWxsZXIuICAqLwogICBib29sIGluc3RhbGxfbW9k ZTsKZGlmZiAtLWdpdCBhL3NyYy9tdi5jIGIvc3JjL212LmMKaW5kZXggNzJiYmU4ZTQ2Li5m MjdhMDdhMWMgMTAwNjQ0Ci0tLSBhL3NyYy9tdi5jCisrKyBiL3NyYy9tdi5jCkBAIC00OCw3 ICs0OCw4IEBACiAgICBub24tY2hhcmFjdGVyIGFzIGEgcHNldWRvIHNob3J0IG9wdGlvbiwg c3RhcnRpbmcgd2l0aCBDSEFSX01BWCArIDEuICAqLwogZW51bQogewotICBTVFJJUF9UUkFJ TElOR19TTEFTSEVTX09QVElPTiA9IENIQVJfTUFYICsgMQorICBOT19DT1BZX09QVElPTiA9 IENIQVJfTUFYICsgMSwKKyAgU1RSSVBfVFJBSUxJTkdfU0xBU0hFU19PUFRJT04KIH07CiAK IHN0YXRpYyBzdHJ1Y3Qgb3B0aW9uIGNvbnN0IGxvbmdfb3B0aW9uc1tdID0KQEAgLTU4LDYg KzU5LDcgQEAgc3RhdGljIHN0cnVjdCBvcHRpb24gY29uc3QgbG9uZ19vcHRpb25zW10gPQog ICB7ImZvcmNlIiwgbm9fYXJndW1lbnQsIE5VTEwsICdmJ30sCiAgIHsiaW50ZXJhY3RpdmUi LCBub19hcmd1bWVudCwgTlVMTCwgJ2knfSwKICAgeyJuby1jbG9iYmVyIiwgbm9fYXJndW1l bnQsIE5VTEwsICduJ30sCisgIHsibm8tY29weSIsIG5vX2FyZ3VtZW50LCBOVUxMLCBOT19D T1BZX09QVElPTn0sCiAgIHsibm8tdGFyZ2V0LWRpcmVjdG9yeSIsIG5vX2FyZ3VtZW50LCBO VUxMLCAnVCd9LAogICB7InN0cmlwLXRyYWlsaW5nLXNsYXNoZXMiLCBub19hcmd1bWVudCwg TlVMTCwgU1RSSVBfVFJBSUxJTkdfU0xBU0hFU19PUFRJT059LAogICB7InN1ZmZpeCIsIHJl cXVpcmVkX2FyZ3VtZW50LCBOVUxMLCAnUyd9LApAQCAtMjYwLDYgKzI2Miw3IEBAIFJlbmFt ZSBTT1VSQ0UgdG8gREVTVCwgb3IgbW92ZSBTT1VSQ0UocykgdG8gRElSRUNUT1JZLlxuXAog SWYgeW91IHNwZWNpZnkgbW9yZSB0aGFuIG9uZSBvZiAtaSwgLWYsIC1uLCBvbmx5IHRoZSBm aW5hbCBvbmUgdGFrZXMgZWZmZWN0LlxuXAogIiksIHN0ZG91dCk7CiAgICAgICBmcHV0cyAo XygiXAorICAgICAgLS1uby1jb3B5ICAgICAgICAgICAgICAgIGRvIG5vdCBjb3B5IGlmIHJl bmFtaW5nIGZhaWxzXG5cCiAgICAgICAtLXN0cmlwLXRyYWlsaW5nLXNsYXNoZXMgIHJlbW92 ZSBhbnkgdHJhaWxpbmcgc2xhc2hlcyBmcm9tIGVhY2ggU09VUkNFXG5cCiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBhcmd1bWVudFxuXAogICAtUywgLS1zdWZmaXg9U1VG RklYICAgICAgICAgIG92ZXJyaWRlIHRoZSB1c3VhbCBiYWNrdXAgc3VmZml4XG5cCkBAIC0z MzAsNiArMzMzLDkgQEAgbWFpbiAoaW50IGFyZ2MsIGNoYXIgKiphcmd2KQogICAgICAgICBj YXNlICduJzoKICAgICAgICAgICB4LmludGVyYWN0aXZlID0gSV9BTFdBWVNfTk87CiAgICAg ICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgTk9fQ09QWV9PUFRJT046CisgICAgICAgICAg eC5ub19jb3B5ID0gdHJ1ZTsKKyAgICAgICAgICBicmVhazsKICAgICAgICAgY2FzZSBTVFJJ UF9UUkFJTElOR19TTEFTSEVTX09QVElPTjoKICAgICAgICAgICByZW1vdmVfdHJhaWxpbmdf c2xhc2hlcyA9IHRydWU7CiAgICAgICAgICAgYnJlYWs7CmRpZmYgLS1naXQgYS90ZXN0cy9s b2NhbC5tayBiL3Rlc3RzL2xvY2FsLm1rCmluZGV4IDg2OTA4ZWY0Zi4uZjZlMzc0NmI2IDEw MDY0NAotLS0gYS90ZXN0cy9sb2NhbC5taworKysgYi90ZXN0cy9sb2NhbC5tawpAQCAtNjg2 LDYgKzY4Niw3IEBAIGFsbF90ZXN0cyA9CQkJCQlcCiAgIHRlc3RzL212L2xlYWstZmQuc2gJ CQkJXAogICB0ZXN0cy9tdi9tdi1uLnNoCQkJCVwKICAgdGVzdHMvbXYvbXYtc3BlY2lhbC0x LnNoCQkJXAorICB0ZXN0cy9tdi9uby1jb3B5LnNoCQkJCVwKICAgdGVzdHMvbXYvbm8tdGFy Z2V0LWRpci5zaAkJCVwKICAgdGVzdHMvbXYvcGFydC1mYWlsLnNoCQkJCVwKICAgdGVzdHMv bXYvcGFydC1oYXJkbGluay5zaAkJCVwKZGlmZiAtLWdpdCBhL3Rlc3RzL212L25vLWNvcHku c2ggYi90ZXN0cy9tdi9uby1jb3B5LnNoCm5ldyBmaWxlIG1vZGUgMTAwNzU1CmluZGV4IDAw MDAwMDAwMC4uZmJhNDc1YzAzCi0tLSAvZGV2L251bGwKKysrIGIvdGVzdHMvbXYvbm8tY29w eS5zaApAQCAtMCwwICsxLDMzIEBACisjIS9iaW4vc2gKKyMgVGVzdCBtdiAtLW5vLWNvcHku CisKKyMgQ29weXJpZ2h0IChDKSAyMDIzIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwgSW5j LgorCisjIFRoaXMgcHJvZ3JhbSBpcyBmcmVlIHNvZnR3YXJlOiB5b3UgY2FuIHJlZGlzdHJp YnV0ZSBpdCBhbmQvb3IgbW9kaWZ5CisjIGl0IHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05V IEdlbmVyYWwgUHVibGljIExpY2Vuc2UgYXMgcHVibGlzaGVkIGJ5CisjIHRoZSBGcmVlIFNv ZnR3YXJlIEZvdW5kYXRpb24sIGVpdGhlciB2ZXJzaW9uIDMgb2YgdGhlIExpY2Vuc2UsIG9y CisjIChhdCB5b3VyIG9wdGlvbikgYW55IGxhdGVyIHZlcnNpb24uCisKKyMgVGhpcyBwcm9n cmFtIGlzIGRpc3RyaWJ1dGVkIGluIHRoZSBob3BlIHRoYXQgaXQgd2lsbCBiZSB1c2VmdWws CisjIGJ1dCBXSVRIT1VUIEFOWSBXQVJSQU5UWTsgd2l0aG91dCBldmVuIHRoZSBpbXBsaWVk IHdhcnJhbnR5IG9mCisjIE1FUkNIQU5UQUJJTElUWSBvciBGSVRORVNTIEZPUiBBIFBBUlRJ Q1VMQVIgUFVSUE9TRS4gIFNlZSB0aGUKKyMgR05VIEdlbmVyYWwgUHVibGljIExpY2Vuc2Ug Zm9yIG1vcmUgZGV0YWlscy4KKworIyBZb3Ugc2hvdWxkIGhhdmUgcmVjZWl2ZWQgYSBjb3B5 IG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMgTGljZW5zZQorIyBhbG9uZyB3aXRoIHRoaXMg cHJvZ3JhbS4gIElmIG5vdCwgc2VlIDxodHRwczovL3d3dy5nbnUub3JnL2xpY2Vuc2VzLz4u CisKKy4gIiR7c3JjZGlyPS59L3Rlc3RzL2luaXQuc2giOyBwYXRoX3ByZXBlbmRfIC4vc3Jj CitwcmludF92ZXJfIG12CitjbGVhbnVwXygpIHsgcm0gLXJmICIkb3RoZXJfcGFydGl0aW9u X3RtcGRpciI7IH0KKy4gIiRhYnNfc3JjZGlyL3Rlc3RzL290aGVyLWZzLXRtcGRpciIKKwor bWtkaXIgZGlyIHx8IGZyYW1ld29ya19mYWlsdXJlXworPiBkaXIvYSB8fCBmcmFtZXdvcmtf ZmFpbHVyZV8KKz4gZmlsZSB8fCBmcmFtZXdvcmtfZmFpbHVyZV8KKworbXYgLS1uby1jb3B5 IGRpciAiJG90aGVyX3BhcnRpdGlvbl90bXBkaXIiICYmIGZhaWw9MQorbXYgLS1uby1jb3B5 IGZpbGUgIiRvdGhlcl9wYXJ0aXRpb25fdG1wZGlyIiAmJiBmYWlsPTEKK212IGRpciAiJG90 aGVyX3BhcnRpdGlvbl90bXBkaXIiIHx8IGZhaWw9MQorbXYgZmlsZSAiJG90aGVyX3BhcnRp dGlvbl90bXBkaXIiIHx8IGZhaWw9MQorCitFeGl0ICRmYWlsCi0tIAoyLjM3LjIKCg== --------------TcdYt6F3QcoZGa1dbcWVGzz5-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 27 14:50:31 2023 Received: (at 61050) by debbugs.gnu.org; 27 Jan 2023 19:50:31 +0000 Received: from localhost ([127.0.0.1]:38542 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLUk3-0005BE-4J for submit@debbugs.gnu.org; Fri, 27 Jan 2023 14:50:31 -0500 Received: from mail-wm1-f53.google.com ([209.85.128.53]:35525) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLUjz-0005Av-CG for 61050@debbugs.gnu.org; Fri, 27 Jan 2023 14:50:29 -0500 Received: by mail-wm1-f53.google.com with SMTP id fl11-20020a05600c0b8b00b003daf72fc844so6112065wmb.0 for <61050@debbugs.gnu.org>; Fri, 27 Jan 2023 11:50:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Z9F+8d0P1lbT3iGjGq7uK+ljHNm68F/P0LApkx87o0o=; b=oZvgNiDmzOTYsA5VJqXfGPzgOGI/md6M3r4+8GQCTBcariwe3YKd5l3/bEwQRYuPhB N/in+t08spam0Zf6ImKiO/kUgMCmHWrXNDZGXnfXFjDQJb+l20AvK590k90EHodyyuTS ruM2mbDrsQOyue/g0cA6dY4QmUMZ3OigvEsYiE+ENIx9/WMvMCS7CsXpxDEAm4GXZDSl bYGW7YWap2R8CdoWgGh+hpwL793asZxxUdGkMq8DSRAYMKlCUcMceh4J7GPM+0nCLC7D 45+gUuOXK/4CtATuqKD+Po0qSbOZCayFf7j2AlzcG0AbSNXRk3RGnbuGs76ieE/f45DY By8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Z9F+8d0P1lbT3iGjGq7uK+ljHNm68F/P0LApkx87o0o=; b=jhpxfADk9vdjOIAEJRuX+Ko5oiYGG2jdzWfo/BF9IIeOVvPXW9LrsOa75l4tbZQMRr toWDO3g1zLSBHu1n9jQb7fOkUZzqScmyCG+fYMWSNLZIUeM5zM1GWWPVuILDrM0qKnop mL2MVNH8m9VmDaRluCeH8vVfnNyYM+gKNNO1QSQb0FI6E1JfZ168Mbs6grtRe+YAMlo+ Jdl+hKm7WlUJzHF697hFDEykE5vEy2/MrkYsoCCLrJiGHlcswsueHhz8xqgpjWbB/Ogj /VAdA6OEWzUfvJGi1cX8WkGbopSg/ril01i1Vq5UQwAxzuhZF0SMClaDhwMMxUQ0HtfL svlA== X-Gm-Message-State: AFqh2kp9XaYE/QWEWQ7/MUIznEI6fhbvegK6dGUGnQpavSRQt7KXojMC ByA47RZTZwDiDTpIb4EwiJsT5SsMpLY= X-Google-Smtp-Source: AMrXdXtB1WBJKqdwpup8ACOkMKOqENQSnabFRMBiGh8SXuZOlwIUIN4lR1UMhWhP4DS9TElpKyNDSw== X-Received: by 2002:a05:600c:1e09:b0:3d1:f16d:5848 with SMTP id ay9-20020a05600c1e0900b003d1f16d5848mr40788821wmb.26.1674849021047; Fri, 27 Jan 2023 11:50:21 -0800 (PST) Received: from [192.168.1.9] (95-44-90-175-dynamic.agg2.lod.rsl-rtd.eircom.net. [95.44.90.175]) by smtp.googlemail.com with ESMTPSA id az26-20020a05600c601a00b003d99469ece1sm8863340wmb.24.2023.01.27.11.50.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Jan 2023 11:50:20 -0800 (PST) Message-ID: Date: Fri, 27 Jan 2023 19:50:18 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Subject: Re: bug#61050: mv: add support for --one-file-system Content-Language: en-US To: 61050@debbugs.gnu.org, eggert@cs.ucla.edu, vapier@gentoo.org References: <959daacf-01b9-c5a4-2b7f-694eada803d3@cs.ucla.edu> <13ba87b0-ffce-7e57-6c1d-536cafe45754@cs.ucla.edu> From: =?UTF-8?Q?P=C3=A1draig_Brady?= In-Reply-To: <13ba87b0-ffce-7e57-6c1d-536cafe45754@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 61050 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 27/01/2023 19:13, Paul Eggert wrote: > On 2023-01-25 05:34, Mike Frysinger wrote: >> should there be a `--copy` flag to be able to undo `--no-copy` ? > > We can add one if there's a need, but mv doesn't have a --clobber option > to match its --no-clobber and I'm hoping --no-copy is similar. > >> personally i always argue against using negative variable names > > Yes, I considered calling it "rename_only" instead of "no_copy", but the > pull of the --no-copy option's name was too strong. Besides, > "rename_only" wasn't quite right either as "mv --no-copy" does more than > just renaming (e.g., if the destination is not writeable). > > If we can come up with a better name now's a good time to switch. In the > meantime I installed the attached coreutils patch. Looks good. I pushed this tweak. thanks, Pádraig commit 95bc69a7e71dd2a9b2ca11452be19fa856eb2bbf (HEAD -> master) Author: Pádraig Brady Date: Fri Jan 27 19:46:52 2023 +0000 tests: ensure we fail if mv --no-copy crashes * tests/mv/no-copy.sh: Honor `make syntax` check and use the `returns_ 1 ...` pattern. diff --git a/tests/mv/no-copy.sh b/tests/mv/no-copy.sh index fba475c03..5a55fdf74 100755 --- a/tests/mv/no-copy.sh +++ b/tests/mv/no-copy.sh @@ -25,8 +25,8 @@ mkdir dir || framework_failure_ > dir/a || framework_failure_ > file || framework_failure_ -mv --no-copy dir "$other_partition_tmpdir" && fail=1 -mv --no-copy file "$other_partition_tmpdir" && fail=1 +returns_ 1 mv --no-copy dir "$other_partition_tmpdir" || fail=1 +returns_ 1 mv --no-copy file "$other_partition_tmpdir" || fail=1 mv dir "$other_partition_tmpdir" || fail=1 mv file "$other_partition_tmpdir" || fail=1 From unknown Mon Jun 16 23:44:31 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 25 Feb 2023 12:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator