From unknown Wed Jun 18 23:13:37 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#61038 <61038@debbugs.gnu.org> To: bug#61038 <61038@debbugs.gnu.org> Subject: Status: 30.0.50; `project-query-replace-regexp' also attempts search and replace in auto-save files Reply-To: bug#61038 <61038@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:13:37 +0000 retitle 61038 30.0.50; `project-query-replace-regexp' also attempts search = and replace in auto-save files reassign 61038 emacs submitter 61038 Mickey Petersen severity 61038 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 05:43:06 2023 Received: (at submit) by debbugs.gnu.org; 24 Jan 2023 10:43:06 +0000 Received: from localhost ([127.0.0.1]:55954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKGld-0006LJ-KF for submit@debbugs.gnu.org; Tue, 24 Jan 2023 05:43:05 -0500 Received: from lists.gnu.org ([209.51.188.17]:48970) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKGlc-0006LC-6X for submit@debbugs.gnu.org; Tue, 24 Jan 2023 05:43:04 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKGlY-0003of-Ma for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 05:43:02 -0500 Received: from mail-lo2gbr01on0711.outbound.protection.outlook.com ([2a01:111:f400:fe15::711] helo=GBR01-LO2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKGlU-00050z-0a for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 05:42:59 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=guEU7cbraRW86br2u2a/OZ1qdxGlFya7OmzX0iYLFBPS+Gfl26fvd0T4qhJL+C7D3X+djyQAUO1wbZpSa6el1ZGrD5UGniClgc2FEOLaxYaebx3g5b6IuXThagf5KnfzvCEYNZJVrN57N5b4v/p8u3Rgct4J7wnGENK6FCXmMMCa4nuPysfocZPSce8w+LFn+fEm/7PEdy5ugQYy0ClNQ2SRnHZV5LDUDHxmJicG1oJvXTSZ9N0zVl1aJyW+hnqZWNUqjxEKsEyYbufqzf5AladBSULKyc9hxLbUG8Mf4LMXg+eTt5T3lj2qn1+BaQeZBJULwtTxrnSix2jmCR99FQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1PURfWEVIeW6w2vkNEY45ouhdTWNBH/5Z4BBenetAcM=; b=V8mgt5JVUxJxGeh+KFOR+7DoN0ShwkMlQQuvdT4v6ueK2YB92MGelNBngpNZDPqAlqQ3rsp6YeAc3dIE5j85jaUjieaIilgHVrP3JKg8VtxOOA7r4fV6pju1gPL10NUhHKKLEJeORemgFmKPcTJHM0sdM/93WEFRWEB3uGLhGYvIKrFYieCJkqBdggMotyYnA+FdiLH61fHrDY8m10K/PkY7AyAw37Ncc/5vxhdB7PBdlM0kqLIvEYxb9hcBHO7giQmmcbDPz7f8bItaNW76z4DkDZ5wOjHLvwUTPLGli1rAqMqpFcBxI9yGCGylC4+a38INU9ecEemAc2zYjTfBPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 178.79.136.144) smtp.rcpttodomain=gnu.org smtp.mailfrom=masteringemacs.org; dmarc=pass (p=none sp=none pct=100) action=none header.from=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semantical.onmicrosoft.com; s=selector1-semantical-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1PURfWEVIeW6w2vkNEY45ouhdTWNBH/5Z4BBenetAcM=; b=fXOCuo8W00rdpumxM+vo4M6qlyoc/RR0S0eL4BDrn62avLMcPFJnOHZuDiI7zd/Lg5TNMYDAxynUo/gPF6eWO72jGUMa4sJp9Zyw51Rwux1425vjdpkcFBKEwI0ao9XoSnWKs4qhDcYQPq2SCf2dqh/Q+Wqv0Vivu5VwWnvHVBc= Received: from CWLP123CA0085.GBRP123.PROD.OUTLOOK.COM (2603:10a6:401:5b::25) by LO0P265MB5876.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:261::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33; Tue, 24 Jan 2023 10:37:50 +0000 Received: from CWLGBR01FT035.eop-gbr01.prod.protection.outlook.com (2603:10a6:401:5b:cafe::80) by CWLP123CA0085.outlook.office365.com (2603:10a6:401:5b::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33 via Frontend Transport; Tue, 24 Jan 2023 10:37:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 178.79.136.144) smtp.mailfrom=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org;dmarc=pass action=none header.from=masteringemacs.org; Received-SPF: Pass (protection.outlook.com: domain of masteringemacs.org designates 178.79.136.144 as permitted sender) receiver=protection.outlook.com; client-ip=178.79.136.144; helo=semantical.co.uk; pr=C Received: from semantical.co.uk (178.79.136.144) by CWLGBR01FT035.mail.protection.outlook.com (10.152.40.163) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6023.16 via Frontend Transport; Tue, 24 Jan 2023 10:37:48 +0000 Received: by semantical.co.uk (Postfix, from userid 5001) id BC0A6114001; Tue, 24 Jan 2023 10:37:47 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=masteringemacs.org; s=masteringemacs.org; t=1674556667; bh=1PURfWEVIeW6w2vkNEY45ouhdTWNBH/5Z4BBenetAcM=; h=From:To:Subject:Date:From; b=x5Qd/nhtlcQ/ywIU0fFAfmsn4Ek+VaOPPe5+EYE1JNkr52KTFaJ6jekSfodZBs+we pmz239hHQd8QY3uDh5eHfyBNpWAwefgwZhdlX2tzpMn6gt/Ddfx3N2mi/DLw+UcB9w 1Aq0qbrcTpDKl1VciKSNGBZlSH+zgSAYYGcJExSo= X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on semantical.co.uk X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RECEIVED, NO_RELAYS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 From: Mickey Petersen To: bug-gnu-emacs@gnu.org Subject: 30.0.50; `project-query-replace-regexp' also attempts search and replace in auto-save files Date: Tue, 24 Jan 2023 10:37:44 +0000 Message-ID: <87y1psw747.fsf@masteringemacs.org> Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLGBR01FT035:EE_|LO0P265MB5876:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 6a94a501-0b77-4475-55f9-08dafdf7094a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: VDRHIQ08z1cRPDlwDXYq4fy6Go4UaX1N7gGGkULNvxA4DT5nsXpbsyCF25DXcbVfNHANz4439ts6e5WlkGdenly0qI2jLr3Ij57LctdmEbpyk8PkMRS+lne/OAu29suHia8or6vN3p+0f1efiDWoeYvw1dj1XtcrKlJ5C3gYsUXx6yP5IKd3nHnrc3Db1YsyX9xO1NvEqyAn+dkP0xW2P8ENDAM7Rf9vRE2uV7JWIW78OX2UqJjufBqYYHmSpqC+WD5887klnX/Df92bVzVSNYrHajf5/6/bBChnQRcbN3RCEVvjbWwK/oBHj0oPI/5+D2QBSd1WTm5AZt6rdp7J/atrohcoiplok0qyx0hnuUsJ77H6xUCE4LJuxXHjUfmEjV+aRxUSiCF88zRTamdBs9/POt/3icNyq0mPZPnuT0v0g1udcotKC9/K/NAV5+IbgjMrLUC9P42qxCufrR2/jWiZVq6xDuqEfXwZLrXKTNB2vvxOK3r6k6JF8JBel7CWcdwqeRcsurtgNtsNKdvmdRtl/uQsI8Ue26jKht/DhN8CLPTw2kXsALAPPE0eq0gZ0yzqakqcoGqgaxHBBi/ARaZv6UNZVMWymxD2KeaPK6070g2Ef5A6i+iTGo+U0oC2vkotNgebIjXQFY/1VG1QNc6swnfnq32fxcA42E1mYF3FUaD2QaJDTTEBXFjG3XNJ8OborT12ERCPczjp3E/AslXECojPX1cCgah5W8wHbvkxgALXbZ5Ql3mm2nk2mlHYZyHEgL62FvG0jy6GQBQD3w== X-Forefront-Antispam-Report: CIP:178.79.136.144; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:semantical.co.uk; PTR:semantical.co.uk; CAT:NONE; SFS:(13230022)(39830400003)(346002)(136003)(376002)(396003)(451199015)(46966006)(36840700001)(7596003)(7636003)(356005)(36756003)(40480700001)(82310400005)(86362001)(478600001)(316002)(336012)(70586007)(70206006)(6916009)(8676002)(47076005)(2616005)(36860700001)(42186006)(2906002)(6666004)(5660300002)(186003)(26005)(6266002)(41300700001)(4744005)(8936002)(38230200001)(81973001)(14776008)(79816003); DIR:OUT; SFP:1102; X-OriginatorOrg: masteringemacs.org X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Jan 2023 10:37:48.0493 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6a94a501-0b77-4475-55f9-08dafdf7094a X-MS-Exchange-CrossTenant-Id: a4e27e3d-bab0-45e8-8942-e64cf9fbd34f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a4e27e3d-bab0-45e8-8942-e64cf9fbd34f; Ip=[178.79.136.144]; Helo=[semantical.co.uk] X-MS-Exchange-CrossTenant-AuthSource: CWLGBR01FT035.eop-gbr01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB5876 Received-SPF: pass client-ip=2a01:111:f400:fe15::711; envelope-from=mickey@masteringemacs.org; helo=GBR01-LO2-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) I think it'd be more useful if auto-save files (or even backup files) were excluded from all the various `project-' commands that operate on project files. In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2023-01-17 built on mickey-work Repository revision: bb383a54910c3094e5d228e0af62bf70e36203ca Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Ubuntu 20.04.3 LTS Configured using: 'configure --with-native-compilation --with-json --with-mailutils --without-compress-install --with-imagemagick CC=gcc-10' From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 24 18:20:35 2023 Received: (at 61038) by debbugs.gnu.org; 24 Jan 2023 23:20:35 +0000 Received: from localhost ([127.0.0.1]:57815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKSah-000258-7N for submit@debbugs.gnu.org; Tue, 24 Jan 2023 18:20:35 -0500 Received: from mail-wm1-f45.google.com ([209.85.128.45]:52743) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKSag-00024w-65 for 61038@debbugs.gnu.org; Tue, 24 Jan 2023 18:20:34 -0500 Received: by mail-wm1-f45.google.com with SMTP id k16so12590804wms.2 for <61038@debbugs.gnu.org>; Tue, 24 Jan 2023 15:20:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=KxTieEaJs/+vOgwUB30ugvkL81jqkPnNLMbIJ48qG5k=; b=hFVi0v/+HnSNn0s4ItTJWKbxXU2Rlsmg91X2rPtoFi7O3BXKzn9mq0xcBP9OtBO97u MwbN0v+YP2bXV0ufJE4ebIpTtcc//F2l/9VGYFnwsaUU/s6q6REG6dJQM3siRL5VHQxF SvTQ3wWnyMxplwkfL4z3Gv1S30xKNLFJ/ApgCXyQeF8V7Opv4GwhKPCrQGa2TxHaEKz6 hjEVFOQiKVRWzHroOeMZSw97z3qW16CX9/XniwN+VtB7O7B0t++K6EZFQUtcenMgV3LU 76bp2jlWuuCbawQFqazeLvnawunl3KcDWVt0+iBJJPqFfLeuR0UE/EAYe6BZVbcIrw7K MiKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KxTieEaJs/+vOgwUB30ugvkL81jqkPnNLMbIJ48qG5k=; b=ylTy+nx5xo1IXgA1Hy+J8KninANgufqI1TZv+qMWftyrVIw35PzafgiOHzcJKXcur4 El2dGvkID/yBkuMGVyH4b8ZhQzOHfNsugz94l+HtU5rmqzn62O4m3iqbEY3n63J7NgzI F1uhDpgbEP0wsAMnwDpLDIXjs4y1YUqBfeLZSQAJ28L5jtwHOQbKJx+vDPGsKcB5ZhC+ MGoTR3v2nxNWEtl4Sq9k+MRUB5LDsh7PJ41pvX9e1yZnN2W52kFEA0b2NJDDB2cMe1X8 lpIRNFXyPFifqFivEh0zj6MO9ByTlhlhJ56EYVMXs2W2Tbwg5bStkPxRsSJTgVbLTtN5 GuJA== X-Gm-Message-State: AFqh2kp1m0yeACNCvyEoofJZCR5N0xhn4VhcBQ/cvZWgChmcoOZ2J3IK BR3rH29bhPGr8bzyyUY+HRI= X-Google-Smtp-Source: AMrXdXvqyPStc9fA+fEZQg+55EGirymv3PaG5DKu+qqIETaCUA+oo/s/K3mjwPndWJ4SLkuzvUAMgQ== X-Received: by 2002:a05:600c:3c94:b0:3da:f2b:d7a0 with SMTP id bg20-20020a05600c3c9400b003da0f2bd7a0mr29261262wmb.31.1674602428128; Tue, 24 Jan 2023 15:20:28 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id fl22-20020a05600c0b9600b003d1e3b1624dsm199906wmb.2.2023.01.24.15.20.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Jan 2023 15:20:27 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 01:20:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#61038: 30.0.50; `project-query-replace-regexp' also attempts search and replace in auto-save files Content-Language: en-US To: Mickey Petersen , 61038@debbugs.gnu.org References: <87y1psw747.fsf@masteringemacs.org> From: Dmitry Gutov In-Reply-To: <87y1psw747.fsf@masteringemacs.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 61038 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 24/01/2023 12:37, Mickey Petersen wrote: > I think it'd be more useful if auto-save files (or even backup files) > were excluded from all the various `project-' commands that operate on > project files. I think that depends on the project backend. The default implementation uses grep-find-ignored-files (which include auto-save files, I think?). But the vc-aware backend ignores generally what the repository configuration tells it to ignore. Which would generally include auto-save files as well, but that depends on factors external to Emacs. What kind of backend were you trying this command with? From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 02:30:54 2023 Received: (at 61038) by debbugs.gnu.org; 25 Jan 2023 07:30:54 +0000 Received: from localhost ([127.0.0.1]:58143 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKaFB-0007PM-Sd for submit@debbugs.gnu.org; Wed, 25 Jan 2023 02:30:54 -0500 Received: from mail-db8eur05on2115.outbound.protection.outlook.com ([40.107.20.115]:57484 helo=EUR05-DB8-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKaFA-0007P9-Jg for 61038@debbugs.gnu.org; Wed, 25 Jan 2023 02:30:53 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JtHKgKcYsQhdwVcdcu0bsRZBZvehbUD5Nu9wFup448DCDMBxmsvShcFosWbq6fWhEAibpXLzTiM0XnihaE5HgePwVcl29QxFcTF88o2+yn4bTubNZYB/gdvLTRgVoOdMbejLGeu1IcgaT7wUQ2Qjoda9+/ZBCqU+9KKEinqwad51zMnBgJUsr78GTPvF95FJyNyqHuLeC6/I2408j82C/4G+QgI8qCnn317Z8feRA0V/SkChX3bmaA1gwzxH4D40izpn9bQ9KQZqxldZz/awVUpwRQuLgTCcDn5w2y8NEUgbPEVWKIwmxk9XPhjKaoVs7WGWM51vNGGRT55fQbM0jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zthDVib/3SB1Rdh+iSshwZq+1/DrGuC/T3NMWOkno8M=; b=OS5xbSCxfecOTs6lv2fcmQ5vwHPE1QXr5Yc/bMip1yqsTkhehW1mn/JhAbUoA+afIdKBoXWCYF9UvARNbGYRD6iAXkWXuDh+W6drgvrFVDaqv8PQBB3FVspApshQH0GJ0ryP14Lvs3gPc1oCP6iLML6V99xRCVgbjB4ZObxYA6CAdfSgtEZfcFU90G2itJqgoWnH8MCA5LVGadnt72vBFgNT/2X7QBX8zXgt/CeVnHp4wTMt4c+BynyeX7/+KtOXkzQtrz3JIIH4yV/6abbyZ5CsMdWGjdrtB5GJd+QhKk3Wj/z0WidcweB3mnxrQFBz9Z9XGLKfZ7QOH6kNbr28GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 178.79.136.144) smtp.rcpttodomain=debbugs.gnu.org smtp.mailfrom=masteringemacs.org; dmarc=pass (p=none sp=none pct=100) action=none header.from=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semantical.onmicrosoft.com; s=selector1-semantical-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zthDVib/3SB1Rdh+iSshwZq+1/DrGuC/T3NMWOkno8M=; b=aKMh11YxDBzy/JwNbzBlm2mAgnDrwRGIyKNryVXPJPwxvslvc6QhyLedHdPnuMrC9jAd8LdXuA+Mqvs71tH/OrmCvTvX9psaaUxDyiuG7CUM+rvCr2msAWBVRhR0Vbkk/5mPLYBweU8MiUbFgo/FcSEHZh9NGxsIzvKHc7u/x+Y= Received: from LO4P265CA0025.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ae::10) by LO0P265MB5430.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:287::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21; Wed, 25 Jan 2023 07:30:46 +0000 Received: from LO2GBR01FT026.eop-gbr01.prod.protection.outlook.com (2603:10a6:600:2ae:cafe::94) by LO4P265CA0025.outlook.office365.com (2603:10a6:600:2ae::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.17 via Frontend Transport; Wed, 25 Jan 2023 07:30:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 178.79.136.144) smtp.mailfrom=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org;dmarc=pass action=none header.from=masteringemacs.org; Received-SPF: Pass (protection.outlook.com: domain of masteringemacs.org designates 178.79.136.144 as permitted sender) receiver=protection.outlook.com; client-ip=178.79.136.144; helo=semantical.co.uk; pr=C Received: from semantical.co.uk (178.79.136.144) by LO2GBR01FT026.mail.protection.outlook.com (10.152.42.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21 via Frontend Transport; Wed, 25 Jan 2023 07:30:45 +0000 Received: by semantical.co.uk (Postfix, from userid 5001) id BF73A114002; Wed, 25 Jan 2023 07:30:42 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=masteringemacs.org; s=masteringemacs.org; t=1674631842; bh=zthDVib/3SB1Rdh+iSshwZq+1/DrGuC/T3NMWOkno8M=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=ACNXxn669B/tOJ8XJrcZXnB+Bgf2xNgutm1XEih0nwtQdQNAJPTg8K9Xy3MGiKZjp h8ckAue6Gf9NZDpD8gzlGA8NQF9DeXrGSKLOJ+mhIJY5QBDs8kmZBTcNLXt2ZQcixv SsX+9T9lGzk/fkhLoT+aLdV+VnWoSZpJC4ERRit4= X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on semantical.co.uk X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RECEIVED, NO_RELAYS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 References: <87y1psw747.fsf@masteringemacs.org> User-agent: mu4e @VERSION@; emacs 30.0.50 From: Mickey Petersen To: Dmitry Gutov Subject: Re: bug#61038: 30.0.50; `project-query-replace-regexp' also attempts search and replace in auto-save files Date: Wed, 25 Jan 2023 07:30:14 +0000 Organization: Mastering Emacs In-reply-to: Message-ID: <878rhrvzof.fsf@masteringemacs.org> Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO2GBR01FT026:EE_|LO0P265MB5430:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: b6394fae-819d-4e69-3d39-08dafea612a4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cTWnSuuEwKAS90RJN4M8OyKH0BdmdRBcul1uE8ee13oYB3+N27mn6JajV40u9adqZDLWeU+rXrv4ThgvOA7vgJ/iko1tW+xrwd8cFH9HJcSpgdrz4vN40si9AkNLut9jr+QOy4f3AuK5GRs5S1+lYpWVjuAGexicITgfI1W+L6ozGvVIVZ4wZXhtPWSrdd4aogumw+YnyX1TEzKCwdF4tfoXI9dzD47HCQP5rU/JX0QAiDNm/uoP1IFtA57uJ2owNF/ffXHS6T6ISLhSrdglcmZXWD0lsQP0e0JGPSBPJV9pcxGOH/DCntg4XwURn574m0PPDZFRttQuSxboqYy6TzrSjMnHw8I4eVDRKyWhC1tjHoCh/mDI71ZCH1j98x/a3iNwGlAf0aWWyaTD0QBXmyPAL0r52EoWJTEIE/QDYBWm0DpZepd23hzlVxWzZKh55ZgS2mzA0iSqsvnTnfFB/UE8m+cujB8o81XWmbEQeGKyLpx28dofNC2+nf5EB0pO0cJ8RNNCP9Q85hGJN2Nkx0fOSyD1pYE7MKiaazzpK4ddDtiURxaUTUvReG9zfuY0RxaUJ5chn/QIluOwYlHUz8pxAce9DrgfhUieo8jq62xjjCsqdY5dWWMHWeWCI0mpDrGFq5M5YlPoDylBYgszHFphmPSWzOsSO1+1Ki30sdzUzD+Cts++U2RBklcRpBBN7ypuwotTcQlgbn1aMD9wm2Y2ZaFdw/IUGwB7WzisKdwrNw1h4qPly206jI0pT/sqNLxUc64fZR518aGldsWh/k6aJvq9AuGf8zXjQaqqFrDYaOegnEarpI4KIUk57Nwi X-Forefront-Antispam-Report: CIP:178.79.136.144; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:semantical.co.uk; PTR:semantical.co.uk; CAT:NONE; SFS:(13230025)(396003)(136003)(346002)(376002)(39830400003)(451199018)(46966006)(36840700001)(47076005)(82310400005)(86362001)(36756003)(40480700001)(356005)(36860700001)(7636003)(7596003)(4744005)(42186006)(316002)(2906002)(41300700001)(4326008)(70206006)(70586007)(6862004)(8676002)(8936002)(5660300002)(186003)(26005)(6266002)(53546011)(2616005)(36916002)(6666004)(478600001)(336012)(38230200001)(81973001)(23180200003)(14776008)(79816003); DIR:OUT; SFP:1102; X-OriginatorOrg: masteringemacs.org X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 07:30:45.5019 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b6394fae-819d-4e69-3d39-08dafea612a4 X-MS-Exchange-CrossTenant-Id: a4e27e3d-bab0-45e8-8942-e64cf9fbd34f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a4e27e3d-bab0-45e8-8942-e64cf9fbd34f; Ip=[178.79.136.144]; Helo=[semantical.co.uk] X-MS-Exchange-CrossTenant-AuthSource: LO2GBR01FT026.eop-gbr01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB5430 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61038 Cc: 61038@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 24/01/2023 12:37, Mickey Petersen wrote: >> I think it'd be more useful if auto-save files (or even backup files) >> were excluded from all the various `project-' commands that operate on >> project files. > > I think that depends on the project backend. > > The default implementation uses grep-find-ignored-files (which include > auto-save files, I think?). > > But the vc-aware backend ignores generally what the repository > configuration tells it to ignore. Which would generally include > auto-save files as well, but that depends on factors external to > Emacs. > > What kind of backend were you trying this command with? Default git backend. However, I'd charge that Emacs should know about its own backup files (and not necessarily those of other Emacs instances that may be running.) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 10:29:26 2023 Received: (at 61038) by debbugs.gnu.org; 25 Jan 2023 15:29:26 +0000 Received: from localhost ([127.0.0.1]:59753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKhiI-0005S7-3a for submit@debbugs.gnu.org; Wed, 25 Jan 2023 10:29:26 -0500 Received: from mail-ej1-f49.google.com ([209.85.218.49]:45966) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKhiD-0005Rr-Ua for 61038@debbugs.gnu.org; Wed, 25 Jan 2023 10:29:24 -0500 Received: by mail-ej1-f49.google.com with SMTP id vw16so48598129ejc.12 for <61038@debbugs.gnu.org>; Wed, 25 Jan 2023 07:29:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=VBGYCOXzisE0wlP+QLzPIJMouB1+iXRQsalD2qObYko=; b=p0H5N1DhH93Hz08CGmgZgxB2/wk+w6INKv1UHAPumRYHpsJidjBDH/NZcpWh/FGKvd mRh1x3MRKK4EJojloARxqylE6fg2FcTN14o0g49+/RkTdxEuB4dE2ji7+WANJAHR+9wz gI/+D/KtVzfYmlEcyS7vVS7gz5VZph6en4yPIYBIJ6X5QPe4cW4/bk/NA2fmD9s4GG6H kCW8Tq9x99rSawEVA4HqvK7JWeRiC4OlHDOF4TK1fOy7ivQjhPk6OV0N6CFpRX16gO8J W8YVz/1htC8gfY5qeobFGvT0M/H7a63PUBneNqOExoReRCuIxCoQ0J0Sq6n48Yw8GaO6 kgjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=VBGYCOXzisE0wlP+QLzPIJMouB1+iXRQsalD2qObYko=; b=lL5/SijkEYNrQifN5/iLyzMN86HQ2hIZLxU/vTQCz4tgyWHrr3Xq4FGZ2TeE20vk1H Mkk9XEf+ByiQVc/Rl41ZbS8s608a8EhnNx8xNYpuKSFPETtnJ7VjXWBOCmAYQeutf17V 8kxvHZdp0+WYRerMIY7Oglx3rCYUjxPCpxWwvpNHPO5UL20gUTZ6UAtXXc0i0QRh1A2T YDf99AO/ViFkwl9rmBISG1nZuiL7ZDXenXF9J3ZSHBAV5zbA3bj3d0/mDy2a98BcU36F mycxlj5dHqXEzNclQuaS4+wyFjv2tTPlEELrXU+MI4Z1vRidpN/1IxlAIjh8iY5H2Mwf giew== X-Gm-Message-State: AFqh2kqSIINDz55UrO+6rqOmha93KpAFkwvIWNm75677iQjhEPn6edUA f44GOJoNHa8OTWZyY46Rg8A= X-Google-Smtp-Source: AMrXdXuQD/CvN7OTIoz6qOcXNblqhw0B6SCjMkJ/QLI0ByzVlyQeJ426rUy9nO0wO3raV8h7+isCQw== X-Received: by 2002:a17:906:758:b0:84d:12d8:e1e9 with SMTP id z24-20020a170906075800b0084d12d8e1e9mr31551724ejb.41.1674660555718; Wed, 25 Jan 2023 07:29:15 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m26-20020a1709066d1a00b008779b5c7db6sm2518428ejr.107.2023.01.25.07.29.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 07:29:15 -0800 (PST) Message-ID: Date: Wed, 25 Jan 2023 17:29:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#61038: 30.0.50; `project-query-replace-regexp' also attempts search and replace in auto-save files Content-Language: en-US To: Mickey Petersen References: <87y1psw747.fsf@masteringemacs.org> <878rhrvzof.fsf@masteringemacs.org> From: Dmitry Gutov In-Reply-To: <878rhrvzof.fsf@masteringemacs.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 61038 Cc: 61038@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 25/01/2023 09:30, Mickey Petersen wrote: > Dmitry Gutov writes: > >> On 24/01/2023 12:37, Mickey Petersen wrote: >>> I think it'd be more useful if auto-save files (or even backup files) >>> were excluded from all the various `project-' commands that operate on >>> project files. >> I think that depends on the project backend. >> >> The default implementation uses grep-find-ignored-files (which include >> auto-save files, I think?). >> >> But the vc-aware backend ignores generally what the repository >> configuration tells it to ignore. Which would generally include >> auto-save files as well, but that depends on factors external to >> Emacs. >> >> What kind of backend were you trying this command with? > Default git backend. However, I'd charge that Emacs should know about > its own backup files (and not necessarily those of other Emacs > instances that may be running.) It's hard for me to say what is TRT here. If we explicitly ignore backups, does that mean we should add compiled objects files, etc, that is, everything from grep-find-ignored-files? But I have configured my backups to be saved inside ~/.emacs.d/ directory, like a lot of people recommend. Via backup-directory-alist. If you don't do that, and you have them saved side-by-side inside Git repository, don't you usually add .gitignore rules for them then? So that they don't get in the way of other operations, outside of Emacs. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 15:44:11 2023 Received: (at 61038) by debbugs.gnu.org; 25 Jan 2023 20:44:11 +0000 Received: from localhost ([127.0.0.1]:60073 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKmct-0005EX-7T for submit@debbugs.gnu.org; Wed, 25 Jan 2023 15:44:11 -0500 Received: from mail-he1eur04on2124.outbound.protection.outlook.com ([40.107.7.124]:20484 helo=EUR04-HE1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKmcp-0005E1-Az for 61038@debbugs.gnu.org; Wed, 25 Jan 2023 15:44:09 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Sbm77O6zhTeI6JJK5vWO3pcEgcOlBLRkUeGYA0e1fjnGQdsrxWi3y9xRPYa+rCT59vTXgcieysGPggRFLwh4YEyCG3CFJUJVLT+j8kzp1dCVXI0LE+4iB/AJkI1bb9qSKVGv3XfEI2IIicf1a3yZxO8vjR/TOyFohIzQZuEmXjzFB3M0OfUwwU00rlem11DE5sCwgabmNwtWue0qR2xGmXWiY96Cd4F/nf3Wk+KzKlstyXbcAPdmpwlaDns+2LEqfKQw3+GNo2XfiygtBFjQOOxiFITIgg6k5ls6EhX1Jxyzd0R01DQpym8hdXikFK1HbxA5qmGvX1sW06dNajWbWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=X9haugP7w7g9GfzKy58pMriePjY/rpoLa6jWgeMSK5U=; b=SZTdUjuyv5adukIW60eIClrzXGg/U5JOY+6AvKjb+ea+KU3hbl6cEASNk1ahRhh9fsnDXVFvQLqEmKYqMD3vsKdMrt6Hb9qjA4BtO0yVpz3FCRvDz0KpsbygJxv0YHBI0h8IvksQO51SXyB+gEtO6x78bW+3OLrraXKsYtFoHGkttT1nzS4cNO37xOAMVVLbQaxzffUqUOQO+ZxyiQAO1zDqwLigEtHZgbNxqmFku3ODzbkGRoiXxeaWS2nsAGYl0medQ7lW6KTiEE7wkb0PY2bE9Sz2PsXTZl+ACvSOQ+3IkMCbiTnD7C+R06ZjShXgpcrOAoXrtbfiCBptqCcnag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 178.79.136.144) smtp.rcpttodomain=debbugs.gnu.org smtp.mailfrom=masteringemacs.org; dmarc=pass (p=none sp=none pct=100) action=none header.from=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semantical.onmicrosoft.com; s=selector1-semantical-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X9haugP7w7g9GfzKy58pMriePjY/rpoLa6jWgeMSK5U=; b=bPnQ0kmxEz6gDuMA5DZOcvWCxh3iZ5VFTjPN1hA2fImbNG0mXM2Z3q9DW6uCkuds6+20wyo7jxSzcVfoJbUHZ9s7/AxDHiFtmrx8triP3Cr+PGLmNsAgj7ctQBwl7TMAY64S0F87OSkmJ0ELGD7DbGT7rVkpuHiDa4J0SQb84bg= Received: from CWLP123CA0259.GBRP123.PROD.OUTLOOK.COM (2603:10a6:400:1d5::7) by CWXP265MB5058.GBRP265.PROD.OUTLOOK.COM (2603:10a6:400:199::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.21; Wed, 25 Jan 2023 20:44:00 +0000 Received: from CWLGBR01FT017.eop-gbr01.prod.protection.outlook.com (2603:10a6:400:1d5:cafe::3a) by CWLP123CA0259.outlook.office365.com (2603:10a6:400:1d5::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.33 via Frontend Transport; Wed, 25 Jan 2023 20:44:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 178.79.136.144) smtp.mailfrom=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org;dmarc=pass action=none header.from=masteringemacs.org; Received-SPF: Pass (protection.outlook.com: domain of masteringemacs.org designates 178.79.136.144 as permitted sender) receiver=protection.outlook.com; client-ip=178.79.136.144; helo=semantical.co.uk; pr=C Received: from semantical.co.uk (178.79.136.144) by CWLGBR01FT017.mail.protection.outlook.com (10.152.40.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.17 via Frontend Transport; Wed, 25 Jan 2023 20:43:59 +0000 Received: by semantical.co.uk (Postfix, from userid 5001) id 6F99E114002; Wed, 25 Jan 2023 20:43:59 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=masteringemacs.org; s=masteringemacs.org; t=1674679439; bh=U9hYrM1QcbWo9QaYoNKRgIPXiaPSv8OogHR/AN76JgI=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=alUTEJlkJSGCkUcLGjruvVEwCO4pKyXvB4scpFPP2rOwQ2ZcDCIiO/xOx3y9BwOsq vfAuWs4Qt/Pj8zfeiVT6X67W55CUlmZR7ejVlmbugaGeKzCuQsgfJ7srZiWrrhK4/l oniLSHmtvAuuGGpdqzxA7pP/pR0CZjLDJe+L0lu8= X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on semantical.co.uk X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RECEIVED, NO_RELAYS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 References: <87y1psw747.fsf@masteringemacs.org> <878rhrvzof.fsf@masteringemacs.org> User-agent: mu4e @VERSION@; emacs 30.0.50 From: Mickey Petersen To: Dmitry Gutov Subject: Re: bug#61038: 30.0.50; `project-query-replace-regexp' also attempts search and replace in auto-save files Date: Wed, 25 Jan 2023 20:34:07 +0000 Organization: Mastering Emacs In-reply-to: Message-ID: <87bkmmbb05.fsf@masteringemacs.org> Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CWLGBR01FT017:EE_|CWXP265MB5058:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: bd32f2d7-a157-4fb2-bcfc-08daff14e2e7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rnSdcW0SAjDiKrz5oG/6c5IOuF/TOO9OdCitDA7BACnSD+N0GkkfIbB6ITe3YfUdz/ZdNt5+jx+Wl0Bh/tyi06Yt6e3Ods+wHz6Wbx43XwBEuvmc5cgCEGJ56nsJ+pJPT1s1cT6Ngw0chQOIAuJU2BuRUbADl2jb8IgnUWTaGSZ0blmydcqpbqOOXR4WaivOG54dE1S9HKxYxqHm6z1GbH9m2IzhtSjhNPNs+cul/GYNigIDrPYlQKpeRxBvT8EvPbtMbo/GgX1MnSuRs8XlyIuMzfVTGo10px2FkyOE0fcJKmbE5dqYRHP4GHxy244fPVK54HfbLfS8GxfAS7wbTgiYYJmnJoaznnicZZd/U0cRlA/enkMAthIs7/ZnnLD1kI7Y0BBmJIhKanlC35EfhK6zCqp5PteooOacS5OKH9qfZwIrYgBHCztvMkBslPPs8DmDIc456wPczoTodRtQGfZXc5RlUBfjVuBoL3TIMa47KGj4UCx2jynhNle+Grr2MO8hu/XqskaNEl7nfTJA7nMVMtNfUk9N9X/+444tgJJJUrZHTuM0dgd6N3gruVWwAmJyk5PvYImb0LKGgJuZa9dEbAKuwtR+dAIZjEQ9Q8f4+/F/XmAyWPAopPQcrNUl/OtKQlAclvsRXAdOXY7yjpiEhxQdkNxzlyvL+W/W7/sdm30tXuFbZLujpnVSu6n3croKXfIyddvKluQC/J7jhU7+iuw7RaIdlg6PuSjUj9F660wb15snDQ67QBm/vryRjpuTe45FjbvD53UtLwDwaPiq5slAQoE+imE5gzhfaoHxN2MTK+HPt/G9W9YeCuau X-Forefront-Antispam-Report: CIP:178.79.136.144; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:semantical.co.uk; PTR:semantical.co.uk; CAT:NONE; SFS:(13230025)(39830400003)(136003)(376002)(346002)(396003)(451199018)(46966006)(36840700001)(36860700001)(7596003)(7636003)(86362001)(36756003)(40480700001)(82310400005)(356005)(316002)(42186006)(2616005)(70206006)(70586007)(8676002)(4326008)(36916002)(26005)(186003)(53546011)(6266002)(83380400001)(2906002)(47076005)(41300700001)(336012)(6666004)(8936002)(6862004)(5660300002)(478600001)(38230200001)(81973001)(23180200003)(14776008)(79816003); DIR:OUT; SFP:1102; X-OriginatorOrg: masteringemacs.org X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Jan 2023 20:43:59.7300 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: bd32f2d7-a157-4fb2-bcfc-08daff14e2e7 X-MS-Exchange-CrossTenant-Id: a4e27e3d-bab0-45e8-8942-e64cf9fbd34f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a4e27e3d-bab0-45e8-8942-e64cf9fbd34f; Ip=[178.79.136.144]; Helo=[semantical.co.uk] X-MS-Exchange-CrossTenant-AuthSource: CWLGBR01FT017.eop-gbr01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CWXP265MB5058 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61038 Cc: 61038@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 25/01/2023 09:30, Mickey Petersen wrote: >> Dmitry Gutov writes: >> >>> On 24/01/2023 12:37, Mickey Petersen wrote: >>>> I think it'd be more useful if auto-save files (or even backup files) >>>> were excluded from all the various `project-' commands that operate on >>>> project files. >>> I think that depends on the project backend. >>> >>> The default implementation uses grep-find-ignored-files (which include >>> auto-save files, I think?). >>> >>> But the vc-aware backend ignores generally what the repository >>> configuration tells it to ignore. Which would generally include >>> auto-save files as well, but that depends on factors external to >>> Emacs. >>> >>> What kind of backend were you trying this command with? >> Default git backend. However, I'd charge that Emacs should know about >> its own backup files (and not necessarily those of other Emacs >> instances that may be running.) > > It's hard for me to say what is TRT here. If we explicitly ignore > backups, does that mean we should add compiled objects files, etc, > that is, everything from grep-find-ignored-files? > > But I have configured my backups to be saved inside ~/.emacs.d/ > directory, like a lot of people recommend. Via backup-directory-alist. > > If you don't do that, and you have them saved side-by-side inside Git > repository, don't you usually add .gitignore rules for them then? > > So that they don't get in the way of other operations, outside of Emacs. (Actually this issue also afflicts auto-save files in my Emacs.) And the files in question are not committed to the index, nor are they part of the git tree. So they're just stray files that happen to be important (backup, auto save) to Emacs. It seems odd that you'd want to search and replace those by default, particularly when Emacs is well aware of the fact that they are indeed backups or auto saves of other files used by that instance of Emacs. And yes indeed: why not make the project replace mechanism ignore dumb things no one wants to edit. And committing large, binary files to a tree is common in a wide range of situations, though less so in Git, as it's terrible at it. So, yes, `grep-find-ignored-files' (or a project.el equivalent) should indeed exist. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 25 18:43:37 2023 Received: (at 61038) by debbugs.gnu.org; 25 Jan 2023 23:43:37 +0000 Received: from localhost ([127.0.0.1]:60211 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKpQW-0001M1-PP for submit@debbugs.gnu.org; Wed, 25 Jan 2023 18:43:37 -0500 Received: from mail-ed1-f47.google.com ([209.85.208.47]:37410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKpQQ-0001Lk-KI for 61038@debbugs.gnu.org; Wed, 25 Jan 2023 18:43:35 -0500 Received: by mail-ed1-f47.google.com with SMTP id s3so437833edd.4 for <61038@debbugs.gnu.org>; Wed, 25 Jan 2023 15:43:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=xJtMM//LGj5RtNADsSlZOFK4eu4vo1HHujO2bu7fNMs=; b=nOeRApgYwMld6X5uQ5Fe01C4tWAmtsl6YHyB+0rbZm2vlJqt81t86xLEDB+mCYjLrM OifMZ5RiXyPiY+0MN/JGqoyzKHosVeo+IyaDPvhzJppyngouFmOhPbFpcrSgF1azuckF YqRQw31RgyRXs5kTDBCT1aqd8cZ0MFCpMQz1MF9U4UytTY7nnBE3PeZKm0SX6zdGyQRU g7wFJNoMcKHvfTLX7szFJC1U2TSLwgX0aNMQYuzYrLcyxGOVPO6metkW1LcB6ij8xc49 ME00sHm+zifD2gTiEuAi2KlgWXgwC7ArReZaqrLzW9NmE33gnX95dhapzpJoZOuw83xe GbXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xJtMM//LGj5RtNADsSlZOFK4eu4vo1HHujO2bu7fNMs=; b=Rh//9DW2vjySkck9SvgGctFxtJmFtpIeVxNTWMtsazMX0kULZOzo+ldZBGbvl3s5xW 8azFOV/BM2qYWeHElEjyNoMLrECjb2DVwc5CgYKzUuznXAKLhNdZLLXlwqcicyP5MAD9 caBWh0DS5xmEDDoAiWTxdKCGQebhPDF6qxsVNY22BUEGO9uTsNUNyes//MRxa21OSedS ixEsokIkUkHZhT0ZtFBitl4oBm7OoULd5+7p675AKaHWM6umgKWHM6+zFRNdJCJTaIzG UWd4+IS14xcAKUdXZAN0UcefJfj/kgB9sG5DaxfxXIMu8WH2qS7gFFUYWk95aCtyJ9BJ qakg== X-Gm-Message-State: AFqh2kpCzpKXdvGmB+xybZe4pi6YITed1annoGmohbo95+suQPv/zVRo ptzx+SE47H+xXmpalBsRGCo= X-Google-Smtp-Source: AMrXdXsvMELlBxzBUyT/y0VB2DRIqJ5J0fgtWb67YVmp88BMxj7Hv9AlrHhkk42iMccKz6bvPTs7MQ== X-Received: by 2002:a05:6402:4507:b0:499:9d31:8490 with SMTP id ez7-20020a056402450700b004999d318490mr37881424edb.24.1674690203664; Wed, 25 Jan 2023 15:43:23 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id m6-20020aa7d346000000b0049c6c7670easm2956643edr.70.2023.01.25.15.43.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jan 2023 15:43:23 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 01:43:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#61038: 30.0.50; `project-query-replace-regexp' also attempts search and replace in auto-save files Content-Language: en-US To: Mickey Petersen References: <87y1psw747.fsf@masteringemacs.org> <878rhrvzof.fsf@masteringemacs.org> <87bkmmbb05.fsf@masteringemacs.org> From: Dmitry Gutov In-Reply-To: <87bkmmbb05.fsf@masteringemacs.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 61038 Cc: 61038@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 25/01/2023 22:34, Mickey Petersen wrote: > (Actually this issue also afflicts auto-save files in my Emacs.) > > And the files in question are not committed to the index, nor are they > part of the git tree. So they're just stray files that happen to be > important (backup, auto save) to Emacs. > > It seems odd that you'd want to search and replace those by default, > particularly when Emacs is well aware of the fact that they are indeed > backups or auto saves of other files used by that instance of Emacs. I'm asking why they are not in your .gitignore already. They must get in the way of operations such as 'git status', or 'git add *', or 'git commit -a', or just in the way of shell completion for 'git add ...'. > And yes indeed: why not make the project replace mechanism ignore dumb > things no one wants to edit. The "project replace mechanism" uses the same set of files that you get in completion for project-find-file. Or search through with 'project-find-regex'. So far the semantics of the vc-aware backend has been that all files that Git doesn't consider ignored (tracked or untracked) are considered to be part of the project. > And committing large, binary files to a tree is common in a wide range > of situations, though less so in Git, as it's terrible at it. That's why people usually put the binary files, backup files, etc, in .gitignore. > So, yes, `grep-find-ignored-files' (or a project.el equivalent) should > indeed exist. grep-find-ignored-files is a real user option already. You can also use project-vc-ignores, but it's nil by default. A couple of reasons not to use grep-find-ignored-files patterns by default: - Some users might be actually looking for one of those files, and would get surprised that while the Git repository lists them fine (perhaps they even checked in such file; maybe they're using unusual file naming schemes), but our project backend does not. - Every addition to the ignored patterns is a minor but steady performance hit. grep-find-ignored-files has 61 element by default. Dropping all of those into project--vc-list-files can create a performance hit of an order of a magnitude. E.g. in my testing the time to list the files in gecko-dev went up from 1s to about 5s. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 26 04:24:44 2023 Received: (at 61038) by debbugs.gnu.org; 26 Jan 2023 09:24:44 +0000 Received: from localhost ([127.0.0.1]:60715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKyUt-0008QZ-LN for submit@debbugs.gnu.org; Thu, 26 Jan 2023 04:24:44 -0500 Received: from mail-he1eur01on2092.outbound.protection.outlook.com ([40.107.13.92]:31109 helo=EUR01-HE1-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKyUo-0008QE-Fz for 61038@debbugs.gnu.org; Thu, 26 Jan 2023 04:24:42 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NUBHNXC5b8xNNQuGc/DfVyOxu5kTHaCjcOZAcULYGv262toTW67oUgtjfkjEMcZO4YEf0eOOLS2OD6tsxkb6uYt30XGqfB6ENhKVMUSmNgNJqmeSfnbwxWIqQ1uSJjNs7vVNOWCkabcRJmU+4H0myWw4233l7vghbVm6CwykmY/ly58oA3bGVBCrbaxRATI1B4VRieQsqjznOlu0kjgvyVRMbIQQFvqUCncvr8IuEdyzJ8HyLRsd9ZDZZiyduNyePpu4o/EZwgZ0o673nRaly49VE/RXdczL4OLR/haMjUnLOwEZIw0U8QZD6CnIbnkdd0jmRcO7Kl7B8hKiq/fPdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M4RgRX112AzCKBxO8xCQsnj2h1r4ogF8RVrgOu2ENoQ=; b=Pz2C5iN9ROP6LB49eWCxSCMtjKOHVLgGpT0HBXXI4OoCqj5CXIeq316/lXKE59LQYiRLqkJzh9WP/zUNcpEUC3NBfnyboULdAnuJaml+idRSZ8qBIUDCNSFZPg7fJku0ebbDyv7JgrQQ+UfzulOosCOCj5spR4dJ/ZKoNqxL6MFXLMZpaJp3+XTbwZ3ImZFgUybM2HR44wm6HrbUJIiaT25tFsyX9reP5NIEjiheysBJ0sEEoxTdlrDfKkPAeexa0G1sbMI+thGla63NfsM36xQDSQFeeET+XsZT/E+ks2BZJBcRyNopH7kPjhn1WlPRqFpV7NJw4OGdIkECtGzvXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 178.79.136.144) smtp.rcpttodomain=debbugs.gnu.org smtp.mailfrom=masteringemacs.org; dmarc=pass (p=none sp=none pct=100) action=none header.from=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semantical.onmicrosoft.com; s=selector1-semantical-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M4RgRX112AzCKBxO8xCQsnj2h1r4ogF8RVrgOu2ENoQ=; b=kAD6CTcGjHizsoF+XvZ9GogWb1sjjd63LDgM2I22yRZXw/bon+hlt5vL8Hq32O1iNOL9wdzM2GTRFM11Wd0eoWlPQ7TmAyQ+w0uzxCUdfbNoHeGax4L2azZuEyS4xllKrK4X/ZJNZfw0bDvGArpuC07eEJJgkkIqL9HMjnYnDnk= Received: from LO2P265CA0298.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::22) by LO0P265MB7238.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:335::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22; Thu, 26 Jan 2023 09:24:22 +0000 Received: from LO2GBR01FT029.eop-gbr01.prod.protection.outlook.com (2603:10a6:600:a5:cafe::39) by LO2P265CA0298.outlook.office365.com (2603:10a6:600:a5::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.22 via Frontend Transport; Thu, 26 Jan 2023 09:24:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 178.79.136.144) smtp.mailfrom=masteringemacs.org; dkim=pass (signature was verified) header.d=masteringemacs.org;dmarc=pass action=none header.from=masteringemacs.org; Received-SPF: Pass (protection.outlook.com: domain of masteringemacs.org designates 178.79.136.144 as permitted sender) receiver=protection.outlook.com; client-ip=178.79.136.144; helo=semantical.co.uk; pr=C Received: from semantical.co.uk (178.79.136.144) by LO2GBR01FT029.mail.protection.outlook.com (10.152.42.155) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6043.20 via Frontend Transport; Thu, 26 Jan 2023 09:24:21 +0000 Received: by semantical.co.uk (Postfix, from userid 5001) id 76B7C114002; Thu, 26 Jan 2023 09:24:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=masteringemacs.org; s=masteringemacs.org; t=1674725061; bh=uG5JYTPf0DKfSBuW+ymrV7WzI4FujWTEZIBVXeSEX8U=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=eBm7cVQEQmHgUzAuSSuQPc+u4Zy1XO02u3iNiqrbcVNImaHnYpZdR6Kt6HQ7v4HQZ VWh/3pAlXxHrk1jf2NCLxFrxTjNouWPap4YGFyh057j1FJJeVM8Rty51jSvS+QLlt+ LgZW17SmZ5Mq5/t37tHCd7UV+HVlijHUPW9lJha8= X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on semantical.co.uk X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,NO_RECEIVED, NO_RELAYS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 References: <87y1psw747.fsf@masteringemacs.org> <878rhrvzof.fsf@masteringemacs.org> <87bkmmbb05.fsf@masteringemacs.org> User-agent: mu4e @VERSION@; emacs 30.0.50 From: Mickey Petersen To: Dmitry Gutov Subject: Re: bug#61038: 30.0.50; `project-query-replace-regexp' also attempts search and replace in auto-save files Date: Thu, 26 Jan 2023 09:13:31 +0000 Organization: Mastering Emacs In-reply-to: Message-ID: <877cx9bqd8.fsf@masteringemacs.org> Content-Type: text/plain X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LO2GBR01FT029:EE_|LO0P265MB7238:EE_ MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 40353460-cc56-49e5-622e-08daff7f1bc3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: O2FnaqCT7wZ/Cu1CdrInctTgQCDlZl5znv5vSlAYXiTMUqiI07rGQoGucHvsEVpaOmYMMMlc+sWauW21fSp7rZsNx6EXCzfmbytKCT2ycLSpnzXyOQui6VBVJZeks58jB5ge2nu0YT+8ayBPeIXm0ZzB8CyLswjtB48TxemFCPNoetw0ddDSQPU7kE2SwUinezrRV+RcDEOo/rSi3nduzDw6DEhgxCViU1ndCzntBPqo5isCgd+VKLXAlJtcywKw7pgoz+/H3yb5Cxvrxxd+0GjxKY0gVN3deQv7oaShAHIAToeYKzz6oBBWIOqUfbegLrYzRUVYnJ2KpJGGVzEESZpES4TO2DTI4qa76ynvh9VLEqUrX/l+w2sTJ19oQwSzeliWIFmeQPUlr0CCTZH1BGxCsMERGjazeacbLxc0hsRMEv7FkJuHuqT/v+QBOZUfizGufFk3HjHZOAYI0C8C7AxwfrzmcCY1E7zIDQODADS1JwgFyFKhjSBTQ4oztweyeRLhnm8T35Oq+44Q6vQ24R8scoYeGuiUZAjVLmiaoUadnsP0C9eOyDRU+Amsg4p/VTjKz7dDaP0lLxpYA/xrklTzVd1d7P15rb1ImMSjlGZZn1GRGWuBL8VDBW9muBOHRH6jbMyvzsaLa3dY2c8kD90yXymObx5X43v0piu86AwP65emdv7RSjC1GsnTX2SPu7cMpehFBvLmCmVRgy/pfCssrDkk81PwuRbffvVkpvm9NEPO0gmKpXuUDilLo+GU6vEiKy5x1XOvBHlTe6weOj+zaDBNOw3U3fELHkultO/cspZONsLfrHyMJ1PDbt3T X-Forefront-Antispam-Report: CIP:178.79.136.144; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:semantical.co.uk; PTR:semantical.co.uk; CAT:NONE; SFS:(13230025)(376002)(396003)(346002)(39830400003)(136003)(451199018)(46966006)(36840700001)(36756003)(36916002)(8676002)(316002)(478600001)(42186006)(6666004)(53546011)(5660300002)(2906002)(4326008)(70586007)(70206006)(6862004)(8936002)(41300700001)(7636003)(7596003)(36860700001)(356005)(86362001)(40480700001)(336012)(82310400005)(83380400001)(2616005)(186003)(26005)(6266002)(47076005)(38230200001)(81973001)(23180200003)(14776008)(79816003); DIR:OUT; SFP:1102; X-OriginatorOrg: masteringemacs.org X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2023 09:24:21.7752 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 40353460-cc56-49e5-622e-08daff7f1bc3 X-MS-Exchange-CrossTenant-Id: a4e27e3d-bab0-45e8-8942-e64cf9fbd34f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a4e27e3d-bab0-45e8-8942-e64cf9fbd34f; Ip=[178.79.136.144]; Helo=[semantical.co.uk] X-MS-Exchange-CrossTenant-AuthSource: LO2GBR01FT029.eop-gbr01.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: LO0P265MB7238 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 61038 Cc: 61038@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov writes: > On 25/01/2023 22:34, Mickey Petersen wrote: > >> (Actually this issue also afflicts auto-save files in my Emacs.) >> And the files in question are not committed to the index, nor are >> they >> part of the git tree. So they're just stray files that happen to be >> important (backup, auto save) to Emacs. >> It seems odd that you'd want to search and replace those by default, >> particularly when Emacs is well aware of the fact that they are indeed >> backups or auto saves of other files used by that instance of Emacs. > > I'm asking why they are not in your .gitignore already. They must get > in the way of operations such as 'git status', or 'git add *', or 'git > commit -a', or just in the way of shell completion for 'git add ...'. > Let's assume I'm simplifying a more complex workflow to aid with the bug report. >> And yes indeed: why not make the project replace mechanism ignore dumb >> things no one wants to edit. > > The "project replace mechanism" uses the same set of files that you > get in completion for project-find-file. Or search through with > 'project-find-regex'. > > So far the semantics of the vc-aware backend has been that all files > that Git doesn't consider ignored (tracked or untracked) are > considered to be part of the project. > >> And committing large, binary files to a tree is common in a wide range >> of situations, though less so in Git, as it's terrible at it. > > That's why people usually put the binary files, backup files, etc, in > .gitignore. > There are many legitimate reasons for having binary files -- large ones too -- in a repository. Though it's uncommon with git, as it does a poor job handling them. There are also legitimate reasons for not having expansive ignore files, particularly with version control systems that lack the granularity of Git and its ilk. Nevertheless, knowing that untracked are also considered part of the project, I can now set `project-vc-include-untracked' to nil to at least resolve this. It would seem I was not the only one who chafed at this edge case. >> So, yes, `grep-find-ignored-files' (or a project.el equivalent) should >> indeed exist. > > grep-find-ignored-files is a real user option already. You can also > use project-vc-ignores, but it's nil by default. > > A couple of reasons not to use grep-find-ignored-files patterns by default: > > - Some users might be actually looking for one of those files, and > would get surprised that while the Git repository lists them fine > (perhaps they even checked in such file; maybe they're using unusual > file naming schemes), but our project backend does not. > > - Every addition to the ignored patterns is a minor but steady > performance hit. grep-find-ignored-files has 61 element by > default. Dropping all of those into project--vc-list-files can > create a performance hit of an order of a magnitude. E.g. in my > testing the time to list the files in gecko-dev went up from 1s to > about 5s. Sure. But `git-grep(1)' will ignore binary files by default, for example. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 26 10:50:40 2023 Received: (at 61038) by debbugs.gnu.org; 26 Jan 2023 15:50:40 +0000 Received: from localhost ([127.0.0.1]:35935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pL4WN-0001BZ-Ve for submit@debbugs.gnu.org; Thu, 26 Jan 2023 10:50:40 -0500 Received: from mail-ej1-f49.google.com ([209.85.218.49]:44991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pL4WL-0001BM-OD for 61038@debbugs.gnu.org; Thu, 26 Jan 2023 10:50:38 -0500 Received: by mail-ej1-f49.google.com with SMTP id ss4so6136206ejb.11 for <61038@debbugs.gnu.org>; Thu, 26 Jan 2023 07:50:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=4DiFfFwmkSKigDegkvx9rtHegADBXxMvdoAYjLGgS54=; b=AWi4evk8APgHC41XzkUgxCnk6mRYNm7e4nx+gnZFumbfWcsPwRKPd4BkHdl3hcgUou zE5dbIYps1cTUm36JRfFitfoyGE3VsoB6fsdHZNGq7tibDoeUfuy6q0nAAAC1MNc/c5q SrO0z3LltKd6jA8096moFhn41SljSDVy34CVoQDpI0mjAhCIN7HsihoFNdXFjpW+QJAo btV6cHv4loEoR734y9uZWgq0x2e4U0Ui6cPS8S/0BH4ZqgCbRg45SMUPceS72T03IIV1 g7An4EozIzIy6010WuorJrXtBEwDl8D87onneymCBg0WargEKRaUS3fhSr3kUou13a3P GnoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4DiFfFwmkSKigDegkvx9rtHegADBXxMvdoAYjLGgS54=; b=uLE+DdXVS/PYnZPBJ/dSloMW198A8SOwP2+w+yWLxTkSLUECq723rGl4QYGUZzEjvV IlCUwKFo1lYADDBobVcu708XLhZRZM5sXhBtoJFqbuFJmXUBQpG5mZ9x6KB2ODdVi3T5 Df+z4X8wOV5EzuZ+mPRY0eN/TEUFXQJ00VnKo1pshtB03jcGPf37WL5mvqNB4vePTPsc XO6Vvd3LxfAm/o+1dbas2TTqkXMS43lkFCW+IFj78rtROnFFCC4Rcy5oUCNCkUKLOtx5 PeuMkoDL+tJ/9xuZR+1e+0dDscDqKTcopm7nSVsdbGzbz/S8X+YdXLTeOKhlDqKlXAmL T8hA== X-Gm-Message-State: AFqh2kr/TdPcZZ4JoXvYFZqGRWU4eMwvG0zm++5TSt4mWPORg6x0DuwB DHveofP6hcDzpmuR0IEE4ulEsM4fpCA= X-Google-Smtp-Source: AMrXdXuM4fPlGs/nZuqQ9QbqbExmEbDkGwDzlpyem74cY3dlfhDiy0WmxofE5A5rEMhL6hXFQz8ItA== X-Received: by 2002:a17:906:ce23:b0:85a:4230:6743 with SMTP id sd3-20020a170906ce2300b0085a42306743mr36857055ejb.23.1674748231505; Thu, 26 Jan 2023 07:50:31 -0800 (PST) Received: from [192.168.0.2] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id sb25-20020a1709076d9900b0086faa5b06d4sm747912ejc.181.2023.01.26.07.50.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 07:50:30 -0800 (PST) Message-ID: <40efee33-4142-90ac-b7b4-7ea19dd688ee@yandex.ru> Date: Thu, 26 Jan 2023 17:50:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: bug#61038: 30.0.50; `project-query-replace-regexp' also attempts search and replace in auto-save files Content-Language: en-US To: Mickey Petersen References: <87y1psw747.fsf@masteringemacs.org> <878rhrvzof.fsf@masteringemacs.org> <87bkmmbb05.fsf@masteringemacs.org> <877cx9bqd8.fsf@masteringemacs.org> From: Dmitry Gutov In-Reply-To: <877cx9bqd8.fsf@masteringemacs.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 61038 Cc: 61038@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 26/01/2023 11:13, Mickey Petersen wrote: > > Dmitry Gutov writes: > >> On 25/01/2023 22:34, Mickey Petersen wrote: >> >>> (Actually this issue also afflicts auto-save files in my Emacs.) >>> And the files in question are not committed to the index, nor are >>> they >>> part of the git tree. So they're just stray files that happen to be >>> important (backup, auto save) to Emacs. >>> It seems odd that you'd want to search and replace those by default, >>> particularly when Emacs is well aware of the fact that they are indeed >>> backups or auto saves of other files used by that instance of Emacs. >> >> I'm asking why they are not in your .gitignore already. They must get >> in the way of operations such as 'git status', or 'git add *', or 'git >> commit -a', or just in the way of shell completion for 'git add ...'. >> > > Let's assume I'm simplifying a more complex workflow to aid with the > bug report. Okay. > There are many legitimate reasons for having binary files -- large > ones too -- in a repository. Though it's uncommon with git, as it does > a poor job handling them. > > There are also legitimate reasons for not having expansive ignore > files, particularly with version control systems that lack the > granularity of Git and its ilk. > > Nevertheless, knowing that untracked are also considered part of the > project, I can now set `project-vc-include-untracked' to nil to at > least resolve this. It would seem I was not the only one who chafed at > this edge case. You can also customize project-vc-ignores to fine-tune which additional file to skip specifically (whether tracked or not). But if "skip untracked" suits your mental model well, even better (it also increases file listing's performance). As a default behavior, though, I think it's problematic because one might work for a significant amount of time on a bunch of new files before committing them. Depends on a workflow. >>> So, yes, `grep-find-ignored-files' (or a project.el equivalent) should >>> indeed exist. >> >> grep-find-ignored-files is a real user option already. You can also >> use project-vc-ignores, but it's nil by default. >> >> A couple of reasons not to use grep-find-ignored-files patterns by default: >> >> - Some users might be actually looking for one of those files, and >> would get surprised that while the Git repository lists them fine >> (perhaps they even checked in such file; maybe they're using unusual >> file naming schemes), but our project backend does not. >> >> - Every addition to the ignored patterns is a minor but steady >> performance hit. grep-find-ignored-files has 61 element by >> default. Dropping all of those into project--vc-list-files can >> create a performance hit of an order of a magnitude. E.g. in my >> testing the time to list the files in gecko-dev went up from 1s to >> about 5s. > > Sure. But `git-grep(1)' will ignore binary files by default, for example. Hmm, I think in our case the step which will ignore the binary files is the search program. So (project-files) will include them in the listing, but both Grep and Ripgrep will skip them during the search.