From unknown Sat Aug 09 04:57:43 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61037: 28.1; mml-attach-buffer on archive-mode Resent-From: Al Haji-Ali Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Jan 2023 10:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61037 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61037@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167455681524090 (code B ref -1); Tue, 24 Jan 2023 10:41:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Jan 2023 10:40:15 +0000 Received: from localhost ([127.0.0.1]:55948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKGit-0006GT-0r for submit@debbugs.gnu.org; Tue, 24 Jan 2023 05:40:15 -0500 Received: from lists.gnu.org ([209.51.188.17]:45136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKGis-0006GL-7b for submit@debbugs.gnu.org; Tue, 24 Jan 2023 05:40:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKGil-0003Rb-BO for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 05:40:12 -0500 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKGij-0004ck-N7 for bug-gnu-emacs@gnu.org; Tue, 24 Jan 2023 05:40:07 -0500 Received: by mail-wr1-x42d.google.com with SMTP id n7so13419012wrx.5 for ; Tue, 24 Jan 2023 02:40:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=5G+bWmjG7rT452W7xEepx6Sqyw9OuwaS4wReu7dZpiE=; b=j43GOyIL7GLyUuq5+y/mZ2uQFFo2vAOwroR5tUHuERbNJoM+KRr9Q0rVgkfCgb/0C5 IZbcLW6dM4iqcq/RQ51Pvhq3qtBUWThZSmNyjf2BXObUKe+arWoxp4pOEPnIznn1NwFy /IzUA/31YF+Zggmfhq/vlzqqR0QBCoSZGceKhwcQZNskZ9JKjh73xacYMSNlOXYgepGS BJMTCOW6DNKmSxDkqIK2gPbgP8torjGsNz9T94nUXJFOQ7pZuV1wGm+S/CvjgaUV+LDW GH9cnE2QqhdpyGDX/U4XpZdrDiKZX1CEwqRnjZthaGIbd7jOcuJ7XAAJ+RajEkZI+C5x +jXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5G+bWmjG7rT452W7xEepx6Sqyw9OuwaS4wReu7dZpiE=; b=AS3/9NepxYp1PWMdU9b4jLYcn0VNjwi8VxWVafXc1hJDpkhCVBl2l5cWDiZFqSX3IK t9X4hNVTcqPtNM33YIjR3bJg17HTS/ZlUNXmhGfqI9Hj6onD1iiIJWllbq7aeQizd2Ez NHMbkqf6E35IHgLD+0OJBiIiu3ODJ36VTZsnk+qAlEY5NJRefxkxpUhm7nBvvQPMaE9h V5uOoWy8xFSjM0xTlqGPeCkkz2U1NpibVzATXL+lPQ1S0ESX4wOylJTNKZ3Jw1Ngz8N2 hoshadMXuFM7S/z4IDmqNqukwoA/dGz7ySreXIo+s3Fi91yyyq1oVuLj42RxJWagtKOW bCNg== X-Gm-Message-State: AFqh2kp5zxUaTYL3zCG09dWFkm9WUiZRnc5kHw4MjZFTXyovgx8ASInz cPk0A7UNzFEnXR+H2oGJldzbMreTYDU= X-Google-Smtp-Source: AMrXdXtv2PmYErsNc/IUSljdJRIKEiaMiZDyN8hUM4OZRXkp43w7zawVEHF/PStMFoMYirvd4x/q+w== X-Received: by 2002:a05:6000:1c0e:b0:26f:6bf:348f with SMTP id ba14-20020a0560001c0e00b0026f06bf348fmr21181678wrb.6.1674556802387; Tue, 24 Jan 2023 02:40:02 -0800 (PST) Received: from localhost ([137.195.26.27]) by smtp.gmail.com with ESMTPSA id j7-20020adfb307000000b002be063f6820sm1924089wrd.81.2023.01.24.02.40.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Jan 2023 02:40:02 -0800 (PST) From: Al Haji-Ali Date: Tue, 24 Jan 2023 10:33:48 +0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=abdo.haji.ali@gmail.com; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, When calling `mml-attach-buffer` to attach an `archive-mode` buffer, the "wrong" attachment is sent (the archive is not sent). This is because archive-mode adds a file summary to the top of the buffer and restricts the buffer to that summary. Then in mml.el:645 the line (insert-buffer-substring (cdr (assq 'buffer cont))) inserts the buffer content (which is just the summary) and similarly in mml.el:725 (insert (with-current-buffer (cdr (assq 'buffer cont)) (buffer-string))) (incidentally, I am not sure why `insert-buffer-substring` is not used in mml.el:725) I can hack my way around this by advising `buffer-string` and `insert-buffer-substring` to handle archive-mode correctly by widening and narrowing to (archive-file-list-start (point-max)), at least when called from `mml-generate-mime-1`, but I was wondering if this should also be fixed somewhere upstream. Cheers, -- Al