From unknown Fri Jun 13 10:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace Resent-From: Mohammed Sadiq Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Jan 2023 11:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61026@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16744726782438 (code B ref -1); Mon, 23 Jan 2023 11:18:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Jan 2023 11:17:58 +0000 Received: from localhost ([127.0.0.1]:53468 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJupq-0000dG-Ft for submit@debbugs.gnu.org; Mon, 23 Jan 2023 06:17:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:48528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pJupm-0000d6-QH for submit@debbugs.gnu.org; Mon, 23 Jan 2023 06:17:57 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJuph-0007Jf-DN for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 06:17:54 -0500 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pJupd-0000ra-Dj for bug-gnu-emacs@gnu.org; Mon, 23 Jan 2023 06:17:48 -0500 Received: (Authenticated sender: sadiq@sadiqpk.org) by mail.gandi.net (Postfix) with ESMTPA id C3B24FF804 for ; Mon, 23 Jan 2023 11:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sadiqpk.org; s=gm1; t=1674472658; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gsEbKpdx0iSwB8YzUoTCcSd7TtoLTDD3+yDlmygr+bM=; b=ooHkX3BtWNCE6Y+qn9yniKNl0gRr+Ix102NEX0IBgOcq61VbIOCkKpqLKloQ/sNsT4xJTL eD4+YN3WUU52oWsJOt1963xuWQvEmpUqty+DKlSvDBq2MDuuqwjYC/umujsx2jjZfwfuZt 6jkNDCfb3sdBIxXi94TYLZVYkbQAd2FNl3WT0KFq4mkkbaYs4kkgv8ezvmSnRd0WiIfVp3 e2E6Isj6a5HzKvt5eJW50cowi7ZAXqcNRhCH7D6V0Ta/Q0w43j7w3tnJR0un3Aw5Nxr0Ba Ec8bfth5zR2D3pz0DG0VCQTwJYngkrlxFdsxxHk8cWjPum17sdWOeAa8pSZh7A== MIME-Version: 1.0 Date: Mon, 23 Jan 2023 16:47:38 +0530 From: Mohammed Sadiq Message-ID: X-Sender: sadiq@sadiqpk.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2001:4b98:dc4:8::229; envelope-from=sadiq@sadiqpk.org; helo=relay9-d.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) The following code has broken indentation with c-ts-mode: while (true) if (true) { puts ("Hello"); } if (true) if (true) { puts ("World"); } For which, I expect to get the following indentation (with default config): while (true) if (true) { puts ("Hello"); } if (true) if (true) { puts ("World"); } In GNU Emacs 29.0.60 (build 6, x86_64-pc-linux-gnu, GTK+ Version 3.24.36, cairo version 1.16.0) of 2023-01-23 built on purism Repository revision: e6c5f32e77dceed4e26b16889cc56547093bdc45 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12101006 System Description: Debian GNU/Linux bookworm/sid From unknown Fri Jun 13 10:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Jan 2023 20:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Mohammed Sadiq Cc: 61026@debbugs.gnu.org, Yuan Fu Received: via spool by 61026-submit@debbugs.gnu.org id=B61026.167467809418040 (code B ref 61026); Wed, 25 Jan 2023 20:22:01 +0000 Received: (at 61026) by debbugs.gnu.org; 25 Jan 2023 20:21:34 +0000 Received: from localhost ([127.0.0.1]:60047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKmGz-0004gu-QA for submit@debbugs.gnu.org; Wed, 25 Jan 2023 15:21:34 -0500 Received: from out-135.mta0.migadu.com ([91.218.175.135]:16209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKmGw-0004gh-6D for 61026@debbugs.gnu.org; Wed, 25 Jan 2023 15:21:31 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1674678088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PDZ1IkpBCQiFtIgNVsYzWU19mckqfZ+brNB4tLzRQic=; b=mJ9F38Bst4hyt9m3CYr8p8Jy9sDt+fjnFUmnOpeo32ZC0kGPmC6LQ9rfHMT2m8/ZoWtFWN ZIS031Zaza73nmHGBAE2i0syzO4yvVH4pCWkW1ngyLWKTkIbVojuomIEPpbTSTvVI2oesZ +FCnCXMn2q2Ty9x0O/ZuVe1BGO3vZEew7PfbZxfMnY6/etOeJsnfq/WPYeWH2Km5dJw9sN Z2WrdvgrAIJlY1z2eyZ2VAuMrPMs2W+8+ugJQqrHb7H5Vdb74lcKFw52JHOuNb+pUCC7Aa sXsBiQ82dtrx4L4g5BYFIszmpDwhsq8xBOlz2Z6PkN0Zb9kF+JwPZr818zj6ug== From: Theodor Thornhill In-Reply-To: (Mohammed Sadiq's message of "Mon, 23 Jan 2023 16:47:38 +0530") References: Date: Wed, 25 Jan 2023 21:21:27 +0100 Message-ID: <87ilgu8iwo.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain X-Migadu-Flow: FLOW_OUT X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mohammed Sadiq writes: > The following code has broken indentation with c-ts-mode: > > while (true) > if (true) { > puts ("Hello"); > } > > if (true) > if (true) > { > puts ("World"); > } > > For which, I expect to get the following indentation (with default config): > > while (true) > if (true) { > puts ("Hello"); > } > > if (true) > if (true) > { > puts ("World"); > } > > Thanks, Mohammed! Yuan, I'm not sure the new brace counting method is a good enough improvement just yet considering its complexity and the number of issues we are seeing. Do you see any simple fixes for these issues? I can try to debug this this weekend, but not sure I really have time to fix it. All of these issues work fine in js-ts-mode or java-ts-mode, if I'm not mistaken. Theo From unknown Fri Jun 13 10:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace References: In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Jan 2023 07:55:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Theodor Thornhill Cc: Mohammed Sadiq , 61026@debbugs.gnu.org Received: via spool by 61026-submit@debbugs.gnu.org id=B61026.167471967122624 (code B ref 61026); Thu, 26 Jan 2023 07:55:01 +0000 Received: (at 61026) by debbugs.gnu.org; 26 Jan 2023 07:54:31 +0000 Received: from localhost ([127.0.0.1]:60546 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKx5a-0005sq-Ut for submit@debbugs.gnu.org; Thu, 26 Jan 2023 02:54:31 -0500 Received: from mail-pf1-f174.google.com ([209.85.210.174]:46848) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKx5Y-0005sY-Ih for 61026@debbugs.gnu.org; Thu, 26 Jan 2023 02:54:29 -0500 Received: by mail-pf1-f174.google.com with SMTP id 20so599787pfu.13 for <61026@debbugs.gnu.org>; Wed, 25 Jan 2023 23:54:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=IV+Z35Hmkirp9KOpM/MZ8OwfMVrh33lbu9yNfs32UMg=; b=i4WgJS+gno+fPNu7XtF9W9V0Lo55RWW8k8lHPToDRiDVncKqo6ObS+hkB8Ges/iU2v boZABKVXDLrSBLWnc+v9RGoPXVlER9TTuXAn+kySVARPnM6fIpj78gL9AzlZulAM6rW7 KQMyXwnZj9ZcfZPdq8AAYLK6vYJ9wqxkbozUulWfwGajNUVMibj/tvVktHOEibiAXKz1 7A34GpKoIxoQA2zMQ2mZZkiPFmzIjfspnQMLH4Ue7psDuHKgO/7vs2JwuHFatenj6Iky OXwmPue3uTOofqqSHaBUmriuf9AA8SDPvx5giOpjZdjdnd4U2q0jKGA2GfTRMs6z7SVJ cAkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IV+Z35Hmkirp9KOpM/MZ8OwfMVrh33lbu9yNfs32UMg=; b=NmsI8mvp9d9uVfJbwnGcXSkTDDAoW+3c7EtlQZOKGw0QhsDeIojCovWX6HjgFudGVX SJkkQB2EMputXI7GU7fsAPwkWNHIZ5pSZWas5WH+R0qL8Mev2emlOsxA1BX4lWLorgIX 18EGJESNhV1WFWl+Cq1utGFgN6Wio7KEKuS9zjA0uViCmINs3NCNT6ccf881jOjwxtJR XJ5QjRAifbL+eK+44DHjhs2TFXHVN2/o7R+Lig54QPXZZsOGDEcI/Q4NDwHLWzJYzoZm Q5xr0qx2Yf86E8sppZe4AEgzkpFtF0MAUzG+GK7JhOEtMSnLogvr5HRiCJ5gP8GqfV+K 0xzw== X-Gm-Message-State: AFqh2kqZeo5dBbufcsOgfZlYnGXJc2JgeCgBjMA8VKZyM90SvFht8Dtx +Wx0sp7RhLxzdoixLbrHkZY= X-Google-Smtp-Source: AMrXdXuQPeOB0CyXCL/RHIi6T70pvBCCilM0/1UCtyahOqUFRAqYobsuCkXdKcTLrRc8/DDqQ2qnvg== X-Received: by 2002:a05:6a00:1887:b0:588:cb81:9274 with SMTP id x7-20020a056a00188700b00588cb819274mr50576163pfh.32.1674719660555; Wed, 25 Jan 2023 23:54:20 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id o125-20020a62cd83000000b00575fbe1cf2esm333017pfg.109.2023.01.25.23.54.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 25 Jan 2023 23:54:19 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Message-Id: <8E212F23-55C2-49AB-8753-90BA6C2B4EAF@gmail.com> Date: Wed, 25 Jan 2023 23:54:08 -0800 X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > Mohammed Sadiq writes: > >> The following code has broken indentation with c-ts-mode: >> >> while (true) >> if (true) { >> puts ("Hello"); >> } >> >> if (true) >> if (true) >> { >> puts ("World"); >> } >> >> For which, I expect to get the following indentation (with default = config): >> >> while (true) >> if (true) { >> puts ("Hello"); >> } >> >> if (true) >> if (true) >> { >> puts ("World"); >> } >> >> > > Thanks, Mohammed! > > Yuan, I'm not sure the new brace counting method is a good enough > improvement just yet considering its complexity and the number of = issues > we are seeing. Do you see any simple fixes for these issues? I fixed it. > I can try to debug this this weekend, but not sure I really have time = to > fix it. All of these issues work fine in js-ts-mode or java-ts-mode, = if > I'm not mistaken. Yes, because js and java doesn=E2=80=99t allow omitting brackets. So we = only need to add a special-case for C/C++, so it isn=E2=80=99t too bad. Yuan From unknown Fri Jun 13 10:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 26 Jan 2023 07:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: Mohammed Sadiq , 61026@debbugs.gnu.org Received: via spool by 61026-submit@debbugs.gnu.org id=B61026.167471984822952 (code B ref 61026); Thu, 26 Jan 2023 07:58:01 +0000 Received: (at 61026) by debbugs.gnu.org; 26 Jan 2023 07:57:28 +0000 Received: from localhost ([127.0.0.1]:60559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKx8S-0005y8-5l for submit@debbugs.gnu.org; Thu, 26 Jan 2023 02:57:28 -0500 Received: from out0.migadu.com ([94.23.1.103]:46376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pKx8Q-0005xz-59 for 61026@debbugs.gnu.org; Thu, 26 Jan 2023 02:57:27 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1674719844; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U8h1CqsN2i4xN7tp8azZkpDqR1rdF6YD/YQayD/ChSI=; b=c9xWUdcmfCwSoOCCv0Ac21L60za6qYM5QHprRM0BKQXM3cE0wsg3QObieCCsEwVoX4sN1m 58hpSWxD+fEEMrTDLiBOGlKa3OYP7q5W/oSOPJd2x/l5ZQeysJM2xIM45C1MZ+k/1d2wIU 3ezVkGM5kzhuXXbkwaYfEMwtDOVYPQzxB6UpMukrU8z8yepIJcGXVR86skOorGHR1USMBE Fe0FSkjXIkPwhqHCyfSy7nnN1OwJbng1KhD9Yq+Sb27C5X9WcVd1zJMvDDtyExezUpitc5 8F3wvXdMFOTos5ymQRIQLRSfrpB+ThQoMOtv/AyESITIHn4tbP1qpPolPXxtgQ== From: Theodor Thornhill In-Reply-To: <8E212F23-55C2-49AB-8753-90BA6C2B4EAF@gmail.com> References: <8E212F23-55C2-49AB-8753-90BA6C2B4EAF@gmail.com> Date: Thu, 26 Jan 2023 08:57:23 +0100 Message-ID: <878rhphgnw.fsf@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Yuan Fu writes: > Theodor Thornhill writes: > >> Mohammed Sadiq writes: >> >>> The following code has broken indentation with c-ts-mode: >>> >>> while (true) >>> if (true) { >>> puts ("Hello"); >>> } >>> >>> if (true) >>> if (true) >>> { >>> puts ("World"); >>> } >>> >>> For which, I expect to get the following indentation (with default conf= ig): >>> >>> while (true) >>> if (true) { >>> puts ("Hello"); >>> } >>> >>> if (true) >>> if (true) >>> { >>> puts ("World"); >>> } >>> >>> >> >> Thanks, Mohammed! >> >> Yuan, I'm not sure the new brace counting method is a good enough >> improvement just yet considering its complexity and the number of issues >> we are seeing. Do you see any simple fixes for these issues? > > I fixed it. > >> I can try to debug this this weekend, but not sure I really have time to >> fix it. All of these issues work fine in js-ts-mode or java-ts-mode, if >> I'm not mistaken. > > Yes, because js and java doesn=E2=80=99t allow omitting brackets. So we o= nly > need to add a special-case for C/C++, so it isn=E2=80=99t too bad. > > Yuan They allow that just fine, don't they?=20 From unknown Fri Jun 13 10:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace References: In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 08:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Theodor Thornhill Cc: Mohammed Sadiq , 61026@debbugs.gnu.org Received: via spool by 61026-submit@debbugs.gnu.org id=B61026.16749805706113 (code B ref 61026); Sun, 29 Jan 2023 08:23:01 +0000 Received: (at 61026) by debbugs.gnu.org; 29 Jan 2023 08:22:50 +0000 Received: from localhost ([127.0.0.1]:42235 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM2xe-0001aX-D4 for submit@debbugs.gnu.org; Sun, 29 Jan 2023 03:22:50 -0500 Received: from mail-pf1-f174.google.com ([209.85.210.174]:36845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM2xa-0001aD-4P for 61026@debbugs.gnu.org; Sun, 29 Jan 2023 03:22:48 -0500 Received: by mail-pf1-f174.google.com with SMTP id n2so5823197pfo.3 for <61026@debbugs.gnu.org>; Sun, 29 Jan 2023 00:22:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=7el4vOMa0N/FCfrWoYL4LXaPdjo91+fVJdU4JphD8vw=; b=oNQ/udfBw9lw8XDnQYpeUFcy/PnachL+VMgcEbuoDiitXHKCyRxfx96ZLpSC7guKyY ++xWFjZnN1Sv0GxUbqvdpmDdyyPHLjQoWKzDz3JnIri4cTVbZoPLAXSy/K53sc+xf4yu naVy0VORrX5nTp2+lQ2ctNft9ug5OARFUsVpNd94PL2EX37QRc1OP7lGjdXlXtENrRPO fecVm5gPBKckk9z96v+lZ2H0FSCyK/oJQPtKN6zSghAdk4FMfmx46Q2YXBx9K31Bo6iH Fu1GjpGB4H6dwJtQVc+54NaTWbybMsTqhSYOTm3DlJFUyubASJmrihORbAv/W2nfoSID Slaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7el4vOMa0N/FCfrWoYL4LXaPdjo91+fVJdU4JphD8vw=; b=4vtZ5GYVYbwWjvY0NtBfF75MJlfQx/3v8W+JZq4dj7IiAi61Vgtl7QgoIKJPKqn4lm en5hC+LVSuRVh2hc98Z1NZ4MiWkalH1FNKNtLB5nWrFzt86pT4xWMryQyX9i5ntMIfRC ADSYefvId8tYWA8inizzK72g9MujvOgkf4TpZw0Ea537r2aOeWd4O1VfvooATjksdmEB eqrYoS2wsvhnGgsO4n6UW+IqvC+3nTQret9oi3953D0KzLuWByuvpNyVU7ZrSeKtEvjo +dgZCPTLIeHLIFc7FXDTQMgS8AJMde+d7hQoLMt8Z6gYj16toAVzcvyc2euPpcrUGfO4 7DDQ== X-Gm-Message-State: AFqh2kp9NjVdem7V9WUwFBzVhePWhgfREbZt12iA17RFF6hIB/F3NZHb WPYcdFHpVgutdVwWE8rCRKs= X-Google-Smtp-Source: AMrXdXuEMTGeFeGfuhtRZ6uIV4Vj3jnZsZ92nLWTb7OeJ83mL+otsn9NYGG3rtCNSGIDpQd0H5PHGw== X-Received: by 2002:a05:6a00:1da0:b0:58d:f607:52f7 with SMTP id z32-20020a056a001da000b0058df60752f7mr37794746pfw.12.1674980560201; Sun, 29 Jan 2023 00:22:40 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id x3-20020aa79403000000b00593b9a626dcsm275945pfo.6.2023.01.29.00.22.39 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 Jan 2023 00:22:39 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Message-Id: <68C0658F-BA18-4DEE-84AC-035A85AFCE36@gmail.com> Date: Sun, 29 Jan 2023 00:22:26 -0800 X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Theodor Thornhill writes: > Yuan Fu writes: > >> Theodor Thornhill writes: >> >>> Mohammed Sadiq writes: >>> >>>> The following code has broken indentation with c-ts-mode: >>>> >>>> while (true) >>>> if (true) { >>>> puts ("Hello"); >>>> } >>>> >>>> if (true) >>>> if (true) >>>> { >>>> puts ("World"); >>>> } >>>> >>>> For which, I expect to get the following indentation (with default = config): >>>> >>>> while (true) >>>> if (true) { >>>> puts ("Hello"); >>>> } >>>> >>>> if (true) >>>> if (true) >>>> { >>>> puts ("World"); >>>> } >>>> >>>> >>> >>> Thanks, Mohammed! >>> >>> Yuan, I'm not sure the new brace counting method is a good enough >>> improvement just yet considering its complexity and the number of = issues >>> we are seeing. Do you see any simple fixes for these issues? >> >> I fixed it. >> >>> I can try to debug this this weekend, but not sure I really have = time to >>> fix it. All of these issues work fine in js-ts-mode or = java-ts-mode, if >>> I'm not mistaken. >> >> Yes, because js and java doesn=E2=80=99t allow omitting brackets. So = we only >> need to add a special-case for C/C++, so it isn=E2=80=99t too bad. >> >> Yuan > > They allow that just fine, don't they?=20 You are right. I made the fix general and moved everything to c-ts-common.el. The next step is to make other modes use it. Yuan From unknown Fri Jun 13 10:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Jan 2023 08:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: Mohammed Sadiq , 61026@debbugs.gnu.org Received: via spool by 61026-submit@debbugs.gnu.org id=B61026.16749825539630 (code B ref 61026); Sun, 29 Jan 2023 08:56:01 +0000 Received: (at 61026) by debbugs.gnu.org; 29 Jan 2023 08:55:53 +0000 Received: from localhost ([127.0.0.1]:42282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM3Tc-0002VG-J3 for submit@debbugs.gnu.org; Sun, 29 Jan 2023 03:55:52 -0500 Received: from out2.migadu.com ([188.165.223.204]:29445) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pM3TY-0002V4-6B for 61026@debbugs.gnu.org; Sun, 29 Jan 2023 03:55:51 -0500 Date: Sun, 29 Jan 2023 09:55:42 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1674982546; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=W321pN3FzrWBpfTMRueiEEp60SOUSVu/dnnzLljmEx4=; b=BzTFd4C/sJN4/HjCksEAebst01ZYJkZkkTkl2f5hn8W5IgDPvJp9oMI8bQYyzypm5WFIOo bi9dsocX8wf5LCWs+38ubnmlbLdBxMmOb7aYvSM2K+Y6oXhY3SjoNWYefGi6RWOp44dsZR ClJB8vTegFWbLGi+d4hSJ6VnR8DthLzusLtNsJKQZZRfhdGbqI2BUdK5HQmmqlGHS50vqu vIwgWWui3K9BqjJL44ZWyA2ejVlANWb/XCfhqZzDwZPpidUywv2T26U+aVgElpTE3oexEf NM8orRdQKnEFgBDc+nOV+ZoJXiSKU/Tl4itqekiaqS6f7GERd1cOTWnbd+Kb6w== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill In-Reply-To: <68C0658F-BA18-4DEE-84AC-035A85AFCE36@gmail.com> References: <68C0658F-BA18-4DEE-84AC-035A85AFCE36@gmail.com> Message-ID: <1A70D229-1DCF-449D-A2F2-6003CA907039@thornhill.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 29 January 2023 09:22:26 CET, Yuan Fu wrote: > >Theodor Thornhill writes: > >> Yuan Fu writes: >> >>> Theodor Thornhill writes: >>> >>>> Mohammed Sadiq writes: >>>> >>>>> The following code has broken indentation with c-ts-mode: >>>>> >>>>> while (true) >>>>> if (true) { >>>>> puts ("Hello"); >>>>> } >>>>> >>>>> if (true) >>>>> if (true) >>>>> { >>>>> puts ("World"); >>>>> } >>>>> >>>>> For which, I expect to get the following indentation (with default c= onfig): >>>>> >>>>> while (true) >>>>> if (true) { >>>>> puts ("Hello"); >>>>> } >>>>> >>>>> if (true) >>>>> if (true) >>>>> { >>>>> puts ("World"); >>>>> } >>>>> >>>>> >>>> >>>> Thanks, Mohammed! >>>> >>>> Yuan, I'm not sure the new brace counting method is a good enough >>>> improvement just yet considering its complexity and the number of iss= ues >>>> we are seeing=2E Do you see any simple fixes for these issues? >>> >>> I fixed it=2E >>> >>>> I can try to debug this this weekend, but not sure I really have time= to >>>> fix it=2E All of these issues work fine in js-ts-mode or java-ts-mod= e, if >>>> I'm not mistaken=2E >>> >>> Yes, because js and java doesn=E2=80=99t allow omitting brackets=2E So= we only >>> need to add a special-case for C/C++, so it isn=E2=80=99t too bad=2E >>> >>> Yuan >> >> They allow that just fine, don't they?=20 > >You are right=2E I made the fix general and moved everything to >c-ts-common=2Eel=2E The next step is to make other modes use it=2E > >Yuan Nice! From unknown Fri Jun 13 10:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace References: In-Reply-To: Resent-From: Knut Anders Hatlen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Feb 2023 20:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 61026@debbugs.gnu.org Received: via spool by 61026-submit@debbugs.gnu.org id=B61026.167562917928857 (code B ref 61026); Sun, 05 Feb 2023 20:33:01 +0000 Received: (at 61026) by debbugs.gnu.org; 5 Feb 2023 20:32:59 +0000 Received: from localhost ([127.0.0.1]:46558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOlh3-0007VM-O2 for submit@debbugs.gnu.org; Sun, 05 Feb 2023 15:32:58 -0500 Received: from mail-ej1-f49.google.com ([209.85.218.49]:41962) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOlgz-0007V3-0Y for 61026@debbugs.gnu.org; Sun, 05 Feb 2023 15:32:54 -0500 Received: by mail-ej1-f49.google.com with SMTP id m2so28906049ejb.8 for <61026@debbugs.gnu.org>; Sun, 05 Feb 2023 12:32:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=lHW/4VoeCVe48Aq06T/y5Ccj4cTgeaIhoB0j2AgXJAU=; b=HN3Cqsl+uWxZZvsmpICZjuMqLORfjehCmC5Ds6rIcsVRYbjxW+zPAObQrejx+fECad VVwgImBEDab1BIi2Flz/gARgzJaHrAgfVZLvOj21CCLOlu0m93Jx11oD84zhTfsV4w4C c1iiy5/i+9SeQHtoqg/XEp6GNB1bsa5hu8xgvR1pzYNwlHHdAtyGSGUTL7oNilQ3oHwH dOdntB/HEfvyAHpecnm8IgbKZcR10LuHk7BU5EIfg9FPYdUeXgX/Y+jGMFNTZqDG0B9F OAztLQQq8fwV8q4cug9vjq/4aXh9D408eTMCTFmjSSwijEC1n9RhlJvgFDN1CAws5L5u AroQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lHW/4VoeCVe48Aq06T/y5Ccj4cTgeaIhoB0j2AgXJAU=; b=fEf1Xk4zFwE959S3/ZtiVxJifOgT3md8VPZHsyPKTFc6UvyWTsDf0PbX5eoFfqnff9 kywHL6sCeQrBTnSXpuIpQHwmtZyOIp4LpHmFGxEJ43+M4g/mTHm307vXYGNY24QhLKjd SkC7Nu1RsET5FwB392zNKzbaSodCZiYAnmj7uZFTX4loqAdqmOn/JDuqgueitm5WfWtg 448CV/KbJcra/ZKaHpu8NV54RhxAB67VKBOG63LQNZvtwjG1p6L/kbG0NVnn2lC48N+5 q0sGW5WfK4zzyMCUVOTRhDyTZKo5ZpMYo3fOz9Dwve9BmUp5TUrpvZHXKeI+SX+THsYk xdig== X-Gm-Message-State: AO0yUKVEjqG1JTmSsCGFhIHvK8CRHbxtOs+7EIKkvJ3ePfNQDLQ/EAjc eWBEo0ouzeHvBgZc5SePsj6sBvdANMPB X-Google-Smtp-Source: AK7set9ws9BCrkSUV0VyKT677ww5UhKCuWVxDJHQm3GvKB2lLhmgjrwY2vHmI/dSXqz/Y/RPUhti/A== X-Received: by 2002:a17:907:6eab:b0:88d:ba89:182f with SMTP id sh43-20020a1709076eab00b0088dba89182fmr14222555ejc.0.1675629166886; Sun, 05 Feb 2023 12:32:46 -0800 (PST) Received: from dell ([2a02:2121:6b1:b9d:6dbe:69a1:124b:c49e]) by smtp.gmail.com with ESMTPSA id lt14-20020a170906fa8e00b00880dbd4b6d7sm4568674ejb.170.2023.02.05.12.32.45 for <61026@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Feb 2023 12:32:46 -0800 (PST) From: Knut Anders Hatlen Date: Sun, 05 Feb 2023 21:32:44 +0100 Message-ID: <871qn3am4z.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, I'm still seeing odd indentation for conditions without braces. For example, invoking c-ts-mode-indent-defun (C-c C-q) with the point inside this function ... int f(int x) { if (x > 1) return x; else return x + 1; } ... results in the following indentation with the default GNU style: int f(int x) { if (x > 1) return x; else return x + 1; } I would have expected this: int f(int x) { if (x > 1) return x; else return x + 1; } Is something more needed for this bug, or is the problem I'm seeing a different bug? -- Knut Anders From unknown Fri Jun 13 10:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace References: In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Feb 2023 02:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Knut Anders Hatlen Cc: 61026@debbugs.gnu.org Received: via spool by 61026-submit@debbugs.gnu.org id=B61026.167573706221012 (code B ref 61026); Tue, 07 Feb 2023 02:32:02 +0000 Received: (at 61026) by debbugs.gnu.org; 7 Feb 2023 02:31:02 +0000 Received: from localhost ([127.0.0.1]:50539 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPDl7-0005Sp-Q8 for submit@debbugs.gnu.org; Mon, 06 Feb 2023 21:31:02 -0500 Received: from mail-pj1-f46.google.com ([209.85.216.46]:55266) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPDl6-0005SL-Oy for 61026@debbugs.gnu.org; Mon, 06 Feb 2023 21:31:01 -0500 Received: by mail-pj1-f46.google.com with SMTP id mi9so13534234pjb.4 for <61026@debbugs.gnu.org>; Mon, 06 Feb 2023 18:31:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=DFaZUcGa04LuaF+uTl3ABuZVqbyGYxnYAISoccWszm4=; b=J4YkLxZToq7ZaMlLAB1PFoUjpruTc1+DElSmqw05OiNaz8EPeQqQJtXciaxc/QZZWz ooqPlSo8Jga6Uh9tAPmR8fGZs/ahx1Iuv9zXpnzgDX7sAVM71JxgknaXr5ZCk77sjYQZ rPXEQ6zjVwiy0pn/eUAzHOxYLheDYNv2F0jVRiqkIP9nSigU9+jUiKKjEthLYVrnjAu4 b3GSg7jx4FNznoU7KUXp611RkPDE2Q/dUTTPDD3sIE1dwr6Ni7E+VFOS6Els8Oaxc8co f7lwOYzI8COizwXvVdtw1yIDyPg8VhdCqTLy6iIQxrMsREOInJ46sToNwMqVJuquyqHp rLJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DFaZUcGa04LuaF+uTl3ABuZVqbyGYxnYAISoccWszm4=; b=QhY2Gu1CIkZPw8X8LDFiyBLhb5NeNT5WdRtlVpySPEbETRVcqtwqKkGsSPV/vAiXS0 r+Wqjk2DSp7xgISMxmdJymM7TFRlQSI4FQtV14VyYW6hOJzPPHP7HLaV7GlGy2mAm/gG augUZgP5g/XRjMPJ/pLsQg8oGB1Qfr6NbwRyJ2SoHFbm6yrCnUHnJ0H73j+Fgf/gA4/n 1lqMP5yqbVqi85veYExS819IYou6FaV268ajsBF35T8wBqsttYCWoqdvd+EaCsa3fsGh QhrxFT2krBTuYjBjITMseCQM7xzcoH3neeh5PvyZ1CP5MOhZ8ueCVN6jX99E80Pakfkq IfEg== X-Gm-Message-State: AO0yUKVwZ/OIBNTLipsQiv4UbceTeDnKveekDs9Omzg5Hn6Jvk8ic5CU enrM9KkwEaDLQjRMHI2DrQw= X-Google-Smtp-Source: AK7set+3pnmsNieka+yStoLinTvCenkD37eCwdD5VXz+j0HYNANGNy3LGAxLxb40xze6GGk40qpLzA== X-Received: by 2002:a17:903:283:b0:199:ccf:d94 with SMTP id j3-20020a170903028300b001990ccf0d94mr1356701plr.61.1675737054920; Mon, 06 Feb 2023 18:30:54 -0800 (PST) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id ju5-20020a170903428500b00198e7d97171sm6345696plb.128.2023.02.06.18.30.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Feb 2023 18:30:54 -0800 (PST) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Message-Id: Date: Mon, 6 Feb 2023 18:30:43 -0800 X-Mailer: Apple Mail (2.3731.300.101.1.3) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Knut Anders Hatlen writes: > Hi, > > I'm still seeing odd indentation for conditions without braces. For > example, invoking c-ts-mode-indent-defun (C-c C-q) with the point = inside > this function ... > > int f(int x) { > if (x > 1) > return x; > else > return x + 1; > } > > ... results in the following indentation with the default GNU style: > > int f(int x) { > if (x > 1) > return x; > else > return x + 1; > } > > I would have expected this: > > int f(int x) { > if (x > 1) > return x; > else > return x + 1; > } > > Is something more needed for this bug, or is the problem I'm seeing a > different bug? My bad, I made some changes and didn=E2=80=99t push them, and I=E2=80=99m = sitting here wondering why everyone is seeing problems... Everything should indent fine now. Yuan From unknown Fri Jun 13 10:56:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#61026: 29.0.60; c-ts-mode: Broken indentation for loops and conditions without brace Resent-From: Knut Anders Hatlen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Feb 2023 10:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61026 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: 61026@debbugs.gnu.org Received: via spool by 61026-submit@debbugs.gnu.org id=B61026.16757664963019 (code B ref 61026); Tue, 07 Feb 2023 10:42:01 +0000 Received: (at 61026) by debbugs.gnu.org; 7 Feb 2023 10:41:36 +0000 Received: from localhost ([127.0.0.1]:51147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPLPs-0000mc-5a for submit@debbugs.gnu.org; Tue, 07 Feb 2023 05:41:36 -0500 Received: from mail-yb1-f178.google.com ([209.85.219.178]:42825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPLPq-0000mL-13 for 61026@debbugs.gnu.org; Tue, 07 Feb 2023 05:41:34 -0500 Received: by mail-yb1-f178.google.com with SMTP id a1so17984334ybj.9 for <61026@debbugs.gnu.org>; Tue, 07 Feb 2023 02:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5p4SUvnADP2z4FkvSkyrD1+nvWtXaLj8oDNcrxBJg+w=; b=Pmcz2lf6zHc9m8YGlzuA8vkc0xui6hKUVGlkC2jY1aPtwzgtOvc05LoAEz3a/K4SMi bRrDs+6JxNVk1mP0n4GjFdF4z3It7rVrJUYeXW5UvrcQS+2Mh5xJJBpcMNqRA20stJqf EHNX90/BP95rOVAxpey4sOE35THOkdVnQDst3x98aB/ExdNAqv3p2lr3sI0YXyk34nrH S8MqPNTl+Wle0l//Vw6UkqBOj6Br2jEktnI0Rrm6Fjqu36kn/L6OVJ4RePgAUL8FSHj8 oXW+OGJoDF67kxXOQra4FKgxgB5MB6qDx8Xmn/O5dBdC+5ytNDYXYQMQXlFXbQuRQ8ac kMqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5p4SUvnADP2z4FkvSkyrD1+nvWtXaLj8oDNcrxBJg+w=; b=oMMAA5jf95Fi5hA6FP4ZPZhHcRwrRqAs6wKqbsEp79AU8+ALyaBr6UuZADoMc/A5d+ WbZVR14z/fAp5++f8NYIThRARnwKGTtfGqRoCxE2Z28yXFJFIwTypGcMb58o3KOu3/9N WWl6vNxtRHw217xsmO6PLIYTMSM4DWawec8aAaEyFc68rgePFlxFL4BDZ0KpGsp//3T+ 1b2OVvjLs1bS4qvnVJQBDQjimKvrXwW4NT0grpSFuCXOhKPvAQHcS90FdTOF5UoxRXdJ vpgAf7gk4YQkNu02UdSumF7RyuVOHTznnp9HkZ1tsY3GtV6mM5yaS2S838tR4+n0uPzx jqpw== X-Gm-Message-State: AO0yUKVqKQIRV/u9WIFiSiIdsITK3GvmyXikZRFdqmQzQ+o9r1ln818M S2l9rDFjgWZYUw7tJT8nPNAxaoI142CAFQEN5g== X-Google-Smtp-Source: AK7set90aC4l25CKNBVvz8M7XcASg/40wNwKnDo45BcVexLuRq9Z71Rc31+6VqymiUi/ZcQtSHDgbKmNcGFb6d783Fc= X-Received: by 2002:a5b:4cf:0:b0:87d:c01e:2205 with SMTP id u15-20020a5b04cf000000b0087dc01e2205mr454323ybp.179.1675766488212; Tue, 07 Feb 2023 02:41:28 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Knut Anders Hatlen Date: Tue, 7 Feb 2023 11:41:17 +0100 Message-ID: Content-Type: multipart/alternative; boundary="00000000000041a89905f419ca29" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000041a89905f419ca29 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable tir. 7. feb. 2023 kl. 03:30 skrev Yuan Fu : > > Knut Anders Hatlen writes: > > > Hi, > > > > I'm still seeing odd indentation for conditions without braces. For > > example, invoking c-ts-mode-indent-defun (C-c C-q) with the point insid= e > > this function ... > > > > int f(int x) { > > if (x > 1) > > return x; > > else > > return x + 1; > > } > > > > ... results in the following indentation with the default GNU style: > > > > int f(int x) { > > if (x > 1) > > return x; > > else > > return x + 1; > > } > > > > I would have expected this: > > > > int f(int x) { > > if (x > 1) > > return x; > > else > > return x + 1; > > } > > > > Is something more needed for this bug, or is the problem I'm seeing a > > different bug? > > My bad, I made some changes and didn=E2=80=99t push them, and I=E2=80=99m= sitting here > wondering why everyone is seeing problems... Everything should indent > fine now. > > Yuan > Thanks, Yuan! It now seems to work fine with the GNU style, K&R style and Linux style. With BSD style, however, it ends up like this: int f(int x) { if (x > 1) return x; else return x + 1; } I assume the return statements should have been indented one more level here too? Best regards, --=20 Knut Anders --00000000000041a89905f419ca29 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
tir. 7. feb. 2023 kl. 03:30 skrev Yuan Fu <casouri@gmail.com>:

Knut Anders Hatlen <kahatlen@gmail.com> writes:

> Hi,
>
> I'm still seeing odd indentation for conditions without braces. Fo= r
> example, invoking c-ts-mode-indent-defun (C-c C-q) with the point insi= de
> this function ...
>
> int f(int x) {
> if (x > 1)
> return x;
> else
> return x + 1;
> }
>
> ... results in the following indentation with the default GNU style: >
> int f(int x) {
>=C2=A0 =C2=A0if (x > 1)
> return x;
>=C2=A0 =C2=A0else
> return x + 1;
> }
>
> I would have expected this:
>
> int f(int x) {
>=C2=A0 =C2=A0if (x > 1)
>=C2=A0 =C2=A0 =C2=A0return x;
>=C2=A0 =C2=A0else
>=C2=A0 =C2=A0 =C2=A0return x + 1;
> }
>
> Is something more needed for this bug, or is the problem I'm seein= g a
> different bug?

My bad, I made some changes and didn=E2=80=99t push them, and I=E2=80=99m s= itting here
wondering why everyone is seeing problems... Everything should indent
fine now.

Yuan

Thanks, Yuan!

It now seems to work fine with the GNU style, K&R style and Linux st= yle. With BSD style, however, it ends up like this:

int f(int x) {
=C2=A0 if (x > 1)
=C2=A0 return x;
=C2=A0 else=
=C2=A0 return x + 1;
}

I assume the return = statements should have been indented one more level here too?

Best regards,

--
Knut Anders
--00000000000041a89905f419ca29--