GNU bug report logs - #61010
[PATCH] gnu: Add icewm

Previous Next

Full log

View this message in rfc822 format

From: Andy Tai <atai <at> atai.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 61010 <at> debbugs.gnu.org
Subject: [bug#61010] [PATCH] gnu: Add icewm
Date: Tue, 24 Jan 2023 23:37:45 -0800

[Message part 1 (text/plain, inline)]

updated patch  attached


On Tue, Jan 24, 2023 at 4:35 AM Simon Tournier <zimon.toutoune <at> gmail.com> wrote:
>
> The patch builds fine and it LTGM except one minor point.
>
> On dim., 22 janv. 2023 at 12:37, Andy Tai <atai <at> atai.org> wrote:
>
> This archive contains generated .gmo which are not in the source code
> [1] and I do not know what is the usual Guix policy about that.  Do we
> re-generate them?
>
> Other said, these files are in the archive tar.gz [2].
>
> 1: <https://github.com/ice-wm/icewm/tree/3.3.1/po>
> 2: <https://github.com/ice-wm/icewm/archive/refs/tags/3.3.1.tar.gz>
>

This I did not address in the revision because the second .tar.gz is
available on the net, satisfying GPL's source requirement... but will
revise if Guix policy demands otherwise
>
> > \ No newline at end of file
>
> This patch does not apply to current master.  From my point of view, it
> is worth to provide the base-commit (see --base option of
> git-format-patch or git-send-email).
>
> And it helps if the new package is not added to the end of the file.
> For instance, I would put it between i3lock-fancy and xmonad-next.
>

addressed as suggested
>
> Cheers,
> simon

[0001-gnu-Add-icewm.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.