From unknown Sat Aug 09 13:08:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6100 <6100@debbugs.gnu.org> To: bug#6100 <6100@debbugs.gnu.org> Subject: Status: c-beginning-of-defun doesn't push mark Reply-To: bug#6100 <6100@debbugs.gnu.org> Date: Sat, 09 Aug 2025 20:08:35 +0000 retitle 6100 c-beginning-of-defun doesn't push mark reassign 6100 emacs,cc-mode submitter 6100 Juri Linkov severity 6100 minor tag 6100 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Tue May 04 12:23:08 2010 Received: (at submit) by debbugs.gnu.org; 4 May 2010 16:23:08 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9Kto-0000mp-8V for submit@debbugs.gnu.org; Tue, 04 May 2010 12:23:08 -0400 Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9Ktm-0000mN-Ri for submit@debbugs.gnu.org; Tue, 04 May 2010 12:23:07 -0400 Received: from lists.gnu.org ([199.232.76.165]:39556) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1O9Kth-0003mn-V8 for submit@debbugs.gnu.org; Tue, 04 May 2010 12:23:02 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O9Ktg-00022C-U0 for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:23:01 -0400 Received: from [140.186.70.92] (port=41065 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O9Ktb-0001wy-N3 for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:22:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O9Kta-00086u-80 for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:22:55 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3]:49317 helo=mx1.starman.ee) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9Kta-00086F-2U for bug-gnu-emacs@gnu.org; Tue, 04 May 2010 12:22:54 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.30.129.cable.starman.ee [82.131.30.129]) by mx1.starman.ee (Postfix) with ESMTP id 1F4E23F40FE for ; Tue, 4 May 2010 19:22:48 +0300 (EEST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: c-beginning-of-defun doesn't push mark Organization: JURTA Date: Tue, 04 May 2010 19:01:45 +0300 Message-ID: <87mxwf942y.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.0 (-----) There is one annoying difference between `beginning-of-defun' and `c-beginning-of-defun': `beginning-of-defun' and `end-of-defun' pushes the mark for the old point location to the mark ring with this code: (or (not (eq this-command 'beginning-of-defun)) (eq last-command 'beginning-of-defun) (and transient-mark-mode mark-active) (push-mark)) but `c-beginning-of-defun' doesn't do that. This patch add the same code to `c-beginning-of-defun' and `c-end-of-defun': === modified file 'lisp/progmodes/cc-cmds.el' --- lisp/progmodes/cc-cmds.el 2010-04-19 15:07:52 +0000 +++ lisp/progmodes/cc-cmds.el 2010-05-04 16:01:05 +0000 @@ -1501,6 +1501,11 @@ (defun c-beginning-of-defun (&optional a (interactive "p") (or arg (setq arg 1)) + (or (not (eq this-command 'c-beginning-of-defun)) + (eq last-command 'c-beginning-of-defun) + (and transient-mark-mode mark-active) + (push-mark)) + (c-save-buffer-state (beginning-of-defun-function end-of-defun-function (start (point)) @@ -1604,6 +1609,11 @@ (defun c-end-of-defun (&optional arg) (interactive "p") (or arg (setq arg 1)) + (or (not (eq this-command 'c-end-of-defun)) + (eq last-command 'c-end-of-defun) + (and transient-mark-mode mark-active) + (push-mark)) + (c-save-buffer-state (beginning-of-defun-function end-of-defun-function (start (point)) -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 09:16:33 2010 Received: (at 6100) by debbugs.gnu.org; 5 May 2010 13:16:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9eSn-0004gd-7g for submit@debbugs.gnu.org; Wed, 05 May 2010 09:16:33 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9eSl-0004gW-U7 for 6100@debbugs.gnu.org; Wed, 05 May 2010 09:16:32 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAOsM4UvO+IB1/2dsb2JhbACdRHK+C4UTBIwu X-IronPort-AV: E=Sophos;i="4.52,333,1270440000"; d="scan'208";a="63446248" Received: from 206-248-128-117.dsl.teksavvy.com (HELO alfajor.home) ([206.248.128.117]) by ironport2-out.pppoe.ca with ESMTP; 05 May 2010 09:16:26 -0400 Received: by alfajor.home (Postfix, from userid 20848) id C4051AF29E; Wed, 5 May 2010 09:16:25 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#6100: c-beginning-of-defun doesn't push mark Message-ID: References: <87mxwf942y.fsf@mail.jurta.org> Date: Wed, 05 May 2010 09:16:25 -0400 In-Reply-To: <87mxwf942y.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 04 May 2010 19:01:45 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 6100 Cc: 6100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > There is one annoying difference between `beginning-of-defun' > and `c-beginning-of-defun': > `beginning-of-defun' and `end-of-defun' pushes the mark for the > old point location to the mark ring with this code: > (or (not (eq this-command 'beginning-of-defun)) > (eq last-command 'beginning-of-defun) > (and transient-mark-mode mark-active) > (push-mark)) > but `c-beginning-of-defun' doesn't do that. > This patch add the same code to `c-beginning-of-defun' and `c-end-of-defun': Of course, I'd argue that the right fix is to use `beginning-of-defun'. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 14:28:55 2010 Received: (at 6100) by debbugs.gnu.org; 5 May 2010 18:28:55 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9jL4-00077u-Ac for submit@debbugs.gnu.org; Wed, 05 May 2010 14:28:55 -0400 Received: from smtp-out1.starman.ee ([85.253.0.3] helo=mx1.starman.ee) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9jL2-00077n-PF for 6100@debbugs.gnu.org; Wed, 05 May 2010 14:28:53 -0400 X-Virus-Scanned: by Amavisd-New at mx1.starman.ee Received: from mail.starman.ee (82.131.29.84.cable.starman.ee [82.131.29.84]) by mx1.starman.ee (Postfix) with ESMTP id 0CE2C3F4133; Wed, 5 May 2010 21:28:44 +0300 (EEST) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#6100: c-beginning-of-defun doesn't push mark Organization: JURTA References: <87mxwf942y.fsf@mail.jurta.org> Date: Wed, 05 May 2010 21:28:32 +0300 In-Reply-To: (Stefan Monnier's message of "Wed, 05 May 2010 09:16:25 -0400") Message-ID: <87k4rimcdr.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 6100 Cc: 6100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) >> There is one annoying difference between `beginning-of-defun' >> and `c-beginning-of-defun': > >> `beginning-of-defun' and `end-of-defun' pushes the mark for the >> old point location to the mark ring with this code: > >> (or (not (eq this-command 'beginning-of-defun)) >> (eq last-command 'beginning-of-defun) >> (and transient-mark-mode mark-active) >> (push-mark)) > >> but `c-beginning-of-defun' doesn't do that. > >> This patch add the same code to `c-beginning-of-defun' and `c-end-of-defun': > > Of course, I'd argue that the right fix is to use `beginning-of-defun'. Do you mean cc-mode should use `beginning-of-defun-function'? -- Juri Linkov http://www.jurta.org/emacs/ From debbugs-submit-bounces@debbugs.gnu.org Wed May 05 16:29:50 2010 Received: (at 6100) by debbugs.gnu.org; 5 May 2010 20:29:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9lE6-00084T-HM for submit@debbugs.gnu.org; Wed, 05 May 2010 16:29:50 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9lE4-00084K-F7 for 6100@debbugs.gnu.org; Wed, 05 May 2010 16:29:48 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAK5x4UvO+IB1/2dsb2JhbACdUnK+fIUTBIws X-IronPort-AV: E=Sophos;i="4.52,335,1270440000"; d="scan'208";a="63501385" Received: from 206-248-128-117.dsl.teksavvy.com (HELO pastel.home) ([206.248.128.117]) by ironport2-out.pppoe.ca with ESMTP; 05 May 2010 16:29:44 -0400 Received: by pastel.home (Postfix, from userid 20848) id DBAC5814C; Wed, 5 May 2010 16:29:43 -0400 (EDT) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#6100: c-beginning-of-defun doesn't push mark Message-ID: References: <87mxwf942y.fsf@mail.jurta.org> <87k4rimcdr.fsf@mail.jurta.org> Date: Wed, 05 May 2010 16:29:43 -0400 In-Reply-To: <87k4rimcdr.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 05 May 2010 21:28:32 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 6100 Cc: 6100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > Do you mean cc-mode should use `beginning-of-defun-function'? AFAIK it already does, so just using the beginning-of-defun command should DTRT. Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu May 06 06:46:15 2010 Received: (at 6100) by debbugs.gnu.org; 6 May 2010 10:46:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9yas-0000kC-K9 for submit@debbugs.gnu.org; Thu, 06 May 2010 06:46:14 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O9yaq-0000k7-3e for 6100@debbugs.gnu.org; Thu, 06 May 2010 06:46:13 -0400 Received: (qmail 78649 invoked by uid 3782); 6 May 2010 10:46:05 -0000 Received: from acm.muc.de (pD9E2229E.dip.t-dialin.net [217.226.34.158]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Thu, 06 May 2010 12:45:22 +0200 Received: (qmail 4791 invoked by uid 1000); 6 May 2010 10:54:33 -0000 Date: Thu, 6 May 2010 10:54:33 +0000 To: Juri Linkov Subject: Re: bug#6100: c-beginning-of-defun doesn't push mark Message-ID: <20100506105433.GA1366@muc.de> References: <87mxwf942y.fsf@mail.jurta.org> <87k4rimcdr.fsf@mail.jurta.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k4rimcdr.fsf@mail.jurta.org> User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 6100 Cc: Stefan Monnier , 6100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Hi, Juri, On Wed, May 05, 2010 at 09:28:32PM +0300, Juri Linkov wrote: > >> There is one annoying difference between `beginning-of-defun' > >> and `c-beginning-of-defun': > >> `beginning-of-defun' and `end-of-defun' pushes the mark for the > >> old point location to the mark ring with this code: > >> (or (not (eq this-command 'beginning-of-defun)) > >> (eq last-command 'beginning-of-defun) > >> (and transient-mark-mode mark-active) > >> (push-mark)) > >> but `c-beginning-of-defun' doesn't do that. > >> This patch add the same code to `c-beginning-of-defun' and `c-end-of-defun': > > Of course, I'd argue that the right fix is to use `beginning-of-defun'. > Do you mean cc-mode should use `beginning-of-defun-function'? This would be OK. Unfortunately, end-of-defun-function isn't called cleanly. With a C-M-e, {beginning,end}-of-defun-function are often called 4 times. c-end-of-defun, however, already does the Right Thing on its own. c-{beginning,end}-of-defun have a heavy overhead in determining the type of starting position (inside the brace block, inside the function header, etc.) and in locating a top-level brace (at the start) and the start of the header (at the end). This overhead dominates the speed of the functions, which work essentially as fast regardless of how big ARG is. The speed of c-{beginning,end}-of-defun have presented problems from time to time. Quadrupling CC Mode's end-of-defun's runtime doesn't seem a good idea. I want to keep the handling of c-{beginning,end}-of-defun symmetrical for ease of maintenance. I would favour your patch to these defuns which pushes the marks. > Juri Linkov -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Tue May 11 15:22:37 2010 Received: (at 6100) by debbugs.gnu.org; 11 May 2010 19:22:37 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBv2L-0005B7-D5 for submit@debbugs.gnu.org; Tue, 11 May 2010 15:22:37 -0400 Received: from tomts40.bellnexxia.net ([209.226.175.97] helo=tomts40-srv.bellnexxia.net) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBv2J-0005B0-3l for 6100@debbugs.gnu.org; Tue, 11 May 2010 15:22:36 -0400 Received: from toip5.srvr.bell.ca ([209.226.175.88]) by tomts40-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20100511192217.MCTD1888.tomts40-srv.bellnexxia.net@toip5.srvr.bell.ca> for <6100@debbugs.gnu.org>; Tue, 11 May 2010 15:22:17 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAB5F6UtKDMwD/2dsb2JhbACeJnK9BIUQBA Received: from bas1-montreal42-1242352643.dsl.bell.ca (HELO ceviche.home) ([74.12.204.3]) by toip5.srvr.bell.ca with ESMTP; 11 May 2010 15:37:15 -0400 Received: by ceviche.home (Postfix, from userid 20848) id B3F6966773; Tue, 11 May 2010 15:22:10 -0400 (EDT) From: Stefan Monnier To: Alan Mackenzie Subject: Re: bug#6100: c-beginning-of-defun doesn't push mark Message-ID: References: <87mxwf942y.fsf@mail.jurta.org> <87k4rimcdr.fsf@mail.jurta.org> <20100506105433.GA1366@muc.de> Date: Tue, 11 May 2010 15:22:10 -0400 In-Reply-To: <20100506105433.GA1366@muc.de> (Alan Mackenzie's message of "Thu, 6 May 2010 10:54:33 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: 0.6 (/) X-Debbugs-Envelope-To: 6100 Cc: Juri Linkov , 6100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.0 (/) > The speed of c-{beginning,end}-of-defun have presented problems from time > to time. Quadrupling CC Mode's end-of-defun's runtime doesn't seem a > good idea. I want to keep the handling of c-{beginning,end}-of-defun > symmetrical for ease of maintenance. IIUC the speed of those operations has been a problem when called many times within a single command (i.e. the cumulative time became a problem), so it shouldn't be a problem for interactive use where doing it 4 times rather than 1 shouldn't be noticeable. IOW, the problem was algorithmic, but running the same code 4 times makes no difference algorithmically. > I would favour your patch to these defuns which pushes the marks. It's your code, so it's your choice. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 07:12:35 2010 Received: (at 6100) by debbugs.gnu.org; 12 May 2010 11:12:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OC9rf-0003ZC-2l for submit@debbugs.gnu.org; Wed, 12 May 2010 07:12:35 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OC9rd-0003Z7-FF for 6100@debbugs.gnu.org; Wed, 12 May 2010 07:12:34 -0400 Received: (qmail 13478 invoked by uid 3782); 12 May 2010 11:12:27 -0000 Received: from acm.muc.de (pD9E2290D.dip.t-dialin.net [217.226.41.13]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Wed, 12 May 2010 13:12:25 +0200 Received: (qmail 2100 invoked by uid 1000); 12 May 2010 11:21:45 -0000 Date: Wed, 12 May 2010 11:21:45 +0000 To: Stefan Monnier Subject: Re: bug#6100: c-beginning-of-defun doesn't push mark Message-ID: <20100512112144.GA1280@muc.de> References: <87mxwf942y.fsf@mail.jurta.org> <87k4rimcdr.fsf@mail.jurta.org> <20100506105433.GA1366@muc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: 6100 Cc: Juri Linkov , 6100@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) Hi, Stefan and Juri, On Tue, May 11, 2010 at 03:22:10PM -0400, Stefan Monnier wrote: > > I would favour your patch to these defuns which pushes the marks. > It's your code, so it's your choice. I've commited Juri's patch. The mark will now be pushed when appropriate in c-{beginning,end}-of-function. > Stefan -- Alan Mackenzie (Nuremberg, Germany). From debbugs-submit-bounces@debbugs.gnu.org Wed May 12 09:17:12 2010 Received: (at 6100-done) by debbugs.gnu.org; 12 May 2010 13:17:12 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCBoG-00050Y-D6 for submit@debbugs.gnu.org; Wed, 12 May 2010 09:17:12 -0400 Received: from colin.muc.de ([193.149.48.1] helo=mail.muc.de) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OCBoF-00050S-4c for 6100-done@debbugs.gnu.org; Wed, 12 May 2010 09:17:11 -0400 Received: (qmail 26752 invoked by uid 3782); 12 May 2010 13:17:04 -0000 Received: from acm.muc.de (pD9E2290D.dip.t-dialin.net [217.226.41.13]) by colin2.muc.de (tmda-ofmipd) with ESMTP; Wed, 12 May 2010 15:16:42 +0200 Received: (qmail 3695 invoked by uid 1000); 12 May 2010 13:26:03 -0000 Date: Wed, 12 May 2010 13:26:03 +0000 To: 6100-done@debbugs.gnu.org Subject: Fix Message-ID: <20100512132603.GB1280@muc.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.9i X-Delivery-Agent: TMDA/1.1.5 (Fettercairn) From: Alan Mackenzie X-Primary-Address: acm@muc.de X-Spam-Score: -2.5 (--) X-Debbugs-Envelope-To: 6100-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) c-{beginning,end}-of-function now push the mark like beginning-of-defun does. -- Alan Mackenzie (Nuremberg, Germany). From unknown Sat Aug 09 13:08:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 10 Jun 2010 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator