GNU bug report logs - #60997
[patch] gnu: Add python-cmseq, python-cmseq, python-phylophlan and python-metaphlan.

Previous Next

Full log

Message #23 received at 60997 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Mădălin Ionel Patrașcu
 <madalinionel.patrascu <at> mdc-berlin.de>
Cc: 60997 <at> debbugs.gnu.org, debbugs-submit <at> debbugs.gnu.org
Subject: Re: [bug#60997] [PATCH 3/4] gnu: Add python-phylophlan.
Date: Tue, 24 Jan 2023 10:10:20 +0100

Mădălin Ionel Patrașcu <madalinionel.patrascu <at> mdc-berlin.de> writes:

> +    (build-system python-build-system)

Please use pyproject-build-system where possible.

> +    (arguments
> +     (list
> +      #:tests? #f ;pypi no tests

There are no tests, nothing to do with pypi.

> +      #:phases
> +      #~(modify-phases %standard-phases
> +          ;;pypi does not provide the readme.md file
> +          (add-before 'build 'loose-readme-file-requirement
> +           (lambda _
> +              (substitute* "setup.py"
> +                (("long_description")
> +                  "#long_description")))))))

I changed this to just fetch the source from git.

> +    (propagated-inputs
> +     (list python-biopython

This will become a problem down the line when combined with cmseq.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.