GNU bug report logs - #60996
29.0.60; Native compile fails to remove temp file for trampoline

Previous Next

Full log

Message #64 received at 60996 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Andrea Corallo <akrl <at> sdf.org>
Cc: andrewjmoreton <at> gmail.com, 60996 <at> debbugs.gnu.org
Subject: Re: bug#60996: 29.0.60; Native compile fails to remove temp file
 for trampoline
Date: Thu, 26 Jan 2023 22:03:39 +0200

> From: Andrea Corallo <akrl <at> sdf.org>
> Cc: andrewjmoreton <at> gmail.com, 60996 <at> debbugs.gnu.org
> Date: Thu, 26 Jan 2023 19:46:25 +0000
> 
> >> If (as I understand) in Windows we can't delete a mapped file we have a
> >> problem more to solve.
> >
> > Yes.  If this is what happens, then I think we will have to maintain a
> > list of such trampolines, and delete them just before exiting, after
> > calling dynlib_close for them.
> 
> Mmmhh, and what if another Emacs tries to delete or overwrite the same
> file?

This shouldn't happen, since the *.eln files are generated with
make-temp-file.

> But my question is: is this mechanism _really_ necessary?
> 
> >From my POV it's just a kludge that was, is and will be source of
> problems.  Was never clear to me for which specific reason this was
> implemented as, at the time, I had the impression that all Debian
> requirements could be handled with what we already offered.
> 
> At the time I firmly opposed to this change, but I was told by Lars it
> went into master "for discussion" (!?), indeed the review discussion
> never happened...  and now we are left with this present.
> 
> Unless we have a very strong reason to keep it, I believe we should just
> get rid of this mechanism, otherwise it will be source of pain for us
> again and again in the future.

I'll have to refresh my memory about the reasons and the actual
changeset.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.